Fix #13703 by correctly using munged names in ghc-pkg.

Authored by ezyang on May 15 2017, 11:17 PM.

Description

Fix Trac #13703 by correctly using munged names in ghc-pkg.

Summary:
Cabal internal libraries are implemented using a trick, where the 'name'
field in ghc-pkg registration file is munged into a new form to keep
each internal library looking like a distinct package to ghc-pkg and
other tools; e.g. the internal library q from package p is named
z-p-z-q.

Later, Cabal library got refactored so that we made a closer distinction
between these "munged" package names and the true package name of a
package. Unfortunately, this is an example of a refactor for clarity in
the source code which ends up causing problems downstream, because the
point of "munging" the package name was to make it so that ghc-pkg and
similar tools transparently used MungedPackageName whereever they
previously used PackageName (in preparation for them learning proper
syntax for package name + component name). Failing to do this meant
that internal libraries from the same package (but with different
names) clobber each other.

This commit search-replaces most occurrences of PackageName in
ghc-pkg and turns them into MungedPackageName. Otherwise there
shouldn't be any functional differenes.

Signed-off-by: Edward Z. Yang <ezyang@cs.stanford.edu>

Test Plan: validate

Reviewers: bgamari, austin

Subscribers: rwbarton, thomie

GHC Trac Issues: Trac #13703

Differential Revision: https://phabricator.haskell.org/D3590

Details

Committed
ezyangMay 16 2017, 8:59 PM
Differential Revision
D3590: Fix #13703 by correctly using munged names in ghc-pkg.
Parents
rGHCcec7d580c2c0: Fix the pure unifier
Branches
Unknown
Tags
Unknown