* storage manager: preserve upper address bits on 64bit machines (thanks to…

Authored by trofi on Jul 9 2010, 6:59 AM.

Description

  • storage manager: preserve upper address bits on 64bit machines (thanks to zygoloid)

Patch does not touch amd64 as it's address lengts is 48 bits at most, so amd64 is unaffected.

the issue: during ia64 ghc bootstrap (both 6.10.4 and 6.12.3) I
got the failure on stage2 phase:

"inplace/bin/ghc-stage2"   -H32m -O -H64m -O0 -w ...
ghc-stage2: internal error: evacuate: strange closure type 15
    (GHC version 6.12.3 for ia64_unknown_linux)
    Please report this as a GHC bug:  http://www.haskell.org/ghc/reportabug
make[1]: *** [libraries/dph/dph-base/dist-install/build/Data/Array/Parallel/Base/Hyperstrict.o] Aborted

gdb backtrace (break on 'barf'):
Breakpoint 1 at 0x400000000469ec31: file rts/RtsMessages.c, line 39.
(gdb) run -B/var/tmp/portage/dev-lang/ghc-6.12.3/work/ghc-6.12.3/inplace/bin --info
Starting program: /var/tmp/portage/dev-lang/ghc-6.12.3/work/ghc-6.12.3/inplace/lib/ghc-stage2 -B/var/tmp/portage/dev-lang/ghc-6.12.3/work/ghc-6.12.3/inplace/bin --info
[Thread debugging using libthread_db enabled]

Breakpoint 1, barf (s=0x40000000047915b0 "evacuate: strange closure type %d") at rts/RtsMessages.c:39
39 va_start(ap,s);
(gdb) bt
Trac #0 barf (s=0x40000000047915b0 "evacuate: strange closure type %d") at rts/RtsMessages.c:39
Trac #1 0x400000000474a1e0 in evacuate (p=0x6000000000147958) at rts/sm/Evac.c:756
Trac #2 0x40000000046d68c0 in scavenge_srt (srt=0x6000000000147958, srt_bitmap=7) at rts/sm/Scav.c:348
...

16:52:53 < zygoloid> slyfox: i'm no ghc expert but it looks like HEAP_ALLOCED_GC(q)

is returning true for a FUN_STATIC closure

17:18:43 < zygoloid> try: p HEAP_ALLOCED_miss((unsigned long)(*p) >> 20, *p)
17:19:12 < slyfox> (gdb) p HEAP_ALLOCED_miss((unsigned long)(*p) >> 20, *p)
17:19:12 < slyfox> $1 = 0
17:19:40 < zygoloid> i /think/ that means the mblock_cache is broken
17:22:45 < zygoloid> i can't help further. however i am suspicious that you seem to have pointers with similar-looking low 33

bits and different high 4 bits, and it looks like such pointers get put into the same bucket in
mblock_cache.

...

17:36:16 < zygoloid> slyfox: try changing the definition of MbcCacheLine to StgWord64, see if that helps
17:36:31 < zygoloid> that's in includes/rts/storage/MBlock.h

And it helped!

Details

Committed
trofiJul 9 2010, 6:59 AM
Pushed
bgamariAug 25 2016, 1:39 PM
Parents
rGHCDIFF615d88d1912a: Fixing link failure of compiler on ia64 ('-Wl,' prefixed value passed directly…
Branches
Unknown
Tags
Unknown