NCG: New code layout algorithm.

Authored by AndreasK on Nov 17 2018, 4:20 AM.

Description

NCG: New code layout algorithm.

Summary:
This patch implements a new code layout algorithm.
It has been tested for x86 and is disabled on other platforms.

Performance varies slightly be CPU/Machine but in general seems to be better
by around 2%.
Nofib shows only small differences of about +/- ~0.5% overall depending on
flags/machine performance in other benchmarks improved significantly.

Other benchmarks includes at least the benchmarks of: aeson, vector, megaparsec, attoparsec,
containers, text and xeno.

While the magnitude of gains differed three different CPUs where tested with
all getting faster although to differing degrees. I tested: Sandy Bridge(Xeon), Haswell,
Skylake

  • Library benchmark results summarized:
    • containers: ~1.5% faster
    • aeson: ~2% faster
    • megaparsec: ~2-5% faster
    • xml library benchmarks: 0.2%-1.1% faster
    • vector-benchmarks: 1-4% faster
    • text: 5.5% faster

On average GHC compile times go down, as GHC compiled with the new layout
is faster than the overhead introduced by using the new layout algorithm,

Things this patch does:

  • Move code responsilbe for block layout in it's own module.
  • Move the NcgImpl Class into the NCGMonad module.
  • Extract a control flow graph from the input cmm.
  • Update this cfg to keep it in sync with changes during asm codegen. This has been tested on x64 but should work on x86. Other platforms still use the old codelayout.
  • Assign weights to the edges in the CFG based on type and limited static analysis which are then used for block layout.
  • Once we have the final code layout eliminate some redundant jumps.

    In particular turn a sequences of: jne .foo jmp .bar foo: into je bar foo: ..

Test Plan: ci

Reviewers: bgamari, jmct, jrtc27, simonmar, simonpj, RyanGlScott

Reviewed By: RyanGlScott

Subscribers: RyanGlScott, trommler, jmct, carter, thomie, rwbarton

GHC Trac Issues: Trac #15124

Differential Revision: https://phabricator.haskell.org/D4726

Details

Committed
AndreasKNov 17 2018, 4:20 AM
Reviewer
RyanGlScott
Differential Revision
D4726: NCG: New code layout algorithm.
Parents
rGHC6ba9aa5dd0a5: Fix a typo in the description of -fabstract-refinement-hole-fits
Branches
Unknown
Tags
Unknown