Don't use X86_64_ELF_NONPIC_HACK for +RTS -xp

Authored by watashi on Dec 28 2018, 10:48 PM.

Description

Don't use X86_64_ELF_NONPIC_HACK for +RTS -xp

Summary:
When +RTS -xp is passed, when don't need the X86_64_ELF_NONPIC_HACK,
becasue the relocation offset should only be out of range if

  • the object file was not compiled with -fPIC -fexternal-dynamic-refs;
  • ghc generates non-pic code while it should (e.g. Trac #15723)

In either case, we should print an error message rather that silently
attempt to use a hacky workaround that may not work.

This could have made debugging Trac #15723 and Trac #15729 much easier.

Test Plan:
Run this in a case where ghci used to crash becasue of T15723. Now we
see helpful message like:

ghc-iserv-prof: R_X86_64_PC32 relocation out of range:
stmzm2zi4zi4zi1zmJQn4hNPyYjP5m9AcbI88Ve_ControlziConcurrentziSTMziTMVar_readTMVar_C61n_cc
= 9b95ffac

Reviewers: simonmar, bgamari, erikd

Reviewed By: simonmar, bgamari

Subscribers: rwbarton, carter

Differential Revision: https://phabricator.haskell.org/D5233

Details

Committed
bgamariJan 30 2019, 9:06 AM
Reviewer
simonmar
Differential Revision
D5233: Don't use X86_64_ELF_NONPIC_HACK for +RTS -xp
Parents
rGHC740534d43cf9: Allocate bss section within proper range of other sections
Branches
Unknown
Tags
Unknown