Check that libs found by GCC aren't folders

Authored by harpocrates on Jan 7 2019, 2:59 PM.

Description

Check that libs found by GCC aren't folders

Summary:
We use 'gcc -B<base-location> --print-file-name mylib.a' as a way of
checking if 'gcc' can discover 'mylib.a' at the given location. However,
this can break down if there is a folder caller 'mylib.a' that 'gcc' can
discover. We can guard against this by explicitly checking that the path
returned by 'gcc' is a file.

This may seem like a far-fetched scenario, but since
3d17f1f10fc00540ac052f2fd03182906aa47e35, we look for libraries without
any prefix or suffix (ie. 'extra-libraries: softfloat', we look for just
'softfloat' as well as 'softloat.a', 'softfloat.dll.a', etc.) which means
that there might actusally be a folder of that name in one of the base
locations.

Reviewers: Phyx, bgamari, hvr, angerman

Reviewed By: Phyx, angerman

Subscribers: angerman, rwbarton, carter

GHC Trac Issues: Trac #16063

Differential Revision: https://phabricator.haskell.org/D5462

Details

Committed
harpocratesJan 7 2019, 3:58 PM
Reviewer
Phyx
Differential Revision
D5462: Check that libs found by GCC aren't folders
Parents
rGHC1c9dab22f010: fix-submodules: Rip out typing
Branches
Unknown
Tags
Unknown