Clean up TcHsSyn.zonkEnv

Authored by simonpj on Aug 24 2018, 2:14 AM.

Description

Clean up TcHsSyn.zonkEnv

Triggered by Trac Trac #15552, I'd been looking at ZonkEnv in TcHsSyn.

This patch does some minor refactoring

  • Make ZonkEnv into a record with named fields, and use them. (I'm planning to add a new field, for TyCons, so this prepares the way.)
  • Replace UnboundTyVarZonker (a higer order function) with the simpler and more self-descriptive ZonkFlexi data type, below. It's just much more perspicuous and direct, and (I suspect) a tiny bit faster too -- no unknown function calls.

data ZonkFlexi -- See Note [Un-unified unification variables]

= DefaultFlexi    -- Default unbound unificaiton variables to Any
| SkolemiseFlexi  -- Skolemise unbound unification variables
                  -- See Note [Zonking the LHS of a RULE]
| RuntimeUnkFlexi -- Used in the GHCi debugger

There was one knock-on effect in the GHCi debugger -- the
RuntimeUnkFlexi case. Somehow previously, these RuntimeUnk
variables were sometimes getting SystemNames (and hence
printed as 'a0', 'a1', etc) and sometimes not (and hence
printed as 'a', 'b' etc). I'm not sure precisely why, but
the new behaviour seems more uniform, so I just accepted the
(small) renaming wibbles in some ghci.debugger tests.

I had a quick look at perf: any changes are tiny.