GHCProject
ActivePublic

Details

Description

The Glasgow Haskell Compiler team.

Recent Activity

Apr 9 2019

bgamari added a comment to D42: Fix hWaitForInput not being interruptible (#8684)..

@nh2, what is the status of this?

Apr 9 2019, 5:57 PM · GHC

Jan 25 2019

angerman added a comment to D5213: Backend plugins.

@angerman, what is the status of this?

Jan 25 2019, 12:54 AM · GHC

Jan 20 2019

bgamari requested changes to D5213: Backend plugins.
Jan 20 2019, 7:13 PM · GHC
bgamari added a comment to D5213: Backend plugins.

@angerman, what is the status of this?

Jan 20 2019, 6:06 PM · GHC

Nov 25 2018

jb55 added a member for GHC: jb55.
Nov 25 2018, 5:01 PM

Nov 8 2018

mpickering resigned from D42: Fix hWaitForInput not being interruptible (#8684)..
Nov 8 2018, 4:26 PM · GHC
mpickering resigned from D4257: add variants of `finiteBitSize` and friends which take `Proxy`.
Nov 8 2018, 4:24 PM · GHC

Oct 11 2018

angerman commandeered D5213: Backend plugins.
Oct 11 2018, 4:31 AM · GHC

Oct 9 2018

luite added inline comments to D5213: Backend plugins.
Oct 9 2018, 1:56 AM · GHC
TerrorJack added inline comments to D5213: Backend plugins.
Oct 9 2018, 1:17 AM · GHC
luite added inline comments to D5213: Backend plugins.
Oct 9 2018, 1:05 AM · GHC
TerrorJack added a comment to D5213: Backend plugins.

Besides, Cabal and ghc-pkg won't know anything about backend-specific output files: Unless you manage to stuff all the wasm32 code into the existing .o and .a files, the result wouldn't be copied to the right place.

Oct 9 2018, 12:56 AM · GHC
luite added a comment to D5213: Backend plugins.

@luite There isn't a discussion other than the ghc-devs thread yet, I'll create a reddit thread to collect more opinions later.

Oct 9 2018, 12:29 AM · GHC

Oct 8 2018

TerrorJack added a comment to D5213: Backend plugins.

@luite There isn't a discussion other than the ghc-devs thread yet, I'll create a reddit thread to collect more opinions later.

Oct 8 2018, 9:43 PM · GHC
luite added a comment to D5213: Backend plugins.

Is there a discussion somewhere else (other than the ghc-devs mailing list) about this? For example I'm still not sure why for the motivating example (custom backends) you prefer plugins over hooks. Perhaps I missed it.

Oct 8 2018, 2:28 PM · GHC
AndreasK added a comment to D5213: Backend plugins.

The Cmm pipeline has multiple stages.
It would be good to give a reason why we allow people to hook into it at the place you suggest.

Oct 8 2018, 9:44 AM · GHC
TerrorJack added a comment to D5213: Backend plugins.

@mpickering The Hsc there indicates there's a HscEnv in scope available for use.

Oct 8 2018, 9:41 AM · GHC
Harbormaster failed remote builds in B22995: Diff 18256 for D5213: Backend plugins!
Oct 8 2018, 9:38 AM · GHC
mpickering added a comment to D5213: Backend plugins.

What have you been able to implement with these extension points? The Hsc looks suspicious.

Oct 8 2018, 9:33 AM · GHC
TerrorJack created D5213: Backend plugins.
Oct 8 2018, 9:25 AM · GHC

Jun 21 2018

nh2 added a comment to D42: Fix hWaitForInput not being interruptible (#8684)..

Note for myself:

Jun 21 2018, 12:13 PM · GHC

Apr 30 2018

simonmar added a comment to D42: Fix hWaitForInput not being interruptible (#8684)..

One concern I have is that the pthread implementation of the timer, when it doesn't use timerfd() just does a usleep(), which means that it will be less accurate than the timerfd() version or the setitimer() verison, because it relies on the scheduler not descheduling the thread for long periods.

Apr 30 2018, 2:51 AM · GHC

Apr 28 2018

nh2 added a comment to D42: Fix hWaitForInput not being interruptible (#8684)..

I still feel slightly weird about doing kill(pid(),EPIPE) at 50Hz or whatever the context switch interval is set to. Maybe it's OK.

Apr 28 2018, 3:02 PM · GHC

Apr 25 2018

Herald updated subscribers of D1111: 4 reduce/reduce parser conflicts resolved.
Apr 25 2018, 5:33 PM · GHC

Jan 10 2018

simonmar added a comment to D42: Fix hWaitForInput not being interruptible (#8684)..

I definitely support bringing in those docs somewhere (with the fix I just added to https://ghc.haskell.org/trac/ghc/ticket/10840).

Jan 10 2018, 11:43 AM · GHC

Jan 9 2018

Harbormaster failed remote builds in B19061: Diff 15058 for D42: Fix hWaitForInput not being interruptible (#8684).!
Jan 9 2018, 3:42 PM · GHC
nh2 updated the diff for D42: Fix hWaitForInput not being interruptible (#8684)..

Implemented context-switching in non-threaded on non-Linux

Jan 9 2018, 3:42 PM · GHC

Jan 6 2018

nh2 added a comment to D42: Fix hWaitForInput not being interruptible (#8684)..

There's another potential issue in current GHC I just found: I wrote:

Jan 6 2018, 9:02 PM · GHC
nh2 added a comment to D42: Fix hWaitForInput not being interruptible (#8684)..
In D42#119712, @nh2 wrote:

Which OSThreadId id can I pass? [...] what is the correct way to obtain its number?

Jan 6 2018, 8:46 PM · GHC
nh2 added a comment to D42: Fix hWaitForInput not being interruptible (#8684)..

For my reference, https://ghc.haskell.org/trac/ghc/ticket/10840 is what introduced the timerfd usage and also the other uses of non-SIGVTALRM timers.
I wasn't aware that they were introduced as recently as GHC 8.2.

Jan 6 2018, 6:29 PM · GHC

Dec 14 2017

RyanGlScott added a comment to D4257: add variants of `finiteBitSize` and friends which take `Proxy`.

@RyanGlScott which are these other such terms?

Dec 14 2017, 4:16 AM · GHC

Dec 13 2017

strake added a comment to D4257: add variants of `finiteBitSize` and friends which take `Proxy`.

@RyanGlScott which are these other such terms?

Dec 13 2017, 9:30 PM · GHC
strake added a comment to D4257: add variants of `finiteBitSize` and friends which take `Proxy`.

@RyanGlScott good point — we ought to introduce Proxyfied versions of all such terms in base.

Dec 13 2017, 9:28 PM · GHC

Dec 9 2017

RyanGlScott requested changes to D4257: add variants of `finiteBitSize` and friends which take `Proxy`.

Has there been a discussion on the Haskell libraries mailing list about this topic? We typically do not accept wholesale API additions to base without some kind of community consensus that they should be added.

Dec 9 2017, 4:37 AM · GHC

Dec 8 2017

Harbormaster failed remote builds in B18833: Diff 14897 for D4257: add variants of `finiteBitSize` and friends which take `Proxy`!
Dec 8 2017, 5:18 PM · GHC
strake created D4257: add variants of `finiteBitSize` and friends which take `Proxy`.
Dec 8 2017, 5:18 PM · GHC

Nov 30 2017

simonmar added a comment to D42: Fix hWaitForInput not being interruptible (#8684)..
It feels like a bit of a hack
Nov 30 2017, 3:41 AM · GHC

Nov 29 2017

nh2 added inline comments to D42: Fix hWaitForInput not being interruptible (#8684)..
Nov 29 2017, 11:53 AM · GHC

Nov 28 2017

simonmar added inline comments to D42: Fix hWaitForInput not being interruptible (#8684)..
Nov 28 2017, 2:17 PM · GHC
nh2 added inline comments to D42: Fix hWaitForInput not being interruptible (#8684)..
Nov 28 2017, 11:53 AM · GHC

Nov 27 2017

nh2 added a comment to D42: Fix hWaitForInput not being interruptible (#8684)..

For easier testing, I have provided binary distributions of this change backported to GHC 8.0.2 here: https://github.com/nh2/ghc/releases/tag/ghc-8.0.2-bug-8684-interruptible-hWaitForInput-iohk-2017-11-26

Nov 27 2017, 10:58 AM · GHC
simonmar requested changes to D42: Fix hWaitForInput not being interruptible (#8684)..

Mostly this looks reasonable to me, thanks for doing all this! One question inline.

Nov 27 2017, 3:44 AM · GHC

Nov 26 2017

nh2 updated the diff for D42: Fix hWaitForInput not being interruptible (#8684)..

Also update user's guide

Nov 26 2017, 11:53 AM · GHC
nh2 added a comment to D42: Fix hWaitForInput not being interruptible (#8684)..

TODO for myself: I need to update the user's guide section Interruptible foreign calls with the information about the newly added events.

Nov 26 2017, 9:33 AM · GHC

Nov 25 2017

nh2 updated the diff for D42: Fix hWaitForInput not being interruptible (#8684)..

Updated description from commit message

Nov 25 2017, 7:05 PM · GHC
nh2 updated the diff for D42: Fix hWaitForInput not being interruptible (#8684)..

Update commit message with good news

Nov 25 2017, 6:55 PM · GHC
Harbormaster failed remote builds in B18729: Diff 14821 for D42: Fix hWaitForInput not being interruptible (#8684).!
Nov 25 2017, 6:55 PM · GHC
nh2 added inline comments to D42: Fix hWaitForInput not being interruptible (#8684)..
Nov 25 2017, 6:24 PM · GHC
nh2 updated the diff for D42: Fix hWaitForInput not being interruptible (#8684)..

3 years after opening this, D42 is back!

Nov 25 2017, 5:21 PM · GHC
Harbormaster failed remote builds in B18728: Diff 14820 for D42: Fix hWaitForInput not being interruptible (#8684).!
Nov 25 2017, 5:21 PM · GHC