wz1000 (Zubin Duggal)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 4 2018, 7:53 AM (80 w, 6 d)

Recent Activity

Sep 13 2019

Marge Bot <ben+marge-bot@smart-cactus.org> committed rGHC71428a43bf12: Address review comments [skip CI] (authored by wz1000).
Address review comments [skip CI]
Sep 13 2019, 10:26 AM
Marge Bot <ben+marge-bot@smart-cactus.org> committed rGHC6f3cd50e2cee: Explain how to update HieAst [skip ci] (authored by wz1000).
Explain how to update HieAst [skip ci]
Sep 13 2019, 10:25 AM

Aug 7 2019

Marge Bot <ben+marge-bot@smart-cactus.org> committed rGHC8e2fe57528ba: Fix bug preventing information about patterns from being serialized in .hie… (authored by wz1000).
Fix bug preventing information about patterns from being serialized in .hie…
Aug 7 2019, 9:24 AM

Oct 18 2018

wz1000 added inline comments to D5239: Support generating HIE files.
Oct 18 2018, 3:28 PM
wz1000 added a comment to D5239: Support generating HIE files.

I'm putting these changes up because I'd like them to be reviewed sooner rather than later, especially since they are supposedly already almost merge-ready. Critically, this is blocking the Hi Haddock GSOC project too (see D5067), since there is no good path forward on that front for --hyperlinked-sources without .hie files.

@bgamari do you think it is unreasonable for this to be merged in time for 8.8.1?

/cc @hvr @sjakobi

Oct 18 2018, 2:24 PM

Jun 19 2018

wz1000 added a comment to D4866: Check if files are same in combineSrcSpans.

@dfeuer I modified T15279.hs to the following:

Jun 19 2018, 12:04 AM

Jun 18 2018

wz1000 updated the diff for D4866: Check if files are same in combineSrcSpans.
  • Test that Trac:15279 is fixed by modification to combineSrcSpans
Jun 18 2018, 2:31 PM
wz1000 added a comment to D4866: Check if files are same in combineSrcSpans.

@dfeuer A test case for the issue in Trac #15279 you mean?

Jun 18 2018, 2:31 PM
wz1000 updated the diff for D4866: Check if files are same in combineSrcSpans.
  • Fix grammar in comment
Jun 18 2018, 1:49 AM
wz1000 updated the Trac tickets for D4866: Check if files are same in combineSrcSpans.
Jun 18 2018, 1:49 AM
wz1000 created D4866: Check if files are same in combineSrcSpans.
Jun 18 2018, 1:49 AM

Jun 12 2018

wz1000 updated the diff for D4822: Preserve parenthesis in function application in typechecker.
  • Explain filtering logic
Jun 12 2018, 1:23 PM
wz1000 updated the diff for D4822: Preserve parenthesis in function application in typechecker.
  • Rename coercePar_maybe and remove notArgPar in favor of isArgPar
Jun 12 2018, 1:23 PM
wz1000 updated the diff for D4822: Preserve parenthesis in function application in typechecker.
  • make wrapHsArgs handle HsArgPar
Jun 12 2018, 1:00 PM
wz1000 updated the diff for D4822: Preserve parenthesis in function application in typechecker.
  • Explain HsArgPar and remove incomplete pattern in coercePar
  • Remove isArgPar and rename coercePar to coercePar_maybe
  • Add test to check all HsPars are preserved
  • Reduce testcase stderr
  • Remove most parens that ghc already preserved without patch
  • Merge branch 'master' of https://github.com/ghc/ghc
Jun 12 2018, 1:00 PM
wz1000 added a comment to D4822: Preserve parenthesis in function application in typechecker.

I've removed most parens from the testcase that ghc already preserved.

Jun 12 2018, 8:58 AM
wz1000 updated the diff for D4822: Preserve parenthesis in function application in typechecker.
  • Explain HsArgPar and remove incomplete pattern in coercePar
  • Remove isArgPar and rename coercePar to coercePar_maybe
  • Add test to check all HsPars are preserved
  • Reduce testcase stderr
  • Remove most parens that ghc already preserved without patch
Jun 12 2018, 8:52 AM
wz1000 updated the diff for D4822: Preserve parenthesis in function application in typechecker.
  • Reduce testcase stderr
Jun 12 2018, 8:12 AM

Jun 11 2018

wz1000 added inline comments to D4822: Preserve parenthesis in function application in typechecker.
Jun 11 2018, 10:49 PM
wz1000 updated the test plan for D4822: Preserve parenthesis in function application in typechecker.
Jun 11 2018, 12:35 PM
wz1000 updated the diff for D4822: Preserve parenthesis in function application in typechecker.
  • Add test to check all HsPars are preserved
Jun 11 2018, 12:35 PM

Jun 10 2018

wz1000 updated the diff for D4822: Preserve parenthesis in function application in typechecker.
  • Explain HsArgPar and remove incomplete pattern in coercePar
  • Remove isArgPar and rename coercePar to coercePar_maybe
Jun 10 2018, 9:57 PM

Jun 9 2018

wz1000 updated the diff for D4822: Preserve parenthesis in function application in typechecker.
  • Explain HsArgPar and remove incomplete pattern in coercePar
Jun 9 2018, 10:03 PM
wz1000 created D4822: Preserve parenthesis in function application in typechecker.
Jun 9 2018, 7:58 AM