watashi (Zejun Wu)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 24 2015, 10:18 PM (225 w, 5 d)

Recent Activity

Jun 7 2019

Marge Bot <ben+marge-bot@smart-cactus.org> committed rGHCcfd3e0f1cfd1: Pass preprocessor options to C compiler when building foreign C files (#16737) (authored by watashi).
Pass preprocessor options to C compiler when building foreign C files (#16737)
Jun 7 2019, 9:30 AM

Mar 6 2019

Marge Bot <ben+marge-bot@smart-cactus.org> committed rGHC3caeb443b2bc: Move reifyGHCi function into GhciMonad type class (authored by watashi).
Move reifyGHCi function into GhciMonad type class
Mar 6 2019, 3:51 PM

Mar 4 2019

Marge Bot <ben+marge-bot@smart-cactus.org> committed rGHC406e43af2f12: Add `-fplugin-trustworthy` to avoid marking modules as unsafe (authored by watashi).
Add `-fplugin-trustworthy` to avoid marking modules as unsafe
Mar 4 2019, 1:05 PM
Marge Bot <ben+marge-bot@smart-cactus.org> committed rGHC59d622d7f1a9: docs: change meta-variable of -interactive-print from expr to name (authored by watashi).
docs: change meta-variable of -interactive-print from expr to name
Mar 4 2019, 1:05 PM

Feb 1 2019

watashi abandoned D5433: Introduce GhciMonad and generalize types of functions in GHCi.UI.

merged in gitlab

Feb 1 2019, 3:16 PM
watashi closed D5233: Don't use X86_64_ELF_NONPIC_HACK for +RTS -xp.

merged

Feb 1 2019, 3:16 PM
watashi closed D5289: Add a RTS option -xp to load PIC object anywhere in address space.

merged

Feb 1 2019, 3:16 PM
watashi closed D5290: Allocate bss section within proper range of other sections.

merged

Feb 1 2019, 3:16 PM

Jan 21 2019

Herald updated subscribers of D4219: [WIP][RFC] GHCi: Order messages according to severity.
Jan 21 2019, 6:27 PM

Jan 20 2019

watashi added a comment to D5433: Introduce GhciMonad and generalize types of functions in GHCi.UI.

@simonmar Any comment on either direction?
I will just make a new MR on gitlab whichever direction we decide to go with.

Jan 20 2019, 8:23 PM

Jan 6 2019

watashi abandoned D5270: Hadrian: merge sections in profiling _p.a to .p_o for ghci.

This was merged in https://gitlab.haskell.org/ghc/ghc/merge_requests/82.

Jan 6 2019, 5:32 PM

Dec 21 2018

watashi added a comment to D5433: Introduce GhciMonad and generalize types of functions in GHCi.UI.

We can surely go with GHCi instead of GhciMonad m in this diff, and revise it in the future should it becomes necessary.

Dec 21 2018, 1:07 PM

Dec 14 2018

watashi added a comment to D5433: Introduce GhciMonad and generalize types of functions in GHCi.UI.

What is it that forces the overloading?

Dec 14 2018, 12:50 PM
watashi updated the diff for D5452: Fix ghci crash when starting with -fno-implicit-import-qualified.

grammar

Dec 14 2018, 12:34 PM
watashi updated the diff for D5452: Fix ghci crash when starting with -fno-implicit-import-qualified.

rebase && ./validate

Dec 14 2018, 12:50 AM
watashi updated the diff for D5453: Handle :cd in external interpreter in a more robust way.

rebase && ./validate

Dec 14 2018, 12:50 AM

Dec 13 2018

watashi retitled D5452: Fix ghci crash when starting with -fno-implicit-import-qualified from Fix ghci crash when starts with -fno-implicit-import-qualified to Fix ghci crash when starting with -fno-implicit-import-qualified.
Dec 13 2018, 11:06 PM
watashi created D5453: Handle :cd in external interpreter in a more robust way.
Dec 13 2018, 10:43 PM
watashi created D5452: Fix ghci crash when starting with -fno-implicit-import-qualified.
Dec 13 2018, 10:28 PM

Dec 11 2018

watashi updated the diff for D5270: Hadrian: merge sections in profiling _p.a to .p_o for ghci.

rebase and rerun tests

Dec 11 2018, 6:31 PM

Dec 10 2018

watashi created D5433: Introduce GhciMonad and generalize types of functions in GHCi.UI.
Dec 10 2018, 2:18 PM

Dec 5 2018

watashi updated the diff for D5270: Hadrian: merge sections in profiling _p.a to .p_o for ghci.

rebase onto recent Cabal release
@bgamari this handles .p_o now, see updated test plan

Dec 5 2018, 11:20 PM
watashi updated the test plan for D5270: Hadrian: merge sections in profiling _p.a to .p_o for ghci.
Dec 5 2018, 11:17 PM

Dec 3 2018

watashi added a child revision for D5388: Fix uninformative hp2ps error when the cmdline contains double quotes: D5407: cosmetic change: expandtab in utils/hp2ps/HpFile.c.
Dec 3 2018, 9:46 PM
watashi added a parent revision for D5407: cosmetic change: expandtab in utils/hp2ps/HpFile.c: D5388: Fix uninformative hp2ps error when the cmdline contains double quotes.
Dec 3 2018, 9:46 PM
watashi updated the diff for D5388: Fix uninformative hp2ps error when the cmdline contains double quotes.

rebase onto D5407: cosmetic change: expandtab in utils/hp2ps/HpFile.c and move ASSERT as @tdammers suggested

Dec 3 2018, 4:09 PM
watashi created D5407: cosmetic change: expandtab in utils/hp2ps/HpFile.c.
Dec 3 2018, 4:02 PM
watashi added inline comments to D5388: Fix uninformative hp2ps error when the cmdline contains double quotes.
Dec 3 2018, 3:57 PM

Nov 29 2018

watashi added a reviewer for D5395: Remove redundant include of Rts.h in EventLogWriter.h: alexbiehl.
Nov 29 2018, 4:39 PM
watashi created D5395: Remove redundant include of Rts.h in EventLogWriter.h.
Nov 29 2018, 4:29 PM

Nov 28 2018

watashi updated the diff for D5288: Explicitly pass -fno-PIC to C compiler on linux.

add reference to track ticket in the comment

Nov 28 2018, 3:44 PM

Nov 27 2018

watashi created D5388: Fix uninformative hp2ps error when the cmdline contains double quotes.
Nov 27 2018, 4:34 PM

Nov 24 2018

watashi added a comment to rGHC390df8b51b91: Fix uninformative hp2ps error when the cmdline contains double quotes.

@bgamari do you mind provide the shell version info you are using for test? It seems to be imcompatibity of $ā€™\nā€™. I will remove it from the test case.

Nov 24 2018, 6:24 PM

Nov 18 2018

watashi created D5349: Fix deadlock bug when mkFastStringWith is duplicated.
Nov 18 2018, 12:09 AM

Nov 16 2018

watashi added a comment to D5270: Hadrian: merge sections in profiling _p.a to .p_o for ghci.

The cabal changes has been pushed to master and 2.4 branches on github: https://github.com/haskell/cabal/commits/2.4
But the 2.4 branch on haskell.org is still 2 weeks old: http://git.haskell.org/packages/Cabal.git/log/refs/heads/2.4
Is only master branch automatically synced?

Nov 16 2018, 8:45 PM
watashi added a comment to D5289: Add a RTS option -xp to load PIC object anywhere in address space.

Can we still have this in ghc-8.8?

Nov 16 2018, 7:29 PM
watashi updated the Trac tickets for D5346: Fix uninformative hp2ps error when the command args contains double quotes.
Nov 16 2018, 3:11 PM
watashi created D5346: Fix uninformative hp2ps error when the command args contains double quotes.
Nov 16 2018, 3:11 PM

Nov 9 2018

watashi updated the diff for D5289: Add a RTS option -xp to load PIC object anywhere in address space.

rebase

Nov 9 2018, 5:24 PM

Nov 2 2018

watashi added a comment to D5288: Explicitly pass -fno-PIC to C compiler on linux.

@simonmar I created tickets with more details:

Nov 2 2018, 1:32 PM
watashi updated the summary of D5288: Explicitly pass -fno-PIC to C compiler on linux.
Nov 2 2018, 1:20 PM

Oct 31 2018

watashi added a parent revision for D5233: Don't use X86_64_ELF_NONPIC_HACK for +RTS -xp: D5289: Add a RTS option -xp to load PIC object anywhere in address space.
Oct 31 2018, 9:56 PM
watashi added a child revision for D5289: Add a RTS option -xp to load PIC object anywhere in address space: D5233: Don't use X86_64_ELF_NONPIC_HACK for +RTS -xp.
Oct 31 2018, 9:56 PM
watashi added a parent revision for D5290: Allocate bss section within proper range of other sections: D5289: Add a RTS option -xp to load PIC object anywhere in address space.
Oct 31 2018, 9:55 PM
watashi added a child revision for D5289: Add a RTS option -xp to load PIC object anywhere in address space: D5290: Allocate bss section within proper range of other sections.
Oct 31 2018, 9:55 PM
watashi created D5290: Allocate bss section within proper range of other sections.
Oct 31 2018, 9:55 PM
watashi updated the diff for D5289: Add a RTS option -xp to load PIC object anywhere in address space.

amend with the actual fix

Oct 31 2018, 8:59 PM
watashi added a parent revision for D5289: Add a RTS option -xp to load PIC object anywhere in address space: D5288: Explicitly pass -fno-PIC to C compiler on linux.
Oct 31 2018, 8:47 PM
watashi created D5289: Add a RTS option -xp to load PIC object anywhere in address space.
Oct 31 2018, 8:47 PM
watashi added a child revision for D5288: Explicitly pass -fno-PIC to C compiler on linux: D5289: Add a RTS option -xp to load PIC object anywhere in address space.
Oct 31 2018, 8:47 PM
watashi created D5288: Explicitly pass -fno-PIC to C compiler on linux.
Oct 31 2018, 6:22 PM

Oct 30 2018

watashi added a comment to rGHC8306141397d6: Allocate bss section within proper range of other sections.

@bgamari I will investigate this, it will take some time to setup an i686 environment, so feel free to revert this.

Oct 30 2018, 3:28 PM

Oct 28 2018

watashi updated the diff for D5270: Hadrian: merge sections in profiling _p.a to .p_o for ghci.

move package /= rts to cabal configure step
this also fix failure at cabal copy step due to missing HSrts-*.o

Oct 28 2018, 1:37 AM
watashi updated the summary of D5270: Hadrian: merge sections in profiling _p.a to .p_o for ghci.
Oct 28 2018, 1:34 AM
watashi updated the test plan for D5270: Hadrian: merge sections in profiling _p.a to .p_o for ghci.
Oct 28 2018, 1:33 AM

Oct 27 2018

watashi added inline comments to D5270: Hadrian: merge sections in profiling _p.a to .p_o for ghci.
Oct 27 2018, 1:39 AM
watashi retitled D5270: Hadrian: merge sections in profiling _p.a to .p_o for ghci from Hadrain: merge sections in profiling _p.a to .p_o to Hadrain: merge sections in profiling _p.a to .p_o for ghci.
Oct 27 2018, 1:33 AM
watashi created D5270: Hadrian: merge sections in profiling _p.a to .p_o for ghci.
Oct 27 2018, 1:32 AM

Oct 26 2018

watashi updated the diff for D5211: Rewrite FastString table in concurrent hashtable.

refer tests as full path

Oct 26 2018, 12:50 PM

Oct 25 2018

watashi updated the diff for D5211: Rewrite FastString table in concurrent hashtable.

add test and comment as @simonmar suggested:

Oct 25 2018, 2:17 AM

Oct 23 2018

watashi updated the diff for D5211: Rewrite FastString table in concurrent hashtable.
  • comments on naming
  • use Array# (IORef FastStringTableSegment)
  • didn't see significant difference with different load factor, keep it as 1 as it's common and simple
  • the benchmark in exterm case looks better, it's hard to measure in normal build run as this part is usually not dominator
Oct 23 2018, 5:54 PM

Oct 19 2018

watashi created D5246: Fix rare undefined asm temp end label error in x86.
Oct 19 2018, 1:29 PM

Oct 18 2018

watashi updated the summary of D5233: Don't use X86_64_ELF_NONPIC_HACK for +RTS -xp.
Oct 18 2018, 1:44 PM

Oct 17 2018

watashi created D5235: Fix T15729 and T3001-2 in master.
Oct 17 2018, 11:14 AM
watashi created D5234: Fix ghc-pkg when only prof way is enabled.
Oct 17 2018, 11:06 AM
watashi created D5233: Don't use X86_64_ELF_NONPIC_HACK for +RTS -xp.
Oct 17 2018, 8:53 AM
watashi added a comment to D5230: rts/Linker.c: define the 'mmap_again' label only for x86_64.

Thank you for fixing this.

Oct 17 2018, 8:47 AM

Oct 15 2018

watashi added a parent revision for D5219: Allocate bss section within proper range of other sections: D5195: Add a RTS option -xp to load PIC object anywhere in address space.
Oct 15 2018, 11:14 AM
watashi added a child revision for D5195: Add a RTS option -xp to load PIC object anywhere in address space: D5219: Allocate bss section within proper range of other sections.
Oct 15 2018, 11:14 AM

Oct 10 2018

watashi planned changes to D5211: Rewrite FastString table in concurrent hashtable.
Oct 10 2018, 7:01 AM

Oct 9 2018

watashi created D5219: Allocate bss section within proper range of other sections.
Oct 9 2018, 7:22 PM
watashi updated the diff for D5214: Generate correct relocation for external cost centre.

nit + CCS_Label is always local

Oct 9 2018, 3:52 PM
watashi added inline comments to D5214: Generate correct relocation for external cost centre.
Oct 9 2018, 3:22 PM

Oct 8 2018

watashi created D5214: Generate correct relocation for external cost centre.
Oct 8 2018, 9:54 AM

Oct 7 2018

watashi created D5211: Rewrite FastString table in concurrent hashtable.
Oct 7 2018, 10:43 AM

Oct 3 2018

watashi updated the diff for D5195: Add a RTS option -xp to load PIC object anywhere in address space.

comments

Oct 3 2018, 7:52 PM
watashi updated the test plan for D5195: Add a RTS option -xp to load PIC object anywhere in address space.
Oct 3 2018, 7:32 PM
watashi updated the test plan for D5195: Add a RTS option -xp to load PIC object anywhere in address space.
Oct 3 2018, 7:32 PM
watashi updated the test plan for D5195: Add a RTS option -xp to load PIC object anywhere in address space.
Oct 3 2018, 7:30 PM
watashi updated the diff for D5195: Add a RTS option -xp to load PIC object anywhere in address space.

clean up ALWAYS_PIC macro and comments

Oct 3 2018, 5:01 PM

Oct 2 2018

watashi updated the diff for D5195: Add a RTS option -xp to load PIC object anywhere in address space.

.

Oct 2 2018, 1:36 PM
watashi updated the diff for D5195: Add a RTS option -xp to load PIC object anywhere in address space.

Avoid changing the order for Windows

Oct 2 2018, 1:36 PM
watashi added a comment to D5195: Add a RTS option -xp to load PIC object anywhere in address space.

@Phyx Thanks for pointing this out, so we cannot flip the order for PEi386 and I will keep it untouched, but it was a problem for ELF when !RTS_LINKER_USE_MMAP || USE_CONTIGUOUS_MMAP is true.

Oct 2 2018, 1:36 PM
watashi added inline comments to D3915: Updated PE linker, section alignment and cleanup..
Oct 2 2018, 11:15 AM
watashi created D5195: Add a RTS option -xp to load PIC object anywhere in address space.
Oct 2 2018, 11:12 AM

Sep 28 2018

watashi updated the diff for D5168: Always check the relocation value for x86_64.

Improve error message:

  • For non-pic relocation, suggest recompile with -fPIC -fexternal-dynamic-refs
  • For pic relocation, suggest report bug of ghc
Sep 28 2018, 7:32 AM

Sep 27 2018

watashi planned changes to D5168: Always check the relocation value for x86_64.
Sep 27 2018, 1:59 PM
watashi added inline comments to D5168: Always check the relocation value for x86_64.
Sep 27 2018, 12:40 PM
watashi added inline comments to D5168: Always check the relocation value for x86_64.
Sep 27 2018, 9:39 AM

Sep 25 2018

watashi added inline comments to D5168: Always check the relocation value for x86_64.
Sep 25 2018, 5:27 PM
watashi added a comment to D5169: Merge sections in profiling .a to .p_o and use it whenever it exists.

Does that include the ghc package?

Sep 25 2018, 11:01 AM
watashi added a comment to D5169: Merge sections in profiling .a to .p_o and use it whenever it exists.

The total size of each output in my build:

Sep 25 2018, 6:50 AM

Sep 21 2018

watashi updated the diff for D5169: Merge sections in profiling .a to .p_o and use it whenever it exists.

update comment wording

Sep 21 2018, 12:31 PM
watashi created D5169: Merge sections in profiling .a to .p_o and use it whenever it exists.
Sep 21 2018, 10:26 AM
watashi added inline comments to D5168: Always check the relocation value for x86_64.
Sep 21 2018, 5:32 AM

Sep 20 2018

watashi added inline comments to D5168: Always check the relocation value for x86_64.
Sep 20 2018, 6:42 PM
watashi added a comment to D5161: users_guide: fix sphinx error caused by non-explicit override.

That's sad :-(

Sep 20 2018, 4:56 PM
watashi added inline comments to D5168: Always check the relocation value for x86_64.
Sep 20 2018, 4:38 PM
watashi updated the diff for D5161: users_guide: fix sphinx error caused by non-explicit override.

rebase

Sep 20 2018, 12:22 PM
watashi added a comment to D5161: users_guide: fix sphinx error caused by non-explicit override.

@bgamari I will rebase this on top of that then.

Sep 20 2018, 12:22 PM