v0d1ch (Sasa Bogicevic)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 3 2018, 3:24 PM (27 w, 3 d)

Recent Activity

Oct 22 2018

v0d1ch updated the diff for D4943: WIP: Notify user when a kind mismatch holds up a type family reduction.
  • Update some code with master
Oct 22 2018, 5:40 AM

Sep 28 2018

v0d1ch updated the diff for D4943: WIP: Notify user when a kind mismatch holds up a type family reduction.
  • submodule revert
Sep 28 2018, 8:44 AM

Sep 25 2018

v0d1ch added a comment to D5040: Surprising error message with bang pattern.

@bgamari I think one important bit that we somehow managed to loose along the way is that the wording should be:

Sep 25 2018, 4:06 PM
v0d1ch updated the diff for D5040: Surprising error message with bang pattern.
  • PR review changes
Sep 25 2018, 4:03 PM

Sep 24 2018

v0d1ch updated the diff for D4943: WIP: Notify user when a kind mismatch holds up a type family reduction.
  • Rebase new master
Sep 24 2018, 4:30 AM
v0d1ch added a comment to D4943: WIP: Notify user when a kind mismatch holds up a type family reduction.

@bgamari Yes! I was busy with https://phabricator.haskell.org/D5040 and now I can dedicate my spare time to this task.

Sep 24 2018, 4:11 AM

Sep 23 2018

v0d1ch added a comment to D5040: Surprising error message with bang pattern.

It should be fine now. Thank you for all your help @sgraf !

Sep 23 2018, 5:15 AM
v0d1ch updated the diff for D5040: Surprising error message with bang pattern.
  • Add warning to standard warnings
Sep 23 2018, 5:09 AM

Sep 22 2018

v0d1ch added inline comments to D5040: Surprising error message with bang pattern.
Sep 22 2018, 4:52 PM
v0d1ch updated the diff for D5040: Surprising error message with bang pattern.
  • review changes
Sep 22 2018, 4:48 PM

Sep 21 2018

v0d1ch updated the diff for D5040: Surprising error message with bang pattern.
  • Add stderr
Sep 21 2018, 4:09 PM
v0d1ch updated the diff for D5040: Surprising error message with bang pattern.
  • PR changes
Sep 21 2018, 11:45 AM

Sep 20 2018

v0d1ch updated the diff for D5040: Surprising error message with bang pattern.
  • Add one more user doc line
Sep 20 2018, 4:56 PM
v0d1ch updated the diff for D5040: Surprising error message with bang pattern.
  • Add a warning
Sep 20 2018, 9:45 AM
v0d1ch added inline comments to D5040: Surprising error message with bang pattern.
Sep 20 2018, 6:57 AM
v0d1ch updated the diff for D5040: Surprising error message with bang pattern.
  • Move checkIfBang function
Sep 20 2018, 6:53 AM
v0d1ch updated the diff for D5040: Surprising error message with bang pattern.
  • Separate test cases
Sep 20 2018, 3:29 AM
v0d1ch added inline comments to D5040: Surprising error message with bang pattern.
Sep 20 2018, 3:19 AM
v0d1ch updated the diff for D5040: Surprising error message with bang pattern.
  • Add a function to match a bang
Sep 20 2018, 3:15 AM

Sep 19 2018

v0d1ch updated the diff for D5040: Surprising error message with bang pattern.
  • Add another warning message
Sep 19 2018, 9:13 AM

Sep 18 2018

v0d1ch added a comment to D5040: Surprising error message with bang pattern.

@sgraf I just realized we never check if we actually deal with ! just if infix expression is followed immediately by var. I think it makes sense to add that and also warn about defining infix expression without proper spacing. What is your take ?
Also in your example I don't understand how would this compile without errors:

f4 :: [a] -> Int -> a
f4 ! x = f4 !! x

Aren't you writing a type signature for f4 and then defining infix operator ! so f4 lacks its implementation ?

Sep 18 2018, 4:22 PM
v0d1ch updated the diff for D5040: Surprising error message with bang pattern.
  • Add new warning message
Sep 18 2018, 4:22 PM
v0d1ch retitled D5040: Surprising error message with bang pattern from WIP: Surprising error message with bang pattern to Surprising error message with bang pattern.
Sep 18 2018, 10:34 AM
v0d1ch updated the diff for D5040: Surprising error message with bang pattern.
  • Remove passing test record
Sep 18 2018, 10:32 AM
v0d1ch added a comment to D5040: Surprising error message with bang pattern.

@sgraf I added another test case just in case :) If you think this is good enough I can ping @bgamari to review again.

Sep 18 2018, 10:31 AM
v0d1ch updated the diff for D5040: Surprising error message with bang pattern.
  • Add one more test case
Sep 18 2018, 10:29 AM
v0d1ch added inline comments to D5040: Surprising error message with bang pattern.
Sep 18 2018, 9:48 AM
v0d1ch added inline comments to D5040: Surprising error message with bang pattern.
Sep 18 2018, 9:38 AM
v0d1ch updated the diff for D5040: Surprising error message with bang pattern.
  • Check for space and move tests
Sep 18 2018, 9:27 AM
v0d1ch added a comment to D5040: Surprising error message with bang pattern.

¯\_(ツ)_/¯ maybe I should move it even further into the parser and find a place where we still have whitespace knowledge

Sep 18 2018, 6:55 AM
v0d1ch updated the diff for D5040: Surprising error message with bang pattern.
  • Move check to infixexp_top
Sep 18 2018, 6:54 AM

Sep 14 2018

v0d1ch added a comment to D5040: Surprising error message with bang pattern.

@sgraf I am kinda lost here and I am not sure if I need to try to add this check somewhere else. @bgamari mentioned that I need to find a place where we still have whitespace knowledge in order to check if ! comes right before param.
I printed out the types and values of things in scope just because it may help out but as I see there is already space around ! from where I am printing this.

testsuite/tests/printer/T13600.hs
line looks like this: f4 !x = return (sum x)
these are the printed things in scope from https://github.com/ghc/ghc/blob/master/compiler/parser/Parser.y#L2313
Sep 14 2018, 4:49 PM

Sep 10 2018

v0d1ch added a comment to D5040: Surprising error message with bang pattern.

Thanks for your help @sgraf ! I will play around with those functions you added in the last edit and hopefully manage to add that check.

Sep 10 2018, 4:32 PM

Sep 7 2018

v0d1ch added a comment to D5040: Surprising error message with bang pattern.

Yeah I made changes to this file before just a few lines below but it didn't catch some cases. Take a look at this comment https://phabricator.haskell.org/D5040#138828 from @bgamari

Sep 7 2018, 3:21 PM
v0d1ch added a comment to D5040: Surprising error message with bang pattern.

Yes, either suggesting enabling BangPatterns or adding space behind !.
I am not sure that this is the right place to hint BangPatterns but the test I added goes trough this part of the parser https://github.com/v0d1ch/ghc/blob/master/compiler/parser/Parser.y#L2312

Sep 7 2018, 9:30 AM

Sep 6 2018

v0d1ch updated the diff for D5040: Surprising error message with bang pattern.

Return all to previous state

Sep 6 2018, 3:46 PM

Aug 24 2018

v0d1ch abandoned D5101: Comment out where that is left behind.
Aug 24 2018, 3:54 AM
v0d1ch created D5101: Comment out where that is left behind.
Aug 24 2018, 3:24 AM

Aug 10 2018

v0d1ch retitled D5040: Surprising error message with bang pattern from Surprising error message with bang pattern to WIP: Surprising error message with bang pattern.
Aug 10 2018, 5:05 AM

Aug 9 2018

v0d1ch added a comment to D5040: Surprising error message with bang pattern.

This now yields:

Aug 9 2018, 5:39 AM
v0d1ch updated the diff for D5040: Surprising error message with bang pattern.
  • Check if RdrName matches a bang
Aug 9 2018, 5:35 AM

Aug 8 2018

v0d1ch updated the diff for D5040: Surprising error message with bang pattern.
  • Detect ! and warn if no bangpatterns
Aug 8 2018, 7:04 PM

Aug 6 2018

v0d1ch retitled D5040: Surprising error message with bang pattern from Add test files to Surprising error message with bang pattern.
Aug 6 2018, 4:28 PM
v0d1ch added a comment to D5040: Surprising error message with bang pattern.

Oh I see now what is the summary, just the top title in bold that you can't miss 😄

Aug 6 2018, 4:28 PM
v0d1ch added a comment to D5040: Surprising error message with bang pattern.

@bgamari Is there a way to mark the diff as WIP so nobody wastes precious time reviewing ?

Aug 6 2018, 3:37 PM

Aug 4 2018

v0d1ch added inline comments to D5040: Surprising error message with bang pattern.
Aug 4 2018, 4:12 PM

Aug 3 2018

v0d1ch updated the diff for D5040: Surprising error message with bang pattern.
  • Very bad solution
Aug 3 2018, 4:47 PM
v0d1ch created D5040: Surprising error message with bang pattern.
Aug 3 2018, 8:40 AM

Jul 29 2018

v0d1ch updated the diff for D4943: WIP: Notify user when a kind mismatch holds up a type family reduction.
  • Remove previous attempt
Jul 29 2018, 5:32 PM

Jul 18 2018

v0d1ch created D4985: Small spelling fixes for Unify.hs.
Jul 18 2018, 5:15 PM

Jul 17 2018

v0d1ch created D4979: Fix some typos in docs.
Jul 17 2018, 7:18 AM
v0d1ch created D4978: Correct spelling errors.
Jul 17 2018, 5:13 AM
v0d1ch created D4977: Fix spelling errors.
Jul 17 2018, 4:52 AM
v0d1ch created D4976: Fix a typo.
Jul 17 2018, 4:33 AM
v0d1ch created D4975: Fix a typo in related trac ticket number.
Jul 17 2018, 3:16 AM

Jul 11 2018

v0d1ch updated the diff for D4943: WIP: Notify user when a kind mismatch holds up a type family reduction.
  • Revert changes and start from scratch
Jul 11 2018, 4:59 PM

Jul 10 2018

v0d1ch abandoned D4949: Notify user when a kind mismatch holds up a type family reduction.
Jul 10 2018, 2:29 AM
v0d1ch removed a parent revision for D4949: Notify user when a kind mismatch holds up a type family reduction: D4943: WIP: Notify user when a kind mismatch holds up a type family reduction.
Jul 10 2018, 2:25 AM
v0d1ch removed a child revision for D4943: WIP: Notify user when a kind mismatch holds up a type family reduction: D4949: Notify user when a kind mismatch holds up a type family reduction.
Jul 10 2018, 2:25 AM
v0d1ch added a comment to D4949: Notify user when a kind mismatch holds up a type family reduction.

arc diff <other usual stuff> -update D4943

Jul 10 2018, 2:24 AM
v0d1ch updated the diff for D4943: WIP: Notify user when a kind mismatch holds up a type family reduction.

Fix number of lines warn in TcErrors.hs

Jul 10 2018, 2:21 AM

Jul 9 2018

v0d1ch added a parent revision for D4949: Notify user when a kind mismatch holds up a type family reduction: D4943: WIP: Notify user when a kind mismatch holds up a type family reduction.
Jul 9 2018, 5:42 PM
v0d1ch added a child revision for D4943: WIP: Notify user when a kind mismatch holds up a type family reduction: D4949: Notify user when a kind mismatch holds up a type family reduction.
Jul 9 2018, 5:42 PM
v0d1ch added a comment to D4949: Notify user when a kind mismatch holds up a type family reduction.

Is there a way to merge somehow parent differential D4943 with this one ? I managed to delete my previous commits locally (facepalm) and this diff should really be a small update for D4943

Jul 9 2018, 5:33 PM
Herald added a reviewer for D4949: Notify user when a kind mismatch holds up a type family reduction: goldfire.
Jul 9 2018, 5:28 PM

Jul 6 2018

v0d1ch added inline comments to D4943: WIP: Notify user when a kind mismatch holds up a type family reduction.
Jul 6 2018, 6:13 PM
Herald added a reviewer for D4943: WIP: Notify user when a kind mismatch holds up a type family reduction: goldfire.
Jul 6 2018, 5:24 PM