trommler (Peter Trommler)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Jun 6 2014, 3:56 PM (202 w, 6 d)
Availability
Available

Recent Activity

Mar 9 2018

trommler added a comment to D4489: SPARC nativeGen: Support for MO_SS_Conv_W32_W64.

Note: I don't have a working SPARC machine so I could not test this.

Mar 9 2018, 5:28 AM
trommler created D4489: SPARC nativeGen: Support for MO_SS_Conv_W32_W64.
Mar 9 2018, 5:24 AM

Mar 5 2018

trommler added a comment to D4363: Improve accuracy of get/setAllocationCounter.

Currently MO_SS_Conv W32 W64 is not supported on 32 bit PPC.

I created D4468 for this.

Mar 5 2018, 3:56 AM
trommler created D4468: PPC nativeGen: Add support for MO_SS_Conv_W32_W64.
Mar 5 2018, 3:56 AM

Feb 1 2018

trommler added a comment to D4364: ghc-prim: Emulate C11 atomics when not available.

I think atomic read is fine but atomic write is missing a parameter. See inline comment.

Feb 1 2018, 1:34 PM
trommler added a comment to D4363: Improve accuracy of get/setAllocationCounter.

Currently MO_SS_Conv W32 W64 is not supported on 32 bit PPC. In fact, we would get a compiler panic if I understand the code in nativeGen/PPC/Codegen.hs right.

Feb 1 2018, 12:11 PM

Nov 27 2017

trommler added a comment to D4236: Add new mbmi and mbmi2 compiler flags.

I have a small comment regarding the C functions.

Nov 27 2017, 10:42 AM

Nov 14 2017

trommler accepted D4182: CLabel: Clean up unused label types.

LGTM. I validated this diff applied to HEAD and Phab:D4181 on a POWER8 (powerpc64-linux) with no regressions.

Nov 14 2017, 11:38 AM

Nov 12 2017

trommler requested changes to D4182: CLabel: Clean up unused label types.

I built the diff against HEAD on a POWER8 and got this error:

Nov 12 2017, 1:19 PM
trommler created D4181: RTS: Disable warnings in ffi.h.
Nov 12 2017, 11:19 AM

Nov 6 2017

trommler created D4165: Update autoconf test for gcc to require 4.7 and up.
Nov 6 2017, 1:30 PM

Nov 5 2017

trommler updated the diff for D4149: Fix PPC NCG after blockID patch.
  • Improve comments
Nov 5 2017, 11:46 AM
trommler added inline comments to D4149: Fix PPC NCG after blockID patch.
Nov 5 2017, 2:58 AM
trommler updated the diff for D4149: Fix PPC NCG after blockID patch.
  • Fix duplicate labels on powerpc64le
Nov 5 2017, 2:48 AM

Nov 4 2017

trommler updated the summary of D4149: Fix PPC NCG after blockID patch.
Nov 4 2017, 2:15 PM
trommler updated the summary of D4149: Fix PPC NCG after blockID patch.
Nov 4 2017, 2:15 PM
trommler planned changes to D4149: Fix PPC NCG after blockID patch.

I'd like to fix powerpc64le, too.

Nov 4 2017, 1:10 PM
trommler updated the diff for D4149: Fix PPC NCG after blockID patch.
  • Break up long lines
  • Make block info tables local and simplify
  • Simplify and always use infoTblLbl
  • Add note Proc-point block entry-point
Nov 4 2017, 1:07 PM
trommler updated the summary of D4149: Fix PPC NCG after blockID patch.
Nov 4 2017, 6:17 AM

Nov 3 2017

trommler updated the summary of D4149: Fix PPC NCG after blockID patch.
Nov 3 2017, 2:17 PM
trommler added a reviewer for D4149: Fix PPC NCG after blockID patch: angerman.
Nov 3 2017, 8:47 AM

Nov 2 2017

trommler created D4149: Fix PPC NCG after blockID patch.
Nov 2 2017, 11:44 AM

Oct 2 2017

trommler updated the summary of D4009: Fix atomicread/write operations.
Oct 2 2017, 10:24 AM

Sep 30 2017

trommler updated the diff for D4009: Fix atomicread/write operations.
  • add lost commit
Sep 30 2017, 2:03 PM
trommler updated the diff for D4009: Fix atomicread/write operations.
  • add comment for memory barrier
Sep 30 2017, 1:59 PM

Sep 27 2017

trommler added a comment to D4009: Fix atomicread/write operations.

These get compiled into the same code on x86, right?

For atomic read the answer is yes.

Sep 27 2017, 10:15 AM

Sep 23 2017

trommler added 1 blocking reviewer(s) for D3984: PPC NCG: Impl branch prediction, atomic ops.: hvr.
Sep 23 2017, 9:58 AM
trommler added a comment to D3984: PPC NCG: Impl branch prediction, atomic ops..

I'll have to trust you on the PPC details.

I checked the POWER ISA docs and compared the code with what gcc does. I also added a comment with references to the POWER docs in a place where the code looks very odd.

Sep 23 2017, 9:58 AM
trommler updated the diff for D3984: PPC NCG: Impl branch prediction, atomic ops..
  • add comments and fix typo
Sep 23 2017, 9:58 AM

Sep 22 2017

trommler created D4009: Fix atomicread/write operations.
Sep 22 2017, 12:26 PM

Sep 17 2017

trommler updated the summary of D3984: PPC NCG: Impl branch prediction, atomic ops..
Sep 17 2017, 5:46 AM
trommler created D3984: PPC NCG: Impl branch prediction, atomic ops..
Sep 17 2017, 4:40 AM

May 9 2017

trommler abandoned D3540: RTS: Fix duplicate symbols in unreg'd on ppc64le.

Let's use Ben's patch D3560. It is both cleaner and more efficient.

May 9 2017, 2:14 PM
trommler accepted D3560: rts: Don't build StgCRunAsm.S if unregisterised.

Yes. That is better than my patch.

May 9 2017, 2:12 PM

May 5 2017

trommler created D3540: RTS: Fix duplicate symbols in unreg'd on ppc64le.
May 5 2017, 1:09 PM

Apr 30 2017

trommler created D3512: PPC NCG: Lower MO_*_Fabs as PowerPC fabs instruction.
Apr 30 2017, 4:57 AM

Apr 25 2017

trommler added a comment to D2973: PPC NCG: Implement callish prim ops.
In D2973#99561, @hvr wrote:

Is there any particular test-case that exercises specifically this part of the code-gen? I can't easily run the whole validate testsuite currently, due to a broken Python installation.

Apr 25 2017, 12:28 AM

Mar 27 2017

trommler updated the diff for D2973: PPC NCG: Implement callish prim ops.
  • Fix count trailing zeros formula in comment
Mar 27 2017, 10:08 AM

Mar 25 2017

trommler added a comment to D2973: PPC NCG: Implement callish prim ops.

Fix long lines.
Rebase again to fix Habormaster builds.

Mar 25 2017, 4:35 AM

Mar 24 2017

trommler updated the diff for D2973: PPC NCG: Implement callish prim ops.

Fix long lines.
Rebase again to fix Habormaster builds.

Mar 24 2017, 3:39 AM

Mar 21 2017

trommler updated the diff for D2973: PPC NCG: Implement callish prim ops.

Rebase so it applies cleanly to HEAD again.

Mar 21 2017, 2:21 PM

Jan 17 2017

trommler added a comment to D2973: PPC NCG: Implement callish prim ops.
In D2973#86962, @erikd wrote:

This looks ok to me, but I can't currently built it cause my PowerPC machine is busted.

Jan 17 2017, 4:39 AM
trommler updated D2973: PPC NCG: Implement callish prim ops.
Jan 17 2017, 3:44 AM

Jan 16 2017

trommler updated subscribers of T297: Phabricator stopped sending email.
Jan 16 2017, 4:29 AM
trommler updated subscribers of T297: Phabricator stopped sending email.

When did this start happening?

Jan 16 2017, 3:46 AM

Jan 14 2017

trommler updated the diff for D2973: PPC NCG: Implement callish prim ops.
  • Break up long lines
Jan 14 2017, 11:26 AM
trommler created T297: Phabricator stopped sending email.
Jan 14 2017, 11:12 AM
trommler retitled D2973: PPC NCG: Implement callish prim ops from to PPC NCG: Implement callish prim ops.
Jan 14 2017, 10:09 AM

Dec 18 2016

trommler updated the diff for D2782: Testsuite: Skip failing tests on PowerPC 64-bit.
  • remove newline.
Dec 18 2016, 8:21 AM

Dec 16 2016

trommler updated the diff for D2782: Testsuite: Skip failing tests on PowerPC 64-bit.
  • Fix typos in comment.
  • Improve RTS linker support detection
  • RTS linker: Better error message on PPC64
  • RTS linker: Note runtime-linker-support
Dec 16 2016, 1:39 PM

Dec 6 2016

trommler added a comment to D2791: NCG: Implement trivColorable for PowerPC 64-bit.
In D2791#81436, @hvr wrote:

@trommler just wondering, how does register allocation work right now for ppc64?

Dec 6 2016, 4:19 AM

Dec 5 2016

trommler retitled D2791: NCG: Implement trivColorable for PowerPC 64-bit from to NCG: Implement trivColorable for PowerPC 64-bit.
Dec 5 2016, 12:58 PM
trommler updated the diff for D2782: Testsuite: Skip failing tests on PowerPC 64-bit.
  • Testsuite: rename config property
Dec 5 2016, 9:12 AM

Dec 3 2016

trommler added a comment to D2782: Testsuite: Skip failing tests on PowerPC 64-bit.

I added a new property for runtime linker support to settings

Dec 3 2016, 1:21 PM
trommler updated the diff for D2782: Testsuite: Skip failing tests on PowerPC 64-bit.
  • add to GHC info if RTS linker is supported
  • Testsuite: skip another test when no RTS linker
  • Fix typo.
Dec 3 2016, 1:15 PM

Dec 2 2016

trommler added inline comments to D2782: Testsuite: Skip failing tests on PowerPC 64-bit.
Dec 2 2016, 2:12 AM

Dec 1 2016

trommler retitled D2782: Testsuite: Skip failing tests on PowerPC 64-bit from to Testsuite: Skip failing tests on PowerPC 64-bit.
Dec 1 2016, 1:04 PM

Oct 11 2016

trommler added a comment to D2525: StgCmmPrim: Add missing write barrier..

Inline comment done.

Oct 11 2016, 10:24 AM

Oct 10 2016

trommler updated D2525: StgCmmPrim: Add missing write barrier..
Oct 10 2016, 6:55 AM
trommler updated the diff for D2525: StgCmmPrim: Add missing write barrier..
  • Move write barrier and add comment
Oct 10 2016, 5:16 AM

Oct 6 2016

trommler added inline comments to D2525: StgCmmPrim: Add missing write barrier..
Oct 6 2016, 11:03 AM

Sep 30 2016

trommler updated the diff for D2547: PPC/CodeGen: fix lwa instruction generation.
  • Add note referring to Power ISA specification
Sep 30 2016, 8:49 AM

Sep 28 2016

trommler added a comment to D2547: PPC/CodeGen: fix lwa instruction generation.

Alright; I don't know what a DS form is but fair enough.

Sep 28 2016, 5:08 AM

Sep 25 2016

trommler retitled D2547: PPC/CodeGen: fix lwa instruction generation from to PPC/CodeGen: fix lwa instruction generation.
Sep 25 2016, 7:45 AM

Sep 11 2016

trommler added a reviewer for D2525: StgCmmPrim: Add missing write barrier.: rrnewton.
Sep 11 2016, 3:38 AM
trommler retitled D2525: StgCmmPrim: Add missing write barrier. from to StgCmmPrim: Add missing write barrier..
Sep 11 2016, 3:19 AM

Aug 7 2016

trommler retitled D2445: PPC NCG: Implement minimal stack frame header. from to PPC NCG: Implement minimal stack frame header..
Aug 7 2016, 3:04 AM

Aug 1 2016

trommler accepted D2431: Use MO_Cmpxchg in Primops.cmm instead of ccall cas(..).

Thank you Alex!

Aug 1 2016, 2:36 AM

Jul 31 2016

trommler added a comment to D2431: Use MO_Cmpxchg in Primops.cmm instead of ccall cas(..).

Builds on PowerPC 64-bit now.

Jul 31 2016, 3:22 AM

Jul 29 2016

trommler accepted D2435: Add atomic operations to package.conf.in.

This builds on PowerPC 64-bit big endian.

Jul 29 2016, 12:47 PM
trommler requested changes to D2435: Add atomic operations to package.conf.in.

One macro is still AMD/Intel specific.

Jul 29 2016, 4:35 AM
trommler requested changes to D2435: Add atomic operations to package.conf.in.

Please support all 64-bit platforms. See my inline comment.

Jul 29 2016, 1:27 AM

Jul 28 2016

trommler added a comment to D2431: Use MO_Cmpxchg in Primops.cmm instead of ccall cas(..).
In D2431#70796, @erikd wrote:

@trommler Do you get the same result on PowerPC64?

Jul 28 2016, 9:04 AM

Jun 21 2016

trommler added a comment to D2328: PPC NCG: Fix and refactor TOC handling..

Is this something we should merge for 8.0.2? If so would you mind opening a ticket and placing it in merge state?

Jun 21 2016, 2:39 AM

Jun 13 2016

trommler added a comment to D2328: PPC NCG: Fix and refactor TOC handling..

Please let me know if I need to add more information here.

Jun 13 2016, 1:23 PM
trommler updated the diff for D2328: PPC NCG: Fix and refactor TOC handling..
  • Improve comment.
Jun 13 2016, 1:22 PM
trommler updated the diff for D2328: PPC NCG: Fix and refactor TOC handling..
  • Explain why we need NOPs after a call.
Jun 13 2016, 1:12 PM

Jun 12 2016

trommler retitled D2328: PPC NCG: Fix and refactor TOC handling. from to PPC NCG: Fix and refactor TOC handling..
Jun 12 2016, 1:20 PM
trommler updated the diff for D2327: PPC NCG: Fix float parameter passing on 64-bit..
  • untabify C file
Jun 12 2016, 8:51 AM
trommler updated the diff for D2327: PPC NCG: Fix float parameter passing on 64-bit..

Forgot the first commit (again) :-(

Jun 12 2016, 8:43 AM
trommler retitled D2327: PPC NCG: Fix float parameter passing on 64-bit. from to PPC NCG: Fix float parameter passing on 64-bit..
Jun 12 2016, 8:40 AM

Jun 1 2016

trommler added a comment to D2289: testsuite: Mark broken tests on powerpc64le.
In D2289#66206, @hvr wrote:

there's a good chance this applies to AIX/ppc32 as well;

I have some unfinished patch to mark all TH-requiring tests as such to reduce the overwhelming noise you currently get with the testsuite if run it with a TH-lacking GHC...

Jun 1 2016, 1:34 PM
trommler retitled D2289: testsuite: Mark broken tests on powerpc64le from to testsuite: Mark broken tests on powerpc64le.
Jun 1 2016, 11:37 AM

May 27 2016

trommler updated the diff for D2233: RTS SMP: Use compiler built-ins on all platforms..
  • update file path in comment
  • Improve comments after code review.
May 27 2016, 5:00 AM
trommler updated D2233: RTS SMP: Use compiler built-ins on all platforms..
May 27 2016, 3:33 AM

May 25 2016

trommler added inline comments to D2233: RTS SMP: Use compiler built-ins on all platforms..
May 25 2016, 12:08 PM

May 19 2016

trommler added a comment to D2233: RTS SMP: Use compiler built-ins on all platforms..
In D2233#64807, @hvr wrote:

would it make any sense to combine __sync_synchronize() with __sync_lock_test_and_set()?

May 19 2016, 8:29 AM

May 18 2016

trommler added a comment to D2233: RTS SMP: Use compiler built-ins on all platforms..

Add x86_64 assembler output.

May 18 2016, 4:08 AM

May 17 2016

trommler retitled D2233: RTS SMP: Use compiler built-ins on all platforms. from to RTS SMP: Use compiler built-ins on all platforms..
May 17 2016, 1:08 PM

May 16 2016

trommler added a comment to D2225: PPC: Implement SMP primitives using gcc built-ins.
In D2225#64401, @hvr wrote:

@trommler you'll get there :-)

May 16 2016, 7:55 AM
trommler updated the diff for D2225: PPC: Implement SMP primitives using gcc built-ins.

Submit all commits.

May 16 2016, 7:50 AM
trommler added a comment to D2225: PPC: Implement SMP primitives using gcc built-ins.

Also, it would be great if you could do this soon since 8.0.1 is now blocked on this change.

May 16 2016, 7:48 AM
trommler updated the diff for D2225: PPC: Implement SMP primitives using gcc built-ins.

Only apply to PPC as the title says.

  • Revert "RTS: Use _sync_* built-ins on all systems"
  • PPC: Fix atomic_dec in RTS.
May 16 2016, 7:46 AM
trommler added a comment to D2225: PPC: Implement SMP primitives using gcc built-ins.

The patch looks good to me.

However, it looks like this touches more than just PPC, contrary to what the title claims.

I missed that one when I edited the description, sorry!

@hvr had asked for this commit to be included in 8.0.1 (which unfortunately needs to be re-spun); however I'll admit that I'm a little hesitant to merge something that touches all of our platforms like this. As far as I can tell there are three options here,

  • Wait until 8.0.2 to merge this
  • Only merge the PPC part of this into 8.0.1
  • Be very very careful and merge the whole thing into 8.0.1

    I'm really not keen on the last option. What do you think, @trommler?

I would be fine with option two. I'll update the diff accordingly and prepare another diff
for the other systems.

May 16 2016, 6:56 AM
trommler updated the diff for D2225: PPC: Implement SMP primitives using gcc built-ins.

Forgot trailing ~, so first commit was missing.

May 16 2016, 6:34 AM
trommler retitled D2225: PPC: Implement SMP primitives using gcc built-ins from to PPC: Implement SMP primitives using gcc built-ins.
May 16 2016, 6:33 AM

May 13 2016

trommler retitled D2214: PPC NCG: Fix pretty printing of st[wd]ux instr. from to PPC NCG: Fix pretty printing of st[wd]ux instr..
May 13 2016, 10:18 AM

May 5 2016

trommler added a comment to D1290: Reduce the size of string literals in binaries..

Is this patch good to go now?

May 5 2016, 4:46 AM

Apr 8 2016

trommler updated the diff for D2093: PPC NCG: Improve pointer de-tagging code.

Replace diff to recover lost commits.

Apr 8 2016, 1:28 PM
trommler added a comment to D2093: PPC NCG: Improve pointer de-tagging code.
Apr 8 2016, 12:59 PM