trofi (Sergei Trofimovich)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Jun 9 2014, 4:10 AM (202 w, 3 d)
Availability
Available

Recent Activity

Wed, Apr 18

trofi requested review of D4608: rts: fix format arguments for debugBelch calls on 32-bit systems.
Wed, Apr 18, 4:27 PM

Mar 17 2018

trofi committed rGHC0693b0b05002: aclocal.m4: add OSHurd (debian patch) (authored by trofi).
aclocal.m4: add OSHurd (debian patch)
Mar 17 2018, 12:20 PM
trofi committed rGHC1522cf05c9c3: aclocal.m4: allow more GNU/Hurd tuples (authored by trofi).
aclocal.m4: allow more GNU/Hurd tuples
Mar 17 2018, 7:26 AM

Mar 10 2018

trofi committed rGHCe3ae0eb8e13a: testsuite: disable T13615 on non-smp targets (authored by trofi).
testsuite: disable T13615 on non-smp targets
Mar 10 2018, 6:47 AM

Mar 9 2018

trofi committed rGHCdd3906bf5deb: UNREG: fix implicit declarations from pdep and pext (authored by trofi).
UNREG: fix implicit declarations from pdep and pext
Mar 9 2018, 11:57 AM

Mar 5 2018

trofi accepted D4467: `--via-asm` only for windows targets.

Looks good! Thank you!

Mar 5 2018, 2:21 PM

Mar 4 2018

trofi raised a concern with rGHC5f6fcf7808b1: Compile with `--via-asm` when cross compiling..

Caused breakage at least on sparc: https://ghc.haskell.org/trac/ghc/ticket/14889

Mar 4 2018, 4:39 AM

Mar 3 2018

trofi added inline comments to D4439: Compile with `--via-asm` when cross compiling..
Mar 3 2018, 4:57 AM

Feb 25 2018

trofi accepted D4448: configure: Enable LD_NO_GOLD is set in all codepaths.

Looks good and works here locally!

Feb 25 2018, 1:52 PM

Dec 25 2017

trofi committed rGHC02aaeabd5851: aclocal.m4: add minimal support for nios2 architecture (authored by trofi).
aclocal.m4: add minimal support for nios2 architecture
Dec 25 2017, 9:53 AM

Dec 5 2017

trofi committed rGHC1ecbe9ccb10f: utils/hsc2hs: update submodule (authored by trofi).
utils/hsc2hs: update submodule
Dec 5 2017, 2:29 AM
trofi closed D4248: utils/hsc2hs: update submodule.
Dec 5 2017, 2:29 AM
trofi committed rGHC30d6373e6715: rts: fix filename case for mingw32 target (authored by trofi).
rts: fix filename case for mingw32 target
Dec 5 2017, 1:50 AM
trofi closed D4247: rts: fix filename case for mingw32 target.
Dec 5 2017, 1:50 AM

Dec 2 2017

trofi created D4248: utils/hsc2hs: update submodule.
Dec 2 2017, 5:23 AM
trofi added inline comments to D3913: Add stack traces on crashes on Windows.
Dec 2 2017, 5:20 AM
trofi created D4247: rts: fix filename case for mingw32 target.
Dec 2 2017, 5:17 AM

Nov 29 2017

trofi added a comment to D4048: Build utilities with the bootstrap compiler when cross compiling.

Created the following https://phabricator.haskell.org/D4243 for review.

Nov 29 2017, 5:16 PM
trofi added a comment to D4048: Build utilities with the bootstrap compiler when cross compiling.

The hsc2hs repo would need to have the following patch

From 94af7d9a27307f40a8b18da0f8e0fd9e9d77e818 Mon Sep 17 00:00:00 2001
From: Moritz Angermann <moritz.angermann@gmail.com>
Date: Sun, 1 Oct 2017 18:07:17 +0800
Subject: [PATCH] Use the same conditional install logic from unlit

This removes the make concurrency bug from the CrossCompilation fix, and uses the
same appraoch `utils/unlit` already uses.
---
 ghc.mk | 21 ++++++++-------------
 1 file changed, 8 insertions(+), 13 deletions(-)

diff --git a/ghc.mk b/ghc.mk
index c5f7473..8221829 100644
--- a/ghc.mk
+++ b/ghc.mk
@@ -5,27 +5,22 @@ utils/hsc2hs_dist_PROGNAME         = hsc2hs
 utils/hsc2hs_dist-install_PROGNAME = hsc2hs
 
 utils/hsc2hs_dist_SHELL_WRAPPER = YES
-utils/hsc2hs_dist_INSTALL = NO
 utils/hsc2hs_dist_INSTALL_INPLACE = YES
 
 utils/hsc2hs_dist-install_SHELL_WRAPPER = YES
-utils/hsc2hs_dist-install_INSTALL = YES
 utils/hsc2hs_dist-install_INSTALL_INPLACE = NO
 
-$(eval $(call build-prog,utils/hsc2hs,dist,0))
-
-# When CrossCompiling, we want to ship the binary for the
-# host, not for the target.  As such we need to compile
-# with the Bootstrap compiler rather than with the in-tree
-# stage1 compiler, which would result in a binary that
-# won't run on the host.
-ifeq "$(CrossCompiling)" "YES"
-# compile with stage 0 (bootstrap compiler)
-$(eval $(call build-prog,utils/hsc2hs,dist-install,0))
+ifeq "$(Stage1Only)" "YES"
+utils/hsc2hs_dist_INSTALL         = YES
+utils/hsc2hs_dist-install_INSTALL = NO
 else
-$(eval $(call build-prog,utils/hsc2hs,dist-install,1))
+utils/hsc2hs_dist_INSTALL         = NO
+utils/hsc2hs_dist-install_INSTALL = YES
 endif
 
+$(eval $(call build-prog,utils/hsc2hs,dist,0))
+$(eval $(call build-prog,utils/hsc2hs,dist-install,1))
+
 # After build-prog above
 utils/hsc2hs_dist_MODULES += Paths_hsc2hs
 utils/hsc2hs_dist-install_MODULES = $(utils/hsc2hs_dist_MODULES)
-- 
2.14.1

applied, to be consistent with the changes in updated changes in here.

Nov 29 2017, 4:49 PM

Nov 6 2017

trofi requested changes to D4017: Use EntryLabel to represent block labels.

This change also seems to break dynamic build:

Nov 6 2017, 8:19 AM

Nov 2 2017

trofi committed rGHC51321cf2eb3b: rts/PrimOps.cmm: add declaration for heapOverflow closure (authored by trofi).
rts/PrimOps.cmm: add declaration for heapOverflow closure
Nov 2 2017, 6:27 PM

Oct 20 2017

trofi accepted D4114: Move ghc{autoconf,platform,version}.h to includes/dist; hide includes/ from stage0 compiler.

Looks good! Thank you!

Oct 20 2017, 2:07 AM

Oct 16 2017

trofi accepted D4100: updateThunk: indirectee can be tagged.
Oct 16 2017, 2:53 PM

Sep 29 2017

trofi added a comment to D4048: Build utilities with the bootstrap compiler when cross compiling.

dist-install is just a name of intermediate directory nearby source of a tool or library.
The directory name itself does not carry semantic meaning and is just a suffix for rest
of variables like utils/hpc_dist-install_INSTALL = YES (vs, say utils/hpc_dist_INSTALL = YES)

Sep 29 2017, 5:09 AM
trofi added a comment to D4048: Build utilities with the bootstrap compiler when cross compiling.

The commit message does not explain what exactly changes in:

  • build process
  • what changes in installed artifacts
Sep 29 2017, 3:50 AM

Sep 24 2017

trofi accepted D4017: Use EntryLabel to represent block labels.
Sep 24 2017, 11:08 AM
trofi committed rGHCb3ae47caf2f2: don't allow AsmTempLabel in UNREG mode (Trac #14264) (authored by trofi).
don't allow AsmTempLabel in UNREG mode (Trac #14264)
Sep 24 2017, 7:29 AM

Sep 23 2017

trofi accepted D4004: Additional LLVM_TARGET logic..
Sep 23 2017, 3:34 AM
trofi accepted D4014: Fix AsmTempLabel.

Let's try that. If it will also fail at worst we'll invert it back to 'if not UNREG'.

Sep 23 2017, 2:30 AM

Sep 20 2017

trofi added inline comments to D3883: Add gen-dll as replacement for dll-split.
Sep 20 2017, 5:27 PM
trofi committed rGHCd7705f2fbead: aclocal.m4: call cygpath on mingw32 only (authored by trofi).
aclocal.m4: call cygpath on mingw32 only
Sep 20 2017, 5:21 PM
trofi added inline comments to D3883: Add gen-dll as replacement for dll-split.
Sep 20 2017, 4:49 PM

Jul 22 2017

trofi added a comment to D3741: Stg.h: Reintroduce removed EI_/II_ for bootstrapping.

The GHC_INCLUDE_DIRS to stage0 was added in ea310f9956179f91ca973bc747b0bc7b061bc174:

Jul 22 2017, 12:46 PM
trofi accepted D3775: fix dllwrap issue..

Thank you!

Jul 22 2017, 8:17 AM
trofi added inline comments to D3637: Provide way to build using existing C compiler on Windows..
Jul 22 2017, 5:15 AM

Jul 15 2017

trofi accepted D3741: Stg.h: Reintroduce removed EI_/II_ for bootstrapping.

Nice and simple fix. Apologies for caused breakage. Didin't realize
we leak-in new Stg.h even when stage0 is invoked.

Jul 15 2017, 1:20 PM

Jul 8 2017

trofi committed rGHCc2303dff95aa: aclocal.m4: allow arbitrary <vendor> string in toolchain triplets (authored by trofi).
aclocal.m4: allow arbitrary <vendor> string in toolchain triplets
Jul 8 2017, 4:01 AM

Jul 6 2017

trofi committed rGHCf3979b7fbd83: lowercase clang (authored by angerman).
lowercase clang
Jul 6 2017, 2:02 AM

Jul 5 2017

trofi committed rGHC3eeb55e9578f: rts/sm/Storage.c: tweak __clear_cache proto for clang (authored by trofi).
rts/sm/Storage.c: tweak __clear_cache proto for clang
Jul 5 2017, 3:26 AM
trofi committed rGHC7040660528f5: Revert "rts/sm/Storage.c: tweak __clear_cache proto for clang" (authored by trofi).
Revert "rts/sm/Storage.c: tweak __clear_cache proto for clang"
Jul 5 2017, 3:25 AM
trofi added a reverting change for rGHC9492703a5862: rts/sm/Storage.c: tweak __clear_cache proto for clang: rGHC7040660528f5: Revert "rts/sm/Storage.c: tweak __clear_cache proto for clang".
Jul 5 2017, 3:25 AM
trofi committed rGHC9492703a5862: rts/sm/Storage.c: tweak __clear_cache proto for clang (authored by trofi).
rts/sm/Storage.c: tweak __clear_cache proto for clang
Jul 5 2017, 3:12 AM

Jun 22 2017

trofi committed rGHC34b7f63e285e: UNREG: use __builtin___clear_cache where available (authored by trofi).
UNREG: use __builtin___clear_cache where available
Jun 22 2017, 4:36 PM

Jun 21 2017

trofi committed rGHCc6fe403ec714: Revert "UNREG: use __builtin___clear_cache where available" (authored by trofi).
Revert "UNREG: use __builtin___clear_cache where available"
Jun 21 2017, 4:16 PM
trofi added a reverting change for rGHC6dd1257fdd4d: UNREG: use __builtin___clear_cache where available: rGHCc6fe403ec714: Revert "UNREG: use __builtin___clear_cache where available".
Jun 21 2017, 4:16 PM
trofi committed rGHC6dd1257fdd4d: UNREG: use __builtin___clear_cache where available (authored by trofi).
UNREG: use __builtin___clear_cache where available
Jun 21 2017, 3:30 PM

Jun 1 2017

trofi committed rGHCd39a3409acd3: aclocal.m4: add support for versioned darwin triplets (authored by trofi).
aclocal.m4: add support for versioned darwin triplets
Jun 1 2017, 4:35 PM

May 25 2017

trofi committed rGHCf011f587ca02: rules: add per-library EXTRA_HC_OPTS (authored by trofi).
rules: add per-library EXTRA_HC_OPTS
May 25 2017, 4:56 PM

May 23 2017

trofi committed rGHC107601058b61: ghc.mk: rename installed ghc-stage1 on non-windows (authored by trofi).
ghc.mk: rename installed ghc-stage1 on non-windows
May 23 2017, 4:31 AM
trofi committed rGHC1fd06de4e98d: aclocal.m4: allow override of dllwrap and windres when cross-compiling (authored by trofi).
aclocal.m4: allow override of dllwrap and windres when cross-compiling
May 23 2017, 4:31 AM
trofi committed rGHC432a1f18327a: mk/config.mk.in: lower -O2 optimization down to -O1 on UNREG (authored by trofi).
mk/config.mk.in: lower -O2 optimization down to -O1 on UNREG
May 23 2017, 4:31 AM

May 16 2017

trofi added inline comments to D3589: Add support for producing position-independent executables.
May 16 2017, 3:03 AM

May 14 2017

trofi committed rGHCd5414dd61b54: rts/linker/ElfTypes.h: restore powerps (and others) support (authored by trofi).
rts/linker/ElfTypes.h: restore powerps (and others) support
May 14 2017, 2:34 PM
trofi closed D3583: rts/linker/ElfTypes.h: restore powerps (and others) support by committing rGHCd5414dd61b54: rts/linker/ElfTypes.h: restore powerps (and others) support.
May 14 2017, 2:34 PM
trofi committed rGHC230416f8b6f6: rts: annotate switch/case with '/* fallthrough */' (authored by trofi).
rts: annotate switch/case with '/* fallthrough */'
May 14 2017, 2:34 PM
trofi committed rGHC20c39b7743a2: ProfilerReportJson.c: fix out-of-bounds access (authored by trofi).
ProfilerReportJson.c: fix out-of-bounds access
May 14 2017, 2:34 PM
Herald added a reviewer for D3583: rts/linker/ElfTypes.h: restore powerps (and others) support: austin.
May 14 2017, 4:48 AM
trofi committed rGHC1269aff19e7b: includes/Stg.h: '#if sparch_HOST_ARCH' -> '#if defined(sparch_HOST_ARCH)' (authored by trofi).
includes/Stg.h: '#if sparch_HOST_ARCH' -> '#if defined(sparch_HOST_ARCH)'
May 14 2017, 4:35 AM

Apr 25 2017

trofi accepted D3499: configure: Kill off FP_ARG_WITH_*.

Yay! Thank you! Perhaps worth explicitly mentioning in release notes file.

Apr 25 2017, 4:11 PM

Apr 23 2017

trofi committed rGHC74e5ec9e63ff: ghc.mk: fix 'make install' for cross-mingw32 (authored by trofi).
ghc.mk: fix 'make install' for cross-mingw32
Apr 23 2017, 9:40 AM
trofi committed rGHC8908ba31c4dc: ghc: tweak cross-compilation to mingw32 (authored by trofi).
ghc: tweak cross-compilation to mingw32
Apr 23 2017, 9:20 AM
trofi committed rGHC745032dd02da: rts: tweak cross-compilation to mingw32 (authored by trofi).
rts: tweak cross-compilation to mingw32
Apr 23 2017, 7:55 AM
trofi committed rGHCfe37e2c6ab9d: aclocal.m4: treat '*-w64-mingw32' targets as windows (authored by trofi).
aclocal.m4: treat '*-w64-mingw32' targets as windows
Apr 23 2017, 7:55 AM
trofi committed rGHC58a656956f70: configure.ac: print paths to dllwrap and windres (authored by trofi).
configure.ac: print paths to dllwrap and windres
Apr 23 2017, 7:55 AM

Apr 21 2017

trofi committed rGHC32a5ba993de4: Build system: fix bindist for cross-build GHC (authored by Fangrui Song <i@maskray.me>).
Build system: fix bindist for cross-build GHC
Apr 21 2017, 4:33 PM
Herald added a reviewer for D3481: compiler/cmm/PprC.hs: constify labels in .rodata: austin.
Apr 21 2017, 4:40 AM
trofi committed rGHC24cf688b4882: utils/debugNCG: remove old tool (authored by trofi).
utils/debugNCG: remove old tool
Apr 21 2017, 2:29 AM
trofi closed D3476: utils/debugNCG: remove old tool by committing rGHC24cf688b4882: utils/debugNCG: remove old tool.
Apr 21 2017, 2:29 AM

Apr 20 2017

trofi committed rGHC526d2ebc218f: pprDebugCLabel: drop duplicate trailing ')' (authored by trofi).
pprDebugCLabel: drop duplicate trailing ')'
Apr 20 2017, 3:14 PM
trofi committed rGHCa18f58d2290c: testsuite: disable 'optllvm' for unregisterised compiler (authored by trofi).
testsuite: disable 'optllvm' for unregisterised compiler
Apr 20 2017, 2:23 PM
trofi created D3476: utils/debugNCG: remove old tool.
Apr 20 2017, 1:53 PM

Apr 17 2017

trofi added a comment to rGHC79848f18805a: aclocal.m4: respect user's --with-ar= choice.

Filed https://ghc.haskell.org/trac/ghc/ticket/13583 for it. Single ticket might be hard to track all the disparate places we allow tool overrides but it's a start.

Apr 17 2017, 12:15 PM
trofi committed rGHC79848f18805a: aclocal.m4: respect user's --with-ar= choice (authored by trofi).
aclocal.m4: respect user's --with-ar= choice
Apr 17 2017, 7:58 AM
trofi committed rGHC1ca188c74e70: configure.ac: print resolved 'ar' and 'ranlib' tools (authored by trofi).
configure.ac: print resolved 'ar' and 'ranlib' tools
Apr 17 2017, 7:58 AM
trofi committed rGHCa92ff5d66182: hs_add_root() RTS API removal (authored by trofi).
hs_add_root() RTS API removal
Apr 17 2017, 7:57 AM
trofi closed D3460: hs_add_root() RTS API removal by committing rGHCa92ff5d66182: hs_add_root() RTS API removal.
Apr 17 2017, 7:57 AM
trofi updated the diff for D3460: hs_add_root() RTS API removal.

Tweaked release notes entry following Simon's suggestion.

Apr 17 2017, 5:41 AM
trofi updated the diff for D3460: hs_add_root() RTS API removal.
  • Added ghc-8.4.1 release notes entry.
  • Removed unrelated #include <stdlib.h>.
Apr 17 2017, 5:30 AM
trofi added inline comments to D3460: hs_add_root() RTS API removal.
Apr 17 2017, 5:09 AM

Apr 16 2017

trofi committed rGHC29ef71412af4: UNREG: fix spelling of '-split-objs' in warning (authored by trofi).
UNREG: fix spelling of '-split-objs' in warning
Apr 16 2017, 12:30 PM
trofi committed rGHC5fd75d737dec: UNREG: remove dead code around -split-objs (authored by trofi).
UNREG: remove dead code around -split-objs
Apr 16 2017, 11:52 AM
trofi updated the diff for D3460: hs_add_root() RTS API removal.

Removed even more references to __stginit in comments.
Removed unused stg_init and stg_init_finish rts functions.

Apr 16 2017, 7:32 AM
Herald added a reviewer for D3460: hs_add_root() RTS API removal: austin.
Apr 16 2017, 6:20 AM
trofi committed rGHC295f97f74dcf: rts/RtsUtils.c: drop stale comments (authored by trofi).
rts/RtsUtils.c: drop stale comments
Apr 16 2017, 5:15 AM

Apr 11 2017

trofi accepted D3440: Caret diagnostics: Avoid decoding whole module if only specific line is needed.

Looks nice! Thank you!

Apr 11 2017, 4:04 PM

Apr 10 2017

trofi added inline comments to D3440: Caret diagnostics: Avoid decoding whole module if only specific line is needed.
Apr 10 2017, 4:32 PM
trofi accepted D3438: [Elf/arm] Thumb indicator bit only for STT_FUNC.
Apr 10 2017, 2:28 AM

Apr 9 2017

trofi added a comment to D3432: fix 'make install' for cross-stage2.

I can expand existing https://ghc.haskell.org/trac/ghc/wiki/Building/Installing with cross-compiling/cross-building case.

Apr 9 2017, 6:15 PM
trofi added a comment to D2875: Cache the files in StringBuffer to improve efficiency.

In http://ghc.haskell.org/trac/ghc/ticket/13527 we've encountered an interesting effect of caret diagnostic:
the line from file being printed in not from haskell file, but from huge autogenerated assembler file.

Apr 9 2017, 12:28 PM

Apr 8 2017

trofi committed rGHCff84d052850b: cross-build 'unlit' and 'hp2ps' for stage2 install (authored by trofi).
cross-build 'unlit' and 'hp2ps' for stage2 install
Apr 8 2017, 4:59 AM
trofi committed rGHC54895c90440c: fix 'make install' for cross-stage2 (authored by trofi).
fix 'make install' for cross-stage2
Apr 8 2017, 4:59 AM
trofi closed D3432: fix 'make install' for cross-stage2 by committing rGHC54895c90440c: fix 'make install' for cross-stage2.
Apr 8 2017, 4:59 AM

Apr 7 2017

trofi created D3432: fix 'make install' for cross-stage2.
Apr 7 2017, 4:26 AM

Apr 6 2017

trofi committed rGHC732b3dbbff19: add $(CrossCompilePrefix) to 'runghc' and 'ghci' (authored by trofi).
add $(CrossCompilePrefix) to 'runghc' and 'ghci'
Apr 6 2017, 5:24 PM
trofi committed rGHC4671e3c17cb6: config.mk.in: removed stray HaveLibDL assignment (authored by trofi).
config.mk.in: removed stray HaveLibDL assignment
Apr 6 2017, 4:12 AM
trofi committed rGHCf2685df3b10e: avoid $(CrossCompilerPrefix) for stage2 install (authored by trofi).
avoid $(CrossCompilerPrefix) for stage2 install
Apr 6 2017, 4:12 AM
trofi committed rGHC6ff98b962db1: config.mk.in: remove phase=0 hack for CrossCompilePrefix (authored by trofi).
config.mk.in: remove phase=0 hack for CrossCompilePrefix
Apr 6 2017, 4:12 AM
trofi committed rGHC844704b4883e: Use non-canocalized triple as cross-compiler prefix (authored by trofi).
Use non-canocalized triple as cross-compiler prefix
Apr 6 2017, 4:12 AM

Apr 5 2017

trofi added inline comments to D3358: base: Implement bit casts between word and float types.
Apr 5 2017, 2:48 AM

Apr 4 2017

trofi added inline comments to D3358: base: Implement bit casts between word and float types.
Apr 4 2017, 4:10 PM