trofi (Sergei Trofimovich)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 9 2014, 4:10 AM (235 w, 1 d)

Recent Activity

Oct 14 2018

trofi added inline comments to D5190: Multiple fixes / improvements for LLVM backend.
Oct 14 2018, 1:59 PM

Oct 7 2018

trofi committed rGHCe4bec29cb475: testsuite: disable T11760 on non-smp targets (authored by trofi).
testsuite: disable T11760 on non-smp targets
Oct 7 2018, 5:29 AM
trofi committed rGHC32ceaaab9daf: testsuite: disable nursery-chunks1 on non-smp targets (authored by trofi).
testsuite: disable nursery-chunks1 on non-smp targets
Oct 7 2018, 5:29 AM
trofi committed rGHC6483ff98f550: testsuite: disable T10017 on non-smp targets (authored by trofi).
testsuite: disable T10017 on non-smp targets
Oct 7 2018, 5:29 AM
trofi committed rGHCed1615dc2537: testsuite: disable T14075 on non-smp targets (authored by trofi).
testsuite: disable T14075 on non-smp targets
Oct 7 2018, 5:29 AM

Oct 6 2018

trofi committed rGHC4e3562c04169: UNREG: don't prefix asm prefixes in via-C mode (authored by trofi).
UNREG: don't prefix asm prefixes in via-C mode
Oct 6 2018, 1:46 PM
trofi closed D5207: UNREG: don't prefix asm prefixes in via-C mode.
Oct 6 2018, 1:46 PM

Oct 5 2018

trofi created D5207: UNREG: don't prefix asm prefixes in via-C mode.
Oct 5 2018, 6:20 PM

Sep 22 2018

trofi created D5171: aclocal.m4: fix shell comment syntax: '#', not '$'.
Sep 22 2018, 5:55 PM

Aug 27 2018

trofi added a comment to D5085: driver: use --no-relax form (instead of -no-relax).
In D5085#139913, @Phyx wrote:

Hmm right, gold does support --relax, jus not --no-relax

Aug 27 2018, 3:35 PM

Aug 23 2018

trofi added a comment to D5085: driver: use --no-relax form (instead of -no-relax).

Why not just fix the configure time check instead of doing this at runtime. The ldIsGnuLd configure check should probably be extended to check for --no-relax support.

Aug 23 2018, 3:54 AM

Aug 22 2018

trofi added a comment to D5085: driver: use --no-relax form (instead of -no-relax).

Oh, that's unfortunate. --no-relax is very old flag in binutils (ld.bfd) and sparc did --no-relax forever.
Sounds like we will need to extend the driver to query $LD at runtime to check for --no-relax support.

Aug 22 2018, 5:16 PM

Aug 21 2018

trofi created D5085: driver: use --no-relax form (instead of -no-relax).
Aug 21 2018, 11:51 PM
trofi committed rGHC1cc9061fce42: driver: unconditionally disable relaxation when linking partially (authored by trofi).
driver: unconditionally disable relaxation when linking partially
Aug 21 2018, 2:50 PM
trofi closed D4888: driver: unconditionally disable relaxation when linking partially.
Aug 21 2018, 2:50 PM

Jul 25 2018

Ian Lynagh <ian@well-typed.com> committed rGHCDIFF7807289fd3a5: Gentoo calls 'w64' a mingw flavour with mingw-w64 runtime. (authored by trofi).
Gentoo calls 'w64' a mingw flavour with mingw-w64 runtime.
Jul 25 2018, 7:55 AM
Ian Lynagh <igloo@earth.li> committed rGHCDIFF607537a8424f: Gentoo's scanelf program found executable stack in many resulting binaries: *… (authored by trofi).
Gentoo's scanelf program found executable stack in many resulting binaries: *…
Jul 25 2018, 7:01 AM
Ian Lynagh <igloo@earth.li> committed rGHCDIFF3b322660f82d: An example of failure: "inplace/bin/ghc-stage1" -H32m -O -package-name… (authored by trofi).
An example of failure: "inplace/bin/ghc-stage1" -H32m -O -package-name…
Jul 25 2018, 6:54 AM
Ian Lynagh <igloo@earth.li> committed rGHCDIFF690f7ec4cd51: The patch fixes recognition of 'softfloat' targets as valid: ghc $ . (authored by trofi).
The patch fixes recognition of 'softfloat' targets as valid: ghc $ .
Jul 25 2018, 6:52 AM
trofi committed rGHCDIFFe45b7db233c7: configure: amend sanity check (authored by trofi).
configure: amend sanity check
Jul 25 2018, 6:41 AM
trofi committed rGHCDIFFc00ea87f7923: configure: triplet: accept i486 CPU (and more), more vendors and OSes (authored by trofi).
configure: triplet: accept i486 CPU (and more), more vendors and OSes
Jul 25 2018, 6:41 AM
trofi committed rGHCDIFF7bb9d7760929: libffi: backport incorrect detection of selinux (authored by trofi).
libffi: backport incorrect detection of selinux
Jul 25 2018, 6:41 AM
trofi committed rGHCDIFF33653031263a: ppc: switch handling of 'foreign import wrapper' (FIW) to libffi (authored by trofi).
ppc: switch handling of 'foreign import wrapper' (FIW) to libffi
Jul 25 2018, 6:33 AM
trofi committed rGHCDIFFe025c94f0dd6: ia64: switch handling of 'foreign import wrapper' (FIW) to libffi (authored by trofi).
ia64: switch handling of 'foreign import wrapper' (FIW) to libffi
Jul 25 2018, 6:32 AM
trofi committed rGHCDIFFd12690d5995d: * storage manager: preserve upper address bits on 64bit machines (thanks to… (authored by trofi).
* storage manager: preserve upper address bits on 64bit machines (thanks to…
Jul 25 2018, 6:32 AM
trofi committed rGHCDIFF615d88d1912a: Fixing link failure of compiler on ia64 ('-Wl,' prefixed value passed directly… (authored by trofi).
Fixing link failure of compiler on ia64 ('-Wl,' prefixed value passed directly…
Jul 25 2018, 6:32 AM
trofi committed rGHCDIFFa8dc46dcbeea: alpha: switch handling of 'foreign import wrapper' (FIW) to libffi (authored by trofi).
alpha: switch handling of 'foreign import wrapper' (FIW) to libffi
Jul 25 2018, 6:32 AM
trofi committed rGHCDIFFf2bfd33806f1: configure.ac: fix libm checks (Trac #3730) (authored by trofi).
configure.ac: fix libm checks (Trac #3730)
Jul 25 2018, 6:25 AM

Jul 18 2018

trofi committed rGHCe175aaf6918b: fix osReserveHeapMemory block alignment (authored by trofi).
fix osReserveHeapMemory block alignment
Jul 18 2018, 5:40 PM
trofi closed D4982: fix osReserveHeapMemory block alignment.
Jul 18 2018, 5:40 PM

Jul 17 2018

trofi created D4982: fix osReserveHeapMemory block alignment.
Jul 17 2018, 6:17 PM
trofi committed rGHC5e63a25249f3: aclocal.m4: narrow down 'riscv*' to 'riscv-*' and 'riscv32*' (authored by trofi).
aclocal.m4: narrow down 'riscv*' to 'riscv-*' and 'riscv32*'
Jul 17 2018, 2:15 PM

Jul 16 2018

trofi committed rGHCbeba89a0f166: aclocal.m4: allow riscv and riscv64 CPU (authored by trofi).
aclocal.m4: allow riscv and riscv64 CPU
Jul 16 2018, 4:34 PM
trofi committed rGHC8ec48990fee9: driver: skip -Bsymbolic on unregisterised targets (Trac #15338) (authored by trofi).
driver: skip -Bsymbolic on unregisterised targets (Trac #15338)
Jul 16 2018, 4:07 PM
trofi closed D4959: driver: don't enable -Bsymbolic on unregisterised targets (Trac #15338).
Jul 16 2018, 4:07 PM

Jul 13 2018

trofi added a comment to D4959: driver: don't enable -Bsymbolic on unregisterised targets (Trac #15338).

Ok, but we need to document the assumptions carefully here. I believe this is it:

Agreed. Added 'Note [-Bsymbolic assumptions by GHC]'.

Jul 13 2018, 4:18 PM
trofi updated the diff for D4959: driver: don't enable -Bsymbolic on unregisterised targets (Trac #15338).

Added 'Note [-Bsymbolic assumptions by GHC]' to describe -Bsymbolic delicacy.

Jul 13 2018, 4:04 PM

Jul 12 2018

trofi created D4959: driver: don't enable -Bsymbolic on unregisterised targets (Trac #15338).
Jul 12 2018, 6:07 PM

Jun 23 2018

trofi created D4888: driver: unconditionally disable relaxation when linking partially.
Jun 23 2018, 5:51 AM

Jun 16 2018

trofi created D4856: UNREG: fix CmmRegOff large offset handling on W64 platforms.
Jun 16 2018, 6:19 AM

Jun 15 2018

trofi committed rGHC01c9d95aca12: UNREG: PprC: add support for of W16 literals (Ticket #15237) (authored by trofi).
UNREG: PprC: add support for of W16 literals (Ticket #15237)
Jun 15 2018, 3:29 AM

Jun 13 2018

trofi updated the Trac tickets for D4837: UNREG: PprC: add support for of W32 literals.
Jun 13 2018, 1:09 AM

Jun 12 2018

trofi added a comment to D4837: UNREG: PprC: add support for of W32 literals.

Does this actually make the build succeed? I thought there was a bigger problem, namely Trac #15237

Jun 12 2018, 3:58 PM
trofi created D4837: UNREG: PprC: add support for of W32 literals.
Jun 12 2018, 10:16 AM

Jun 2 2018

trofi committed rGHC9ea45963ad2e: C codegen: print details of pprStatics panics (authored by trofi).
C codegen: print details of pprStatics panics
Jun 2 2018, 4:28 PM

Jun 1 2018

trofi committed rGHC9fd4ed90bcdb: UNREG: mark SRT as writable in generated C code (authored by trofi).
UNREG: mark SRT as writable in generated C code
Jun 1 2018, 11:22 AM
trofi closed D4731: UNREG: put SRT into read-only data section.
Jun 1 2018, 11:22 AM

May 28 2018

trofi added a comment to D4731: UNREG: put SRT into read-only data section.

Dropped constness. GHC used to have small SRTs (marked const in C codegen) and large SRTs (marked writable).

May 28 2018, 12:12 PM
trofi updated the diff for D4731: UNREG: put SRT into read-only data section.

Updated SRTs to mark writable.

May 28 2018, 12:09 PM

May 24 2018

trofi created D4731: UNREG: put SRT into read-only data section.
May 24 2018, 3:56 PM

May 14 2018

trofi committed rGHC79bbb23fd308: rts: export new absentSumFieldError from base (authored by trofi).
rts: export new absentSumFieldError from base
May 14 2018, 4:05 PM
trofi committed rGHC6d57a92f6076: utils/fs: use <sys/stat.h>, not <sys\stat.h> (authored by trofi).
utils/fs: use <sys/stat.h>, not <sys\stat.h>
May 14 2018, 3:22 AM

Apr 18 2018

trofi requested review of D4608: rts: fix format arguments for debugBelch calls on 32-bit systems.
Apr 18 2018, 4:27 PM

Mar 17 2018

trofi committed rGHC0693b0b05002: aclocal.m4: add OSHurd (debian patch) (authored by trofi).
aclocal.m4: add OSHurd (debian patch)
Mar 17 2018, 12:20 PM
trofi committed rGHC1522cf05c9c3: aclocal.m4: allow more GNU/Hurd tuples (authored by trofi).
aclocal.m4: allow more GNU/Hurd tuples
Mar 17 2018, 7:26 AM

Mar 10 2018

trofi committed rGHCe3ae0eb8e13a: testsuite: disable T13615 on non-smp targets (authored by trofi).
testsuite: disable T13615 on non-smp targets
Mar 10 2018, 6:47 AM

Mar 9 2018

trofi committed rGHCdd3906bf5deb: UNREG: fix implicit declarations from pdep and pext (authored by trofi).
UNREG: fix implicit declarations from pdep and pext
Mar 9 2018, 11:57 AM

Mar 5 2018

trofi accepted D4467: `--via-asm` only for windows targets.

Looks good! Thank you!

Mar 5 2018, 2:21 PM

Mar 4 2018

trofi raised a concern with rGHC5f6fcf7808b1: Compile with `--via-asm` when cross compiling..

Caused breakage at least on sparc: https://ghc.haskell.org/trac/ghc/ticket/14889

Mar 4 2018, 4:39 AM

Mar 3 2018

trofi added inline comments to D4439: Compile with `--via-asm` when cross compiling..
Mar 3 2018, 4:57 AM

Feb 25 2018

trofi accepted D4448: configure: Enable LD_NO_GOLD is set in all codepaths.

Looks good and works here locally!

Feb 25 2018, 1:52 PM

Dec 25 2017

trofi committed rGHC02aaeabd5851: aclocal.m4: add minimal support for nios2 architecture (authored by trofi).
aclocal.m4: add minimal support for nios2 architecture
Dec 25 2017, 9:53 AM

Dec 5 2017

trofi committed rGHC1ecbe9ccb10f: utils/hsc2hs: update submodule (authored by trofi).
utils/hsc2hs: update submodule
Dec 5 2017, 2:29 AM
trofi closed D4248: utils/hsc2hs: update submodule.
Dec 5 2017, 2:29 AM
trofi committed rGHC30d6373e6715: rts: fix filename case for mingw32 target (authored by trofi).
rts: fix filename case for mingw32 target
Dec 5 2017, 1:50 AM
trofi closed D4247: rts: fix filename case for mingw32 target.
Dec 5 2017, 1:50 AM

Dec 2 2017

trofi created D4248: utils/hsc2hs: update submodule.
Dec 2 2017, 5:23 AM
trofi added inline comments to D3913: Add stack traces on crashes on Windows.
Dec 2 2017, 5:20 AM
trofi created D4247: rts: fix filename case for mingw32 target.
Dec 2 2017, 5:17 AM

Nov 29 2017

trofi added a comment to D4048: Build utilities with the bootstrap compiler when cross compiling.

Created the following https://phabricator.haskell.org/D4243 for review.

Nov 29 2017, 5:16 PM
trofi added a comment to D4048: Build utilities with the bootstrap compiler when cross compiling.

The hsc2hs repo would need to have the following patch

From 94af7d9a27307f40a8b18da0f8e0fd9e9d77e818 Mon Sep 17 00:00:00 2001
From: Moritz Angermann <moritz.angermann@gmail.com>
Date: Sun, 1 Oct 2017 18:07:17 +0800
Subject: [PATCH] Use the same conditional install logic from unlit

This removes the make concurrency bug from the CrossCompilation fix, and uses the
same appraoch `utils/unlit` already uses.
---
 ghc.mk | 21 ++++++++-------------
 1 file changed, 8 insertions(+), 13 deletions(-)

diff --git a/ghc.mk b/ghc.mk
index c5f7473..8221829 100644
--- a/ghc.mk
+++ b/ghc.mk
@@ -5,27 +5,22 @@ utils/hsc2hs_dist_PROGNAME         = hsc2hs
 utils/hsc2hs_dist-install_PROGNAME = hsc2hs
 
 utils/hsc2hs_dist_SHELL_WRAPPER = YES
-utils/hsc2hs_dist_INSTALL = NO
 utils/hsc2hs_dist_INSTALL_INPLACE = YES
 
 utils/hsc2hs_dist-install_SHELL_WRAPPER = YES
-utils/hsc2hs_dist-install_INSTALL = YES
 utils/hsc2hs_dist-install_INSTALL_INPLACE = NO
 
-$(eval $(call build-prog,utils/hsc2hs,dist,0))
-
-# When CrossCompiling, we want to ship the binary for the
-# host, not for the target.  As such we need to compile
-# with the Bootstrap compiler rather than with the in-tree
-# stage1 compiler, which would result in a binary that
-# won't run on the host.
-ifeq "$(CrossCompiling)" "YES"
-# compile with stage 0 (bootstrap compiler)
-$(eval $(call build-prog,utils/hsc2hs,dist-install,0))
+ifeq "$(Stage1Only)" "YES"
+utils/hsc2hs_dist_INSTALL         = YES
+utils/hsc2hs_dist-install_INSTALL = NO
 else
-$(eval $(call build-prog,utils/hsc2hs,dist-install,1))
+utils/hsc2hs_dist_INSTALL         = NO
+utils/hsc2hs_dist-install_INSTALL = YES
 endif
 
+$(eval $(call build-prog,utils/hsc2hs,dist,0))
+$(eval $(call build-prog,utils/hsc2hs,dist-install,1))
+
 # After build-prog above
 utils/hsc2hs_dist_MODULES += Paths_hsc2hs
 utils/hsc2hs_dist-install_MODULES = $(utils/hsc2hs_dist_MODULES)
-- 
2.14.1

applied, to be consistent with the changes in updated changes in here.

Nov 29 2017, 4:49 PM

Nov 6 2017

trofi requested changes to D4017: Use EntryLabel to represent block labels.

This change also seems to break dynamic build:

Nov 6 2017, 8:19 AM

Nov 2 2017

trofi committed rGHC51321cf2eb3b: rts/PrimOps.cmm: add declaration for heapOverflow closure (authored by trofi).
rts/PrimOps.cmm: add declaration for heapOverflow closure
Nov 2 2017, 6:27 PM

Oct 20 2017

trofi accepted D4114: Move ghc{autoconf,platform,version}.h to includes/dist; hide includes/ from stage0 compiler.

Looks good! Thank you!

Oct 20 2017, 2:07 AM

Oct 16 2017

trofi accepted D4100: updateThunk: indirectee can be tagged.
Oct 16 2017, 2:53 PM

Sep 29 2017

trofi added a comment to D4048: Build utilities with the bootstrap compiler when cross compiling.

dist-install is just a name of intermediate directory nearby source of a tool or library.
The directory name itself does not carry semantic meaning and is just a suffix for rest
of variables like utils/hpc_dist-install_INSTALL = YES (vs, say utils/hpc_dist_INSTALL = YES)

Sep 29 2017, 5:09 AM
trofi added a comment to D4048: Build utilities with the bootstrap compiler when cross compiling.

The commit message does not explain what exactly changes in:

  • build process
  • what changes in installed artifacts
Sep 29 2017, 3:50 AM

Sep 24 2017

trofi accepted D4017: Use EntryLabel to represent block labels.
Sep 24 2017, 11:08 AM
trofi committed rGHCb3ae47caf2f2: don't allow AsmTempLabel in UNREG mode (Trac #14264) (authored by trofi).
don't allow AsmTempLabel in UNREG mode (Trac #14264)
Sep 24 2017, 7:29 AM

Sep 23 2017

trofi accepted D4004: Additional LLVM_TARGET logic..
Sep 23 2017, 3:34 AM
trofi accepted D4014: Fix AsmTempLabel.

Let's try that. If it will also fail at worst we'll invert it back to 'if not UNREG'.

Sep 23 2017, 2:30 AM

Sep 20 2017

trofi added inline comments to D3883: Add gen-dll as replacement for dll-split.
Sep 20 2017, 5:27 PM
trofi committed rGHCd7705f2fbead: aclocal.m4: call cygpath on mingw32 only (authored by trofi).
aclocal.m4: call cygpath on mingw32 only
Sep 20 2017, 5:21 PM
trofi added inline comments to D3883: Add gen-dll as replacement for dll-split.
Sep 20 2017, 4:49 PM

Jul 22 2017

trofi added a comment to D3741: Stg.h: Reintroduce removed EI_/II_ for bootstrapping.

The GHC_INCLUDE_DIRS to stage0 was added in ea310f9956179f91ca973bc747b0bc7b061bc174:

Jul 22 2017, 12:46 PM
trofi accepted D3775: fix dllwrap issue..

Thank you!

Jul 22 2017, 8:17 AM
trofi added inline comments to D3637: Provide way to build using existing C compiler on Windows..
Jul 22 2017, 5:15 AM

Jul 15 2017

trofi accepted D3741: Stg.h: Reintroduce removed EI_/II_ for bootstrapping.

Nice and simple fix. Apologies for caused breakage. Didin't realize
we leak-in new Stg.h even when stage0 is invoked.

Jul 15 2017, 1:20 PM

Jul 8 2017

trofi committed rGHCc2303dff95aa: aclocal.m4: allow arbitrary <vendor> string in toolchain triplets (authored by trofi).
aclocal.m4: allow arbitrary <vendor> string in toolchain triplets
Jul 8 2017, 4:01 AM

Jul 6 2017

trofi committed rGHCf3979b7fbd83: lowercase clang (authored by angerman).
lowercase clang
Jul 6 2017, 2:02 AM

Jul 5 2017

trofi committed rGHC3eeb55e9578f: rts/sm/Storage.c: tweak __clear_cache proto for clang (authored by trofi).
rts/sm/Storage.c: tweak __clear_cache proto for clang
Jul 5 2017, 3:26 AM
trofi committed rGHC7040660528f5: Revert "rts/sm/Storage.c: tweak __clear_cache proto for clang" (authored by trofi).
Revert "rts/sm/Storage.c: tweak __clear_cache proto for clang"
Jul 5 2017, 3:25 AM
trofi added a reverting change for rGHC9492703a5862: rts/sm/Storage.c: tweak __clear_cache proto for clang: rGHC7040660528f5: Revert "rts/sm/Storage.c: tweak __clear_cache proto for clang".
Jul 5 2017, 3:25 AM
trofi committed rGHC9492703a5862: rts/sm/Storage.c: tweak __clear_cache proto for clang (authored by trofi).
rts/sm/Storage.c: tweak __clear_cache proto for clang
Jul 5 2017, 3:12 AM

Jun 22 2017

trofi committed rGHC34b7f63e285e: UNREG: use __builtin___clear_cache where available (authored by trofi).
UNREG: use __builtin___clear_cache where available
Jun 22 2017, 4:36 PM

Jun 21 2017

trofi committed rGHCc6fe403ec714: Revert "UNREG: use __builtin___clear_cache where available" (authored by trofi).
Revert "UNREG: use __builtin___clear_cache where available"
Jun 21 2017, 4:16 PM
trofi added a reverting change for rGHC6dd1257fdd4d: UNREG: use __builtin___clear_cache where available: rGHCc6fe403ec714: Revert "UNREG: use __builtin___clear_cache where available".
Jun 21 2017, 4:16 PM
trofi committed rGHC6dd1257fdd4d: UNREG: use __builtin___clear_cache where available (authored by trofi).
UNREG: use __builtin___clear_cache where available
Jun 21 2017, 3:30 PM

Jun 1 2017

trofi committed rGHCd39a3409acd3: aclocal.m4: add support for versioned darwin triplets (authored by trofi).
aclocal.m4: add support for versioned darwin triplets
Jun 1 2017, 4:35 PM

May 25 2017

trofi committed rGHCf011f587ca02: rules: add per-library EXTRA_HC_OPTS (authored by trofi).
rules: add per-library EXTRA_HC_OPTS
May 25 2017, 4:56 PM