trofi (Sergei Trofimovich)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Jun 9 2014, 4:10 AM (163 w, 2 d)
Availability
Available

Recent Activity

Sat, Jul 22

trofi added a comment to D3741: Stg.h: Reintroduce removed EI_/II_ for bootstrapping.

The GHC_INCLUDE_DIRS to stage0 was added in ea310f9956179f91ca973bc747b0bc7b061bc174:

Sat, Jul 22, 12:46 PM
trofi accepted D3775: fix dllwrap issue..

Thank you!

Sat, Jul 22, 8:17 AM
trofi added inline comments to D3637: Provide way to build using existing C compiler on Windows..
Sat, Jul 22, 5:15 AM

Sat, Jul 15

trofi accepted D3741: Stg.h: Reintroduce removed EI_/II_ for bootstrapping.

Nice and simple fix. Apologies for caused breakage. Didin't realize
we leak-in new Stg.h even when stage0 is invoked.

Sat, Jul 15, 1:20 PM

Sat, Jul 8

trofi committed rGHCc2303dff95aa: aclocal.m4: allow arbitrary <vendor> string in toolchain triplets (authored by trofi).
aclocal.m4: allow arbitrary <vendor> string in toolchain triplets
Sat, Jul 8, 4:01 AM

Thu, Jul 6

trofi committed rGHCf3979b7fbd83: lowercase clang (authored by angerman).
lowercase clang
Thu, Jul 6, 2:02 AM

Wed, Jul 5

trofi committed rGHC3eeb55e9578f: rts/sm/Storage.c: tweak __clear_cache proto for clang (authored by trofi).
rts/sm/Storage.c: tweak __clear_cache proto for clang
Wed, Jul 5, 3:26 AM
trofi committed rGHC7040660528f5: Revert "rts/sm/Storage.c: tweak __clear_cache proto for clang" (authored by trofi).
Revert "rts/sm/Storage.c: tweak __clear_cache proto for clang"
Wed, Jul 5, 3:25 AM
trofi added a reverting commit for rGHC9492703a5862: rts/sm/Storage.c: tweak __clear_cache proto for clang: rGHC7040660528f5: Revert "rts/sm/Storage.c: tweak __clear_cache proto for clang".
Wed, Jul 5, 3:25 AM
trofi committed rGHC9492703a5862: rts/sm/Storage.c: tweak __clear_cache proto for clang (authored by trofi).
rts/sm/Storage.c: tweak __clear_cache proto for clang
Wed, Jul 5, 3:12 AM

Jun 22 2017

trofi committed rGHC34b7f63e285e: UNREG: use __builtin___clear_cache where available (authored by trofi).
UNREG: use __builtin___clear_cache where available
Jun 22 2017, 4:36 PM

Jun 21 2017

trofi committed rGHCc6fe403ec714: Revert "UNREG: use __builtin___clear_cache where available" (authored by trofi).
Revert "UNREG: use __builtin___clear_cache where available"
Jun 21 2017, 4:16 PM
trofi added a reverting commit for rGHC6dd1257fdd4d: UNREG: use __builtin___clear_cache where available: rGHCc6fe403ec714: Revert "UNREG: use __builtin___clear_cache where available".
Jun 21 2017, 4:16 PM
trofi committed rGHC6dd1257fdd4d: UNREG: use __builtin___clear_cache where available (authored by trofi).
UNREG: use __builtin___clear_cache where available
Jun 21 2017, 3:30 PM

Jun 1 2017

trofi committed rGHCd39a3409acd3: aclocal.m4: add support for versioned darwin triplets (authored by trofi).
aclocal.m4: add support for versioned darwin triplets
Jun 1 2017, 4:35 PM

May 25 2017

trofi committed rGHCf011f587ca02: rules: add per-library EXTRA_HC_OPTS (authored by trofi).
rules: add per-library EXTRA_HC_OPTS
May 25 2017, 4:56 PM

May 23 2017

trofi committed rGHC107601058b61: ghc.mk: rename installed ghc-stage1 on non-windows (authored by trofi).
ghc.mk: rename installed ghc-stage1 on non-windows
May 23 2017, 4:31 AM
trofi committed rGHC1fd06de4e98d: aclocal.m4: allow override of dllwrap and windres when cross-compiling (authored by trofi).
aclocal.m4: allow override of dllwrap and windres when cross-compiling
May 23 2017, 4:31 AM
trofi committed rGHC432a1f18327a: mk/config.mk.in: lower -O2 optimization down to -O1 on UNREG (authored by trofi).
mk/config.mk.in: lower -O2 optimization down to -O1 on UNREG
May 23 2017, 4:31 AM

May 16 2017

trofi added inline comments to D3589: Add support for producing position-independent executables.
May 16 2017, 3:03 AM

May 14 2017

trofi committed rGHCd5414dd61b54: rts/linker/ElfTypes.h: restore powerps (and others) support (authored by trofi).
rts/linker/ElfTypes.h: restore powerps (and others) support
May 14 2017, 2:34 PM
trofi closed D3583: rts/linker/ElfTypes.h: restore powerps (and others) support by committing rGHCd5414dd61b54: rts/linker/ElfTypes.h: restore powerps (and others) support.
May 14 2017, 2:34 PM
trofi committed rGHC230416f8b6f6: rts: annotate switch/case with '/* fallthrough */' (authored by trofi).
rts: annotate switch/case with '/* fallthrough */'
May 14 2017, 2:34 PM
trofi committed rGHC20c39b7743a2: ProfilerReportJson.c: fix out-of-bounds access (authored by trofi).
ProfilerReportJson.c: fix out-of-bounds access
May 14 2017, 2:34 PM
Herald added a reviewer for D3583: rts/linker/ElfTypes.h: restore powerps (and others) support: austin.
May 14 2017, 4:48 AM
trofi committed rGHC1269aff19e7b: includes/Stg.h: '#if sparch_HOST_ARCH' -> '#if defined(sparch_HOST_ARCH)' (authored by trofi).
includes/Stg.h: '#if sparch_HOST_ARCH' -> '#if defined(sparch_HOST_ARCH)'
May 14 2017, 4:35 AM

Apr 25 2017

trofi accepted D3499: configure: Kill off FP_ARG_WITH_*.

Yay! Thank you! Perhaps worth explicitly mentioning in release notes file.

Apr 25 2017, 4:11 PM

Apr 23 2017

trofi committed rGHC74e5ec9e63ff: ghc.mk: fix 'make install' for cross-mingw32 (authored by trofi).
ghc.mk: fix 'make install' for cross-mingw32
Apr 23 2017, 9:40 AM
trofi committed rGHC8908ba31c4dc: ghc: tweak cross-compilation to mingw32 (authored by trofi).
ghc: tweak cross-compilation to mingw32
Apr 23 2017, 9:20 AM
trofi committed rGHC745032dd02da: rts: tweak cross-compilation to mingw32 (authored by trofi).
rts: tweak cross-compilation to mingw32
Apr 23 2017, 7:55 AM
trofi committed rGHCfe37e2c6ab9d: aclocal.m4: treat '*-w64-mingw32' targets as windows (authored by trofi).
aclocal.m4: treat '*-w64-mingw32' targets as windows
Apr 23 2017, 7:55 AM
trofi committed rGHC58a656956f70: configure.ac: print paths to dllwrap and windres (authored by trofi).
configure.ac: print paths to dllwrap and windres
Apr 23 2017, 7:55 AM

Apr 21 2017

trofi committed rGHC32a5ba993de4: Build system: fix bindist for cross-build GHC (authored by Fangrui Song <i@maskray.me>).
Build system: fix bindist for cross-build GHC
Apr 21 2017, 4:33 PM
Herald added a reviewer for D3481: compiler/cmm/PprC.hs: constify labels in .rodata: austin.
Apr 21 2017, 4:40 AM
trofi committed rGHC24cf688b4882: utils/debugNCG: remove old tool (authored by trofi).
utils/debugNCG: remove old tool
Apr 21 2017, 2:29 AM
trofi closed D3476: utils/debugNCG: remove old tool by committing rGHC24cf688b4882: utils/debugNCG: remove old tool.
Apr 21 2017, 2:29 AM

Apr 20 2017

trofi committed rGHC526d2ebc218f: pprDebugCLabel: drop duplicate trailing ')' (authored by trofi).
pprDebugCLabel: drop duplicate trailing ')'
Apr 20 2017, 3:14 PM
trofi committed rGHCa18f58d2290c: testsuite: disable 'optllvm' for unregisterised compiler (authored by trofi).
testsuite: disable 'optllvm' for unregisterised compiler
Apr 20 2017, 2:23 PM
trofi created D3476: utils/debugNCG: remove old tool.
Apr 20 2017, 1:53 PM

Apr 17 2017

trofi added a comment to rGHC79848f18805a: aclocal.m4: respect user's --with-ar= choice.

Filed https://ghc.haskell.org/trac/ghc/ticket/13583 for it. Single ticket might be hard to track all the disparate places we allow tool overrides but it's a start.

Apr 17 2017, 12:15 PM
trofi committed rGHC79848f18805a: aclocal.m4: respect user's --with-ar= choice (authored by trofi).
aclocal.m4: respect user's --with-ar= choice
Apr 17 2017, 7:58 AM
trofi committed rGHC1ca188c74e70: configure.ac: print resolved 'ar' and 'ranlib' tools (authored by trofi).
configure.ac: print resolved 'ar' and 'ranlib' tools
Apr 17 2017, 7:58 AM
trofi committed rGHCa92ff5d66182: hs_add_root() RTS API removal (authored by trofi).
hs_add_root() RTS API removal
Apr 17 2017, 7:57 AM
trofi closed D3460: hs_add_root() RTS API removal by committing rGHCa92ff5d66182: hs_add_root() RTS API removal.
Apr 17 2017, 7:57 AM
trofi updated the diff for D3460: hs_add_root() RTS API removal.

Tweaked release notes entry following Simon's suggestion.

Apr 17 2017, 5:41 AM
trofi updated the diff for D3460: hs_add_root() RTS API removal.
  • Added ghc-8.4.1 release notes entry.
  • Removed unrelated #include <stdlib.h>.
Apr 17 2017, 5:30 AM
trofi added inline comments to D3460: hs_add_root() RTS API removal.
Apr 17 2017, 5:09 AM

Apr 16 2017

trofi committed rGHC29ef71412af4: UNREG: fix spelling of '-split-objs' in warning (authored by trofi).
UNREG: fix spelling of '-split-objs' in warning
Apr 16 2017, 12:30 PM
trofi committed rGHC5fd75d737dec: UNREG: remove dead code around -split-objs (authored by trofi).
UNREG: remove dead code around -split-objs
Apr 16 2017, 11:52 AM
trofi updated the diff for D3460: hs_add_root() RTS API removal.

Removed even more references to __stginit in comments.
Removed unused stg_init and stg_init_finish rts functions.

Apr 16 2017, 7:32 AM
Herald added a reviewer for D3460: hs_add_root() RTS API removal: austin.
Apr 16 2017, 6:20 AM
trofi committed rGHC295f97f74dcf: rts/RtsUtils.c: drop stale comments (authored by trofi).
rts/RtsUtils.c: drop stale comments
Apr 16 2017, 5:15 AM

Apr 11 2017

trofi accepted D3440: Caret diagnostics: Avoid decoding whole module if only specific line is needed.

Looks nice! Thank you!

Apr 11 2017, 4:04 PM

Apr 10 2017

trofi added inline comments to D3440: Caret diagnostics: Avoid decoding whole module if only specific line is needed.
Apr 10 2017, 4:32 PM
trofi accepted D3438: [Elf/arm] Thumb indicator bit only for STT_FUNC.
Apr 10 2017, 2:28 AM

Apr 9 2017

trofi added a comment to D3432: fix 'make install' for cross-stage2.

I can expand existing https://ghc.haskell.org/trac/ghc/wiki/Building/Installing with cross-compiling/cross-building case.

Apr 9 2017, 6:15 PM
trofi added a comment to D2875: Cache the files in StringBuffer to improve efficiency.

In http://ghc.haskell.org/trac/ghc/ticket/13527 we've encountered an interesting effect of caret diagnostic:
the line from file being printed in not from haskell file, but from huge autogenerated assembler file.

Apr 9 2017, 12:28 PM

Apr 8 2017

trofi committed rGHCff84d052850b: cross-build 'unlit' and 'hp2ps' for stage2 install (authored by trofi).
cross-build 'unlit' and 'hp2ps' for stage2 install
Apr 8 2017, 4:59 AM
trofi committed rGHC54895c90440c: fix 'make install' for cross-stage2 (authored by trofi).
fix 'make install' for cross-stage2
Apr 8 2017, 4:59 AM
trofi closed D3432: fix 'make install' for cross-stage2 by committing rGHC54895c90440c: fix 'make install' for cross-stage2.
Apr 8 2017, 4:59 AM

Apr 7 2017

trofi created D3432: fix 'make install' for cross-stage2.
Apr 7 2017, 4:26 AM

Apr 6 2017

trofi committed rGHC732b3dbbff19: add $(CrossCompilePrefix) to 'runghc' and 'ghci' (authored by trofi).
add $(CrossCompilePrefix) to 'runghc' and 'ghci'
Apr 6 2017, 5:24 PM
trofi committed rGHC4671e3c17cb6: config.mk.in: removed stray HaveLibDL assignment (authored by trofi).
config.mk.in: removed stray HaveLibDL assignment
Apr 6 2017, 4:12 AM
trofi committed rGHCf2685df3b10e: avoid $(CrossCompilerPrefix) for stage2 install (authored by trofi).
avoid $(CrossCompilerPrefix) for stage2 install
Apr 6 2017, 4:12 AM
trofi committed rGHC6ff98b962db1: config.mk.in: remove phase=0 hack for CrossCompilePrefix (authored by trofi).
config.mk.in: remove phase=0 hack for CrossCompilePrefix
Apr 6 2017, 4:12 AM
trofi committed rGHC844704b4883e: Use non-canocalized triple as cross-compiler prefix (authored by trofi).
Use non-canocalized triple as cross-compiler prefix
Apr 6 2017, 4:12 AM

Apr 5 2017

trofi added inline comments to D3358: base: Implement bit casts between word and float types.
Apr 5 2017, 2:48 AM

Apr 4 2017

trofi added inline comments to D3358: base: Implement bit casts between word and float types.
Apr 4 2017, 4:10 PM

Apr 3 2017

trofi committed rGHC1e58efb16f76: hp2ps: install shell wrapper (authored by trofi).
hp2ps: install shell wrapper
Apr 3 2017, 4:49 AM

Apr 2 2017

trofi committed rGHC911055689eca: configure.ac: add aarch64 to list of registerised (authored by trofi).
configure.ac: add aarch64 to list of registerised
Apr 2 2017, 3:17 PM
trofi committed rGHCcb18447c75e7: configure.ac: fix NCG support in --target= (authored by trofi).
configure.ac: fix NCG support in --target=
Apr 2 2017, 2:06 PM
trofi committed rGHCd89b0471888b: FastMutInt: fix Int and Ptr sizes when crosscompiling (authored by trofi).
FastMutInt: fix Int and Ptr sizes when crosscompiling
Apr 2 2017, 10:13 AM
trofi closed D3405: FastMutInt: fix Int and Ptr sizes when crosscompiling by committing rGHCd89b0471888b: FastMutInt: fix Int and Ptr sizes when crosscompiling.
Apr 2 2017, 10:13 AM
trofi committed rGHC03e34256e2cb: compiler/ghc.mk: fix GhcWithInterpreter=NO build failure (authored by trofi).
compiler/ghc.mk: fix GhcWithInterpreter=NO build failure
Apr 2 2017, 8:15 AM

Apr 1 2017

trofi added inline comments to D3405: FastMutInt: fix Int and Ptr sizes when crosscompiling.
Apr 1 2017, 12:31 PM
trofi updated the diff for D3405: FastMutInt: fix Int and Ptr sizes when crosscompiling.

Added a few examples what should be used instead of target platform macros:

  • host's Bits instance
  • target's platformConstants from DynFlags
Apr 1 2017, 12:15 PM
trofi updated the diff for D3405: FastMutInt: fix Int and Ptr sizes when crosscompiling.

Fixed 's/pas/past/' typo in comment. Added this DR as another example
on crosscompilation bugs.

Apr 1 2017, 8:16 AM
trofi created D3405: FastMutInt: fix Int and Ptr sizes when crosscompiling.
Apr 1 2017, 8:05 AM
trofi committed rGHCa094aa7dcf92: rts: print incorrect prev_what_next (authored by trofi).
rts: print incorrect prev_what_next
Apr 1 2017, 6:12 AM
trofi committed rGHC74615f412ad3: UNREG: ignore -fllvm (Trac #13495) (authored by trofi).
UNREG: ignore -fllvm (Trac #13495)
Apr 1 2017, 5:12 AM

Mar 29 2017

trofi added inline comments to D3397: unique: fix UNIQUE_BITS crosscompilation (Trac #13491).
Mar 29 2017, 4:12 PM
trofi updated the diff for D3397: unique: fix UNIQUE_BITS crosscompilation (Trac #13491).

Fixed typo spotted by Ryan. Fixed wrong comment about unique stucture:
I've got bits in the wrong order.

Mar 29 2017, 4:04 PM
trofi created D3397: unique: fix UNIQUE_BITS crosscompilation (Trac #13491).
Mar 29 2017, 2:59 PM

Mar 26 2017

trofi committed rGHC6c73504ac5f4: linker: fix OpenBSD build failure, EM_PPC64 is not defined there (authored by trofi).
linker: fix OpenBSD build failure, EM_PPC64 is not defined there
Mar 26 2017, 9:53 AM

Mar 17 2017

trofi accepted D3359: x86 nativeGen: Fix test with mask in range [128,255] (#13425).

Nice catch!

Mar 17 2017, 5:03 PM

Mar 13 2017

trofi accepted D3333: unlit: replace the SHEBANG with an empty line.

That was quick! Thank you!

Mar 13 2017, 3:14 AM

Mar 10 2017

trofi committed rGHC46246a6d57c3: implement missing Fabs{32,64} on i386 NCG and UNREG (authored by trofi).
implement missing Fabs{32,64} on i386 NCG and UNREG
Mar 10 2017, 3:56 AM

Mar 9 2017

trofi committed rGHC9e15db49b57d: KQueue.hsc: fix build failure on FreeBSD (authored by trofi).
KQueue.hsc: fix build failure on FreeBSD
Mar 9 2017, 2:38 AM
trofi closed D3300: KQueue.hsc: fix build failure on FreeBSD by committing rGHC9e15db49b57d: KQueue.hsc: fix build failure on FreeBSD.
Mar 9 2017, 2:37 AM

Mar 8 2017

trofi created D3300: KQueue.hsc: fix build failure on FreeBSD.
Mar 8 2017, 3:28 PM

Feb 24 2017

trofi accepted D3188: Bring sanity to openTempFile.
Feb 24 2017, 2:18 AM
trofi accepted D3187: build system: Persist CrossCompiling in binary distributions.
Feb 24 2017, 2:14 AM

Feb 22 2017

trofi accepted D3164: Use half as much memory when reading interfaces.

Really nice catch! :)

Feb 22 2017, 3:44 PM

Feb 11 2017

trofi committed rGHC594123f57779: IcmmMachOpFoldM: clarify panic message (authored by trofi).
IcmmMachOpFoldM: clarify panic message
Feb 11 2017, 7:12 AM

Feb 10 2017

trofi added a comment to D3122: Binary: Correct endian issue when cross-compiling.
In D3122#91402, @trofi wrote:

Looks good. Thank you!

Running a cross build for m68k target to verify if it works. It will take a while.

Feb 10 2017, 2:06 PM
trofi accepted D3122: Binary: Correct endian issue when cross-compiling.

Looks good. Thank you!

Feb 10 2017, 3:07 AM

Feb 9 2017

trofi added a comment to D2908: Use proper primitives in Utils.Binary.

Looks like this change caused crosscompiler breakage
when host and target have different endianness and word size:

https://ghc.haskell.org/trac/ghc/ticket/13259
Feb 9 2017, 5:04 PM

Jan 29 2017

trofi committed rGHC4441f90738e2: UNREG: add a forward declaration for local literals (authored by trofi).
UNREG: add a forward declaration for local literals
Jan 29 2017, 3:26 PM
trofi committed rGHC34a0205587c8: UNREG: fix "_bytes" string literal forward declaration (authored by trofi).
UNREG: fix "_bytes" string literal forward declaration
Jan 29 2017, 1:46 PM

Dec 18 2016

trofi committed rGHCd327ebd61d84: regalloc_unit_tests: disable on UNREG targets (authored by trofi).
regalloc_unit_tests: disable on UNREG targets
Dec 18 2016, 11:35 AM