thomie (Thomas Miedema)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 26 2014, 12:47 PM (224 w, 3 d)

Recent Activity

Aug 21 2018

thomie added a comment to D5067: [WIP] Hi Haddock: Enable haddock to generate docs from .hi-files.

Do we need a separate place for discussing the design or do we simply need a stub ticket that we can reference?

Aug 21 2018, 1:03 AM

Aug 16 2018

thomie added a comment to D5067: [WIP] Hi Haddock: Enable haddock to generate docs from .hi-files.

Please mention the Trac ticket number in the summary (click "Edit revision"). Create a ticket first if it doesn't exist yet.

Aug 16 2018, 10:23 PM
thomie added a comment to D5057: [WIP] Remove Haddock tokens from the grammar.

I rebased, did some work, then did arc diff. Unfortunately, it looks like the base commit of this diff is the still the pre-rebase one. How would I go about fixing this?

Aug 16 2018, 10:14 PM
thomie abandoned D452: fixes #8944 - Now printing a warning 'Ignoring invalid haddock comment' instead of an error.

Subsumed by D5057.

Aug 16 2018, 10:09 PM

Aug 14 2018

thomie added a reviewer for D5066: Update unicode tables to v. 12 of the standard: Azel.

@Azel: as the author of D4593, could you maybe review this and address @ulysses4ever's comments.

Aug 14 2018, 11:14 PM

Aug 13 2018

thomie accepted D5055: Fix ambiguous/out-of-scope Haddock identifiers.

I don't know about ExitException and mtimes. Maybe just leave it for somebody else to fix.

Aug 13 2018, 5:56 AM
thomie added a comment to D4953: Support for deprecating exports.

@alanasp: maybe you could add a short blurp to the release notes?

Aug 13 2018, 2:10 AM
thomie updated the Trac tickets for D4713: Mark code related symbols as @function not @object.
Aug 13 2018, 2:06 AM

Aug 12 2018

thomie added a reviewer for D5064: Fix the __GLASGOW_HASKELL__ comparison: mpickering.
Aug 12 2018, 8:59 AM
thomie added a comment to D4861: Introduce flag -keep-hscpp-files (#10869).

RolandSenn: one last thing, before @bgamari gets here. Maybe you could add a blurp to the release notes about this new flag.

Aug 12 2018, 4:28 AM

Aug 11 2018

thomie accepted D5062: Simplify testsuite driver, part 2.

LGTM

Aug 11 2018, 5:44 PM
thomie accepted D5061: Simplify testsuite driver.

I'm happy clean_cmd is finally gone.

Aug 11 2018, 11:35 AM
thomie added a comment to D4997: Fix for #12714: Test T9405 fails on Windows..

Please inform me, if these 2 tests can be written with less redundandency.

Aug 11 2018, 5:31 AM

Aug 8 2018

thomie accepted D4861: Introduce flag -keep-hscpp-files (#10869).

I guess specifying -E together with -keep-hscpp-files will write both files? That's ok though.

Aug 8 2018, 12:28 PM

Aug 7 2018

thomie added a comment to D4861: Introduce flag -keep-hscpp-files (#10869).

The file produced by the -E flag however, will continue to be named *.hspp, although it is the output of the C pre-processor.

Aug 7 2018, 2:33 PM

Aug 6 2018

Herald updated subscribers of D3839: users_guide: Convert mkUserGuidePart generation to a Sphinx extension [skip ci].
Aug 6 2018, 6:44 PM
thomie awarded D3839: users_guide: Convert mkUserGuidePart generation to a Sphinx extension [skip ci] a Mountain of Wealth token.
Aug 6 2018, 6:09 PM
thomie awarded D4953: Support for deprecating exports a Mountain of Wealth token.
Aug 6 2018, 5:01 PM
thomie added a comment to D4934: Fix #line pragmas in nested comments.

A patch for the second-oldest still open bug!

Aug 6 2018, 4:44 PM

Aug 5 2018

thomie accepted D5046: Testsuite driver: fix encoding issue when calling ghc-pkg.

Ah, ok, that makes sense.

Aug 5 2018, 4:20 PM
thomie added a reviewer for D5046: Testsuite driver: fix encoding issue when calling ghc-pkg: Phyx.

Nice find.

Aug 5 2018, 1:49 PM

Aug 4 2018

thomie awarded D4761: vectorise: Put it out of its misery a Party Time token.
Aug 4 2018, 1:14 PM
thomie requested changes to D4861: Introduce flag -keep-hscpp-files (#10869).

@RolandSenn: sorry for the late reply.

Aug 4 2018, 10:35 AM
thomie abandoned D1652: WIP. Testing only. Run validate --slow.
Aug 4 2018, 4:49 AM

Aug 3 2018

thomie updated the diff for D5039: Strip ../ from testdir (fixes #15469).

Handle dir='.'

Aug 3 2018, 1:18 PM

Aug 2 2018

thomie created D5039: Strip ../ from testdir (fixes #15469).
Aug 2 2018, 5:58 PM

Jan 22 2017

thomie added a comment to D3000: Remove clean_cmd and extra_clean usage from .T files.

I mean, does it remove the definition so that it is definitely removed everywhere?

Jan 22 2017, 11:30 AM
thomie added a comment to D3000: Remove clean_cmd and extra_clean usage from .T files.

Does this commit remove extra_clean somewhere?

Jan 22 2017, 11:15 AM
thomie retitled D3000: Remove clean_cmd and extra_clean usage from .T files from to Remove clean_cmd and extra_clean usage from .T files.
Jan 22 2017, 8:56 AM

Oct 19 2016

thomie added inline comments to D2564: Introduce ConApp to Core.
Oct 19 2016, 5:11 PM

Oct 18 2016

thomie awarded D2605: Allow top-level string literals in Core (#8472) a Like token.
Oct 18 2016, 11:25 AM

Aug 28 2016

thomie updated the Trac tickets for D2485: Read in unfolding with -O0 and check for inline on usage (#9370).
Aug 28 2016, 5:57 PM
thomie awarded D2483: rts: enable parallel GC scan of large (32M+) allocation area a Mountain of Wealth token.
Aug 28 2016, 5:53 PM
thomie added inline comments to D2484: Less scary arity mismatch error message when deriving.
Aug 28 2016, 5:51 PM
thomie accepted D2461: Add -flocal-ghci-history flag (#9089)..

LGTM

Aug 28 2016, 5:45 PM
thomie set the repository for D2480: Fix startsVarSym and refactor operator predicates (fixes #4239) to rGHC Glasgow Haskell Compiler.
Aug 28 2016, 5:42 PM
thomie awarded D2464: Clarify pkg selection when multiple versions are available a Like token.
Aug 28 2016, 5:35 PM
thomie added a comment to D535: Added a Plugin function to install hooks.

What is the ticket number for this? Click "Edit revision" to add it, thanks.

Aug 28 2016, 2:58 PM · GHC
thomie updated the Trac tickets for D2458: Add -fdefer-out-of-scope-variables flag (#12170)..
Aug 28 2016, 2:54 PM
thomie added a comment to D2209: Support for noinline magic function..

For future reference: this feature was added to fix Trac #10083 (I think).

Aug 28 2016, 1:14 PM
thomie accepted D2458: Add -fdefer-out-of-scope-variables flag (#12170)..

One more.

Aug 28 2016, 9:54 AM
thomie requested changes to D2458: Add -fdefer-out-of-scope-variables flag (#12170)..

Currently the name of the warning flag in the documentation and in the implementation don't match.

Aug 28 2016, 5:29 AM

Aug 27 2016

thomie requested changes to D2461: Add -flocal-ghci-history flag (#9089)..

Missing changelog entry: docs/users_guide/8.2.1-notes.rst
Missing update to utils/mkUserGuidePart/Options/Misc.hs

Aug 27 2016, 2:27 PM
thomie updated the Trac tickets for D2461: Add -flocal-ghci-history flag (#9089)..
Aug 27 2016, 1:18 PM
thomie requested changes to D2458: Add -fdefer-out-of-scope-variables flag (#12170)..
Aug 27 2016, 11:20 AM
thomie added a comment to D2458: Add -fdefer-out-of-scope-variables flag (#12170)..

Changelog entry is missing. This would go in docs/users_guide/8.2.1-notes.rst normally.

Aug 27 2016, 11:20 AM

Jul 24 2016

thomie committed rGHC4036c1f11057: Testsuite: fix T10482a (authored by thomie).
Testsuite: fix T10482a
Jul 24 2016, 6:38 PM

Jul 22 2016

thomie accepted D2406: Expanded one abbreviation in documentation #12405.

Thanks!

Jul 22 2016, 11:36 AM
thomie requested changes to D2406: Expanded one abbreviation in documentation #12405.

Just some final remarks. After that I think we can push this (before any merge problems arise), and perhaps continue in a new Diff.

Jul 22 2016, 7:33 AM

Jul 21 2016

thomie accepted D2415: check that the number of parallel build is greater than 0 (fixes #12062).
Jul 21 2016, 10:49 AM

Jul 20 2016

thomie requested changes to D2415: check that the number of parallel build is greater than 0 (fixes #12062).

What's with the Template Haskell in the test? Is that necessary?

Jul 20 2016, 12:58 PM
thomie added a comment to D2407: Support SCC pragmas in declaration context.

Nice and small patch.

Jul 20 2016, 3:46 AM

Jul 19 2016

thomie added inline comments to D2407: Support SCC pragmas in declaration context.
Jul 19 2016, 8:40 AM
thomie requested changes to D2406: Expanded one abbreviation in documentation #12405.

Still looking good. Some small comments.

Jul 19 2016, 7:23 AM

Jul 18 2016

thomie added inline comments to D2406: Expanded one abbreviation in documentation #12405.
Jul 18 2016, 8:44 AM
thomie requested changes to D2406: Expanded one abbreviation in documentation #12405.

This looks ok, after a quick scan, except for one mistake.

Jul 18 2016, 8:37 AM
thomie requested changes to D2344: Add tests for plugin error messages in stage1.

In FrontendPluginUser, you're passing in a frontend plugin with -fplugin instead of with --frontend (see https://downloads.haskell.org/~ghc/master/users-guide/extending_ghc.html#frontend-plugins). Is that intentional?

Jul 18 2016, 6:47 AM
thomie added a comment to D2406: Expanded one abbreviation in documentation #12405.

This is good.

Jul 18 2016, 5:50 AM

Jul 13 2016

thomie added a comment to D2402: Rename type variables fairly.

perf.haskell.org show now performance regressions.

Jul 13 2016, 12:30 PM

Jul 11 2016

thomie added inline comments to D2397: Pretty: remove a harmful $! (#12227).
Jul 11 2016, 1:02 PM
thomie updated the diff for D2397: Pretty: remove a harmful $! (#12227).

Compile-time performance differences:

  • -67% 'bytes allocated' for T12227 (8.0.1 even looped on this one)
  • -3% 'max_bytes_used' for T3294
  • +3% 'bytes allocated' for T3294 (I don't know why, but I'm ignoring it)
Jul 11 2016, 12:52 PM
thomie retitled D2397: Pretty: remove a harmful $! (#12227) from to Pretty: remove a harmful $! (#12227).
Jul 11 2016, 12:19 PM
thomie committed rGHC372dbc4e78ab: Pretty: delete really old changelog (authored by thomie).
Pretty: delete really old changelog
Jul 11 2016, 12:17 PM
thomie accepted D2393: CodeGen: Way to dump cmm only once (#11717).

The new flags need to be mentioned in utils/mkUserGuidePart/Options/CompilerDebugging.hs as well (sorry for not alerting you earlier).

Jul 11 2016, 4:16 AM

Jul 9 2016

thomie committed rGHC0177c85b6146: Testsuite: expose TEST_CC (path to gcc) (authored by thomie).
Testsuite: expose TEST_CC (path to gcc)
Jul 9 2016, 11:24 AM
thomie closed D2394: Update tests for #11223 to use GHC instead of GCC by committing rGHC0177c85b6146: Testsuite: expose TEST_CC (path to gcc).
Jul 9 2016, 11:24 AM
thomie added inline comments to D2393: CodeGen: Way to dump cmm only once (#11717).
Jul 9 2016, 7:22 AM
thomie updated the diff for D2394: Update tests for #11223 to use GHC instead of GCC.

How about this

Jul 9 2016, 7:18 AM

Jul 8 2016

thomie requested changes to D2393: CodeGen: Way to dump cmm only once (#11717).

This looks ok, but it needs some documentation. See point 6 and 7 of https://ghc.haskell.org/trac/ghc/wiki/WorkingConventions/AddingFeatures#HowtocontributeanewfeaturetoGHC.

Jul 8 2016, 10:44 AM

Jul 7 2016

thomie committed rGHC34085b501d99: Correct the message displayed for syntax error (#12146) (authored by Aditya <adityadivekar03@gmail.com>).
Correct the message displayed for syntax error (#12146)
Jul 7 2016, 10:15 AM
thomie added a comment to D2391: Bugfix for bug 11632: `readLitChar` should consume null characters.

This looks ok to me, but I'd like a sign off from someone on the CLC.

Jul 7 2016, 7:35 AM
thomie edited reviewers for D2391: Bugfix for bug 11632: `readLitChar` should consume null characters, added: Core Libraries Committee; removed: GHC.
Jul 7 2016, 7:30 AM

Jul 1 2016

thomie committed rGHC0afc41b49e0a: Testsuite: be less strict about topHandler03's stderr (authored by thomie).
Testsuite: be less strict about topHandler03's stderr
Jul 1 2016, 4:22 AM

Jun 30 2016

thomie committed rGHCb65363d3eaff: Fix check_uniques in non-unicode locale (authored by thomie).
Fix check_uniques in non-unicode locale
Jun 30 2016, 4:01 PM
thomie closed D2372: Fix check_uniques in non-unicode locale by committing rGHCb65363d3eaff: Fix check_uniques in non-unicode locale.
Jun 30 2016, 4:01 PM
thomie committed rGHCe8d62711e6cb: Testsuite: do not depend on sys.stdout.encoding (authored by thomie).
Testsuite: do not depend on sys.stdout.encoding
Jun 30 2016, 3:44 AM
thomie retitled D2372: Fix check_uniques in non-unicode locale from to Fix check_uniques in non-unicode locale.
Jun 30 2016, 3:33 AM

Jun 29 2016

thomie committed rGHC1084d3755cac: Testsuite: use ignore_stderr/stdout instead of ignore_output (authored by thomie).
Testsuite: use ignore_stderr/stdout instead of ignore_output
Jun 29 2016, 11:21 AM
thomie closed D2367: Testsuite: use ignore_stderr/stdout instead of ignore_output by committing rGHC1084d3755cac: Testsuite: use ignore_stderr/stdout instead of ignore_output.
Jun 29 2016, 11:21 AM
thomie committed rGHC848e3ceb881e: Testsuite: fixes for python2.6 support (authored by thomie).
Testsuite: fixes for python2.6 support
Jun 29 2016, 6:17 AM

Jun 28 2016

thomie requested changes to D2357: Disable unbuffering of stdout, fixes encoding problem #12213..

I tried this, but you end up with a very confusing intertwining of stdout and stderr.

Jun 28 2016, 7:44 AM
thomie added a comment to D1234: Testsuite: open/close stdout and stderr manually.

I pushed the above patch, although T7037 still fails occasionally.

Jun 28 2016, 7:36 AM
thomie committed rGHC3fb9837f3d69: Testsuite: mark tests expect_broken (authored by thomie).
Testsuite: mark tests expect_broken
Jun 28 2016, 7:26 AM
thomie committed rGHC6b3b631e90aa: Testsuite: run all indexed-types ways on ./validate --slow (authored by thomie).
Testsuite: run all indexed-types ways on ./validate --slow
Jun 28 2016, 7:26 AM
thomie committed rGHC0eb037814b39: Testsuite: do not add -debug explicitly in .T file (authored by thomie).
Testsuite: do not add -debug explicitly in .T file
Jun 28 2016, 7:26 AM
thomie committed rGHC782cacf57300: Testsuite: framework failure improvements (#11165) (authored by thomie).
Testsuite: framework failure improvements (#11165)
Jun 28 2016, 7:26 AM
thomie committed rGHC58f0086b70f2: Testsuite: open/close stdin/stdout/stderr explicitly (authored by thomie).
Testsuite: open/close stdin/stdout/stderr explicitly
Jun 28 2016, 7:26 AM
thomie committed rGHCd8e9b876de87: Testsuite: cleanup printing of summary (authored by thomie).
Testsuite: cleanup printing of summary
Jun 28 2016, 7:26 AM
thomie committed rGHCbafd615e40c2: Testsuite: do not print timeout message (authored by thomie).
Testsuite: do not print timeout message
Jun 28 2016, 7:26 AM
thomie committed rGHC206b4a1d0e82: Testsuite: simplify extra_file handling (authored by thomie).
Testsuite: simplify extra_file handling
Jun 28 2016, 7:26 AM
thomie committed rGHC1f45bce0e7b3: Testsuite: remove one level of indentation [skip ci] (authored by thomie).
Testsuite: remove one level of indentation [skip ci]
Jun 28 2016, 7:26 AM
thomie committed rGHC7593c2fbe4a6: Testsuite: report duplicate testnames when `make TEST=<name>` (authored by thomie).
Testsuite: report duplicate testnames when `make TEST=<name>`
Jun 28 2016, 7:26 AM
thomie committed rGHCbbf0aa27281d: Testsuite: never pick up .T files in .run directories (authored by thomie).
Testsuite: never pick up .T files in .run directories
Jun 28 2016, 7:26 AM
thomie closed D1234: Testsuite: open/close stdout and stderr manually by committing rGHC58f0086b70f2: Testsuite: open/close stdin/stdout/stderr explicitly.
Jun 28 2016, 7:26 AM
thomie retitled D2367: Testsuite: use ignore_stderr/stdout instead of ignore_output from to Testsuite: use ignore_stderr/stdout instead of ignore_output.
Jun 28 2016, 5:56 AM
thomie added a comment to rGHCff1cc262cf6b: Don't run the run_command tests with ext-interp.

Maybe the testsuite driver should ignore extra_ways for run_commands. What do you think?

Jun 28 2016, 2:59 AM

Jun 24 2016

thomie committed rGHCdf9611ee5c05: Testsuite: do not copy .hi/.o files to testdir (#12112) (authored by thomie).
Testsuite: do not copy .hi/.o files to testdir (#12112)
Jun 24 2016, 4:04 AM

Jun 20 2016

thomie committed rGHCe170d1970250: Testsuite: assume timeout_prog always exists (authored by thomie).
Testsuite: assume timeout_prog always exists
Jun 20 2016, 9:41 AM
thomie committed rGHC135fc86c5462: Testsuite: remove `-Wno-warn-tabs` from default flags (authored by thomie).
Testsuite: remove `-Wno-warn-tabs` from default flags
Jun 20 2016, 9:41 AM
thomie committed rGHCebaf26b75c6a: Testsuite: delete dead code + cleanup (authored by thomie).
Testsuite: delete dead code + cleanup
Jun 20 2016, 9:41 AM