snowleopard (Andrey Mokhov)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 27 2016, 1:39 PM (136 w, 6 d)

Recent Activity

Today

snowleopard accepted D5431: Hadrian: ability to run a subset of the testsuite.

Great work!

Tue, Dec 11, 1:07 PM
snowleopard accepted D5434: Hadrian: simple targets for building libraries and executables.

Many thanks, @alpmestan! All looks great now.

Tue, Dec 11, 1:02 PM

Yesterday

snowleopard added a comment to D5434: Hadrian: simple targets for building libraries and executables.

What a nice little build rule. We could add some more intelligence (see my comments), although what you already have is very useful too.

Mon, Dec 10, 3:53 PM
snowleopard added a comment to D5431: Hadrian: ability to run a subset of the testsuite.

Where else do you want this to be documented?

Mon, Dec 10, 3:41 PM
snowleopard accepted D5431: Hadrian: ability to run a subset of the testsuite.

This looks great. Thank you for the patch!

Mon, Dec 10, 12:38 PM
snowleopard accepted D5427: hadrian: Only link against libffi when it is needed for adjustors.

Hope that's enough to fix the issue.

Mon, Dec 10, 4:34 AM

Fri, Dec 7

snowleopard accepted D5422: hadrian: eliminate most of the remaining big rule enumerations.

@alpmestan Awesome, thank you!

Fri, Dec 7, 8:17 AM

Thu, Dec 6

snowleopard retitled D5419: Hadrian: fix dynamicGhcPrograms value for the quickest flavour from hadrian: fix dynamicGhcPrograms value for the quickest flavour to Hadrian: fix dynamicGhcPrograms value for the quickest flavour.
Thu, Dec 6, 9:50 AM
snowleopard accepted D5419: Hadrian: fix dynamicGhcPrograms value for the quickest flavour.

@alpmestan Thank you! Looks perfectly reasonable to me.

Thu, Dec 6, 9:50 AM
snowleopard added a comment to D5417: Hadrian: support in-tree GMP.

@harpocrates Thank you for the patch.

Thu, Dec 6, 9:47 AM
snowleopard added inline comments to D5417: Hadrian: support in-tree GMP.
Thu, Dec 6, 9:44 AM
snowleopard accepted D5412: hadrian: optimise Rules.Compile.

@alpmestan Many thanks! Your patch looks great now.

Thu, Dec 6, 9:33 AM
snowleopard accepted D5417: Hadrian: support in-tree GMP.
Thu, Dec 6, 9:29 AM

Wed, Dec 5

snowleopard added inline comments to D5412: hadrian: optimise Rules.Compile.
Wed, Dec 5, 11:28 AM

Tue, Dec 4

snowleopard added inline comments to D5412: hadrian: optimise Rules.Compile.
Tue, Dec 4, 5:33 PM
snowleopard requested changes to D5412: hadrian: optimise Rules.Compile.

@alpmestan Many thanks! In general this looks great, but I left a few comments/questions for you.

Tue, Dec 4, 4:49 PM

Sun, Dec 2

snowleopard accepted D5404: Hadrian: include 'findPtr' via find-ptr cabal flag.

And another thumb-up from me. Thanks @harpocrates!

Sun, Dec 2, 4:15 PM

Wed, Nov 28

snowleopard accepted D5389: Allow containers-0.6, QuickCheck-2.12 in Hadrian.

Thanks! Sure, let's bump the bounds.

Wed, Nov 28, 12:49 PM
snowleopard added a comment to D5385: Hadrian: bump Cabal submodule, install extra dynamic flavours of libHSrts.

Thanks @alpmestan, I agree with your thoughts.

Wed, Nov 28, 5:36 AM

Tue, Nov 27

snowleopard accepted D5385: Hadrian: bump Cabal submodule, install extra dynamic flavours of libHSrts.

Looks good to me!

Tue, Nov 27, 7:36 AM

Mon, Nov 26

snowleopard accepted D5381: hadrian/test: Don't depend upon iserv on Windows.

Thanks! Yes, that's the right solution for now, but I'm happy to discuss/help with a better design.

Mon, Nov 26, 10:53 AM

Thu, Nov 22

snowleopard added a comment to D5371: Hadrian: improve bindist rule.

Let me capitalise the title, since Hadrian is a name :-)

Thu, Nov 22, 8:44 PM
snowleopard retitled D5371: Hadrian: improve bindist rule from hadrian: improve bindist rule to Hadrian: improve bindist rule.
Thu, Nov 22, 8:43 PM
snowleopard accepted D5371: Hadrian: improve bindist rule.

@alpmestan Many thanks, this is a very helpful note.

Thu, Nov 22, 7:37 PM
snowleopard added a comment to D5371: Hadrian: improve bindist rule.

Like @bgamari, I'd like to have a note about wrappers somewhere in the code, as otherwise it's always a matter of googling for hours in order to find out more information about them.

Thu, Nov 22, 3:39 PM

Tue, Nov 20

snowleopard accepted D5316: Hadrian: Misc. fixes in Haddock rules.

Thank you! i believe this can now be merged.

Tue, Nov 20, 3:27 PM
snowleopard accepted D5361: Hadrian: work around Cabal's/GHC's different Arch/OS strings.

Thank you! This looks good to me, although we should remember to merge this commit with Hadrian: prefix, since it's a Hadrian-only commit.

Tue, Nov 20, 3:08 PM
snowleopard added a comment to D5316: Hadrian: Misc. fixes in Haddock rules.

One more thing: we'd like to follow a convention that all Hadrian-only commits are prefixed with Hadrian: . I guess renaming this diff should be sufficient for it to land with the right commit message.

Tue, Nov 20, 3:00 PM
snowleopard added inline comments to D5316: Hadrian: Misc. fixes in Haddock rules.
Tue, Nov 20, 2:57 PM
snowleopard added a comment to D5316: Hadrian: Misc. fixes in Haddock rules.

@harpocrates Thank you! The newly added comments and simplifications to the docs rule are very helpful.

Tue, Nov 20, 2:33 PM

Wed, Nov 14

snowleopard added inline comments to D5316: Hadrian: Misc. fixes in Haddock rules.
Wed, Nov 14, 5:45 AM
snowleopard updated subscribers of D5316: Hadrian: Misc. fixes in Haddock rules.

Additionally, I noticed that there Hadrian doesn't generate the short wrapper shell script the make-based system used to produce

Wed, Nov 14, 5:36 AM

Tue, Nov 13

snowleopard requested changes to D5316: Hadrian: Misc. fixes in Haddock rules.

@harpocrates Many thanks! Apologies for taking so long to review. I've left a few minor comments, mostly just trying to make this patch a bit simpler.

Tue, Nov 13, 5:41 PM

Oct 27 2018

snowleopard accepted D5270: Hadrian: merge sections in profiling _p.a to .p_o for ghci.

@watashi Thank you! Generally this looks good, but if possible I would like to avoid baking in the special case package /= rts (see my comment). Can this be specified in rts.cabal.in instead?

Oct 27 2018, 7:02 AM

Oct 26 2018

snowleopard resigned from D5266: compareByPreference: handle the case where the two packages have a different name.

@alpmestan I'm happy this fixes Hadrian, but I feel unqualified to review this patch from the GHC perspective. In my opinion, the way compareByPreference and integer-wired-in interact is questionable and error-prone (both before and after this patch), which should probaby be discussed in a separate GHC ticket.

Oct 26 2018, 9:12 AM
snowleopard added inline comments to D5266: compareByPreference: handle the case where the two packages have a different name.
Oct 26 2018, 6:53 AM

Oct 25 2018

snowleopard added inline comments to D5255: hadrian: build ghc-iserv-prof in addition to ghc-iserv, as it is required for 10+ tests.
Oct 25 2018, 5:52 AM
snowleopard added a comment to D5255: hadrian: build ghc-iserv-prof in addition to ghc-iserv, as it is required for 10+ tests.

@alpmestan Great! Is there a way to migrate our AppVeyor and Travis scripts too?

Oct 25 2018, 5:46 AM

Oct 24 2018

snowleopard added inline comments to D5255: hadrian: build ghc-iserv-prof in addition to ghc-iserv, as it is required for 10+ tests.
Oct 24 2018, 10:07 AM
snowleopard added inline comments to D5255: hadrian: build ghc-iserv-prof in addition to ghc-iserv, as it is required for 10+ tests.
Oct 24 2018, 7:52 AM
snowleopard added a comment to D5255: hadrian: build ghc-iserv-prof in addition to ghc-iserv, as it is required for 10+ tests.

@alpmestan Thank you, this looks good to me. However, have we lost all CI support with the move from GitHub? Can we fix the CI first?

Oct 24 2018, 7:46 AM

Oct 23 2018

snowleopard committed rGHC45f3bff7016a: Fix warnings, improve documentation (authored by snowleopard).
Fix warnings, improve documentation
Oct 23 2018, 4:41 PM
snowleopard committed rGHCc8bab2837b1f: Bump QuickCheck bound (authored by snowleopard).
Bump QuickCheck bound
Oct 23 2018, 4:41 PM
snowleopard committed rGHC5e432d4aa47f: Honour the flavours advertised by the flavours.md document (#691) (authored by alpmestan).
Honour the flavours advertised by the flavours.md document (#691)
Oct 23 2018, 4:41 PM
snowleopard committed rGHC996afc7daaea: Pass 'threaded' flag to the GHC executable (#689) (authored by alpmestan).
Pass 'threaded' flag to the GHC executable (#689)
Oct 23 2018, 4:41 PM
GitHub <noreply@github.com> committed rGHC021e753b499d: Simplify oracles (#694) (authored by snowleopard).
Simplify oracles (#694)
Oct 23 2018, 4:41 PM
snowleopard committed rGHC835f2766eda7: Build touchy and unlit only in Stage0, copy binaries for later stages (#693) (authored by alpmestan).
Build touchy and unlit only in Stage0, copy binaries for later stages (#693)
Oct 23 2018, 4:41 PM
snowleopard committed rGHC6eb9c0c9bf91: OS X CI scripts: don't use my GHC branch anymore, D5138 has been merged (#690) (authored by alpmestan).
OS X CI scripts: don't use my GHC branch anymore, D5138 has been merged (#690)
Oct 23 2018, 4:41 PM
GitHub <noreply@github.com> committed rGHC7169ac5d7b03: Rework parsing of Cabal metadata (#692) (authored by snowleopard).
Rework parsing of Cabal metadata (#692)
Oct 23 2018, 4:41 PM
snowleopard committed rGHC9609113f1d54: Fix a logic error that kept us from building/linking object files for many ways… (authored by alpmestan).
Fix a logic error that kept us from building/linking object files for many ways…
Oct 23 2018, 4:41 PM
snowleopard committed rGHC407190e6e8d0: Add unlit to testsuitePackages (#688) (authored by alpmestan).
Add unlit to testsuitePackages (#688)
Oct 23 2018, 4:41 PM
snowleopard committed rGHC97f93453e46e: Set integer-gmp flag when appropriate (#684) (authored by alpmestan).
Set integer-gmp flag when appropriate (#684)
Oct 23 2018, 4:41 PM
snowleopard committed rGHC9a6f41ced3c9: Fix clean so it works on Windows (#679) (authored by ndmitchell).
Fix clean so it works on Windows (#679)
Oct 23 2018, 4:40 PM
snowleopard committed rGHCdf96f2510804: Move to GHC 8.4.3 by upgrading the Stackage snapshot (#680) (authored by ndmitchell).
Move to GHC 8.4.3 by upgrading the Stackage snapshot (#680)
Oct 23 2018, 4:40 PM
snowleopard committed rGHC9bf046f15391: Build more profiling ways by default (#682) (authored by alpmestan).
Build more profiling ways by default (#682)
Oct 23 2018, 4:40 PM
snowleopard committed rGHC06f3206e1f81: Update OS X scripts to test a GHC patch for #614 (#678) (authored by alpmestan).
Update OS X scripts to test a GHC patch for #614 (#678)
Oct 23 2018, 4:40 PM
snowleopard committed rGHCf8d3f9b09ec1: Make the test rule depend on ghc-compact, to make this library's tests pass… (authored by alpmestan).
Make the test rule depend on ghc-compact, to make this library's tests pass…
Oct 23 2018, 4:40 PM
snowleopard committed rGHC1bbc4b3b6205: Work around the "can't use Natural in base" problem on a per-flavour basis… (authored by alpmestan).
Work around the "can't use Natural in base" problem on a per-flavour basis…
Oct 23 2018, 4:40 PM
snowleopard committed rGHC921dbbdc7712: Remove unwanted '-O0's in Settings.Packages (#674) (authored by alpmestan).
Remove unwanted '-O0's in Settings.Packages (#674)
Oct 23 2018, 4:40 PM
snowleopard committed rGHC481961760e6a: Address some issues with the testsuite rules (#672) (authored by alpmestan).
Address some issues with the testsuite rules (#672)
Oct 23 2018, 4:40 PM
GitHub <noreply@github.com> committed rGHC3217903fc83a: Fix typos (authored by snowleopard).
Fix typos
Oct 23 2018, 4:40 PM
GitHub <noreply@github.com> committed rGHC90d07d7bf42b: Fix documentation rules (#665) (authored by snowleopard).
Fix documentation rules (#665)
Oct 23 2018, 4:40 PM
GitHub <noreply@github.com> committed rGHCabf9cbee2651: Build runghc instead of runhaskell (#670) (authored by snowleopard).
Build runghc instead of runhaskell (#670)
Oct 23 2018, 4:40 PM
GitHub <noreply@github.com> committed rGHC12e6635a583a: Fix build scripts (#668) (authored by snowleopard).
Fix build scripts (#668)
Oct 23 2018, 4:39 PM
GitHub <noreply@github.com> committed rGHC798a716b1637: Simplify Package data type (#663) (authored by snowleopard).
Simplify Package data type (#663)
Oct 23 2018, 4:39 PM
GitHub <noreply@github.com> committed rGHCe5f13b3a7586: Tweak the build root section (authored by snowleopard).
Tweak the build root section
Oct 23 2018, 4:39 PM
snowleopard committed rGHCa820566c16e1: Minor revision (authored by snowleopard).
Minor revision
Oct 23 2018, 4:39 PM
GitHub <noreply@github.com> committed rGHC0059b9f205d0: Clean up remaining bits of the install rule (#660) (authored by snowleopard).
Clean up remaining bits of the install rule (#660)
Oct 23 2018, 4:39 PM
snowleopard committed rGHCae35b2b2b89f: Remove dead code (authored by snowleopard).
Remove dead code
Oct 23 2018, 4:39 PM
GitHub <noreply@github.com> committed rGHC0106f2039271: Reorganise GHC packages, get rid of Builder import cycle (#662) (authored by snowleopard).
Reorganise GHC packages, get rid of Builder import cycle (#662)
Oct 23 2018, 4:39 PM
GitHub <noreply@github.com> committed rGHC8ec50a585ac6: Fix defaut top level targets (#659) (authored by snowleopard).
Fix defaut top level targets (#659)
Oct 23 2018, 4:39 PM
GitHub <noreply@github.com> committed rGHC8dc4f73f169a: Clean up remaining bits related to ghc-cabal (#658) (authored by snowleopard).
Clean up remaining bits related to ghc-cabal (#658)
Oct 23 2018, 4:39 PM
snowleopard committed rGHCe174dca4d5c6: Drop nonCabalContext, since all GHC packages now come with Cabal files (authored by snowleopard).
Drop nonCabalContext, since all GHC packages now come with Cabal files
Oct 23 2018, 4:39 PM
GitHub <noreply@github.com> committed rGHCa804d57a6b29: Fix package dependencies (#657) (authored by snowleopard).
Fix package dependencies (#657)
Oct 23 2018, 4:39 PM
GitHub <noreply@github.com> committed rGHC2fac053131d4: Fix warnings, improve comments and error handling, minor refactoring (#656) (authored by snowleopard).
Fix warnings, improve comments and error handling, minor refactoring (#656)
Oct 23 2018, 4:39 PM
snowleopard committed rGHC4265e3aab7df: Bump Cabal upper bound (#651) (authored by bgamari).
Bump Cabal upper bound (#651)
Oct 23 2018, 4:39 PM
snowleopard committed rGHC148006a03eae: Remove the hack to use a patched Cabal submodule in CI (#650) (authored by quasicomputational <quasicomputational@gmail.com>).
Remove the hack to use a patched Cabal submodule in CI (#650)
Oct 23 2018, 4:39 PM
snowleopard committed rGHC165f03e90f50: Implement the equivalent of D4955 (#648) (authored by alpmestan).
Implement the equivalent of D4955 (#648)
Oct 23 2018, 4:38 PM
snowleopard committed rGHC23dc432a3f6c: Fixes building with stack within recent versions of ghc repo (#646) (authored by mgsloan).
Fixes building with stack within recent versions of ghc repo (#646)
Oct 23 2018, 4:38 PM
snowleopard committed rGHCe5773fa62333: Switch to the fixed Cabal branch in CI and add a fix for Natural (#640) (authored by alpmestan).
Switch to the fixed Cabal branch in CI and add a fix for Natural (#640)
Oct 23 2018, 4:38 PM
snowleopard committed rGHC843790ea9b3f: Fix timeout building rule for Linux (#638) (authored by alpmestan).
Fix timeout building rule for Linux (#638)
Oct 23 2018, 4:38 PM
snowleopard committed rGHCbbdd69bdaa48: Make Cabal install unconditional in build.cabal.sh (#633) (authored by Chitrak Raj Gupta <chitrak711988@gmail.com>).
Make Cabal install unconditional in build.cabal.sh (#633)
Oct 23 2018, 4:38 PM
snowleopard committed rGHC36c9781b8251: Add includes to bindist (#632) (authored by Chitrak Raj Gupta <chitrak711988@gmail.com>).
Add includes to bindist (#632)
Oct 23 2018, 4:38 PM
snowleopard committed rGHC233a63897883: Add new featues to binary distribution (#623) (authored by Chitrak Raj Gupta <chitrak711988@gmail.com>).
Add new featues to binary distribution (#623)
Oct 23 2018, 4:38 PM
snowleopard committed rGHCd4b9c1fbc3ab: Remove more validation errors (#628) (authored by Chitrak Raj Gupta <chitrak711988@gmail.com>).
Remove more validation errors (#628)
Oct 23 2018, 4:38 PM
snowleopard committed rGHC48b81a3a5234: Implement build rules for testsuite/timeout (#499) (authored by sighingnow).
Implement build rules for testsuite/timeout (#499)
Oct 23 2018, 4:38 PM
snowleopard committed rGHCf3192439950b: Read the `main-is` field from the cabal file for executables (#627) (authored by sighingnow).
Read the `main-is` field from the cabal file for executables (#627)
Oct 23 2018, 4:38 PM
snowleopard committed rGHC831e1ce04983: Add config file and test speed options to testsuite (#624) (authored by Chitrak Raj Gupta <chitrak711988@gmail.com>).
Add config file and test speed options to testsuite (#624)
Oct 23 2018, 4:38 PM
snowleopard committed rGHC190682875096: Set more test arguments correctly (#625) (authored by alpmestan).
Set more test arguments correctly (#625)
Oct 23 2018, 4:38 PM
snowleopard committed rGHC0b35e12f4d90: Add test compiler option to test (#621) (authored by Chitrak Raj Gupta <chitrak711988@gmail.com>).
Add test compiler option to test (#621)
Oct 23 2018, 4:38 PM
GitHub <noreply@github.com> committed rGHC235809092b65: Refactor package-specific settings (#622) (authored by snowleopard).
Refactor package-specific settings (#622)
Oct 23 2018, 4:38 PM
snowleopard committed rGHCccf6453f33ef: Bump Shake version to 0.16.1. (#618) (authored by sighingnow).
Bump Shake version to 0.16.1. (#618)
Oct 23 2018, 4:37 PM
snowleopard committed rGHCc51b92b59d63: Add `gmp` and `ncurses` as nix dependencies (#616) (authored by sgillespie).
Add `gmp` and `ncurses` as nix dependencies (#616)
Oct 23 2018, 4:37 PM
GitHub <noreply@github.com> committed rGHCc866660513a2: Minor revision (#619) (authored by snowleopard).
Minor revision (#619)
Oct 23 2018, 4:37 PM
snowleopard committed rGHCef4137d7e4a8: Added support for testsuite (#602) (authored by Chitrak Raj Gupta <chitrak711988@gmail.com>).
Added support for testsuite (#602)
Oct 23 2018, 4:37 PM
GitHub <noreply@github.com> committed rGHCa63ad3294b5d: Update RTS flags (#613) (authored by snowleopard).
Update RTS flags (#613)
Oct 23 2018, 4:37 PM
GitHub <noreply@github.com> committed rGHC8dba6748e84c: Add libiserv, rename iserv-bin to iserv, drop primitive (#612) (authored by snowleopard).
Add libiserv, rename iserv-bin to iserv, drop primitive (#612)
Oct 23 2018, 4:37 PM
snowleopard committed rGHCec5e9d3acdf9: Do not always add -Iincludes to C arguments (#610) (authored by alpmestan).
Do not always add -Iincludes to C arguments (#610)
Oct 23 2018, 4:37 PM
snowleopard committed rGHC3837187e57bf: remove (unnecessary) recursive dependency involving ghcPath (#606) (authored by alpmestan).
remove (unnecessary) recursive dependency involving ghcPath (#606)
Oct 23 2018, 4:37 PM
snowleopard committed rGHCc0292ffcaee9: Add ghc-heap (authored by snowleopard).
Add ghc-heap
Oct 23 2018, 4:37 PM