snowleopard (Andrey Mokhov)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 27 2016, 1:39 PM (163 w, 5 d)

Recent Activity

Apr 19 2019

Marge Bot <ben+marge-bot@smart-cactus.org> committed rGHC10776562d8b9: Hadrian: Drop old/unused CI scripts (authored by snowleopard).
Hadrian: Drop old/unused CI scripts
Apr 19 2019, 11:08 PM

Apr 16 2019

Marge Bot <ben+marge-bot@smart-cactus.org> committed rGHC894ec447955a: Hadrian: Generate GHC wrapper scripts (authored by snowleopard).
Hadrian: Generate GHC wrapper scripts
Apr 16 2019, 2:57 PM

Apr 2 2019

Marge Bot <ben+marge-bot@smart-cactus.org> committed rGHC646f2e79c5d6: Hadrian: trace the execution of expensive Cabal calls (authored by snowleopard).
Hadrian: trace the execution of expensive Cabal calls
Apr 2 2019, 3:54 PM
Marge Bot <ben+marge-bot@smart-cactus.org> committed rGHCab41c1b42937: Hadrian: Bump Shake to 0.17.6 (authored by snowleopard).
Hadrian: Bump Shake to 0.17.6
Apr 2 2019, 3:54 PM

Mar 9 2019

Marge Bot <ben+marge-bot@smart-cactus.org> committed rGHC5d7441432e4c: Hadrian: Drop remaining symlink traversal code from build scripts (authored by snowleopard).
Hadrian: Drop remaining symlink traversal code from build scripts
Mar 9 2019, 1:11 AM

Mar 4 2019

Marge Bot <ben+marge-bot@smart-cactus.org> committed rGHC1dad4fc27ea1: Hadrian: Fix untracked dependencies (authored by snowleopard).
Hadrian: Fix untracked dependencies
Mar 4 2019, 1:07 PM

Dec 22 2018

snowleopard added a comment to D5458: Hadrian: Add support for building Stage3.

I think the only question to resolve is whether it is ok to build haddock and ghcTags at stage1 How do you want to resolve this without leaving this patch in limbo?

Dec 22 2018, 4:57 AM

Dec 20 2018

snowleopard added inline comments to D5458: Hadrian: Add support for building Stage3.
Dec 20 2018, 12:11 PM

Dec 19 2018

snowleopard requested changes to D5458: Hadrian: Add support for building Stage3.

@mpickering Thank you. I've left a few more comments. The question about moving ghcTags and haddock to Stage1 is the biggest. I don't know whether this is the right solution in the long term, and why Make's behaviour is different. Please clarify.

Dec 19 2018, 5:15 PM

Dec 18 2018

snowleopard added a comment to D5458: Hadrian: Add support for building Stage3.

I think I fixed things up now.

Dec 18 2018, 12:14 PM

Dec 17 2018

snowleopard accepted D5446: hadrian: introduce make-user-oriented docs.

Thanks, Alp! I think this is ready to land.

Dec 17 2018, 6:31 PM

Dec 16 2018

snowleopard added a comment to D5458: Hadrian: Add support for building Stage3.

Thanks Andrey, I managed to apply your suggestions and things appear to work smoothly still. I'll try a clean rebuild overnight.

Dec 16 2018, 4:48 PM
snowleopard added inline comments to D5458: Hadrian: Add support for building Stage3.
Dec 16 2018, 3:47 PM
snowleopard added inline comments to D5458: Hadrian: Add support for building Stage3.
Dec 16 2018, 3:36 PM
snowleopard added a comment to D5458: Hadrian: Add support for building Stage3.

@mpickering Thanks for trying to build Stage3 GHC! I've never tried it. I've left a bunch of comments.

Dec 16 2018, 2:06 PM

Dec 15 2018

snowleopard accepted D5454: Hadrian: introduce userDefaultFlavour, making default flavour overridable.

Looks good to me, thank you!

Dec 15 2018, 9:55 AM
snowleopard added a comment to D5446: hadrian: introduce make-user-oriented docs.

Some of your comments apply to the contents that was already there, and I don't feel like using this diff to freshen up the README entirely.

Dec 15 2018, 9:16 AM

Dec 14 2018

snowleopard requested changes to D5446: hadrian: introduce make-user-oriented docs.

I love the new docs, @alpmestan, thank you! I've left a few comments.

Dec 14 2018, 5:56 PM

Dec 11 2018

snowleopard accepted D5431: Hadrian: ability to run a subset of the testsuite.

Great work!

Dec 11 2018, 1:07 PM
snowleopard accepted D5434: Hadrian: simple targets for building libraries and executables.

Many thanks, @alpmestan! All looks great now.

Dec 11 2018, 1:02 PM

Dec 10 2018

snowleopard added a comment to D5434: Hadrian: simple targets for building libraries and executables.

What a nice little build rule. We could add some more intelligence (see my comments), although what you already have is very useful too.

Dec 10 2018, 3:53 PM
snowleopard added a comment to D5431: Hadrian: ability to run a subset of the testsuite.

Where else do you want this to be documented?

Dec 10 2018, 3:41 PM
snowleopard accepted D5431: Hadrian: ability to run a subset of the testsuite.

This looks great. Thank you for the patch!

Dec 10 2018, 12:38 PM
snowleopard accepted D5427: hadrian: Only link against libffi when it is needed for adjustors.

Hope that's enough to fix the issue.

Dec 10 2018, 4:34 AM

Dec 7 2018

snowleopard accepted D5422: hadrian: eliminate most of the remaining big rule enumerations.

@alpmestan Awesome, thank you!

Dec 7 2018, 8:17 AM

Dec 6 2018

snowleopard retitled D5419: Hadrian: fix dynamicGhcPrograms value for the quickest flavour from hadrian: fix dynamicGhcPrograms value for the quickest flavour to Hadrian: fix dynamicGhcPrograms value for the quickest flavour.
Dec 6 2018, 9:50 AM
snowleopard accepted D5419: Hadrian: fix dynamicGhcPrograms value for the quickest flavour.

@alpmestan Thank you! Looks perfectly reasonable to me.

Dec 6 2018, 9:50 AM
snowleopard added a comment to D5417: Hadrian: support in-tree GMP.

@harpocrates Thank you for the patch.

Dec 6 2018, 9:47 AM
snowleopard added inline comments to D5417: Hadrian: support in-tree GMP.
Dec 6 2018, 9:44 AM
snowleopard accepted D5412: hadrian: optimise Rules.Compile.

@alpmestan Many thanks! Your patch looks great now.

Dec 6 2018, 9:33 AM
snowleopard accepted D5417: Hadrian: support in-tree GMP.
Dec 6 2018, 9:29 AM

Dec 5 2018

snowleopard added inline comments to D5412: hadrian: optimise Rules.Compile.
Dec 5 2018, 11:28 AM

Dec 4 2018

snowleopard added inline comments to D5412: hadrian: optimise Rules.Compile.
Dec 4 2018, 5:33 PM
snowleopard requested changes to D5412: hadrian: optimise Rules.Compile.

@alpmestan Many thanks! In general this looks great, but I left a few comments/questions for you.

Dec 4 2018, 4:49 PM

Dec 2 2018

snowleopard accepted D5404: Hadrian: include 'findPtr' via find-ptr cabal flag.

And another thumb-up from me. Thanks @harpocrates!

Dec 2 2018, 4:15 PM

Nov 28 2018

snowleopard accepted D5389: Allow containers-0.6, QuickCheck-2.12 in Hadrian.

Thanks! Sure, let's bump the bounds.

Nov 28 2018, 12:49 PM
snowleopard added a comment to D5385: Hadrian: bump Cabal submodule, install extra dynamic flavours of libHSrts.

Thanks @alpmestan, I agree with your thoughts.

Nov 28 2018, 5:36 AM

Nov 27 2018

snowleopard accepted D5385: Hadrian: bump Cabal submodule, install extra dynamic flavours of libHSrts.

Looks good to me!

Nov 27 2018, 7:36 AM

Nov 26 2018

snowleopard accepted D5381: hadrian/test: Don't depend upon iserv on Windows.

Thanks! Yes, that's the right solution for now, but I'm happy to discuss/help with a better design.

Nov 26 2018, 10:53 AM

Nov 22 2018

snowleopard added a comment to D5371: Hadrian: improve bindist rule.

Let me capitalise the title, since Hadrian is a name :-)

Nov 22 2018, 8:44 PM
snowleopard retitled D5371: Hadrian: improve bindist rule from hadrian: improve bindist rule to Hadrian: improve bindist rule.
Nov 22 2018, 8:43 PM
snowleopard accepted D5371: Hadrian: improve bindist rule.

@alpmestan Many thanks, this is a very helpful note.

Nov 22 2018, 7:37 PM
snowleopard added a comment to D5371: Hadrian: improve bindist rule.

Like @bgamari, I'd like to have a note about wrappers somewhere in the code, as otherwise it's always a matter of googling for hours in order to find out more information about them.

Nov 22 2018, 3:39 PM

Nov 20 2018

snowleopard accepted D5316: Hadrian: Misc. fixes in Haddock rules.

Thank you! I believe this can now be merged.

Nov 20 2018, 3:27 PM
snowleopard accepted D5361: Hadrian: work around Cabal's/GHC's different Arch/OS strings.

Thank you! This looks good to me, although we should remember to merge this commit with Hadrian: prefix, since it's a Hadrian-only commit.

Nov 20 2018, 3:08 PM
snowleopard added a comment to D5316: Hadrian: Misc. fixes in Haddock rules.

One more thing: we'd like to follow a convention that all Hadrian-only commits are prefixed with Hadrian: . I guess renaming this diff should be sufficient for it to land with the right commit message.

Nov 20 2018, 3:00 PM
snowleopard added inline comments to D5316: Hadrian: Misc. fixes in Haddock rules.
Nov 20 2018, 2:57 PM
snowleopard added a comment to D5316: Hadrian: Misc. fixes in Haddock rules.

@harpocrates Thank you! The newly added comments and simplifications to the docs rule are very helpful.

Nov 20 2018, 2:33 PM

Nov 14 2018

snowleopard added inline comments to D5316: Hadrian: Misc. fixes in Haddock rules.
Nov 14 2018, 5:45 AM
snowleopard updated subscribers of D5316: Hadrian: Misc. fixes in Haddock rules.

Additionally, I noticed that there Hadrian doesn't generate the short wrapper shell script the make-based system used to produce

Nov 14 2018, 5:36 AM

Nov 13 2018

snowleopard requested changes to D5316: Hadrian: Misc. fixes in Haddock rules.

@harpocrates Many thanks! Apologies for taking so long to review. I've left a few minor comments, mostly just trying to make this patch a bit simpler.

Nov 13 2018, 5:41 PM

Oct 27 2018

snowleopard accepted D5270: Hadrian: merge sections in profiling _p.a to .p_o for ghci.

@watashi Thank you! Generally this looks good, but if possible I would like to avoid baking in the special case package /= rts (see my comment). Can this be specified in rts.cabal.in instead?

Oct 27 2018, 7:02 AM

Oct 26 2018

snowleopard resigned from D5266: compareByPreference: handle the case where the two packages have a different name.

@alpmestan I'm happy this fixes Hadrian, but I feel unqualified to review this patch from the GHC perspective. In my opinion, the way compareByPreference and integer-wired-in interact is questionable and error-prone (both before and after this patch), which should probaby be discussed in a separate GHC ticket.

Oct 26 2018, 9:12 AM
snowleopard added inline comments to D5266: compareByPreference: handle the case where the two packages have a different name.
Oct 26 2018, 6:53 AM

Oct 25 2018

snowleopard added inline comments to D5255: hadrian: build ghc-iserv-prof in addition to ghc-iserv, as it is required for 10+ tests.
Oct 25 2018, 5:52 AM
snowleopard added a comment to D5255: hadrian: build ghc-iserv-prof in addition to ghc-iserv, as it is required for 10+ tests.

@alpmestan Great! Is there a way to migrate our AppVeyor and Travis scripts too?

Oct 25 2018, 5:46 AM

Oct 24 2018

snowleopard added inline comments to D5255: hadrian: build ghc-iserv-prof in addition to ghc-iserv, as it is required for 10+ tests.
Oct 24 2018, 10:07 AM
snowleopard added inline comments to D5255: hadrian: build ghc-iserv-prof in addition to ghc-iserv, as it is required for 10+ tests.
Oct 24 2018, 7:52 AM
snowleopard added a comment to D5255: hadrian: build ghc-iserv-prof in addition to ghc-iserv, as it is required for 10+ tests.

@alpmestan Thank you, this looks good to me. However, have we lost all CI support with the move from GitHub? Can we fix the CI first?

Oct 24 2018, 7:46 AM

Oct 23 2018

snowleopard committed rGHC45f3bff7016a: Fix warnings, improve documentation (authored by snowleopard).
Fix warnings, improve documentation
Oct 23 2018, 4:41 PM
snowleopard committed rGHCc8bab2837b1f: Bump QuickCheck bound (authored by snowleopard).
Bump QuickCheck bound
Oct 23 2018, 4:41 PM
snowleopard committed rGHC5e432d4aa47f: Honour the flavours advertised by the flavours.md document (#691) (authored by alpmestan).
Honour the flavours advertised by the flavours.md document (#691)
Oct 23 2018, 4:41 PM
snowleopard committed rGHC996afc7daaea: Pass 'threaded' flag to the GHC executable (#689) (authored by alpmestan).
Pass 'threaded' flag to the GHC executable (#689)
Oct 23 2018, 4:41 PM
GitHub <noreply@github.com> committed rGHC021e753b499d: Simplify oracles (#694) (authored by snowleopard).
Simplify oracles (#694)
Oct 23 2018, 4:41 PM
snowleopard committed rGHC835f2766eda7: Build touchy and unlit only in Stage0, copy binaries for later stages (#693) (authored by alpmestan).
Build touchy and unlit only in Stage0, copy binaries for later stages (#693)
Oct 23 2018, 4:41 PM
snowleopard committed rGHC6eb9c0c9bf91: OS X CI scripts: don't use my GHC branch anymore, D5138 has been merged (#690) (authored by alpmestan).
OS X CI scripts: don't use my GHC branch anymore, D5138 has been merged (#690)
Oct 23 2018, 4:41 PM
GitHub <noreply@github.com> committed rGHC7169ac5d7b03: Rework parsing of Cabal metadata (#692) (authored by snowleopard).
Rework parsing of Cabal metadata (#692)
Oct 23 2018, 4:41 PM
snowleopard committed rGHC9609113f1d54: Fix a logic error that kept us from building/linking object files for many ways… (authored by alpmestan).
Fix a logic error that kept us from building/linking object files for many ways…
Oct 23 2018, 4:41 PM
snowleopard committed rGHC407190e6e8d0: Add unlit to testsuitePackages (#688) (authored by alpmestan).
Add unlit to testsuitePackages (#688)
Oct 23 2018, 4:41 PM
snowleopard committed rGHC97f93453e46e: Set integer-gmp flag when appropriate (#684) (authored by alpmestan).
Set integer-gmp flag when appropriate (#684)
Oct 23 2018, 4:41 PM
snowleopard committed rGHC9a6f41ced3c9: Fix clean so it works on Windows (#679) (authored by ndmitchell).
Fix clean so it works on Windows (#679)
Oct 23 2018, 4:40 PM
snowleopard committed rGHCdf96f2510804: Move to GHC 8.4.3 by upgrading the Stackage snapshot (#680) (authored by ndmitchell).
Move to GHC 8.4.3 by upgrading the Stackage snapshot (#680)
Oct 23 2018, 4:40 PM
snowleopard committed rGHC9bf046f15391: Build more profiling ways by default (#682) (authored by alpmestan).
Build more profiling ways by default (#682)
Oct 23 2018, 4:40 PM
snowleopard committed rGHC06f3206e1f81: Update OS X scripts to test a GHC patch for #614 (#678) (authored by alpmestan).
Update OS X scripts to test a GHC patch for #614 (#678)
Oct 23 2018, 4:40 PM
snowleopard committed rGHCf8d3f9b09ec1: Make the test rule depend on ghc-compact, to make this library's tests pass… (authored by alpmestan).
Make the test rule depend on ghc-compact, to make this library's tests pass…
Oct 23 2018, 4:40 PM
snowleopard committed rGHC1bbc4b3b6205: Work around the "can't use Natural in base" problem on a per-flavour basis… (authored by alpmestan).
Work around the "can't use Natural in base" problem on a per-flavour basis…
Oct 23 2018, 4:40 PM
snowleopard committed rGHC921dbbdc7712: Remove unwanted '-O0's in Settings.Packages (#674) (authored by alpmestan).
Remove unwanted '-O0's in Settings.Packages (#674)
Oct 23 2018, 4:40 PM
snowleopard committed rGHC481961760e6a: Address some issues with the testsuite rules (#672) (authored by alpmestan).
Address some issues with the testsuite rules (#672)
Oct 23 2018, 4:40 PM
GitHub <noreply@github.com> committed rGHC3217903fc83a: Fix typos (authored by snowleopard).
Fix typos
Oct 23 2018, 4:40 PM
GitHub <noreply@github.com> committed rGHC90d07d7bf42b: Fix documentation rules (#665) (authored by snowleopard).
Fix documentation rules (#665)
Oct 23 2018, 4:40 PM
GitHub <noreply@github.com> committed rGHCabf9cbee2651: Build runghc instead of runhaskell (#670) (authored by snowleopard).
Build runghc instead of runhaskell (#670)
Oct 23 2018, 4:40 PM
GitHub <noreply@github.com> committed rGHC12e6635a583a: Fix build scripts (#668) (authored by snowleopard).
Fix build scripts (#668)
Oct 23 2018, 4:39 PM
GitHub <noreply@github.com> committed rGHC798a716b1637: Simplify Package data type (#663) (authored by snowleopard).
Simplify Package data type (#663)
Oct 23 2018, 4:39 PM
GitHub <noreply@github.com> committed rGHCe5f13b3a7586: Tweak the build root section (authored by snowleopard).
Tweak the build root section
Oct 23 2018, 4:39 PM
snowleopard committed rGHCa820566c16e1: Minor revision (authored by snowleopard).
Minor revision
Oct 23 2018, 4:39 PM
GitHub <noreply@github.com> committed rGHC0059b9f205d0: Clean up remaining bits of the install rule (#660) (authored by snowleopard).
Clean up remaining bits of the install rule (#660)
Oct 23 2018, 4:39 PM
snowleopard committed rGHCae35b2b2b89f: Remove dead code (authored by snowleopard).
Remove dead code
Oct 23 2018, 4:39 PM
GitHub <noreply@github.com> committed rGHC0106f2039271: Reorganise GHC packages, get rid of Builder import cycle (#662) (authored by snowleopard).
Reorganise GHC packages, get rid of Builder import cycle (#662)
Oct 23 2018, 4:39 PM
GitHub <noreply@github.com> committed rGHC8ec50a585ac6: Fix defaut top level targets (#659) (authored by snowleopard).
Fix defaut top level targets (#659)
Oct 23 2018, 4:39 PM
GitHub <noreply@github.com> committed rGHC8dc4f73f169a: Clean up remaining bits related to ghc-cabal (#658) (authored by snowleopard).
Clean up remaining bits related to ghc-cabal (#658)
Oct 23 2018, 4:39 PM
snowleopard committed rGHCe174dca4d5c6: Drop nonCabalContext, since all GHC packages now come with Cabal files (authored by snowleopard).
Drop nonCabalContext, since all GHC packages now come with Cabal files
Oct 23 2018, 4:39 PM
GitHub <noreply@github.com> committed rGHCa804d57a6b29: Fix package dependencies (#657) (authored by snowleopard).
Fix package dependencies (#657)
Oct 23 2018, 4:39 PM
GitHub <noreply@github.com> committed rGHC2fac053131d4: Fix warnings, improve comments and error handling, minor refactoring (#656) (authored by snowleopard).
Fix warnings, improve comments and error handling, minor refactoring (#656)
Oct 23 2018, 4:39 PM
snowleopard committed rGHC4265e3aab7df: Bump Cabal upper bound (#651) (authored by bgamari).
Bump Cabal upper bound (#651)
Oct 23 2018, 4:39 PM
snowleopard committed rGHC148006a03eae: Remove the hack to use a patched Cabal submodule in CI (#650) (authored by quasicomputational <quasicomputational@gmail.com>).
Remove the hack to use a patched Cabal submodule in CI (#650)
Oct 23 2018, 4:39 PM
snowleopard committed rGHC165f03e90f50: Implement the equivalent of D4955 (#648) (authored by alpmestan).
Implement the equivalent of D4955 (#648)
Oct 23 2018, 4:38 PM
snowleopard committed rGHC23dc432a3f6c: Fixes building with stack within recent versions of ghc repo (#646) (authored by mgsloan).
Fixes building with stack within recent versions of ghc repo (#646)
Oct 23 2018, 4:38 PM
snowleopard committed rGHCe5773fa62333: Switch to the fixed Cabal branch in CI and add a fix for Natural (#640) (authored by alpmestan).
Switch to the fixed Cabal branch in CI and add a fix for Natural (#640)
Oct 23 2018, 4:38 PM
snowleopard committed rGHC843790ea9b3f: Fix timeout building rule for Linux (#638) (authored by alpmestan).
Fix timeout building rule for Linux (#638)
Oct 23 2018, 4:38 PM
snowleopard committed rGHCbbdd69bdaa48: Make Cabal install unconditional in build.cabal.sh (#633) (authored by Chitrak Raj Gupta <chitrak711988@gmail.com>).
Make Cabal install unconditional in build.cabal.sh (#633)
Oct 23 2018, 4:38 PM