sjakobi (Simon Jakobi)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 18 2018, 12:08 PM (47 w, 6 d)

Recent Activity

Wed, Jan 16

sjakobi committed rGHC53874834b779: Mark GHC.Maybe as not-home for haddock (authored by sjakobi).
Mark GHC.Maybe as not-home for haddock
Wed, Jan 16, 12:24 AM

Mon, Jan 7

sjakobi accepted D5463: Create folder if missing for .hie files.

Cheers! :)

Mon, Jan 7, 7:01 PM

Sat, Jan 5

sjakobi updated the summary of D5067: [WIP] Hi Haddock: Enable haddock to generate docs from .hi-files.
Sat, Jan 5, 12:40 AM
sjakobi updated the diff for D5067: [WIP] Hi Haddock: Enable haddock to generate docs from .hi-files.

Rebase

Sat, Jan 5, 12:03 AM

Fri, Dec 28

sjakobi added a comment to D5405: 'DynFlag'-free version of 'mkParserFlags'.

@tdammers Are you satisfied with the latest changes?

Fri, Dec 28, 5:31 AM

Dec 14 2018

sjakobi accepted D4692: Remove OPTIONS_HADDOCK hide in favour for not-home.

LGTM! Thanks for working on this @adamse! :)

Dec 14 2018, 4:56 PM

Dec 5 2018

sjakobi accepted D5239: Support generating HIE files.
Dec 5 2018, 2:33 PM
sjakobi added a comment to D5239: Support generating HIE files.

Thanks for the fixes! One last tiny issue! :)

Dec 5 2018, 12:09 PM

Dec 1 2018

sjakobi added inline comments to D5239: Support generating HIE files.
Dec 1 2018, 2:47 PM

Nov 26 2018

sjakobi added a comment to D5239: Support generating HIE files.

Sorry I didn't review this earlier! :/

Nov 26 2018, 11:51 AM

Nov 25 2018

sjakobi added a comment to D5239: Support generating HIE files.

A few more comments on HieTypes.

Nov 25 2018, 10:20 PM
sjakobi requested changes to D5239: Support generating HIE files.

Thanks for completing this project, @harpocrates! :)

Nov 25 2018, 9:17 PM

Nov 21 2018

sjakobi updated the diff for D5067: [WIP] Hi Haddock: Enable haddock to generate docs from .hi-files.
  • HaddockLex: Replace wrapper with custom code
Nov 21 2018, 4:40 PM

Nov 20 2018

sjakobi added inline comments to D5067: [WIP] Hi Haddock: Enable haddock to generate docs from .hi-files.
Nov 20 2018, 8:14 PM
sjakobi updated the diff for D5067: [WIP] Hi Haddock: Enable haddock to generate docs from .hi-files.
  • -fshow-docs-of-hole-fits: Warn about modules compiled without -haddock
  • Delete loadInterfaceForNameMaybe
Nov 20 2018, 8:09 PM

Nov 19 2018

sjakobi added a comment to D5239: Support generating HIE files.

What logic do we want for recompilation-avoidance? Should compiling with -fenable-ide-info force recompilation if the .hie file isn't found (or is out of date)? Right now, we have none of that, so compiling with -fenable-ide-info only dumps out an .hie file when GHC compiles the module...

Nov 19 2018, 5:45 PM
sjakobi updated the diff for D5343: Refactor TcRnMonad.mapAndRecoverM.
  • Don't use LambdaCase for rightToMaybe
Nov 19 2018, 3:41 PM

Nov 18 2018

sjakobi updated the diff for D5067: [WIP] Hi Haddock: Enable haddock to generate docs from .hi-files.
  • Redefine StringLiteral as a synonym of (WithSourceText FastString)
Nov 18 2018, 11:49 AM

Nov 17 2018

sjakobi added a comment to D5269: 'DynFlag'-free version of 'mkParserFlags'.

@bgamari can you merge this? I'd like to use this patch in D5067.

Nov 17 2018, 10:32 AM
sjakobi updated the diff for D5347: Don't reverse explicit export lists during renaming.
  • Rewrite accumExports in terms of mapAccumLM
Nov 17 2018, 10:15 AM
sjakobi added inline comments to D5347: Don't reverse explicit export lists during renaming.
Nov 17 2018, 8:25 AM

Nov 16 2018

sjakobi added inline comments to D5347: Don't reverse explicit export lists during renaming.
Nov 16 2018, 5:49 PM
sjakobi created D5347: Don't reverse explicit export lists during renaming.
Nov 16 2018, 5:45 PM
sjakobi added a comment to D5343: Refactor TcRnMonad.mapAndRecoverM.

Maybe you could use mapMaybeM instead of a fold?

Nov 16 2018, 2:54 PM
sjakobi updated the diff for D5343: Refactor TcRnMonad.mapAndRecoverM.
  • Improve TcRnMonad.mapAndRecoverM a bit
  • Define mapAndRecoverM via mapMaybeM
Nov 16 2018, 2:53 PM
sjakobi created D5344: Speed up MonadUtils.mapMaybeM.
Nov 16 2018, 2:19 PM
sjakobi created D5343: Refactor TcRnMonad.mapAndRecoverM.
Nov 16 2018, 8:31 AM
sjakobi requested review of D5319: Remove warnings-silencing flags for code generated by Alex.

Do my updates to aclocal.m4 and mk/config.mk.in make sense?

Nov 16 2018, 6:27 AM
sjakobi updated the diff for D5319: Remove warnings-silencing flags for code generated by Alex.

Fix bad revision update

Nov 16 2018, 6:23 AM
sjakobi updated the diff for D5319: Remove warnings-silencing flags for code generated by Alex.
  • Bump Alex version requirement to 3.1.7
Nov 16 2018, 6:21 AM

Nov 10 2018

sjakobi updated subscribers of D5067: [WIP] Hi Haddock: Enable haddock to generate docs from .hi-files.
Nov 10 2018, 4:00 AM
sjakobi updated the diff for D5067: [WIP] Hi Haddock: Enable haddock to generate docs from .hi-files.
  • HaddockLex: Add TODO
  • rnHsDocIdentifier: Check an invariant
Nov 10 2018, 3:15 AM
sjakobi added inline comments to D5067: [WIP] Hi Haddock: Enable haddock to generate docs from .hi-files.
Nov 10 2018, 2:54 AM
sjakobi added inline comments to D5319: Remove warnings-silencing flags for code generated by Alex.
Nov 10 2018, 2:39 AM
sjakobi created D5319: Remove warnings-silencing flags for code generated by Alex.
Nov 10 2018, 2:33 AM

Nov 9 2018

sjakobi updated the diff for D5067: [WIP] Hi Haddock: Enable haddock to generate docs from .hi-files.
  • Break some overlong lines
  • Strictly serialize the mi_docs constructor, lazily serialize the Docs inside
Nov 9 2018, 10:52 PM
sjakobi updated the diff for D5067: [WIP] Hi Haddock: Enable haddock to generate docs from .hi-files.
  • Fix serialization of language extensions
Nov 9 2018, 9:35 PM
sjakobi updated the diff for D5067: [WIP] Hi Haddock: Enable haddock to generate docs from .hi-files.
  • Bump haddock
  • Speed up utf8SplitAtByteString
Nov 9 2018, 7:03 PM

Nov 4 2018

sjakobi abandoned D4749: [WIP] Lex and rename docstrings.

Superseded by D5067.

Nov 4 2018, 7:28 AM

Oct 29 2018

sjakobi accepted D5269: 'DynFlag'-free version of 'mkParserFlags'.

Cheers! :)

Oct 29 2018, 11:19 AM

Oct 28 2018

sjakobi added inline comments to D5269: 'DynFlag'-free version of 'mkParserFlags'.
Oct 28 2018, 6:14 AM

Oct 27 2018

sjakobi added inline comments to D5269: 'DynFlag'-free version of 'mkParserFlags'.
Oct 27 2018, 7:46 AM

Oct 26 2018

sjakobi updated the diff for D5067: [WIP] Hi Haddock: Enable haddock to generate docs from .hi-files.
  • HaddockLex: Simplify a type
Oct 26 2018, 12:02 PM
sjakobi added inline comments to D5067: [WIP] Hi Haddock: Enable haddock to generate docs from .hi-files.
Oct 26 2018, 11:48 AM
sjakobi updated the diff for D5067: [WIP] Hi Haddock: Enable haddock to generate docs from .hi-files.
  • appendHsDoc: Clarify
Oct 26 2018, 11:38 AM
sjakobi updated the diff for D5067: [WIP] Hi Haddock: Enable haddock to generate docs from .hi-files.
  • extractDocs': Rely on tcg_rn_decls to be Just
  • A small haddock improvement
Oct 26 2018, 11:16 AM
sjakobi updated the diff for D5067: [WIP] Hi Haddock: Enable haddock to generate docs from .hi-files.
  • getNamedChunks: Add docs
Oct 26 2018, 10:51 AM
sjakobi added inline comments to D5067: [WIP] Hi Haddock: Enable haddock to generate docs from .hi-files.
Oct 26 2018, 10:34 AM
sjakobi updated the diff for D5067: [WIP] Hi Haddock: Enable haddock to generate docs from .hi-files.
  • Binary instances for ordered containers: Simply use fromList
Oct 26 2018, 10:27 AM
sjakobi added inline comments to D5067: [WIP] Hi Haddock: Enable haddock to generate docs from .hi-files.
Oct 26 2018, 12:52 AM

Oct 25 2018

sjakobi updated the diff for D5067: [WIP] Hi Haddock: Enable haddock to generate docs from .hi-files.
  • Don't split identifiers off docstrings for serialization
Oct 25 2018, 2:22 PM

Oct 23 2018

sjakobi added inline comments to D5158: Document the list data type.
Oct 23 2018, 1:27 PM
sjakobi added inline comments to D5158: Document the list data type.
Oct 23 2018, 1:20 PM

Oct 22 2018

sjakobi updated the diff for D5067: [WIP] Hi Haddock: Enable haddock to generate docs from .hi-files.
  • Remove redundant import
Oct 22 2018, 7:24 PM
sjakobi updated the diff for D5067: [WIP] Hi Haddock: Enable haddock to generate docs from .hi-files.
  • Use extractDocs' iff we have -haddock
  • mkDocStructure: Clarify handling of explicit export list
  • mkDocStructureFromExportList: Misc cleanup
Oct 22 2018, 5:23 PM
sjakobi updated the diff for D5067: [WIP] Hi Haddock: Enable haddock to generate docs from .hi-files.
  • Port over some fixes to 'ExtractDocs'
  • Add Haddock 'print-explicit-runtime-reps' in libs
Oct 22 2018, 12:08 PM

Oct 20 2018

sjakobi updated the Trac tickets for D5067: [WIP] Hi Haddock: Enable haddock to generate docs from .hi-files.
Oct 20 2018, 6:29 AM

Oct 18 2018

sjakobi abandoned D4679: RTS: Auto-size the allocation area depending on CPU cache size.

@sjakobi, what is your plan for this?

Oct 18 2018, 2:18 PM

Sep 11 2018

sjakobi added a comment to D4924: Add a strict version of foldMap to Foldable.

The test failures look unrelated to me.

Sep 11 2018, 4:03 PM

Sep 10 2018

sjakobi updated the diff for D4924: Add a strict version of foldMap to Foldable.

Rebase & changelog entry

Sep 10 2018, 9:14 PM

Aug 29 2018

sjakobi added a comment to D4913: Make :doc work for the ghc library.

@bgamari: Can we get this into ghc-8.6 too?

Aug 29 2018, 10:31 AM

Aug 23 2018

sjakobi added a comment to D5067: [WIP] Hi Haddock: Enable haddock to generate docs from .hi-files.
  • mkMaps and other Haddock survivors. Some of the nasty bits from haddock moved into GHC with this patch (and the prior one). We should look for an alternative to store and extract documentation. Simon suggest putting documentation into IfaceDecl directly. Rendering would then have to traverse the IfaceDecls only.
Aug 23 2018, 10:37 AM

Aug 22 2018

sjakobi added inline comments to D5067: [WIP] Hi Haddock: Enable haddock to generate docs from .hi-files.
Aug 22 2018, 4:21 AM

Aug 20 2018

sjakobi added inline comments to D5067: [WIP] Hi Haddock: Enable haddock to generate docs from .hi-files.
Aug 20 2018, 6:41 PM
sjakobi added a comment to D5067: [WIP] Hi Haddock: Enable haddock to generate docs from .hi-files.

Please mention the Trac ticket number in the summary (click "Edit revision"). Create a ticket first if it doesn't exist yet.

Aug 20 2018, 5:07 PM
sjakobi added a comment to D5057: [WIP] Remove Haddock tokens from the grammar.

I suspect this might fix https://ghc.haskell.org/trac/ghc/ticket/15029 too?!

Aug 20 2018, 1:44 PM

Aug 16 2018

adamse awarded D5067: [WIP] Hi Haddock: Enable haddock to generate docs from .hi-files a Mountain of Wealth token.
Aug 16 2018, 5:12 PM

Aug 14 2018

sjakobi updated the summary of D5067: [WIP] Hi Haddock: Enable haddock to generate docs from .hi-files.
Aug 14 2018, 8:40 AM
sjakobi updated the summary of D5067: [WIP] Hi Haddock: Enable haddock to generate docs from .hi-files.
Aug 14 2018, 8:39 AM
sjakobi created D5067: [WIP] Hi Haddock: Enable haddock to generate docs from .hi-files.
Aug 14 2018, 8:15 AM

Aug 3 2018

sjakobi added a comment to D4852: --show-iface: Qualify all non-local names.

Bump

Aug 3 2018, 11:14 PM
sjakobi added a comment to D4924: Add a strict version of foldMap to Foldable.

@bgamari: Bump

Aug 3 2018, 11:13 PM
sjakobi abandoned D4996: Update haddock to state of upstream ghc-head branch.
Aug 3 2018, 11:11 PM

Jul 20 2018

sjakobi created D4996: Update haddock to state of upstream ghc-head branch.
Jul 20 2018, 9:34 AM
sjakobi created D4995: Update haddock to state of upstream ghc-8.6 branch.
Jul 20 2018, 9:30 AM

Jul 18 2018

sjakobi added a comment to D4913: Make :doc work for the ghc library.

It would be interesting to know how much of an effect this has on interface file sizes. I doubt it's much , but it would be a good measurement to do. I'll try to characterise this as I merge.

Jul 18 2018, 4:42 PM

Jul 17 2018

sjakobi abandoned D4973: Add functions for splitting sigma types while preserving type synonyms.

Any reason you can't put these functions in Haddock itself?

Jul 17 2018, 3:32 AM

Jul 16 2018

sjakobi created D4973: Add functions for splitting sigma types while preserving type synonyms.
Jul 16 2018, 6:30 PM

Jul 7 2018

sjakobi updated the diff for D4924: Add a strict version of foldMap to Foldable.
  • Bump version in @since annotation
Jul 7 2018, 1:25 AM

Jul 4 2018

sjakobi updated the diff for D4924: Add a strict version of foldMap to Foldable.

Rebase

Jul 4 2018, 11:12 AM
sjakobi planned changes to D4924: Add a strict version of foldMap to Foldable.

Oops. Looks like I lost my first commit that in fact added the foldMap' method.

Jul 4 2018, 11:05 AM

Jul 3 2018

sjakobi updated the diff for D4924: Add a strict version of foldMap to Foldable.
  • Use (<>) instead of mappend
Jul 3 2018, 5:45 AM
sjakobi updated the diff for D4924: Add a strict version of foldMap to Foldable.
  • Remove bang pattern – we're using foldl'!
Jul 3 2018, 5:13 AM

Jul 2 2018

sjakobi created D4924: Add a strict version of foldMap to Foldable.
Jul 2 2018, 7:51 PM
sjakobi added a comment to D4913: Make :doc work for the ghc library.

Sorry, I wasn't clear. This change should be useful on both master and ghc-8.6.

Jul 2 2018, 12:25 PM
sjakobi accepted D4847: UniqFM: Use foldl' instead of fold.

LGTM. Using foldl' instead of foldl seems less confusing/surprising to me.

Jul 2 2018, 10:53 AM

Jul 1 2018

sjakobi added a comment to D4913: Make :doc work for the ghc library.

I've realized that I've forked this branch off master although I want this change to go onto the ghc-8.6 branch. Do I need to change something?

Jul 1 2018, 7:25 AM

Jun 30 2018

sjakobi created D4913: Make :doc work for the ghc library.
Jun 30 2018, 7:09 PM

Jun 17 2018

sjakobi accepted D4848: Add flag to show docs of valid hole fits.

LGTM.

Jun 17 2018, 6:18 PM
sjakobi requested changes to D4848: Add flag to show docs of valid hole fits.
Jun 17 2018, 5:29 PM
sjakobi updated the diff for D4852: --show-iface: Qualify all non-local names.
  • Add Note [Name qualification with --show-iface]
Jun 17 2018, 9:05 AM

Jun 15 2018

sjakobi accepted D4736: Change to improve Eq, Ord, Float and Double documentation (trac issue #15078)..

Thanks! :)

Jun 15 2018, 1:06 PM
sjakobi created D4852: --show-iface: Qualify all non-local names.
Jun 15 2018, 12:17 PM
sjakobi added inline comments to D4848: Add flag to show docs of valid hole fits.
Jun 15 2018, 10:17 AM
sjakobi added a comment to D4848: Add flag to show docs of valid hole fits.

I appreciate the changes to getDocs but I have some qualms about the import of InteractiveEval from typecheck/.

Jun 15 2018, 9:36 AM
sjakobi added a comment to D4848: Add flag to show docs of valid hole fits.

An alternative method to get the documentation, would be to use extractDocs on the existing TcGblEnv.

Jun 15 2018, 7:06 AM
sjakobi added a comment to D4848: Add flag to show docs of valid hole fits.

@sjakobi @alexbiehl do you know what's going on with the test errors? They all seem to be variants of

Bad interface file: T11274.hi
    T11274.hi: openBinaryFile: does not exist (No such file or directory)

or

Compile failed (exit code 1) errors were:
[1 of 2] Compiling ValidHoleFits    ( ValidHoleFits.hs, ValidHoleFits.o )
[2 of 2] Compiling Foo              ( valid_hole_fits.hs, valid_hole_fits.o )
attempting to use module ‘main:Foo’ (valid_hole_fits.hs) which is not loaded

Neither of which seem to be related to how I'm using the getDocs function.

Jun 15 2018, 6:08 AM

Jun 14 2018

sjakobi created D4847: UniqFM: Use foldl' instead of fold.
Jun 14 2018, 10:17 AM

Jun 13 2018

sjakobi abandoned D4806: --show-iface: Always qualify names.

I have created Trac #15269.

Jun 13 2018, 7:15 AM

Jun 8 2018

sjakobi updated the diff for D4816: Fix deserialization of docs (#15240).
  • Add reference to stableNameCmp
Jun 8 2018, 5:04 PM