sjakobi (Simon Jakobi)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 18 2018, 12:08 PM (38 w, 5 d)

Recent Activity

Yesterday

sjakobi added inline comments to D5347: Don't reverse explicit export lists during renaming.
Fri, Nov 16, 5:49 PM
sjakobi created D5347: Don't reverse explicit export lists during renaming.
Fri, Nov 16, 5:45 PM
sjakobi added a comment to D5343: Refactor TcRnMonad.mapAndRecoverM.

Maybe you could use mapMaybeM instead of a fold?

Fri, Nov 16, 2:54 PM
sjakobi updated the diff for D5343: Refactor TcRnMonad.mapAndRecoverM.
  • Improve TcRnMonad.mapAndRecoverM a bit
  • Define mapAndRecoverM via mapMaybeM
Fri, Nov 16, 2:53 PM
sjakobi created D5344: Speed up MonadUtils.mapMaybeM.
Fri, Nov 16, 2:19 PM
sjakobi created D5343: Refactor TcRnMonad.mapAndRecoverM.
Fri, Nov 16, 8:31 AM
sjakobi requested review of D5319: Remove warnings-silencing flags for code generated by Alex.

Do my updates to aclocal.m4 and mk/config.mk.in make sense?

Fri, Nov 16, 6:27 AM
sjakobi updated the diff for D5319: Remove warnings-silencing flags for code generated by Alex.

Fix bad revision update

Fri, Nov 16, 6:23 AM
sjakobi updated the diff for D5319: Remove warnings-silencing flags for code generated by Alex.
  • Bump Alex version requirement to 3.1.7
Fri, Nov 16, 6:21 AM

Sat, Nov 10

sjakobi updated subscribers of D5067: [WIP] Hi Haddock: Enable haddock to generate docs from .hi-files.
Sat, Nov 10, 4:00 AM
sjakobi updated the diff for D5067: [WIP] Hi Haddock: Enable haddock to generate docs from .hi-files.
  • HaddockLex: Add TODO
  • rnHsDocIdentifier: Check an invariant
Sat, Nov 10, 3:15 AM
sjakobi added inline comments to D5067: [WIP] Hi Haddock: Enable haddock to generate docs from .hi-files.
Sat, Nov 10, 2:54 AM
sjakobi added inline comments to D5319: Remove warnings-silencing flags for code generated by Alex.
Sat, Nov 10, 2:39 AM
sjakobi created D5319: Remove warnings-silencing flags for code generated by Alex.
Sat, Nov 10, 2:33 AM

Fri, Nov 9

sjakobi updated the diff for D5067: [WIP] Hi Haddock: Enable haddock to generate docs from .hi-files.
  • Break some overlong lines
  • Strictly serialize the mi_docs constructor, lazily serialize the Docs inside
Fri, Nov 9, 10:52 PM
sjakobi updated the diff for D5067: [WIP] Hi Haddock: Enable haddock to generate docs from .hi-files.
  • Fix serialization of language extensions
Fri, Nov 9, 9:35 PM
sjakobi updated the diff for D5067: [WIP] Hi Haddock: Enable haddock to generate docs from .hi-files.
  • Bump haddock
  • Speed up utf8SplitAtByteString
Fri, Nov 9, 7:03 PM

Sun, Nov 4

sjakobi abandoned D4749: [WIP] Lex and rename docstrings.

Superseded by D5067.

Sun, Nov 4, 7:28 AM

Mon, Oct 29

sjakobi accepted D5269: 'DynFlag'-free version of 'mkParserFlags'.

Cheers! :)

Mon, Oct 29, 11:19 AM

Sun, Oct 28

sjakobi added inline comments to D5269: 'DynFlag'-free version of 'mkParserFlags'.
Sun, Oct 28, 6:14 AM

Sat, Oct 27

sjakobi added inline comments to D5269: 'DynFlag'-free version of 'mkParserFlags'.
Sat, Oct 27, 7:46 AM

Fri, Oct 26

sjakobi updated the diff for D5067: [WIP] Hi Haddock: Enable haddock to generate docs from .hi-files.
  • HaddockLex: Simplify a type
Fri, Oct 26, 12:02 PM
sjakobi added inline comments to D5067: [WIP] Hi Haddock: Enable haddock to generate docs from .hi-files.
Fri, Oct 26, 11:48 AM
sjakobi updated the diff for D5067: [WIP] Hi Haddock: Enable haddock to generate docs from .hi-files.
  • appendHsDoc: Clarify
Fri, Oct 26, 11:38 AM
sjakobi updated the diff for D5067: [WIP] Hi Haddock: Enable haddock to generate docs from .hi-files.
  • extractDocs': Rely on tcg_rn_decls to be Just
  • A small haddock improvement
Fri, Oct 26, 11:16 AM
sjakobi updated the diff for D5067: [WIP] Hi Haddock: Enable haddock to generate docs from .hi-files.
  • getNamedChunks: Add docs
Fri, Oct 26, 10:51 AM
sjakobi added inline comments to D5067: [WIP] Hi Haddock: Enable haddock to generate docs from .hi-files.
Fri, Oct 26, 10:34 AM
sjakobi updated the diff for D5067: [WIP] Hi Haddock: Enable haddock to generate docs from .hi-files.
  • Binary instances for ordered containers: Simply use fromList
Fri, Oct 26, 10:27 AM
sjakobi added inline comments to D5067: [WIP] Hi Haddock: Enable haddock to generate docs from .hi-files.
Fri, Oct 26, 12:52 AM

Thu, Oct 25

sjakobi updated the diff for D5067: [WIP] Hi Haddock: Enable haddock to generate docs from .hi-files.
  • Don't split identifiers off docstrings for serialization
Thu, Oct 25, 2:22 PM

Tue, Oct 23

sjakobi added inline comments to D5158: Document the list data type.
Tue, Oct 23, 1:27 PM
sjakobi added inline comments to D5158: Document the list data type.
Tue, Oct 23, 1:20 PM

Mon, Oct 22

sjakobi updated the diff for D5067: [WIP] Hi Haddock: Enable haddock to generate docs from .hi-files.
  • Remove redundant import
Mon, Oct 22, 7:24 PM
sjakobi updated the diff for D5067: [WIP] Hi Haddock: Enable haddock to generate docs from .hi-files.
  • Use extractDocs' iff we have -haddock
  • mkDocStructure: Clarify handling of explicit export list
  • mkDocStructureFromExportList: Misc cleanup
Mon, Oct 22, 5:23 PM
sjakobi updated the diff for D5067: [WIP] Hi Haddock: Enable haddock to generate docs from .hi-files.
  • Port over some fixes to 'ExtractDocs'
  • Add Haddock 'print-explicit-runtime-reps' in libs
Mon, Oct 22, 12:08 PM

Sat, Oct 20

sjakobi updated the Trac tickets for D5067: [WIP] Hi Haddock: Enable haddock to generate docs from .hi-files.
Sat, Oct 20, 6:29 AM

Thu, Oct 18

sjakobi abandoned D4679: RTS: Auto-size the allocation area depending on CPU cache size.

@sjakobi, what is your plan for this?

Thu, Oct 18, 2:18 PM

Sep 11 2018

sjakobi added a comment to D4924: Add a strict version of foldMap to Foldable.

The test failures look unrelated to me.

Sep 11 2018, 4:03 PM

Sep 10 2018

sjakobi updated the diff for D4924: Add a strict version of foldMap to Foldable.

Rebase & changelog entry

Sep 10 2018, 9:14 PM

Aug 29 2018

sjakobi added a comment to D4913: Make :doc work for the ghc library.

@bgamari: Can we get this into ghc-8.6 too?

Aug 29 2018, 10:31 AM

Aug 23 2018

sjakobi added a comment to D5067: [WIP] Hi Haddock: Enable haddock to generate docs from .hi-files.
  • mkMaps and other Haddock survivors. Some of the nasty bits from haddock moved into GHC with this patch (and the prior one). We should look for an alternative to store and extract documentation. Simon suggest putting documentation into IfaceDecl directly. Rendering would then have to traverse the IfaceDecls only.
Aug 23 2018, 10:37 AM

Aug 22 2018

sjakobi added inline comments to D5067: [WIP] Hi Haddock: Enable haddock to generate docs from .hi-files.
Aug 22 2018, 4:21 AM

Aug 20 2018

sjakobi added inline comments to D5067: [WIP] Hi Haddock: Enable haddock to generate docs from .hi-files.
Aug 20 2018, 6:41 PM
sjakobi added a comment to D5067: [WIP] Hi Haddock: Enable haddock to generate docs from .hi-files.

Please mention the Trac ticket number in the summary (click "Edit revision"). Create a ticket first if it doesn't exist yet.

Aug 20 2018, 5:07 PM
sjakobi added a comment to D5057: [WIP] Remove Haddock tokens from the grammar.

I suspect this might fix https://ghc.haskell.org/trac/ghc/ticket/15029 too?!

Aug 20 2018, 1:44 PM

Aug 16 2018

adamse awarded D5067: [WIP] Hi Haddock: Enable haddock to generate docs from .hi-files a Mountain of Wealth token.
Aug 16 2018, 5:12 PM

Aug 14 2018

sjakobi updated the summary of D5067: [WIP] Hi Haddock: Enable haddock to generate docs from .hi-files.
Aug 14 2018, 8:40 AM
sjakobi updated the summary of D5067: [WIP] Hi Haddock: Enable haddock to generate docs from .hi-files.
Aug 14 2018, 8:39 AM
sjakobi created D5067: [WIP] Hi Haddock: Enable haddock to generate docs from .hi-files.
Aug 14 2018, 8:15 AM

Aug 3 2018

sjakobi added a comment to D4852: --show-iface: Qualify all non-local names.

Bump

Aug 3 2018, 11:14 PM
sjakobi added a comment to D4924: Add a strict version of foldMap to Foldable.

@bgamari: Bump

Aug 3 2018, 11:13 PM
sjakobi abandoned D4996: Update haddock to state of upstream ghc-head branch.
Aug 3 2018, 11:11 PM

Jul 20 2018

sjakobi created D4996: Update haddock to state of upstream ghc-head branch.
Jul 20 2018, 9:34 AM
sjakobi created D4995: Update haddock to state of upstream ghc-8.6 branch.
Jul 20 2018, 9:30 AM

Jul 18 2018

sjakobi added a comment to D4913: Make :doc work for the ghc library.

It would be interesting to know how much of an effect this has on interface file sizes. I doubt it's much , but it would be a good measurement to do. I'll try to characterise this as I merge.

Jul 18 2018, 4:42 PM

Jul 17 2018

sjakobi abandoned D4973: Add functions for splitting sigma types while preserving type synonyms.

Any reason you can't put these functions in Haddock itself?

Jul 17 2018, 3:32 AM

Jul 16 2018

sjakobi created D4973: Add functions for splitting sigma types while preserving type synonyms.
Jul 16 2018, 6:30 PM

Jul 7 2018

sjakobi updated the diff for D4924: Add a strict version of foldMap to Foldable.
  • Bump version in @since annotation
Jul 7 2018, 1:25 AM

Jul 4 2018

sjakobi updated the diff for D4924: Add a strict version of foldMap to Foldable.

Rebase

Jul 4 2018, 11:12 AM
sjakobi planned changes to D4924: Add a strict version of foldMap to Foldable.

Oops. Looks like I lost my first commit that in fact added the foldMap' method.

Jul 4 2018, 11:05 AM

Jul 3 2018

sjakobi updated the diff for D4924: Add a strict version of foldMap to Foldable.
  • Use (<>) instead of mappend
Jul 3 2018, 5:45 AM
sjakobi updated the diff for D4924: Add a strict version of foldMap to Foldable.
  • Remove bang pattern – we're using foldl'!
Jul 3 2018, 5:13 AM

Jul 2 2018

sjakobi created D4924: Add a strict version of foldMap to Foldable.
Jul 2 2018, 7:51 PM
sjakobi added a comment to D4913: Make :doc work for the ghc library.

Sorry, I wasn't clear. This change should be useful on both master and ghc-8.6.

Jul 2 2018, 12:25 PM
sjakobi accepted D4847: UniqFM: Use foldl' instead of fold.

LGTM. Using foldl' instead of foldl seems less confusing/surprising to me.

Jul 2 2018, 10:53 AM

Jul 1 2018

sjakobi added a comment to D4913: Make :doc work for the ghc library.

I've realized that I've forked this branch off master although I want this change to go onto the ghc-8.6 branch. Do I need to change something?

Jul 1 2018, 7:25 AM

Jun 30 2018

sjakobi created D4913: Make :doc work for the ghc library.
Jun 30 2018, 7:09 PM

Jun 17 2018

sjakobi accepted D4848: Add flag to show docs of valid hole fits.

LGTM.

Jun 17 2018, 6:18 PM
sjakobi requested changes to D4848: Add flag to show docs of valid hole fits.
Jun 17 2018, 5:29 PM
sjakobi updated the diff for D4852: --show-iface: Qualify all non-local names.
  • Add Note [Name qualification with --show-iface]
Jun 17 2018, 9:05 AM

Jun 15 2018

sjakobi accepted D4736: Change to improve Eq, Ord, Float and Double documentation (trac issue #15078)..

Thanks! :)

Jun 15 2018, 1:06 PM
sjakobi created D4852: --show-iface: Qualify all non-local names.
Jun 15 2018, 12:17 PM
sjakobi added inline comments to D4848: Add flag to show docs of valid hole fits.
Jun 15 2018, 10:17 AM
sjakobi added a comment to D4848: Add flag to show docs of valid hole fits.

I appreciate the changes to getDocs but I have some qualms about the import of InteractiveEval from typecheck/.

Jun 15 2018, 9:36 AM
sjakobi added a comment to D4848: Add flag to show docs of valid hole fits.

An alternative method to get the documentation, would be to use extractDocs on the existing TcGblEnv.

Jun 15 2018, 7:06 AM
sjakobi added a comment to D4848: Add flag to show docs of valid hole fits.

@sjakobi @alexbiehl do you know what's going on with the test errors? They all seem to be variants of

Bad interface file: T11274.hi
    T11274.hi: openBinaryFile: does not exist (No such file or directory)

or

Compile failed (exit code 1) errors were:
[1 of 2] Compiling ValidHoleFits    ( ValidHoleFits.hs, ValidHoleFits.o )
[2 of 2] Compiling Foo              ( valid_hole_fits.hs, valid_hole_fits.o )
attempting to use module ‘main:Foo’ (valid_hole_fits.hs) which is not loaded

Neither of which seem to be related to how I'm using the getDocs function.

Jun 15 2018, 6:08 AM

Jun 14 2018

sjakobi created D4847: UniqFM: Use foldl' instead of fold.
Jun 14 2018, 10:17 AM

Jun 13 2018

sjakobi abandoned D4806: --show-iface: Always qualify names.

I have created Trac #15269.

Jun 13 2018, 7:15 AM

Jun 8 2018

sjakobi updated the diff for D4816: Fix deserialization of docs (#15240).
  • Add reference to stableNameCmp
Jun 8 2018, 5:04 PM
sjakobi updated the diff for D4816: Fix deserialization of docs (#15240).
  • Testsuite: Accept corrected output for DocsInHiFile1
Jun 8 2018, 4:59 PM
sjakobi created D4816: Fix deserialization of docs (#15240).
Jun 8 2018, 8:45 AM

Jun 7 2018

sjakobi added a comment to D4806: --show-iface: Always qualify names.

I'm not sure I follow why this is an improvement. It seems like this is only introducing noise. Perhaps I'm missing some context?

Jun 7 2018, 9:49 AM
sjakobi created D4806: --show-iface: Always qualify names.
Jun 7 2018, 7:41 AM

Jun 5 2018

sjakobi retitled D4749: [WIP] Lex and rename docstrings from [DON'T MERGE] Lex docstrings and include them in .hi-files to [WIP] Lex and rename docstrings.
Jun 5 2018, 10:39 AM
sjakobi updated the diff for D4749: [WIP] Lex and rename docstrings.

Rebase on master

Jun 5 2018, 10:22 AM

Jun 4 2018

sjakobi requested changes to D4736: Change to improve Eq, Ord, Float and Double documentation (trac issue #15078)..
Jun 4 2018, 4:44 PM

Jun 3 2018

sjakobi added a comment to D4758: Serialize docstrings to ifaces, display them with new GHCi :doc command.

Maybe we could output a note that :doc is a tech preview and that ANSI codes and highlighting might come in later iterations.

Jun 3 2018, 10:48 AM
sjakobi updated the diff for D4758: Serialize docstrings to ifaces, display them with new GHCi :doc command.
  • HsDoc: Fix complexity of concatDocs
  • getDocs: Add TODO
  • Expand comment on why we keep the renamed syntax with -haddock
Jun 3 2018, 10:27 AM
sjakobi accepted D4736: Change to improve Eq, Ord, Float and Double documentation (trac issue #15078)..
Jun 3 2018, 3:04 AM
sjakobi added a comment to D4736: Change to improve Eq, Ord, Float and Double documentation (trac issue #15078)..

This is the first time I hear about exponential fields and division rings though, so it would be good if someone more knowledgeable about algebra could review this too.

Jun 3 2018, 3:04 AM

Jun 1 2018

sjakobi updated the diff for D4758: Serialize docstrings to ifaces, display them with new GHCi :doc command.
  • Fix concatenation of docstrings
Jun 1 2018, 9:04 AM

May 31 2018

sjakobi updated the diff for D4758: Serialize docstrings to ifaces, display them with new GHCi :doc command.
  • mk/config.mk.in: Add -haddock to GhcLibHcOpts
May 31 2018, 10:34 AM
sjakobi added a comment to D4758: Serialize docstrings to ifaces, display them with new GHCi :doc command.

Here is a little demonstration of the :doc command:

May 31 2018, 9:29 AM
sjakobi updated the diff for D4758: Serialize docstrings to ifaces, display them with new GHCi :doc command.
  • Remove outdated TODO
May 31 2018, 8:37 AM
sjakobi created D4758: Serialize docstrings to ifaces, display them with new GHCi :doc command.
May 31 2018, 8:37 AM

May 30 2018

sjakobi requested changes to D4736: Change to improve Eq, Ord, Float and Double documentation (trac issue #15078)..
May 30 2018, 7:15 PM
sjakobi added a comment to D4736: Change to improve Eq, Ord, Float and Double documentation (trac issue #15078)..

Thanks for your changes! I really like how this is turning out.

May 30 2018, 7:15 PM

May 29 2018

sjakobi added a comment to D4749: [WIP] Lex and rename docstrings.

BTW the build fails only because haddock hasn't been adapted yet.

May 29 2018, 1:18 PM
sjakobi added inline comments to D4749: [WIP] Lex and rename docstrings.
May 29 2018, 1:17 PM
sjakobi updated the diff for D4749: [WIP] Lex and rename docstrings.
  • Fix build with ghc-8.2
  • Fix line length issues
May 29 2018, 9:53 AM