sighingnow (HE, Tao)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Jan 5 2017, 11:19 PM (59 w, 21 h)
Availability
Available

Recent Activity

Fri, Feb 9

sighingnow updated the diff for D4400: Improve exhaustive checking for guards in pattern bindings and MultiIf..
  • Fix the misunderstanding for m_pats and add a PatBindGuards context.
Fri, Feb 9, 10:37 AM

Thu, Feb 8

sighingnow updated the summary of D4400: Improve exhaustive checking for guards in pattern bindings and MultiIf..
Thu, Feb 8, 11:35 PM
sighingnow created D4400: Improve exhaustive checking for guards in pattern bindings and MultiIf..
Thu, Feb 8, 11:34 PM

Wed, Feb 7

sighingnow updated the diff for D4397: Improve error message for UNPACK/strictness annotations..

Unstage again...

Wed, Feb 7, 11:29 AM
sighingnow updated the diff for D4397: Improve error message for UNPACK/strictness annotations..

Unstage hadrian changes again.

Wed, Feb 7, 11:26 AM
sighingnow updated the diff for D4397: Improve error message for UNPACK/strictness annotations..

Unstage hadrian changes.

Wed, Feb 7, 11:21 AM
sighingnow created D4397: Improve error message for UNPACK/strictness annotations..
Wed, Feb 7, 11:19 AM

Tue, Feb 6

sighingnow updated the diff for D4384: Improve X86CodeGen's pprASCII..
  • Add Note [Pretty print ASCII when AsmCodeGen].
Tue, Feb 6, 6:25 AM
mpickering awarded D4384: Improve X86CodeGen's pprASCII. a Like token.
Tue, Feb 6, 5:28 AM
sighingnow added a reviewer for D4384: Improve X86CodeGen's pprASCII.: mpickering.
Tue, Feb 6, 12:47 AM
sighingnow created D4384: Improve X86CodeGen's pprASCII..
Tue, Feb 6, 12:31 AM

Thu, Feb 1

sighingnow added a comment to D4350: Raise parse error for `data T where`..

Thanks @adamse, fixed.

Thu, Feb 1, 8:11 PM
sighingnow updated the diff for D4350: Raise parse error for `data T where`..

Just check -XGADTSyntax since -XGADTs implies -XGADTSyntax.

Thu, Feb 1, 8:10 PM

Wed, Jan 31

sighingnow created D4361: Flag `-fdefer-typed-holes` also implies `-fdefer-out-of-scope-variables`..
Wed, Jan 31, 11:21 PM
sighingnow updated the diff for D4359: UnboxedTuples can't be used as constraints. Fix #14740..

Add comment for function checkContext.

Wed, Jan 31, 8:02 PM
sighingnow created D4359: UnboxedTuples can't be used as constraints. Fix #14740..
Wed, Jan 31, 3:45 AM

Mon, Jan 29

sighingnow updated the diff for D4350: Raise parse error for `data T where`..

Fix syntax in docs.

Mon, Jan 29, 10:06 AM
sighingnow updated the diff for D4350: Raise parse error for `data T where`..

Document the breaking change.

Mon, Jan 29, 9:25 AM
sighingnow updated the diff for D4350: Raise parse error for `data T where`..

Move the check logic to RdrHsSyn as checkEmptyGADTs.

Mon, Jan 29, 7:18 AM
sighingnow created D4350: Raise parse error for `data T where`..
Mon, Jan 29, 5:43 AM

Jan 12 2018

sighingnow updated the summary of D4305: Fix hash in haddock of ghc-prim..
Jan 12 2018, 6:23 AM
sighingnow created D4305: Fix hash in haddock of ghc-prim..
Jan 12 2018, 6:22 AM

Sep 17 2017

sighingnow added a reviewer for D3986: Make zipWith and zipWith3 inlinable.: dfeuer.
Sep 17 2017, 8:51 PM
Herald added a reviewer for D3986: Make zipWith and zipWith3 inlinable.: austin.
Sep 17 2017, 8:50 PM

Sep 13 2017

sighingnow added a comment to D3940: Fix missing fields warnings in empty record construction, fix #13870.

Yes.

Sep 13 2017, 8:33 PM · GHC
sighingnow added a comment to D3940: Fix missing fields warnings in empty record construction, fix #13870.

I didn't check that field_strs and field_labels are both empty. In checkMissingFields I checked that field_strs must NOT be empty and field_labels must be empty, and then throw the missing-fields warning.

Sep 13 2017, 7:54 AM · GHC
sighingnow updated the diff for D3940: Fix missing fields warnings in empty record construction, fix #13870.

Use when rather than unless and not, response to @mpickering's comment.

Sep 13 2017, 3:32 AM · GHC
sighingnow added a comment to D3940: Fix missing fields warnings in empty record construction, fix #13870.

Sorry for the typo, "we" should be "when".

Sep 13 2017, 3:27 AM · GHC
sighingnow added a comment to D3940: Fix missing fields warnings in empty record construction, fix #13870.

The field_strs needs to be checked because we field_strs is null, the constructor has no fields, for example, Nothing. If we write Nothing{} to construct a Maybe Int, no warning should be thrown, as described in test2 of T13870.hs.

Sep 13 2017, 3:26 AM · GHC

Sep 12 2017

sighingnow updated the diff for D3940: Fix missing fields warnings in empty record construction, fix #13870.

Fix warning message inconsistence with other test cases.

Sep 12 2017, 7:39 PM · GHC
sighingnow added a comment to D3940: Fix missing fields warnings in empty record construction, fix #13870.

Thanks for your hint, Ben. I have upload a new diff revision via arcanist.

Sep 12 2017, 7:29 PM · GHC
sighingnow updated the diff for D3940: Fix missing fields warnings in empty record construction, fix #13870.

Fix missing fields warnings in empty record construction, fix Trac #13870.

Sep 12 2017, 7:27 PM · GHC

Sep 11 2017

sighingnow updated the test plan for D3940: Fix missing fields warnings in empty record construction, fix #13870.
Sep 11 2017, 7:18 AM · GHC

Sep 10 2017

sighingnow added a comment to D3940: Fix missing fields warnings in empty record construction, fix #13870.

I'm newcomer to ghc and not familiar with Harbormaster, could any help me on the build failure ?

Sep 10 2017, 9:24 PM · GHC
sighingnow created D3940: Fix missing fields warnings in empty record construction, fix #13870.
Sep 10 2017, 9:20 PM · GHC
sighingnow added a comment to D3938: Make IntPtr and WordPtr as instance of Data.Data typeclass, fix #13115.

Thanks for your help, @RyanGlScott.

Sep 10 2017, 9:43 AM
sighingnow updated the diff for D3938: Make IntPtr and WordPtr as instance of Data.Data typeclass, fix #13115.
Sep 10 2017, 9:39 AM
sighingnow updated the test plan for D3938: Make IntPtr and WordPtr as instance of Data.Data typeclass, fix #13115.
Sep 10 2017, 9:31 AM
sighingnow updated the Trac tickets for D3938: Make IntPtr and WordPtr as instance of Data.Data typeclass, fix #13115.
Sep 10 2017, 9:29 AM
Herald added a reviewer for D3938: Make IntPtr and WordPtr as instance of Data.Data typeclass, fix #13115: austin.
Sep 10 2017, 9:24 AM