sighingnow (HE, Tao)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 5 2017, 11:19 PM (75 w, 3 d)

Recent Activity

Today

sighingnow added a comment to rGHCfe770c211631: Built-in Natural literals in Core.

The panic only occurs with ghc-8.4.2, ghc-8.2.2 works fine.

Mon, Jun 18, 4:38 AM
sighingnow raised a concern with rGHCfe770c211631: Built-in Natural literals in Core.

After this commit, the hadrian experiences GHC panic with quickest flavour. More related discussion is here.

Mon, Jun 18, 4:38 AM

Yesterday

sighingnow updated the diff for D4739: Fix "redundant constraint" warnings when meets functional dependencies.
  • Add some comments.
  • Revise comments and fix "Too long lines" lint warnings.
  • Fix compile error.
  • Replace * with Type in T11474.
Sun, Jun 17, 11:36 PM
sighingnow added inline comments to D4739: Fix "redundant constraint" warnings when meets functional dependencies.
Sun, Jun 17, 11:36 PM

Thu, Jun 14

sighingnow added a comment to D4814: Exclude libraries/libiserv/ghc.mk and other things via .gitignore..

@bgamari Could we commit this one or further revise is still needed ?

Thu, Jun 14, 10:17 AM

Wed, Jun 13

sighingnow planned changes to D4820: Inline the default `enumFromTo` and `enumFromThenTo` methods in `Enum` typeclass..

I will look into how INLINE works here and add perf tests for this ticket.

Wed, Jun 13, 5:48 AM
sighingnow accepted D4827: Make Control.Exception.throw levity polymorphic..
Wed, Jun 13, 3:24 AM
sighingnow added a comment to D4827: Make Control.Exception.throw levity polymorphic..

The stats number of these two failed tests are bumped up in 229789ab27851436a522c38ac5. However the base of this phab is a9eb645bb1e6bbaee35, which is earlier than that commit. I think it's ok to let this one merged.

Wed, Jun 13, 3:23 AM

Tue, Jun 12

sighingnow updated the diff for D4830: Disable `-fdefer-out-of-scope-variables` in ghci..
  • Fix typos.
Tue, Jun 12, 11:41 AM
sighingnow updated the diff for D4830: Disable `-fdefer-out-of-scope-variables` in ghci..
  • Add Note [Deferred type errors in GHCi].
Tue, Jun 12, 11:34 AM
sighingnow added a comment to D4836: Add libiserv makefile to .gitignore.

There's already D4814 for this propose :)

Tue, Jun 12, 9:51 AM
sighingnow updated the summary of D4830: Disable `-fdefer-out-of-scope-variables` in ghci..
Tue, Jun 12, 6:46 AM
sighingnow updated the diff for D4830: Disable `-fdefer-out-of-scope-variables` in ghci..
  • This patch also fixes Trac #14963. Add several tests for this ticket.
Tue, Jun 12, 6:45 AM
sighingnow added a comment to D4833: Disable error deferring in interactive statements.

I think it's ok to allow -fdefer-type-errors in files to be load to ghci, which wouldn't cause a panic and is very helpful to develop and try partial finished programs. We only need to disable -fdefer-type-errors (as well as the other two -fdefer) to interactive inputs in ghci.

Tue, Jun 12, 6:29 AM
sighingnow added a comment to D4830: Disable `-fdefer-out-of-scope-variables` in ghci..

This patch should also fix Trac #14963.

Tue, Jun 12, 6:22 AM
sighingnow added a comment to D4833: Disable error deferring in interactive statements.

@tdammers We have already disabled -fdefer-type-errors and -fdefer-typed-holes in GHCi (by Phab:D1527), see https://github.com/ghc/ghc/blob/master/compiler/typecheck/TcRnDriver.hs#L2070. I opened a ticket Trac #15259 yesterday to disable -fdefer-out-of-scope-variables as well, and fixed it by Phab:D4830. After doing that, the program given in Trac #14963 prints the result correctly and doesn't panic.

Tue, Jun 12, 6:21 AM

Mon, Jun 11

sighingnow created D4830: Disable `-fdefer-out-of-scope-variables` in ghci..
Mon, Jun 11, 9:26 AM

Sun, Jun 10

sighingnow added a comment to D4827: Make Control.Exception.throw levity polymorphic..

Please add a note about this change in changelog.md of base library.

Sun, Jun 10, 9:58 AM

Sat, Jun 9

sighingnow created D4820: Inline the default `enumFromTo` and `enumFromThenTo` methods in `Enum` typeclass..
Sat, Jun 9, 2:54 AM

Fri, Jun 8

sighingnow added inline comments to D4819: Add "quantified constraint" context in error message, fix #15231..
Fri, Jun 8, 11:55 PM
sighingnow updated the diff for D4819: Add "quantified constraint" context in error message, fix #15231..
  • Rename head' to head_pred'
  • Fix a bug
  • Accept more changes in expected error messages
Fri, Jun 8, 11:55 PM
sighingnow created D4819: Add "quantified constraint" context in error message, fix #15231..
Fri, Jun 8, 2:39 PM
sighingnow added a comment to D4814: Exclude libraries/libiserv/ghc.mk and other things via .gitignore..

@bgamari I have noticed that we only have excluded these entries in top-level .gitignore for package ghc-boot, ghc-boot-th and ghci. Other packages all have their own .gitignore. Should I continue to move these entries to top-level .gitignore ?

Fri, Jun 8, 8:29 AM
sighingnow created D4815: Replace `showSDocUnsafe` with `showSDoc` in extending_ghc.rst, and fix compile errors..
Fri, Jun 8, 5:24 AM
sighingnow updated the diff for D4739: Fix "redundant constraint" warnings when meets functional dependencies.
  • Fix compile error.
Fri, Jun 8, 4:28 AM
sighingnow updated the diff for D4739: Fix "redundant constraint" warnings when meets functional dependencies.
  • Add some comments.
  • Revise comments and fix "Too long lines" lint warnings.
Fri, Jun 8, 3:46 AM
sighingnow created D4814: Exclude libraries/libiserv/ghc.mk and other things via .gitignore..
Fri, Jun 8, 3:31 AM

Sun, Jun 3

sighingnow updated the summary of D4778: Fix broken test T14547..
Sun, Jun 3, 11:37 AM
sighingnow created D4778: Fix broken test T14547..
Sun, Jun 3, 11:37 AM

Sun, May 27

sighingnow added inline comments to D4739: Fix "redundant constraint" warnings when meets functional dependencies.
Sun, May 27, 9:36 PM
sighingnow updated the diff for D4739: Fix "redundant constraint" warnings when meets functional dependencies.
  • Add some comments.
Sun, May 27, 9:32 PM

Sat, May 26

sighingnow added a comment to D4733: Fix `print-explicit-runtime-reps` (#11786)..

This "stats not good enough" failures of T13701 and T14697 are not caused by this patch. We have already bump the number for OSX in rGHC49691c4f2b7971c5f3b562116811a197554514c0 (This commit is ahead of base of this patch). I thinks it's ok to send this patch to review queue.

Sat, May 26, 9:01 PM
sighingnow retitled D4739: Fix "redundant constraint" warnings when meets functional dependencies from When a class constraint itself or it's superclasses have functional dependencies, don't emit redundant-constraints warnings. Fix Trac #11474. to Fix "redundant constraint" warnings when meets functional dependencies.
Sat, May 26, 9:18 AM
sighingnow created D4739: Fix "redundant constraint" warnings when meets functional dependencies.
Sat, May 26, 9:16 AM
sighingnow updated the diff for D4733: Fix `print-explicit-runtime-reps` (#11786)..
  • Accept all output changes due to the fix for more than one foralls in type.
Sat, May 26, 7:44 AM
sighingnow retitled D4733: Fix `print-explicit-runtime-reps` (#11786). from Implement the idea in Trac #11376#comment:34, and fix #11786. to Fix `print-explicit-runtime-reps` (#11786)..
Sat, May 26, 4:23 AM
sighingnow updated the diff for D4733: Fix `print-explicit-runtime-reps` (#11786)..
  • Remove uncessary changes for :type command.
  • Split nested IfaceSigmaTy correctly.
  • Update some expected tests output.
  • Fix a typo in documentation.
Sat, May 26, 4:23 AM

Fri, May 25

sighingnow planned changes to D4733: Fix `print-explicit-runtime-reps` (#11786)..

This patch break some test cases, marking as "Not ready for review"...

Fri, May 25, 12:54 AM

Thu, May 24

sighingnow updated the diff for D4733: Fix `print-explicit-runtime-reps` (#11786)..
  • Fix pprPrecIfaceType.
Thu, May 24, 10:16 PM
sighingnow added inline comments to D4733: Fix `print-explicit-runtime-reps` (#11786)..
Thu, May 24, 10:15 PM
sighingnow created D4733: Fix `print-explicit-runtime-reps` (#11786)..
Thu, May 24, 10:11 PM

May 17 2018

sighingnow created D4708: Put the `ev_binds` of main function inside `runMainIO` to ensure the deferred type error can be emitted correctly..
May 17 2018, 8:42 AM

May 8 2018

sighingnow added a comment to D4624: Normalize the element type of ListPat, fix #14547.

@bgamari I have noticed that the committed diff is wrong. In https://github.com/ghc/ghc/commit/361d23a8ebb44f5df5167306d7b98d8bd1724e06 , seems that the Diff 16147 is committed however the latest (newest) diff in this Phab is Diff 16315.

May 8 2018, 8:54 AM

May 4 2018

sighingnow updated the diff for D4624: Normalize the element type of ListPat, fix #14547.
  • Fix the compile error.
May 4 2018, 8:17 PM
sighingnow updated the diff for D4571: Improve exhaustiveness checking for literal values and patterns, fix #14546.
  • Rebase to master, adapt to changes in the TTG patch.
May 4 2018, 10:35 AM
sighingnow abandoned D4641: Run runMeta only before collect implicitly quantified type variables, then do renaming..

This patch doesn't solve the problem.

May 4 2018, 10:35 AM
sighingnow updated the diff for D4624: Normalize the element type of ListPat, fix #14547.
  • When RebindableSyntax is enabled, treat the overloaded list pattern as ordinary view pattern.
May 4 2018, 10:16 AM

May 3 2018

sighingnow updated the diff for D4650: Improve numeric stability of numericEnumFrom for floating numbers, fix #15081..
  • Use bang, remove seq, and add a reference to Trac and Phab.
May 3 2018, 10:22 PM
sighingnow added a comment to D4650: Improve numeric stability of numericEnumFrom for floating numbers, fix #15081..

@bgamari @dfeuer Thanks for your attention on this. After looking at the core (with ghc-8.2.2), now I can say:

May 3 2018, 10:08 PM
sighingnow updated the diff for D4650: Improve numeric stability of numericEnumFrom for floating numbers, fix #15081..
  • Add bangs in let, the highest-perf version.
May 3 2018, 11:04 AM
sighingnow added a comment to D4650: Improve numeric stability of numericEnumFrom for floating numbers, fix #15081..

Another thing confuses me is that the [stat too good] of T7954 on CI. I have already update the expected number of bytes allocated.

May 3 2018, 12:49 AM
sighingnow added a comment to D4650: Improve numeric stability of numericEnumFrom for floating numbers, fix #15081..

If additions are substantially faster, then we'd prefer to use them when they don't lose too much precision.

May 3 2018, 12:46 AM

May 2 2018

sighingnow requested review of D4650: Improve numeric stability of numericEnumFrom for floating numbers, fix #15081..
May 2 2018, 9:59 PM

Apr 29 2018

sighingnow requested review of D4641: Run runMeta only before collect implicitly quantified type variables, then do renaming..

Seems that the failure of T12425 [stat not good enough] already exists in master before this diff.

Apr 29 2018, 1:01 PM

Apr 27 2018

sighingnow updated the diff for D4571: Improve exhaustiveness checking for literal values and patterns, fix #14546.
  • More test cases to cover the OverloadedStrings case.
Apr 27 2018, 6:06 AM

Apr 26 2018

sighingnow updated the diff for D4571: Improve exhaustiveness checking for literal values and patterns, fix #14546.
  • Revise the note. No changes in real code, the CI should be green.
Apr 26 2018, 9:35 PM

Apr 25 2018

sighingnow requested review of D4624: Normalize the element type of ListPat, fix #14547.
Apr 25 2018, 6:07 AM

Apr 21 2018

sighingnow updated the diff for D4571: Improve exhaustiveness checking for literal values and patterns, fix #14546.
  • Fix the Line Too Long lint warnings.
Apr 21 2018, 4:37 AM
sighingnow added a comment to D4571: Improve exhaustiveness checking for literal values and patterns, fix #14546.

@bgamari Sorry for the lack of description. I have updated the summary and rebased this patch to master.

Apr 21 2018, 4:37 AM
sighingnow updated the diff for D4571: Improve exhaustiveness checking for literal values and patterns, fix #14546.
  • Rebase to upstream/master and adapt changes from master.
Apr 21 2018, 4:21 AM
sighingnow retitled D4571: Improve exhaustiveness checking for literal values and patterns, fix #14546 from Improve exhaustiveness checking for literal values and patterns. to Improve exhaustiveness checking for literal values and patterns, fix #14546.
Apr 21 2018, 4:16 AM

Apr 18 2018

sighingnow requested review of D4594: Better error message for empty character literal, for Trac #13450..
Apr 18 2018, 10:37 AM

Apr 8 2018

sighingnow requested review of D4571: Improve exhaustiveness checking for literal values and patterns, fix #14546.
Apr 8 2018, 7:48 AM

Apr 5 2018

sighingnow abandoned D4536: In Phab:D4529, this typo cause the failure of ghc-head, this patch fixes it..

Close as the issue has already been fixed in HEAD.

Apr 5 2018, 8:59 AM

Mar 6 2018

sighingnow updated the diff for D4469: Fix scoped type variables in TH for class methods, default signatures and pattern synonyms..
  • Improve comments.
Mar 6 2018, 7:21 PM
sighingnow added a comment to D4469: Fix scoped type variables in TH for class methods, default signatures and pattern synonyms..

@RyanGlScott Thanks for your advice !

Mar 6 2018, 7:20 PM
sighingnow updated the diff for D4469: Fix scoped type variables in TH for class methods, default signatures and pattern synonyms..
  • Fix the stdout of T7064. The order of declarations should be consistent in the TH declaration and TH splice.
Mar 6 2018, 8:58 AM

Mar 5 2018

sighingnow added inline comments to D4469: Fix scoped type variables in TH for class methods, default signatures and pattern synonyms..
Mar 5 2018, 9:19 PM
sighingnow updated the diff for D4469: Fix scoped type variables in TH for class methods, default signatures and pattern synonyms..
  • Add rep_sigs_binds and fix the unexpected failed testcases.
Mar 5 2018, 9:09 PM
sighingnow updated the diff for D4461: Improve the warning message of qualified unused imports..
  • Add comment and point to the target ticket.
Mar 5 2018, 9:36 AM
sighingnow added reviewers for D4469: Fix scoped type variables in TH for class methods, default signatures and pattern synonyms.: simonpj, RyanGlScott.
Mar 5 2018, 9:33 AM
sighingnow updated the diff for D4469: Fix scoped type variables in TH for class methods, default signatures and pattern synonyms..
  • Add release note.
Mar 5 2018, 9:33 AM
sighingnow created D4469: Fix scoped type variables in TH for class methods, default signatures and pattern synonyms..
Mar 5 2018, 9:33 AM

Mar 3 2018

sighingnow created D4461: Improve the warning message of qualified unused imports..
Mar 3 2018, 6:44 AM

Feb 26 2018

sighingnow added a comment to D4400: Improve exhaustive checking for guards in pattern bindings and MultiIf..

My apologies for slow responses, the release note has been updated now.

Feb 26 2018, 1:56 AM
sighingnow updated the diff for D4400: Improve exhaustive checking for guards in pattern bindings and MultiIf..

Add release note about exhaustive checking for guards.

Feb 26 2018, 1:39 AM

Feb 9 2018

sighingnow updated the diff for D4400: Improve exhaustive checking for guards in pattern bindings and MultiIf..
  • Fix the misunderstanding for m_pats and add a PatBindGuards context.
Feb 9 2018, 10:37 AM

Feb 8 2018

sighingnow updated the summary of D4400: Improve exhaustive checking for guards in pattern bindings and MultiIf..
Feb 8 2018, 11:35 PM
sighingnow created D4400: Improve exhaustive checking for guards in pattern bindings and MultiIf..
Feb 8 2018, 11:34 PM

Feb 7 2018

sighingnow updated the diff for D4397: Improve error message for UNPACK/strictness annotations..

Unstage again...

Feb 7 2018, 11:29 AM
sighingnow updated the diff for D4397: Improve error message for UNPACK/strictness annotations..

Unstage hadrian changes again.

Feb 7 2018, 11:26 AM
sighingnow updated the diff for D4397: Improve error message for UNPACK/strictness annotations..

Unstage hadrian changes.

Feb 7 2018, 11:21 AM
sighingnow created D4397: Improve error message for UNPACK/strictness annotations..
Feb 7 2018, 11:19 AM

Feb 6 2018

sighingnow updated the diff for D4384: Improve X86CodeGen's pprASCII..
  • Add Note [Pretty print ASCII when AsmCodeGen].
Feb 6 2018, 6:25 AM
mpickering awarded D4384: Improve X86CodeGen's pprASCII. a Like token.
Feb 6 2018, 5:28 AM
sighingnow added a reviewer for D4384: Improve X86CodeGen's pprASCII.: mpickering.
Feb 6 2018, 12:47 AM
sighingnow created D4384: Improve X86CodeGen's pprASCII..
Feb 6 2018, 12:31 AM

Feb 1 2018

sighingnow added a comment to D4350: Raise parse error for `data T where`..

Thanks @adamse, fixed.

Feb 1 2018, 8:11 PM
sighingnow updated the diff for D4350: Raise parse error for `data T where`..

Just check -XGADTSyntax since -XGADTs implies -XGADTSyntax.

Feb 1 2018, 8:10 PM

Jan 31 2018

sighingnow created D4361: Flag `-fdefer-typed-holes` also implies `-fdefer-out-of-scope-variables`..
Jan 31 2018, 11:21 PM
sighingnow updated the diff for D4359: UnboxedTuples can't be used as constraints. Fix #14740..

Add comment for function checkContext.

Jan 31 2018, 8:02 PM
sighingnow created D4359: UnboxedTuples can't be used as constraints. Fix #14740..
Jan 31 2018, 3:45 AM

Jan 29 2018

sighingnow updated the diff for D4350: Raise parse error for `data T where`..

Fix syntax in docs.

Jan 29 2018, 10:06 AM
sighingnow updated the diff for D4350: Raise parse error for `data T where`..

Document the breaking change.

Jan 29 2018, 9:25 AM
sighingnow updated the diff for D4350: Raise parse error for `data T where`..

Move the check logic to RdrHsSyn as checkEmptyGADTs.

Jan 29 2018, 7:18 AM
sighingnow created D4350: Raise parse error for `data T where`..
Jan 29 2018, 5:43 AM

Jan 12 2018

sighingnow updated the summary of D4305: Fix hash in haddock of ghc-prim..
Jan 12 2018, 6:23 AM
sighingnow created D4305: Fix hash in haddock of ghc-prim..
Jan 12 2018, 6:22 AM

Sep 17 2017

sighingnow added a reviewer for D3986: Make zipWith and zipWith3 inlinable.: dfeuer.
Sep 17 2017, 8:51 PM
Herald added a reviewer for D3986: Make zipWith and zipWith3 inlinable.: austin.
Sep 17 2017, 8:50 PM