shayne-fletcher-da (Shayne Fletcher)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 24 2018, 10:53 AM (12 w, 1 d)

Recent Activity

Nov 7 2018

shayne-fletcher-da added a comment to D5251: enable rebindable fail with overloaded strings.

As far as I know, this is good to go (@bgamari - perhaps this can go back into the merge queue now?). Please let me know if there's any way I can be of further help!

Nov 7 2018, 8:42 AM

Nov 1 2018

shayne-fletcher-da updated the diff for D5251: enable rebindable fail with overloaded strings.
  • fix-trac-15645 : update user guide
Nov 1 2018, 12:27 PM

Oct 29 2018

shayne-fletcher-da updated the diff for D5251: enable rebindable fail with overloaded strings.
  • fix-trac-15645 : remove redundant parens
Oct 29 2018, 12:29 PM
shayne-fletcher-da added a comment to D5251: enable rebindable fail with overloaded strings.

@simonpj Regarding your note "Better: just use SynAny for both cases. I think that'll be fine.", it turns out that I was just being silly. It's not wrong to pass stringTy in all cases there so that change is reverted and the original, unmodified code remains. However, do please note that if SynAny is passed instead, it gives rise to a Core Lint error on tests/rebindable/rebindable1.hs

*** Core Lint errors : in result of Desugar (before optimization) ***
<no location info>: warning:
    In the expression: fail
                         @ (Any -> Any)
                         (unpackCString#
                            "Pattern match failure in do expression at testsuite/tests/rebindable/rebindable1.hs:39:17-22"#)
    Argument value doesn't match argument type:
    Fun type: Any -> Any
    Arg type: [Char]
    Arg:
        unpackCString#
          "Pattern match failure in do expression at testsuite/tests/rebindable/rebindable1.hs:39:17-22"#

I mention this just in case its hinting at a latent problem!

Oct 29 2018, 12:09 PM
shayne-fletcher-da added a comment to D5251: enable rebindable fail with overloaded strings.

@bgamari Diff 18525 submitted fixing the regression so we should be unblocked now!

Oct 29 2018, 12:03 PM
shayne-fletcher-da updated the diff for D5251: enable rebindable fail with overloaded strings.
  • fix-trac-15645 : argument shape for fail op is always stringTy
Oct 29 2018, 11:58 AM

Oct 28 2018

shayne-fletcher-da added a comment to D5251: enable rebindable fail with overloaded strings.

It seems this patch has given rise to a test failure in tests/rebindable/rebindable1.hs. I will investigate.

Oct 28 2018, 5:54 AM

Oct 27 2018

shayne-fletcher-da updated the diff for D5251: enable rebindable fail with overloaded strings.
  • fix-trac-15645 : enable rebindable fail with overloaded strings
Oct 27 2018, 11:49 AM

Oct 25 2018

shayne-fletcher-da added inline comments to D5251: enable rebindable fail with overloaded strings.
Oct 25 2018, 3:24 PM

Oct 22 2018

shayne-fletcher-da created D5251: enable rebindable fail with overloaded strings.
Oct 22 2018, 9:38 AM