shayan-najd (Shayan Najd)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Nov 19 2014, 1:59 PM (169 w, 4 d)
Availability
Available

Recent Activity

Nov 15 2017

shayan-najd added a comment to D4199: Remove HasSourceText and SourceTextX classes.

Similar to my question on the previous TTG patch: why NoSourceText and not noExt? (If this patch is not the place to fix these, I understand)

Nov 15 2017, 3:52 AM

Nov 14 2017

shayan-najd accepted D4186: TTG3 Combined Step 1 and 3 for Trees That Grow.

As expected.

Nov 14 2017, 3:36 PM
shayan-najd added a comment to D4186: TTG3 Combined Step 1 and 3 for Trees That Grow.

I have taken a quick look and added some quick comments.

Nov 14 2017, 11:50 AM

Nov 6 2017

shayan-najd added a comment to D4147: WIP on Doing a combined Step 1 and 3 for Trees That Grow.

Could you update https://ghc.haskell.org/trac/ghc/wiki/ImplementingTreesThatGrow to reflect the current plan? It's out of date.

Nov 6 2017, 1:34 PM
shayan-najd added a comment to D4147: WIP on Doing a combined Step 1 and 3 for Trees That Grow.

I don't like the "NewT" nomenclature for the "extra" data constructor for data type T. Could it be XT?

Nov 6 2017, 11:30 AM

Nov 4 2017

shayan-najd accepted D4147: WIP on Doing a combined Step 1 and 3 for Trees That Grow.

I have taken a look. It all seems as expected and rather mechanical. There are some bits sticking out, those that Simon and Ben commented on, that I believe are some side-effects of splitting the big patch into multiple steps: the treatment of binders sticks out that can be treated in the next step and there are some bits that can be done when we update HsExpr as well.

Nov 4 2017, 11:45 AM

Sep 11 2017

shayan-najd commandeered D3935: [wip] Growable AST.
Sep 11 2017, 8:11 AM

Jun 1 2017

shayan-najd accepted D3609: Update hsSyn AST to use Trees that Grow.

I am not sure if I really qualify as a reviewer for this.
This is a minor, yet enabling step in practice.
All is as planned and described in the wiki, and if other reviewers are fine with it, there should be no problem in landing it as soon as possible.

Jun 1 2017, 5:54 PM