- User Since
- Nov 19 2014, 1:59 PM (186 w, 4 d)
Apr 25 2018
All is as expected (systematic). Finally, we got rid of the old PostRN / PostTC solution using TTG.
If the performance measures are also as expected, I suggest landing this patch.
Apr 12 2018
I looked through the changes, and all seems as expected.
General question: about the choice of what to consider as an extension (both new fields and new constructors) does it follow wip/GrowableAST?
Nov 15 2017
Similar to my question on the previous TTG patch: why NoSourceText and not noExt? (If this patch is not the place to fix these, I understand)
Nov 14 2017
I have taken a quick look and added some quick comments.
Nov 6 2017
Could you update https://ghc.haskell.org/trac/ghc/wiki/ImplementingTreesThatGrow to reflect the current plan? It's out of date.
I don't like the "NewT" nomenclature for the "extra" data constructor for data type T. Could it be XT?
Nov 4 2017
I have taken a look. It all seems as expected and rather mechanical. There are some bits sticking out, those that Simon and Ben commented on, that I believe are some side-effects of splitting the big patch into multiple steps: the treatment of binders sticks out that can be treated in the next step and there are some bits that can be done when we update HsExpr as well.
Sep 11 2017
Jun 1 2017
I am not sure if I really qualify as a reviewer for this.
This is a minor, yet enabling step in practice.
All is as planned and described in the wiki, and if other reviewers are fine with it, there should be no problem in landing it as soon as possible.