ruperthorlick (Rupert Horlick)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 2 2017, 10:18 AM (137 w, 3 d)

Recent Activity

Mar 8 2017

ruperthorlick added a comment to D3299: Fixed QuasiQuotation test and output.

I agree that these are all a little strange. @bgamari asked me to get them compiling at least, but now I guess we want to figure out what they're actually good for. They were left over broken tests after I validated https://phabricator.haskell.org/D3271.

Mar 8 2017, 3:37 PM
ruperthorlick created D3299: Fixed QuasiQuotation test and output.
Mar 8 2017, 10:51 AM
ruperthorlick updated the diff for D3271: Fixed error messages for RecursiveDo (#8501).
  • Removed partiality in error checking (Trac #8501)
  • Ran validation and updated test outputs
Mar 8 2017, 10:49 AM

Mar 7 2017

ruperthorlick added a comment to D3271: Fixed error messages for RecursiveDo (#8501).

I've removed the partiality and run the validation.

Mar 7 2017, 5:41 AM

Mar 6 2017

ruperthorlick added a comment to D3281: Changed OverLit warnings to work with negative literals (#13257).
In D3281#95038, @dfeuer wrote:

While you're in the area: do we have logic to warm about negative Natural and Word literals?

Mar 6 2017, 1:14 PM
ruperthorlick created D3286: Disallow unboxed string literals in patterns (#13260).
Mar 6 2017, 9:08 AM

Mar 5 2017

ruperthorlick created D3281: Changed OverLit warnings to work with negative literals (#13257).
Mar 5 2017, 12:01 PM
ruperthorlick added a comment to D3271: Fixed error messages for RecursiveDo (#8501).

Okay so I've added a function like the one @bgamari suggested and tested it. Looks pretty good.

Mar 5 2017, 7:52 AM
ruperthorlick updated the diff for D3271: Fixed error messages for RecursiveDo (#8501).
Mar 5 2017, 7:49 AM
ruperthorlick updated the diff for D3271: Fixed error messages for RecursiveDo (#8501).
  • Refactored examining of StringBuffers (Trac #8501)
Mar 5 2017, 7:48 AM

Mar 4 2017

ruperthorlick added a comment to D3271: Fixed error messages for RecursiveDo (#8501).

I like the idea, but I'm a bit concerned about the implementation. I haven't thought about what a potential refactoring would look like, but I'm happy to advise if you'd like.

Mar 4 2017, 3:51 AM

Mar 3 2017

ruperthorlick retitled D3271: Fixed error messages for RecursiveDo (#8501) from Fixed error messages for ex. 1 and 3 (#8501) to Fixed error messages for RecursiveDo (#8501).
Mar 3 2017, 12:54 PM
ruperthorlick created D3271: Fixed error messages for RecursiveDo (#8501).
Mar 3 2017, 12:44 PM
ruperthorlick added a comment to D3267: Fix stderr files for tests T12429 and T12811.

You're welcome, it was my pleasure!

Mar 3 2017, 7:11 AM

Mar 2 2017

ruperthorlick added a comment to D3262: Changed parser message for RankNTypes (#12811).

Phew, sorry about that! This is my first patch with multiple commits.

Mar 2 2017, 12:50 PM
ruperthorlick updated the diff for D3262: Changed parser message for RankNTypes (#12811).

Trying again

Mar 2 2017, 12:49 PM
ruperthorlick updated the diff for D3262: Changed parser message for RankNTypes (#12811).

Attempting to fix up diff again

Mar 2 2017, 12:47 PM
ruperthorlick added a comment to D3262: Changed parser message for RankNTypes (#12811).

Fixed both of those (and had some trouble in the middle, but sorted it out!)

Mar 2 2017, 11:54 AM
ruperthorlick updated the diff for D3262: Changed parser message for RankNTypes (#12811).

Fixed accidentally merged diffs

Mar 2 2017, 11:52 AM
ruperthorlick updated the diff for D3262: Changed parser message for RankNTypes (#12811).

Attempting to fix accidentally merged diffs (2)

Mar 2 2017, 11:52 AM
ruperthorlick updated the diff for D3262: Changed parser message for RankNTypes (#12811).

Attempting to fix accidentally mearged diffs

Mar 2 2017, 11:51 AM
ruperthorlick updated the diff for D3262: Changed parser message for RankNTypes (#12811).
Mar 2 2017, 11:45 AM
ruperthorlick updated the diff for D3262: Changed parser message for RankNTypes (#12811).
Mar 2 2017, 11:42 AM
ruperthorlick created D3262: Changed parser message for RankNTypes (#12811).
Mar 2 2017, 11:33 AM
ruperthorlick created D3261: Add suggestion for PatternSynonyms parse error (fixes #12429).
Mar 2 2017, 10:37 AM