rockbmb (Alexandre R. Baldé)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 18 2018, 3:02 PM (43 w, 2 d)

Recent Activity

Jun 9 2019

Marge Bot <ben+marge-bot@smart-cactus.org> committed rGHC0462b0e02d87: Explain that 'mappend' and '(<>)' should be the same [skip ci] (authored by rockbmb).
Explain that 'mappend' and '(<>)' should be the same [skip ci]
Jun 9 2019, 10:49 AM

Apr 23 2019

Marge Bot <ben+marge-bot@smart-cactus.org> committed rGHCab9b3ace24e5: Fix error message for './configure' regarding '--with-ghc' [skip ci] (authored by rockbmb).
Fix error message for './configure' regarding '--with-ghc' [skip ci]
Apr 23 2019, 8:39 AM

Apr 2 2019

Marge Bot <ben+marge-bot@smart-cactus.org> committed rGHC345306d3fa5e: Fix formatting issue in ghc-prim's changelog [skip ci] (authored by rockbmb).
Fix formatting issue in ghc-prim's changelog [skip ci]
Apr 2 2019, 3:54 PM
Marge Bot <ben+marge-bot@smart-cactus.org> committed rGHC33173a51c77d: Add support for bitreverse primop (authored by rockbmb).
Add support for bitreverse primop
Apr 2 2019, 3:54 PM
Marge Bot <ben+marge-bot@smart-cactus.org> committed rGHCa3971b4e8cb2: Bump ghc-prim's version where needed (authored by rockbmb).
Bump ghc-prim's version where needed
Apr 2 2019, 3:54 PM

Mar 4 2019

Marge Bot <ben+marge-bot@smart-cactus.org> committed rGHC9059343e8d1f: base: Allow fusion for zip7 and related (authored by rockbmb).
base: Allow fusion for zip7 and related
Mar 4 2019, 3:09 PM
Marge Bot <ben+marge-bot@smart-cactus.org> committed rGHC129a800dd01b: Fix Haddock comment for Integer datatype (authored by rockbmb).
Fix Haddock comment for Integer datatype
Mar 4 2019, 1:07 PM

Feb 24 2019

rockbmb abandoned D5249: [#14037] Allow fusion for zip7 and related.

This can be closed now that the GitLab MR has been merged.
Thank you to all who lent their time to guide me.

Feb 24 2019, 4:01 PM

Feb 20 2019

rockbmb added a comment to D5249: [#14037] Allow fusion for zip7 and related.

I've just sent you an email.

Feb 20 2019, 6:43 PM
rockbmb added a comment to D5249: [#14037] Allow fusion for zip7 and related.

@simonpj I've sent the email. Unfortunately, Microsoft has suspended my Outlook email account because it classified my email as "suspicious activity", but I sent it with another address. Can you confirm reception?

Feb 20 2019, 10:48 AM
rockbmb added a comment to D5249: [#14037] Allow fusion for zip7 and related.

@simonpj I do not have write access to this repository, and I believe it is needed in order to merge this. Would you mind doing so for me?

Feb 20 2019, 9:37 AM
rockbmb added a comment to D5249: [#14037] Allow fusion for zip7 and related.

@simonpj should be even more acceptable now :)

Feb 20 2019, 9:28 AM
rockbmb updated the diff for D5249: [#14037] Allow fusion for zip7 and related.
  • Fix comments after latest review [skip ci]
Feb 20 2019, 9:18 AM
rockbmb updated the diff for D5249: [#14037] Allow fusion for zip7 and related.
  • Fix comments after latest review [skip ci]
Feb 20 2019, 9:16 AM
rockbmb updated the diff for D5249: [#14037] Allow fusion for zip7 and related.
  • Fix comments after latest review [skip ci]
Feb 20 2019, 9:15 AM
rockbmb updated the diff for D5249: [#14037] Allow fusion for zip7 and related.
  • Fix comments after latest review [skip ci]
Feb 20 2019, 9:11 AM

Feb 19 2019

rockbmb updated the diff for D5249: [#14037] Allow fusion for zip7 and related.
  • Fix comment regarding 'mapAndUnzipM' inlining
  • Fix comment regarding zipWithNM functions [skip ci]
Feb 19 2019, 9:23 PM
rockbmb added a comment to D5249: [#14037] Allow fusion for zip7 and related.

@simonpj This diff should be more acceptable now.

Feb 19 2019, 9:22 PM
rockbmb updated the diff for D5249: [#14037] Allow fusion for zip7 and related.
  • Fix comment regarding 'unzip' inlining
  • Fix comment regarding 'mapAndUnzipM' inlining
  • Fix comment regarding zipWithNM functions [skip ci]
Feb 19 2019, 9:20 PM

Feb 18 2019

rockbmb added a comment to D5249: [#14037] Allow fusion for zip7 and related.

@simonpj you're right - I forgot to raise that point in this discussion so that someone could add those comments. I didn't do it myself since I'm not that familiar with the codebase yet.
Thank you that MR. As soon as it's merged and lands on this instance's master, I'll fix this Diff and push the changes.

Feb 18 2019, 8:32 AM
rockbmb added a comment to D5249: [#14037] Allow fusion for zip7 and related.

@simonpj sorry, but what do you specifically mean by this:

I don't having like comments like this

?

Feb 18 2019, 7:57 AM

Feb 16 2019

rockbmb added a comment to D5249: [#14037] Allow fusion for zip7 and related.

I apologise for my insistence on this issue as well (I ask for some tolerance based on point 7.) - can someone review this?

Feb 16 2019, 7:34 PM

Feb 15 2019

rockbmb edited reviewers for D5249: [#14037] Allow fusion for zip7 and related, added: simonpj; removed: hvr, dfeuer.
Feb 15 2019, 4:02 PM

Feb 9 2019

rockbmb added inline comments to D5249: [#14037] Allow fusion for zip7 and related.
Feb 9 2019, 4:27 PM
rockbmb added inline comments to D5249: [#14037] Allow fusion for zip7 and related.
Feb 9 2019, 4:22 PM

Feb 8 2019

rockbmb updated the diff for D5249: [#14037] Allow fusion for zip7 and related.
  • Fix reference in commit to differential with unzip fusion rules
Feb 8 2019, 5:39 PM

Feb 5 2019

rockbmb added a comment to D5249: [#14037] Allow fusion for zip7 and related.

It seems CI has been disabled for Phabricator as part of the move to GitLab.
In any case, I forked GHC there, performed these changes on my fork and pushed them here. Every required build passes.

Feb 5 2019, 7:53 PM
rockbmb added a comment to D5249: [#14037] Allow fusion for zip7 and related.

This differential has been updated to reflect the changes from D5241 (some of the previous changes here have already been implemented by that diff), along with some comments explaining the changes.

Feb 5 2019, 7:49 PM
rockbmb updated the diff for D5249: [#14037] Allow fusion for zip7 and related.
  • Allow fusion for unzip4
  • Allow fusion for unzip5
  • Allow fusion for unzip6
  • Allow fusion for unzip7
  • Add comment explaining INLINE for unzips
  • Add inline rule to mapAndUnzip3M
  • Add inline rule to mapAndUnzip4M
  • Add inline rule to mapAndUnzip5M
  • Add explanation to mapAndUnzipM changes
  • Add inline for zipWith3M
  • Add inline for zipWith3M_
  • Add inline for zipWith4M
  • Add comment explaining zipWithM inline
Feb 5 2019, 7:46 PM

Dec 18 2018

rockbmb added a comment to D5249: [#14037] Allow fusion for zip7 and related.

@bgamari Is it alright if I close this, and reopen it in GHC's Gitlab instance? Or would you rather have me complete this issue here?

Dec 18 2018, 2:21 PM

Dec 3 2018

rockbmb added inline comments to D5241: Add fusion rules for the zipWith functions in base (#15263).
Dec 3 2018, 11:26 AM

Nov 15 2018

rockbmb added inline comments to D5241: Add fusion rules for the zipWith functions in base (#15263).
Nov 15 2018, 4:22 PM

Nov 5 2018

rockbmb added a comment to D5241: Add fusion rules for the zipWith functions in base (#15263).

When this is done, I'll update D5249 to reflect these changes.

Nov 5 2018, 10:28 AM

Oct 28 2018

rockbmb added a comment to D5241: Add fusion rules for the zipWith functions in base (#15263).

I was unaware of this ticket. I do not mind removing these changes from D5249 so the two differentials do not collide. You've also added comments and a performance test, whereas I did neither.

Oct 28 2018, 2:50 PM

Oct 22 2018

rockbmb added a comment to D5249: [#14037] Allow fusion for zip7 and related.

Hm, it seems I spoke too soon. I am not sure of the reason, but it seems that the tests that output stat too good do so in the latest master branch as well, and with identical results. Can anyone confirm this? I had expected that all performance tests in the latest master would pass without being too bad or too good, at least when ran with make test, but it seems I was wrong, both on that and about these changes being strictly positive. I cannot claim they are when the same improvement appears without them.
I'll continue trying things out.

Oct 22 2018, 1:14 PM
rockbmb added a comment to D5249: [#14037] Allow fusion for zip7 and related.

There are a number of changes in this patch, but none of them are commented in any way. So maybe someone will change them all back in a while! It would really help to document the intent, rather than just change the code.

Sometimes a single Note, which can be pointed to from several places, is the easiest way to explain how all the moving parts fit together.
W
I've made a few notes to that effects in the individual places.

Oct 22 2018, 7:53 AM

Oct 21 2018

rockbmb updated the Trac tickets for D5249: [#14037] Allow fusion for zip7 and related.
Oct 21 2018, 4:27 PM
rockbmb added a comment to D5249: [#14037] Allow fusion for zip7 and related.

For T9203:

Expected    T9203(normal) bytes allocated:  98360576 +/-5%
Lower bound T9203(normal) bytes allocated:  93442547 
Upper bound T9203(normal) bytes allocated: 103278605 
Actual      T9203(normal) bytes allocated:  46371896 
Deviation   T9203(normal) bytes allocated:     -52.9 %
Oct 21 2018, 4:26 PM
rockbmb added a comment to D5249: [#14037] Allow fusion for zip7 and related.

Good news, it seems the current set of changes, when make fasttest -j8 is run, produce (on my machine, of course):

Oct 21 2018, 4:15 PM

Oct 20 2018

rockbmb created D5249: [#14037] Allow fusion for zip7 and related.
Oct 20 2018, 6:32 PM
rockbmb abandoned D5240: [#14037] Allow fusion for zipWith (and related) utilities.
Oct 20 2018, 5:34 PM
rockbmb updated the diff for D5240: [#14037] Allow fusion for zipWith (and related) utilities.
Oct 20 2018, 5:34 PM
rockbmb updated the diff for D5240: [#14037] Allow fusion for zipWith (and related) utilities.

Retry removing unwanted changes from differential

Oct 20 2018, 5:06 PM
rockbmb updated the diff for D5240: [#14037] Allow fusion for zipWith (and related) utilities.

Update differential to attempt to remove unwanted changes

Oct 20 2018, 4:57 PM
rockbmb updated the diff for D5240: [#14037] Allow fusion for zipWith (and related) utilities.

Update revision

Oct 20 2018, 4:32 PM

Oct 18 2018

rockbmb added a comment to D5240: [#14037] Allow fusion for zipWith (and related) utilities.

I think I understand what happened here: revision D3758 is relevant to this revision as it provides a tool to test performance regressions between commits, so I ran arc patch D123 to be able to use it while working on D5240.

Oct 18 2018, 5:29 PM
rockbmb updated the diff for D5240: [#14037] Allow fusion for zipWith (and related) utilities.

Unapply patch from D3758

Oct 18 2018, 5:26 PM
rockbmb updated the diff for D5240: [#14037] Allow fusion for zipWith (and related) utilities.

Remove extraneous changes from diff

Oct 18 2018, 5:14 PM
rockbmb updated the diff for D5240: [#14037] Allow fusion for zipWith (and related) utilities.
Oct 18 2018, 5:11 PM
rockbmb added a comment to D5240: [#14037] Allow fusion for zipWith (and related) utilities.

It seems I did something incorrectly, I mistakenly added work to this differential that does not belong here. I will attempt to resolve this at once.

Oct 18 2018, 4:50 PM
rockbmb updated the diff for D5240: [#14037] Allow fusion for zipWith (and related) utilities.

Add missing NOINLINE zip4 pragma

Oct 18 2018, 4:47 PM
rockbmb retitled D5240: [#14037] Allow fusion for zipWith (and related) utilities from [#14037] Allow fusion for zipWith3 [#14037] Allow fusion for zipWith4 to [#14037] Allow fusion for zipWith (and related) utilities.
Oct 18 2018, 3:45 PM
rockbmb created D5240: [#14037] Allow fusion for zipWith (and related) utilities.
Oct 18 2018, 3:42 PM