quchen (David Luposchainsky)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 1 2015, 1:27 PM (233 w, 3 h)

Recent Activity

Oct 23 2018

quchen committed rGHC462f78f8a676: Report success on IRC only if the build was fixed (authored by quchen).
Report success on IRC only if the build was fixed
Oct 23 2018, 3:25 PM
quchen committed rGHCc43d07d967b7: Shallow clone GHC from Github instead of Haskell.org (authored by quchen).
Shallow clone GHC from Github instead of Haskell.org
Oct 23 2018, 3:21 PM
quchen committed rGHC988dabb35a23: Fix unnecessary import hiding (authored by quchen).
Fix unnecessary import hiding
Oct 23 2018, 3:19 PM
quchen committed rGHC2ba641b3d7d4: Make imports fully qualified (authored by quchen).
Make imports fully qualified
Oct 23 2018, 3:17 PM
quchen committed rGHC6cf79029f6b1: Add missing Haddock header (authored by quchen).
Add missing Haddock header
Oct 23 2018, 3:17 PM
quchen committed rGHC5a8257902248: Add Haddocks to Base.hs (authored by quchen).
Add Haddocks to Base.hs
Oct 23 2018, 3:17 PM
quchen committed rGHC9dd9ae02b8ba: Add Haddocks to GHC.hs (authored by quchen).
Add Haddocks to GHC.hs
Oct 23 2018, 3:17 PM
quchen committed rGHC302c1dfb0728: Fix bad imports (authored by quchen).
Fix bad imports
Oct 23 2018, 3:17 PM
quchen committed rGHC5f4a8f617074: Add cabal configure to CI (authored by quchen).
Add cabal configure to CI
Oct 23 2018, 3:17 PM
quchen committed rGHCffc151c00416: Fix type error (authored by quchen).
Fix type error
Oct 23 2018, 3:17 PM
quchen committed rGHC997ce259b41f: Haddocks for Way.hs (authored by quchen).
Haddocks for Way.hs
Oct 23 2018, 3:17 PM
quchen committed rGHCbee9ceed2f9e: Explain stages (authored by quchen).
Explain stages
Oct 23 2018, 3:17 PM
quchen committed rGHC1b013b0886e5: Add Haddocks to Target.hs (authored by quchen).
Add Haddocks to Target.hs
Oct 23 2018, 3:17 PM
quchen committed rGHCdb5e646e6fed: Add Haddock build to CI (authored by quchen).
Add Haddock build to CI
Oct 23 2018, 3:17 PM
quchen committed rGHC20381e58208c: Split up definitions in Rules.hs (authored by quchen).
Split up definitions in Rules.hs
Oct 23 2018, 3:17 PM
quchen committed rGHC921dcce1ab2e: Make value sources more explicit (authored by quchen).
Make value sources more explicit
Oct 23 2018, 3:16 PM
quchen committed rGHCde634dadaf36: Add Haddock comments in Predicates.hs (authored by quchen).
Add Haddock comments in Predicates.hs
Oct 23 2018, 3:16 PM
quchen committed rGHC9784dfb75fdb: Cache $HOME/.ghc as well (authored by quchen).
Cache $HOME/.ghc as well
Oct 23 2018, 3:12 PM
quchen committed rGHC2e4f060ee78c: Add IRC notifications (authored by quchen).
Add IRC notifications
Oct 23 2018, 3:12 PM
quchen committed rGHCd0ffc1f8d7e1: Rework Travis CI script (authored by quchen).
Rework Travis CI script
Oct 23 2018, 3:07 PM
quchen committed rGHC64da99895a24: Add Travis support (authored by quchen).
Add Travis support
Oct 23 2018, 3:05 PM
quchen committed rGHC8235f157b7dc: Make output boxes prettier by closing them on the right (authored by quchen).
Make output boxes prettier by closing them on the right
Oct 23 2018, 3:04 PM
quchen committed rGHC5da933f76892: Add Cabal support for sandboxed build system building (authored by quchen).
Add Cabal support for sandboxed build system building
Oct 23 2018, 2:49 PM
quchen committed rGHCbfd3d3240107: Parallelize+optimize compilation of build system (-j -O) (authored by quchen).
Parallelize+optimize compilation of build system (-j -O)
Oct 23 2018, 2:47 PM
quchen committed rGHC0e196114ceb6: Show simple shake progress and timings (authored by quchen).
Show simple shake progress and timings
Oct 23 2018, 2:47 PM
quchen committed rGHC828bc3a27a26: Avoid common shell scripting pitfalls (authored by quchen).
Avoid common shell scripting pitfalls
Oct 23 2018, 2:47 PM

Apr 14 2016

quchen updated the diff for D2076: Add flag to control number of missing patterns in warnings.
  • Change -fwarn to -W in doc
Apr 14 2016, 4:47 PM

Apr 1 2016

quchen added inline comments to D2076: Add flag to control number of missing patterns in warnings.
Apr 1 2016, 5:54 PM
quchen retitled D2076: Add flag to control number of missing patterns in warnings from to Add flag to control number of missing patterns in warnings.
Apr 1 2016, 5:49 PM

Feb 27 2016

quchen accepted D1954: Print which flag controls emitted desugaring warnings.

I think we should say "via -W..." instead of "in -W..." though, which I find clearer than "in". The latter doesn't really tell *me* that the group is which was responsible for the warning.

Feb 27 2016, 9:07 AM

Feb 24 2016

quchen accepted D1943: Print which warning-flag controls an emitted warning..

Looks good to me!

Feb 24 2016, 2:01 PM

Feb 23 2016

quchen requested changes to D1943: Print which warning-flag controls an emitted warning..

The addWarn' functions are because initially I didn't realise that there were warnings without an associated flag, so I changed the types of the original functions. Personally, I think all warnings should have a flag (otherwise you can't turn them off!), but that's a separate issue.

Feb 23 2016, 10:09 AM

Dec 17 2015

rwbarton awarded D1647: Conditionally show plural "s" in warnings a Like token.
Dec 17 2015, 4:42 AM
quchen updated D1647: Conditionally show plural "s" in warnings.
Dec 17 2015, 4:11 AM
quchen updated the diff for D1647: Conditionally show plural "s" in warnings.

Fix existing tests

Dec 17 2015, 3:56 AM
quchen updated the diff for D1647: Conditionally show plural "s" in warnings.

Capitalize test

Dec 17 2015, 1:44 AM
quchen retitled D1647: Conditionally show plural "s" in warnings from to Conditionally show plural "s" in warnings.
Dec 17 2015, 1:37 AM

Dec 16 2015

quchen accepted D1637: Start using `-W` instead of `-f(no-)warn` in some places.
Dec 16 2015, 7:18 AM
quchen added a comment to D1637: Start using `-W` instead of `-f(no-)warn` in some places.

I suspect this patch is going to grow quite a bit. Maybe justify each class of changes in the revision?

Dec 16 2015, 7:07 AM
quchen added inline comments to D1613: Add `-W(no-)xxx` aliases for `-f(no-)warn-xxx` flags.
Dec 16 2015, 1:13 AM
quchen added inline comments to D1613: Add `-W(no-)xxx` aliases for `-f(no-)warn-xxx` flags.
Dec 16 2015, 1:10 AM

Dec 15 2015

quchen updated the diff for D1613: Add `-W(no-)xxx` aliases for `-f(no-)warn-xxx` flags.

Switch mkUserGuidePart to -W syntax

Dec 15 2015, 6:47 AM
quchen updated D1613: Add `-W(no-)xxx` aliases for `-f(no-)warn-xxx` flags.
Dec 15 2015, 4:13 AM
quchen updated the diff for D1613: Add `-W(no-)xxx` aliases for `-f(no-)warn-xxx` flags.

Fix rebase fallout again ... waaah

Dec 15 2015, 3:46 AM
quchen updated the diff for D1613: Add `-W(no-)xxx` aliases for `-f(no-)warn-xxx` flags.

Fix rebase fallout (update user's guide with -W again)

Dec 15 2015, 3:29 AM
quchen updated the diff for D1613: Add `-W(no-)xxx` aliases for `-f(no-)warn-xxx` flags.

Rebase onto HEAD

Dec 15 2015, 2:18 AM

Dec 14 2015

quchen added a comment to D1613: Add `-W(no-)xxx` aliases for `-f(no-)warn-xxx` flags.

Should we mention the old -f syntax in the user's guide at all? I completely removed it with the newest commit.

Dec 14 2015, 11:35 AM
quchen updated the diff for D1613: Add `-W(no-)xxx` aliases for `-f(no-)warn-xxx` flags.

Update the user's guide with -W* warnings

Dec 14 2015, 11:32 AM
quchen added a comment to D1613: Add `-W(no-)xxx` aliases for `-f(no-)warn-xxx` flags.

User manual?

Yes, will do once the features are decided.

Dec 14 2015, 9:29 AM
quchen updated the diff for D1613: Add `-W(no-)xxx` aliases for `-f(no-)warn-xxx` flags.
  • Mark old -f(no-)warn* flags as hidden
  • Fix GHCi test
Dec 14 2015, 9:26 AM
quchen added a comment to D1613: Add `-W(no-)xxx` aliases for `-f(no-)warn-xxx` flags.
Dec 14 2015, 6:57 AM
quchen added inline comments to D1613: Add `-W(no-)xxx` aliases for `-f(no-)warn-xxx` flags.
Dec 14 2015, 6:57 AM
quchen updated the diff for D1613: Add `-W(no-)xxx` aliases for `-f(no-)warn-xxx` flags.
  • Fix bootstrapping issue
  • Remove unwanted deprecations of -f flags
Dec 14 2015, 6:56 AM
quchen updated the diff for D1613: Add `-W(no-)xxx` aliases for `-f(no-)warn-xxx` flags.

Fix name clash

Dec 14 2015, 6:33 AM
quchen commandeered D1613: Add `-W(no-)xxx` aliases for `-f(no-)warn-xxx` flags.
Dec 14 2015, 5:28 AM
quchen added a comment to D1613: Add `-W(no-)xxx` aliases for `-f(no-)warn-xxx` flags.

I threw this patch together in a hurry without testing it yesterday, which explains why it doesn't build because of a duplicate name. What's also missing is mentioning the new flags in the user's guide, if that's desirable.

Dec 14 2015, 5:26 AM

Dec 6 2015

quchen accepted D1553: Implement new `-fwarn-noncanonical-monoid-instances`.
Dec 6 2015, 8:24 AM
quchen added a comment to D1553: Implement new `-fwarn-noncanonical-monoid-instances`.

We can flesh out the details in a future release, e.g. rename the functions, improve the error message and what not.

Dec 6 2015, 8:23 AM

Dec 1 2015

quchen updated D1554: Remove *.xml from gitignore.
Dec 1 2015, 8:23 AM
quchen retitled D1554: Remove *.xml from gitignore from to Remove *.xml from gitignore.
Dec 1 2015, 8:22 AM
quchen requested changes to D1553: Implement new `-fwarn-noncanonical-monoid-instances`.
Dec 1 2015, 7:28 AM

Nov 28 2015

quchen added a comment to D1541: Remove redundant `#if`s.

Ah, base is not built by the stage-0 compiler, but only by stage-1, right? In that case this looks good to me

Nov 28 2015, 11:37 AM
quchen added a comment to D1539: Implement warnings for Semigroups as parent of Monoid.
Nov 28 2015, 10:35 AM
quchen updated the diff for D1539: Implement warnings for Semigroups as parent of Monoid.

Implement @hvr's code review

Nov 28 2015, 10:34 AM

Nov 27 2015

quchen updated the diff for D1539: Implement warnings for Semigroups as parent of Monoid.
  • Fix semigroup warnings
  • Rename warning flag to -fwarn-semigroup
  • Add docs
Nov 27 2015, 11:24 AM
quchen updated D1539: Implement warnings for Semigroups as parent of Monoid.
Nov 27 2015, 10:09 AM
quchen updated the Trac tickets for D1539: Implement warnings for Semigroups as parent of Monoid.
Nov 27 2015, 10:07 AM
quchen retitled D1539: Implement warnings for Semigroups as parent of Monoid from to Implement warnings for Semigroups as parent of Monoid.
Nov 27 2015, 10:06 AM
quchen added a comment to D1292: Ad-hoc class method deprecations.

What @hvr said. We'll probably be able to use this patch to implement the generalized version though, but I'm not sure what the workflow for this is - close this diff? Leave it hanging around for documentation purposes? Delete it?

Nov 27 2015, 9:55 AM

Nov 25 2015

quchen accepted D1529: User's Guide: Add links to MFP wiki page.

I migrated the Wiki article, so these links point to something useful now. So LGTM

Nov 25 2015, 11:55 AM

Nov 23 2015

quchen updated the diff for D1495: Add -Wcompat warning flag group.

Add mkUserGuidePart entry for -Wcompat

Nov 23 2015, 1:57 AM

Nov 20 2015

quchen updated the diff for D1495: Add -Wcompat warning flag group.

Remove redundant files

Nov 20 2015, 7:25 AM
quchen updated the diff for D1495: Add -Wcompat warning flag group.
Typo
Nov 20 2015, 3:06 AM
quchen updated D1495: Add -Wcompat warning flag group.
Nov 20 2015, 2:34 AM

Nov 19 2015

quchen updated the diff for D1495: Add -Wcompat warning flag group.

Rebase onto HEAD

Nov 19 2015, 11:22 AM
quchen updated the diff for D1495: Add -Wcompat warning flag group.
  • Fix tests
  • Add release notes
Nov 19 2015, 10:58 AM

Nov 18 2015

quchen updated the diff for D1495: Add -Wcompat warning flag group.
  • Re-add deleted MonadFail tests, woops
Nov 18 2015, 11:59 AM
quchen updated the diff for D1495: Add -Wcompat warning flag group.
  • Document -Wno-compat
Nov 18 2015, 11:59 AM
quchen updated the diff for D1495: Add -Wcompat warning flag group.
  • Add -Wno-compat option, the opposite of -Wcompat
Nov 18 2015, 11:59 AM
quchen updated the diff for D1495: Add -Wcompat warning flag group.

Remove -W options from -Wcompat

Nov 18 2015, 11:59 AM
quchen added a reviewer for D1495: Add -Wcompat warning flag group: hvr.
Nov 18 2015, 11:59 AM
quchen retitled D1496: Mention "-XMonadFailDesugaring" in the docs from to Mention "-XMonadFailDesugaring" in the docs.
Nov 18 2015, 11:59 AM
quchen updated D1495: Add -Wcompat warning flag group.
Nov 18 2015, 11:59 AM
quchen updated D1495: Add -Wcompat warning flag group.
Nov 18 2015, 11:59 AM
quchen retitled D1495: Add -Wcompat warning flag group from to Add -Wcompat warning flag group.
Nov 18 2015, 11:21 AM
quchen updated the diff for D1489: Improve MonadFail errors by mentioning the pattern.

Fix patch to be relative to origin/master instead of outdated old branch

Nov 18 2015, 3:32 AM
quchen updated the diff for D1489: Improve MonadFail errors by mentioning the pattern.
  • Move short stuff out
  • More housekeeping
  • Syntax error
  • Forgotten herald
  • Revert special case for RebindableSyntax
  • Fix T4437
Nov 18 2015, 2:58 AM
quchen added a comment to D1489: Improve MonadFail errors by mentioning the pattern.
Nov 18 2015, 2:12 AM
quchen added a comment to D1489: Improve MonadFail errors by mentioning the pattern.
Nov 18 2015, 2:12 AM
quchen updated the diff for D1489: Improve MonadFail errors by mentioning the pattern.
  • Revert special case for RebindableSyntax
  • Fix syntax error
  • Forgotten herald in error messages
Nov 18 2015, 2:08 AM

Nov 17 2015

quchen added inline comments to D1489: Improve MonadFail errors by mentioning the pattern.
Nov 17 2015, 3:26 PM
quchen updated the diff for D1489: Improve MonadFail errors by mentioning the pattern.

More housekeeping

Nov 17 2015, 3:10 PM
quchen updated the diff for D1489: Improve MonadFail errors by mentioning the pattern.

Housekeeping

Nov 17 2015, 3:06 PM
quchen updated D1489: Improve MonadFail errors by mentioning the pattern.
Nov 17 2015, 2:54 PM
quchen retitled D1489: Improve MonadFail errors by mentioning the pattern from to Improve MonadFail errors by mentioning the pattern.
Nov 17 2015, 2:52 PM
quchen added a child revision for D1248: MonadFail proposal, phase 1: D1489: Improve MonadFail errors by mentioning the pattern.
Nov 17 2015, 2:52 PM · GHC
quchen added a comment to D1248: MonadFail proposal, phase 1.
Nov 17 2015, 10:06 AM · GHC
quchen updated the diff for D1248: MonadFail proposal, phase 1.

rebase onto HEAD again

Nov 17 2015, 10:06 AM · GHC
quchen added a comment to D1248: MonadFail proposal, phase 1.
Nov 17 2015, 9:55 AM · GHC
quchen updated the diff for D1248: MonadFail proposal, phase 1.

Rebase onto HEAD, implement CR suggestions

Nov 17 2015, 9:54 AM · GHC