ppk (Piyush P Kurur)
User

Projects

User does not belong to any projects.

User Details

User Since
Tue, Jul 10, 7:46 AM (6 d, 7 h)

Recent Activity

Today

ppk added a comment to D4951: support typechecking of type literals in backpack fixes #15138.

The windows build failed due to some strange problems. Shall I restart the build ?

Mon, Jul 16, 11:15 AM
ppk updated the diff for D4951: support typechecking of type literals in backpack fixes #15138.
  • typo in description of isLitTy.
Mon, Jul 16, 1:11 AM
ppk updated the diff for D4951: support typechecking of type literals in backpack fixes #15138.
  • allow type literal for data declaration spec only in hsig files.
  • added the test isLitTy to the Types module
  • simplify typecheck with isLitTy.
Mon, Jul 16, 1:08 AM

Sat, Jul 14

ppk added a comment to D4951: support typechecking of type literals in backpack fixes #15138.

@ezyang Okey I will make the changes you suggested in a couple of days.

Sat, Jul 14, 5:03 PM
ppk updated subscribers of D4951: support typechecking of type literals in backpack fixes #15138.

@ezyang I managed to fix this issue of Nats and Backpack. Can you have a look as there is somethings regarding hs-boot and hsig files here that are not clear to me.

Sat, Jul 14, 11:14 AM

Thu, Jul 12

ppk added a comment to D4951: support typechecking of type literals in backpack fixes #15138.

There is one clarification that I still need so may be you can just hold on before you merge. The function in question seems to be used both for hs-boot files and hsig files. The very next guard in the function check whether the function is for hsig and there is a comment there saying that it does not work with hsboot. Since I do not understand the code fully, can you confirm whether I should add such a check for this clause also

Thu, Jul 12, 10:58 PM
ppk added a comment to D4951: support typechecking of type literals in backpack fixes #15138.

Do you want me to do a commit sqashing. I think I can give better commit messages ?

Thu, Jul 12, 10:58 PM
ppk updated the diff for D4951: support typechecking of type literals in backpack fixes #15138.
  • some newline cleanups.
Thu, Jul 12, 3:39 AM
ppk added a comment to D4951: support typechecking of type literals in backpack fixes #15138.

I noticed that there are some new line ugliness. Will add a commit for that.

Thu, Jul 12, 3:35 AM

Tue, Jul 10

ppk created D4951: support typechecking of type literals in backpack fixes #15138.
Tue, Jul 10, 8:29 AM