ppk (Piyush P Kurur)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 10 2018, 7:46 AM (11 w, 1 d)

Recent Activity

Thu, Sep 13

ppk added inline comments to D5123: Fix #15594 (--abi-hash with Backpack sometimes fails).
Thu, Sep 13, 1:26 AM
ppk added a comment to D5123: Fix #15594 (--abi-hash with Backpack sometimes fails).

The summary for this phab is very sparse can there be more text there ?

Thu, Sep 13, 1:25 AM

Thu, Sep 6

ppk updated the summary of D4988: Support builtin classes like KnownNat in backpack.
Thu, Sep 6, 9:10 AM
ppk updated the diff for D4988: Support builtin classes like KnownNat in backpack.
  • tightened the language.
Thu, Sep 6, 9:10 AM
ppk added a comment to D4988: Support builtin classes like KnownNat in backpack.

@bgamari I think I have addressed all the outstanding issues here.

Thu, Sep 6, 8:41 AM

Wed, Sep 5

ppk updated the summary of D4988: Support builtin classes like KnownNat in backpack.
Wed, Sep 5, 11:33 PM
ppk updated the diff for D4988: Support builtin classes like KnownNat in backpack.
  • added @ezyang's explanation on the "magic" that resolves KnownNat.
Wed, Sep 5, 11:19 PM
ppk updated the diff for D4988: Support builtin classes like KnownNat in backpack.

Update the notes as suggested by spj.

Wed, Sep 5, 11:10 PM
ppk updated the summary of D4988: Support builtin classes like KnownNat in backpack.
Wed, Sep 5, 5:10 AM

Aug 21 2018

ppk added a comment to D4988: Support builtin classes like KnownNat in backpack.

Actually this was something that I too find magical because we do indeed know that the resolution is happening as witnessed
by the test case. I will try hunting it down.

Using -ddump-ds or -ddump-simpl should help. Edward may help too.

In the end, it would be good if the Note explained the magic.

Aug 21 2018, 12:48 AM

Aug 20 2018

ppk updated the diff for D4988: Support builtin classes like KnownNat in backpack.
  • remove useless newline.
Aug 20 2018, 12:44 AM

Aug 11 2018

ppk added inline comments to D4988: Support builtin classes like KnownNat in backpack.
Aug 11 2018, 5:28 AM
ppk updated the diff for D4988: Support builtin classes like KnownNat in backpack.

The instance checks that were happening in doClsInstErrorCheck now
needed to be ported into the check_valid_instance_head function
available in TcValidity.

Aug 11 2018, 5:23 AM
ppk added a comment to D4988: Support builtin classes like KnownNat in backpack.

The doClsInstErrorCheck which existed when I made this patch does not seem to exist any more. That is why it is now appearing in my patch although
I have not written them. I will not have to port the changes and see whether it works out or not.

Aug 11 2018, 3:35 AM
ppk updated the diff for D4988: Support builtin classes like KnownNat in backpack.
  • testsuite: Added test for Trac #15379.
  • allow instance of builtin classes in hsig files.
  • support builtin classes like KnownNat in backpack fixes Trac #15379.
Aug 11 2018, 2:56 AM

Aug 2 2018

ppk updated the diff for D4951: Support typechecking of type literals in backpack.
  • fixup: the just bug.
  • doc: fixup
Aug 2 2018, 9:58 AM
ppk updated the diff for D4988: Support builtin classes like KnownNat in backpack.
  • fixup: the just bug.
  • doc: fixup
  • testsuite: Added test for Trac #15379.
  • allow instance of builtin classes in hsig files.
  • support builtin classes like KnownNat in backpack fixes Trac #15379.
Aug 2 2018, 9:13 AM
ppk updated the diff for D4988: Support builtin classes like KnownNat in backpack.

Carry over from D4988.

Aug 2 2018, 4:50 AM
ppk updated the diff for D4951: Support typechecking of type literals in backpack.

Sorry Wrong commits unknowingly pushed here.

Aug 2 2018, 4:48 AM
ppk updated the diff for D4951: Support typechecking of type literals in backpack.

rebased with what is available on D4951.

Aug 2 2018, 4:47 AM
ppk updated the diff for D4951: Support typechecking of type literals in backpack.
  • testsuite: Added test for Trac #15379.
  • hand-written instances only rejected when not in boot/sig files.
  • testsuite: T15379 updated with instances of KnownSymbol and Typeable.
  • allow instances of builtin classes only in hsig and not hboot
  • testsuite: update the stdout for T15379.
  • delay on-the-fly generation of instances for KnownNat and friends.
Aug 2 2018, 4:34 AM

Jul 30 2018

ppk added a comment to D4951: Support typechecking of type literals in backpack.

If everything is okey let me know. We still need to address the issue that @simonpj raised.

What issue did I raise? I don't see anything on the ticket or in the Phab log.I recall writing stuff about KnonwNat but isn't that a separate patch? Confused...

Jul 30 2018, 3:09 AM

Jul 29 2018

ppk added a comment to D4951: Support typechecking of type literals in backpack.

It looks like there are a few failing tests still:

TEST="bkpfail23 bkpfail25 bkpfail26 bkpfail27 bkpfail46"

I looked them over and they look like legitimate failures.

Jul 29 2018, 10:15 PM

Jul 28 2018

ppk updated subscribers of D4951: Support typechecking of type literals in backpack.

@ezyang can you have a look at the backpack tests that are failing. In light of what @simonpj says about the witness; it could be pretty serious

Jul 28 2018, 2:28 AM

Jul 25 2018

ppk added a comment to D4988: Support builtin classes like KnownNat in backpack.

I'm puzzled about one thing. In the test case, module Util will look up the KnownNat NatType instance, and generate code that refers to the dictionary function, say $df78 :: KnownNat NatType.

I expect that when compiling Concrete.hs we'll generate a binding for $df78. (for hs-boot files it'd be created in TcRnDriver.checkHiBootIface)
But I don't see where that happens.

Jul 25 2018, 6:27 AM
ppk updated the summary of D4988: Support builtin classes like KnownNat in backpack.
Jul 25 2018, 5:28 AM
ppk updated the summary of D4988: Support builtin classes like KnownNat in backpack.
Jul 25 2018, 5:26 AM
ppk updated the summary of D4988: Support builtin classes like KnownNat in backpack.
Jul 25 2018, 5:23 AM
ppk updated the summary of D4988: Support builtin classes like KnownNat in backpack.
Jul 25 2018, 5:20 AM

Jul 24 2018

ppk updated the diff for D4988: Support builtin classes like KnownNat in backpack.
  • testsuite: Added test for Trac #15379.
  • allow instance of builtin classes in hsig files.
  • support builtin classes like KnownNat in backpack fixes Trac #15379.
Jul 24 2018, 11:44 PM

Jul 23 2018

ppk added a comment to D4988: Support builtin classes like KnownNat in backpack.

This should also have at least something of a commit message. It's fine to pull some language from the Note.

Jul 23 2018, 10:56 PM

Jul 20 2018

ppk updated the diff for D4988: Support builtin classes like KnownNat in backpack.

fixed typo in commit message.

Jul 20 2018, 1:13 AM
ppk added inline comments to D4988: Support builtin classes like KnownNat in backpack.
Jul 20 2018, 1:11 AM
ppk updated the diff for D4988: Support builtin classes like KnownNat in backpack.
  • added note for why not to reject builtin classes in sig files.
Jul 20 2018, 1:08 AM
ppk updated the diff for D4988: Support builtin classes like KnownNat in backpack.
  • added note on evidence generation in the setting of backpack.
Jul 20 2018, 12:52 AM
ppk updated the diff for D4988: Support builtin classes like KnownNat in backpack.
  • added note on evidence generation in the setting of backpack.
Jul 20 2018, 12:25 AM

Jul 19 2018

ppk added a child revision for D4951: Support typechecking of type literals in backpack: D4988: Support builtin classes like KnownNat in backpack.
Jul 19 2018, 10:50 PM
ppk added a parent revision for D4988: Support builtin classes like KnownNat in backpack: D4951: Support typechecking of type literals in backpack.
Jul 19 2018, 10:50 PM
ppk retitled D4988: Support builtin classes like KnownNat in backpack from supprot builtin classes like KnownNat in backpack fixes #15379. to support builtin classes like KnownNat in backpack fixes #15379..
Jul 19 2018, 8:04 AM
ppk updated subscribers of D4988: Support builtin classes like KnownNat in backpack.

Sorry I meant @ezyang

Jul 19 2018, 8:03 AM
ppk added a comment to D4988: Support builtin classes like KnownNat in backpack.

@ezang okey finally the patch for Trac #15379 is ready for review. I am told that there is a way to put a dependency on D4951. How does one do it ?

Jul 19 2018, 8:02 AM
ppk created D4988: Support builtin classes like KnownNat in backpack.
Jul 19 2018, 7:54 AM

Jul 17 2018

ppk added a comment to D4951: Support typechecking of type literals in backpack.

I guess this is finally ready to merge. If there is anything pending please let me know @bgamari @ezyang.

Jul 17 2018, 11:01 PM

Jul 16 2018

ppk added a comment to D4951: Support typechecking of type literals in backpack.

The windows build failed due to some strange problems. Shall I restart the build ?

Jul 16 2018, 11:15 AM
ppk updated the diff for D4951: Support typechecking of type literals in backpack.
  • typo in description of isLitTy.
Jul 16 2018, 1:11 AM
ppk updated the diff for D4951: Support typechecking of type literals in backpack.
  • allow type literal for data declaration spec only in hsig files.
  • added the test isLitTy to the Types module
  • simplify typecheck with isLitTy.
Jul 16 2018, 1:08 AM

Jul 14 2018

ppk added a comment to D4951: Support typechecking of type literals in backpack.

@ezyang Okey I will make the changes you suggested in a couple of days.

Jul 14 2018, 5:03 PM
ppk updated subscribers of D4951: Support typechecking of type literals in backpack.

@ezyang I managed to fix this issue of Nats and Backpack. Can you have a look as there is somethings regarding hs-boot and hsig files here that are not clear to me.

Jul 14 2018, 11:14 AM

Jul 12 2018

ppk added a comment to D4951: Support typechecking of type literals in backpack.

There is one clarification that I still need so may be you can just hold on before you merge. The function in question seems to be used both for hs-boot files and hsig files. The very next guard in the function check whether the function is for hsig and there is a comment there saying that it does not work with hsboot. Since I do not understand the code fully, can you confirm whether I should add such a check for this clause also

Jul 12 2018, 10:58 PM
ppk added a comment to D4951: Support typechecking of type literals in backpack.

Do you want me to do a commit sqashing. I think I can give better commit messages ?

Jul 12 2018, 10:58 PM
ppk updated the diff for D4951: Support typechecking of type literals in backpack.
  • some newline cleanups.
Jul 12 2018, 3:39 AM
ppk added a comment to D4951: Support typechecking of type literals in backpack.

I noticed that there are some new line ugliness. Will add a commit for that.

Jul 12 2018, 3:35 AM

Jul 10 2018

ppk created D4951: Support typechecking of type literals in backpack.
Jul 10 2018, 8:29 AM