phadej (Oleg Grenrus)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 24 2014, 9:33 AM (203 w, 3 d)

Recent Activity

Mar 9 2018

phadej added inline comments to D4212: Built-in Natural literals in Core.
Mar 9 2018, 6:17 AM

Aug 2 2017

phadej updated the diff for D3816: Add MonadIO Q - by requiring MonadIO => Quasi.

have -> has

Aug 2 2017, 11:48 AM
phadej updated the diff for D3816: Add MonadIO Q - by requiring MonadIO => Quasi.

mention qRunIO default implementation, qRunIO = liftIO

Aug 2 2017, 11:32 AM
phadej updated the diff for D3816: Add MonadIO Q - by requiring MonadIO => Quasi.
  • Fix T9208
Aug 2 2017, 11:15 AM
phadej updated the diff for D3816: Add MonadIO Q - by requiring MonadIO => Quasi.
  • TcSplice change
  • changelog
Aug 2 2017, 11:09 AM
Herald added a reviewer for D3816: Add MonadIO Q - by requiring MonadIO => Quasi: austin.
Aug 2 2017, 9:52 AM

Mar 3 2017

phadej added a comment to D3272: Reexport CmpNat and friends (defined in GHC.TypeNats) from GHC.TypeLits.

Oh seems I forgot to remove them. Nice catch, thanks @RyanGlScott !

Mar 3 2017, 3:09 PM

Feb 3 2017

phadej added inline comments to D3024: Introduce GHC.TypeNats module, change KnownNat evidence to be Natural.
Feb 3 2017, 12:05 PM
phadej added a comment to D3024: Introduce GHC.TypeNats module, change KnownNat evidence to be Natural.

I'm not very happy about the new {-# SOURCE #-} import, is it really necessary?

Feb 3 2017, 11:54 AM
phadej added a comment to D3024: Introduce GHC.TypeNats module, change KnownNat evidence to be Natural.
  1. I was explicitly asked by by @dfeuer to change evidence to be Natural, and it IMHO makes sense in the longer run.
  2. I tried to do that, but it turned to be much bigger patch. But there is a ticket: https://ghc.haskell.org/trac/ghc/ticket/13186 about that. The comments are welcomed.
Feb 3 2017, 3:44 AM

Feb 1 2017

phadej updated the diff for D3024: Introduce GHC.TypeNats module, change KnownNat evidence to be Natural.
  • Add changelog and notes entries
Feb 1 2017, 12:04 AM

Jan 26 2017

phadej updated the diff for D3024: Introduce GHC.TypeNats module, change KnownNat evidence to be Natural.

Fix clasing uniques, add naturalToInteger to integer-simple part

Jan 26 2017, 5:53 AM
phadej added a comment to D3024: Introduce GHC.TypeNats module, change KnownNat evidence to be Natural.

@dfeuer See https://ghc.haskell.org/trac/ghc/ticket/13186

Jan 26 2017, 1:55 AM
phadej added a comment to D3024: Introduce GHC.TypeNats module, change KnownNat evidence to be Natural.

@dfeuer yes, it will break: https://github.com/ekmett/reflection/blob/795bd225ef0008cfe25e14fbfbf705ed4c12396e/fast/Data/Reflection.hs#L199-L200 and also recently released Data.Constraint.Nat in constraints: http://hackage.haskell.org/package/constraints-0.9/docs/src/Data-Constraint-Nat.html but these are easy to fix.

Jan 26 2017, 12:46 AM
phadej retitled D3024: Introduce GHC.TypeNats module, change KnownNat evidence to be Natural from to Introduce GHC.TypeNats module, change KnownNat evidence to be Natural.
Jan 26 2017, 12:24 AM

Jan 12 2017

phadej added a comment to D2632: Add 'type family (m :: Symbol) <> (n :: Symbol)'.

There was another [a,b] <- traverse f [c, d] in the code. Expanded all of them.

Jan 12 2017, 12:51 AM
phadej updated the diff for D2632: Add 'type family (m :: Symbol) <> (n :: Symbol)'.
  • Don't use traverse
Jan 12 2017, 12:50 AM

Jan 10 2017

phadej updated the diff for D2632: Add 'type family (m :: Symbol) <> (n :: Symbol)'.

try update

Jan 10 2017, 12:32 AM

Jan 7 2017

phadej added inline comments to D2632: Add 'type family (m :: Symbol) <> (n :: Symbol)'.
Jan 7 2017, 10:28 AM
phadej updated the diff for D2632: Add 'type family (m :: Symbol) <> (n :: Symbol)'.

Split tests

Jan 7 2017, 10:28 AM

Jan 5 2017

phadej updated the diff for D2632: Add 'type family (m :: Symbol) <> (n :: Symbol)'.

Another try

Jan 5 2017, 6:37 AM
phadej updated the diff for D2632: Add 'type family (m :: Symbol) <> (n :: Symbol)'.

Another try

Jan 5 2017, 6:37 AM
phadej updated the diff for D2632: Add 'type family (m :: Symbol) <> (n :: Symbol)'.

Update release notes

Jan 5 2017, 6:10 AM
phadej retitled D2920: Fix doctests in Data.Functor from to Fix doctests in Data.Functor.
Jan 5 2017, 5:57 AM

Nov 5 2016

phadej added a comment to D2632: Add 'type family (m :: Symbol) <> (n :: Symbol)'.

@mpickering From my perspective, yes.

Nov 5 2016, 8:38 AM

Oct 26 2016

phadej updated the diff for D2632: Add 'type family (m :: Symbol) <> (n :: Symbol)'.
  • Add AppendSymbol injectivity tests
Oct 26 2016, 5:41 PM
phadej added a comment to D2632: Add 'type family (m :: Symbol) <> (n :: Symbol)'.

@yuv thanks for the reply. Now I see, I have to try to remove the inert rules to see how GHC would fail, and write this all up in the wiki. This is all very educating!

Oct 26 2016, 4:48 PM
phadej updated the diff for D2632: Add 'type family (m :: Symbol) <> (n :: Symbol)'.
  • Update T9181 output
  • Add some Symbol concatenation tests
  • Rename internals to AppendSymbol
  • Use AppendSymbol name in base
Oct 26 2016, 4:45 PM
phadej added a comment to D2632: Add 'type family (m :: Symbol) <> (n :: Symbol)'.

@yav could you elaborate what "Test interactions with inerts" do?

Oct 26 2016, 1:33 PM

Oct 23 2016

phadej added a comment to D2632: Add 'type family (m :: Symbol) <> (n :: Symbol)'.

I'm not sure where to add tests (cannot find Nat tests anywhere, +, * aren't well greppable), but would be glad to add them.

Oct 23 2016, 4:23 PM
phadej updated the diff for D2632: Add 'type family (m :: Symbol) <> (n :: Symbol)'.

Removed forgotten trace
fixed lint

Oct 23 2016, 4:21 PM
phadej retitled D2632: Add 'type family (m :: Symbol) <> (n :: Symbol)' from to Add 'type family (m :: Symbol) <> (n :: Symbol)'.
Oct 23 2016, 4:10 PM

Jun 22 2016

phadej committed rHADDOCK718c0830ba96: Fix orphan instance collapsing (authored by phadej).
Fix orphan instance collapsing
Jun 22 2016, 10:34 PM
phadej committed rHADDOCKad66637174de: Add orphan instances link to contents box (authored by phadej).
Add orphan instances link to contents box
Jun 22 2016, 10:34 PM
phadej committed rHADDOCK4d6b37ef3c8c: Generate docs for orphan instances (authored by phadej).
Generate docs for orphan instances
Jun 22 2016, 10:34 PM
phadej committed rHADDOCK17300995d63d: Have source links for orphan instances (authored by phadej).
Have source links for orphan instances
Jun 22 2016, 10:34 PM
phadej committed rHADDOCKb3e5ef8b70d6: Print orphan instances header only if required (authored by phadej).
Print orphan instances header only if required
Jun 22 2016, 10:34 PM

Jun 6 2016

phadej committed rHADDOCK7c60df10642d: Change Hyperlinked lexer to know about DataKinds ticks (authored by phadej).
Change Hyperlinked lexer to know about DataKinds ticks
Jun 6 2016, 7:26 PM
phadej committed rHADDOCKb8e3380f80da: UnfelpfulSpan line number omitted (authored by phadej).
UnfelpfulSpan line number omitted
Jun 6 2016, 7:26 PM

Jan 30 2016

phadej updated the diff for D1865: Add some Outputable instances.
  • Auto-derive Show Language
Jan 30 2016, 11:13 PM

Jan 29 2016

phadej retitled D1865: Add some Outputable instances from to Add some Outputable instances.
Jan 29 2016, 6:19 AM

Dec 25 2015

phadej committed rHADDOCKdee8ef2b9189: Have source links for orphan instances (authored by phadej).
Have source links for orphan instances
Dec 25 2015, 4:16 AM
phadej committed rHADDOCKc609348cca06: Add orphan instances link to contents box (authored by phadej).
Add orphan instances link to contents box
Dec 25 2015, 4:16 AM
phadej committed rHADDOCK02e633a6f9b7: Generate docs for orphan instances (authored by phadej).
Generate docs for orphan instances
Dec 25 2015, 4:16 AM
phadej committed rHADDOCK52bc03a00cf5: Fix orphan instance collapsing (authored by phadej).
Fix orphan instance collapsing
Dec 25 2015, 4:16 AM
phadej committed rHADDOCK7f97a59a8bf6: Print orphan instances header only if required (authored by phadej).
Print orphan instances header only if required
Dec 25 2015, 4:16 AM

Mar 19 2015

phadej updated the diff for D741: Fake (->) fixity declaration.
  • fixup! Fake (->) fixity declaration
Mar 19 2015, 7:39 AM
phadej retitled D741: Fake (->) fixity declaration from to Fake (->) fixity declaration.
Mar 19 2015, 1:20 AM

Mar 9 2015

phadej retitled D716: Add more MonadZip instances from to Add more MonadZip instances.
Mar 9 2015, 1:26 AM

Feb 24 2015

phadej added a comment to D591: Split warn-unused-binds into three parts (fixes #17).

nomeata, that was indeed a good "bonus".

Feb 24 2015, 4:07 AM

Feb 22 2015

phadej updated the diff for D673: Add various instances to newtypes in Data.Monoid.
  • Revert "Derive Data for Identity" (by hvr comment)
Feb 22 2015, 12:04 PM
phadej updated the diff for D673: Add various instances to newtypes in Data.Monoid.
  • Update tests
Feb 22 2015, 10:44 AM
phadej retitled D673: Add various instances to newtypes in Data.Monoid from to Add various instances to newtypes in Data.Monoid.
Feb 22 2015, 6:37 AM

Jan 27 2015

phadej retitled D631: Add packageName to GHC.Generics.Datatype from to Add packageName to GHC.Generics.Datatype.
Jan 27 2015, 11:45 AM

Jan 16 2015

phadej added a comment to D591: Split warn-unused-binds into three parts (fixes #17).

Should I rewrite the git history (squash "Correct other tests" and the revert commit)? I'm not sure how that would work with phabricator?

Jan 16 2015, 5:26 AM

Jan 13 2015

phadej updated the diff for D591: Split warn-unused-binds into three parts (fixes #17).
  • Revert 'Correct other tests'
Jan 13 2015, 1:18 PM
phadej updated the diff for D591: Split warn-unused-binds into three parts (fixes #17).

Changes according to review comments by rwbarton

Jan 13 2015, 12:26 PM

Dec 24 2014

phadej retitled D591: Split warn-unused-binds into three parts (fixes #17) from to Split warn-unused-binds into three parts (fixes #17).
Dec 24 2014, 11:10 AM