patrickdoc (Patrick Dougherty)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 9 2017, 10:10 AM (75 w, 2 d)

Recent Activity

Aug 6 2018

thomie awarded D3839: users_guide: Convert mkUserGuidePart generation to a Sphinx extension [skip ci] a Mountain of Wealth token.
Aug 6 2018, 6:09 PM

Jul 11 2018

patrickdoc added a comment to D4955: Support the GHCi debugger with -fexternal-interpreter.

I'm glad to see the Box/HValue flipping resolved. I think that reduces a lot of the friction between GHCi and the heap code.

Jul 11 2018, 6:50 PM

May 3 2018

patrickdoc added a comment to D3055: WIP Add HeapView functionality.

Just to make sure this doesn't fade away: bump.

May 3 2018, 3:13 PM

Apr 27 2018

patrickdoc updated the diff for D3055: WIP Add HeapView functionality.
  • Test more fields of closures for equality
  • Remove unnecessary evaluates
  • Expose all modules to fix Prof bug and match other libs
Apr 27 2018, 10:56 PM

Apr 24 2018

patrickdoc added a comment to D3055: WIP Add HeapView functionality.

Ok, I've now tested both non-TNTC prof and non-prof, I even found a bug :P I also updated the comment about the Word, changed to ConstrClosure, and fixed the test profiling.

Apr 24 2018, 2:23 AM
patrickdoc updated the diff for D3055: WIP Add HeapView functionality.
  • Add unboxed unlifted support
  • Fix (not TNTC && PROF) bug
Apr 24 2018, 2:06 AM

Apr 22 2018

patrickdoc added a comment to D3055: WIP Add HeapView functionality.

Thanks! I built unregisterized and tested, but before I got profiling working 100%. So I don't think I've covered the TNTC/Profiling matrix of options.

Apr 22 2018, 9:09 PM

Apr 21 2018

patrickdoc added a comment to D3055: WIP Add HeapView functionality.

Both TNTC and Profiling should now be supported. The biggest difficulty was the interactions between prof and ghci. I pulled a bit more code out of libraries/ghci and into heap-view to reduce the number of places making CPP profiling checks and adjusting pointers, but it's possible that there are some broken interactions hiding. I ran the testsuite a couple times for each way, and only ran into some transient failures that didn't seem like they could have come from me (although they certainly could have).

Apr 21 2018, 11:17 AM
patrickdoc updated the diff for D3055: WIP Add HeapView functionality.

Add support for more ways

  • Support Tables_Next_To_Code
  • Support Profiling
Apr 21 2018, 10:49 AM

Mar 26 2018

patrickdoc commandeered D3055: WIP Add HeapView functionality.

I've updated the revision so that it builds under "quick" and removes much of the duplication. Heap.hsc is currently structured to make the origin of different functions clear. Most of the functions are taken straight from various places in GHC. I've pulled them all out of their original sources and dealt with the fallout of the changes. compiler/ghci/RtClosureInspect.hs required the most changes.

Mar 26 2018, 1:00 AM
patrickdoc updated the diff for D3055: WIP Add HeapView functionality.

Deduplicate code and integrate ghc-heap

Mar 26 2018, 12:18 AM

Aug 17 2017

patrickdoc added a comment to D3839: users_guide: Convert mkUserGuidePart generation to a Sphinx extension [skip ci].

Indeed, I came to the same conclusion: it's not at all clear how to deal with env.app in a platform-specific manner.

Aug 17 2017, 11:20 AM
patrickdoc updated the diff for D3839: users_guide: Convert mkUserGuidePart generation to a Sphinx extension [skip ci].
  • Clean up reverse flags
  • Add note to DynFlags.hs to keep the docs up to date
Aug 17 2017, 10:52 AM

Aug 16 2017

patrickdoc added a comment to D3839: users_guide: Convert mkUserGuidePart generation to a Sphinx extension [skip ci].

I updated the code to just use app, app.env, and app.builder. Then I built and checked with Sphinx 1.3.6, 1.4.9, and 1.6.3. I had to update the column width specifiers in flags.rst because the \Y{} shorthand was only introduced in 1.6.

Aug 16 2017, 3:56 PM
patrickdoc updated the diff for D3839: users_guide: Convert mkUserGuidePart generation to a Sphinx extension [skip ci].
  • Fix compatibility for Sphinx versions 1.3.6 through 1.6.3
Aug 16 2017, 3:52 PM

Aug 15 2017

patrickdoc added a comment to D3839: users_guide: Convert mkUserGuidePart generation to a Sphinx extension [skip ci].

I've added some specific replies inline.

Aug 15 2017, 1:21 AM

Aug 11 2017

patrickdoc updated the diff for D3839: users_guide: Convert mkUserGuidePart generation to a Sphinx extension [skip ci].
  • Update gitignore
Aug 11 2017, 9:34 PM
patrickdoc created D3839: users_guide: Convert mkUserGuidePart generation to a Sphinx extension [skip ci].
Aug 11 2017, 9:30 PM

Jul 24 2017

patrickdoc accepted D3785: users-guide: Make it easier to reference haddocks.

Looks good to me, aside from the stray '>' and print statement.

Jul 24 2017, 3:21 PM

Jul 22 2017

patrickdoc created D3778: users-guide: Standardize and repair all flag references.
Jul 22 2017, 7:40 PM

Jun 29 2017

patrickdoc updated the diff for D3634: Make ':info Coercible' display an arbitrary string (fixes #12390).

Move logic into lookupKnownNameInfo

Jun 29 2017, 9:42 PM
patrickdoc added a comment to D3634: Make ':info Coercible' display an arbitrary string (fixes #12390).

On second thought, I have a better solution. I will post soon.

Jun 29 2017, 8:47 PM
patrickdoc updated the diff for D3634: Make ':info Coercible' display an arbitrary string (fixes #12390).
  • Make output valid Haskell
Jun 29 2017, 7:40 PM

Jun 27 2017

patrickdoc updated the diff for D3634: Make ':info Coercible' display an arbitrary string (fixes #12390).

Reimplement the change by introducing a lookupInfo function.

Jun 27 2017, 3:52 PM

Jun 22 2017

patrickdoc added a comment to D3634: Make ':info Coercible' display an arbitrary string (fixes #12390).

Apologies for the delay, I have been without internet for the past two weeks since graduation.

Jun 22 2017, 1:28 PM

Jun 9 2017

patrickdoc created D3634: Make ':info Coercible' display an arbitrary string (fixes #12390).
Jun 9 2017, 10:42 AM