nomeata (Joachim Breitner)
User

User Details

User Since
Jun 6 2014, 3:01 AM (231 w, 4 d)

Recent Activity

Oct 2 2018

nomeata added inline comments to D5079: Make GHC (the library) flexible in the choice of integer library.
Oct 2 2018, 11:31 AM
nomeata updated the diff for D5079: Make GHC (the library) flexible in the choice of integer library.
  • Merge branch 'master' of git://git.haskell.org/ghc into wip/T13477 Will merge into master when Phab is happy.
Oct 2 2018, 11:31 AM
nomeata added a comment to D5079: Make GHC (the library) flexible in the choice of integer library.

Ben, this PR is still officially blocked on you. Do you want to check it again? I hope I did enough Note refinement for now :-)

Oct 2 2018, 10:05 AM

Sep 7 2018

nomeata added inline comments to D5079: Make GHC (the library) flexible in the choice of integer library.
Sep 7 2018, 9:54 AM
nomeata updated the diff for D5079: Make GHC (the library) flexible in the choice of integer library.

More note refinement. Most of the information seems to be in Note [Wired-in
packages] already, but I rephrased slightly.

Sep 7 2018, 9:54 AM
nomeata added inline comments to D5079: Make GHC (the library) flexible in the choice of integer library.
Sep 7 2018, 8:58 AM
nomeata updated the diff for D5079: Make GHC (the library) flexible in the choice of integer library.
  • More links between notes, in particular Note [Wired-in packages]
Sep 7 2018, 4:07 AM
nomeata added a comment to D5079: Make GHC (the library) flexible in the choice of integer library.

More note massaging.

Sep 7 2018, 4:07 AM

Aug 26 2018

nomeata updated the summary of D5079: Make GHC (the library) flexible in the choice of integer library.
Aug 26 2018, 9:27 PM

Aug 25 2018

nomeata added a comment to D5058: Make lambda fit for MFP.

Someone needs to update the submodule in ghc to unblock https://perf.haskell.org/ghc/

Aug 25 2018, 1:48 PM

Aug 24 2018

nomeata accepted D5104: Fix #10859 by using foldr1 while deriving Eq instances.

I hope I did not discourage you from writing test cases in the future :-)

Aug 24 2018, 3:46 PM
nomeata added a comment to D5104: Fix #10859 by using foldr1 while deriving Eq instances.

Oh right, I should've used -dsuppress-uniques. Would a comment in the test file help ? Otherwise, I'll update this patch to not include it.

Aug 24 2018, 3:13 PM
nomeata requested changes to D5104: Fix #10859 by using foldr1 while deriving Eq instances.

Arg, Phab ate half my comments :-(

Aug 24 2018, 12:37 PM
nomeata added inline comments to D5104: Fix #10859 by using foldr1 while deriving Eq instances.
Aug 24 2018, 12:33 PM

Aug 22 2018

nomeata updated the diff for D5082: Make tablesNextToCode a proper dynamic flag (#15548).
  • Do not pass -DTABLES_NEXT_TO_CODE to gcc (untested)
Aug 22 2018, 3:49 PM

Aug 21 2018

nomeata updated the diff for D5082: Make tablesNextToCode a proper dynamic flag (#15548).
  • Found a few more ifdefs in the GHCi code
Aug 21 2018, 1:56 PM
nomeata updated the diff for D5079: Make GHC (the library) flexible in the choice of integer library.
  • One more note reference
Aug 21 2018, 12:03 PM
nomeata updated the diff for D5079: Make GHC (the library) flexible in the choice of integer library.
  • Add a Note and and use integer-wired-in for the unit name
Aug 21 2018, 12:03 PM
nomeata added a comment to D5082: Make tablesNextToCode a proper dynamic flag (#15548).

I'm confused; yes, they can now modify the flag but they would be unable to run any code compiled with the modification with a runtime built in the same way. Is the goal here to allow cross-compilation?

Aug 21 2018, 12:02 PM
nomeata updated the diff for D5082: Make tablesNextToCode a proper dynamic flag (#15548).

Use the right function

Aug 21 2018, 1:20 AM
nomeata created D5082: Make tablesNextToCode a proper dynamic flag (#15548).
Aug 21 2018, 12:39 AM

Aug 20 2018

nomeata retitled D5079: Make GHC (the library) flexible in the choice of integer library from [wip] Make GHC (the library) flexible in the choice of integer library to Make GHC (the library) flexible in the choice of integer library.
Aug 20 2018, 11:05 PM
nomeata updated the diff for D5079: Make GHC (the library) flexible in the choice of integer library.
  • Unused import
Aug 20 2018, 7:57 PM
nomeata updated the diff for D5079: Make GHC (the library) flexible in the choice of integer library.
  • Update findWiredInPackages to handle new integer unit name
Aug 20 2018, 6:35 PM
nomeata updated the diff for D5079: Make GHC (the library) flexible in the choice of integer library.
  • Introduce integerLibrary :: DynFlags -> IntegerLibrary
Aug 20 2018, 5:45 PM
nomeata updated the diff for D5079: Make GHC (the library) flexible in the choice of integer library.
  • Introduce integerLibrary :: DynFlags -> IntegerLibrary
Aug 20 2018, 4:53 PM
nomeata created D5079: Make GHC (the library) flexible in the choice of integer library.
Aug 20 2018, 4:47 PM

Aug 18 2018

nomeata accepted D5076: CSE should deal with letrec (#9441).

LGTM, thanks!

Aug 18 2018, 10:19 AM

Aug 16 2018

nomeata committed rGHCa50244c6a871: Rename SigTv to TyVarTv (#15480) (authored by nomeata).
Rename SigTv to TyVarTv (#15480)
Aug 16 2018, 10:59 PM
nomeata closed D5074: Rename SigTv to TyVarTv (#15480).
Aug 16 2018, 10:59 PM
nomeata added a comment to D5074: Rename SigTv to TyVarTv (#15480).

Ugh, I get test case failures locally. Let’s see if Phabricator seems them as well, or if my local setup is broken. And if they are there, where did I do a typo – this is a pure renaming of symbols!

Aug 16 2018, 8:18 PM
nomeata created D5074: Rename SigTv to TyVarTv (#15480).
Aug 16 2018, 7:20 PM

Aug 13 2018

nomeata added a comment to D5038: CSE should deal with letrec.

@nomeata Thanks for your comment!

you can do all this in one line

I have 3 different testcases with 3 different input modules and 2 different syslog outputs. Do you want me to put all 3 testcases into one single module?

Aug 13 2018, 10:52 AM

Aug 12 2018

nomeata added a comment to D5038: CSE should deal with letrec.

A bit late to the party, but this Makefile and grep business is really tricky later, and you can do all this in one line, see these for inspiration:

tests/stranal/should_compile/all.T:test('T10482',  [ grep_errmsg(r'wfoo.*Int#') ], compile, ['-dppr-cols=200 -ddump-simpl'])
tests/stranal/should_compile/all.T:test('T10482a', [ grep_errmsg(r'wf.*Int#') ],   compile, ['-dppr-cols=200 -ddump-simpl'])
tests/stranal/should_compile/all.T:test('T10694', [ grep_errmsg(r'Str=') ],   compile, ['-dppr-cols=200 -ddump-simpl'])
tests/stranal/should_compile/all.T:test('T11770', [ check_errmsg('OneShot') ], compile, ['-ddump-simpl'])
Aug 12 2018, 6:10 PM

Aug 11 2018

nomeata raised a concern with rGHCaab8656ba056: Turn on MonadFail desugaring by default.

This broke nofib:

Aug 11 2018, 12:56 PM

Aug 6 2018

nomeata committed rGHCf811685c3c15: Mention #15050 in the release notes for 8.8.1 (authored by nomeata).
Mention #15050 in the release notes for 8.8.1
Aug 6 2018, 9:11 AM

Aug 5 2018

nomeata committed rGHC4d91cabcd5e3: Allow scoped type variables refer to types (authored by nomeata).
Allow scoped type variables refer to types
Aug 5 2018, 7:59 PM
nomeata closed D4980: Use TauTv for pattern signature variables (#15050).
Aug 5 2018, 7:59 PM
nomeata added a comment to D4980: Use TauTv for pattern signature variables (#15050).

Ok, pushed. You may mention this in the camera ready version of the paper that I guess you might be working on right now :-)

Aug 5 2018, 7:58 PM
nomeata added a comment to rGHC56590db07a77: base: Make Foreign.Marshal.Alloc.allocBytes[Aligned] NOINLINE.

Weird: in fannkuch-redux allocations go up, but dynamic instructions go down: https://perf.haskell.org/ghc/#revision/56590db07a776ce81eb89d4a4d86bd0f953fb44e
Also maillist goes up

Aug 5 2018, 7:55 PM
nomeata updated the diff for D4980: Use TauTv for pattern signature variables (#15050).
  • Extend Note [Pattern signature binders]
  • Actually update the user guide according to the proposal
Aug 5 2018, 7:45 PM
nomeata added inline comments to D4980: Use TauTv for pattern signature variables (#15050).
Aug 5 2018, 7:45 PM

Aug 4 2018

nomeata added a comment to D4980: Use TauTv for pattern signature variables (#15050).

The proposal got accepted. I rebased, updated this, added a bit of note editing, and consider this ready for merging.

Aug 4 2018, 11:58 AM
nomeata updated the diff for D4980: Use TauTv for pattern signature variables (#15050).
  • Merge remote-tracking branch 'origin/wip/T15050' into wip/T15050 Not sure why there are two branches...
Aug 4 2018, 11:55 AM
nomeata updated the diff for D4980: Use TauTv for pattern signature variables (#15050).
  • Update Note [Pattern signature binders]
Aug 4 2018, 11:49 AM
nomeata updated the diff for D4980: Use TauTv for pattern signature variables (#15050).
  • Merge branch 'master' of git://git.haskell.org/ghc into wip/T15050
  • Turn the comment next to SigTv into a proper Note
Aug 4 2018, 11:45 AM
nomeata updated the summary of D4980: Use TauTv for pattern signature variables (#15050).
Aug 4 2018, 11:45 AM

Jul 25 2018

nomeata committed rGHCDIFF3b6efceff655: Replaced Text.Printf with extensible printf, and made comcommitant changes (authored by Bart Massey <bart@cs.pdx.edu>).
Replaced Text.Printf with extensible printf, and made comcommitant changes
Jul 25 2018, 11:13 AM
nomeata committed rGHCDIFF907cd8c36b6c: Add Data.Bool.bool (fixes #8302) (authored by Oliver Charles <ollie@ocharles.org.uk>).
Add Data.Bool.bool (fixes #8302)
Jul 25 2018, 11:13 AM
nomeata committed rGHCDIFFf793302a3f91: Refer to the coercible paper in Coercible' docs (authored by nomeata).
Refer to the coercible paper in Coercible' docs
Jul 25 2018, 10:19 AM
nomeata committed rGHCDIFF99869efc7946: Export Coercible in GHC.Types (#8894) (authored by nomeata).
Export Coercible in GHC.Types (#8894)
Jul 25 2018, 10:19 AM
nomeata committed rGHCDIFF54c95ffcb2cf: Better Comment [Kind-changing of (~) and Coercible] (authored by nomeata).
Better Comment [Kind-changing of (~) and Coercible]
Jul 25 2018, 10:19 AM
nomeata committed rGHCDIFFa962e1e41a0e: Note [Kind-changing of (~) and Coercible] (authored by nomeata).
Note [Kind-changing of (~) and Coercible]
Jul 25 2018, 10:19 AM
nomeata committed rGHCDIFF722193b42882: Update Coercible docs due to Safe Haskell adjustment (authored by nomeata).
Update Coercible docs due to Safe Haskell adjustment
Jul 25 2018, 10:19 AM
nomeata committed rGHCDIFF38b718295eea: Comment typo (authored by nomeata).
Comment typo
Jul 25 2018, 10:19 AM
nomeata committed rGHCDIFF7251d426b50c: Document Coercible in GHC.Types (authored by nomeata).
Document Coercible in GHC.Types
Jul 25 2018, 10:19 AM
nomeata committed rGHCDIFF2a5ac7b8edc1: Define GHC.Types.Coercible (authored by nomeata).
Define GHC.Types.Coercible
Jul 25 2018, 10:19 AM
nomeata committed rGHCDIFFa107737f84f6: s/FromList/isList in docs (authored by nomeata).
s/FromList/isList in docs
Jul 25 2018, 10:18 AM
nomeata committed rGHCDIFFc3108234cb1c: CopySmallArrayStressTest needs random (authored by nomeata).
CopySmallArrayStressTest needs random
Jul 25 2018, 10:17 AM
nomeata committed rGHCDIFF4bc3c8265f98: Mark test for #8831 as known-broken (authored by nomeata).
Mark test for #8831 as known-broken
Jul 25 2018, 10:15 AM
nomeata committed rGHCDIFFdf409de9550d: Flush after TH in #8884 test case (authored by nomeata).
Flush after TH in #8884 test case
Jul 25 2018, 10:15 AM
nomeata committed rGHCDIFFa5ab610f8d7e: Test case: ghci059: Forgot stdout file (authored by nomeata).
Test case: ghci059: Forgot stdout file
Jul 25 2018, 10:15 AM
nomeata committed rGHCDIFF7511d5bf708f: Fix validation issue due to Coercible move (#8894) (authored by nomeata).
Fix validation issue due to Coercible move (#8894)
Jul 25 2018, 10:15 AM
nomeata committed rGHCDIFF5d59265acf6c: Remove support for "primclass" (authored by nomeata).
Remove support for "primclass"
Jul 25 2018, 10:14 AM
nomeata added a reverting change for rGHCDIFFe239753c349f: Allow primclass and class constraints in primops: rGHCDIFF5d59265acf6c: Remove support for "primclass".
Jul 25 2018, 10:14 AM
nomeata committed rGHCDIFFd59170b6deae: Coercible is now exported from GHC.Types (#8894) (authored by nomeata).
Coercible is now exported from GHC.Types (#8894)
Jul 25 2018, 10:14 AM
nomeata committed rGHCDIFF014223745186: Test case: :info Coercible in GHCi (authored by nomeata).
Test case: :info Coercible in GHCi
Jul 25 2018, 10:14 AM
nomeata committed rGHCDIFFdb497cd1bef8: Fix comment for ghci script files (authored by nomeata).
Fix comment for ghci script files
Jul 25 2018, 10:14 AM
nomeata committed rGHCDIFFaab6b9bdc00d: Call Arity test case: Check what happens with unboxed lets (authored by nomeata).
Call Arity test case: Check what happens with unboxed lets
Jul 25 2018, 10:14 AM
nomeata committed rGHCDIFF306d255de6c3: Call Arity: Never eta-expand thunks in recursive groups (authored by nomeata).
Call Arity: Never eta-expand thunks in recursive groups
Jul 25 2018, 10:14 AM
nomeata committed rGHCDIFF1e36a3860422: Document Coercible in the user guide (authored by nomeata).
Document Coercible in the user guide
Jul 25 2018, 10:14 AM
nomeata committed rGHCDIFFd53ccab6ab32: Another reference to Note [Kind-changing of (~) and Coercible] (authored by nomeata).
Another reference to Note [Kind-changing of (~) and Coercible]
Jul 25 2018, 10:14 AM
nomeata committed rGHCDIFF4133ff86cbee: Reference Note [Kind-changing of (~) and Coercible] (authored by nomeata).
Reference Note [Kind-changing of (~) and Coercible]
Jul 25 2018, 10:14 AM
nomeata committed rGHCDIFF797da5c5e0e1: Call Arity : Note about fakeBoringCalls (authored by nomeata).
Call Arity : Note about fakeBoringCalls
Jul 25 2018, 10:14 AM
nomeata committed rGHCDIFF41ab58415224: Remove unused gHC_COERCIBLE (authored by nomeata).
Remove unused gHC_COERCIBLE
Jul 25 2018, 10:14 AM
nomeata committed rGHCDIFF7f919dec1579: Call Arity: Resurrect fakeBoringCalls (authored by nomeata).
Call Arity: Resurrect fakeBoringCalls
Jul 25 2018, 10:13 AM
nomeata committed rGHCDIFFd246c62afd73: Also allow http://github.com (#8824) (authored by nomeata).
Also allow http://github.com (#8824)
Jul 25 2018, 10:13 AM
nomeata committed rGHCDIFF3efcb0a7d147: Make sync-all handle all github protocols correctly (authored by nomeata).
Make sync-all handle all github protocols correctly
Jul 25 2018, 10:13 AM
nomeata committed rGHCDIFF0014fb3dbf4a: Run testcase for 8124 only with threaded ways (authored by nomeata).
Run testcase for 8124 only with threaded ways
Jul 25 2018, 10:13 AM
nomeata committed rGHCDIFFcb8a63cb61af: Major Call Arity rework (authored by nomeata).
Major Call Arity rework
Jul 25 2018, 10:13 AM
nomeata committed rGHCDIFFaf7428e8bfe0: Call Arity refactoring: fakeBoringCalls (authored by nomeata).
Call Arity refactoring: fakeBoringCalls
Jul 25 2018, 10:12 AM
nomeata committed rGHCDIFFba4616b68584: Call Arity: Update compiler perf number changes (authored by nomeata).
Call Arity: Update compiler perf number changes
Jul 25 2018, 10:11 AM
nomeata committed rGHCDIFFf347bfeae0d7: Support mutual recursion (authored by nomeata).
Support mutual recursion
Jul 25 2018, 10:11 AM
nomeata committed rGHCDIFFd3c579c75ffe: Call arity testcase for #3924 (authored by nomeata).
Call arity testcase for #3924
Jul 25 2018, 10:11 AM
nomeata committed rGHCDIFFd51d7efd67fe: Call arity: Handle type application correctly (authored by nomeata).
Call arity: Handle type application correctly
Jul 25 2018, 10:11 AM
nomeata committed rGHCDIFF2ab00bf74863: Call Arity: Now also done on Top-Level binds (authored by nomeata).
Call Arity: Now also done on Top-Level binds
Jul 25 2018, 10:11 AM
nomeata committed rGHCDIFF7e787e7e7e3c: Move unit call arity unittests into subdirectory (authored by nomeata).
Move unit call arity unittests into subdirectory
Jul 25 2018, 10:11 AM
nomeata committed rGHCDIFF7c603aba2f2e: Call Arity refactoring: instance Outputable Count (authored by nomeata).
Call Arity refactoring: instance Outputable Count
Jul 25 2018, 10:11 AM
nomeata committed rGHCDIFFfa353f274df7: Call Arity refactoring: Use a product domain (authored by nomeata).
Call Arity refactoring: Use a product domain
Jul 25 2018, 10:11 AM
nomeata committed rGHCDIFF983fbbe71783: Call Arity refactoring: Factor out callArityBound (authored by nomeata).
Call Arity refactoring: Factor out callArityBound
Jul 25 2018, 10:11 AM
nomeata committed rGHCDIFF4c93a40db5cf: Make CallArity make more use of many-calls (authored by nomeata).
Make CallArity make more use of many-calls
Jul 25 2018, 10:11 AM
nomeata committed rGHCDIFF2931d19e90d2: More liberally eta-expand a case-expression (authored by nomeata).
More liberally eta-expand a case-expression
Jul 25 2018, 10:11 AM
nomeata committed rGHCDIFF347721659cb3: Fix Manual hlinting patch (authored by nomeata).
Fix Manual hlinting patch
Jul 25 2018, 10:11 AM
nomeata committed rGHCDIFFe16826b12e8a: Cleaned up Maybes.lhs (authored by Iceland_jack).
Cleaned up Maybes.lhs
Jul 25 2018, 10:11 AM
nomeata committed rGHCDIFFe2cacb66e10c: Manual hlinting: or (map f) = any f (authored by nomeata).
Manual hlinting: or (map f) = any f
Jul 25 2018, 10:11 AM
nomeata committed rGHCDIFF9f607eeb6227: Link to #minimal-pragma from release notes (authored by nomeata).
Link to #minimal-pragma from release notes
Jul 25 2018, 10:10 AM
nomeata committed rGHCDIFF5d04603b33d2: Remove eta-expansion in Rules.match (authored by nomeata).
Remove eta-expansion in Rules.match
Jul 25 2018, 10:10 AM
nomeata committed rGHCDIFFcde88e20a880: Test case: Looking through unfoldings when matching lambdas (authored by nomeata).
Test case: Looking through unfoldings when matching lambdas
Jul 25 2018, 10:10 AM
nomeata committed rGHCDIFFa27b29855118: Use exprIsLambda_maybe in match (authored by nomeata).
Use exprIsLambda_maybe in match
Jul 25 2018, 10:10 AM
nomeata committed rGHCDIFF377672ae068f: Test case for RULE map coerce = coerce (authored by nomeata).
Test case for RULE map coerce = coerce
Jul 25 2018, 10:10 AM