nomeata (Joachim Breitner)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Jun 6 2014, 3:01 AM (151 w, 2 d)
Availability
Available

Recent Activity

Today

nomeata raised a concern with rGHC945c45ad50ed: Prefer #if defined to #ifdef.

This broke travis:
https://travis-ci.org/ghc/ghc/jobs/227042525

libraries/time/lib/Data/Time/Clock/Internal/SystemTime.hs:22:0: error:
Sun, Apr 30, 5:04 AM
nomeata committed rGHC41d9a79078b4: Remove unused tidyOccNames and update Note (authored by nomeata).
Remove unused tidyOccNames and update Note
Sun, Apr 30, 4:27 AM
nomeata closed D3511: Remove unused tidyOccNames and update Note by committing rGHC41d9a79078b4: Remove unused tidyOccNames and update Note.
Sun, Apr 30, 4:27 AM
nomeata updated the diff for D3511: Remove unused tidyOccNames and update Note.

Clean up imports

Sun, Apr 30, 3:02 AM
nomeata added a comment to rGHC18ac80ff729e: tidyType: Rename variables of nested forall at once.

Quite right, cleanup patch at https://phabricator.haskell.org/rGHC18ac80ff729e#66197

Sun, Apr 30, 2:31 AM
nomeata created D3511: Remove unused tidyOccNames and update Note.
Sun, Apr 30, 2:30 AM

Fri, Apr 28

nomeata added a comment to rGHCa1b753e8b147: Cure exponential behaviour in the simplifier.

Combined effect has one runtime regression and one improvement of similar size. See
https://perf.haskell.org/ghc/#compare/25754c83c9be3bf843310b1c7877c42fa3f9f3c7/29d88ee173bc9b04245a33d5268dda032f5dc331
for dateils. I’ll not raise any concern.

Fri, Apr 28, 5:07 PM
nomeata resigned from rGHCa1b753e8b147: Cure exponential behaviour in the simplifier.

Nevermind, the next commit fixes some of these issues; I should report on their combined effect.

Fri, Apr 28, 5:07 PM
nomeata raised a concern with rGHCa1b753e8b147: Cure exponential behaviour in the simplifier.

According to https://perf.haskell.org/ghc/#revision/a1b753e8b1475659440f524b3e66dfbea31c5787 this fix is not without a cost:
Allocations up 22% for boyer2, up 5% for mate; runtime up 4.7% for fast and up 3.3% for mate.

Fri, Apr 28, 5:07 PM

Mon, Apr 24

nomeata committed rGHC583fa9e3687b: core-spec: Simplify the handling of LetRec (authored by nomeata).
core-spec: Simplify the handling of LetRec
Mon, Apr 24, 3:59 PM
nomeata closed D3466: core-spec: Simplify the handling of LetRec by committing rGHC583fa9e3687b: core-spec: Simplify the handling of LetRec.
Mon, Apr 24, 3:59 PM
nomeata committed rGHC1c27e5b3932c: Add failing test case for T13611 (authored by nomeata).
Add failing test case for T13611
Mon, Apr 24, 12:16 PM
nomeata requested review of D3466: core-spec: Simplify the handling of LetRec.

Oh, I guess I have to tell Phabricator that I don’t currently plan to change this, but rather that discussion should continue.

Mon, Apr 24, 12:13 PM

Tue, Apr 18

nomeata added a comment to D3466: core-spec: Simplify the handling of LetRec.

Correct me if I'm wrong, but these semantics say that let rec x = 3 in x steps to itself, no? And you can do this with proper (co-)recursion: let rec ones = 1 : ones in ones is quite useful, yet this, too, seems to step to itself.

Tue, Apr 18, 7:46 PM
nomeata committed rGHC21c35bda8e43: Simplify StgCases when all alts refer to the case binder (authored by nomeata).
Simplify StgCases when all alts refer to the case binder
Tue, Apr 18, 7:18 PM
nomeata closed D3467: Simplify StgCases when all alts refer to the case binder by committing rGHC21c35bda8e43: Simplify StgCases when all alts refer to the case binder.
Tue, Apr 18, 7:18 PM
nomeata added a comment to D3467: Simplify StgCases when all alts refer to the case binder.

Is there any perf effect?

Tue, Apr 18, 5:38 PM
nomeata committed rGHCebb780f1b384: Add failing test case for #13588 (authored by nomeata).
Add failing test case for #13588
Tue, Apr 18, 4:34 PM
nomeata created D3467: Simplify StgCases when all alts refer to the case binder.
Tue, Apr 18, 4:27 PM
nomeata created D3466: core-spec: Simplify the handling of LetRec.
Tue, Apr 18, 3:41 PM
nomeata committed rGHC60699e120bfd: Fix LaTeX in core-spec (authored by nomeata).
Fix LaTeX in core-spec
Tue, Apr 18, 3:19 PM

Wed, Apr 12

nomeata raised a concern with rGHC751996e90a96: Kill off complications in CoreFVs.

I (well, perf.haskell.org) observes a 25% increase in runtime in n-body (but nothing in any other numbers).

Wed, Apr 12, 10:30 PM

Mon, Apr 10

nomeata committed rGHCddc05912565a: Add a second regression test for #13536 (authored by nomeata).
Add a second regression test for #13536
Mon, Apr 10, 10:23 AM
nomeata committed rGHCb55f310d06b8: StgCse: Do not re-use trivial case scrutinees (authored by nomeata).
StgCse: Do not re-use trivial case scrutinees
Mon, Apr 10, 9:13 AM
nomeata closed D3437: StgCse: Do not re-use trivial case scrutinees by committing rGHCb55f310d06b8: StgCse: Do not re-use trivial case scrutinees.
Mon, Apr 10, 9:13 AM

Sun, Apr 9

nomeata created D3437: StgCse: Do not re-use trivial case scrutinees.
Sun, Apr 9, 6:49 PM
nomeata committed rGHC87377f74eec1: Add a Note [Call Arity and Join Points] (authored by nomeata).
Add a Note [Call Arity and Join Points]
Sun, Apr 9, 5:44 PM

Mar 31 2017

nomeata resigned from rGHCcea7141851ce: Fix #13458.
Mar 31 2017, 8:59 AM
nomeata added a comment to rGHCcea7141851ce: Fix #13458.

Ok, I just did that in 03c7dd0941fb4974be54026ef3e4bb97451c3b1f. It can be reverted if that was uncalled for, but ideally with a patch that avoids spamming the log.

Mar 31 2017, 8:59 AM
nomeata committed rGHC03c7dd0941fb: Disable bogus lint checks about levity polimorphic coerions (authored by nomeata).
Disable bogus lint checks about levity polimorphic coerions
Mar 31 2017, 8:57 AM
nomeata added a comment to rGHCcea7141851ce: Fix #13458.

Is there a reason not to quickly and simply disable the warning until this has been looked into?

Mar 31 2017, 8:43 AM

Mar 29 2017

nomeata raised a concern with rGHCcea7141851ce: Fix #13458.

This commit makes the build on perf.haskell.org produce huge build logs (>130MB) because of a spew of new lint warnings:

Mar 29 2017, 10:37 PM

Mar 28 2017

nomeata committed rGHCe07211f752b9: Zap Call Arity info in the simplifier (authored by nomeata).
Zap Call Arity info in the simplifier
Mar 28 2017, 6:36 PM
nomeata closed D3390: Zap Call Arity info in the simplifier by committing rGHCe07211f752b9: Zap Call Arity info in the simplifier.
Mar 28 2017, 6:36 PM
nomeata created D3390: Zap Call Arity info in the simplifier.
Mar 28 2017, 3:21 PM

Mar 24 2017

nomeata resigned from rGHC1dd60ac9a949: Typos in comments (notes too) [ci skip].
Mar 24 2017, 9:34 AM

Mar 19 2017

nomeata resigned from rGHCcbe569a56e2a: Upgrade UniqSet to a newtype.

Sure.

Mar 19 2017, 9:49 PM

Mar 17 2017

nomeata raised a concern with rGHC1cbc7c315fb6: Bump nofib submodule.

Sorry for not checking earlier, but no, this is not sufficient: https://raw.githubusercontent.com/nomeata/ghc-speed-logs/f37051fd6649e468621ee197179a514587b78e27/e0c433c81182c934ee4c4cc5c6cf25a1b6fb8d83.log.broken

Mar 17 2017, 5:14 PM

Mar 16 2017

nomeata added a comment to D3055: WIP Add HeapView functionality.
In D3055#96358, @erikd wrote:

There's a lot of work to be done on this and I can't see myself finding the time.

Mar 16 2017, 5:26 PM

Mar 15 2017

nomeata accepted rNOFIB313812d319e0: spectral: fix secretary.
Mar 15 2017, 3:38 PM
nomeata added a comment to rNOFIB313812d319e0: spectral: fix secretary.

I was actually thinking about this problem (but in the context of benchmarks in parallel) - maybe we could check-in (or add as submodules?) the packages that are needed for the benchmarks. This would make nofib more hermetic (and we could measure the compile-time required for those packages as another signal for measuring the performance of GHC itself).

Mar 15 2017, 3:38 PM
nomeata accepted D3347: spectral: temporarily disable secretary.

LGTM.

Mar 15 2017, 3:37 PM
nomeata raised a concern with rNOFIB313812d319e0: spectral: fix secretary.

This broke testing on perf.haskell.org:

+== make boot --no-print-directory;
+ in /home/nomeata/logs/ghc-tmp-REV/nofib/spectral/secretary
+------------------------------------------------------------------------
+/home/nomeata/logs/ghc-tmp-REV/inplace/bin/ghc-stage2  -M -dep-suffix "" -dep-makefile .depend -osuf o     -O2 -Rghc-timing -H32m -hisuf hi -package random -rtsopts Main.lhs
+<command line>: cannot satisfy -package random
+    (use -v for more information)
+<<ghc: 10186952 bytes, 7 GCs, 530340/819800 avg/max bytes residency (2 samples), 23M in use, 0.001 INIT (0.000 elapsed), 0.007 MUT (0.006 elapsed), 0.012 GC (0.012 elapsed) :ghc>>
Mar 15 2017, 3:05 PM

Mar 9 2017

nomeata committed rGHC712c45d03579: integerConstantFolding: no longer broken with -DDEBUG (#1106) (authored by nomeata).
integerConstantFolding: no longer broken with -DDEBUG (#1106)
Mar 9 2017, 11:16 AM
nomeata committed rNOFIB9a1b1a0cd06b: Simon’s notes: Refer mailing list about binary-tree (authored by nomeata).
Simon’s notes: Refer mailing list about binary-tree
Mar 9 2017, 10:20 AM
nomeata committed rGHC665cefe80d11: Add a comment to the mapFB rules (authored by nomeata).
Add a comment to the mapFB rules
Mar 9 2017, 9:14 AM

Mar 7 2017

nomeata updated the diff for D3246: Revise list fusion for and, or, all, any, elem, notElem (#13351).

Rebase

Mar 7 2017, 4:55 AM
nomeata added a comment to D3275: Add rule mapFB c (λx.x) = c.
In D3275#95081, @dfeuer wrote:

We use one mechanism to deal with map/coerce and now a different one to deal with map/id. My impression is that these basically do the same thing in general. The map/id rule (as I understand it) simplifies mapFB forms so they'll eventually trip the foldr/cons rule. Is that right? Is it more effective than the simpler approach we take for map/coerce?

Mar 7 2017, 4:51 AM

Mar 6 2017

nomeata added a comment to D3246: Revise list fusion for and, or, all, any, elem, notElem (#13351).

Ok, all reported performance changes are due to the changes to the list functions, and not due to fusing short lists.

Mar 6 2017, 6:52 AM

Mar 5 2017

nomeata added a comment to D3275: Add rule mapFB c (λx.x) = c.
In D3275#94927, @dfeuer wrote:

Can you add a test to verify directly that the rule fires?

Mar 5 2017, 5:42 PM
nomeata raised a concern with rGHCa694cee77b64: TcTypeable: Try to reuse KindReps.

There are two small, but stable runtime changes in nofib. Expected, or a sign that something went wrong?
https://perf.haskell.org/ghc/#revision/a694cee77b64235b42029fea248453ddf6b17d17

Mar 5 2017, 5:32 AM

Mar 4 2017

nomeata created D3275: Add rule mapFB c (λx.x) = c.
Mar 4 2017, 2:20 PM
nomeata added a comment to D3246: Revise list fusion for and, or, all, any, elem, notElem (#13351).

Bumping out of the review queue for now.

Mar 4 2017, 2:03 PM
nomeata committed rGHC2e58c3b21b40: Update dangling Note reference (authored by nomeata).
Update dangling Note reference
Mar 4 2017, 1:51 PM

Mar 3 2017

nomeata raised a concern with rGHC2effe18ab51d: The Early Inline Patch.

This might be interesting for @lukemaurer: According to https://perf.haskell.org/ghc/#revision/2effe18ab51d66474724d38b20e49cc1b8738f60 this patch undid the effect of join points on fannkuch-redux (i..e allocation goes up by 1318762.9%, but runtime goes down by 5%). Was this ever cleared up?

Mar 3 2017, 5:31 AM

Mar 2 2017

nomeata added a comment to D3246: Revise list fusion for and, or, all, any, elem, notElem (#13351).

Gipeda results are in: https://perf.haskell.org/ghc/#revision/b112f4604811faa6f5aeb399d8b5ee575f413bb7.

It definitely looks like there is more work to do here.

Mar 2 2017, 4:23 PM

Mar 1 2017

nomeata updated the diff for D3246: Revise list fusion for and, or, all, any, elem, notElem (#13351).

Test suite update

Mar 1 2017, 8:32 PM
nomeata accepted rGHCd0508ef001e9: When floating, don't box an expression that's okay for speculation (#13338).

Nevermind me then :-)

Mar 1 2017, 1:13 PM
nomeata raised a concern with rGHCd0508ef001e9: When floating, don't box an expression that's okay for speculation (#13338).

Do you have a grip on the performance regressions?

Benchmark name 	                    previous 	change 	       now 	
nofib/time/fannkuch-redux 	4.706 	+ 11.62% 	5.253 	seconds
nofib/time/k-nucleotide 	        5.323 	+ 4.3% 	        5.552 	seconds
Mar 1 2017, 12:59 PM
nomeata updated the diff for D3246: Revise list fusion for and, or, all, any, elem, notElem (#13351).

Try to make T2110 more robust

Mar 1 2017, 12:15 PM

Feb 28 2017

nomeata created D3246: Revise list fusion for and, or, all, any, elem, notElem (#13351).
Feb 28 2017, 3:42 PM

Feb 22 2017

nomeata resigned from rGHC8ccbc2e5252a: Bump Cabal and containers submodules.
Feb 22 2017, 9:51 AM
nomeata raised a concern with rGHC8ccbc2e5252a: Bump Cabal and containers submodules.

The last-piece nofib program has regressed considerably (7%), likely due to changes in Data.Map. How should we handle that? Ignore it? Report to the cabal project? I guess I’ll do the latter: https://github.com/haskell/containers/issues/415

Feb 22 2017, 9:50 AM

Feb 21 2017

nomeata added a comment to rGHC27a2854124cc: A number of Typeable wibbles from review.

Runtime performance improvements in fasta and lambda:
https://perf.haskell.org/ghc/#revision/27a2854124cc1c101570104501beea234a4ee921
A bit weird, isn’t it?

Feb 21 2017, 8:56 AM

Feb 16 2017

nomeata added a comment to D3141: testsuite: Move echoing commands in make invocations to VERBOSE=5.
In D3141#92010, @Phyx wrote:

I rather not have another environment variable to do another thing, as it's already hard to remember what to use for the various things.

Feb 16 2017, 10:17 AM

Feb 15 2017

nomeata requested changes to D3141: testsuite: Move echoing commands in make invocations to VERBOSE=5.

I have doubts about the VERBOSE setting. If increasing the verbosity can make tests fail, then that is a harsh violation of the principle of least surprise!

Feb 15 2017, 10:40 PM
nomeata raised a concern with rGHCa3704409acc3: Fix various issues with testsuite code on Windows.

Sorry to jump on this after it has been commited, but I have doubts about the VERBOSE setting. If increasing the verbosity can make tests fail, then that is a harsh violation of the principle of least surprise!

Feb 15 2017, 10:40 PM

Feb 11 2017

nomeata updated the diff for D3089: Improve the Occurrence Analyzer’s handling of one-shot functions.

Also recenter haddock.compiler

Feb 11 2017, 12:46 PM
nomeata updated the diff for D3089: Improve the Occurrence Analyzer’s handling of one-shot functions.

Update perf data.

Feb 11 2017, 12:44 PM
nomeata updated the diff for D3089: Improve the Occurrence Analyzer’s handling of one-shot functions.

Rebase to master

Feb 11 2017, 10:49 AM
nomeata added inline comments to D3055: WIP Add HeapView functionality.
Feb 11 2017, 9:23 AM

Feb 9 2017

nomeata added a comment to rGHCb9bebd8cedcc: Implement addCStub in template-haskell..

https://travis-ci.org/ghc/ghc/builds/200216540 looks good, thanks!

Feb 9 2017, 10:39 PM
nomeata added inline comments to D810: Ensure that Literals are in range.
Feb 9 2017, 5:39 PM
nomeata added a comment to rGHCb9bebd8cedcc: Implement addCStub in template-haskell..

Hmm, baking in the output of a tool that is not under our control, has several implementations and may of course change its error message from versin to version does not strike me as very useful in the long run. Maybe just grep the output for TH_addCStub2.hs:13:13, assuming that at least that part stays stable?

Feb 9 2017, 2:30 PM
nomeata raised a concern with rGHCb9bebd8cedcc: Implement addCStub in template-haskell..

On Travis, this causes test cases to fail: https://api.travis-ci.org/jobs/200040619/log.txt?deansi=true

Feb 9 2017, 12:19 PM
nomeata committed rGHCd266aac9586d: Library docs: Document the order for sort and sortOn. (authored by Alexander Kjeldaas <ak@formalprivacy.com>).
Library docs: Document the order for sort and sortOn.
Feb 9 2017, 12:17 PM

Feb 8 2017

nomeata committed rGHC8c4c084f858c: Travis experiment: Try “quickest” build flavor (authored by nomeata).
Travis experiment: Try “quickest” build flavor
Feb 8 2017, 1:38 PM

Feb 7 2017

nomeata committed rGHC2f31711f9291: Travis experiment: bump boot GHC (authored by nomeata).
Travis experiment: bump boot GHC
Feb 7 2017, 3:39 PM
nomeata committed rGHC8882aa770588: Improve the Occurrence Analyzer’s handling of one-shot functions (authored by nomeata).
Improve the Occurrence Analyzer’s handling of one-shot functions
Feb 7 2017, 3:35 PM
nomeata added a comment to rGHCb8f58d79ee3e: Another improvement to SetLevels.

I see different runtime results from nofib:
https://perf.haskell.org/ghc/#revision/b8f58d79ee3e34840beeea2fab846a9f47bff21a

Feb 7 2017, 2:06 PM
nomeata committed rGHCa0440d8d12b0: Travis experiment: bump boot GHC (authored by nomeata).
Travis experiment: bump boot GHC
Feb 7 2017, 1:54 PM
nomeata committed rGHCc729798f5a07: Travis experiment: try trusty (authored by nomeata).
Travis experiment: try trusty
Feb 7 2017, 1:54 PM
nomeata committed rGHCf9a0639fe00c: Travis experiment: language: generic (authored by nomeata).
Travis experiment: language: generic
Feb 7 2017, 1:51 PM
nomeata committed rGHC6fce907bf573: Travis experiment: Build in non-container environment (authored by nomeata).
Travis experiment: Build in non-container environment
Feb 7 2017, 1:51 PM
nomeata committed rGHC5ce39f6395ef: Add Wredundant-constraints to list of flags excluded from -Wall (authored by siddhanathan).
Add Wredundant-constraints to list of flags excluded from -Wall
Feb 7 2017, 10:20 AM
nomeata committed rGHC078beea9e970: Docs: Fix typo in glasgow_exts.rst (authored by DanielG).
Docs: Fix typo in glasgow_exts.rst
Feb 7 2017, 10:18 AM
nomeata updated the diff for D3089: Improve the Occurrence Analyzer’s handling of one-shot functions.

s/info/information/

Feb 7 2017, 9:59 AM
nomeata updated the diff for D3089: Improve the Occurrence Analyzer’s handling of one-shot functions.

Improve notes

Feb 7 2017, 9:36 AM

Feb 6 2017

nomeata committed rGHC52fc50301279: Improve the Occurrence Analyzer’s handling of one-shot functions (authored by nomeata).
Improve the Occurrence Analyzer’s handling of one-shot functions
Feb 6 2017, 8:39 PM
nomeata added a comment to D3073: Do not drop dead code in the desugarer.

@nomeata looks like there's a perf regression though in the testsuite (T4029).

Feb 6 2017, 7:41 PM

Feb 5 2017

nomeata raised a concern with rGHCfbcef83a3aa1: Use proper primitives in Utils.Binary.

https://perf.haskell.org/ghc/#revision/fbcef83a3aa130d976a201f2a21c5afc5a43d000 reports some speed-ups, but also that some stats in the test suite might need to be adjusted

Feb 5 2017, 10:13 PM
nomeata accepted rGHCa2f39da0461b: Add liftA2 to Applicative class.

https://perf.haskell.org/ghc/#revision/a2f39da0461b5da62a9020b0d98a1ce2765dd700 reports some speed-ups!

Feb 5 2017, 10:12 PM
nomeata committed rGHC4f92864d0404: Improve the Occurrence Analyzer’s handling of one-shot functions (authored by nomeata).
Improve the Occurrence Analyzer’s handling of one-shot functions
Feb 5 2017, 3:47 PM
nomeata retitled D3089: Improve the Occurrence Analyzer’s handling of one-shot functions from to Improve the Occurrence Analyzer’s handling of one-shot functions.
Feb 5 2017, 3:46 PM
nomeata committed rGHC88dcbc63ae34: Bind educated guess: count OneShotInfos in occ_one_shots (authored by nomeata).
Bind educated guess: count OneShotInfos in occ_one_shots
Feb 5 2017, 11:46 AM
nomeata committed rGHC6564330e7be1: Bind educated guess: count OneShotInfos in occ_one_shots (authored by nomeata).
Bind educated guess: count OneShotInfos in occ_one_shots
Feb 5 2017, 11:35 AM
nomeata committed rGHC4a78993377b2: Improve the Occurrence Analyzer’s handling of one-shot functions (authored by nomeata).
Improve the Occurrence Analyzer’s handling of one-shot functions
Feb 5 2017, 11:28 AM
nomeata committed rGHCa9dc47a1b995: Improve the Occurrence Analyzer’s handling of one-shot functions (authored by nomeata).
Improve the Occurrence Analyzer’s handling of one-shot functions
Feb 5 2017, 9:54 AM

Feb 4 2017

nomeata added a comment to D3073: Do not drop dead code in the desugarer.

From a very brief look at this, and assuming for a moment the plugin architecture allowed for hooks prior to the desugarer, would this change still be necessary

Feb 4 2017, 11:07 PM
nomeata added a comment to D3073: Do not drop dead code in the desugarer.

perf.haskell.org reports the absence of significant regressions: https://perf.haskell.org/ghc/#revision/b59c2de7abe3cd4e046f11c3536ba8e7137c4f84

Feb 4 2017, 11:06 PM