nomeata (Joachim Breitner)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

Badges

User Since
Jun 6 2014, 3:01 AM (141 w, 5 d)
Availability
Available

Recent Activity

Yesterday

nomeata added a comment to rGHC27a2854124cc: A number of Typeable wibbles from review.

Runtime performance improvements in fasta and lambda:
https://perf.haskell.org/ghc/#revision/27a2854124cc1c101570104501beea234a4ee921
A bit weird, isn’t it?

Tue, Feb 21, 8:56 AM

Thu, Feb 16

nomeata added a comment to D3141: testsuite: Move echoing commands in make invocations to VERBOSE=5.
In D3141#92010, @Phyx wrote:

I rather not have another environment variable to do another thing, as it's already hard to remember what to use for the various things.

Thu, Feb 16, 10:17 AM

Wed, Feb 15

nomeata requested changes to D3141: testsuite: Move echoing commands in make invocations to VERBOSE=5.

I have doubts about the VERBOSE setting. If increasing the verbosity can make tests fail, then that is a harsh violation of the principle of least surprise!

Wed, Feb 15, 10:40 PM
nomeata raised a concern with rGHCa3704409acc3: Fix various issues with testsuite code on Windows.

Sorry to jump on this after it has been commited, but I have doubts about the VERBOSE setting. If increasing the verbosity can make tests fail, then that is a harsh violation of the principle of least surprise!

Wed, Feb 15, 10:40 PM

Sat, Feb 11

nomeata updated the diff for D3089: Improve the Occurrence Analyzer’s handling of one-shot functions.

Also recenter haddock.compiler

Sat, Feb 11, 12:46 PM
nomeata updated the diff for D3089: Improve the Occurrence Analyzer’s handling of one-shot functions.

Update perf data.

Sat, Feb 11, 12:44 PM
nomeata updated the diff for D3089: Improve the Occurrence Analyzer’s handling of one-shot functions.

Rebase to master

Sat, Feb 11, 10:49 AM
nomeata added inline comments to D3055: WIP Add HeapView functionality.
Sat, Feb 11, 9:23 AM

Thu, Feb 9

nomeata added a comment to rGHCb9bebd8cedcc: Implement addCStub in template-haskell..

https://travis-ci.org/ghc/ghc/builds/200216540 looks good, thanks!

Thu, Feb 9, 10:39 PM
nomeata added inline comments to D810: Ensure that Literals are in range.
Thu, Feb 9, 5:39 PM
nomeata added a comment to rGHCb9bebd8cedcc: Implement addCStub in template-haskell..

Hmm, baking in the output of a tool that is not under our control, has several implementations and may of course change its error message from versin to version does not strike me as very useful in the long run. Maybe just grep the output for TH_addCStub2.hs:13:13, assuming that at least that part stays stable?

Thu, Feb 9, 2:30 PM
nomeata raised a concern with rGHCb9bebd8cedcc: Implement addCStub in template-haskell..

On Travis, this causes test cases to fail: https://api.travis-ci.org/jobs/200040619/log.txt?deansi=true

Thu, Feb 9, 12:19 PM
nomeata committed rGHCd266aac9586d: Library docs: Document the order for sort and sortOn. (authored by Alexander Kjeldaas <ak@formalprivacy.com>).
Library docs: Document the order for sort and sortOn.
Thu, Feb 9, 12:17 PM

Wed, Feb 8

nomeata committed rGHC8c4c084f858c: Travis experiment: Try “quickest” build flavor (authored by nomeata).
Travis experiment: Try “quickest” build flavor
Wed, Feb 8, 1:38 PM

Tue, Feb 7

nomeata committed rGHC2f31711f9291: Travis experiment: bump boot GHC (authored by nomeata).
Travis experiment: bump boot GHC
Tue, Feb 7, 3:39 PM
nomeata committed rGHC8882aa770588: Improve the Occurrence Analyzer’s handling of one-shot functions (authored by nomeata).
Improve the Occurrence Analyzer’s handling of one-shot functions
Tue, Feb 7, 3:35 PM
nomeata added a comment to rGHCb8f58d79ee3e: Another improvement to SetLevels.

I see different runtime results from nofib:
https://perf.haskell.org/ghc/#revision/b8f58d79ee3e34840beeea2fab846a9f47bff21a

Tue, Feb 7, 2:06 PM
nomeata committed rGHCa0440d8d12b0: Travis experiment: bump boot GHC (authored by nomeata).
Travis experiment: bump boot GHC
Tue, Feb 7, 1:54 PM
nomeata committed rGHCc729798f5a07: Travis experiment: try trusty (authored by nomeata).
Travis experiment: try trusty
Tue, Feb 7, 1:54 PM
nomeata committed rGHCf9a0639fe00c: Travis experiment: language: generic (authored by nomeata).
Travis experiment: language: generic
Tue, Feb 7, 1:51 PM
nomeata committed rGHC6fce907bf573: Travis experiment: Build in non-container environment (authored by nomeata).
Travis experiment: Build in non-container environment
Tue, Feb 7, 1:51 PM
nomeata committed rGHC5ce39f6395ef: Add Wredundant-constraints to list of flags excluded from -Wall (authored by siddhanathan).
Add Wredundant-constraints to list of flags excluded from -Wall
Tue, Feb 7, 10:20 AM
nomeata committed rGHC078beea9e970: Docs: Fix typo in glasgow_exts.rst (authored by DanielG).
Docs: Fix typo in glasgow_exts.rst
Tue, Feb 7, 10:18 AM
nomeata updated the diff for D3089: Improve the Occurrence Analyzer’s handling of one-shot functions.

s/info/information/

Tue, Feb 7, 9:59 AM
nomeata updated the diff for D3089: Improve the Occurrence Analyzer’s handling of one-shot functions.

Improve notes

Tue, Feb 7, 9:36 AM

Mon, Feb 6

nomeata committed rGHC52fc50301279: Improve the Occurrence Analyzer’s handling of one-shot functions (authored by nomeata).
Improve the Occurrence Analyzer’s handling of one-shot functions
Mon, Feb 6, 8:39 PM
nomeata added a comment to D3073: Do not drop dead code in the desugarer.

@nomeata looks like there's a perf regression though in the testsuite (T4029).

Mon, Feb 6, 7:41 PM

Sun, Feb 5

nomeata raised a concern with rGHCfbcef83a3aa1: Use proper primitives in Utils.Binary.

https://perf.haskell.org/ghc/#revision/fbcef83a3aa130d976a201f2a21c5afc5a43d000 reports some speed-ups, but also that some stats in the test suite might need to be adjusted

Sun, Feb 5, 10:13 PM
nomeata accepted rGHCa2f39da0461b: Add liftA2 to Applicative class.

https://perf.haskell.org/ghc/#revision/a2f39da0461b5da62a9020b0d98a1ce2765dd700 reports some speed-ups!

Sun, Feb 5, 10:12 PM
nomeata committed rGHC4f92864d0404: Improve the Occurrence Analyzer’s handling of one-shot functions (authored by nomeata).
Improve the Occurrence Analyzer’s handling of one-shot functions
Sun, Feb 5, 3:47 PM
nomeata retitled D3089: Improve the Occurrence Analyzer’s handling of one-shot functions from to Improve the Occurrence Analyzer’s handling of one-shot functions.
Sun, Feb 5, 3:46 PM
nomeata committed rGHC88dcbc63ae34: Bind educated guess: count OneShotInfos in occ_one_shots (authored by nomeata).
Bind educated guess: count OneShotInfos in occ_one_shots
Sun, Feb 5, 11:46 AM
nomeata committed rGHC6564330e7be1: Bind educated guess: count OneShotInfos in occ_one_shots (authored by nomeata).
Bind educated guess: count OneShotInfos in occ_one_shots
Sun, Feb 5, 11:35 AM
nomeata committed rGHC4a78993377b2: Improve the Occurrence Analyzer’s handling of one-shot functions (authored by nomeata).
Improve the Occurrence Analyzer’s handling of one-shot functions
Sun, Feb 5, 11:28 AM
nomeata committed rGHCa9dc47a1b995: Improve the Occurrence Analyzer’s handling of one-shot functions (authored by nomeata).
Improve the Occurrence Analyzer’s handling of one-shot functions
Sun, Feb 5, 9:54 AM

Sat, Feb 4

nomeata added a comment to D3073: Do not drop dead code in the desugarer.

From a very brief look at this, and assuming for a moment the plugin architecture allowed for hooks prior to the desugarer, would this change still be necessary

Sat, Feb 4, 11:07 PM
nomeata added a comment to D3073: Do not drop dead code in the desugarer.

perf.haskell.org reports the absence of significant regressions: https://perf.haskell.org/ghc/#revision/b59c2de7abe3cd4e046f11c3536ba8e7137c4f84

Sat, Feb 4, 11:06 PM
nomeata accepted rGHC283acec1d730: Make split sections by default work again.

Whoohoo! Build time down by 13%. And sizes down. Well spotted!

Sat, Feb 4, 11:05 PM
nomeata committed rGHC88950a11b9df: Ensure that Literals in an Int# case are in range (authored by nomeata).
Ensure that Literals in an Int# case are in range
Sat, Feb 4, 10:25 PM
nomeata updated the diff for D810: Ensure that Literals are in range.

Redone the patch, and make mkMachInt etc. do the wrapping.

Sat, Feb 4, 10:24 PM
nomeata updated the diff for D810: Ensure that Literals are in range.

Rebase to master

Sat, Feb 4, 9:30 PM
nomeata committed rGHC54b9b064fc79: Expose cseExpr from CSE (authored by nomeata).
Expose cseExpr from CSE
Sat, Feb 4, 5:09 PM
nomeata committed rGHC82121357f5bf: New internal dynamic flag: Very aggressive inlining (authored by nomeata).
New internal dynamic flag: Very aggressive inlining
Sat, Feb 4, 5:09 PM
nomeata closed D3069: Two new knobs for GHC API users by committing rGHC82121357f5bf: New internal dynamic flag: Very aggressive inlining.
Sat, Feb 4, 5:09 PM
nomeata committed rGHCb59c2de7abe3: Do not drop dead code in the desugarer (authored by nomeata).
Do not drop dead code in the desugarer
Sat, Feb 4, 8:14 AM
nomeata committed rGHC122c65592718: Expose cseExpr from CSE (authored by nomeata).
Expose cseExpr from CSE
Sat, Feb 4, 8:14 AM
nomeata committed rGHC6d5efdb9ab64: New internal dynamic flag: Very aggressive inlining (authored by nomeata).
New internal dynamic flag: Very aggressive inlining
Sat, Feb 4, 8:14 AM
nomeata added a comment to D3073: Do not drop dead code in the desugarer.

I disagree with that review.

Sat, Feb 4, 8:13 AM

Fri, Feb 3

nomeata added a comment to D3073: Do not drop dead code in the desugarer.

I have a better approach now. Do you like it?

Fri, Feb 3, 9:13 PM
nomeata updated the diff for D3073: Do not drop dead code in the desugarer.

New approach to not dropping dead code in the desugarer

Fri, Feb 3, 9:11 PM
nomeata retitled D3073: Do not drop dead code in the desugarer from to Do not drop dead code in the desugarer.
Fri, Feb 3, 5:30 PM
nomeata added a comment to D3069: Two new knobs for GHC API users.

I'm curious: what is a hypothetical API user going to do with this flag? It seems likely that inlining everything possible would essentially never be a win in any realistic program due to code bloat. Is there something I'm missing here?

Fri, Feb 3, 4:26 PM
nomeata added a comment to D3069: Two new knobs for GHC API users.

Obviously I’ll push these as separate commits; but I’d like to get a quick nod from someone else before I do so.

Fri, Feb 3, 3:29 PM
nomeata retitled D3069: Two new knobs for GHC API users from to Two new knobs for GHC API users.
Fri, Feb 3, 3:04 PM
nomeata committed rGHCc2becee48aa7: Bump performance mark for T9020 (authored by nomeata).
Bump performance mark for T9020
Fri, Feb 3, 10:39 AM
nomeata committed rGHC09b8332df924: Get rid of ProbOneShot (authored by nomeata).
Get rid of ProbOneShot
Fri, Feb 3, 10:39 AM
nomeata closed D3067: Get rid of ProbOneShot by committing rGHC09b8332df924: Get rid of ProbOneShot.
Fri, Feb 3, 10:39 AM

Thu, Feb 2

nomeata updated the diff for D3067: Get rid of ProbOneShot.

Clean up some code is simpler without ProbOneShot

Thu, Feb 2, 7:38 PM
nomeata retitled D3067: Get rid of ProbOneShot from to Get rid of ProbOneShot.
Thu, Feb 2, 7:31 PM
nomeata committed rGHC4c5af213a9ff: Get rid of ProbOneShot (authored by nomeata).
Get rid of ProbOneShot
Thu, Feb 2, 2:32 PM
nomeata committed rGHC99857796bdac: Get rid of ProbOneShot (authored by nomeata).
Get rid of ProbOneShot
Thu, Feb 2, 11:54 AM
nomeata committed rGHCd8ac64e782b8: Add a testcase for #13227 (authored by nomeata).
Add a testcase for #13227
Thu, Feb 2, 11:06 AM

Wed, Feb 1

nomeata added a comment to D3055: WIP Add HeapView functionality.

Does this have to live in a separate library? Can it not be part of base (which already has a bunch of low-level GHC. modules) or ghc-prim?

Wed, Feb 1, 2:54 PM
nomeata added a comment to D3055: WIP Add HeapView functionality.
In D3055#89677, @erikd wrote:

@nomeata What do you thing of moving the haskell definition of those types to a different file (say GHC.Exts.HeapView.Closures`) and then generating that file automatically from Closure.h? Doing it this way means no test is needed.

Wed, Feb 1, 2:33 PM
nomeata added inline comments to D3055: WIP Add HeapView functionality.
Wed, Feb 1, 9:13 AM

Tue, Jan 24

nomeata raised a concern with rGHC53e2e70a4778: Ensure that scrutinee constant folding wraps numbers.

This had a reproducible effect of increasing runtime of fasta by +4.47%. Are runtime effects here expected?

Tue, Jan 24, 8:46 PM

Jan 19 2017

nomeata accepted rGHCbf1e1f3206f8: Add explicit foldMap implementation for Maybe.

Good job, tests/alloc/T13056 improves by 4%!

Jan 19 2017, 11:14 PM

Jan 17 2017

nomeata accepted rGHC715be013d405: Typos in manual and comments [ci skip].
Jan 17 2017, 11:09 AM

Jan 6 2017

nomeata added a comment to D2871: Add a CSE pass to Stg (#9291).

Well, I expect programs that use Monad (Either s) or Functor (Either s) or similar constructs to benefit, but we might not just have them in nofib.

Jan 6 2017, 11:58 AM
nomeata added a comment to D2871: Add a CSE pass to Stg (#9291).

Yes, at https://perf.haskell.org/ghc/#revision/19d5c7312bf0ad9ae764168132aecf3696d5410b. Unfortunately, nothing significant shows up. When I tested it locally, I saw some relevant improvements with the runtime of binary-trees. I continue to conclude that our benchmark situation sucks when it comes to producing hard evidence.

Jan 6 2017, 11:07 AM

Jan 5 2017

nomeata committed rGHC19d5c7312bf0: Add a CSE pass to Stg (#9291) (authored by nomeata).
Add a CSE pass to Stg (#9291)
Jan 5 2017, 8:18 AM
nomeata closed D2871: Add a CSE pass to Stg (#9291) by committing rGHC19d5c7312bf0: Add a CSE pass to Stg (#9291).
Jan 5 2017, 8:18 AM
nomeata updated the diff for D2871: Add a CSE pass to Stg (#9291).

Pushed version of the DR

Jan 5 2017, 8:17 AM
nomeata added a comment to D2871: Add a CSE pass to Stg (#9291).

Is this -O2 only? Or all -O? It's probably pretty cheap.

Jan 5 2017, 7:52 AM
nomeata added a comment to D2871: Add a CSE pass to Stg (#9291).

Yes, I think so as well. Will do that in a second.

Jan 5 2017, 7:52 AM

Dec 29 2016

nomeata committed rGHCaac08a0f3744: Add a CSE pass to Stg (#9291) (authored by nomeata).
Add a CSE pass to Stg (#9291)
Dec 29 2016, 12:27 PM

Dec 27 2016

nomeata committed rGHCd2788ab551fb: Expand I/O CP in comments (authored by nomeata).
Expand I/O CP in comments
Dec 27 2016, 2:42 AM

Dec 26 2016

nomeata committed rGHC815099cce8f1: CallArity: Use exprIsCheap to detect thunks (authored by nomeata).
CallArity: Use exprIsCheap to detect thunks
Dec 26 2016, 2:34 PM
nomeata committed rGHC0f5b9a6509eb: CallArity: Use exprIsCheap to detect thunks (authored by nomeata).
CallArity: Use exprIsCheap to detect thunks
Dec 26 2016, 3:29 AM
nomeata added a comment to D2871: Add a CSE pass to Stg (#9291).

Marking a few inline-comments as “Done”

Dec 26 2016, 3:24 AM
nomeata updated the diff for D2871: Add a CSE pass to Stg (#9291).

Do not rewrite case binders to trivial case scrutinees

Dec 26 2016, 3:22 AM
nomeata committed rGHC899cf3b9ed30: CallArity: Use exprIsCheap to detect thunks (authored by nomeata).
CallArity: Use exprIsCheap to detect thunks
Dec 26 2016, 3:18 AM
nomeata committed rGHC1cf987f5df07: Typo in Call Arity notes (authored by nomeata).
Typo in Call Arity notes
Dec 26 2016, 3:18 AM

Dec 25 2016

nomeata committed rGHCe81ce911ded9: Add a CSE pass to Stg (#9291) (authored by nomeata).
Add a CSE pass to Stg (#9291)
Dec 25 2016, 8:26 AM

Dec 23 2016

nomeata committed rGHC49664e9699c8: Stg CSE: Try handle trivial cases less intrusively (authored by nomeata).
Stg CSE: Try handle trivial cases less intrusively
Dec 23 2016, 3:43 PM
nomeata committed rGHC42c63be6f89d: More work on STG CSE (authored by nomeata).
More work on STG CSE
Dec 23 2016, 8:11 AM
nomeata committed rGHC4065fee08d60: Add a CSE pass to Stg (#9291) (authored by nomeata).
Add a CSE pass to Stg (#9291)
Dec 23 2016, 8:11 AM
nomeata updated the diff for D2871: Add a CSE pass to Stg (#9291).

More notes, use of In… and Out… types, and more careful handling of renaming due to shadowing. (Is shadowing a thing in STG?)

Dec 23 2016, 8:11 AM

Dec 20 2016

nomeata committed rGHCd8a45b9a2f71: Add a CSE pass to Stg (#9291) (authored by nomeata).
Add a CSE pass to Stg (#9291)
Dec 20 2016, 1:39 AM
nomeata updated D2871: Add a CSE pass to Stg (#9291).
Dec 20 2016, 1:16 AM
nomeata updated the diff for D2871: Add a CSE pass to Stg (#9291).

Use a record for the env, general notes fine-tuning

Dec 20 2016, 1:07 AM
nomeata added a comment to D2871: Add a CSE pass to Stg (#9291).

Thanks for the review, Simon. I did change the env to a record, and refined some notes.

Dec 20 2016, 1:07 AM
nomeata accepted rGHCd3b546b1a605: Scrutinee Constant Folding.

Ok, discussion continues at https://phabricator.haskell.org/D2883.

Dec 20 2016, 12:44 AM

Dec 19 2016

nomeata added a comment to rGHCd3b546b1a605: Scrutinee Constant Folding.

@hsyl20 I am still not convinced that this is a useful test case. If case folding would suddenly stop working, would this test case really catch the regression?

Dec 19 2016, 12:33 PM
nomeata updated the diff for D2871: Add a CSE pass to Stg (#9291).

Fix in comments

Dec 19 2016, 12:19 PM
nomeata added inline comments to D2871: Add a CSE pass to Stg (#9291).
Dec 19 2016, 12:19 PM

Dec 17 2016

nomeata updated the diff for D2871: Add a CSE pass to Stg (#9291).

Rebase onto master

Dec 17 2016, 4:04 PM
nomeata updated D2871: Add a CSE pass to Stg (#9291).
Dec 17 2016, 4:04 PM
nomeata committed rGHCc33f5af6b6ff: Add a CSE pass to Stg (#9291) (authored by nomeata).
Add a CSE pass to Stg (#9291)
Dec 17 2016, 4:04 PM
nomeata updated D2871: Add a CSE pass to Stg (#9291).
Dec 17 2016, 3:34 PM