niteria (Bartosz Nitka)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 13 2014, 5:19 PM (226 w, 5 d)

Recent Activity

Jul 6 2018

niteria added a comment to D4263: [RTS] Add loadNativeObj and unloadNativeObj.

@simonmar: I'm sorry for dropping the ball on this. Feel free to finish it, I don't know when I will get to it.

Jul 6 2018, 11:41 AM

Jun 3 2018

niteria accepted D4780: a naive but simple fix to resolve trac ticket 15207, because currently stgcrun.c when compiled with gcc and then assembled with clang/apple as/llvm assembler fails..

LGTM. Sorry about the breakage, it worked on my Mac, so I assumed it'd be fine, but we lose nothing by gating on !darwin.

Jun 3 2018, 4:52 PM

May 17 2018

niteria committed rGHC5d3b15ecbf17: Fix unwinding of C -> Haskell FFI calls with -threaded (2nd try) (authored by niteria).
Fix unwinding of C -> Haskell FFI calls with -threaded (2nd try)
May 17 2018, 10:29 AM
niteria closed D4694: Fix unwinding of C -> Haskell FFI calls with -threaded (2nd try).
May 17 2018, 10:29 AM
niteria added a comment to D4694: Fix unwinding of C -> Haskell FFI calls with -threaded (2nd try).

According to local testing this doesn't break more than is currently broken, I will land this.

May 17 2018, 10:10 AM

May 16 2018

niteria added a comment to D4694: Fix unwinding of C -> Haskell FFI calls with -threaded (2nd try).

I *think* this doesn't break Windows, but I'm still running local tests.

May 16 2018, 11:40 AM

May 14 2018

niteria updated the diff for D4694: Fix unwinding of C -> Haskell FFI calls with -threaded (2nd try).

update comment

May 14 2018, 4:05 PM
niteria created D4694: Fix unwinding of C -> Haskell FFI calls with -threaded (2nd try).
May 14 2018, 4:05 PM

May 12 2018

niteria committed rGHCbec2e71e9869: Revert "Fix unwinding of C -> Haskell FFI calls with -threaded" (authored by niteria).
Revert "Fix unwinding of C -> Haskell FFI calls with -threaded"
May 12 2018, 9:32 AM
niteria added a reverting change for rGHCcb5c2fe87596: Fix unwinding of C -> Haskell FFI calls with -threaded: rGHCbec2e71e9869: Revert "Fix unwinding of C -> Haskell FFI calls with -threaded".
May 12 2018, 9:32 AM
niteria added a comment to rGHCcb5c2fe87596: Fix unwinding of C -> Haskell FFI calls with -threaded.

:( Sorry about that, I will revert.

May 12 2018, 9:30 AM

May 11 2018

niteria committed rGHCcb5c2fe87596: Fix unwinding of C -> Haskell FFI calls with -threaded (authored by niteria).
Fix unwinding of C -> Haskell FFI calls with -threaded
May 11 2018, 6:02 AM
niteria closed D4666: Fix unwinding of C -> Haskell FFI calls with -threaded.
May 11 2018, 6:02 AM

May 10 2018

niteria updated the diff for D4666: Fix unwinding of C -> Haskell FFI calls with -threaded.

rebase

May 10 2018, 9:54 AM
niteria updated the diff for D4666: Fix unwinding of C -> Haskell FFI calls with -threaded.

eat extra newlines

May 10 2018, 9:47 AM
niteria updated the diff for D4666: Fix unwinding of C -> Haskell FFI calls with -threaded.
  • move str/xstr to RtsUtils.h
  • add a diagram
  • (hopefully) make it unambiguous what calls what and what is unwound
May 10 2018, 9:42 AM

May 4 2018

niteria committed rGHC56974323ed42: Normalize T14999 test output some more (authored by niteria).
Normalize T14999 test output some more
May 4 2018, 5:13 AM
niteria added a comment to D4606: Correctly add unwinding info in manifestSp and makeFixupBlocks.

@osa1: I just pushed https://phabricator.haskell.org/rGHC56974323ed427988059b5153bb43c694358cbb9b, hopefully that's enough.

May 4 2018, 5:13 AM
niteria added a comment to D4606: Correctly add unwinding info in manifestSp and makeFixupBlocks.

Sigh, looks like your readelf puts an extra newline there. I will try collapsing consecutive newlines to normalize.

May 4 2018, 4:12 AM
niteria added a comment to D4666: Fix unwinding of C -> Haskell FFI calls with -threaded.

Why is it that we apparently do not need to unwind rbp in the non-threaded runtime?

May 4 2018, 1:46 AM

May 3 2018

niteria updated the diff for D4666: Fix unwinding of C -> Haskell FFI calls with -threaded.

3*7=21

May 3 2018, 4:21 PM
niteria created D4666: Fix unwinding of C -> Haskell FFI calls with -threaded.
May 3 2018, 4:21 PM

May 2 2018

niteria added a comment to D4649: storageAddCapabilities: fix bug in updating nursery pointers.

This might be the same as Trac #13793.

May 2 2018, 9:47 AM

Apr 29 2018

niteria added a comment to D4606: Correctly add unwinding info in manifestSp and makeFixupBlocks.

Yes, ready to give it a last review and merge if nothing is off.

Apr 29 2018, 10:08 AM

Apr 23 2018

niteria updated the diff for D4606: Correctly add unwinding info in manifestSp and makeFixupBlocks.

more debugging tips

Apr 23 2018, 11:31 AM
niteria added inline comments to D4606: Correctly add unwinding info in manifestSp and makeFixupBlocks.
Apr 23 2018, 9:09 AM
niteria updated the diff for D4606: Correctly add unwinding info in manifestSp and makeFixupBlocks.
  • Y => Y-1
  • skip the test when gdb or readelf unavailable
Apr 23 2018, 9:05 AM

Apr 19 2018

niteria retitled D4606: Correctly add unwinding info in manifestSp and makeFixupBlocks from Correctly add unwinding info in manifestSp to Correctly add unwinding info in manifestSp and makeFixupBlocks.
Apr 19 2018, 9:04 AM
niteria updated the diff for D4606: Correctly add unwinding info in manifestSp and makeFixupBlocks.
  • Fix cmm lint errors on T14779b that D4559 would detect
  • Consolidate the logic for adding Sp unwind in maybeAddSpAdj
Apr 19 2018, 9:04 AM
niteria updated the diff for D4606: Correctly add unwinding info in manifestSp and makeFixupBlocks.

only run on 64bit linux

Apr 19 2018, 7:01 AM
niteria updated the diff for D4606: Correctly add unwinding info in manifestSp and makeFixupBlocks.

normalize whitespace in test

Apr 19 2018, 6:50 AM
niteria planned changes to D4606: Correctly add unwinding info in manifestSp and makeFixupBlocks.

whitespace differences in test output

Apr 19 2018, 3:19 AM

Apr 18 2018

niteria added inline comments to D4606: Correctly add unwinding info in manifestSp and makeFixupBlocks.
Apr 18 2018, 9:07 AM
niteria requested review of D4606: Correctly add unwinding info in manifestSp and makeFixupBlocks.
Apr 18 2018, 9:05 AM

Mar 21 2018

niteria updated the diff for D4496: Don't refer to blocks in debug info when -g1.

broader condition

Mar 21 2018, 5:58 AM

Mar 11 2018

niteria added inline comments to D4496: Don't refer to blocks in debug info when -g1.
Mar 11 2018, 8:36 PM
niteria created D4496: Don't refer to blocks in debug info when -g1.
Mar 11 2018, 7:45 PM

Mar 9 2018

niteria added inline comments to D1959: ErrUtils: Add timings to compiler phases.
Mar 9 2018, 11:10 AM

Mar 6 2018

niteria committed rGHC9bccfcdbbf97: Correct -g flag description (authored by niteria).
Correct -g flag description
Mar 6 2018, 8:28 AM
niteria closed D4471: Correct -g flag description.
Mar 6 2018, 8:28 AM
niteria committed rGHC5bc195a2cadd: Allow top level ticked string literals (authored by niteria).
Allow top level ticked string literals
Mar 6 2018, 7:57 AM
niteria added a reverting change for rGHCf5b275a239d2: Don't tick top-level string literals: rGHC5bc195a2cadd: Allow top level ticked string literals.
Mar 6 2018, 7:57 AM
niteria closed D4470: Allow top level ticked string literals.
Mar 6 2018, 7:57 AM

Mar 5 2018

niteria updated the diff for D4470: Allow top level ticked string literals.

Remove "It was because we produced a ticked top-level primitive string." as
that's misleading now.

Mar 5 2018, 3:50 PM
niteria updated the diff for D4470: Allow top level ticked string literals.

address @simonpj's comments

Mar 5 2018, 3:19 PM
niteria updated the test plan for D4470: Allow top level ticked string literals.
Mar 5 2018, 2:59 PM
niteria updated the diff for D4470: Allow top level ticked string literals.
  • rebase
  • drop Data.Data comments
  • add a (scary) test from Trac #14868
Mar 5 2018, 2:33 PM
niteria added inline comments to D4470: Allow top level ticked string literals.
Mar 5 2018, 2:31 PM
niteria created D4471: Correct -g flag description.
Mar 5 2018, 1:13 PM
niteria abandoned D4423: Don't tick floated top-level primitive strings.

In favor of https://phabricator.haskell.org/D4470

Mar 5 2018, 12:46 PM
niteria created D4470: Allow top level ticked string literals.
Mar 5 2018, 12:46 PM

Mar 2 2018

niteria committed rGHCb8f03bbe16af: Cache the fingerprint of sOpt_P (authored by niteria).
Cache the fingerprint of sOpt_P
Mar 2 2018, 6:42 AM
niteria closed D4445: Cache the fingerprint of sOpt_P.
Mar 2 2018, 6:42 AM

Mar 1 2018

niteria added a comment to rGHCd675a354e8db: Better stats for T5837.

The build for this change failed on this exact test. It looks like the CI doesn't agree that it improved.

Mar 1 2018, 12:41 PM
niteria updated the diff for D4445: Cache the fingerprint of sOpt_P.

try to please the testrunner

Mar 1 2018, 8:34 AM

Feb 27 2018

niteria planned changes to D4423: Don't tick floated top-level primitive strings.

I'll follow https://ghc.haskell.org/trac/ghc/ticket/14779#comment:15

Feb 27 2018, 10:33 AM
niteria added a comment to D4445: Cache the fingerprint of sOpt_P.

I think T14697 fails because the {{1..10000}} expansion fails. That sounds fixable.

Feb 27 2018, 8:54 AM
niteria updated the diff for D4445: Cache the fingerprint of sOpt_P.

fix comment

Feb 27 2018, 8:09 AM
niteria added a comment to D4445: Cache the fingerprint of sOpt_P.

Hmm, interesting, for the test failures on Linux I get completely different numbers.

Feb 27 2018, 8:09 AM

Feb 26 2018

niteria updated the diff for D4445: Cache the fingerprint of sOpt_P.

actually set the expected value in the test

Feb 26 2018, 3:40 AM

Feb 23 2018

niteria updated the diff for D4445: Cache the fingerprint of sOpt_P.

fix spurious whitespace change

Feb 23 2018, 8:33 AM
niteria created D4445: Cache the fingerprint of sOpt_P.
Feb 23 2018, 8:28 AM

Feb 22 2018

niteria abandoned D4424: Don't inline top-level primitive string literals.
Feb 22 2018, 7:05 AM

Feb 20 2018

niteria added a comment to D4424: Don't inline top-level primitive string literals.

What is the motivation for this change? Is there a Trac ticket for it?

Feb 20 2018, 5:38 AM

Feb 19 2018

niteria added a comment to D4424: Don't inline top-level primitive string literals.

I run nofib a couple of time and it's hard to see anything among the noise P175. I don't *think* I have cpu scaling on, is usually less noisy for other people?

Feb 19 2018, 3:16 PM
niteria updated the diff for D4424: Don't inline top-level primitive string literals.

update test output

Feb 19 2018, 12:14 PM
niteria updated the summary of D4424: Don't inline top-level primitive string literals.
Feb 19 2018, 11:17 AM
niteria created D4424: Don't inline top-level primitive string literals.
Feb 19 2018, 11:15 AM
niteria created D4423: Don't tick floated top-level primitive strings.
Feb 19 2018, 10:45 AM

Feb 8 2018

niteria requested changes to D3925: CoreLint: Assert that string literals aren't tick'd.
Feb 8 2018, 8:36 AM
niteria added inline comments to D3925: CoreLint: Assert that string literals aren't tick'd.
Feb 8 2018, 8:36 AM

Feb 6 2018

niteria committed rGHCd2511e3b6156: Compute the union of imp_finsts on the side (authored by niteria).
Compute the union of imp_finsts on the side
Feb 6 2018, 11:58 AM
niteria closed D4369: Compute the union of imp_finsts on the side.
Feb 6 2018, 11:58 AM

Feb 2 2018

niteria created D4369: Compute the union of imp_finsts on the side.
Feb 2 2018, 10:13 AM

Jan 23 2018

niteria committed rGHCf00ddea96cc8: Allocate less in plus_mod_dep (authored by niteria).
Allocate less in plus_mod_dep
Jan 23 2018, 4:59 PM
niteria closed D4332: Allocate less in plus_mod_dep.
Jan 23 2018, 4:59 PM
niteria updated the diff for D4332: Allocate less in plus_mod_dep.

address comments

Jan 23 2018, 4:55 PM

Jan 21 2018

niteria created D4332: Allocate less in plus_mod_dep.
Jan 21 2018, 12:01 PM

Jan 20 2018

niteria updated the diff for D4329: Use IntSet in Dataflow.

remove outdated comment

Jan 20 2018, 12:30 PM
niteria created D4329: Use IntSet in Dataflow.
Jan 20 2018, 12:24 PM

Jan 15 2018

niteria added a comment to D4299: Add flag -fno-it.

I'm not sure I understand why it is leaking. Surely we should be able to expunge the old binding after it is shadowed, no?

Jan 15 2018, 3:01 PM
niteria committed rGHCcf2c029ccdb9: Fix quadratic behavior of prepareAlts (authored by niteria).
Fix quadratic behavior of prepareAlts
Jan 15 2018, 2:36 PM
niteria closed D4307: Fix quadratic behavior of prepareAlts.
Jan 15 2018, 2:36 PM
niteria added inline comments to D4307: Fix quadratic behavior of prepareAlts.
Jan 15 2018, 5:04 AM
niteria added inline comments to D4307: Fix quadratic behavior of prepareAlts.
Jan 15 2018, 4:11 AM

Jan 14 2018

niteria created D4307: Fix quadratic behavior of prepareAlts.
Jan 14 2018, 4:08 PM

Jan 10 2018

niteria committed rGHCdbdf77d92c9c: Lift constructor tag allocation out of a loop (authored by niteria).
Lift constructor tag allocation out of a loop
Jan 10 2018, 7:52 AM
niteria closed D4289: Lift constructor tag allocation out of a loop.
Jan 10 2018, 7:51 AM
niteria updated the diff for D4289: Lift constructor tag allocation out of a loop.

@simonpj's comments

Jan 10 2018, 6:11 AM
niteria updated the Trac tickets for D4289: Lift constructor tag allocation out of a loop.
Jan 10 2018, 4:53 AM

Jan 5 2018

niteria updated the diff for D4289: Lift constructor tag allocation out of a loop.

add a test

Jan 5 2018, 1:22 PM
niteria updated the test plan for D4289: Lift constructor tag allocation out of a loop.
Jan 5 2018, 12:34 PM
niteria updated the summary of D4289: Lift constructor tag allocation out of a loop.
Jan 5 2018, 11:09 AM
niteria created D4289: Lift constructor tag allocation out of a loop.
Jan 5 2018, 11:08 AM

Jan 4 2018

niteria committed rGHC6c34824434a6: Cache the number of data cons in DataTyCon and SumTyCon (authored by niteria).
Cache the number of data cons in DataTyCon and SumTyCon
Jan 4 2018, 8:05 AM
niteria closed D4131: Cache the number of data cons in DataTyCon and SumTyCon.
Jan 4 2018, 8:05 AM
niteria updated the diff for D4131: Cache the number of data cons in DataTyCon and SumTyCon.

use only mkDataTyConRhs

Jan 4 2018, 7:16 AM

Jan 3 2018

niteria updated the diff for D4131: Cache the number of data cons in DataTyCon and SumTyCon.
Jan 3 2018, 5:37 PM

Dec 26 2017

niteria committed rGHCe19b6464cc8e: Compute InScopeSet in substInteractiveContext (authored by niteria).
Compute InScopeSet in substInteractiveContext
Dec 26 2017, 6:29 AM
niteria closed D3431: Compute InScopeSet in substInteractiveContext.
Dec 26 2017, 6:29 AM