- User Since
- Jan 22 2018, 8:56 PM (56 w, 2 d)
Wed, Feb 6
Last update only shows the latest changes. I think the problem is that my commits are interleaved with other commits in the git log. Is there a way to arc diff specific commits?
Here are the compared nofib results:
- Fixing validation errors
- Rebased to master
- Updating D5041: Make the types of expressions accessible in the API.
- Enter a brief description of the changes included in this update.
- The first line is used as subject, next lines as comment.
- If you intended to create a new revision, use:
- $ arc diff --create
Tue, Feb 5
I rebased to master and ran the tests:
Sun, Jan 27
Yes, I would like to integrate this. I need some pointers on what changes are requested to finish.
Aug 29 2018
- Fixing library submodules
- Fixing utils/haddock version
Aug 8 2018
I think this version should be ok, but I don't really understand the build errors.
Aug 7 2018
- Fixing validation errors
Aug 3 2018
Jul 12 2018
I like the changes, it clears the design of the plugins.
Feb 5 2018
- Removing unintended changes.
- Updated design of renamed action and user guide.
Feb 2 2018
I can see the motivation for the rename plugin. Would a more general mechanism be a DynFlags modification function Module -> DynFlags -> DynFlags which could set/unset options on a per module basis, running at the start of the pipeline.
I think that the more general version could be dangerous for a plugin author not familiar with the internal workings of GHC. Besides, I think there is no flag that instructs type checking to keep the renamed AST. I think needsRenamedSyntax is better for this task.
I don't accept this. If you're writing a plugin you have to know what you're doing anyway as you are making arbitrary changes to the source program. Adding a flag to control this isn't hard.
Jan 26 2018
- Re-adding parentheses and describing interface plugin usage
- Created LoadedPlugin datatype. Added tests for modification using the plugin. Removed SAFE annotation when plugin is applied. Removed unnecessary initializePlugins call.
- Written a note and extended the plugins section in user manual.
- Fixing lint warnings.
Jan 25 2018
I think now I got the commit range right. I tried to get rid of the library changes, but I'm not experienced with git submodules. Can you give me some hint how to reverse them?
- Reversing unintended changes in Main.hs and libraries.
- Added GhcPrelude import to new hs-boot files, removed unnecessary imports.
Jan 24 2018
- Fixed the loading of plugins
- Fixed lint warnings.
In this version the plugins are loaded too early, so OPTIONS_GHC pragmas cannot add new plugins. I nearly solved this issue and will upload a new version tomorrow.
This version does not work correctly in all cases, but I wanted to upload the first version of my solution for others to see. Sorry if it is not the right place.