nboldi (Boldizsár Németh)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 22 2018, 8:56 PM (56 w, 2 d)

Recent Activity

Wed, Feb 6

nboldi added a comment to D5041: Make the types of expressions accessible in the API..

Last update only shows the latest changes. I think the problem is that my commits are interleaved with other commits in the git log. Is there a way to arc diff specific commits?

Wed, Feb 6, 12:49 AM
nboldi added a comment to D5041: Make the types of expressions accessible in the API..

Here are the compared nofib results:

Wed, Feb 6, 12:44 AM
nboldi updated the diff for D5041: Make the types of expressions accessible in the API..
  • Fixing validation errors
  • Rebased to master
  1. Updating D5041: Make the types of expressions accessible in the API.
  2. Enter a brief description of the changes included in this update.
  3. The first line is used as subject, next lines as comment.
  4. If you intended to create a new revision, use:
  5. $ arc diff --create
Wed, Feb 6, 12:42 AM

Tue, Feb 5

nboldi added a comment to D5041: Make the types of expressions accessible in the API..

I rebased to master and ran the tests:

Tue, Feb 5, 1:47 AM

Sun, Jan 27

nboldi added a comment to D5041: Make the types of expressions accessible in the API..

Yes, I would like to integrate this. I need some pointers on what changes are requested to finish.

Sun, Jan 27, 4:27 AM

Aug 29 2018

nboldi updated the diff for D5041: Make the types of expressions accessible in the API..
  • Fixing library submodules
Aug 29 2018, 6:49 AM
nboldi updated the diff for D5041: Make the types of expressions accessible in the API..
  • Fixing utils/haddock version
Aug 29 2018, 6:22 AM

Aug 8 2018

nboldi added a comment to D5041: Make the types of expressions accessible in the API..

I think this version should be ok, but I don't really understand the build errors.

Aug 8 2018, 8:49 AM

Aug 7 2018

nboldi updated the diff for D5041: Make the types of expressions accessible in the API..
  • Fixing validation errors
Aug 7 2018, 9:03 AM
nboldi added a comment to D5041: Make the types of expressions accessible in the API..

I'm rather confused; didn't the discussion on the ticket indicate that this approach would be too costly in the typical compilation case to be acceptable?

Aug 7 2018, 4:00 AM

Aug 3 2018

nboldi created D5041: Make the types of expressions accessible in the API..
Aug 3 2018, 8:49 AM

Jul 12 2018

nboldi accepted D4947: Run the renamed source plugin after each HsGroup.

I like the changes, it clears the design of the plugins.

Jul 12 2018, 5:19 AM

Feb 5 2018

nboldi updated the diff for D4342: Extended the plugin system to run plugins on the parsed, typechecked representation, splices to be run and interfaces that are loaded. Pre-loading the plugins..
  • Removing unintended changes.
Feb 5 2018, 1:28 AM
nboldi updated the diff for D4342: Extended the plugin system to run plugins on the parsed, typechecked representation, splices to be run and interfaces that are loaded. Pre-loading the plugins..
  • Updated design of renamed action and user guide.
Feb 5 2018, 12:58 AM

Feb 2 2018

nboldi added a comment to D4342: Extended the plugin system to run plugins on the parsed, typechecked representation, splices to be run and interfaces that are loaded. Pre-loading the plugins..

I can see the motivation for the rename plugin. Would a more general mechanism be a DynFlags modification function Module -> DynFlags -> DynFlags which could set/unset options on a per module basis, running at the start of the pipeline.

I think that the more general version could be dangerous for a plugin author not familiar with the internal workings of GHC. Besides, I think there is no flag that instructs type checking to keep the renamed AST. I think needsRenamedSyntax is better for this task.

I don't accept this. If you're writing a plugin you have to know what you're doing anyway as you are making arbitrary changes to the source program. Adding a flag to control this isn't hard.

Feb 2 2018, 12:11 AM

Jan 26 2018

nboldi updated the diff for D4342: Extended the plugin system to run plugins on the parsed, typechecked representation, splices to be run and interfaces that are loaded. Pre-loading the plugins..
  • Re-adding parentheses and describing interface plugin usage
Jan 26 2018, 7:20 AM
nboldi added inline comments to D4342: Extended the plugin system to run plugins on the parsed, typechecked representation, splices to be run and interfaces that are loaded. Pre-loading the plugins..
Jan 26 2018, 5:42 AM
nboldi updated the diff for D4342: Extended the plugin system to run plugins on the parsed, typechecked representation, splices to be run and interfaces that are loaded. Pre-loading the plugins..
  • Created LoadedPlugin datatype. Added tests for modification using the plugin. Removed SAFE annotation when plugin is applied. Removed unnecessary initializePlugins call.
  • Written a note and extended the plugins section in user manual.
  • Fixing lint warnings.
Jan 26 2018, 5:36 AM

Jan 25 2018

nboldi added a comment to D4342: Extended the plugin system to run plugins on the parsed, typechecked representation, splices to be run and interfaces that are loaded. Pre-loading the plugins..
Jan 25 2018, 7:20 PM
nboldi added a comment to D4342: Extended the plugin system to run plugins on the parsed, typechecked representation, splices to be run and interfaces that are loaded. Pre-loading the plugins..

Thank you!

Jan 25 2018, 8:04 AM
nboldi added a comment to D4342: Extended the plugin system to run plugins on the parsed, typechecked representation, splices to be run and interfaces that are loaded. Pre-loading the plugins..

I think now I got the commit range right. I tried to get rid of the library changes, but I'm not experienced with git submodules. Can you give me some hint how to reverse them?

Jan 25 2018, 7:38 AM
nboldi updated the diff for D4342: Extended the plugin system to run plugins on the parsed, typechecked representation, splices to be run and interfaces that are loaded. Pre-loading the plugins..
  • Reversing unintended changes in Main.hs and libraries.
Jan 25 2018, 7:22 AM
nboldi updated the diff for D4342: Extended the plugin system to run plugins on the parsed, typechecked representation, splices to be run and interfaces that are loaded. Pre-loading the plugins..
  • Added GhcPrelude import to new hs-boot files, removed unnecessary imports.
Jan 25 2018, 7:19 AM

Jan 24 2018

nboldi updated the summary of D4342: Extended the plugin system to run plugins on the parsed, typechecked representation, splices to be run and interfaces that are loaded. Pre-loading the plugins..
Jan 24 2018, 7:32 PM
nboldi updated the diff for D4342: Extended the plugin system to run plugins on the parsed, typechecked representation, splices to be run and interfaces that are loaded. Pre-loading the plugins..
  • Fixed the loading of plugins
  • Fixed lint warnings.
Jan 24 2018, 7:27 PM
nboldi added a comment to D4342: Extended the plugin system to run plugins on the parsed, typechecked representation, splices to be run and interfaces that are loaded. Pre-loading the plugins..

In this version the plugins are loaded too early, so OPTIONS_GHC pragmas cannot add new plugins. I nearly solved this issue and will upload a new version tomorrow.

Jan 24 2018, 6:06 AM
nboldi added a comment to D4342: Extended the plugin system to run plugins on the parsed, typechecked representation, splices to be run and interfaces that are loaded. Pre-loading the plugins..

This version does not work correctly in all cases, but I wanted to upload the first version of my solution for others to see. Sorry if it is not the right place.

Jan 24 2018, 3:40 AM

Jan 23 2018

nboldi updated the summary of D4342: Extended the plugin system to run plugins on the parsed, typechecked representation, splices to be run and interfaces that are loaded. Pre-loading the plugins..
Jan 23 2018, 8:09 PM
nboldi created D4342: Extended the plugin system to run plugins on the parsed, typechecked representation, splices to be run and interfaces that are loaded. Pre-loading the plugins..
Jan 23 2018, 8:06 PM