mynguyen (My Nguyen)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 16 2018, 12:53 PM (13 w, 4 d)

Recent Activity

Dec 17 2018

mynguyen added a comment to D5229: Visible kind application.

Regrettable changes can be observed in tests T12447, UncurryNamed, WildcardInstantiations, T11670,...to name but a few. I also saw this while I was running the testsuite:

Dec 17 2018, 11:30 PM
mynguyen updated the diff for D5229: Visible kind application.
  1. Updating D5229: Visible kind application
Dec 17 2018, 11:28 PM

Dec 10 2018

mynguyen added inline comments to D5229: Visible kind application.
Dec 10 2018, 9:13 PM

Dec 6 2018

mynguyen added inline comments to D5229: Visible kind application.
Dec 6 2018, 11:04 PM
mynguyen updated the diff for D5229: Visible kind application.
  1. Updating D5229: Visible kind application
Dec 6 2018, 11:09 AM

Dec 5 2018

mynguyen added inline comments to D5229: Visible kind application.
Dec 5 2018, 4:18 PM
mynguyen added inline comments to D5229: Visible kind application.
Dec 5 2018, 4:04 PM
mynguyen added inline comments to D5229: Visible kind application.
Dec 5 2018, 12:11 AM
mynguyen updated the diff for D5229: Visible kind application.
  1. Updating D5229: Visible kind application
Dec 5 2018, 12:07 AM

Dec 4 2018

mynguyen added inline comments to D5229: Visible kind application.
Dec 4 2018, 9:12 PM
mynguyen added inline comments to D5229: Visible kind application.
Dec 4 2018, 9:49 AM
mynguyen added inline comments to D5229: Visible kind application.
Dec 4 2018, 9:10 AM
mynguyen added a comment to D5229: Visible kind application.

ooops, somehow I can't add inline comment...But here is the failed outputs for:

Dec 4 2018, 2:29 AM
mynguyen added a reviewer for D5229: Visible kind application: Iceland_jack.
Dec 4 2018, 2:21 AM
mynguyen added inline comments to D5229: Visible kind application.
Dec 4 2018, 2:20 AM
mynguyen added a reviewer for D5229: Visible kind application: RyanGlScott.
Dec 4 2018, 2:11 AM
mynguyen updated the Trac tickets for D5229: Visible kind application.
Dec 4 2018, 2:11 AM
mynguyen updated the diff for D5229: Visible kind application.
  1. Updating D5229: Visible kind application
Dec 4 2018, 2:04 AM

Oct 18 2018

mynguyen added a comment to D5229: Visible kind application.

I see two possible solutions:

  1. Currently, '[] is parsed as an empty list, which means it's type-checked as a list. This causes trouble for visible kind application, because lists expect to get their type from their elements. We could instead parse it as a ntgtycon by adding SIMPLEQUOTE '[' ']' as a production there and changing the list production from atype to require at least one type in the brackets. If '[] is parsed into an HsTyVar, then type-checking will automatically work.
  2. Special-case the empty list in the type-checker.

I will special-case [] in the type-checker.

Oct 18 2018, 2:17 PM
mynguyen added a comment to D5229: Visible kind application.

I'm not sure which commit your haddock submodule corresponds to. You've put 5035a25c2020a04f124b05221b209c57403f1cab, but that doesn't appear to live anywhere in your fork of Haddock. (The latest commit on the wip/kind-app branch is c6b2f4a3bd96a28c7a2ec34108e4705f9b4a8d59, for comparison.)

Sorry @RyanGlScott, I didn't know how to respond to direct comments until now. 5035a25c2020a04f124b05221b209c57403f1cab is the head commit on my local wip/kind-app after I rebased my utils/haddock to origin/ghc-head, so technically my local utils/haddock has diverged from my github fork. I don't see why it would matter, but seems like it does. I'm not very good with git and would appreciate any help with this!

  1. Even though it's possible to use the value-level empty list constructor [] with visible type applications (e.g., [] @Bool), it's impossible to do the same with the promoted empty list constructor:

Thanks for the catch! I'll go with adding a special case for [] in the typechecker, although I agree this is not the most elegant solution.

Oct 18 2018, 2:15 PM
mynguyen added inline comments to D5229: Visible kind application.
Oct 18 2018, 1:51 PM
mynguyen added inline comments to D5229: Visible kind application.
Oct 18 2018, 1:02 AM
mynguyen added inline comments to D5229: Visible kind application.
Oct 18 2018, 12:49 AM

Oct 17 2018

mynguyen updated the summary of D5229: Visible kind application.
Oct 17 2018, 3:44 AM
mynguyen updated the diff for D5229: Visible kind application.

My rebase last time was missing some commits

Oct 17 2018, 3:36 AM
mynguyen created D5229: Visible kind application.
Oct 17 2018, 1:44 AM