mpickering (Matthew Pickering)Administrator
User

Projects

User Details

User Since
Dec 18 2014, 1:25 PM (208 w, 4 d)
Roles
Administrator

Recent Activity

Today

mpickering added a comment to D5458: Hadrian: Add support for building Stage3.

I think that stageLibraries also needs to be used in configurePackage to make sure you end up needing packages from the right stage. That occurs here: https://github.com/ghc/ghc/blob/ed69f8bd1fd4b84b62bb4f10eef7f76e537be07b/hadrian/src/Hadrian/Haskell/Cabal/Parse.hs#L116. Note that this is already wrong for stage 2 thereby preventing me from building Haddock >:(.

Tue, Dec 18, 2:20 AM

Yesterday

mpickering added a comment to D5458: Hadrian: Add support for building Stage3.

Still not ready. There is a problem with packageDbPath resolving to the wrong thing in some places. This stems from the fact that packageDbPath used to have a call to min in which clearly does the wrong thing and relies on the fact that we didn't used to build any libraries with the stage2 compiler. I haven't managed yet to work out how to precisely fix this though.

Mon, Dec 17, 4:01 PM

Sun, Dec 16

mpickering added a comment to D5458: Hadrian: Add support for building Stage3.

Thanks Andrey, I managed to apply your suggestions and things appear to work smoothly still. I'll try a clean rebuild overnight.

Sun, Dec 16, 4:20 PM
mpickering updated the diff for D5458: Hadrian: Add support for building Stage3.
  • Define and use stageLibaries
  • Resolve some more stage confusion
Sun, Dec 16, 4:15 PM
mpickering added inline comments to D5458: Hadrian: Add support for building Stage3.
Sun, Dec 16, 3:40 PM
mpickering added inline comments to D5458: Hadrian: Add support for building Stage3.
Sun, Dec 16, 2:43 PM
mpickering added inline comments to D5458: Hadrian: Add support for building Stage3.
Sun, Dec 16, 12:45 PM
mpickering added a reviewer for D5458: Hadrian: Add support for building Stage3: snowleopard.
Sun, Dec 16, 12:28 PM
mpickering created D5458: Hadrian: Add support for building Stage3.
Sun, Dec 16, 12:27 PM

Fri, Dec 14

mpickering added a comment to D5454: Hadrian: introduce userDefaultFlavour, making default flavour overridable.

Is there somewhere to view a rendered up-to-date copy of the documentation? If there's not then this doesn't seem like a great idea.

Fri, Dec 14, 11:15 AM
mpickering added a comment to D5454: Hadrian: introduce userDefaultFlavour, making default flavour overridable.

Thanks Alp, this will be useful. Please can we update the wiki page as well when this is merged.

Fri, Dec 14, 11:03 AM

Fri, Dec 7

mpickering added a comment to D5286: Run typed splices in the zonker.

CI passes: https://circleci.com/gh/ghc/ghc-diffs/1038

Fri, Dec 7, 9:46 AM
mpickering updated the diff for D5286: Run typed splices in the zonker.
  • Try to fix build ordering
Fri, Dec 7, 8:57 AM
mpickering added a comment to D5286: Run typed splices in the zonker.

I had a call with Simon and he suggested two changes which I have implemented now. The finaliser bug should also be fixed.

Fri, Dec 7, 8:28 AM
mpickering updated the diff for D5286: Run typed splices in the zonker.
  • Simplify
  • Remove unused variable
  • Remove extra arguments
  • zonk after calling tcTopSpliceExpr
  • Note and Richard's other comments
  • Remove diff churn
  • Remove blank line
  • Remove blank line
  • More formatting
  • Store arguments to runTopSplice rather than whole TcM action
  • Run and zonk finalisers
Fri, Dec 7, 8:18 AM

Tue, Nov 27

mpickering added a comment to D5360: Add -fno-safe-haskell flag.

Updated with Ben's comments now.

Tue, Nov 27, 3:58 AM
mpickering updated the diff for D5360: Add -fno-safe-haskell flag.
  • Address Ben's comments
Tue, Nov 27, 3:57 AM

Thu, Nov 22

mpickering added a comment to D2343: [WIP] llvmGen: Produce debug information metadata for functions.

The subprograms field has been removed. https://smlnj-gitlab.cs.uchicago.edu/manticore/llvm/commit/4eeaa0da042055b1cd17b339e2dde518a3026033

Thu, Nov 22, 9:06 AM
mpickering added a comment to D2343: [WIP] llvmGen: Produce debug information metadata for functions.

This still applies cleanly to master fwiw.

Thu, Nov 22, 8:30 AM
mpickering added a comment to D5360: Add -fno-safe-haskell flag.

CI passes: https://circleci.com/gh/ghc/ghc/11719?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link

Thu, Nov 22, 6:49 AM

Tue, Nov 20

mpickering updated the diff for D5360: Add -fno-safe-haskell flag.
  • fix test
Tue, Nov 20, 10:25 AM
mpickering updated the diff for D5360: Add -fno-safe-haskell flag.
  • Stop infinite loop
Tue, Nov 20, 10:19 AM
mpickering created D5360: Add -fno-safe-haskell flag.
Tue, Nov 20, 6:01 AM

Mon, Nov 19

mpickering committed rGHC7e570676bd0a: eventlog: Log the current stack size when stack overflows (authored by mpickering).
eventlog: Log the current stack size when stack overflows
Mon, Nov 19, 5:35 AM
mpickering closed D5287: eventlog: Log the current stack size when stack overflows.
Mon, Nov 19, 5:35 AM
mpickering awarded D5351: Remove explicit recursion in retainer profiling (fixes #14758) a Yellow Medal token.
Mon, Nov 19, 5:29 AM
mpickering updated subscribers of D5355: hadrian: make it possible to run the testsuite with quickest and quick.

Thanks @alpmestan

Mon, Nov 19, 5:19 AM

Sun, Nov 18

mpickering added a reviewer for D5352: Add -fcompact-holes.: RyanGlScott.
Sun, Nov 18, 9:23 AM

Nov 13 2018

mpickering planned changes to D5286: Run typed splices in the zonker.

Still one problem with finalisers getting run in the wrong place.

Nov 13 2018, 5:52 AM
mpickering updated the diff for D5286: Run typed splices in the zonker.
  • Remove blank line
  • Remove blank line
  • More formatting
Nov 13 2018, 3:39 AM
mpickering updated the diff for D5286: Run typed splices in the zonker.
  • Simplify
  • Remove unused variable
  • Remove extra arguments
  • zonk after calling tcTopSpliceExpr
  • Remove merge artefact
  • Note and Richard's other comments
  • Remove diff churn
Nov 13 2018, 3:35 AM

Nov 12 2018

mpickering updated the diff for D5286: Run typed splices in the zonker.
  • zonk after calling tcTopSpliceExpr
  • Remove merge artefact
  • Note and Richard's other comments
Nov 12 2018, 4:27 PM
mpickering added a comment to D5286: Run typed splices in the zonker.

If you look at the first version of this patch, I did as you suggested and persisted all the original parts but I think it was more complicated. You still need to persist TcLclEnv and so end up with an import cycle and several {-# SOURCE #-} imports in the zonker.

Nov 12 2018, 12:09 PM
mpickering updated the diff for D5286: Run typed splices in the zonker.
  • Remove extra arguments
Nov 12 2018, 8:25 AM

Nov 9 2018

mpickering updated the diff for D5286: Run typed splices in the zonker.
  • Simplify
  • Remove unused variable
Nov 9 2018, 2:42 PM
mpickering updated the diff for D5287: eventlog: Log the current stack size when stack overflows.
  • indentation
  • Remove redundant conditional
  • fix link
Nov 9 2018, 2:57 AM
mpickering accepted D5308: Respect naming conventions in module RnUnbound.hs in fix for #15611.

Thanks!

Nov 9 2018, 2:37 AM

Nov 8 2018

mpickering resigned from D42: Fix hWaitForInput not being interruptible (#8684)..
Nov 8 2018, 4:26 PM · GHC
mpickering resigned from D3047: Implement cheapBuild.
Nov 8 2018, 4:25 PM
mpickering added a comment to D3834: Point to FunDeps documentation on Haskell wiki.

Would be good to land this still I think?

Nov 8 2018, 4:24 PM
mpickering resigned from D4257: add variants of `finiteBitSize` and friends which take `Proxy`.
Nov 8 2018, 4:24 PM · GHC
mpickering added a comment to D4533: Don't overwrite the set log_action when using --interactive.

Probably still needs fixing but there appear to be no consumers for -ddump-json to care.

Nov 8 2018, 4:22 PM
mpickering abandoned D4279: Look through casts when calculating dict arg discount.

I think this was fixed in 954cbc7c106a20639960f55ebb85c5c972652d41

Nov 8 2018, 4:20 PM
mpickering abandoned D2929: Always expose unfoldings for overloaded functions.
Nov 8 2018, 4:15 PM
mpickering abandoned D3322: WIP: Reduce stderr output by passing -v0 to ghc-pkg.
Nov 8 2018, 4:11 PM
mpickering requested changes to D5299: Fix recompilation checking of pure plugins.

Looks plausible but I need to understand what Ben meant in his comment above before understanding the logic in detail.

Nov 8 2018, 4:02 PM
mpickering requested changes to D5308: Respect naming conventions in module RnUnbound.hs in fix for #15611.

Two comments.

Nov 8 2018, 3:35 PM
mpickering created D5311: iserv: Fix typo in cabal file.
Nov 8 2018, 9:38 AM

Nov 6 2018

mpickering accepted D5162: GHCi does not need a main function.

Thanks @RolandSenn, do you need to change the title of the revision as well?

Nov 6 2018, 3:35 PM
mpickering added a comment to D5285: Warn about unused packages.

You could make the flag imply -fforce-recomp but if we don't understand how the patch works for the partial recompilation case then I would suggest that we don't understand what the code is doing well enough.

Nov 6 2018, 3:24 PM

Nov 5 2018

mpickering added a comment to D5287: eventlog: Log the current stack size when stack overflows.

I removed that branch now I understand what is going on more.

Nov 5 2018, 3:40 AM
mpickering updated the diff for D5287: eventlog: Log the current stack size when stack overflows.
  • Remove redundant conditional
Nov 5 2018, 3:39 AM

Nov 2 2018

mpickering added a comment to D5287: eventlog: Log the current stack size when stack overflows.

In order for this to affect the eventlog you will need to modify EventLog.c:postSchedEvent. However, it looks like info2 may already be used for something else in the EVENT_STOP_THREAD case (although it's not clear what).

Nov 2 2018, 3:36 PM

Nov 1 2018

mpickering created D5291: Add test for #15437.
Nov 1 2018, 9:16 AM
mpickering added inline comments to D5162: GHCi does not need a main function.
Nov 1 2018, 4:04 AM

Oct 31 2018

mpickering added a comment to D5286: Run typed splices in the zonker.

The build works on hadrian but not on the old build system.

Oct 31 2018, 12:57 PM
mpickering updated the diff for D5286: Run typed splices in the zonker.
  • Revert "Add dummy dependency on GHC.Types"
Oct 31 2018, 9:49 AM
mpickering updated the diff for D5286: Run typed splices in the zonker.
  • Add dummy dependency on GHC.Types
Oct 31 2018, 9:33 AM
mpickering updated the diff for D5286: Run typed splices in the zonker.
  • Add Simon's test as well
Oct 31 2018, 8:13 AM
mpickering updated the diff for D5286: Run typed splices in the zonker.
  • Rename the spliced expression in the right context
Oct 31 2018, 8:09 AM
mpickering updated the diff for D5286: Run typed splices in the zonker.
  • rebase
Oct 31 2018, 6:12 AM
mpickering updated the diff for D5287: eventlog: Log the current stack size when stack overflows.
  • indentation
Oct 31 2018, 5:53 AM
mpickering created D5287: eventlog: Log the current stack size when stack overflows.
Oct 31 2018, 5:52 AM

Oct 30 2018

mpickering created D5286: Run typed splices in the zonker.
Oct 30 2018, 11:27 AM
mpickering added a comment to D5285: Warn about unused packages.

Does this work when a module is not recompiled because it has not changed? In other words, what is the result of running ghc with this flag enabled twice in a row?

Oct 30 2018, 11:10 AM

Oct 29 2018

mpickering requested changes to D5278: Support registering Plugins through the GHC API.

What is the problem with adding the plugin you want to load to the plugins field? There at least needs to be a comment explaining why it is necessary for these two different approaches which look very similar.

Oct 29 2018, 4:54 AM

Oct 25 2018

mpickering accepted D5264: users-guide: Fix formatting of eventlog format documentation.
Oct 25 2018, 5:26 PM

Oct 24 2018

mpickering accepted D5257: Fix some broken links (#15733).

Thanks a lot!

Oct 24 2018, 3:39 PM
mpickering added inline comments to D5221: Lower precedence for {-# UNPACK #-}.
Oct 24 2018, 3:36 PM

Oct 23 2018

mpickering committed rGHCb3bcd0ffe22f: Fix inability to find gmp.h when building concurrently (authored by mpickering).
Fix inability to find gmp.h when building concurrently
Oct 23 2018, 4:01 PM

Oct 20 2018

mpickering accepted D5248: Keep top-level names in typed TH quotes alive.

Thanks a lot Ryan.

Oct 20 2018, 10:08 AM

Oct 18 2018

mpickering accepted D5237: Plugins: Add documentation and missing exports.
Oct 18 2018, 9:50 AM

Oct 15 2018

mpickering added inline comments to D5223: WIP: Support profiling in ghc-heap.
Oct 15 2018, 2:33 PM

Oct 12 2018

mpickering added a comment to D5223: WIP: Support profiling in ghc-heap.
In D5223#143889, @osa1 wrote:

What does it show if you print return value of getClosureData con? I'm asking because you don't know in this code that con points to a constructor without any indirections. For example, GHC can float con to the top-level and make it a CAF, in which case con might point to a IND_STATIC, not to a CONSTR_1_0.

Oct 12 2018, 9:44 AM

Oct 11 2018

mpickering added a reviewer for D5223: WIP: Support profiling in ghc-heap: osa1.
Oct 11 2018, 3:54 PM
mpickering abandoned D4941: Mark ForeignPtr as representational.

We agreed at ICFP the best course of action was to patch the vector library.

Oct 11 2018, 3:53 PM
mpickering added a comment to D5223: WIP: Support profiling in ghc-heap.

I made some progress, it no longer prints out garbage but the result looks wrong.

Oct 11 2018, 11:39 AM
mpickering updated the diff for D5223: WIP: Support profiling in ghc-heap.
  • Correct the offset calculation, now working
Oct 11 2018, 11:34 AM
mpickering created D5223: WIP: Support profiling in ghc-heap.
Oct 11 2018, 9:53 AM

Oct 8 2018

mpickering added a comment to D5213: Backend plugins.

What have you been able to implement with these extension points? The Hsc looks suspicious.

Oct 8 2018, 9:33 AM · GHC

Oct 3 2018

mpickering added a comment to D5198: TH 'TExp' docs + 'liftedTyped'.

I was just suggest a comment indicating this future direction of travel not actually changing the existing patch. I don't know how this will impact code in the wild at all.

Oct 3 2018, 6:24 AM

Oct 2 2018

mpickering accepted D5198: TH 'TExp' docs + 'liftedTyped'.

Much better than before.

Oct 2 2018, 5:18 PM
mpickering added a comment to D5189: resolve T13704.

Thanks Daniel, can you clarify the difference between this patch and D5162?

I believe that D5162 only helps the situation with GHCi not having an implicit module Main(main) where, whereas this patch allows -main-is to specify an entry point to the program alternative to the name 'main' in the absence of a module header while compiling with ghc - the previous behaviour was to demand the existence of a function 'main'. If the explanation provided in docs/users_guide/bugs.rst is insuffient, please let me know.

Oct 2 2018, 4:30 AM

Sep 30 2018

mpickering accepted D5189: resolve T13704.

Looks straightforward to me.

Sep 30 2018, 4:39 PM
mpickering added a comment to D5189: resolve T13704.

Thanks Daniel, can you clarify the difference between this patch and D5162?

Sep 30 2018, 4:34 PM

Sep 28 2018

mpickering abandoned D4946: Release notes about source plugins.

The plugins have been unleashed.

Sep 28 2018, 9:10 PM

Sep 20 2018

mpickering added a comment to D5162: GHCi does not need a main function.

Perhaps you should modify check_main instead to not look for main when loading a module into GHCi.

Sep 20 2018, 3:18 PM
mpickering requested changes to D5162: GHCi does not need a main function.

I chatted with Omer about this. Can you try the suggestion I left inline?

Sep 20 2018, 9:45 AM

Sep 4 2018

mpickering abandoned D5128: Remove outdated note in StaticPointers documentation.
Sep 4 2018, 1:27 PM
mpickering created D5128: Remove outdated note in StaticPointers documentation.
Sep 4 2018, 8:21 AM

Aug 17 2018

mpickering added a comment to D5036: [TTG: Handling Source Locations] Foundation and Pat.

Seems like this patch would be a lot cleaner if a pattern synonym was defined for L. Having to use ViewPatterns everywhere is not very ergonomic.

Aug 17 2018, 7:08 AM

Aug 11 2018

mpickering accepted D5048: Filter plugin dylib locations.

This patch works for me.

Aug 11 2018, 3:05 AM

Aug 6 2018

mpickering accepted D5048: Filter plugin dylib locations.

I have tested that this patch fixes the panic.

Aug 6 2018, 10:25 AM

Aug 5 2018

mpickering accepted D5045: Refactor printMinimalImports (#15439).

Looks fine.

Aug 5 2018, 6:15 AM

Aug 3 2018

mpickering added inline comments to D5040: Surprising error message with bang pattern.
Aug 3 2018, 6:33 PM

Jul 17 2018

mpickering accepted D4937: Plugin dependency information is stored separately.
Jul 17 2018, 10:42 AM
mpickering accepted D4975: Fix a typo in related trac ticket number.

Thanks.

Jul 17 2018, 4:10 AM
mpickering added a comment to D4973: Add functions for splitting sigma types while preserving type synonyms.

Any reason you can't put these functions in Haddock itself?

Jul 17 2018, 2:05 AM

Jul 9 2018

mpickering updated the diff for D4946: Release notes about source plugins.
  • Update for comments
Jul 9 2018, 11:07 AM
mpickering updated the diff for D4927: Export findImportUsage and ImportDeclUsage.
  • Suggestion
Jul 9 2018, 10:59 AM