mpickering (Matthew Pickering)Administrator
User

Projects

User Details

User Since
Dec 18 2014, 1:25 PM (226 w, 5 d)
Roles
Administrator

Recent Activity

Mon, Apr 22

Marge Bot <ben+marge-bot@smart-cactus.org> committed rGHC1a7a329b983f: Correct off by one error in ghci +c (authored by mpickering).
Correct off by one error in ghci +c
Mon, Apr 22, 1:44 PM

Mon, Apr 8

Marge Bot <ben+marge-bot@smart-cactus.org> committed rGHC4dda2270d260: Use ./hadrian/ghci.sh in .ghcid (authored by mpickering).
Use ./hadrian/ghci.sh in .ghcid
Mon, Apr 8, 2:11 PM

Tue, Apr 2

Marge Bot <ben+marge-bot@smart-cactus.org> committed rGHC463a4e4de71b: Don't overwrite the set log_action when using --interactive (authored by mpickering).
Don't overwrite the set log_action when using --interactive
Tue, Apr 2, 3:56 PM
Marge Bot <ben+marge-bot@smart-cactus.org> committed rGHC6c27fd3517e1: Only build vanilla way in devel2 flavour (authored by mpickering).
Only build vanilla way in devel2 flavour
Tue, Apr 2, 3:56 PM
Marge Bot <ben+marge-bot@smart-cactus.org> committed rGHC8e07368faf50: Refactor ./hadrian/ghci.sh for better error messages (authored by mpickering).
Refactor ./hadrian/ghci.sh for better error messages
Tue, Apr 2, 3:53 PM
Marge Bot <ben+marge-bot@smart-cactus.org> committed rGHC200d65ef41ef: Check hadrian/ghci.sh script output to determine pass/fail (authored by mpickering).
Check hadrian/ghci.sh script output to determine pass/fail
Tue, Apr 2, 3:53 PM

Mar 22 2019

Marge Bot <ben+marge-bot@smart-cactus.org> committed rGHCdbe4557f0cfb: CI: Allow failure in packaging step (authored by mpickering).
CI: Allow failure in packaging step
Mar 22 2019, 10:01 AM

Mar 21 2019

Marge Bot <ben+marge-bot@smart-cactus.org> committed rGHC7092b2de6fb8: Only run check-makefiles.py linter in testsuite dir (authored by mpickering).
Only run check-makefiles.py linter in testsuite dir
Mar 21 2019, 11:01 PM
Marge Bot <ben+marge-bot@smart-cactus.org> committed rGHC322239de9555: Run linters on merge requests (authored by mpickering).
Run linters on merge requests
Mar 21 2019, 11:01 PM

Mar 20 2019

Marge Bot <ben+marge-bot@smart-cactus.org> committed rGHCc7a84a606731: Update .gitlab-ci.yml (authored by mpickering).
Update .gitlab-ci.yml
Mar 20 2019, 12:15 AM

Mar 12 2019

mpickering committed rGHCa0cab873b592: Revert: Update ci-images commit (authored by mpickering).
Revert: Update ci-images commit
Mar 12 2019, 9:59 AM
mpickering committed rGHC02ddf947f408: CI: Update ci-images commit (authored by mpickering).
CI: Update ci-images commit
Mar 12 2019, 9:59 AM
Marge Bot <ben+marge-bot@smart-cactus.org> committed rGHC5165378d8760: Remove trailing whitespace (authored by mpickering).
Remove trailing whitespace
Mar 12 2019, 8:16 AM
Marge Bot <ben+marge-bot@smart-cactus.org> committed rGHC72c455a4a1d2: CI: Add ghc-in-ghci build job (authored by mpickering).
CI: Add ghc-in-ghci build job
Mar 12 2019, 8:16 AM
Marge Bot <ben+marge-bot@smart-cactus.org> committed rGHCbb684e650166: Remove training whitespace (authored by mpickering).
Remove training whitespace
Mar 12 2019, 8:16 AM
Marge Bot <ben+marge-bot@smart-cactus.org> committed rGHC2d7dd0285bbc: Hadrian: Add ./hadrian/ghci.sh script for fast development feedback (authored by mpickering).
Hadrian: Add ./hadrian/ghci.sh script for fast development feedback
Mar 12 2019, 8:16 AM
Marge Bot <ben+marge-bot@smart-cactus.org> committed rGHC4cf2160afe0e: Hadrian: Fix rpath so shared objects work after being copied (authored by mpickering).
Hadrian: Fix rpath so shared objects work after being copied
Mar 12 2019, 8:15 AM
Marge Bot <ben+marge-bot@smart-cactus.org> committed rGHC705fa21d674a: Hadrian: Make makeRelativeNoSysLink total (authored by mpickering).
Hadrian: Make makeRelativeNoSysLink total
Mar 12 2019, 8:15 AM
Marge Bot <ben+marge-bot@smart-cactus.org> committed rGHC61264556d5c8: Hadrian: Make libsuf and distDir stage aware (authored by mpickering).
Hadrian: Make libsuf and distDir stage aware
Mar 12 2019, 8:15 AM
Marge Bot <ben+marge-bot@smart-cactus.org> committed rGHCb232231065f5: Hadrian: Allow passing CABFLAGS into build.cabal.sh (authored by mpickering).
Hadrian: Allow passing CABFLAGS into build.cabal.sh
Mar 12 2019, 8:15 AM

Mar 4 2019

Marge Bot <ben+marge-bot@smart-cactus.org> committed rGHCa990312e3d36: Exit with exit code 1 when tests unexpectedly pass (authored by mpickering).
Exit with exit code 1 when tests unexpectedly pass
Mar 4 2019, 3:09 PM
mpickering committed rGHCc25b135ff5b9: Fix exprIsConApp_maybe (authored by simonpj).
Fix exprIsConApp_maybe
Mar 4 2019, 1:08 PM
mpickering committed rGHC44ad7215a11c: Use validate flavour rather than devel2 for DEBUG CI job (authored by mpickering).
Use validate flavour rather than devel2 for DEBUG CI job
Mar 4 2019, 1:08 PM
mpickering committed rGHC0eb7cf03da37: Don't do binder-swap for GlobalIds (authored by simonpj).
Don't do binder-swap for GlobalIds
Mar 4 2019, 1:08 PM
mpickering committed rGHCa07f46ead660: Remove tcTyConUserTyVars (authored by simonpj).
Remove tcTyConUserTyVars
Mar 4 2019, 1:08 PM
Marge Bot <ben+marge-bot@smart-cactus.org> committed rGHCeda456f6f7ff: CI: Run `cabal update` before trying to build Hadrian (authored by mpickering).
CI: Run `cabal update` before trying to build Hadrian
Mar 4 2019, 1:07 PM
Marge Bot <ben+marge-bot@smart-cactus.org> committed rGHC69ebf5cb4592: HIE: Save module name and module exports (authored by mpickering).
HIE: Save module name and module exports
Mar 4 2019, 1:07 PM
Marge Bot <ben+marge-bot@smart-cactus.org> committed rGHC5544f6082d6e: Remove Simon's special number from typecheck/should_fail/all.t (authored by mpickering).
Remove Simon's special number from typecheck/should_fail/all.t
Mar 4 2019, 1:07 PM
Marge Bot <ben+marge-bot@smart-cactus.org> committed rGHC9b39597b66b6: Fix tests which were made to pass by "Make a smart mkAppTyM" (authored by mpickering).
Fix tests which were made to pass by "Make a smart mkAppTyM"
Mar 4 2019, 1:07 PM
Marge Bot <ben+marge-bot@smart-cactus.org> committed rGHC19626218566e: Implement -Wredundant-record-wildcards and -Wunused-record-wildcards (authored by mpickering).
Implement -Wredundant-record-wildcards and -Wunused-record-wildcards
Mar 4 2019, 1:06 PM
Marge Bot <ben+marge-bot@smart-cactus.org> committed rGHC6399965d7f16: Add explicit dependencies to cleanup-darwin (authored by mpickering).
Add explicit dependencies to cleanup-darwin
Mar 4 2019, 1:06 PM
Marge Bot <ben+marge-bot@smart-cactus.org> committed rGHC180c9762d456: testsuite: Report unexpected passes in junit output (authored by mpickering).
testsuite: Report unexpected passes in junit output
Mar 4 2019, 1:06 PM
Marge Bot <ben+marge-bot@smart-cactus.org> committed rGHCa48753bdbc99: Capture and simplify constraints arising from running typed splices (authored by mpickering).
Capture and simplify constraints arising from running typed splices
Mar 4 2019, 1:06 PM
Marge Bot <ben+marge-bot@smart-cactus.org> committed rGHC701cfb3e658b: Revert "gitlab-ci: More aggressive artifact expiration" (authored by mpickering).
Revert "gitlab-ci: More aggressive artifact expiration"
Mar 4 2019, 1:05 PM
Marge Bot <ben+marge-bot@smart-cactus.org> committed rGHC8dcd00cef778: Add werror function to Flavour.hs (authored by mpickering).
Add werror function to Flavour.hs
Mar 4 2019, 1:05 PM
Marge Bot <ben+marge-bot@smart-cactus.org> committed rGHC71dae4eb1a48: Turn on -Wno-unused-imports in make build system (authored by mpickering).
Turn on -Wno-unused-imports in make build system
Mar 4 2019, 1:05 PM
Marge Bot <ben+marge-bot@smart-cactus.org> committed rGHC2d79cd152161: Turn on -Werror when validating (authored by mpickering).
Turn on -Werror when validating
Mar 4 2019, 1:05 PM
mpickering committed rGHCdeab6d64eac0: Fix syntax in CODEOWNERS file (authored by mpickering).
Fix syntax in CODEOWNERS file
Mar 4 2019, 1:04 PM

Jan 21 2019

mpickering committed rGHC38d837a46ea8: Fix typo in TcRnTypes.hs [skip ci] (authored by mpickering).
Fix typo in TcRnTypes.hs [skip ci]
Jan 21 2019, 11:32 AM
mpickering added a comment to D5223: WIP: Support profiling in ghc-heap.

No, but the code is here for anyone to use if they wish.

Jan 21 2019, 2:36 AM

Jan 20 2019

Marge Bot <ben+marge-bot@smart-cactus.org> committed rGHC6e7aa5e937b1: Remove TODO in HsExpr (authored by mpickering).
Remove TODO in HsExpr
Jan 20 2019, 11:25 AM

Jan 18 2019

mpickering committed rGHCb14f54041eac: Fix typo in DsExpr (authored by mpickering).
Fix typo in DsExpr
Jan 18 2019, 2:13 PM

Jan 16 2019

mpickering committed rGHCc2455e647501: Run typed splices in the zonker (authored by mpickering).
Run typed splices in the zonker
Jan 16 2019, 12:24 AM
mpickering committed rGHC6486c6e49c53: Hadrian: Add support for building stage3 (authored by mpickering).
Hadrian: Add support for building stage3
Jan 16 2019, 12:24 AM

Jan 11 2019

mpickering abandoned D5286: Run typed splices in the zonker.

Merged now. https://gitlab.haskell.org/ghc/ghc/commit/c2455e647501c5a382861196b64df3dd05b620a2

Jan 11 2019, 4:24 AM

Jan 10 2019

mpickering added a comment to D5286: Run typed splices in the zonker.

Responded to new comments now.

Jan 10 2019, 6:00 AM
mpickering added inline comments to D5286: Run typed splices in the zonker.
Jan 10 2019, 5:58 AM
mpickering added a comment to D5286: Run typed splices in the zonker.

https://gitlab.haskell.org/ghc/ghc/merge_requests/106

Jan 10 2019, 5:50 AM
mpickering added a comment to D5286: Run typed splices in the zonker.

I applied Simon's suggestions apart from the one about TcGblEnv which I don't think made the code much clearer as it then wasn't obvious which bits to extract from the TcGblEnv to combine together with the other TcGblEnv in order to get the correct result.

Jan 10 2019, 5:47 AM

Dec 27 2018

mpickering added a comment to D5352: Add -fcompact-holes..

I put the patch on gitlab: https://gitlab.haskell.org/ghc/ghc/merge_requests/49

Dec 27 2018, 3:12 PM
mpickering added a comment to D5458: Hadrian: Add support for building Stage3.

This patch is now at https://gitlab.haskell.org/ghc/ghc/merge_requests/16

Dec 27 2018, 6:04 AM

Dec 23 2018

mpickering added a comment to D5458: Hadrian: Add support for building Stage3.

CI passes: https://gitlab.haskell.org/mpickering/ghc/pipelines/460

Dec 23 2018, 6:07 AM

Dec 22 2018

mpickering updated the diff for D5458: Hadrian: Add support for building Stage3.
  • remove merge artifacts
Dec 22 2018, 6:41 AM
mpickering added a comment to D5458: Hadrian: Add support for building Stage3.

I rebased. Last night I tested that the default build works correctly, I fixed the binary-dist target so that it doesn't build haddock with Stage2 libraries and also verified that test works correctly.

Dec 22 2018, 6:39 AM
mpickering updated the diff for D5458: Hadrian: Add support for building Stage3.
  • Define and use stageLibaries
  • Resolve some more stage confusion
  • fix build
  • Make things even more consistent
  • docs
  • Cleanup
  • Remove tabs
  • Andrey's suggestions
  • Implement the finalStage build option
  • Note about libffiContext
  • Fix lint
  • Alp comments
  • Use stage1 haddock
Dec 22 2018, 6:38 AM

Dec 21 2018

mpickering updated the diff for D5458: Hadrian: Add support for building Stage3.
  • Alp comments
Dec 21 2018, 7:06 AM
mpickering added inline comments to D5458: Hadrian: Add support for building Stage3.
Dec 21 2018, 6:53 AM
mpickering added a comment to D5458: Hadrian: Add support for building Stage3.

@snowleopard I implement the finalStage solution that @alpmestan suggested. It turned out quite nicely and meant we could remove the stage1Only option.

Dec 21 2018, 6:18 AM
mpickering updated the diff for D5458: Hadrian: Add support for building Stage3.
  • Implement the finalStage build option
  • Note about libffiContext
  • Fix lint
Dec 21 2018, 6:15 AM

Dec 20 2018

mpickering added a comment to D5458: Hadrian: Add support for building Stage3.
So I think that is all the packages?

There's a trivial way to find out, ls _build/stage2/lib/package.conf.d/.

Dec 20 2018, 12:12 PM
mpickering added a comment to D5458: Hadrian: Add support for building Stage3.

This is looking pretty good. Besides Andrey's outstanding question, I made a suggestion and have one request to add a TODO.

Can you clarify how far this gets you? I don't think the flavour matters much, so I won't ask whether you've built with different flavours. You said you get as far as building a working stage 3 compiler, right? And if you make stagePackages return the whole series of packages that a bindist would ship with, does that work too? Maybe you can just borrow that list from stage2Packages (or alternatively stagePackages Stage2)?

Dec 20 2018, 10:46 AM
mpickering added inline comments to D5458: Hadrian: Add support for building Stage3.
Dec 20 2018, 9:47 AM
mpickering updated the diff for D5458: Hadrian: Add support for building Stage3.
  • Andrey's suggestions
Dec 20 2018, 8:59 AM

Dec 19 2018

mpickering added a comment to D5458: Hadrian: Add support for building Stage3.

I completed a stage3 build from a clean tree successfully with this patch and a modified UserSettings.hs. Another review @snowleopard would be good seeing as it also involved some more radical changes now.

Dec 19 2018, 12:42 PM
mpickering updated the diff for D5458: Hadrian: Add support for building Stage3.
  • Remove tabs
Dec 19 2018, 11:30 AM
mpickering updated the diff for D5458: Hadrian: Add support for building Stage3.
  • Make things even more consistent
  • docs
  • cleanup
Dec 19 2018, 11:27 AM
mpickering updated the summary of D5458: Hadrian: Add support for building Stage3.
Dec 19 2018, 11:09 AM
mpickering planned changes to D5458: Hadrian: Add support for building Stage3.

Still broken in fact, see Trac #16069 for where the problem lies.

Dec 19 2018, 7:19 AM

Dec 18 2018

mpickering added a comment to D5458: Hadrian: Add support for building Stage3.

I think I fixed things up now. @alpmestan can you review?

Dec 18 2018, 11:45 AM
mpickering updated the diff for D5458: Hadrian: Add support for building Stage3.
  • fix build
Dec 18 2018, 11:44 AM
mpickering added a comment to D4953: Support for deprecating exports.

@DavidEichmann I think it will be much easier if you rebase the patch? This review cycle has been going on for a very long time now.

Dec 18 2018, 9:36 AM
mpickering added a comment to D5458: Hadrian: Add support for building Stage3.

I think that stageLibraries also needs to be used in configurePackage to make sure you end up needing packages from the right stage. That occurs here: https://github.com/ghc/ghc/blob/ed69f8bd1fd4b84b62bb4f10eef7f76e537be07b/hadrian/src/Hadrian/Haskell/Cabal/Parse.hs#L116. Note that this is already wrong for stage 2 thereby preventing me from building Haddock >:(.

Dec 18 2018, 2:20 AM

Dec 17 2018

mpickering added a comment to D5458: Hadrian: Add support for building Stage3.

Still not ready. There is a problem with packageDbPath resolving to the wrong thing in some places. This stems from the fact that packageDbPath used to have a call to min in which clearly does the wrong thing and relies on the fact that we didn't used to build any libraries with the stage2 compiler. I haven't managed yet to work out how to precisely fix this though.

Dec 17 2018, 4:01 PM

Dec 16 2018

mpickering added a comment to D5458: Hadrian: Add support for building Stage3.

Thanks Andrey, I managed to apply your suggestions and things appear to work smoothly still. I'll try a clean rebuild overnight.

Dec 16 2018, 4:20 PM
mpickering updated the diff for D5458: Hadrian: Add support for building Stage3.
  • Define and use stageLibaries
  • Resolve some more stage confusion
Dec 16 2018, 4:15 PM
mpickering added inline comments to D5458: Hadrian: Add support for building Stage3.
Dec 16 2018, 3:40 PM
mpickering added inline comments to D5458: Hadrian: Add support for building Stage3.
Dec 16 2018, 2:43 PM
mpickering added inline comments to D5458: Hadrian: Add support for building Stage3.
Dec 16 2018, 12:45 PM
mpickering added a reviewer for D5458: Hadrian: Add support for building Stage3: snowleopard.
Dec 16 2018, 12:28 PM
mpickering created D5458: Hadrian: Add support for building Stage3.
Dec 16 2018, 12:27 PM

Dec 14 2018

mpickering added a comment to D5454: Hadrian: introduce userDefaultFlavour, making default flavour overridable.

Is there somewhere to view a rendered up-to-date copy of the documentation? If there's not then this doesn't seem like a great idea.

Dec 14 2018, 11:15 AM
mpickering added a comment to D5454: Hadrian: introduce userDefaultFlavour, making default flavour overridable.

Thanks Alp, this will be useful. Please can we update the wiki page as well when this is merged.

Dec 14 2018, 11:03 AM

Dec 7 2018

mpickering added a comment to D5286: Run typed splices in the zonker.

CI passes: https://circleci.com/gh/ghc/ghc-diffs/1038

Dec 7 2018, 9:46 AM
mpickering updated the diff for D5286: Run typed splices in the zonker.
  • Try to fix build ordering
Dec 7 2018, 8:57 AM
mpickering added a comment to D5286: Run typed splices in the zonker.

I had a call with Simon and he suggested two changes which I have implemented now. The finaliser bug should also be fixed.

Dec 7 2018, 8:28 AM
mpickering updated the diff for D5286: Run typed splices in the zonker.
  • Simplify
  • Remove unused variable
  • Remove extra arguments
  • zonk after calling tcTopSpliceExpr
  • Note and Richard's other comments
  • Remove diff churn
  • Remove blank line
  • Remove blank line
  • More formatting
  • Store arguments to runTopSplice rather than whole TcM action
  • Run and zonk finalisers
Dec 7 2018, 8:18 AM

Nov 27 2018

mpickering added a comment to D5360: Add -fno-safe-haskell flag.

Updated with Ben's comments now.

Nov 27 2018, 3:58 AM
mpickering updated the diff for D5360: Add -fno-safe-haskell flag.
  • Address Ben's comments
Nov 27 2018, 3:57 AM

Nov 22 2018

mpickering added a comment to D2343: [WIP] llvmGen: Produce debug information metadata for functions.

The subprograms field has been removed. https://smlnj-gitlab.cs.uchicago.edu/manticore/llvm/commit/4eeaa0da042055b1cd17b339e2dde518a3026033

Nov 22 2018, 9:06 AM
mpickering added a comment to D2343: [WIP] llvmGen: Produce debug information metadata for functions.

This still applies cleanly to master fwiw.

Nov 22 2018, 8:30 AM
mpickering added a comment to D5360: Add -fno-safe-haskell flag.

CI passes: https://circleci.com/gh/ghc/ghc/11719?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link

Nov 22 2018, 6:49 AM

Nov 20 2018

mpickering updated the diff for D5360: Add -fno-safe-haskell flag.
  • fix test
Nov 20 2018, 10:25 AM
mpickering updated the diff for D5360: Add -fno-safe-haskell flag.
  • Stop infinite loop
Nov 20 2018, 10:19 AM
mpickering created D5360: Add -fno-safe-haskell flag.
Nov 20 2018, 6:01 AM

Nov 19 2018

mpickering committed rGHC7e570676bd0a: eventlog: Log the current stack size when stack overflows (authored by mpickering).
eventlog: Log the current stack size when stack overflows
Nov 19 2018, 5:35 AM
mpickering closed D5287: eventlog: Log the current stack size when stack overflows.
Nov 19 2018, 5:35 AM
mpickering awarded D5351: Remove explicit recursion in retainer profiling (fixes #14758) a Yellow Medal token.
Nov 19 2018, 5:29 AM
mpickering updated subscribers of D5355: hadrian: make it possible to run the testsuite with quickest and quick.

Thanks @alpmestan

Nov 19 2018, 5:19 AM

Nov 18 2018

mpickering added a reviewer for D5352: Add -fcompact-holes.: RyanGlScott.
Nov 18 2018, 9:23 AM

Nov 13 2018

mpickering planned changes to D5286: Run typed splices in the zonker.

Still one problem with finalisers getting run in the wrong place.

Nov 13 2018, 5:52 AM