monoidal (Krzysztof Gogolewski)
User

Projects

User Details

User Since
Jun 29 2014, 12:15 PM (221 w, 18 h)

Recent Activity

Thu, Sep 20

monoidal updated subscribers of D4880: Fix for built-in Natural literals.

@hsyl20 @alpmestan Since https://github.com/snowleopard/hadrian/pull/676 was merged in hadrian, should we close this Diff?

Thu, Sep 20, 6:41 PM

Wed, Sep 19

monoidal committed rGHC45befe27495b: Use predefined known-key names when possible (authored by ckoparkar).
Use predefined known-key names when possible
Wed, Sep 19, 5:29 AM
monoidal closed D5160: Use predefined known-key names when possible.
Wed, Sep 19, 5:29 AM
monoidal committed rGHCa4ae97ea6314: docs: fix example code (authored by john <haskell@abc.com>).
docs: fix example code
Wed, Sep 19, 2:03 AM

Tue, Sep 18

monoidal committed rGHC6bb9bc7d3c93: Invert FP conditions to eliminate the explicit NaN check. (authored by AndreasK).
Invert FP conditions to eliminate the explicit NaN check.
Tue, Sep 18, 12:07 PM
monoidal closed D4990: Invert FP conditions to eliminate the explicit NaN check..
Tue, Sep 18, 12:07 PM
monoidal committed rGHCce3897ffd6e7: Fix check whether GCC supports __atomic_ builtins (authored by iliastsi).
Fix check whether GCC supports __atomic_ builtins
Tue, Sep 18, 12:07 PM
monoidal closed D5154: Fix check whether GCC supports __atomic_ builtins.
Tue, Sep 18, 12:06 PM
monoidal committed rGHC01f7cd799c1c: NoImplicitPrelude in ghc-boot-th, ghc-boot, ghc-heap, ghci (authored by Shayne Fletcher <shayne.fletcher@digitalasset.com>).
NoImplicitPrelude in ghc-boot-th, ghc-boot, ghc-heap, ghci
Tue, Sep 18, 12:06 PM

Mon, Sep 17

monoidal committed rGHCe655aac18c5b: Make sure forM_ and related functions fuse cleanly (authored by sgraf).
Make sure forM_ and related functions fuse cleanly
Mon, Sep 17, 3:26 PM
monoidal closed D5131: Make sure forM_ and related functions fuse cleanly.
Mon, Sep 17, 3:25 PM
monoidal added a comment to D5121: users-guide: Fix code-block layout for QuantifiedConstraints.

@bgamari This can be merged to 8.6.

Mon, Sep 17, 11:57 AM
monoidal committed rGHC43967c0c7d2d: users-guide: Fix code-block layout for QuantifiedConstraints (authored by takenobu).
users-guide: Fix code-block layout for QuantifiedConstraints
Mon, Sep 17, 11:23 AM
monoidal committed rGHC88130dbe948e: base: Add bangs to GHC.IO.Handle.Text hGet* functions (authored by bgamari).
base: Add bangs to GHC.IO.Handle.Text hGet* functions
Mon, Sep 17, 11:23 AM
monoidal committed rGHCd1c2f298870d: Stable name comment wibbles (authored by dfeuer).
Stable name comment wibbles
Mon, Sep 17, 11:23 AM
monoidal closed D5121: users-guide: Fix code-block layout for QuantifiedConstraints.
Mon, Sep 17, 11:23 AM
monoidal closed D5149: base: Add bangs to GHC.IO.Handle.Text hGet* functions.
Mon, Sep 17, 11:23 AM
monoidal closed D5152: Stable name comment wibbles.
Mon, Sep 17, 11:23 AM

Fri, Sep 14

monoidal committed rGHCecbe26b6966a: Fix T15502 on 32-bit (authored by monoidal).
Fix T15502 on 32-bit
Fri, Sep 14, 8:07 AM
monoidal closed D5151: Fix T15502 on 32-bit.
Fri, Sep 14, 8:07 AM
monoidal retitled D5151: Fix T15502 on 32-bit from Skip T15502 on 32-bit to Fix T15502 on 32-bit.
Fri, Sep 14, 7:36 AM
monoidal added a comment to D5151: Fix T15502 on 32-bit.

@RyanGlScott Thanks, done

Fri, Sep 14, 7:36 AM
monoidal updated the diff for D5151: Fix T15502 on 32-bit.

use ws-32 and ws-64 files

Fri, Sep 14, 7:36 AM
monoidal committed rGHC3040444d3a00: tests: increase (compile) timeout multiplier for T13701 and MultiLayerModules (authored by alpmestan).
tests: increase (compile) timeout multiplier for T13701 and MultiLayerModules
Fri, Sep 14, 7:05 AM
monoidal closed D5103: tests: increase (compile) timeout multiplier for T13701 and MultiLayerModules.
Fri, Sep 14, 7:05 AM
monoidal accepted D5103: tests: increase (compile) timeout multiplier for T13701 and MultiLayerModules.
Fri, Sep 14, 7:05 AM
monoidal created D5151: Fix T15502 on 32-bit.
Fri, Sep 14, 6:45 AM
monoidal committed rGHC9c6b7493db24: Add support for ImplicitParams and RecursiveDo in TH (authored by mgsloan).
Add support for ImplicitParams and RecursiveDo in TH
Fri, Sep 14, 6:31 AM
monoidal closed D1979: Add support for ImplicitParams and RecursiveDo in TH.
Fri, Sep 14, 6:30 AM

Thu, Sep 13

monoidal committed rGHC9912cdf6dbb2: Fix build (authored by monoidal).
Fix build
Thu, Sep 13, 4:10 PM
monoidal committed rGHC1ad3c8245cc1: Typo in user guide wrongly claims DeriveLift was added in 7.2 (authored by merijn).
Typo in user guide wrongly claims DeriveLift was added in 7.2
Thu, Sep 13, 5:40 AM
monoidal committed rGHCb9b1f99954e6: Honor INLINE on 0-arity bindings (#15578) (authored by tdammers).
Honor INLINE on 0-arity bindings (#15578)
Thu, Sep 13, 4:38 AM
monoidal closed D5137: Honor INLINE on 0-arity bindings (#15578).
Thu, Sep 13, 4:38 AM

Tue, Sep 11

monoidal committed rGHC03b779f2444c: Make CoreMonad independent of TcEnv (#14391) (authored by monoidal).
Make CoreMonad independent of TcEnv (#14391)
Tue, Sep 11, 3:02 PM
monoidal closed D5139: Make CoreMonad independent of TcEnv (#14391).
Tue, Sep 11, 3:02 PM
monoidal committed rGHC5d67d069608f: rts.cabal.in: advertise new default profiling ways for hadrian (authored by alpmestan).
rts.cabal.in: advertise new default profiling ways for hadrian
Tue, Sep 11, 3:02 PM
monoidal committed rGHC36740b4c346c: Revert incorrect STM wakeup optimisation (authored by osa1).
Revert incorrect STM wakeup optimisation
Tue, Sep 11, 3:02 PM
monoidal closed D5142: rts.cabal.in: advertise new default profiling ways (introduced in D5140) for hadrian.
Tue, Sep 11, 3:02 PM
monoidal closed D5144: Revert incorrect STM wakeup optimisation.
Tue, Sep 11, 3:02 PM

Sun, Sep 9

monoidal updated the diff for D5139: Make CoreMonad independent of TcEnv (#14391).

fix whitespace

Sun, Sep 9, 2:44 PM
monoidal created D5139: Make CoreMonad independent of TcEnv (#14391).
Sun, Sep 9, 2:34 PM

Fri, Sep 7

monoidal added a comment to D5135: Make TcRnMonad independent of TcSplice (#14391).

Yes, validate passed on my machine.

Fri, Sep 7, 9:48 AM
monoidal committed rGHC2b6694a53682: users-guide: Disable syntax highlighting (authored by takenobu).
users-guide: Disable syntax highlighting
Fri, Sep 7, 9:19 AM
monoidal added a comment to D5120: users-guide: Disable syntax highlighting.

@takenobu I landed the change to master in 2b6694a536. @bgamari This can be merged to 8.6.

Fri, Sep 7, 9:18 AM
monoidal committed rGHC4caad1660a64: Documentation tweaks (authored by monoidal).
Documentation tweaks
Fri, Sep 7, 6:53 AM
monoidal closed D5132: Documentation tweaks.
Fri, Sep 7, 6:53 AM

Thu, Sep 6

monoidal updated the diff for D5135: Make TcRnMonad independent of TcSplice (#14391).

Linter fix

Thu, Sep 6, 3:01 PM
monoidal retitled D5135: Make TcRnMonad independent of TcSplice (#14391) from Make TcRnMonad independent of TcSplice (#) to Make TcRnMonad independent of TcSplice (#14391).
Thu, Sep 6, 2:43 PM
monoidal added a comment to D5135: Make TcRnMonad independent of TcSplice (#14391).

I've noticed runRemoteModFinalizers and finishTH are now used only in TcSplice. Should I move them there?

Thu, Sep 6, 2:35 PM
monoidal created D5135: Make TcRnMonad independent of TcSplice (#14391).
Thu, Sep 6, 2:33 PM
monoidal added inline comments to D5132: Documentation tweaks.
Thu, Sep 6, 10:14 AM

Wed, Sep 5

monoidal added a reviewer for D5132: Documentation tweaks: takenobu.
Wed, Sep 5, 2:29 PM
monoidal created D5132: Documentation tweaks.
Wed, Sep 5, 2:29 PM
monoidal committed rGHCe29ac2db000e: Expose 'moduleToPkgConfAll' from 'PackageState' (authored by harpocrates).
Expose 'moduleToPkgConfAll' from 'PackageState'
Wed, Sep 5, 7:58 AM
monoidal closed D5100: Expose 'moduleToPkgConfAll' from 'PackageState'.
Wed, Sep 5, 7:57 AM
monoidal accepted D5100: Expose 'moduleToPkgConfAll' from 'PackageState'.
Wed, Sep 5, 7:28 AM
monoidal committed rGHCecde9546e776: testsuite: Use bools for booleans, not ints (authored by bgamari).
testsuite: Use bools for booleans, not ints
Wed, Sep 5, 7:16 AM
monoidal closed D5010: testsuite: Use bools for booleans, not ints.
Wed, Sep 5, 7:16 AM
monoidal committed rGHCa811d938acb0: base: Add references to Notes for certain special imports (authored by ckoparkar).
base: Add references to Notes for certain special imports
Wed, Sep 5, 7:16 AM
monoidal closed D5092: base: Add references to Notes for certain special imports.
Wed, Sep 5, 7:16 AM
monoidal committed rGHC49d50b2b7d19: testsuite: Add test for #15368 (authored by bgamari).
testsuite: Add test for #15368
Wed, Sep 5, 6:37 AM
monoidal closed D4958: testsuite: Add test for #15368.
Wed, Sep 5, 6:37 AM
monoidal updated the diff for D5010: testsuite: Use bools for booleans, not ints.

Remove debugging output

Wed, Sep 5, 6:37 AM
monoidal committed rGHCc0e5087d01e2: Skip eventlog tests in GHCi way (authored by osa1).
Skip eventlog tests in GHCi way
Wed, Sep 5, 6:12 AM
monoidal closed D5119: Skip eventlog tests in GHCi way.
Wed, Sep 5, 6:12 AM

Tue, Sep 4

monoidal accepted D5121: users-guide: Fix code-block layout for QuantifiedConstraints.
Tue, Sep 4, 5:48 PM
monoidal accepted D5120: users-guide: Disable syntax highlighting.
Tue, Sep 4, 5:42 PM
monoidal created D5129: Cleanup boot and validate.
Tue, Sep 4, 5:19 PM
monoidal committed rGHC24d610a48acc: Fix tests ghci057 and T9293. (#15071) (authored by RolandSenn).
Fix tests ghci057 and T9293. (#15071)
Tue, Sep 4, 3:27 PM
monoidal closed D5125: Fix tests ghci057 and T9293. (#15071).
Tue, Sep 4, 3:26 PM
monoidal added a comment to D5125: Fix tests ghci057 and T9293. (#15071).

Looks like 6d55e36f didn't change the stdout-mingw32 files.

Tue, Sep 4, 3:23 PM
monoidal accepted D5125: Fix tests ghci057 and T9293. (#15071).
Tue, Sep 4, 3:23 PM
monoidal added a comment to D5128: Remove outdated note in StaticPointers documentation.

I'm fine with removing the link to Trac #12356, but IMO the remaining part of the paragraph should stay - it points at a limitation that is not obvious and still there.

Tue, Sep 4, 12:37 PM
monoidal committed rGHC225491203659: testsuite: make CHECK_API_ANNOTATIONS and CHECK_PPR overridable (authored by alpmestan).
testsuite: make CHECK_API_ANNOTATIONS and CHECK_PPR overridable
Tue, Sep 4, 12:10 PM
monoidal closed D5127: testsuite/mk/boilerplate.mk: make CHECK_API_ANNOTATIONS and CHECK_PPR overridable.
Tue, Sep 4, 12:10 PM
monoidal requested changes to D5128: Remove outdated note in StaticPointers documentation.

This removed part is still true - before Trac #12356 static pointers were not supported in ghci at all.

Tue, Sep 4, 12:08 PM
monoidal accepted D5127: testsuite/mk/boilerplate.mk: make CHECK_API_ANNOTATIONS and CHECK_PPR overridable.
Tue, Sep 4, 9:52 AM
monoidal committed rGHCa3a1a17ba7dd: Add a test for Trac #15586 (authored by monoidal).
Add a test for Trac #15586
Tue, Sep 4, 9:43 AM
monoidal closed D5118: Add a test for Trac #15586.
Tue, Sep 4, 9:43 AM
monoidal committed rGHCdf363a646b66: Compiler panic on invalid syntax (unterminated pragma) (authored by RolandSenn).
Compiler panic on invalid syntax (unterminated pragma)
Tue, Sep 4, 8:37 AM
monoidal closed D5093: Compiler panic on invalid syntax (unterminated pragma).
Tue, Sep 4, 8:37 AM
monoidal accepted D5093: Compiler panic on invalid syntax (unterminated pragma).
Tue, Sep 4, 4:29 AM

Mon, Sep 3

monoidal accepted D5124: Refactor Foreign.Marshal modules for more modern style.

LGTM if build passes.

Mon, Sep 3, 7:08 AM

Sun, Sep 2

monoidal committed rGHCed789516e201: make iToBase62's inner loop stricter in one of its arguments (authored by alpmestan).
make iToBase62's inner loop stricter in one of its arguments
Sun, Sep 2, 4:21 PM
monoidal closed D5106: make iToBase62's inner loop stricter in one of its arguments.
Sun, Sep 2, 4:21 PM
monoidal committed rGHC6dea7c161e45: Reject class instances with type families in kinds (authored by RyanGlScott).
Reject class instances with type families in kinds
Sun, Sep 2, 4:21 PM
monoidal closed D5068: Reject class instances with type families in kinds.
Sun, Sep 2, 4:21 PM

Fri, Aug 31

monoidal created D5118: Add a test for Trac #15586.
Fri, Aug 31, 4:46 AM

Thu, Aug 30

monoidal committed rGHC140563ff30ac: fix -ddump-asm description (authored by alpmestan).
fix -ddump-asm description
Thu, Aug 30, 2:11 PM
monoidal closed D5102: fix -ddump-asm description.
Thu, Aug 30, 2:11 PM
monoidal committed rGHC97826e343c48: Fix the __GLASGOW_HASKELL__ comparison (authored by monoidal).
Fix the __GLASGOW_HASKELL__ comparison
Thu, Aug 30, 8:35 AM
monoidal closed D5064: Fix the __GLASGOW_HASKELL__ comparison.
Thu, Aug 30, 8:35 AM

Wed, Aug 29

monoidal added a comment to D5099: rts: Count SRT scavenging events via ticky.

Build failed (is this based on a different branch than master?)

Wed, Aug 29, 5:34 PM
monoidal accepted D5093: Compiler panic on invalid syntax (unterminated pragma).
Wed, Aug 29, 5:33 PM
monoidal added a comment to D5064: Fix the __GLASGOW_HASKELL__ comparison.

@ggreif Should be fixed now.

Wed, Aug 29, 5:20 PM
monoidal updated the diff for D5064: Fix the __GLASGOW_HASKELL__ comparison.

Always use import qualified Data.Semigroup

Wed, Aug 29, 5:20 PM
monoidal added a comment to D5109: Fix a constant folding rule.

Since this caused miscompilation and we're not reverting D2858 in master, I merged as-is; tests can be added in a separate diff.

Wed, Aug 29, 10:15 AM
monoidal committed rGHC65eec9cfd441: Fix a constant folding rule (authored by snowleopard).
Fix a constant folding rule
Wed, Aug 29, 9:46 AM
monoidal closed D5109: Fix a constant folding rule.
Wed, Aug 29, 9:46 AM

Tue, Aug 28

monoidal committed rGHC102284e72f8d: Rename kind vars in left-to-right order in bindHsQTyVars (authored by RyanGlScott).
Rename kind vars in left-to-right order in bindHsQTyVars
Tue, Aug 28, 6:28 PM