last_g (Last G)
User

Projects

User does not belong to any projects.

User Details

User Since
May 14 2018, 8:27 AM (18 w, 1 d)

Recent Activity

Thu, Sep 6

last_g added a comment to D4713: Mark code related symbols as @function not @object.

@lelf

How so?

Thu, Sep 6, 10:39 AM

Wed, Sep 5

last_g added a comment to D4713: Mark code related symbols as @function not @object.

@bgamari @simonmar

Wed, Sep 5, 8:34 AM

Tue, Aug 28

last_g updated the diff for D4722: Mark system and internal symbols as private symbols in asm.

Remove unused symbol

Tue, Aug 28, 10:32 AM
last_g added a comment to D4713: Mark code related symbols as @function not @object.

As I mentioned before this patch actually has no effect on dtrace. My first conclusion was caused by the non-deterministic nature of the problem i.e. dtrace behavior may change after recompilation of the same file. But the process always crashes under dtrace.

Tue, Aug 28, 10:24 AM

Fri, Aug 24

last_g updated the diff for D4722: Mark system and internal symbols as private symbols in asm.

Addressing @simonmar comments

Fri, Aug 24, 4:06 PM
last_g updated the diff for D4713: Mark code related symbols as @function not @object.

accidental squash

Fri, Aug 24, 10:42 AM
last_g updated the diff for D4713: Mark code related symbols as @function not @object.

Rebase on remote/master
Should fix tests

Fri, Aug 24, 10:39 AM

Thu, Aug 23

last_g added a comment to D4713: Mark code related symbols as @function not @object.

Have you tried debugging on Linux? I believe that perf can use dtrace probe points.

Thu, Aug 23, 9:59 AM
last_g updated the diff for D4713: Mark code related symbols as @function not @object.

rebase

Thu, Aug 23, 9:59 AM

Mon, Aug 20

last_g added a comment to D4713: Mark code related symbols as @function not @object.

@lelf Yeah. It looks like this renders dtrace totally unusable (or more unusable). On 8.4.3 and master ghc crashes after getting some probes (https://ghc.haskell.org/trac/ghc/ticket/15543) but with this patch, it crashes immediately. Any clues? (I have almost no idea how dtrace works, how to debug it and how to debug ghc on MacOS, there is even no stack trace in lldb)

Mon, Aug 20, 1:05 PM

Aug 17 2018

last_g added a comment to D4713: Mark code related symbols as @function not @object.

There is one test failure not related to the changes (I reproduced on the parent commit)

Aug 17 2018, 10:15 AM

Aug 16 2018

last_g updated the diff for D4713: Mark code related symbols as @function not @object.

Pushing to staging

Aug 16 2018, 10:34 AM
last_g updated the diff for D4713: Mark code related symbols as @function not @object.

Rebase to fix submodule changes

Aug 16 2018, 7:11 AM

Aug 15 2018

last_g added a comment to D4713: Mark code related symbols as @function not @object.

@lelf I ran two binaries built with stock ghc 8.4.2 and my patch on top of the master and very the same results from dtrace

Aug 15 2018, 11:06 AM

Aug 10 2018

last_g added a comment to D4713: Mark code related symbols as @function not @object.

@bgamari I filed a ticket (https://ghc.haskell.org/trac/ghc/ticket/15501). Can you merge this?

Aug 10 2018, 7:00 AM

Aug 9 2018

last_g updated the diff for D4713: Mark code related symbols as @function not @object.

rebase attempt

Aug 9 2018, 11:13 AM

Jun 27 2018

last_g added a comment to D4713: Mark code related symbols as @function not @object.

@bgamari ping :)

Jun 27 2018, 2:55 PM

Jun 25 2018

last_g added a comment to D4722: Mark system and internal symbols as private symbols in asm.

@simonmar

Do we care that perf will say 0x0000000000331e15 instead of s3ri_info?

I don't think there is any difference for a normal user between an address and a random symbol.

Jun 25 2018, 4:09 PM
last_g updated the diff for D4722: Mark system and internal symbols as private symbols in asm.

Always keep top-level fn symbols and dsp

Jun 25 2018, 3:36 PM

Jun 20 2018

last_g added a comment to D4722: Mark system and internal symbols as private symbols in asm.

@angerman , @simonmar I managed to get some odd behavior with -dead_strip like getting a warning during a link stage:

Jun 20 2018, 11:33 AM
last_g added a comment to D4722: Mark system and internal symbols as private symbols in asm.

@angerman I successfully built a simple binary and a stage2 compiler with -fllvm. Do you have an idea what can go wrong and what/how should I test?

Jun 20 2018, 11:32 AM

Jun 19 2018

last_g added a comment to D4722: Mark system and internal symbols as private symbols in asm.

It took a while to answer :)

Jun 19 2018, 9:15 PM

Jun 18 2018

last_g added a comment to D4713: Mark code related symbols as @function not @object.

I have an idea why it's happening and I plan to investigate it later.

Jun 18 2018, 8:01 PM
last_g updated the diff for D4713: Mark code related symbols as @function not @object.

Address the comments

Jun 18 2018, 8:01 PM

Jun 12 2018

last_g added a comment to D4713: Mark code related symbols as @function not @object.

@bgamari I've rewritten the comment please check
@simonmar thanks for the great explanation!

Jun 12 2018, 4:38 PM
last_g updated the diff for D4713: Mark code related symbols as @function not @object.

Include @simonmar comment into the code

Jun 12 2018, 4:35 PM
last_g updated the diff for D4713: Mark code related symbols as @function not @object.

Make comment readable

Jun 12 2018, 4:27 PM
last_g updated the diff for D4713: Mark code related symbols as @function not @object.

Comments

Jun 12 2018, 4:18 PM
last_g updated the diff for D4713: Mark code related symbols as @function not @object.

Comments

Jun 12 2018, 4:11 PM
last_g updated the diff for D4713: Mark code related symbols as @function not @object.

Addressing comments and making a code comment readable

Jun 12 2018, 4:07 PM

May 24 2018

last_g retitled D4730: Add local @function symbols for the code entries from Add local @function symbols for the code entries code to Add local @function symbols for the code entries.
May 24 2018, 9:52 AM
last_g updated the summary of D4730: Add local @function symbols for the code entries.
May 24 2018, 9:52 AM
last_g created D4730: Add local @function symbols for the code entries.
May 24 2018, 9:52 AM

May 23 2018

last_g added a comment to D4722: Mark system and internal symbols as private symbols in asm.

@angerman

Could you provide the same Perf-list without the D4713 interaction?

This patch only makes sense on top of the D4713.
https://gist.github.com/last-g/0a7a3801478f8d072ab88fd6f9047406

May 23 2018, 1:25 PM
last_g added a comment to D4722: Mark system and internal symbols as private symbols in asm.

@simonmar Knowing perf logic I can speculate why we do have more unknown addresses after D4713 but this actually requires a separate investigation. I can explain how perf treats symbols if you want.
As a proof that D4713 and not this diff leads to the increase of the unknown addresses:

May 23 2018, 12:57 PM

May 22 2018

last_g added a comment to D4722: Mark system and internal symbols as private symbols in asm.

this reduces the granularity of labels. The perf output in particular becomes is obviously less detailed, and also worryingly seems to have more unknown addresses in it.

May 22 2018, 8:00 PM
last_g updated the summary of D4722: Mark system and internal symbols as private symbols in asm.
May 22 2018, 7:36 PM
last_g created D4722: Mark system and internal symbols as private symbols in asm.
May 22 2018, 10:04 AM

May 20 2018

last_g created D4713: Mark code related symbols as @function not @object.
May 20 2018, 5:13 PM