kosmikus (Andres Löh)
User

Projects

User does not belong to any projects.

User Details

User Since
May 22 2014, 4:04 PM (243 w, 2 d)

Recent Activity

Nov 19 2018

kosmikus added a comment to D5352: Add -fcompact-holes..

Thanks for the review.

Nov 19 2018, 9:16 AM

Nov 18 2018

kosmikus created D5352: Add -fcompact-holes..
Nov 18 2018, 9:22 AM

May 30 2016

kosmikus added a comment to D2280: Implement deriving strategies.

I'll try to catch up with the discussion on the ticket.

May 30 2016, 3:45 AM

Apr 13 2016

kosmikus accepted D2111: rel-notes: Add note about UndecidableSuperClasses and #11762.
Apr 13 2016, 12:14 PM

Dec 23 2015

kosmikus added inline comments to D1646: Encode strictness in GHC generics metadata.
Dec 23 2015, 12:52 AM

Dec 17 2015

kosmikus added a comment to D1646: Encode strictness in GHC generics metadata.

I would be agreeable to that. While we're at it, how about we get rid of Bang entirely and just make MetaSel :: Maybe Symbol -> SourceUnpackedness -> SourceStrictness -> DecidedStrictness -> Meta? That would make Selector and MetaSel align more closely, and we can avoid painting the Bang bikeshed entirely.

Dec 17 2015, 1:33 AM
kosmikus added a comment to D1646: Encode strictness in GHC generics metadata.

Looks good to me in general ... but a bit of bikeshedding, sorry:

Dec 17 2015, 1:18 AM

Dec 3 2015

kosmikus accepted D493: Use TypeLits in the meta-data encoding of GHC.Generics.
Dec 3 2015, 8:54 AM
kosmikus added a comment to D493: Use TypeLits in the meta-data encoding of GHC.Generics.

All in all, looks very nice. Thanks for this. Added two really minor comments.

Dec 3 2015, 8:53 AM

Oct 3 2015

kosmikus accepted D1239: Make GHC generics capable of handling unboxed types (#10868).
Oct 3 2015, 4:53 AM

Oct 2 2015

kosmikus added a comment to D1239: Make GHC generics capable of handling unboxed types (#10868).
instance GShow (URec a) where
    gshow (UChar c) = show (C# c)
    gshow (UInt  i) = show (I# i)
Oct 2 2015, 9:38 AM
kosmikus added a comment to D1239: Make GHC generics capable of handling unboxed types (#10868).

Some small comments.

Oct 2 2015, 9:31 AM
kosmikus added a comment to D1239: Make GHC generics capable of handling unboxed types (#10868).

Sorry for joining the discussion this late.

Oct 2 2015, 1:28 AM