kgardas (Karel Gardas)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 10 2014, 12:13 PM (214 w, 4 d)

Recent Activity

Wed, Jul 25

Ian Lynagh <igloo@earth.li> committed rGHCDIFFcdd6afcbb58a: skip T2615 on Solaris which does not support GNUish linker scripts (authored by kgardas).
skip T2615 on Solaris which does not support GNUish linker scripts
Wed, Jul 25, 9:27 AM
kgardas committed rGHCDIFFaed96e5bdfd8: fix hClose002 test output on i386-solaris2 platform (authored by kgardas).
fix hClose002 test output on i386-solaris2 platform
Wed, Jul 25, 9:23 AM
kgardas committed rGHCDIFF4e3058dc4c40: fix openFile003 on i386/solaris2 by providing appropriate stdout file (authored by kgardas).
fix openFile003 on i386/solaris2 by providing appropriate stdout file
Wed, Jul 25, 9:12 AM
Ian Lynagh <ian@well-typed.com> committed rGHCDIFF8e51a7ab47ed: add arm-unknown-linux to platforms which do not support shared libs (authored by kgardas).
add arm-unknown-linux to platforms which do not support shared libs
Wed, Jul 25, 8:02 AM
Ian Lynagh <ian@well-typed.com> committed rGHCDIFF192a8f9f557e: set DYNAMIC_GHC_PROGRAMS to NO if platform does not support shared libs (authored by kgardas).
set DYNAMIC_GHC_PROGRAMS to NO if platform does not support shared libs
Wed, Jul 25, 8:02 AM
Ian Lynagh <ian@well-typed.com> committed rGHCDIFF71f7ab6a0544: define own version of PRIdPTR on platform where its not available (authored by kgardas).
define own version of PRIdPTR on platform where its not available
Wed, Jul 25, 7:45 AM
kgardas committed rGHCDIFF748883b4f157: enable ARM specific target data layout and triple again (authored by kgardas).
enable ARM specific target data layout and triple again
Wed, Jul 25, 6:59 AM
kgardas committed rGHCDIFFbab9a72d7f12: enhance ArchARM with ISA and ISA extensions (authored by kgardas).
enhance ArchARM with ISA and ISA extensions
Wed, Jul 25, 6:59 AM
kgardas committed rGHCDIFF3fff0020aa80: on ARMv7 with VFPv3[D16] support pass appropriate -mattr value to LLVM llc (authored by kgardas).
on ARMv7 with VFPv3[D16] support pass appropriate -mattr value to LLVM llc
Wed, Jul 25, 6:59 AM
Manuel M T Chakravarty <chak@cse.unsw.edu.au> committed rGHCDIFF5cf87b43993f: disable for now ARM specific target data layout and triple (authored by kgardas).
disable for now ARM specific target data layout and triple
Wed, Jul 25, 6:58 AM
Manuel M T Chakravarty <chak@cse.unsw.edu.au> committed rGHCDIFF0ce75cf91d0d: fix ARM/LLVM target data layout specification together with target triple (authored by kgardas).
fix ARM/LLVM target data layout specification together with target triple
Wed, Jul 25, 6:58 AM
Manuel M T Chakravarty <chak@cse.unsw.edu.au> committed rGHCDIFF9ebdbb27a8b2: RTS: fix pushWSDeque to invoke write barrier when element is added (authored by kgardas).
RTS: fix pushWSDeque to invoke write barrier when element is added
Wed, Jul 25, 6:58 AM
Manuel M T Chakravarty <chak@cse.unsw.edu.au> committed rGHCDIFFb0538fd43a8d: implement ARMv7 specific memory barriers (authored by kgardas).
implement ARMv7 specific memory barriers
Wed, Jul 25, 6:58 AM
Manuel M T Chakravarty <chak@cse.unsw.edu.au> committed rGHCDIFFa9b455c4b696: RTS: fix xchg/cas fcns to invoke memory barrier on ARMv7 platform (authored by kgardas).
RTS: fix xchg/cas fcns to invoke memory barrier on ARMv7 platform
Wed, Jul 25, 6:58 AM
Manuel M T Chakravarty <chak@cse.unsw.edu.au> committed rGHCDIFF1e85268bdbd5: LLVM: set target data layout for arm-unknown-linux triplet (authored by kgardas).
LLVM: set target data layout for arm-unknown-linux triplet
Wed, Jul 25, 6:58 AM
Manuel M T Chakravarty <chak@cse.unsw.edu.au> committed rGHCDIFF454b34cb3b67: add support for STG floating-point regs using VFPv3 (authored by kgardas).
add support for STG floating-point regs using VFPv3
Wed, Jul 25, 6:58 AM
Manuel M T Chakravarty <chak@cse.unsw.edu.au> committed rGHCDIFF226541c41825: make StgReturn and cas functions Thumb friendly (authored by kgardas).
make StgReturn and cas functions Thumb friendly
Wed, Jul 25, 6:58 AM
Manuel M T Chakravarty <chak@cse.unsw.edu.au> committed rGHCDIFFe44642590550: Stephen Blackheath's GHC/ARM registerised port (authored by kgardas).
Stephen Blackheath's GHC/ARM registerised port
Wed, Jul 25, 6:58 AM
Manuel M T Chakravarty <chak@cse.unsw.edu.au> committed rGHCDIFF330dff34ddc4: implement ARMv6/7 specific xchg function (authored by kgardas).
implement ARMv6/7 specific xchg function
Wed, Jul 25, 6:58 AM
Ian Lynagh <igloo@earth.li> committed rGHCDIFFe7f04c3b08e1: - disable shared lib support on Solaris 10 and older (fixes #4973) (authored by kgardas).
- disable shared lib support on Solaris 10 and older (fixes #4973)
Wed, Jul 25, 6:42 AM
kgardas committed rGHCDIFFff7ee297b541: replace C++ comments with C comments (Solaris' DTrace fails on C++ comments) (authored by kgardas).
replace C++ comments with C comments (Solaris' DTrace fails on C++ comments)
Wed, Jul 25, 6:40 AM
kgardas committed rGHCDIFF4524b814bedc: do not compile part of shared lib RTS with -fno-PIC on Solaris (authored by kgardas).
do not compile part of shared lib RTS with -fno-PIC on Solaris
Wed, Jul 25, 6:38 AM
kgardas committed rGHCDIFFfb18c56348c6: fix CPP detection of Solaris in NCG (authored by kgardas).
fix CPP detection of Solaris in NCG
Wed, Jul 25, 6:38 AM
kgardas committed rGHCDIFFf5f28c48f956: provide shared libraries support on i386-unknown-solaris2 platform (authored by kgardas).
provide shared libraries support on i386-unknown-solaris2 platform
Wed, Jul 25, 6:38 AM
kgardas committed rGHCDIFF74614af8bae3: FIX #2313 do not include BFD symbols in RTS when the BFD library is not… (authored by kgardas).
FIX #2313 do not include BFD symbols in RTS when the BFD library is not…
Wed, Jul 25, 5:55 AM

Jul 20 2017

kgardas added a comment to D3765: Pass --posix to tar.

Code looks good, but is not working well on OpenBSD 6.1-current which provides GNU tar 1.29:

"rm" -f bindistprep/ghc-8.3.20170720-x86_64-unknown-openbsd.tar  
cd bindistprep && "/usr/local/bin/gtar" --posix hcf - -T ../bindist-list | /usr/local/bin/xz -c > ../bindistprep/ghc-8.3.20170720-x86_64-unknown-openbsd.tar.xz
/usr/local/bin/gtar: You must specify one of the '-Acdtrux', '--delete' or '--test-label' options
Try '/usr/local/bin/gtar --help' or '/usr/local/bin/gtar --usage' for more
information.
mv bindistprep/*.tar.xz .
$ 
$ gtar --version
tar (GNU tar) 1.29
Copyright (C) 2015 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>.
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.
Jul 20 2017, 3:31 PM

Oct 18 2016

kgardas committed rGHCfa8940e80138: fix build failure on Solaris caused by usage of --export-dynamic (authored by kgardas).
fix build failure on Solaris caused by usage of --export-dynamic
Oct 18 2016, 2:48 PM
kgardas closed D2606: fix build failure on Solaris caused by usage of --export-dynamic as linker option by committing rGHCfa8940e80138: fix build failure on Solaris caused by usage of --export-dynamic.
Oct 18 2016, 2:48 PM

Oct 17 2016

kgardas added a comment to D2606: fix build failure on Solaris caused by usage of --export-dynamic as linker option.

Yes, probably yes. Honestly speaking I've googled for equivalent option and its need and found this: http://stackoverflow.com/questions/596076/solaris-linker-equivalent-to-the-gnu-ld-export-dynamic-flag -- I've also build on Solaris with the patch and run testsuite and there are no new errors judging form quick look. I've also compared nm iserv|wc -l on Solaris and Linux and found that 31511 and 31123 are pretty similar numbers. I've not investigated more, but if you know some iserv's symbol which you are interested in and which is exported as dynamic one on Linux, I would grep for it here on Solaris for verification. Thanks.

Oct 17 2016, 11:55 AM
kgardas retitled D2606: fix build failure on Solaris caused by usage of --export-dynamic as linker option from to fix build failure on Solaris caused by usage of --export-dynamic as linker option.
Oct 17 2016, 6:21 AM

Oct 7 2016

kgardas accepted D2579: Cleanup PosixSource.h.
Oct 7 2016, 11:25 AM
kgardas added a comment to D2579: Cleanup PosixSource.h.

Works on Solaris 11.2. Tested on i386 platform, but since this is hardware platform independent issue I would not expect any issue on amd64. Thanks for the patch! Karel

Oct 7 2016, 11:25 AM

Aug 22 2016

kgardas committed rGHCf9aa996f0af5: pass -z wxneeded or -Wl,-zwxneeded for linking on OpenBSD (authored by kgardas).
pass -z wxneeded or -Wl,-zwxneeded for linking on OpenBSD
Aug 22 2016, 9:15 AM
kgardas closed D2454: pass -z wxneeded or -Wl,-zwxneeded for linking on OpenBSD by committing rGHCf9aa996f0af5: pass -z wxneeded or -Wl,-zwxneeded for linking on OpenBSD.
Aug 22 2016, 9:15 AM

Aug 15 2016

kgardas committed rGHC3551e622ab3a: refactor test for __builtin_unreachable into Rts.h macro RTS_UNREACHABLE (authored by kgardas).
refactor test for __builtin_unreachable into Rts.h macro RTS_UNREACHABLE
Aug 15 2016, 3:26 PM
kgardas closed D2457: refactor GNU C version test for __builtin_unreachable into Rts.h macro RTS_UNREACHABLE by committing rGHC3551e622ab3a: refactor test for __builtin_unreachable into Rts.h macro RTS_UNREACHABLE.
Aug 15 2016, 3:26 PM
kgardas added a comment to D2453: fix compilation failure on OpenBSD with system supplied GNU C 4.2.1.

@simonmar the macro is done in D2457

Aug 15 2016, 2:20 PM
kgardas retitled D2457: refactor GNU C version test for __builtin_unreachable into Rts.h macro RTS_UNREACHABLE from to refactor GNU C version test for __builtin_unreachable into Rts.h macro RTS_UNREACHABLE.
Aug 15 2016, 2:20 PM
kgardas added a comment to D2453: fix compilation failure on OpenBSD with system supplied GNU C 4.2.1.

@simonmar Good catch! Working on that. I'm not sure I can update closed Dx, so I'll try to provide a new one.

Aug 15 2016, 1:44 PM

Aug 14 2016

kgardas added a comment to D2454: pass -z wxneeded or -Wl,-zwxneeded for linking on OpenBSD.

@kili thanks for the info. If I may add some note on this matter. It looks like OpenBSD-current which will be released as 6.1 in 2017 will contain several big applications which will require wxallowed file-system and be linked with -z wxneeded. IMHO those will be web browsers with javascripts JITs at least (or am I mistakenly reading openbsd's mailing lists? Please correct me if I'm wrong here!). If we do the same with GHC's own GHCi, nobody will probably kill us. Please note that the wxneeded param is put into the GHC's settings file and so all linked Haskell apps are linked with -z wxneeded. On the other hand this is not necessary and it is always possible to remove -z wxneeded from the GHC's settings during installation step to prevent this hack from ordinary Haskell app which does not require it anyway. At least I've tested bindisttest's HelloWorld.lhs with and without -z wxneeded and in both static and dynamic versions and all were working well.
So if I may ask, I would go with this forward till the time we do have proper patch for W^X. Thanks!

Aug 14 2016, 3:52 PM
kgardas updated the diff for D2454: pass -z wxneeded or -Wl,-zwxneeded for linking on OpenBSD.

replace tabs with spaces

Aug 14 2016, 3:37 PM
kgardas committed rGHCffd4029c5bc5: fix compilation failure on OpenBSD with system supplied GNU C 4.2.1 (authored by kgardas).
fix compilation failure on OpenBSD with system supplied GNU C 4.2.1
Aug 14 2016, 2:57 PM
kgardas closed D2453: fix compilation failure on OpenBSD with system supplied GNU C 4.2.1 by committing rGHCffd4029c5bc5: fix compilation failure on OpenBSD with system supplied GNU C 4.2.1.
Aug 14 2016, 2:57 PM
kgardas added a comment to D2453: fix compilation failure on OpenBSD with system supplied GNU C 4.2.1.

I've changed the #ifdef a bit to test for specific GNU C version. Also I've reformatted code as per Eric's advice. I've tested on OpenBSD-current with its GNU C 4.2.1 and verified I get to abort() code branch and on Solaris 11 with GNU C 4.8.2 and verified that I get to __builtin_unreachable code branch so #ifdef machinery should be ok. Thanks for review and comments.

Aug 14 2016, 6:29 AM
kgardas updated the diff for D2453: fix compilation failure on OpenBSD with system supplied GNU C 4.2.1.

Do not use openbsd_HOST_OS #ifdef but rather test for specific GNU C version

Aug 14 2016, 6:28 AM

Aug 13 2016

kgardas added a comment to D2453: fix compilation failure on OpenBSD with system supplied GNU C 4.2.1.

@erikd will do tomorrow in the evening (CEST). Thanks for the comment.

Aug 13 2016, 4:43 PM
kgardas added a comment to D2454: pass -z wxneeded or -Wl,-zwxneeded for linking on OpenBSD.

@erikd of course let's wait for @kili 's patch(es). I'm not sure, but I think he is working on OpenBSD's GHC 7.10.x base so either he or I'll attempt to forward port his patch(es) to HEAD and provide better solution. Anyway, let's keep this open for few next days and see what kili/me can bring... After all, this is really just workaround to get things running better on OpenBSD-current...

Aug 13 2016, 4:41 PM
kgardas retitled D2454: pass -z wxneeded or -Wl,-zwxneeded for linking on OpenBSD from to pass -z wxneeded or -Wl,-zwxneeded for linking on OpenBSD.
Aug 13 2016, 11:53 AM
kgardas retitled D2453: fix compilation failure on OpenBSD with system supplied GNU C 4.2.1 from to fix compilation failure on OpenBSD with system supplied GNU C 4.2.1.
Aug 13 2016, 11:47 AM

Mar 29 2016

kgardas added inline comments to D2056: cleanup POSIX/XOPEN defines for switch to C99.
Mar 29 2016, 4:53 PM
kgardas committed rGHCbe2a7baf15c6: cleanup POSIX/XOPEN defines for switch to C99 (authored by kgardas).
cleanup POSIX/XOPEN defines for switch to C99
Mar 29 2016, 8:55 AM
kgardas closed D2056: cleanup POSIX/XOPEN defines for switch to C99 by committing rGHCbe2a7baf15c6: cleanup POSIX/XOPEN defines for switch to C99.
Mar 29 2016, 8:55 AM
kgardas updated the diff for D2056: cleanup POSIX/XOPEN defines for switch to C99.

update code comment: listing standards and related trac ticket

Mar 29 2016, 8:28 AM
kgardas added a comment to D2053: fix compilation failure on Solaris 11.

@hvr: please review D2056

Mar 29 2016, 5:30 AM
kgardas retitled D2056: cleanup POSIX/XOPEN defines for switch to C99 from to cleanup POSIX/XOPEN defines for switch to C99.
Mar 29 2016, 5:25 AM
kgardas added a comment to D2053: fix compilation failure on Solaris 11.

@hvr agree with you on consistency C99 versus POSIX/XOPEN. Let me test following diff

diff --git a/rts/PosixSource.h b/rts/PosixSource.h
index 6246e3e..8246fda 100644
--- a/rts/PosixSource.h
+++ b/rts/PosixSource.h
@@ -11,25 +11,13 @@
Mar 29 2016, 4:22 AM
kgardas added a comment to D2053: fix compilation failure on Solaris 11.

@hvr uff, sorry about commit, I've noted your changed of mind too late.

Mar 29 2016, 4:14 AM
kgardas committed rGHC91b96e1ccce6: fix compilation failure on Solaris 11 (authored by kgardas).
fix compilation failure on Solaris 11
Mar 29 2016, 4:12 AM
kgardas closed D2053: fix compilation failure on Solaris 11 by committing rGHC91b96e1ccce6: fix compilation failure on Solaris 11.
Mar 29 2016, 4:12 AM
kgardas added a comment to D2053: fix compilation failure on Solaris 11.

@hvr it's not IMHO the question about what macros are not implemented on Solaris but the question about Solaris strickness. It simply claims

346 /*
347  * It is invalid to compile an XPG3, XPG4, XPG4v2, or XPG5 application
348  * using c99.  The same is true for POSIX.1-1990, POSIX.2-1992, POSIX.1b,
349  * and POSIX.1c applications. Likewise, it is invalid to compile an XPG6
350  * or a POSIX.1-2001 application with anything other than a c99 or later
351  * compiler.  Therefore, we force an error in both cases.
352  */
353 #if defined(_STDC_C99) && (defined(__XOPEN_OR_POSIX) && !defined(_XPG6))
354 #error "Compiler or options invalid for pre-UNIX 03 X/Open applications \
355         and pre-2001 POSIX applications"
356 #elif !defined(_STDC_C99) && \
357         (defined(__XOPEN_OR_POSIX) && defined(_XPG6))
358 #error "Compiler or options invalid; UNIX 03 and POSIX.1-2001 applications \
359         require the use of c99"
360 #endif

and the error on line 354 is what I hit here. By defining _XOPEN_SOURCE to 600 this is corrected. Apparently Linux is not that strict and allows you to compile non XPG6 code with C99 compiler. Basically if you look here: https://github.com/joyent/illumos-joyent/blob/master/usr/src/uts/common/sys/feature_tests.h -- this is nearly the same like Solaris 11's own file except that Illumos modernize it to also support XPG7. Anyway, the logic of test above is still the same.

Mar 29 2016, 3:06 AM

Mar 28 2016

kgardas retitled D2053: fix compilation failure on Solaris 11 from to fix compilation failure on Solaris 11.
Mar 28 2016, 5:08 PM

Feb 23 2016

kgardas added a comment to D1805: Change runtime linker to perform lazy loading of symbols/sections.
In D1805#53370, @thomie wrote:

validate --fast passes for me on OSX 10.11.2

You'll have to set DYNAMIC_GHC_PROGRAMS = NO in mk/validate.mk (that you create yourself), for this to be an effective test. By default ghc uses the system linker on Mac.

solaris is on the NoSharedLibsPlatformList though, maybe @kgardas should do a validate there.

Feb 23 2016, 3:30 AM

Jan 15 2016

kgardas added a comment to D1775: configure.ac: Export MAKECMD to build system.

@thomie Hold on, gmake 3.80 is distributed with Solaris 10 up to these days IIRC and even there is nearly zero chance someone will update their GHC to 8.x on this system, still if the warning hurts nobody I would rather keep it there.

Jan 15 2016, 10:07 AM
kgardas added a comment to D1775: configure.ac: Export MAKECMD to build system.

@bgamari failed on ghc-stage1 running out of memory. Can't see how this may be related to the proposed change...

Jan 15 2016, 7:16 AM

Jan 14 2016

kgardas added a comment to D1775: configure.ac: Export MAKECMD to build system.

@bgamari you are right about it so I removed that.

Jan 14 2016, 8:31 AM
kgardas updated the diff for D1775: configure.ac: Export MAKECMD to build system.

do not set make command in mk/config.mk.in (not necessary for shake)

Jan 14 2016, 8:30 AM

Jan 13 2016

kgardas retitled D1775: configure.ac: Export MAKECMD to build system from to save detected make command into mk/config.mk for shake purposes.
Jan 13 2016, 5:13 PM

Jan 12 2016

kgardas committed rGHC00c8076ecf44: fix typo causing compilation failure on SPARC (ArchSparc -> ArchSPARC) (authored by kgardas).
fix typo causing compilation failure on SPARC (ArchSparc -> ArchSPARC)
Jan 12 2016, 3:00 PM

Dec 23 2015

kgardas committed rGHC84f673961942: - fix gc_thread related compilation failure on Solaris/i386 platform (authored by kgardas).
- fix gc_thread related compilation failure on Solaris/i386 platform
Dec 23 2015, 3:43 AM
kgardas closed D1688: - fix gc_thread related compilation failure on Solaris/i386 platform by committing rGHC84f673961942: - fix gc_thread related compilation failure on Solaris/i386 platform.
Dec 23 2015, 3:43 AM
kgardas updated the diff for D1688: - fix gc_thread related compilation failure on Solaris/i386 platform.
  • fix compilation issue of previous long line fix
Dec 23 2015, 2:53 AM
kgardas updated the diff for D1688: - fix gc_thread related compilation failure on Solaris/i386 platform.
  • fix long line issue
Dec 23 2015, 2:40 AM
kgardas added a comment to D1689: - fix tests on OpenBSD which requires _DYNAMIC symbol.

@hvr: I don't know what's exactly culprit. The error looks like:

Compile failed (status 256) errors were:
ghc-stage2: /usr/lib/libpthread.a: unknown symbol `_DYNAMIC'
ghc-stage2: unable to load package `unix-2.7.1.1'
Dec 23 2015, 1:28 AM
kgardas committed rGHC5f0868163981: - fix tests on OpenBSD which requires _DYNAMIC symbol (authored by kgardas).
- fix tests on OpenBSD which requires _DYNAMIC symbol
Dec 23 2015, 12:44 AM
kgardas closed D1689: - fix tests on OpenBSD which requires _DYNAMIC symbol by committing rGHC5f0868163981: - fix tests on OpenBSD which requires _DYNAMIC symbol.
Dec 23 2015, 12:44 AM

Dec 22 2015

kgardas retitled D1689: - fix tests on OpenBSD which requires _DYNAMIC symbol from to - fix tests on OpenBSD which requires _DYNAMIC symbol.
Dec 22 2015, 4:02 PM
kgardas retitled D1688: - fix gc_thread related compilation failure on Solaris/i386 platform from to - fix gc_thread related compilation failure on Solaris/i386 platform.
Dec 22 2015, 3:56 PM

Nov 19 2015

kgardas added a comment to D1500: derivedConstants: Add support for AIX.

@hvr: arc upgrade solved the issue. I've tested D on OpenBSD/AMD64 and Solaris/AMD64 and builds fine including bindisttest hello world.

Nov 19 2015, 4:38 AM
kgardas added a comment to D1500: derivedConstants: Add support for AIX.

@hvr: can't apply this with: arc patch D1500. It fails with:

Created and checked out branch arcpatch-D1500.
Exception
You may not set new credentials after authenticating conduit.
(Run with `--trace` for a full exception trace.)
49

well just in case you are curious if this runs on Solaris/OpenBSD, can't help you till this is solved. Any idea?

Nov 19 2015, 3:45 AM
kgardas accepted D1499: Make `derivedConstants` more crosscompile-friendly.

Tested on OpenBSD/AMD64 and Solaris/i386. Builds fine.

Nov 19 2015, 3:42 AM

Nov 16 2015

kgardas added a comment to D1470: RTS linker refactoring.

I've compiled HEAD + this Dx on Solaris/AMD64 and OpenBSD/AMD64. I'm not lucky with Solaris/i386 which fails with

"/opt/ghc-7.10.1-i386/bin/ghc" -hisuf hi -osuf  o -hcsuf hc -static  -H32m -O -Wall  -package-db libraries/bootstrapping.conf  -this-package-key ghc-7.11 -hide-all-packages -i -icompiler/backpack -icompiler/basicTypes -icompiler/cmm -icompiler/codeGen -icompiler/coreSyn -icompiler/deSugar -icompiler/ghci -icompiler/hsSyn -icompiler/iface -icompiler/llvmGen -icompiler/main -icompiler/nativeGen -icompiler/parser -icompiler/prelude -icompiler/profiling -icompiler/rename -icompiler/simplCore -icompiler/simplStg -icompiler/specialise -icompiler/stgSyn -icompiler/stranal -icompiler/typecheck -icompiler/types -icompiler/utils -icompiler/vectorise -icompiler/stage1/build -icompiler/stage1/build/autogen -Icompiler/stage1/build -Icompiler/stage1/build/autogen -Icompiler/. -Icompiler/parser -Icompiler/utils -Icompiler/stage1    -optP-include -optPcompiler/stage1/build/autogen/cabal_macros.h -package-id array-0.5.1.0-29bb26a0797af39b979b99b93e9d62fd -package-id base-4.8.0.0-82f21b46ed153fd6b19071a60f2e7937 -package-id binary-0.7.5.0 -package-id bytestring-0.10.6.0-79779027caa792766a3e8dc3e9cb98de -package-id containers-0.5.6.2-90712e174b339b5587c1656969878fb0 -package-id directory-1.2.2.0-73de5f636b1ca4c49aef15924617292c -package-id filepath-1.4.0.0-129f3fdd2b5de4f823a2641d7cf29327 -package-id ghc-boot-0.0.0.0 -package-id hoopl-3.10.2.0 -package-id hpc-0.6.0.2 -package-id process-1.2.3.0-77cd256a28bb4c7cc8cecb076a8fbc37 -package-id template-haskell-2.11.0.0 -package-id time-1.5.0.1-f5db9cf4a7dcb8716611e730437a1fd6 -package-id transformers-0.4.3.0 -package-id unix-2.7.1.0-57629c7ceba7cbcf210cc85471e45e07 -Wall -fno-warn-name-shadowing -this-package-key ghc -XHaskell2010 -DSTAGE=1 -Rghc-timing  -fwarn-tabs  -no-user-package-db -rtsopts      -odir compiler/stage1/build -hidir compiler/stage1/build -stubdir compiler/stage1/build    -c compiler/utils/Outputable.hs -o compiler/stage1/build/Outputable.o
Nov 16 2015, 5:48 AM

Nov 12 2015

kgardas added a comment to D1467: rules/haddock: Set __HADDOCK_VERSION__.

Hi,
I've tested advised:

echo $((2*1000 + 16*10 + 0))

and on both Solaris and OpenBSD I got the expected 2160. So this works well...

Nov 12 2015, 5:14 AM

Nov 11 2015

kgardas committed rGHC9bea234dbe3b: fix RTS Linker on platforms without SHN_XINDEX support (authored by kgardas).
fix RTS Linker on platforms without SHN_XINDEX support
Nov 11 2015, 3:27 PM
kgardas closed D1446: - fix compilation of RTS Linker on platforms where SHN_XINDEX symbol is not defined and/or supported (like OpenBSD). by committing rGHC9bea234dbe3b: fix RTS Linker on platforms without SHN_XINDEX support.
Nov 11 2015, 3:27 PM
kgardas added a comment to D1446: - fix compilation of RTS Linker on platforms where SHN_XINDEX symbol is not defined and/or supported (like OpenBSD)..

Ben, I truly admire Erik's work on Linker. I also feel kind of guilty to kind of reverse its direction with this patch. On the other hand I tried to have that as simple as possible for Erik to exactly see where the culprit is. BTW: the issue is not only in SHN_INDEX being undefined but also in SHT_SYMTAB_SHNDX which is neither defined. In the current patch version this is hidden by SHN_INDEX #ifdef so fixed. Anyway, I still think there is a possibility to refactor this cleanly, but IMHO it's better when one man does this. There is too much code going into Linker.c these days and too much breakage slipping from it so no need to make things even more complex by stepping on Erik's foots with any attempt to cleverly refactor this into a clean code...
Anyway, if I understand this right, Erik does have final word here and even if you accept this code he still need to either ok this or require change(s). Erik, this is up to you now. Thanks for the review!

Nov 11 2015, 4:38 AM

Nov 10 2015

kgardas added a comment to D1381: Systools: read ELF section without calling readelf.

@thomie: silly me! I've kept in head a need to verify that this test passes on builder, but then submitted too quickly. :-) Of course since it already fails this is no regression so for my platforms this D looks fine.

Nov 10 2015, 4:31 AM
kgardas added a comment to D1381: Systools: read ELF section without calling readelf.

@thomie: Solaris/i386 runs fine. Solaris/amd64 fails with:

=====> recomp011(normal) 1 of 1 [0, 0, 0] 
cd . && $MAKE -s --no-print-directory recomp011    </dev/null > recomp011.run.stdout 2> recomp011.run.stderr
Actual stdout output differs from expected:
Warning: missing newline at end of file ./recomp011.stdout.normalised
Warning: missing newline at end of file ./recomp011.run.stdout.normalised
--- ./recomp011.stdout.normalised       Tue Nov 10 10:25:19 2015
+++ ./recomp011.run.stdout.normalised   Tue Nov 10 10:25:19 2015
@@ -1,10 +1,6 @@
 [1 of 1] Compiling Main             ( Main.hs, Main.o )
 Linking Main ...
 42
-[1 of 1] Compiling Main             ( Main.hs, Main.o ) [B.hsinc changed]
-Linking Main ...
-43
-[1 of 1] Compiling Main             ( Main.hs, Main.o ) [A.hsinc changed]
-Linking Main ...
-4343
-4343
+42
+42
+42
*** unexpected failure for recomp011(normal)
Nov 10 2015, 3:31 AM

Nov 7 2015

kgardas retitled D1446: - fix compilation of RTS Linker on platforms where SHN_XINDEX symbol is not defined and/or supported (like OpenBSD). from to - fix compilation of RTS Linker on platforms where SHN_XINDEX symbol is not defined and/or supported (like OpenBSD)..
Nov 7 2015, 8:14 AM
kgardas retitled D1445: - add OpenBSD specific RTS symbols from to - add OpenBSD specific RTS symbols.
Nov 7 2015, 8:09 AM

Nov 2 2015

kgardas committed rGHCc00c5e5ba619: get rid of Elf32/Elf64_Section as this is a non-portable Linux-ism. (authored by kgardas).
get rid of Elf32/Elf64_Section as this is a non-portable Linux-ism.
Nov 2 2015, 1:21 AM
kgardas closed D1419: get rid of Elf32/Elf64_Section as this is a non-portable Linux-ism. by committing rGHCc00c5e5ba619: get rid of Elf32/Elf64_Section as this is a non-portable Linux-ism..
Nov 2 2015, 1:21 AM

Nov 1 2015

kgardas added a comment to D1419: get rid of Elf32/Elf64_Section as this is a non-portable Linux-ism..

@bgamari: Thanks for letting me know. Now, it's clear. :-)

Nov 1 2015, 5:09 PM
kgardas added a comment to D1419: get rid of Elf32/Elf64_Section as this is a non-portable Linux-ism..

@erikd: Any comment to your do-not-approve sign? I would really appreciate that. Thanks! Karel

Nov 1 2015, 3:24 PM
kgardas retitled D1419: get rid of Elf32/Elf64_Section as this is a non-portable Linux-ism. from to get rid of Elf32/Elf64_Section as this is a non-portable Linux-ism..
Nov 1 2015, 3:14 PM

Oct 31 2015

kgardas updated the diff for D1410: enforce linkage with pthread library on OpenBSD since OpenBSD's libffi requires that.

Adding some comments to not confuse future code reader

Oct 31 2015, 5:34 PM
kgardas committed rGHCbc7cc25676a8: disable large address space on OpenBSD (authored by kgardas).
disable large address space on OpenBSD
Oct 31 2015, 5:25 PM
kgardas closed D1411: disable large address space on OpenBSD by committing rGHCbc7cc25676a8: disable large address space on OpenBSD.
Oct 31 2015, 5:25 PM
kgardas retitled D1411: disable large address space on OpenBSD from to disable large address space on OpenBSD.
Oct 31 2015, 5:19 PM
kgardas retitled D1410: enforce linkage with pthread library on OpenBSD since OpenBSD's libffi requires that from to enforce linkage with pthread library on OpenBSD since OpenBSD's libffi requires that.
Oct 31 2015, 5:16 PM

Oct 22 2015

kgardas added a comment to D1326: Handle platforms with renamed "readelf".

Someone adds me as reviewer to this, so I think I will just comment: honestly I do not like the way configuration is handled. I definitely think we should stay with what we have today with --with-<tool>=<tool path>. I see author does not agree with this but such is my feeling that it's better to use kind of common way, otherwise it will be inconvenient for GHC builders/advanced-users just to remember exactly this and this tool needs different way. Anyway, I still think that --with-<tool> also supports authors way of configuration: AR=gar NM=nm ./configure.... -- so I think this more universal...
Otherwise the patch looks OK, at least what I see in it...

Oct 22 2015, 4:13 PM · GHC