int-index (Vladislav Zavialov)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 25 2014, 3:35 AM (243 w, 1 d)

Recent Activity

Wed, May 8

Marge Bot <ben+marge-bot@smart-cactus.org> committed rGHC396e01b472bb: Add a regression test for #14548 (authored by int-index).
Add a regression test for #14548
Wed, May 8, 3:17 PM

Mon, May 6

Marge Bot <ben+marge-bot@smart-cactus.org> committed rGHCead3f835e243: 'warnSpaceAfterBang' only in patterns (#16619) (authored by int-index).
'warnSpaceAfterBang' only in patterns (#16619)
Mon, May 6, 8:55 AM

Thu, Apr 25

Marge Bot <ben+marge-bot@smart-cactus.org> committed rGHCf85efdec3e05: checkPattern error hint is PV context (authored by int-index).
checkPattern error hint is PV context
Thu, Apr 25, 1:37 PM
Marge Bot <ben+marge-bot@smart-cactus.org> committed rGHC0fc69416f5ed: Introduce MonadP, make PV a newtype (authored by int-index).
Introduce MonadP, make PV a newtype
Thu, Apr 25, 1:36 PM

Apr 22 2019

Marge Bot <ben+marge-bot@smart-cactus.org> committed rGHC1959bad3feb9: Stop misusing EWildPat in pattern match coverage checking (authored by int-index).
Stop misusing EWildPat in pattern match coverage checking
Apr 22 2019, 2:01 PM

Apr 19 2019

Marge Bot <ben+marge-bot@smart-cactus.org> committed rGHCe7280c93ef8f: Tagless final encoding of ExpCmdI in the parser (authored by int-index).
Tagless final encoding of ExpCmdI in the parser
Apr 19 2019, 10:55 PM

Apr 2 2019

int-index committed rGHCa11b42ebb897: User's Guide: forall is a keyword nowadays (authored by int-index).
User's Guide: forall is a keyword nowadays
Apr 2 2019, 3:56 PM
int-index committed rGHCe761dbb2df53: Dot/bang operators in export lists (Trac #16339) (authored by int-index).
Dot/bang operators in export lists (Trac #16339)
Apr 2 2019, 3:56 PM
int-index committed rGHCd70eda19335f: 'forall' always a keyword, plus the dot type operator (authored by int-index).
'forall' always a keyword, plus the dot type operator
Apr 2 2019, 3:56 PM

Mar 9 2019

Marge Bot <ben+marge-bot@smart-cactus.org> committed rGHC826282540492: Testsuite: use 'fragile' instead of 'skip' for T3424, T14697 (authored by int-index).
Testsuite: use 'fragile' instead of 'skip' for T3424, T14697
Mar 9 2019, 1:11 AM

Mar 4 2019

Marge Bot <ben+marge-bot@smart-cactus.org> committed rGHC2e8f664957dc: Fix intermittent hie002 failure (authored by int-index).
Fix intermittent hie002 failure
Mar 4 2019, 3:09 PM
Marge Bot <ben+marge-bot@smart-cactus.org> committed rGHC5bc195b1fe78: Treat kind/type variables identically, demolish FKTV (authored by int-index).
Treat kind/type variables identically, demolish FKTV
Mar 4 2019, 3:09 PM
Marge Bot <ben+marge-bot@smart-cactus.org> committed rGHC4dbacba5d283: Skip T3424 when fast() (authored by int-index).
Skip T3424 when fast()
Mar 4 2019, 3:09 PM
int-index committed rGHCf320f3b2f2f4: Fix the ghci063 test on Darwin (Trac #16201) (authored by int-index).
Fix the ghci063 test on Darwin (Trac #16201)
Mar 4 2019, 3:09 PM
Marge Bot <ben+marge-bot@smart-cactus.org> committed rGHC14586f5d737e: Disable fragile test cases: T14697 T5559 T3424 (authored by int-index).
Disable fragile test cases: T14697 T5559 T3424
Mar 4 2019, 3:09 PM
Marge Bot <ben+marge-bot@smart-cactus.org> committed rGHCae7d1ff62f61: User's Guide: forall is a keyword nowadays (authored by int-index).
User's Guide: forall is a keyword nowadays
Mar 4 2019, 3:09 PM
Marge Bot <ben+marge-bot@smart-cactus.org> committed rGHC889701877791: User's Guide: update info on kind inference (authored by int-index).
User's Guide: update info on kind inference
Mar 4 2019, 3:09 PM
Marge Bot <ben+marge-bot@smart-cactus.org> committed rGHCe61f6e35e2ff: Expression/command ambiguity resolution (authored by int-index).
Expression/command ambiguity resolution
Mar 4 2019, 3:09 PM
Marge Bot <ben+marge-bot@smart-cactus.org> committed rGHCe204431e5a5e: Handle the (~) type operator in 'tyconsym' (authored by int-index).
Handle the (~) type operator in 'tyconsym'
Mar 4 2019, 1:07 PM
Marge Bot <ben+marge-bot@smart-cactus.org> committed rGHC2f4af71e73ac: Dot/bang operators in export lists (Trac #16339) (authored by int-index).
Dot/bang operators in export lists (Trac #16339)
Mar 4 2019, 1:07 PM
Marge Bot <ben+marge-bot@smart-cactus.org> committed rGHC1ffee940a011: Fix warnings and fatal parsing errors (authored by int-index).
Fix warnings and fatal parsing errors
Mar 4 2019, 1:07 PM
Marge Bot <ben+marge-bot@smart-cactus.org> committed rGHC887454d8889c: 'forall' always a keyword, plus the dot type operator (authored by int-index).
'forall' always a keyword, plus the dot type operator
Mar 4 2019, 1:07 PM
Marge Bot <ben+marge-bot@smart-cactus.org> committed rGHCb31df5caaebb: Hadrian: enable -Wcompat=error in the testsuite (authored by int-index).
Hadrian: enable -Wcompat=error in the testsuite
Mar 4 2019, 1:07 PM
Marge Bot <ben+marge-bot@smart-cactus.org> committed rGHC071bef18ccaf: Fix optSemi type in Parser.y (authored by int-index).
Fix optSemi type in Parser.y
Mar 4 2019, 1:06 PM
Marge Bot <ben+marge-bot@smart-cactus.org> committed rGHC9292a183fd03: Add int-index as parser/* codeowner (authored by int-index).
Add int-index as parser/* codeowner
Mar 4 2019, 1:05 PM
Marge Bot <ben+marge-bot@smart-cactus.org> committed rGHCab4934230bb1: Refactor splice_exp in Parser.y (authored by int-index).
Refactor splice_exp in Parser.y
Mar 4 2019, 1:05 PM
Marge Bot <ben+marge-bot@smart-cactus.org> committed rGHCeeabeb92a62b: Report multiple errors (authored by int-index).
Report multiple errors
Mar 4 2019, 1:05 PM
Marge Bot <ben+marge-bot@smart-cactus.org> committed rGHC59516e4bbfc0: Fix missing space in ppr_cmd for HsCmdArrForm (authored by int-index).
Fix missing space in ppr_cmd for HsCmdArrForm
Mar 4 2019, 1:05 PM

Dec 18 2018

int-index added a comment to D5408: Introduce ExpPatFrame.

For HsCmd there really is no ambiguity at all! <...> The motivation here is NOT ambiguity but ONLY the desire not to duplicate the grammar of commands and expressions.

Dec 18 2018, 12:27 PM

Dec 14 2018

int-index added a comment to D5408: Introduce ExpPatFrame.

@simonpj Can we merge this, unless you have more questions/objections?

Dec 14 2018, 3:39 AM

Dec 11 2018

int-index added a comment to D5408: Introduce ExpPatFrame.

Good observation, thanks @goldfire. I couldn't decide if it's an intersection or a union, and now I see it's a union of intersections.

Dec 11 2018, 1:19 AM

Dec 10 2018

int-index added a comment to D5408: Introduce ExpPatFrame.

Can you elaborate on this? I don't get it. Commands can't appear in patterns either.

  1. do and if can appear in HsExpr with HsExpr as subtrees:
checkExpr (FrameIf c a b) = mkHsIf (checkExpr c) (checkExpr a) (checkExpr b)
checkExpr (FrameDo ctxt stmts) = mkHsDo ctxt (map checkExprStmt stmts)
Dec 10 2018, 5:25 PM
int-index added a comment to D5408: Introduce ExpPatFrame.

How about PTerm (for "parser term")?

Dec 10 2018, 3:19 PM
int-index added a comment to D5408: Introduce ExpPatFrame.

Would that not make the data type much smaller? Eg why do you have FrameStmt but not FrameBinds?

Dec 10 2018, 4:27 AM

Dec 7 2018

int-index added a comment to D5408: Introduce ExpPatFrame.

A few other stumbling blocks: HsLocalBinds (in HsLet, GRHSs) and Pat (in Match, Stmt).

Dec 7 2018, 12:17 PM
int-index added a comment to D5408: Introduce ExpPatFrame.

Found another option how to deal with ExprWithTySig: not using it. I instantiate XXExpr GhcPrePs with

Dec 7 2018, 8:28 AM
int-index added a comment to D5408: Introduce ExpPatFrame.

I am confused about this comment; what is dubious about having HsExpr (GhcPass GhcPp), where GhcPp is reserved for Pre-Parsing, as the type of expression-like entities that includes HsPat and HsCmd? Isn't it the same as your ExpPatFrame?

Dec 7 2018, 7:25 AM
int-index added a comment to D5408: Introduce ExpPatFrame.

I've added a new Plan G

Dec 7 2018, 5:07 AM
int-index added a comment to D5408: Introduce ExpPatFrame.

All of these passes are part of GHC, a single piece of software.

Dec 7 2018, 3:05 AM
int-index added a comment to D5408: Introduce ExpPatFrame.

To clarify, option one is:

Dec 7 2018, 2:29 AM

Dec 6 2018

int-index added a comment to D5408: Introduce ExpPatFrame.

@simonpj There are two options how I can introduce GhcPrePs:

Dec 6 2018, 11:46 AM
int-index added a comment to D5408: Introduce ExpPatFrame.

On the other hand, for Dependent Haskell we will probably have to merge HsExpr and HsType altogether, throughout the entire pipeline. So this bit of motivation is gone.

Dec 6 2018, 8:08 AM
int-index added a comment to D5408: Introduce ExpPatFrame.
we would create a new stage GhcPrePs for it.

Yes, that'd be fine.

We cannot use TTG for it: what type do we extend, HsExpr or HsPat?

Why "cannot"? Personally I'd extend HsExpr because that would mean that in the common case there little or no work to do.

Dec 6 2018, 7:07 AM
int-index added a comment to D5408: Introduce ExpPatFrame.

I'm very doubtful about the design though. Do we really need yet another huge data type?

Dec 6 2018, 6:27 AM
int-index added inline comments to D5229: Visible kind application.
Dec 6 2018, 12:47 AM

Dec 5 2018

int-index added inline comments to D5229: Visible kind application.
Dec 5 2018, 4:40 AM

Dec 4 2018

int-index updated the diff for D5408: Introduce ExpPatFrame.

Remove outdated TODO

Dec 4 2018, 10:37 AM
int-index updated the summary of D5408: Introduce ExpPatFrame.
Dec 4 2018, 10:25 AM
int-index updated the summary of D5408: Introduce ExpPatFrame.
Dec 4 2018, 10:25 AM
int-index updated the diff for D5408: Introduce ExpPatFrame.

Refactor 'checkCommand' to use ExpPatFrame

Dec 4 2018, 10:21 AM
int-index updated the diff for D5408: Introduce ExpPatFrame.

Rebase, use LExpPatFrame in 'checkValSigLhs'

Dec 4 2018, 4:54 AM
int-index added inline comments to D5229: Visible kind application.
Dec 4 2018, 4:20 AM

Dec 3 2018

int-index created D5408: Introduce ExpPatFrame.
Dec 3 2018, 8:25 PM

Oct 29 2018

int-index updated the diff for D5221: Lower precedence for {-# UNPACK #-}.

Rebase

Oct 29 2018, 8:17 AM

Oct 28 2018

int-index accepted D5274: Fix #15815 by parenthesizing the arguments to infix ~.
Oct 28 2018, 12:50 PM

Oct 27 2018

int-index added a comment to D4894: More explicit foralls (GHC Proposal 0007).

Can we also add a test case (maybe extend T15264) that the new forall forms trigger the implicit kind variables warning?

Oct 27 2018, 5:00 PM
int-index accepted D5170: RTS linker: don't crash early when not finding extra DLL, most likely it's not needed.

I'd be happy to see a test case as I asked before, but overall looks good now.

Oct 27 2018, 7:03 AM
int-index added inline comments to D5170: RTS linker: don't crash early when not finding extra DLL, most likely it's not needed.
Oct 27 2018, 3:48 AM
int-index requested changes to D5170: RTS linker: don't crash early when not finding extra DLL, most likely it's not needed.

You marked https://phabricator.haskell.org/D5170#inline-41160 as "Done" but it's not done.

Oct 27 2018, 3:32 AM

Oct 25 2018

int-index added a comment to D5036: [TTG: Handling Source Locations] Foundation and Pat.

Many functions seem to treat NewPat in a predefined manner instead of recursing into the Pat inside it – I don't see how it could possibly work. Does this rely on the caller to call dL on the pattern? Very fragile, let's not do that.

Oct 25 2018, 4:33 PM
int-index added a comment to D5221: Lower precedence for {-# UNPACK #-}.

could you link to the proposal in the description?

Oct 25 2018, 9:08 AM
int-index updated the summary of D5221: Lower precedence for {-# UNPACK #-}.
Oct 25 2018, 8:41 AM
int-index updated the diff for D5221: Lower precedence for {-# UNPACK #-}.

Rebase, add proposal link to the commit message

Oct 25 2018, 8:37 AM

Oct 24 2018

int-index updated the diff for D5221: Lower precedence for {-# UNPACK #-}.

Update comments, rebase

Oct 24 2018, 4:20 PM
int-index added inline comments to D5221: Lower precedence for {-# UNPACK #-}.
Oct 24 2018, 3:44 PM

Oct 22 2018

int-index added inline comments to D5170: RTS linker: don't crash early when not finding extra DLL, most likely it's not needed.
Oct 22 2018, 2:45 PM
int-index added inline comments to D5170: RTS linker: don't crash early when not finding extra DLL, most likely it's not needed.
Oct 22 2018, 11:21 AM

Oct 20 2018

int-index requested review of D5221: Lower precedence for {-# UNPACK #-}.
Oct 20 2018, 12:31 PM
int-index added a comment to D5221: Lower precedence for {-# UNPACK #-}.

@bgamari The proposal was accepted, would you mind taking another look?

Oct 20 2018, 12:29 PM

Oct 19 2018

int-index added a comment to D5170: RTS linker: don't crash early when not finding extra DLL, most likely it's not needed.

Current documentation talks about GHCi, but we actually face the same issue when using TemplateHaskell because it loads library dynamically, too. Could you mention TemplateHaskell there?

Oct 19 2018, 9:35 AM

Oct 18 2018

int-index added a comment to D5229: Visible kind application.

@RyanGlScott I'm fairly sure [] is parsed as a HsVar:

Oct 18 2018, 6:58 PM
int-index added a comment to D5229: Visible kind application.

I will special-case [] in the type-checker.

Oct 18 2018, 6:18 PM
int-index added inline comments to D5229: Visible kind application.
Oct 18 2018, 10:40 AM
int-index added inline comments to D5229: Visible kind application.
Oct 18 2018, 5:48 AM

Oct 17 2018

int-index added a comment to D5229: Visible kind application.

Great work! I've left a few comments about parsing.

Oct 17 2018, 8:09 AM

Oct 15 2018

int-index abandoned D5218: Meaning-preserving parsing of SCC/GENERATED/CORE annotations.

The discussion under https://github.com/ghc-proposals/ghc-proposals/pull/176 indicates that it's far from clear how exactly to proceed here, and it's likely that we'll end up with something different from this Diff, so I'll mark it as abandoned.

Oct 15 2018, 7:20 AM
int-index added a comment to D5170: RTS linker: don't crash early when not finding extra DLL, most likely it's not needed.

I have tested this patch using https://github.com/serokell/trac11042 and it indeed has the intended effect – the error is now a warning:

Oct 15 2018, 3:59 AM

Oct 13 2018

int-index added a comment to D5200: Enable -Wcompat=error in the testsuite.

CI failures are likely unrelated to this change, two tests have "stat too good":

Oct 13 2018, 2:55 AM

Oct 12 2018

int-index abandoned D5047: Return HsType GhcTc from tc_hs_type.

So do I. So, int-index, would be acceptable to follow path (1) for now?

Oct 12 2018, 1:37 PM
int-index updated the summary of D5200: Enable -Wcompat=error in the testsuite.
Oct 12 2018, 1:17 PM
int-index updated the diff for D5200: Enable -Wcompat=error in the testsuite.

Rebase

Oct 12 2018, 1:08 PM
int-index added a comment to D5044: Include -fwarn-star-is-type in -Wcompat.

Linux CI has passed: https://circleci.com/gh/ghc/ghc-diffs/457

Oct 12 2018, 8:54 AM
int-index added a comment to D5200: Enable -Wcompat=error in the testsuite.

On the other hand, one could argue that even failing test cases should pass -Wcompat's scrutiny.

Oct 12 2018, 8:01 AM
int-index updated the diff for D5200: Enable -Wcompat=error in the testsuite.

Update test cases

Oct 12 2018, 8:01 AM

Oct 11 2018

int-index updated the diff for D5221: Lower precedence for {-# UNPACK #-}.

Testsuite correction

Oct 11 2018, 8:29 AM
int-index added a comment to D5221: Lower precedence for {-# UNPACK #-}.

This change is not yet accepted by the GHC Steering Committee, but I prepared a patch for the case it gets accepted.

Oct 11 2018, 5:21 AM
int-index created D5221: Lower precedence for {-# UNPACK #-}.
Oct 11 2018, 5:20 AM

Oct 10 2018

int-index updated the diff for D5218: Meaning-preserving parsing of SCC/GENERATED/CORE annotations.

Workaround for operator sections

Oct 10 2018, 5:48 AM

Oct 9 2018

int-index added a comment to D5218: Meaning-preserving parsing of SCC/GENERATED/CORE annotations.

I tried to build it and test it but it doesn't build

Oct 9 2018, 4:43 PM
int-index added a comment to D5218: Meaning-preserving parsing of SCC/GENERATED/CORE annotations.

I tried to build it and test it but it doesn't build

Oct 9 2018, 4:05 PM
int-index added a comment to D5218: Meaning-preserving parsing of SCC/GENERATED/CORE annotations.

@osa1 I disagree with your analysis. With this patch, the examples you gave should parse as before, and no action from the users is needed in these cases. The change is that when the annotation is used after an infix operator, it applies only to the RHS of this operator. And in your examples there aren't even any operators.

Oct 9 2018, 3:32 PM
int-index added a comment to D5044: Include -fwarn-star-is-type in -Wcompat.

I updated the migration guide as requested: https://ghc.haskell.org/trac/ghc/wiki/Migration/8.8?action=diff&version=5

Oct 9 2018, 2:41 PM
int-index updated the diff for D5044: Include -fwarn-star-is-type in -Wcompat.

Update documentation

Oct 9 2018, 2:20 PM
int-index created D5218: Meaning-preserving parsing of SCC/GENERATED/CORE annotations.
Oct 9 2018, 1:36 PM
int-index updated the diff for D5044: Include -fwarn-star-is-type in -Wcompat.

Rebase

Oct 9 2018, 11:00 AM

Oct 8 2018

int-index added a comment to D5044: Include -fwarn-star-is-type in -Wcompat.

The CI failures do not seem related to the change:

Oct 8 2018, 7:41 AM

Oct 5 2018

int-index added a comment to D5205: Refactor NewHsTypeX to DerivedCoreTy.

I'm undecided how to proceed here because it appears the invariant about the type being closed is violated in current code.

Oct 5 2018, 9:27 AM
int-index created D5205: Refactor NewHsTypeX to DerivedCoreTy.
Oct 5 2018, 4:52 AM
int-index updated the diff for D5044: Include -fwarn-star-is-type in -Wcompat.

Rebase

Oct 5 2018, 1:55 AM

Oct 4 2018

int-index added a comment to D5044: Include -fwarn-star-is-type in -Wcompat.

Actually, let's merge this as is and add documentation for -Wstar-is-type in a new diff. That will make it easier to backport to 8.6.

Oct 4 2018, 11:06 AM