int-index (Vladislav Zavialov)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 25 2014, 3:35 AM (208 w, 4 d)

Recent Activity

Mon, Aug 27

int-index added a comment to D5047: Return HsType GhcTc from tc_hs_type.

The downside to @int-index's approach is that it requires adding a lot of extension fields

Mon, Aug 27, 6:20 PM

Aug 22 2018

int-index added a comment to D5047: Return HsType GhcTc from tc_hs_type.

I advocate the less ambitious version, which still lets you do the Trac Trac #12088 stuff, doesn't it?

Aug 22 2018, 11:06 AM
int-index added a comment to D5047: Return HsType GhcTc from tc_hs_type.

In fact, it looks as if something entirely new is happening: you are using the extension-field of the HsType constructors to store a desugared version of type. So in fact tc_hs_type is returning both an HsType Tc, and (in the extension fields) a desugared version of every sub-tree. Is this really what we want?

Aug 22 2018, 8:18 AM

Aug 21 2018

int-index added inline comments to D5047: Return HsType GhcTc from tc_hs_type.
Aug 21 2018, 2:50 PM

Aug 17 2018

int-index added a comment to D5023: Parse the ~ and ! type operators consistently.

@int-index: would you be interested in having a go at this? You seem knowledgeable!

Aug 17 2018, 9:31 AM
int-index added a comment to D5023: Parse the ~ and ! type operators consistently.

@RyanGlScott Here's a test case:

Aug 17 2018, 7:35 AM
int-index added a comment to D5023: Parse the ~ and ! type operators consistently.

That would allow f :: T (a ~ b) and f :: T (a ! b) to parse -- I have no idea what happens to them now.

Aug 17 2018, 6:25 AM
int-index added a comment to D5023: Parse the ~ and ! type operators consistently.

I have not looked in detail, but I'm worried that splitBangTyOps is called only at the top level of a type. What about a type like T (a ! b) or T (a ~ b), where the bang or tilde is definitely a type operator.

Aug 17 2018, 6:11 AM

Aug 14 2018

int-index updated the diff for D5044: Include -fwarn-star-is-type in -Wcompat.

Rebase

Aug 14 2018, 2:12 PM

Aug 5 2018

int-index created D5047: Return HsType GhcTc from tc_hs_type.
Aug 5 2018, 1:00 PM
int-index added a comment to D5044: Include -fwarn-star-is-type in -Wcompat.

Needs https://github.com/haskell/cabal/pull/5497, but other than that it passes ./validate --fast on my machine.

Aug 5 2018, 7:41 AM
int-index updated the diff for D5044: Include -fwarn-star-is-type in -Wcompat.

Add a test case

Aug 5 2018, 7:40 AM

Aug 4 2018

int-index updated the summary of D5044: Include -fwarn-star-is-type in -Wcompat.
Aug 4 2018, 4:48 PM
int-index created D5044: Include -fwarn-star-is-type in -Wcompat.
Aug 4 2018, 4:45 PM

Aug 1 2018

int-index added a comment to D5023: Parse the ~ and ! type operators consistently.

I'm extremely confused here. The default fixity for infix type operators is infixl 9 anyways—I wouldn't expect right-associativity by default!

Aug 1 2018, 8:17 AM
int-index added a comment to D5023: Parse the ~ and ! type operators consistently.

Currently, documentation for mergeOps states that

Aug 1 2018, 8:10 AM
int-index updated the diff for D5022: Fix #15415 and simplify tcWildCardBinders.

Rebase

Aug 1 2018, 2:01 AM
int-index added a comment to D5023: Parse the ~ and ! type operators consistently.

I considered doing this while I was refactoring splitTilde for the -XStarIsType patch. The problem with this approach is that now ! is absolutely the wrong fixity. All other type operators respect fixity declarations.

Aug 1 2018, 1:51 AM

Jul 31 2018

int-index added a comment to D5022: Fix #15415 and simplify tcWildCardBinders.

@RyanGlScott, I do not understand the KindOf example, as the subsequent command :k _ doesn't use KindOf. The Dependent example, on the other hand, looks interesting. Indeed, your intuition was right and the hole leaked to the output. I fixed it and added Dependent to the test case.

Jul 31 2018, 10:58 AM
int-index updated the diff for D5022: Fix #15415 and simplify tcWildCardBinders.

Emit wildcard hole constraints

Jul 31 2018, 10:28 AM

Jul 30 2018

int-index added a comment to D5022: Fix #15415 and simplify tcWildCardBinders.

Does it validate?

Jul 30 2018, 5:42 AM

Jul 29 2018

int-index created D5022: Fix #15415 and simplify tcWildCardBinders.
Jul 29 2018, 12:59 PM

Jul 16 2018

int-index updated the diff for D4865: Do not imply NoStarIsType by TypeOperators/TypeInType.

Rebase

Jul 16 2018, 6:46 AM

Jun 25 2018

int-index updated the diff for D4865: Do not imply NoStarIsType by TypeOperators/TypeInType.

Update documentation and warning message

Jun 25 2018, 10:27 PM

Jun 18 2018

int-index updated the diff for D4865: Do not imply NoStarIsType by TypeOperators/TypeInType.

Comments and rebase

Jun 18 2018, 10:09 PM
int-index added inline comments to D4865: Do not imply NoStarIsType by TypeOperators/TypeInType.
Jun 18 2018, 9:57 PM
int-index created D4865: Do not imply NoStarIsType by TypeOperators/TypeInType.
Jun 18 2018, 1:49 AM

Jun 16 2018

int-index updated the summary of D4860: Add -Werror=compat.
Jun 16 2018, 9:42 PM
int-index added a comment to D4860: Add -Werror=compat.

This implements the first part of Trac #15278:

Jun 16 2018, 9:12 PM
int-index created D4860: Add -Werror=compat.
Jun 16 2018, 9:12 PM

Jun 15 2018

int-index added inline comments to D4845: Quantify unfixed kind variables in CUSKs.
Jun 15 2018, 6:32 PM
int-index created D4850: No Unicode in Parser.y.
Jun 15 2018, 6:50 AM

Jun 14 2018

int-index added a comment to D4834: Warn about implicit kind variables with -Wcompat.

Should be fine now.

Jun 14 2018, 6:19 PM
int-index updated the diff for D4834: Warn about implicit kind variables with -Wcompat.

Wording and markup

Jun 14 2018, 6:02 PM
int-index added a comment to D4834: Warn about implicit kind variables with -Wcompat.

@int-index, could you add some discussion to the users guide (both in using-warnings.rst and the release notes)?

Jun 14 2018, 5:32 PM
int-index updated the diff for D4834: Warn about implicit kind variables with -Wcompat.

Documentation

Jun 14 2018, 5:32 PM
int-index updated the diff for D4834: Warn about implicit kind variables with -Wcompat.

Rebase

Jun 14 2018, 3:26 PM
int-index added a comment to D4748: Embrace -XTypeInType, add -XStarIsType.

@goldfire Thanks, I am sure glad to see this land. But what of the submodules? I thought Ben would bump them before merging this patch.

Jun 14 2018, 2:28 PM
int-index updated the diff for D4748: Embrace -XTypeInType, add -XStarIsType.

Remove XApp-stuff, add 'starInfo' comment

Jun 14 2018, 8:32 AM
int-index added inline comments to D4748: Embrace -XTypeInType, add -XStarIsType.
Jun 14 2018, 7:58 AM

Jun 13 2018

int-index updated the diff for D4834: Warn about implicit kind variables with -Wcompat.

Undo accidental commit of testsuite/config/ghc

Jun 13 2018, 8:19 PM
int-index updated the diff for D4834: Warn about implicit kind variables with -Wcompat.

Location info, no -Werror, more comprehensive test

Jun 13 2018, 8:16 PM
int-index added a comment to D4834: Warn about implicit kind variables with -Wcompat.

Here are additional test failures if I specify EXTRA_HC_OPTS="-fwarn-implicit-kind-vars -Werror=implicit-kind-vars":

Jun 13 2018, 7:12 PM
int-index updated the diff for D4834: Warn about implicit kind variables with -Wcompat.

Testsuite update

Jun 13 2018, 5:13 PM
int-index updated the diff for D4748: Embrace -XTypeInType, add -XStarIsType.

Comments

Jun 13 2018, 3:49 PM
int-index updated the diff for D4748: Embrace -XTypeInType, add -XStarIsType.

Comments

Jun 13 2018, 3:23 PM
int-index updated the diff for D4748: Embrace -XTypeInType, add -XStarIsType.

fix ./validate

Jun 13 2018, 2:31 PM
int-index updated the diff for D4748: Embrace -XTypeInType, add -XStarIsType.

Different parsing approach for better error messages, cleanup

Jun 13 2018, 12:02 PM

Jun 12 2018

int-index added a parent revision for D4834: Warn about implicit kind variables with -Wcompat: D4748: Embrace -XTypeInType, add -XStarIsType.
Jun 12 2018, 7:23 AM
int-index added a child revision for D4748: Embrace -XTypeInType, add -XStarIsType: D4834: Warn about implicit kind variables with -Wcompat.
Jun 12 2018, 7:23 AM
int-index added a comment to D4834: Warn about implicit kind variables with -Wcompat.

I'm sure it is, but a test would be nice to ensure that the format doesn't degrade in the future.

Jun 12 2018, 7:22 AM
int-index added a comment to D4834: Warn about implicit kind variables with -Wcompat.

Note: I didn't wait for it to build locally, submitted in its current WIP form to delegate that to CI.

Jun 12 2018, 6:40 AM
int-index added a comment to D4834: Warn about implicit kind variables with -Wcompat.

This deserves at least one test to ensure that the error message is formatted properly.

Jun 12 2018, 6:40 AM
int-index created D4834: Warn about implicit kind variables with -Wcompat.
Jun 12 2018, 6:24 AM

Jun 11 2018

int-index added a comment to D4748: Embrace -XTypeInType, add -XStarIsType.

I didn't see any update to the release notes

Jun 11 2018, 11:16 PM

Jun 10 2018

int-index updated the summary of D4748: Embrace -XTypeInType, add -XStarIsType.
Jun 10 2018, 11:23 AM
int-index updated the summary of D4748: Embrace -XTypeInType, add -XStarIsType.
Jun 10 2018, 11:23 AM
int-index updated the diff for D4748: Embrace -XTypeInType, add -XStarIsType.

Rebase

Jun 10 2018, 11:07 AM

Jun 9 2018

int-index updated the diff for D4748: Embrace -XTypeInType, add -XStarIsType.

Attempt to fix testsuite failures

Jun 9 2018, 11:16 AM

Jun 8 2018

int-index updated the diff for D4748: Embrace -XTypeInType, add -XStarIsType.

Don't include -fwarn-star-is-type in -Wcompat yet

Jun 8 2018, 5:59 PM

Jun 7 2018

int-index updated the diff for D4748: Embrace -XTypeInType, add -XStarIsType.

Add -fwarn-star-is-type

Jun 7 2018, 7:50 PM
int-index updated the diff for D4748: Embrace -XTypeInType, add -XStarIsType.

Update the User's Guide and submodules

Jun 7 2018, 5:58 PM
int-index added a comment to D4748: Embrace -XTypeInType, add -XStarIsType.

I think this Diff is ready for another round of review.

Jun 7 2018, 7:54 AM
int-index updated the diff for D4748: Embrace -XTypeInType, add -XStarIsType.

Remove HsAppsTy, add HsStarTy, restore error message

Jun 7 2018, 7:41 AM

Jun 2 2018

int-index added inline comments to D4748: Embrace -XTypeInType, add -XStarIsType.
Jun 2 2018, 2:18 AM

May 29 2018

int-index updated the diff for D4748: Embrace -XTypeInType, add -XStarIsType.

Remove a couple more of occurences of -XTypeInType

May 29 2018, 4:49 AM
int-index created D4748: Embrace -XTypeInType, add -XStarIsType.
May 29 2018, 2:27 AM
int-index added inline comments to D4724: Implement QuantifiedConstraints.
May 29 2018, 2:23 AM

Nov 20 2017

int-index created D4213: Test Trac #14488.
Nov 20 2017, 12:58 PM

Jan 11 2017

int-index added a comment to D2899: Generic and Generic1 instances for tuples.

Also, you (@int-index) mentioned in https://phabricator.haskell.org/D2899#84342 that you had some code that relies on this... I'd be curious to know what code requires these extraordinarily large tuples :)

Jan 11 2017, 11:20 AM

Dec 28 2016

int-index added a comment to D2899: Generic and Generic1 instances for tuples.

Hello Ben,

Dec 28 2016, 4:47 PM

Dec 26 2016

int-index added a comment to D2899: Generic and Generic1 instances for tuples.

Encouraging/discouraging should be done in documentation and/or compiler warnings. The lack of those instances prevents my (correct) code from compiling and causes unnecessary frustration, for now I had to resort to orphan instances.

Dec 26 2016, 5:39 PM
int-index retitled D2899: Generic and Generic1 instances for tuples from to Generic and Generic1 instances for tuples.
Dec 26 2016, 2:12 PM

Dec 23 2016

int-index retitled D2897: Refactor tyConUnique into a function from to Refactor tyConUnique into a function.
Dec 23 2016, 7:10 PM

Dec 6 2016

int-index updated the diff for D2788: Test Trac #12919.
Dec 6 2016, 4:46 PM
int-index updated the diff for D2788: Test Trac #12919.

Marked as expect_broken

Dec 6 2016, 4:35 PM
int-index added a comment to D2788: Test Trac #12919.

When I created this differential, I didn't know that the test causes a Core Lint error. Do we wait for a fix first, or is it OK to have a broken test in master?

Dec 6 2016, 3:38 AM

Dec 2 2016

int-index retitled D2788: Test Trac #12919 from to Test Trac #12919.
Dec 2 2016, 5:04 PM