hvr (Herbert Valerio Riedel)Administrator
mortal human being

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Jun 2 2014, 7:21 AM (151 w, 6 d)
Roles
Administrator
Availability
Available

Macro ishouldbuy:  I should go out more

Recent Activity

Tue, Apr 25

hvr added a comment to D2973: PPC NCG: Implement callish prim ops.

I've manually run the numeric testcases, and it looks all good to me! Let's merge this!

Tue, Apr 25, 2:14 AM

Mon, Apr 24

hvr accepted D2973: PPC NCG: Implement callish prim ops.

Sorry this took me so long! I finally got GHC HEAD to build again on AIX, and was able to apply this patch cleanly to GHC 8.2.1.

Mon, Apr 24, 5:17 PM
hvr committed rGHCcd10a2328249: Guard yet another /bin/sh `for in` loop against empty vars (authored by hvr).
Guard yet another /bin/sh `for in` loop against empty vars
Mon, Apr 24, 3:25 PM

Sun, Apr 23

hvr committed rGHC2fa6873faf16: Fix compilation for !HAVE_FLOCK (authored by hvr).
Fix compilation for !HAVE_FLOCK
Sun, Apr 23, 8:43 AM
hvr committed rGHC0d975a623d6a: Minor reordering of `#include`s fixing compilation on AIX (authored by hvr).
Minor reordering of `#include`s fixing compilation on AIX
Sun, Apr 23, 8:32 AM

Fri, Apr 21

hvr committed rGHC58a59d035102: Sync up terminfo submodule to 0.4.1.0 release tag (authored by hvr).
Sync up terminfo submodule to 0.4.1.0 release tag
Fri, Apr 21, 5:51 PM
hvr committed rGHCa1ffd70835fb: Sync up haskeline submodule to 0.7.4.0 release tag (authored by hvr).
Sync up haskeline submodule to 0.7.4.0 release tag
Fri, Apr 21, 4:18 AM

Tue, Apr 18

hvr committed rGHC765a2e71f3dc: Update xhtml submodule to potential 3000.2.2 release commit (authored by hvr).
Update xhtml submodule to potential 3000.2.2 release commit
Tue, Apr 18, 10:24 AM

Mon, Apr 17

hvr added a comment to rGHC79848f18805a: aclocal.m4: respect user's --with-ar= choice.

@bgamari, yes indeed. The idea was to extend on Autoconf's convention to honor env-vars such as CFLAGS/LDFLAGS/CC etc.

Mon, Apr 17, 10:44 AM

Tue, Apr 4

hvr updated the diff for D3415: Implement {set,clear,complement}BitBigNat primitives.
  • Silence -Wunbanged-strict-patterns
Tue, Apr 4, 9:22 AM
hvr created D3415: Implement {set,clear,complement}BitBigNat primitives.
Tue, Apr 4, 1:53 AM

Mar 16 2017

hvr accepted D3353: GHC.Word: Move Read instances to GHC.Read.

Seems like a good idea to me since it simplifies the module import graph a little bit... :-)

Mar 16 2017, 2:12 PM

Jan 28 2017

hvr accepted D3034: Simplify minusInteger in integer-gmp slightly.
Jan 28 2017, 12:50 PM

Dec 6 2016

hvr added a comment to D2791: NCG: Implement trivColorable for PowerPC 64-bit.

@trommler just wondering, how does register allocation work right now for ppc64?

Dec 6 2016, 2:14 AM

Nov 21 2016

hvr accepted D2728: Replace -fshow-source-paths with -fhide-source-paths.

@hsyl20 Thanks for going through the hassle to rework the code yet again!

Nov 21 2016, 9:36 AM
hvr awarded D2728: Replace -fshow-source-paths with -fhide-source-paths a Love token.
Nov 21 2016, 9:32 AM

Nov 7 2016

hvr added a comment to D2664: base: Add more POSIX types (fixes #12795).
In D2664#77652, @hvr wrote:

If not, should we have those?

I don't see why not. TBH, I don't really understand what a CTYPE annotation does in the first place,

Nov 7 2016, 10:37 AM

Nov 4 2016

hvr requested changes to D2664: base: Add more POSIX types (fixes #12795).

This is mostly a question/concern rather than a change request: Do we have CTYPE annotations? If not, should we have those?

Nov 4 2016, 2:52 AM

Oct 19 2016

hvr added a comment to D2615: rts/linker: Move loadArchive to new source file.

@bgamari for such exceptional cases we can temporarily bypass the git hooks when pushing the respective commit. Ping me on IRC when you're around...

Oct 19 2016, 2:07 AM

Sep 26 2016

hvr added a member for Haskell.org Infrastructure: bgamari.
Sep 26 2016, 3:17 PM

Sep 16 2016

hvr accepted D2530: Remove directories from include paths.

lgtm, I wanted something like this in the past already... :-)

Sep 16 2016, 12:43 AM

Aug 10 2016

hvr added a comment to D2423: Fix getExecutablePath to return absolute path.

related: http://stackoverflow.com/questions/1023306/finding-current-executables-path-without-proc-self-exe

Aug 10 2016, 3:06 PM
hvr requested changes to D2423: Fix getExecutablePath to return absolute path.

I just stumbled over a bug that was introduced in cabal due to https://github.com/haskell/cabal/pull/3531

Aug 10 2016, 2:36 PM

Jul 25 2016

hvr requested changes to D2425: Darwin: Detect broken NM program at configure time.

Unfortunately I have to strongly disagree with this workaround.

Jul 25 2016, 6:26 AM

Jul 21 2016

hvr accepted D2418: Add deepseq dependency and a few NFData instances.

I'd prefer it if manual NFData instances were placed closer to their definition, so make it more obvious there's an NFData to possibly adapt when the data type def changes in any way.

Jul 21 2016, 9:03 AM

Jul 1 2016

hvr added inline comments to D2375: Cleanup PosixSource.h.
Jul 1 2016, 2:48 AM
hvr added a comment to D2375: Cleanup PosixSource.h.

If this patch works, then PosixSource.h is almost redundant, as it only provides 2 definitions beyond ghcplatform.h. So I'm wondering if we need this header at all, and whether we shouldn't just have the defines provided by ghcautoconf.h, which is also the place to detect whether e.g. you need _DARWIN_C_SOURCE at all (and thereby avoiding yet another #if defined(..._HOST_OS))

Jul 1 2016, 2:39 AM

Jun 22 2016

hvr committed rGHC81d889729c34: Implement {set,clear,complement}BitBigNat primitives (authored by hvr).
Implement {set,clear,complement}BitBigNat primitives
Jun 22 2016, 3:54 AM

Jun 5 2016

hvr awarded D2304: Refactor derived Generic instances to reduce allocations a Mountain of Wealth token.
Jun 5 2016, 12:21 PM

Jun 4 2016

hvr accepted D2301: Replace hand-written Bounded instances with derived ones.
Jun 4 2016, 4:48 PM
hvr added a comment to D2301: Replace hand-written Bounded instances with derived ones.

@austin what happened to that hallucinating parrot of approval? :-)

Jun 4 2016, 4:46 PM
hvr accepted D2277: trac task #11767: add @since annotations to base.

please inspect the result visually to make sure Haddock renders the annotations as expected

Jun 4 2016, 3:22 PM
hvr requested changes to D2277: trac task #11767: add @since annotations to base.

I've tried to annotate the places which still are not isolated last paragraphs containing merely @since ...

Jun 4 2016, 10:20 AM
hvr requested changes to D2277: trac task #11767: add @since annotations to base.

@since ... ought to be the last paragraph in Haddock comments to match existing convention

Jun 4 2016, 8:41 AM

Jun 1 2016

hvr added a comment to D2289: testsuite: Mark broken tests on powerpc64le.
In D2289#66207, @thomie wrote:

I have some unfinished patch to mark all TH-requiring tests as such to reduce the overwhelming noise you currently get with the testsuite if run it with a TH-lacking GHC...

req_interp is sometimes used for that purpose.

Jun 1 2016, 12:20 PM
hvr added a comment to D2289: testsuite: Mark broken tests on powerpc64le.

there's a good chance this applies to AIX/ppc32 as well;

Jun 1 2016, 12:08 PM

May 31 2016

hvr accepted D2285: Remove unused FAST_STRING_NOT_NEEDED macro defs.

I see no evidence this macro to be used anywhere; git log -S revealed that the last use-site was removed back in 2008, see 30c122df62ec75f9ed7f392f24c2925675bf1d06

May 31 2016, 3:06 AM
hvr added a comment to D2284: Add Bifoldable and Bitraversable to base.

First of all, thanks for picking up this tedious task!

May 31 2016, 3:02 AM
hvr awarded D2284: Add Bifoldable and Bitraversable to base a Mountain of Wealth token.
May 31 2016, 2:57 AM

May 29 2016

hvr requested changes to D2274: compiler: move md5.h into a better place.

why do we have another md5.h? I recently saw one in ./libraries/base/include/md5.h

May 29 2016, 5:55 AM
hvr accepted D2278: integer-gmp: Make minusInteger more efficient.

This looks all good to me, thanks!

May 29 2016, 5:53 AM
hvr awarded D2278: integer-gmp: Make minusInteger more efficient a Mountain of Wealth token.
May 29 2016, 5:21 AM

May 24 2016

hvr added a comment to D2248: Remove special casing of Windows in generic files.
In D2248#65260, @Phyx wrote:

Though we already do something similar for perl. So that could be an option too.

May 24 2016, 5:08 AM
hvr accepted D2260: Remove 'deriving Typeable' statements.
May 24 2016, 1:31 AM

May 21 2016

hvr committed rGHC00aa3e6e3f09: ghc-boot(-th): Fix incorrect 'expose'-property and relax cabal-version (authored by hvr).
ghc-boot(-th): Fix incorrect 'expose'-property and relax cabal-version
May 21 2016, 9:19 AM
hvr awarded D2248: Remove special casing of Windows in generic files a Mountain of Wealth token.
May 21 2016, 3:37 AM

May 19 2016

hvr added a comment to D2233: RTS SMP: Use compiler built-ins on all platforms..

would it make any sense to combine __sync_synchronize() with __sync_lock_test_and_set()?

May 19 2016, 4:34 AM

May 18 2016

hvr accepted D1290: Reduce the size of string literals in binaries..

fwiw, on AIX it seems to have a slightly opposite effect (binaries get larger); the linker doesn't seem to unify ro-data-sections

May 18 2016, 1:23 PM

May 17 2016

hvr added a comment to D2223: Set `USE_MMAP` at configure time.
  • The configure tests don't actually probe the system,
May 17 2016, 8:23 AM

May 16 2016

hvr accepted D2224: Move Extension type to ghc-boot-th.
May 16 2016, 8:38 AM
hvr accepted D2214: PPC NCG: Fix pretty printing of st[wd]ux instr..
May 16 2016, 8:20 AM
hvr requested changes to D2224: Move Extension type to ghc-boot-th.
May 16 2016, 8:10 AM
hvr added inline comments to D2224: Move Extension type to ghc-boot-th.
May 16 2016, 8:08 AM
hvr accepted D2225: PPC: Implement SMP primitives using gcc built-ins.

thumbsup2

May 16 2016, 8:01 AM
hvr added a comment to D2225: PPC: Implement SMP primitives using gcc built-ins.

@trommler you'll get there :-)

May 16 2016, 7:50 AM
hvr added a comment to D2218: compiler: #8207: add Language -> String function.

I'm utterly confused about this patch; here's the definition of Language:

May 16 2016, 7:39 AM
hvr accepted D2223: Set `USE_MMAP` at configure time.

see also inline comment, but other than that:

May 16 2016, 4:31 AM
hvr requested changes to D2224: Move Extension type to ghc-boot-th.

this brings us back to the same template-haskell deps 7.10 had?

May 16 2016, 3:23 AM
hvr awarded D2224: Move Extension type to ghc-boot-th a Mountain of Wealth token.
May 16 2016, 3:12 AM
hvr requested changes to D2223: Set `USE_MMAP` at configure time.

thanks for doing this!

May 16 2016, 2:37 AM
hvr awarded D2223: Set `USE_MMAP` at configure time a Mountain of Wealth token.
May 16 2016, 2:33 AM

May 15 2016

hvr committed rGHCc974927318c1: Update bytestring submodule to 0.10.8.1 release tag (authored by hvr).
Update bytestring submodule to 0.10.8.1 release tag
May 15 2016, 4:22 PM
hvr added inline comments to D2199: NUMA support.
May 15 2016, 5:35 AM

May 12 2016

hvr added a comment to D2201: RtsUtils: Use `size_t` instead of `int` where appropriate.

PS: are there any FFI foreign imports that wrap these functions?

May 12 2016, 3:32 AM
hvr accepted D2201: RtsUtils: Use `size_t` instead of `int` where appropriate.

luckily, it's rather unlikely that sizeof() returns anything not fitting in 32bits =)

May 12 2016, 3:31 AM

May 9 2016

hvr awarded D2175: Allow putting Haddocks on derived instances a Mountain of Wealth token.
May 9 2016, 3:05 PM

May 7 2016

hvr committed rGHC633b099cb683: Update time submodule to 1.6.0.1 release tag (authored by hvr).
Update time submodule to 1.6.0.1 release tag
May 7 2016, 1:46 AM

May 6 2016

hvr committed rGHCecc1d586e1b6: Update Win32 submodule to v2.3.1.1 release tag (authored by hvr).
Update Win32 submodule to v2.3.1.1 release tag
May 6 2016, 3:47 AM

May 3 2016

hvr committed rGHC0ab1a6af5a7a: Update bytestring submodule to 0.10.8.0 release tag (authored by hvr).
Update bytestring submodule to 0.10.8.0 release tag
May 3 2016, 5:49 PM
hvr committed rGHC4466ae6451b9: Update bytestring submodule to 0.10.8.0 release tag (authored by hvr).
Update bytestring submodule to 0.10.8.0 release tag
May 3 2016, 5:48 PM
hvr committed rGHCc7d21b1821ea: Update libraries/hpc submodule to v0.6.0.3 release tag (authored by hvr).
Update libraries/hpc submodule to v0.6.0.3 release tag
May 3 2016, 3:20 PM
hvr committed rGHC11a76c73fce8: Update Cabal submodule to v1.24.0.0 releas tag (authored by hvr).
Update Cabal submodule to v1.24.0.0 releas tag
May 3 2016, 3:20 PM
hvr committed rGHC0051ac1786cc: Update libraries/hpc submodule to v0.6.0.3 release tag (authored by hvr).
Update libraries/hpc submodule to v0.6.0.3 release tag
May 3 2016, 3:14 PM

Apr 27 2016

hvr awarded D2153: Fix path to the new build system, now called Hadrian. a Mountain of Wealth token.
Apr 27 2016, 5:51 PM

Apr 23 2016

hvr requested changes to D2136: Clean up defaulting; add new GHCi :type commands.
Apr 23 2016, 3:19 AM

Apr 19 2016

hvr committed rGHC81b14c141dc3: Update unix submodule to v2.7.2.0 release (authored by hvr).
Update unix submodule to v2.7.2.0 release
Apr 19 2016, 4:41 PM
hvr committed rGHC15b7e87702e4: Update `pretty` submodule to v1.1.3.3 release (authored by hvr).
Update `pretty` submodule to v1.1.3.3 release
Apr 19 2016, 4:10 PM
hvr committed rGHCff290b86ad23: Update binary submodule to 0.8.3.0 release (authored by hvr).
Update binary submodule to 0.8.3.0 release
Apr 19 2016, 4:07 PM
hvr committed rGHC96e1bb4536a6: Update deepseq submodule to latest 1.4.2.0 snapshot (authored by hvr).
Update deepseq submodule to latest 1.4.2.0 snapshot
Apr 19 2016, 12:17 PM
hvr committed rGHC91ee5090f1e3: Mark GHC.Stack.Types Trustworthy (authored by hvr).
Mark GHC.Stack.Types Trustworthy
Apr 19 2016, 12:14 PM
hvr committed rGHC81e227929c15: Update hsc2hs submodule (authored by hvr).
Update hsc2hs submodule
Apr 19 2016, 6:58 AM
hvr awarded D2099: Use stdint types to define SIZEOF and ALIGNMENT of INTx/WORDx a Like token.
Apr 19 2016, 2:15 AM
hvr committed rGHC8556f56b71f9: Update `directory` submodule to v1.2.6.2 release (authored by hvr).
Update `directory` submodule to v1.2.6.2 release
Apr 19 2016, 2:03 AM

Apr 17 2016

hvr committed rGHC8a75bb587407: Update haskeline submodule to 0.7.2.3 release (authored by hvr).
Update haskeline submodule to 0.7.2.3 release
Apr 17 2016, 3:18 PM
hvr retitled D2121: Remove obsolete/redundant FLEXIBLE_ARRAY macro from to Remove obsolete/redundant FLEXIBLE_ARRAY macro.
Apr 17 2016, 11:53 AM
hvr committed rGHCdd920e43b887: Silence unused-import warning introduced by 93d85af9fec968b (authored by hvr).
Silence unused-import warning introduced by 93d85af9fec968b
Apr 17 2016, 11:40 AM
hvr committed rGHC93d85af9fec9: Update `directory` submodule to v1.2.6.1 release (authored by hvr).
Update `directory` submodule to v1.2.6.1 release
Apr 17 2016, 10:40 AM
hvr committed rGHC4cbae1bd7009: Update array submodule to v0.5.1.1 release tag (authored by hvr).
Update array submodule to v0.5.1.1 release tag
Apr 17 2016, 5:10 AM

Apr 16 2016

hvr committed rGHC3f3ad75e7b91: Update `directory` submodule to v1.2.6.0 release (authored by hvr).
Update `directory` submodule to v1.2.6.0 release
Apr 16 2016, 2:19 PM

Apr 15 2016

hvr added a comment to D2119: Make it easy to get hyperlinked sources.

have you tested if install targets and binary dists work as expected? Also there may be the need to adapt perf-numbers (just a guess)

Apr 15 2016, 1:21 PM
hvr added a comment to D2078: Rework CC/CC_STAGE0 handling in `configure.ac`.

@simonmar I agree, this patch was about starting with CC, and extend it (or rather make separate patches to have logical commits, which can be reverted individually if needed) to the other "previous variables" listed by ./configure --help such as CPPFLAGS/LDFLAGS/CFLAGS/...

Apr 15 2016, 9:01 AM

Apr 14 2016

hvr retitled D2113: WIP: proof of concept related to #11744 from to WIP: proof of concept related to #11744.
Apr 14 2016, 1:33 AM

Apr 12 2016

hvr added a reviewer for D2078: Rework CC/CC_STAGE0 handling in `configure.ac`: simonmar.
Apr 12 2016, 9:27 AM

Apr 11 2016

hvr added a comment to D2103: libdw: More precise version check.

do we have a list of the dwfl_* symbols we depend on?

Apr 11 2016, 3:25 AM
hvr committed rGHC2ef35d8fed58: Use `@since` annotation in GHC.ExecutionStack (authored by hvr).
Use `@since` annotation in GHC.ExecutionStack
Apr 11 2016, 12:29 AM

Apr 9 2016

hvr retitled D2098: Remove left-over shell-tools.c from to Remove left-over shell-tools.c.
Apr 9 2016, 3:38 PM
hvr retitled D2078: Rework CC/CC_STAGE0 handling in `configure.ac` from WIP: Rework CC/CC_STAGE0 to Rework CC/CC_STAGE0 handling in `configure.ac`.
Apr 9 2016, 8:03 AM
hvr updated the diff for D2078: Rework CC/CC_STAGE0 handling in `configure.ac`.

finalise

Apr 9 2016, 8:02 AM
hvr added a reviewer for D2095: Reduce default for -fmax-pmcheck-iterations from 1e7 to 1e6: gkaracha.
Apr 9 2016, 2:46 AM
hvr retitled D2095: Reduce default for -fmax-pmcheck-iterations from 1e7 to 1e6 from to Reduce default for -fmax-pmcheck-iterations from 1e7 to 1e6.
Apr 9 2016, 2:45 AM