hsyl20 (Sylvain HENRY)
User

Projects

User does not belong to any projects.

User Details

User Since
May 19 2015, 3:52 AM (178 w, 1 d)

Recent Activity

Fri, Sep 28

hsyl20 abandoned D3647: Introduce module hierarchy.
Fri, Sep 28, 11:55 AM
hsyl20 abandoned D4880: Fix for built-in Natural literals.

hadrian doesn't need this patch anymore indeed, and I believe this was the only motivation for this patch -- can you confirm @hsyl20?

Fri, Sep 28, 10:46 AM

Jul 31 2018

hsyl20 abandoned D5020: Use NOINLINE on functions using touch#.
Jul 31 2018, 12:14 PM

Jul 30 2018

hsyl20 added a comment to D4647: RFC: Continuation arguments.

I'm not familiar with this part of GHC but here are a few guesses...

Jul 30 2018, 7:06 PM

Jul 29 2018

hsyl20 updated the diff for D5020: Use NOINLINE on functions using touch#.
  • Use with# in ghc-compact
Jul 29 2018, 12:01 PM
hsyl20 updated the summary of D5020: Use NOINLINE on functions using touch#.
Jul 29 2018, 11:10 AM
hsyl20 updated the summary of D5020: Use NOINLINE on functions using touch#.
Jul 29 2018, 10:47 AM
hsyl20 updated the diff for D5020: Use NOINLINE on functions using touch#.
  • Implement with[#] with catch#
Jul 29 2018, 10:08 AM

Jul 28 2018

hsyl20 updated the diff for D5020: Use NOINLINE on functions using touch#.
  • Ensure test fails with current HEAD (add "-threaded")
Jul 28 2018, 10:00 PM
hsyl20 created D5020: Use NOINLINE on functions using touch#.
Jul 28 2018, 9:39 PM
hsyl20 created D5016: Fix Git commit ID detection in Git worktrees.
Jul 28 2018, 9:04 AM

Jul 25 2018

hsyl20 abandoned D5008: Remove negative literal alternatives when matching dataToTag#.

Ok! No problem, as long as it gets fixed, it's fine!

Jul 25 2018, 10:48 AM
hsyl20 updated the summary of D5008: Remove negative literal alternatives when matching dataToTag#.
Jul 25 2018, 10:29 AM
hsyl20 updated the diff for D5008: Remove negative literal alternatives when matching dataToTag#.
  • Add test
Jul 25 2018, 10:27 AM
hsyl20 created D5008: Remove negative literal alternatives when matching dataToTag#.
Jul 25 2018, 10:22 AM

Jun 22 2018

hsyl20 updated the diff for D4881: Rename literal constructors.

Indeed it is only a cosmetic change but the Mach prefix always seemed weird to me. The only machine-specific literals are MachInt, MachWord and MachNullAddr but two of them have already been renamed. All the other ones are specified independently of the actual machine (Float, Double, Word32, Word64, Label, etc.) and/or are not so close to the machine (Unicode char, UTF8 string, Integer, Natural).

Jun 22 2018, 8:14 AM
hsyl20 updated the summary of D4880: Fix for built-in Natural literals.
Jun 22 2018, 6:41 AM
hsyl20 updated the diff for D4880: Fix for built-in Natural literals.
  • Create a separate diff for the desugaring bug
Jun 22 2018, 6:41 AM
hsyl20 created D4885: Fix for built-in Natural literals desugaring.
Jun 22 2018, 6:38 AM

Jun 21 2018

Herald added a reviewer for D4881: Rename literal constructors: goldfire.
Jun 21 2018, 2:51 AM

Jun 20 2018

hsyl20 added inline comments to D4880: Fix for built-in Natural literals.
Jun 20 2018, 9:49 AM
hsyl20 created D4880: Fix for built-in Natural literals.
Jun 20 2018, 7:14 AM

Jun 15 2018

hsyl20 updated the summary of D4212: Built-in Natural literals in Core.
Jun 15 2018, 12:02 PM
hsyl20 updated the diff for D4212: Built-in Natural literals in Core.
  • Rebae on master
Jun 15 2018, 12:02 PM

May 13 2018

hsyl20 added a comment to D4630: Refactor LitString.

@hsyl20, I'm having a bit of trouble finding the haddock commit, 293629ad826cd24f425bdd6b82a047b882777e1e. Is it possible that you haven't pushed it to your fork?

May 13 2018, 11:49 AM

May 1 2018

hsyl20 updated the diff for D4630: Refactor LitString.
  • Fix comment
May 1 2018, 6:36 AM

Apr 27 2018

hsyl20 updated the diff for D4630: Refactor LitString.
  • Minor changes
Apr 27 2018, 3:23 AM
hsyl20 updated the diff for D4630: Refactor LitString.
  • Fix bPutReplicate
Apr 27 2018, 3:23 AM
hsyl20 added a comment to D4630: Refactor LitString.

Thanks @dfeuer. The new patch for utils/haddock:

--- a/haddock-api/src/Haddock/Backends/LaTeX.hs
+++ b/haddock-api/src/Haddock/Backends/LaTeX.hs
@@ -169,16 +169,9 @@ ppLaTeXModule _title odir iface = do
Apr 27 2018, 3:23 AM
hsyl20 updated the diff for D4630: Refactor LitString.
  • Optimise indentation
Apr 27 2018, 3:23 AM

Apr 26 2018

hsyl20 added inline comments to D4630: Refactor LitString.
Apr 26 2018, 5:47 AM
hsyl20 updated the diff for D4630: Refactor LitString.
  • Switch to Ptr and Int. Other minor changes.
Apr 26 2018, 5:46 AM

Apr 25 2018

hsyl20 added a comment to D4630: Refactor LitString.

Of course the CI cant' build this patch because it needs the following patch in utils/haddock:

Apr 25 2018, 9:00 AM
hsyl20 requested review of D4630: Refactor LitString.
Apr 25 2018, 6:31 AM

Apr 20 2018

hsyl20 updated the diff for D4212: Built-in Natural literals in Core.
  • Comment only
Apr 20 2018, 12:16 PM
hsyl20 updated the diff for D4212: Built-in Natural literals in Core.
  • Use Proxy instead of ambiguous types
  • Fix constructor in mkNatural
Apr 20 2018, 12:03 PM

Apr 19 2018

hsyl20 updated the diff for D4212: Built-in Natural literals in Core.
  • Fix test
Apr 19 2018, 7:30 PM
hsyl20 updated the diff for D4212: Built-in Natural literals in Core.
  • Fix desugaring of overflowing literals
Apr 19 2018, 11:29 AM
hsyl20 added a comment to D4605: Algebraically simplify add/sub with carry/overflow.

LGTM. Indeed it probably conflicts with D2858, D4212, etc. but we can easily rebase.

Apr 19 2018, 7:41 AM
hsyl20 added inline comments to D4212: Built-in Natural literals in Core.
Apr 19 2018, 7:07 AM
hsyl20 retitled D4212: Built-in Natural literals in Core from Performance of Natural to Built-in Natural literals in Core.
Apr 19 2018, 7:06 AM
hsyl20 updated the summary of D4212: Built-in Natural literals in Core.
Apr 19 2018, 7:01 AM
hsyl20 updated the diff for D4212: Built-in Natural literals in Core.
  • Remove pattern synonyms
  • Factorise cvt_integer and cvt_natural into cvt_literal
Apr 19 2018, 7:01 AM

Mar 9 2018

hsyl20 added a comment to D4212: Built-in Natural literals in Core.

Looks plausible to me. But maybe for this patch you can start in that direction, to avoid generating a lot of new code that you then delete?

Mar 9 2018, 6:47 AM
hsyl20 updated the diff for D4212: Built-in Natural literals in Core.
  • Simplify hasCafRefs
  • Introduce LitNumType and LitNumber constructor
  • Factorize some code
Mar 9 2018, 6:36 AM

Mar 5 2018

hsyl20 added a comment to D4212: Built-in Natural literals in Core.

@simonpj If we go this way, I think we should replace MachInt, MachInt64, MachWord, MachWord64, LitInteger and LitNatural with something like:

Mar 5 2018, 12:57 PM
hsyl20 updated the diff for D4212: Built-in Natural literals in Core.
  • Add missing stderr file
Mar 5 2018, 11:17 AM
hsyl20 updated the diff for D4212: Built-in Natural literals in Core.
  • Add test for negative Natural literal warning
Mar 5 2018, 11:17 AM
hsyl20 awarded D4217: Support adding objects from TH a Like token.
Mar 5 2018, 9:11 AM
hsyl20 updated the diff for D4212: Built-in Natural literals in Core.
  • Fix build with integer-simple
  • Don't use wordToNatural# in base, otherwise built-in rules may produce Natural literals
Mar 5 2018, 7:14 AM

Mar 2 2018

hsyl20 added a comment to D2858: Enhanced constant folding.

I'm going to go ahead and merge this as we are well beyond 8.4.

Thanks for your patience @hsyl20!

Mar 2 2018, 6:14 PM
hsyl20 updated the diff for D4212: Built-in Natural literals in Core.
  • wordToNatural: use it and add a built-in rule to lift constant applications into Natural literals
Mar 2 2018, 1:28 PM
hsyl20 updated the summary of D4212: Built-in Natural literals in Core.
Mar 2 2018, 12:51 PM
hsyl20 added a comment to D4212: Built-in Natural literals in Core.

Thanks for doing this!

The one obvious thing that seems missing from this patch is one or two test cases that verify that these optimizations actually kick in. The programs from Trac #14170 and Trac #14465 seem like obvious candidates.

Mar 2 2018, 11:31 AM
hsyl20 updated the diff for D4212: Built-in Natural literals in Core.
  • Add tests
  • Warn on negative Natural literals
  • Fix some minor glitches
  • Fix some line length warnings
Mar 2 2018, 11:23 AM
hsyl20 updated the diff for D4212: Built-in Natural literals in Core.
  • NOINLINE naturalToInteger
Mar 2 2018, 10:57 AM
hsyl20 updated the diff for D4212: Built-in Natural literals in Core.
  • Fix tests
Mar 2 2018, 7:30 AM
hsyl20 updated the diff for D4212: Built-in Natural literals in Core.
  • Fix TH
  • Fix Bits instance
Mar 2 2018, 5:35 AM

Mar 1 2018

hsyl20 updated the diff for D4212: Built-in Natural literals in Core.
  • Split and add base:GHC.Maybe
  • Fix error in naturalFromInteger rule (was returning a LitInteger)
  • Ensure that we avoid using Natural literals in base
  • Fix use of Natural literal in Data.Bits Natural instance
  • Export Natural stuff in basicKnownKeyNames
  • Add some missing imports
Mar 1 2018, 7:56 AM
hsyl20 commandeered D4212: Built-in Natural literals in Core.

I have fixed the build. I hope it's ok if I commandeer the revision in order to update my patch. @Bodigrim don't hesitate to commandeer it back.

Mar 1 2018, 7:54 AM
hsyl20 added inline comments to D4453: 8.4: bump cabal to 2.2 (with ghc-cabal).
Mar 1 2018, 5:24 AM

Feb 26 2018

hsyl20 added a comment to D4212: Built-in Natural literals in Core.
  • naturalToIntegerName, plusNaturalName, minusNaturalName, timesNaturalName, and mkNaturalName are missing from basicKnownKeyNames in compiler/prelude/PrelNames.hs
  • import GHC.Types () is missing from libraries/base/GHC/Exception/Type.hs-boot
Feb 26 2018, 1:18 PM

Feb 16 2018

hsyl20 added a comment to D4212: Built-in Natural literals in Core.

Well, I got stuck with build error, quoted above. Are you able to build GHC with my patch?

Feb 16 2018, 8:08 AM

Feb 15 2018

hsyl20 added a comment to D4212: Built-in Natural literals in Core.

@Bodigrim I have just been bitten by Trac #14170 too... Is there anything we can help you with to complete this patch?

Feb 15 2018, 5:43 PM

Oct 28 2017

hsyl20 added a comment to D2858: Enhanced constant folding.

I wouldn't mind waiting for 8.6. Switching back to pattern guards would be quite a lot of (duplicated) work.

Oct 28 2017, 5:37 PM

Oct 27 2017

hsyl20 added a comment to D2858: Enhanced constant folding.

Whoa! You mean that adding the patch to HEAD means that 8.2 crashes when compiling HEAD? That's NOT ok.

Oct 27 2017, 5:13 AM

Oct 26 2017

hsyl20 added a comment to D2858: Enhanced constant folding.

@bgamari The tests don't pass because of a bug in GHC 8.2.1. I've had to use a snapshot of HEAD to validate this patch (using --enable-bootstrap-with-devel-snapshot).

Oct 26 2017, 2:58 AM

Oct 19 2017

hsyl20 added a comment to D4064: Support adding objects from TH (fixes #14298).

I was concerned with file cleanup when I proposed to support in-memory object files: suppose we have some TH producing an object file. We could use addForeignObject but we would have no way to remove the temporary object file. While if GHC only writes the temporary file for the duration of the link, there is nothing to cleanup. The API would be similar to addForeignFile (which takes a String, not a FilePath).

Oct 19 2017, 10:21 AM
hsyl20 updated the diff for D2858: Enhanced constant folding.
  • Typo in note
Oct 19 2017, 8:43 AM
hsyl20 updated the diff for D2858: Enhanced constant folding.
  • Add note
Oct 19 2017, 8:37 AM
hsyl20 updated the diff for D2858: Enhanced constant folding.
  • Minor fix in Note
Oct 19 2017, 8:37 AM

Oct 18 2017

hsyl20 updated the summary of D2858: Enhanced constant folding.
Oct 18 2017, 10:46 PM
hsyl20 updated the diff for D2858: Enhanced constant folding.
  • Factorize multiplications
Oct 18 2017, 10:25 PM
hsyl20 updated the summary of D2858: Enhanced constant folding.
Oct 18 2017, 10:20 PM
hsyl20 updated the diff for D2858: Enhanced constant folding.
  • Fix lint issues
Oct 18 2017, 10:20 PM
hsyl20 added inline comments to D2858: Enhanced constant folding.
Oct 18 2017, 9:44 PM
hsyl20 updated the diff for D2858: Enhanced constant folding.
  • Use better patterns
  • Add Flag
Oct 18 2017, 9:44 PM

Jul 1 2017

hsyl20 added inline comments to D3695: Eagerly blackhole AP_STACKs.
Jul 1 2017, 3:39 AM

Jun 19 2017

hsyl20 abandoned D3659: Fix Note "What AbsBinds means".

Fixed in https://git.haskell.org/ghc.git/commitdiff/5c93df90a96494229b60bbed0971a4b08c0326a6

Jun 19 2017, 4:53 PM
hsyl20 created D3659: Fix Note "What AbsBinds means".
Jun 19 2017, 5:40 AM

Jun 15 2017

hsyl20 added a comment to D3647: Introduce module hierarchy.

I didn't want to discuss too much the details of the new hierarchy beforehand because I wasn't sure I would have the patience to finish this patch anyway ;-).

Jun 15 2017, 8:47 AM

Jun 14 2017

hsyl20 updated the diff for D3647: Introduce module hierarchy.
  • Minor fixes
Jun 14 2017, 10:49 PM
hsyl20 updated the summary of D3648: Fix GCC 7 warning in the RTS.
Jun 14 2017, 10:21 PM
Herald added a reviewer for D3648: Fix GCC 7 warning in the RTS: austin.
Jun 14 2017, 9:49 PM
hsyl20 added a reviewer for D3647: Introduce module hierarchy: simonpj.

Some submodules also need to be updated:

Jun 14 2017, 8:27 PM
hsyl20 created D3647: Introduce module hierarchy.
Jun 14 2017, 8:20 PM

Feb 2 2017

hsyl20 added a comment to D2839: Ditch static flags.

@hsyl20, do you think you'll get a chance to finish this up at some point? If not I can pick it up.

Feb 2 2017, 2:38 AM

Jan 23 2017

hsyl20 updated the diff for D3009: Ensure that scrutinee constant folding wraps numbers.
  • Typo
Jan 23 2017, 7:06 PM
hsyl20 updated the diff for D3009: Ensure that scrutinee constant folding wraps numbers.
  • Doc
Jan 23 2017, 7:01 PM
hsyl20 updated the diff for D3009: Ensure that scrutinee constant folding wraps numbers.
  • Fix test
Jan 23 2017, 6:16 PM
hsyl20 retitled D3009: Ensure that scrutinee constant folding wraps numbers from to Ensure that scrutinee constant folding wraps numbers.
Jan 23 2017, 6:09 PM
hsyl20 accepted D3008: Re-sort case alternatives after scrutinee constant folding (#13170).

It looks good to me. Sorry to have missed that!

Jan 23 2017, 5:01 PM

Jan 9 2017

hsyl20 accepted D2921: users-guide: Produce OpenSearch description.

It looks good to me. Thanks for the patch.

Jan 9 2017, 4:58 AM

Dec 20 2016

hsyl20 planned changes to D2858: Enhanced constant folding.
Dec 20 2016, 7:58 PM
hsyl20 added a comment to D2858: Enhanced constant folding.

I'm glad to have better constant-folding, but I worry that all looks rather ad-hoc, picking off a bunch of special cases. For example, what about

((v + x#) + w) + y#

will you get to (v+w) + (x+y)#?

Dec 20 2016, 7:57 PM

Dec 19 2016

hsyl20 added a comment to rGHCd3b546b1a605: Scrutinee Constant Folding.

@nomeata Indeed it would be better to grep in Core. Proposed patch: https://phabricator.haskell.org/D2883

Dec 19 2016, 3:11 PM
hsyl20 retitled D2883: Fix test for T12877 from to Fix test for T12877.
Dec 19 2016, 3:10 PM
hsyl20 added a comment to D2839: Ditch static flags.

OK by me once it passes validate.

Dec 19 2016, 6:18 AM

Dec 16 2016

hsyl20 added inline comments to D2858: Enhanced constant folding.
Dec 16 2016, 10:42 AM
hsyl20 updated the diff for D2858: Enhanced constant folding.
  • Guard the pmcheck flag (not supported before 8.0.1)
Dec 16 2016, 10:41 AM