harpocrates (Alec Theriault)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 3 2017, 5:55 PM (67 w, 3 d)

Recent Activity

Thu, Jan 17

harpocrates abandoned D5417: Hadrian: support in-tree GMP.

Migrated to https://gitlab.haskell.org/ghc/ghc/merge_requests/138.

Thu, Jan 17, 6:55 PM

Wed, Jan 16

harpocrates committed rGHC6b5ec08a4a64: Check that libs found by GCC aren't folders (authored by harpocrates).
Check that libs found by GCC aren't folders
Wed, Jan 16, 12:24 AM

Thu, Jan 10

harpocrates abandoned D5409: Hadrian: support extra libraries + OSX rpath.

Moved over to gitlab: https://gitlab.haskell.org/ghc/ghc/merge_requests/86.

Thu, Jan 10, 6:52 AM
harpocrates abandoned D5405: 'DynFlag'-free version of 'mkParserFlags'.

Moved over to gitlab: https://gitlab.haskell.org/ghc/ghc/merge_requests/108.

Thu, Jan 10, 6:05 AM

Tue, Jan 8

harpocrates closed D5462: Check that libs found by GCC aren't folders.
Tue, Jan 8, 8:34 AM
harpocrates closed D5463: Create folder if missing for .hie files.

Migrated to Gitlab in https://gitlab.haskell.org/ghc/ghc/merge_requests/91.

Tue, Jan 8, 8:34 AM

Mon, Jan 7

harpocrates added a comment to D5462: Check that libs found by GCC aren't folders.
In D5462#151388, @Phyx wrote:

Oh sorry, I had forgotten to commit this. I'm afraid I haven't sorted out my commit access to the new repository yet.
I'm not really sure what the process now is... Could I ask you to move it to gitlab? point to this review and I'm sure someone will commit it. I'll try to sort out my access this weekend.

Mon, Jan 7, 3:01 PM
harpocrates added a comment to D5409: Hadrian: support extra libraries + OSX rpath.

Is the patch on gitlab too? (for CI)

Mon, Jan 7, 2:49 PM
harpocrates added a comment to D5462: Check that libs found by GCC aren't folders.

Friendly ping!

Mon, Jan 7, 11:38 AM
harpocrates added a comment to D5409: Hadrian: support extra libraries + OSX rpath.

Friendly ping!

Mon, Jan 7, 11:37 AM

Dec 19 2018

harpocrates created D5463: Create folder if missing for .hie files.
Dec 19 2018, 8:08 AM

Dec 18 2018

harpocrates added a comment to D5462: Check that libs found by GCC aren't folders.

I'm unsure whether this is worth making a test case for, but here is a minimal test repo with instructions: https://github.com/benjaminselfridge/uses-softfloat.

Dec 18 2018, 9:43 PM
harpocrates created D5462: Check that libs found by GCC aren't folders.
Dec 18 2018, 7:34 PM

Dec 17 2018

harpocrates added a comment to D5458: Hadrian: Add support for building Stage3.

I think that stageLibraries also needs to be used in configurePackage to make sure you end up needing packages from the right stage. That occurs here: https://github.com/ghc/ghc/blob/ed69f8bd1fd4b84b62bb4f10eef7f76e537be07b/hadrian/src/Hadrian/Haskell/Cabal/Parse.hs#L116. Note that this is already wrong for stage 2 thereby preventing me from building Haddock >:(.

Dec 17 2018, 10:28 PM
harpocrates added a comment to D5409: Hadrian: support extra libraries + OSX rpath.

Unless someone has a good reason otherwise, I think we should merge this as is.

Dec 17 2018, 10:58 AM
harpocrates retitled D5409: Hadrian: support extra libraries + OSX rpath from Hadrian: support extra libraries + dynamic GHC to Hadrian: support extra libraries + OSX rpath.
Dec 17 2018, 10:54 AM
harpocrates updated the diff for D5409: Hadrian: support extra libraries + OSX rpath.
  • Add some TODOs
Dec 17 2018, 10:51 AM
harpocrates created D5459: Add missing comma in 'libdw' configure check.
Dec 17 2018, 10:39 AM

Dec 12 2018

harpocrates updated the diff for D5405: 'DynFlag'-free version of 'mkParserFlags'.
  • ifBit -> isExtension
Dec 12 2018, 1:38 PM

Dec 11 2018

harpocrates planned changes to D5409: Hadrian: support extra libraries + OSX rpath.

I tried this out in a Windows VM and it indeed doesn't work (the extra-libraries: ffi in libraries/ghci/ghci.cabal.in is what is messing it up - take that out and Windows builds, but Mac doesn't). I've obviously not fully grasped the complexity of the libffi situation. It would be great if there were a note somewhere summarizing what is supposed to be happening.

Dec 11 2018, 6:02 PM

Dec 7 2018

harpocrates added a comment to D5332: Simplify 'ExtBits' in the lexer.

I think I've figured out why tests were failing and the issue is entirely in this diff, not D5269.

How do I proceed? Do I open a new diff that is an updated version of this existing diff or can I still update this diff? Do I also need to re-open something for D5269?

You can't push a new version of a closed diff. Please do just push a new differential.

Dec 7 2018, 9:43 PM
harpocrates created D5424: Require 'libdw' for '--enable-dwarf-unwind'.
Dec 7 2018, 6:15 PM

Dec 6 2018

harpocrates added a comment to D5417: Hadrian: support in-tree GMP.

@harpocrates Thank you for the patch.

It would be nice to also add a Hadrian command like flag at some point for people who don't like going via the configure script (like me), or for people who might be swithing between different GMP settings often (like @adamse?).

@adamse Regarding the build times: Hadrian does not require a full rebuild after a reconfigure: only the affected build rules will be (or rather should be!) rerun.

Dec 6 2018, 9:57 AM
harpocrates added inline comments to D5417: Hadrian: support in-tree GMP.
Dec 6 2018, 9:40 AM
harpocrates added a parent revision for D5417: Hadrian: support in-tree GMP: D5409: Hadrian: support extra libraries + OSX rpath.
Dec 6 2018, 6:25 AM
harpocrates added a child revision for D5409: Hadrian: support extra libraries + OSX rpath: D5417: Hadrian: support in-tree GMP.
Dec 6 2018, 6:25 AM
harpocrates created D5417: Hadrian: support in-tree GMP.
Dec 6 2018, 12:55 AM

Dec 5 2018

harpocrates updated the diff for D5239: Support generating HIE files.
  • Remove duplicate types in combineNodeInfo
Dec 5 2018, 2:24 PM
harpocrates updated the diff for D5239: Support generating HIE files.
  • Unused import
Dec 5 2018, 6:56 AM

Dec 4 2018

harpocrates updated the diff for D5239: Support generating HIE files.
  • Get rid of CmpType and Semigroup/Monoid NodeInfo
  • Comments + final import cleanup
Dec 4 2018, 10:59 PM
harpocrates added inline comments to D5409: Hadrian: support extra libraries + OSX rpath.
Dec 4 2018, 10:36 AM
harpocrates updated the diff for D5409: Hadrian: support extra libraries + OSX rpath.
  • Address review comments
Dec 4 2018, 10:28 AM
harpocrates updated the diff for D5409: Hadrian: support extra libraries + OSX rpath.
  • guard 'ghci's 'ffi' extra-lib behind a flag
  • Rename 'cabalDistDir' into 'distDir'
Dec 4 2018, 3:00 AM
harpocrates added inline comments to D5409: Hadrian: support extra libraries + OSX rpath.
Dec 4 2018, 2:17 AM
harpocrates updated the diff for D5409: Hadrian: support extra libraries + OSX rpath.
  • Rename 'cabalDistDir' into 'distDir'
Dec 4 2018, 2:16 AM
harpocrates updated the diff for D5409: Hadrian: support extra libraries + OSX rpath.
  • guard 'ghci's 'ffi' extra-lib behind a flag
Dec 4 2018, 1:30 AM

Dec 3 2018

harpocrates abandoned D5406: Hadrian: add -no-dead-strip-dylibs for dynamic GHC.

As determined on IRC today, the proper solution here is to likely teach hadrian about extra-libraries as specified in cabal files.
We currently hardcode some of the in hadrian, but should rather read them from the cabal files and fix the cabal files where
they are missing.

Dec 3 2018, 11:56 PM
harpocrates created D5409: Hadrian: support extra libraries + OSX rpath.
Dec 3 2018, 11:55 PM
harpocrates added a comment to D5406: Hadrian: add -no-dead-strip-dylibs for dynamic GHC.

I only see a tiny problem with your patch, it otherwise looks good to me.

Dec 3 2018, 1:56 AM

Dec 2 2018

harpocrates added a comment to rGHC79d5427e1f9d: Hadrian: support dynamically linking ghc.

I've opened https://ghc.haskell.org/trac/ghc/ticket/15990 for this.

Dec 2 2018, 10:05 PM
harpocrates added a comment to D5406: Hadrian: add -no-dead-strip-dylibs for dynamic GHC.

I'm not sure this is the right way to solve this, but it does unbreak dynamically linked GHC on Mac...

Dec 2 2018, 10:04 PM
harpocrates created D5406: Hadrian: add -no-dead-strip-dylibs for dynamic GHC.
Dec 2 2018, 10:03 PM
harpocrates updated the diff for D5181: Warn on all out-of-range literals in pats/exprs.
  • Forgot to commit some changes...
Dec 2 2018, 2:46 PM
harpocrates raised a concern with rGHC6bb8aaa3b4fc: rts: Add FALLTHROUGH macro.

I think this is what is causing Mac CI to fail (pretty early on). Example failure:

Dec 2 2018, 2:41 PM
harpocrates added a comment to rGHC79d5427e1f9d: Hadrian: support dynamically linking ghc.

There is a similar issue on linux where we link the system ffi instead of the local one. This fails e.g. on CircleCI as ld cannot find the ffi library. I don't know if this is related to the OSX failure, but I'll continue investigating this on linux.

Dec 2 2018, 12:46 PM
harpocrates added a comment to rGHC79d5427e1f9d: Hadrian: support dynamically linking ghc.

I did some sleuthing. Apologies if this is overly verbose - I'm out of my depth, so it's difficult for me to gauge what is obvious from what isn't. Also, please call out anything that sounds incorrect!

Dec 2 2018, 5:01 AM
harpocrates added a comment to D5405: 'DynFlag'-free version of 'mkParserFlags'.

@bgamari This lumps together fixed changes from the two reverted patches D5269 and D5332.

Dec 2 2018, 1:05 AM
harpocrates retitled D5405: 'DynFlag'-free version of 'mkParserFlags' from Simplify 'ExtBits' in the lexer to 'DynFlag'-free version of 'mkParserFlags'.
Dec 2 2018, 1:02 AM
harpocrates added a reverting change for rGHC5aa29231ab76: 'DynFlag'-free version of 'mkParserFlags': D5405: 'DynFlag'-free version of 'mkParserFlags'.
Dec 2 2018, 1:02 AM
harpocrates updated the diff for D5405: 'DynFlag'-free version of 'mkParserFlags'.

Lump in changes from 5aa29231ab7603537284eff5e4caff3a73dba6d2 (D5269)

Dec 2 2018, 12:57 AM
harpocrates created D5405: 'DynFlag'-free version of 'mkParserFlags'.
Dec 2 2018, 12:49 AM
harpocrates added a reverting change for rGHCd2fbc33c4ff3: Simplify 'ExtBits' in the lexer: D5405: 'DynFlag'-free version of 'mkParserFlags'.
Dec 2 2018, 12:49 AM

Dec 1 2018

harpocrates updated the diff for D5181: Warn on all out-of-range literals in pats/exprs.

Rebased

Dec 1 2018, 11:29 PM
harpocrates created D5404: Hadrian: include 'findPtr' via find-ptr cabal flag.
Dec 1 2018, 9:01 PM
harpocrates raised a concern with rGHC79d5427e1f9d: Hadrian: support dynamically linking ghc.

I should have marked my previous comment (https://phabricator.haskell.org/rGHC79d5427e1f9de02c0b171bf5db46b6b49c6f85e3#141680) as a concern.

Dec 1 2018, 8:59 PM
harpocrates updated subscribers of rGHC79d5427e1f9d: Hadrian: support dynamically linking ghc.

This breaks the default ./hadrian/build.sh on OSX. :(

Dec 1 2018, 8:58 PM

Nov 30 2018

harpocrates added a comment to D5332: Simplify 'ExtBits' in the lexer.

I think I've figured out why tests were failing and the issue is entirely in this diff, not D5269.

Nov 30 2018, 1:34 PM
harpocrates added a comment to D5181: Warn on all out-of-range literals in pats/exprs.

Is there anything blocking this from being merged?

Nov 30 2018, 12:53 PM
harpocrates updated the diff for D5391: Add 'Lift' instances for 'NonEmpty' and 'Void'.
  • Fix test output
Nov 30 2018, 1:31 AM

Nov 29 2018

harpocrates added inline comments to D5391: Add 'Lift' instances for 'NonEmpty' and 'Void'.
Nov 29 2018, 3:21 AM

Nov 28 2018

harpocrates updated the diff for D5391: Add 'Lift' instances for 'NonEmpty' and 'Void'.
  • Make code similar to what 'DeriveLift' generates
Nov 28 2018, 11:10 PM
harpocrates created D5391: Add 'Lift' instances for 'NonEmpty' and 'Void'.
Nov 28 2018, 5:55 PM
harpocrates added a comment to D5239: Support generating HIE files.

I think I've addressed pretty much all of the feedback. I'm not entirely sure I got the performance test aspect of hie002 right though - isn't there someplace I should be entering expected stats?

Nov 28 2018, 4:11 PM
harpocrates updated the diff for D5239: Support generating HIE files.
  • Post rebase sludge
  • Include srcspan in LocalName check
  • Fix some long lines / comments
  • Port build system changes to hadrian
  • Avoid non-exhaustive cases
  • Fix orphan instances & add docs
  • Add more docs + a note
  • Eliminate string literals with 'Data' combinators
  • Regenerate '.hie' files properly
  • Avoid error when merging overlapping ASTs
  • Longer comment around overlapping spans
  • Copy-paste typo
  • Patch up a test case + add another one
  • Rebase over the TTG Pat changes
  • Fix long lines
  • Fix long lines 2
  • Address review comments
  • Document flags
  • Add a pref test + a recompilation test
  • Fix tests
Nov 28 2018, 4:07 PM

Nov 25 2018

harpocrates updated the diff for D5239: Support generating HIE files.
  • Fix long lines 2
Nov 25 2018, 4:33 AM
harpocrates updated the diff for D5239: Support generating HIE files.
  • Fix long lines
Nov 25 2018, 3:15 AM
harpocrates updated the diff for D5239: Support generating HIE files.
  • Post rebase sludge
  • Include srcspan in LocalName check
  • Fix some long lines / comments
  • Port build system changes to hadrian
  • Avoid non-exhaustive cases
  • Fix orphan instances & add docs
  • Add more docs + a note
  • Eliminate string literals with 'Data' combinators
  • Regenerate '.hie' files properly
  • Avoid error when merging overlapping ASTs
  • Longer comment around overlapping spans
  • Copy-paste typo
  • Patch up a test case + add another one
  • Rebase over the TTG Pat changes
Nov 25 2018, 1:44 AM

Nov 24 2018

harpocrates added a comment to D5239: Support generating HIE files.

I think this is ready for final review now.

Nov 24 2018, 2:27 PM
harpocrates updated the diff for D5239: Support generating HIE files.
  • Avoid error when merging overlapping ASTs
  • Longer comment around overlapping spans
  • Copy-paste typo
Nov 24 2018, 2:21 PM
harpocrates added inline comments to D5239: Support generating HIE files.
Nov 24 2018, 2:46 AM

Nov 23 2018

harpocrates updated the diff for D5239: Support generating HIE files.
  • Regenerate '.hie' files properly
Nov 23 2018, 7:21 PM
harpocrates added a comment to D5332: Simplify 'ExtBits' in the lexer.

Unfortunately either this or D5269 ended up regressing; I have reverted both. @harpocrates, could you have a look?

Nov 23 2018, 1:43 PM

Nov 22 2018

harpocrates added inline comments to D5239: Support generating HIE files.
Nov 22 2018, 3:10 PM
harpocrates updated subscribers of D5332: Simplify 'ExtBits' in the lexer.

Except for the fact that it doesn't cleanly apply.

Do you think you could rebase, @harpocrates?

Nov 22 2018, 1:37 PM
harpocrates added inline comments to D5239: Support generating HIE files.
Nov 22 2018, 1:17 PM
harpocrates updated the diff for D5239: Support generating HIE files.
  • Eliminate string literals with 'Data' combinators
Nov 22 2018, 12:15 PM

Nov 21 2018

harpocrates added inline comments to D5239: Support generating HIE files.
Nov 21 2018, 1:21 AM
harpocrates updated the diff for D5239: Support generating HIE files.
  • Avoid non-exhaustive cases
  • Fix orphan instances & add docs
  • Add more docs + a note
Nov 21 2018, 1:19 AM

Nov 20 2018

harpocrates added inline comments to D5239: Support generating HIE files.
Nov 20 2018, 3:27 PM
harpocrates retitled D5316: Hadrian: Misc. fixes in Haddock rules from Hadrian: Misc. fixes for Hadrian's handling of Haddock to Hadrian: Misc. fixes in Haddock rules.
Nov 20 2018, 3:13 PM
harpocrates retitled D5361: Hadrian: work around Cabal's/GHC's different Arch/OS strings from Hadrian: work around Cabal's/GHC's different Arch/OS strings in Hadrian to Hadrian: work around Cabal's/GHC's different Arch/OS strings.
Nov 20 2018, 3:13 PM
harpocrates retitled D5361: Hadrian: work around Cabal's/GHC's different Arch/OS strings from Work around Cabal's/GHC's different Arch/OS strings in Hadrian to Hadrian: work around Cabal's/GHC's different Arch/OS strings in Hadrian.
Nov 20 2018, 3:13 PM
harpocrates retitled D5316: Hadrian: Misc. fixes in Haddock rules from Misc. fixes for Hadrian's handling of Haddock to Hadrian: Misc. fixes for Hadrian's handling of Haddock.
Nov 20 2018, 3:12 PM
harpocrates updated the diff for D5316: Hadrian: Misc. fixes in Haddock rules.
  • Better comment around union
Nov 20 2018, 3:12 PM
harpocrates added inline comments to D5316: Hadrian: Misc. fixes in Haddock rules.
Nov 20 2018, 2:53 PM
harpocrates added a comment to D5239: Support generating HIE files.
In D5239#147577, @alanz wrote:

If there is anything I can do to help getting this into 8.8, let me know.

Nov 20 2018, 2:15 PM
harpocrates planned changes to D5239: Support generating HIE files.
Nov 20 2018, 1:52 PM
harpocrates created D5361: Hadrian: work around Cabal's/GHC's different Arch/OS strings.
Nov 20 2018, 12:36 PM
harpocrates added a comment to D5316: Hadrian: Misc. fixes in Haddock rules.

I think I now fully understand the rules here. I wasn't able to find a clean way for the docs rule to call the docs-haddock rule, but hopefully the comments I left will make it clear what is happening.

Nov 20 2018, 3:20 AM
harpocrates updated the summary of D5316: Hadrian: Misc. fixes in Haddock rules.
Nov 20 2018, 3:07 AM
harpocrates updated the diff for D5316: Hadrian: Misc. fixes in Haddock rules.
  • Restructure GHC.Prim case for Haddock
  • Remove unused gen_contents_index/prologue rules
  • Simplify some rules & add comments
Nov 20 2018, 3:05 AM

Nov 19 2018

harpocrates added a comment to D5239: Support generating HIE files.

What logic do we want for recompilation-avoidance? Should compiling with -fenable-ide-info force recompilation if the .hie file isn't found (or is out of date)? Right now, we have none of that, so compiling with -fenable-ide-info only dumps out an .hie file when GHC compiles the module...

Nov 19 2018, 12:09 PM

Nov 17 2018

harpocrates updated the diff for D5239: Support generating HIE files.
  • Fix some long lines / comments
  • Port build system changes to hadrian
Nov 17 2018, 3:27 AM
harpocrates updated the diff for D5239: Support generating HIE files.
  • Post rebase sludge
  • Include srcspan in LocalName check
Nov 17 2018, 12:37 AM

Nov 14 2018

harpocrates added inline comments to D5316: Hadrian: Misc. fixes in Haddock rules.
Nov 14 2018, 11:01 AM
harpocrates added a comment to D5316: Hadrian: Misc. fixes in Haddock rules.

Thanks for the review! I'll address the feedback in the coming day. In the meantime, I have a couple followup questions...

Nov 14 2018, 1:20 AM

Nov 12 2018

harpocrates added a comment to D5332: Simplify 'ExtBits' in the lexer.

These are just some cleanup changes I wanted to do in D5269, but thought would distract from the main purpose of the diff. None of the stuff here is essential or fixes any bugs, so I'm willing to just abandon if folks think this is too much code churn for too little benefit.

Nov 12 2018, 8:17 PM
harpocrates added a parent revision for D5332: Simplify 'ExtBits' in the lexer: D5269: 'DynFlag'-free version of 'mkParserFlags'.
Nov 12 2018, 8:13 PM
harpocrates added a child revision for D5269: 'DynFlag'-free version of 'mkParserFlags': D5332: Simplify 'ExtBits' in the lexer.
Nov 12 2018, 8:13 PM
harpocrates created D5332: Simplify 'ExtBits' in the lexer.
Nov 12 2018, 8:13 PM