- User Since
- Jul 11 2017, 4:53 PM (97 w, 4 d)
Aug 18 2017
Yes, looks like Phyx just set it ~4 hours ago.
Aug 17 2017
Can we add this to the 8.4.1 milestone?
Jul 30 2017
Remove redundant import for Windows.
Jul 29 2017
If anyone does pick up the task of writing it in C, this might prove useful - http://utf8everywhere.org. I was under the mistaken assumption that the Windows API's Unicode functions were the ‘right’ ones to use for dealing with Unicode strings in C on Windows.
Wrap lines longer than 80 columns.
@Phyx won't the title form part of the commit message also? Is a summary necessary if the title is self-explanatory (this ticket has no summary currently)?
@Phyx yes, it's the one that was in this diff. I've removed it, I'm giving up. Sorry, I should have made it clear in the diff update message that I was moving on. I've just decided to use the Haskell implementation. @bgamari and I had a conversation about this and leant towards implementing in C for performance reasons (me assuming it would be less difficult than it's proven); in C, GetEnvironmentStrings returns a pointer to the environment variable block, and we can copy the relevant value, free the block and just marshal the single value, whereas in Haskell, we'd have to marshal the whole block of variables through to Haskell-land just to lookup one variable.
Remove redundant imports from non-Windows OSes.
I'm having a lot of trouble getting getenv_windows to work in C; I even
tried porting Matz' Ruby Implementation code and I just can't get it to
work. Memory access errors every time.
Jul 28 2017
I need to head off to work, but I'll leave you with a screenshot of where I'm at. The error in the screenshot is a trivial one, easy to fix; just a basic type mismatch. I'll have to fix it when I get home, as I don't want to start a build right now.
Jul 26 2017
Sorry, haven't had a chance to look at this yet. I'll have a couple of hours to look at it tonight after work
Jul 22 2017
Damn. I was having this failure (not recognising WINDOWS_CCONV) on my local Windows machine. I still don't know why this happens, but it was initially a local-only problem (masking other errors that Harbormaster showed). I'm gonna try a rebuild, and I'm gonna set up my Windows VM again to debug this tomorrow.
Jul 19 2017
Initialize value to NULL at start to fix -Werror=maybe-uninitialized failure.
Jul 18 2017
Fix missing semicolon.
Use non-deprecated string functions.
I'll probably get on the latest requested changes later today or tomorrow (~10pm here). However, I think we're close.
What the hell? Looks like some previous comments were being held and had never posted at all. Man, Phabricator is confusing as hell.
Wow, I don't know how I missed that. Where did you find that, though? Because I'm looking at this page: https://msdn.microsoft.com/en-us/library/windows/desktop/bb759954(v=vs.85).aspx, and I don't see anything mentioned about deprecation. I want to look at the documentation, so I can find the modern equivalents.
Add GHC Trac ticket reference to release notes.
Include Windows.h, which defines LPSTR and other typedefs.
Jul 17 2017
Add shlwapi to base.cabal extra-libraries.
Link Shlwapi.lib file with pragma macro.
Jul 16 2017
Add changelog entry.
Add TODO for macro block defining WINDOWS_CCONV. Fix copyright year.
Incorporate review suggestions from Phyx.
Fix typos (missing semicolon, slightly wrong function name, etc).
Jul 14 2017
Fix incompatible pointer type errors by using Microsoft safe string functions.
Jul 12 2017
Fix Environment.lookupEnv again.
Fix typo causing incorrect pointer type warnings.
Jul 11 2017
Add getenv for Windows.