gracjan (Gracjan Polak)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 1 2015, 1:49 PM (202 w, 4 d)

Recent Activity

Feb 7 2017

gracjan added inline comments to D3089: Improve the Occurrence Analyzer’s handling of one-shot functions.
Feb 7 2017, 9:41 AM

Feb 5 2017

gracjan added inline comments to rGHC88950a11b9df: Ensure that Literals in an Int# case are in range.
Feb 5 2017, 8:40 AM

Jan 28 2017

gracjan added a comment to D3010: Add a flag to emit error messages as JSON.

Hmm, is there some kind of design document or description what requirements this diff tries to satisfy and which it does not try to fullfil?

Jan 28 2017, 2:58 PM

Jan 18 2017

gracjan added inline comments to rGHC769e3ee7671f: testsuite/recomp001: Sleep to ensure that GHC notices file change.
Jan 18 2017, 3:03 AM

Jan 12 2017

gracjan added inline comments to D2964: testsuite/recomp001: Sleep to ensure that GHC notices file change.
Jan 12 2017, 9:52 AM
gracjan added a comment to D2964: testsuite/recomp001: Sleep to ensure that GHC notices file change.

Alternatively the code could look like:

Jan 12 2017, 7:02 AM
gracjan added a comment to D2964: testsuite/recomp001: Sleep to ensure that GHC notices file change.

I take back the sleep 0.04 comment, I mistook time units there.

Jan 12 2017, 6:04 AM
gracjan added inline comments to D2964: testsuite/recomp001: Sleep to ensure that GHC notices file change.
Jan 12 2017, 3:49 AM

Dec 22 2016

gracjan added a comment to D2881: Define MAP_ANONYMOUS on systems that only provide MAP_ANON.

Now what?

Dec 22 2016, 2:41 AM

Dec 20 2016

gracjan retitled D2881: Define MAP_ANONYMOUS on systems that only provide MAP_ANON from Use MAP_ANON instead of MAP_ANONYMOUS for Mac OS X, fixes #13005 to Define MAP_ANONYMOUS on systems that only provide MAP_ANON.
Dec 20 2016, 3:03 AM
gracjan added a comment to D2881: Define MAP_ANONYMOUS on systems that only provide MAP_ANON.

Moved.

Dec 20 2016, 2:37 AM
gracjan updated the diff for D2881: Define MAP_ANONYMOUS on systems that only provide MAP_ANON.
  • Move compatibility define for MAP_ANONYMOUS to LinkerInternal.h
  • Revert "Source MAP_ANONYMOUS definition from linker/M32Alloc.h"
  • Include mman.h in LinkerInternals.h
  • Include mman.h after Rts.h
Dec 20 2016, 2:36 AM

Dec 19 2016

gracjan added a comment to D2881: Define MAP_ANONYMOUS on systems that only provide MAP_ANON.

I do not know which header files are supposed to be internal to linker subsystem and which header files define publicly available linker interface.

Dec 19 2016, 9:52 AM
gracjan added a comment to D2881: Define MAP_ANONYMOUS on systems that only provide MAP_ANON.
$ find ../.. \( -name '*.c' -or -name '*.h' \) -exec grep -Hn LinkerInternals \{} \;
../../rts/linker/CacheFlush.h:4:#include "LinkerInternals.h"
../../rts/linker/Elf.h:5:#include "LinkerInternals.h"
../../rts/linker/PEi386.h:5:#include "LinkerInternals.h"
../../rts/linker/SymbolExtras.h:5:#include "LinkerInternals.h"
../../rts/RtsSymbolInfo.h:12:#include "LinkerInternals.h"
../../rts/RtsSymbols.h:13:#include "LinkerInternals.h"
../../rts/CheckUnload.c:16:#include "LinkerInternals.h"
../../rts/linker/LoadArchive.c:10:#include "LinkerInternals.h"
../../rts/linker/M32Alloc.c:12:#include "LinkerInternals.h"
../../rts/linker/MachO.c:7:#include "LinkerInternals.h"
../../rts/linker/PEi386.c:60:#include "LinkerInternals.h"
../../rts/linker/SymbolExtras.c:12:#include "LinkerInternals.h"
../../rts/Linker.c:19:#include "LinkerInternals.h"
../../rts/RtsStartup.c:36:#include "LinkerInternals.h"
Dec 19 2016, 9:35 AM
gracjan added a comment to D2881: Define MAP_ANONYMOUS on systems that only provide MAP_ANON.

For now I've added #include "linker/M32Alloc.h"

Dec 19 2016, 9:32 AM
gracjan updated the diff for D2881: Define MAP_ANONYMOUS on systems that only provide MAP_ANON.
  • Source MAP_ANONYMOUS definition from linker/M32Alloc.h
  • Revert "Use MAP_ANON instead of MAP_ANONYMOUS for Mac OS X, fixes Trac #13005"
Dec 19 2016, 9:26 AM
gracjan updated D2881: Define MAP_ANONYMOUS on systems that only provide MAP_ANON.
Dec 19 2016, 7:33 AM
gracjan added a comment to D2881: Define MAP_ANONYMOUS on systems that only provide MAP_ANON.
Dec 19 2016, 7:00 AM
gracjan retitled D2881: Define MAP_ANONYMOUS on systems that only provide MAP_ANON from to Use MAP_ANON instead of MAP_ANONYMOUS for Mac OS X, fixes #13005.
Dec 19 2016, 6:56 AM

Nov 23 2016

gracjan added a comment to D2679: Make default output less verbose (source/object paths).

What do you use this information for? How do you use it?

Nov 23 2016, 8:58 AM

Nov 18 2016

gracjan added a comment to D2679: Make default output less verbose (source/object paths).

Hmm, sorry for jumping in the middle of discussion at this last moment. I just wanted to tell you than in haskell-mode in Emacs we filter out everything after module name, so it looks like this:

Nov 18 2016, 3:41 AM