goldfire (Richard Eisenberg)
User

Projects

User Details

User Since
Jun 13 2014, 11:18 AM (235 w, 3 h)

Recent Activity

Mon, Dec 10

goldfire added a comment to D5229: Visible kind application.

In its current form, does it validate? If so, let's merge it. 8.8 is nigh, and it's best to get this out the door. However, even after merging, we should continue to press forward with some of the tweaks suggested in this thread. My and I will discuss in person later this week. In the meantime, My, report if it validates; when it does, let's just pull the trigger.

Mon, Dec 10, 11:14 PM
goldfire added a comment to D5408: Introduce ExpPatFrame.

We can get a precise answer by looking at the intersection of what checkPattern and checkExpr accept.

With commands, we need to look at the intersection of what checkPattern, checkExpr, and checkCommand accept. And when I get to unifying term/type parsers, also checkType (not currently defined).

Mon, Dec 10, 8:14 PM
goldfire accepted D5435: Fix #16008 with a pinch of addConsistencyConstraints.

👍

Mon, Dec 10, 3:21 PM
goldfire added a comment to D4777: Implement the Unlifted Newtypes proposal. This is proposal 13 on the ghc-proposals repo and is fully described there..

OK. I've exhausted my time budget for this today, but I'll keep this in my queue. Sad to say, but I likely won't get to it for a few days.

Mon, Dec 10, 1:06 PM
goldfire added a comment to D5229: Visible kind application.

I've taken my pass, but I skipped the following:

  • TH (Thanks, @RyanGlScott)
  • Parser (Thanks, @int-index)
  • Test output in partial-sigs, thinking that my suggested change to addTypeCtxt will take care of it.
Mon, Dec 10, 1:00 PM
goldfire added inline comments to D5229: Visible kind application.
Mon, Dec 10, 11:29 AM
goldfire added inline comments to D4777: Implement the Unlifted Newtypes proposal. This is proposal 13 on the ghc-proposals repo and is fully described there..
Mon, Dec 10, 10:56 AM

Sun, Dec 9

goldfire added inline comments to D4777: Implement the Unlifted Newtypes proposal. This is proposal 13 on the ghc-proposals repo and is fully described there..
Sun, Dec 9, 11:07 PM
goldfire added a comment to D5408: Introduce ExpPatFrame.

I'm late to this conversation, and I haven't looked at the code -- only the conversation. Here are my thoughts:

Sun, Dec 9, 11:04 PM
goldfire committed rGHC4773b4308203: Fix minor mistake in comment about data decls. (authored by goldfire).
Fix minor mistake in comment about data decls.
Sun, Dec 9, 9:27 PM

Mon, Dec 3

goldfire added a comment to D5401: Linear types: stepping stone.

I do intend to take a close look at this, but it likely won't happen until after classes end, in about 2 weeks.

Mon, Dec 3, 8:29 PM
goldfire added a comment to D5397: Fix #12102/#15872 by removing outdated users' guide prose.
data T a = Eq a => MkT
Mon, Dec 3, 8:25 PM

Fri, Nov 30

goldfire added a comment to D5397: Fix #12102/#15872 by removing outdated users' guide prose.

They can appear in the kinds of promoted data constructors, say from GADTs with hand-written equality constraints.

Fri, Nov 30, 3:35 PM
goldfire added a comment to D5397: Fix #12102/#15872 by removing outdated users' guide prose.

Looking at the relevant bits of the Monster Patch, it looks like these constraints are eliminated simply in the validity checker. That is, equality constraints in kinds still work, but now the user can't write them. By "work", I mean that tcInstTyBinders does the right thing. It looks like this from the code, but I'm just double-checking my understanding.

Fri, Nov 30, 3:22 PM

Sat, Nov 24

goldfire added inline comments to D5305: Towards using level numbers for generalisation.
Sat, Nov 24, 10:25 PM
goldfire added inline comments to D5305: Towards using level numbers for generalisation.
Sat, Nov 24, 1:26 PM
goldfire accepted D5375: Fix #15941 by only special-casing visible infix applications.

We might want to update this approach if/when Trac #12363 ever gets implemented.

Sat, Nov 24, 12:06 PM

Wed, Nov 21

goldfire added a comment to D5305: Towards using level numbers for generalisation.

Sharing comments for call Simon and I are having.

Wed, Nov 21, 10:33 AM
goldfire updated the diff for D5305: Towards using level numbers for generalisation.

More from SPJ.

Wed, Nov 21, 9:28 AM

Mon, Nov 19

goldfire added a comment to D5305: Towards using level numbers for generalisation.

More later!

Mon, Nov 19, 9:05 AM
goldfire updated the diff for D5305: Towards using level numbers for generalisation.

More updates from Simon.

Mon, Nov 19, 8:28 AM

Sun, Nov 18

goldfire accepted D5328: Fix #15852 by eta expanding data family instance RHSes, too.

LGTM.

Sun, Nov 18, 11:00 PM

Nov 14 2018

goldfire added inline comments to D5328: Fix #15852 by eta expanding data family instance RHSes, too.
Nov 14 2018, 10:31 AM
goldfire added a comment to D5282: Print explicit foralls in type family eqns when appropriate.

make all binders in a representation TyCon into Specified, at birth

Nov 14 2018, 8:53 AM

Nov 12 2018

goldfire added inline comments to D5286: Run typed splices in the zonker.
Nov 12 2018, 3:06 PM
goldfire updated the diff for D5305: Towards using level numbers for generalisation.

More commits from Simon:

Nov 12 2018, 10:46 AM
goldfire requested changes to D5328: Fix #15852 by eta expanding data family instance RHSes, too.
Nov 12 2018, 8:54 AM
goldfire requested changes to D5286: Run typed splices in the zonker.

This looks like it works, but I think it can be refactored to be simpler. Thanks!

Nov 12 2018, 8:45 AM

Nov 7 2018

goldfire added a comment to D5305: Towards using level numbers for generalisation.

Out of time now; more later. (Note to self: I read through files before TcHsType, kcImplicitTKBndrs but not kcLHsQTyVars; also read through TcMType)

Nov 7 2018, 12:26 PM
goldfire created D5305: Towards using level numbers for generalisation.
Nov 7 2018, 11:36 AM
goldfire accepted D5283: Fix #15828, from `More explicit foralls`.

LGTM.

Nov 7 2018, 10:41 AM
goldfire added inline comments to D5282: Print explicit foralls in type family eqns when appropriate.
Nov 7 2018, 10:35 AM

Nov 5 2018

goldfire committed rGHC5693ddd07103: Actually add test for #15859. (authored by goldfire).
Actually add test for #15859.
Nov 5 2018, 9:53 PM
goldfire committed rGHC72b82343b793: Fix #15859 by checking, not assuming, an ArgFlag (authored by goldfire).
Fix #15859 by checking, not assuming, an ArgFlag
Nov 5 2018, 12:53 PM
goldfire accepted D5294: Fix #15845 by defining etaExpandFamInstLHS and using it.

Not from me. Ship it!

Nov 5 2018, 12:31 PM
goldfire added inline comments to D5282: Print explicit foralls in type family eqns when appropriate.
Nov 5 2018, 12:30 PM
goldfire abandoned D5150: Fix #14880..

Yes!

Nov 5 2018, 11:19 AM

Nov 2 2018

goldfire added inline comments to D5283: Fix #15828, from `More explicit foralls`.
Nov 2 2018, 9:44 PM
goldfire added a comment to D5294: Fix #15845 by defining etaExpandFamInstLHS and using it.

I've commented on the ticket, as that seems a better place than here.

Nov 2 2018, 8:59 PM
goldfire added a comment to D5294: Fix #15845 by defining etaExpandFamInstLHS and using it.

I have a hunch that this might also fix Trac #15852.

Nov 2 2018, 3:05 PM
goldfire added inline comments to D5282: Print explicit foralls in type family eqns when appropriate.
Nov 2 2018, 3:02 PM
goldfire added inline comments to D5294: Fix #15845 by defining etaExpandFamInstLHS and using it.
Nov 2 2018, 11:24 AM

Nov 1 2018

goldfire committed rGHC1f72a1c81368: Don't lint erroneous programs. (authored by goldfire).
Don't lint erroneous programs.
Nov 1 2018, 5:11 PM
goldfire committed rGHC74ed9c1c1b26: Actually fail in failIfEmitsConstraints (authored by goldfire).
Actually fail in failIfEmitsConstraints
Nov 1 2018, 4:44 PM
goldfire committed rGHC255d2e323a88: Fix embarrassing, egregious bug in roles of (->) (authored by goldfire).
Fix embarrassing, egregious bug in roles of (->)
Nov 1 2018, 4:44 PM
goldfire added inline comments to D5282: Print explicit foralls in type family eqns when appropriate.
Nov 1 2018, 11:04 AM
goldfire added inline comments to D5282: Print explicit foralls in type family eqns when appropriate.
Nov 1 2018, 8:34 AM

Oct 29 2018

goldfire committed rGHC09740d50e74a: Revert "Remove kind generalisation from tcRnType" (authored by goldfire).
Revert "Remove kind generalisation from tcRnType"
Oct 29 2018, 11:37 AM
goldfire added a reverting change for rGHC3a51abd04432: Remove kind generalisation from tcRnType: rGHC09740d50e74a: Revert "Remove kind generalisation from tcRnType".
Oct 29 2018, 11:37 AM
goldfire committed rGHC2adffd854eff: Test #15076 in dependent/should_compile/T15076* (authored by goldfire).
Test #15076 in dependent/should_compile/T15076*
Oct 29 2018, 11:37 AM
goldfire committed rGHC731c95f51672: Test #15825 in dependent/should_fail/T15825 (authored by goldfire).
Test #15825 in dependent/should_fail/T15825
Oct 29 2018, 11:37 AM
goldfire committed rGHCc1db1eb028b6: Test T15711 in indexed-types/should_compile/T15711 (authored by goldfire).
Test T15711 in indexed-types/should_compile/T15711
Oct 29 2018, 8:53 AM
goldfire committed rGHC3a51abd04432: Remove kind generalisation from tcRnType (authored by goldfire).
Remove kind generalisation from tcRnType
Oct 29 2018, 8:53 AM

Oct 28 2018

goldfire abandoned D5208: Fix #14880..

Committed: 5e45ad10ffca1ad175b10f6ef3327e1ed8ba25f3

Oct 28 2018, 10:47 PM
goldfire abandoned D5275: Fix #15787 by squashing a coercion hole..

Committed: 4427315a65b25db22e1754d41b43dd4b782b022f

Oct 28 2018, 10:30 PM
goldfire committed rGHC5e45ad10ffca: Finish fix for #14880. (authored by tdammers).
Finish fix for #14880.
Oct 28 2018, 10:18 PM
goldfire committed rGHC4427315a65b2: Fix #15787 by squashing a coercion hole. (authored by goldfire).
Fix #15787 by squashing a coercion hole.
Oct 28 2018, 10:18 PM
goldfire added inline comments to D5265: Fix `:k` command: add validity checking.
Oct 28 2018, 10:07 PM
goldfire requested changes to D5276: users guide: Introduce :pragma: directive.

Thanks for the quick action here!

Oct 28 2018, 9:53 PM
goldfire added a comment to D5275: Fix #15787 by squashing a coercion hole..

I may not get a chance to cycle back to this one. If it validates, please merge. Thanks.

Oct 28 2018, 3:09 PM
goldfire created D5275: Fix #15787 by squashing a coercion hole..
Oct 28 2018, 3:08 PM
goldfire added inline comments to D5208: Fix #14880..
Oct 28 2018, 2:46 PM
goldfire updated the diff for D5208: Fix #14880..

Get quantification right, for once.

Oct 28 2018, 2:27 PM

Oct 27 2018

goldfire committed rGHC512eeb9bb9a8: More explicit foralls (GHC Proposal 0007) (authored by mayac).
More explicit foralls (GHC Proposal 0007)
Oct 27 2018, 1:57 PM
goldfire closed D4894: More explicit foralls (GHC Proposal 0007).
Oct 27 2018, 1:57 PM

Oct 26 2018

goldfire added inline comments to D4894: More explicit foralls (GHC Proposal 0007).
Oct 26 2018, 11:10 PM

Oct 22 2018

goldfire committed rGHCd06925715b83: Clarify Note about ForAllCo coercions. (authored by goldfire).
Clarify Note about ForAllCo coercions.
Oct 22 2018, 1:59 PM
goldfire accepted D5247: Update core-spec for Coercion Quantification.

Thanks!

Oct 22 2018, 1:51 PM

Oct 21 2018

goldfire requested changes to D5247: Update core-spec for Coercion Quantification.
Oct 21 2018, 8:51 PM

Oct 19 2018

goldfire added a comment to D5229: Visible kind application.

I discovered a potential bug, minimized by Ryan

Oct 19 2018, 10:48 AM
goldfire added a comment to D5229: Visible kind application.

Is using kind application in data declarations; data El @k ..., wanted. Currently rejected

Oct 19 2018, 7:05 AM

Oct 18 2018

goldfire added a comment to D5229: Visible kind application.

I thought so too... but it turns out that the [renamer turns the [] HsVar into an ExplicitList](http://git.haskell.org/ghc.git/blob/46f2906d1c6e1fb732a90882487479a2ebf19ca1:/compiler/rename

Oct 18 2018, 9:23 PM
goldfire accepted D5231: Adding almost devoid check for covar in ForAllCo.

Just update a comment as my comment below, then feel free to push.

Oct 18 2018, 9:13 PM
goldfire added a comment to D5229: Visible kind application.

I still say that I'm unbothered by the examples Ryan writes.

Oct 18 2018, 9:05 AM
goldfire added inline comments to D5229: Visible kind application.
Oct 18 2018, 8:11 AM
goldfire added a comment to D5229: Visible kind application.
  1. The following code produces a GHC panic:
Oct 18 2018, 8:05 AM

Oct 17 2018

goldfire added inline comments to D5229: Visible kind application.
Oct 17 2018, 1:55 PM
goldfire added a comment to D5229: Visible kind application.

For T13524, you can apply this diff:

Oct 17 2018, 1:52 PM
goldfire added a comment to D5229: Visible kind application.

Very nice work. Almost all of my comments are about style/commenting -- very few functional changes to make.

Oct 17 2018, 12:58 PM
goldfire added a comment to D5231: Adding almost devoid check for covar in ForAllCo.

Ah. Much better. Thanks. See one comment below.

Oct 17 2018, 12:53 PM
goldfire added a comment to D4894: More explicit foralls (GHC Proposal 0007).

Just checking in here -- @mayac, you're planning on updating the behavior around warnings and then we'll be good to go?

Oct 17 2018, 12:53 PM
goldfire added inline comments to D5231: Adding almost devoid check for covar in ForAllCo.
Oct 17 2018, 12:02 PM
goldfire committed rGHC38c28c1a8bb1: Fix #15761 by adding parens (authored by goldfire).
Fix #15761 by adding parens
Oct 17 2018, 10:33 AM
goldfire requested changes to D5231: Adding almost devoid check for covar in ForAllCo.

Broadly looks good, but I would change the way that the traversal function works to just return a Bool (as commented below). Thanks!

Oct 17 2018, 8:17 AM

Oct 15 2018

goldfire updated the diff for D5208: Fix #14880..
  • Wibbles suggested by Simon
Oct 15 2018, 5:09 PM
goldfire added inline comments to D5208: Fix #14880..
Oct 15 2018, 5:09 PM
goldfire accepted D5228: Fix #12430 by expanding type synonyms in injTyVarsOfType.

Well, that was easy.

Oct 15 2018, 12:39 PM
goldfire reclaimed D5208: Fix #14880..

This is still under active work. I understand parts of Trac #14880 have been merged and will deal with that in due course.

Oct 15 2018, 12:12 PM
goldfire added inline comments to D5208: Fix #14880..
Oct 15 2018, 12:11 PM
goldfire accepted D5206: Move eta-reduced coaxiom compatibility handling quirks into FamInstEnv..
In D5206#143964, @mniip wrote:

Well then, any further comments on the patch?

Oct 15 2018, 8:51 AM

Oct 14 2018

goldfire accepted D5217: Fix #15725 with an extra Sym.

LGTM. Thanks!

Oct 14 2018, 10:35 PM
goldfire added a comment to D5206: Move eta-reduced coaxiom compatibility handling quirks into FamInstEnv..

You're worried about the haddock performance test? Don't be. I've seen that test failing for some time.

Oct 14 2018, 6:08 PM

Oct 11 2018

goldfire added inline comments to D5217: Fix #15725 with an extra Sym.
Oct 11 2018, 9:23 PM
goldfire added a comment to D5217: Fix #15725 with an extra Sym.

I haven't thought deeply about the technical change here, but it all seems very plausible, Ryan seems confident, and I trust Ningning's analysis of this. So all that adds up to a +1 from me.

Oct 11 2018, 4:18 PM

Oct 8 2018

goldfire updated the diff for D5208: Fix #14880..

A little more bugfixing.

Oct 8 2018, 10:33 PM

Oct 7 2018

goldfire added inline comments to D5206: Move eta-reduced coaxiom compatibility handling quirks into FamInstEnv..
Oct 7 2018, 9:33 PM
goldfire added a comment to D5208: Fix #14880..

And I'll look into your comment about variable ordering. Thanks for pointing this out.

Oct 7 2018, 9:24 PM

Oct 5 2018

goldfire created D5208: Fix #14880..
Oct 5 2018, 9:34 PM
goldfire added a comment to D5206: Move eta-reduced coaxiom compatibility handling quirks into FamInstEnv..

I like this fix. Minor wibbles suggested below. Thanks!

Oct 5 2018, 2:25 PM
goldfire added inline comments to D4894: More explicit foralls (GHC Proposal 0007).
Oct 5 2018, 9:52 AM