gibiansky (Andrew Gibiansky)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 15 2014, 12:40 PM (248 w, 5 d)

Recent Activity

Jul 8 2016

gibiansky committed rHL7cb5f73f10a1: Merge 8f9dc7c52dc7f865e417efe8add303e9a04db54b into… (authored by gibiansky).
Merge 8f9dc7c52dc7f865e417efe8add303e9a04db54b into…
Jul 8 2016, 2:28 PM
gibiansky committed rHLa016f94024d7: Update to new Stackage and make hscolour changes (authored by gibiansky).
Update to new Stackage and make hscolour changes
Jul 8 2016, 2:28 PM
gibiansky committed rHL8f9dc7c52dc7: Fix DevelMain.hs for new wai (authored by gibiansky).
Fix DevelMain.hs for new wai
Jul 8 2016, 2:28 PM

Oct 12 2015

gibiansky added a comment to D1219: Support ArgumentDo (fixes #10843).

My conclusion was that support for the extension was very mixed, and that I
do not think the extension makes sense without overall approval from the
community. I am not planning on pushing this any further.

Oct 12 2015, 9:30 PM

Sep 6 2015

gibiansky added a comment to D1219: Support ArgumentDo (fixes #10843).

@goldfire: I would actually prefer the pretty printer work properly. I added that because I didn't realize it was working wrong. It used to say something like, "there is an error in the do block below, do you want Argument Do". But then there were parens, so it didn't make sense, because GHC had fixed the error when pretty printing, so the user would be confused, because the shown code was not what they typed, and the shown code was actually NOT an error. So if the pretty printer is fixed, I'll change the error message back to what it was originally (that is what I would prefer).

Sep 6 2015, 10:04 PM

Sep 5 2015

gibiansky added a comment to D1219: Support ArgumentDo (fixes #10843).

Hooray, it passes ./validate now.

Sep 5 2015, 5:47 PM
gibiansky updated the diff for D1219: Support ArgumentDo (fixes #10843).
  • Add strictness in parser to avoid allocation
Sep 5 2015, 5:00 PM
gibiansky added a comment to D1219: Support ArgumentDo (fixes #10843).

I got validation errors in parsing001. This seems to be a performance test. I don't think my parser changes in any way should change the parsing of the parsing001 test... any ideas as to why this is failing? (I restarted the build to see if its intermittent...)

Sep 5 2015, 4:02 PM
gibiansky updated the diff for D1219: Support ArgumentDo (fixes #10843).
  • Fix tests for lambda case and error messages
Sep 5 2015, 2:16 PM
gibiansky updated the diff for D1219: Support ArgumentDo (fixes #10843).
  • Parse lambdas without dollar sign
  • Fix test that detects ghc-only extensions
Sep 5 2015, 1:32 PM
gibiansky added a comment to D1219: Support ArgumentDo (fixes #10843).

@nomeata: Here's some info on the $ hack from StackOverflow.

Sep 5 2015, 11:43 AM
gibiansky added a comment to D1219: Support ArgumentDo (fixes #10843).

I've fixed the validation failure for now (and will fix more if they come), but I think the real question is not whether the code is correct right now, but whether we actually want an extension like this...

Sep 5 2015, 9:44 AM
gibiansky updated the diff for D1219: Support ArgumentDo (fixes #10843).
  • ArgumentDo only applies to do blocks, not list comprehensions, etc
Sep 5 2015, 9:25 AM
gibiansky retitled D1219: Support ArgumentDo (fixes #10843) from to Support ArgumentDo (fixes #10843).
Sep 5 2015, 3:30 AM

Jul 27 2015

gibiansky abandoned D171: Add -prelude-is flag.

It is unclear whether this feature is necessary or whether this would be the right way to implement it if it is necessary, so this diff is being abandoned.

Jul 27 2015, 5:25 PM
gibiansky added a comment to D171: Add -prelude-is flag.

Check out the GHC trac page. There was more discussion there – it seemed like there were alternatives to this that removed the need for this patch.

Jul 27 2015, 4:13 PM

Jun 30 2015

gibiansky added a comment to D1014: Remove redundant parser entry point.

There is no reason for parseFullStmt to exist. I am in favor of getting rid of it. Including it was a mistake, oops.

Jun 30 2015, 12:30 PM

Aug 22 2014

gibiansky added a comment to D171: Add -prelude-is flag.

Should I added a test for this?

Aug 22 2014, 1:06 AM
gibiansky retitled D171: Add -prelude-is flag from to Add -prelude-is flag.
Aug 22 2014, 1:02 AM

Jul 15 2014

gibiansky retitled D71: Adding more parser exports and some documentation. from to Adding more parser exports and some documentation..
Jul 15 2014, 12:57 PM