ggreif (Gabor Greif)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Jun 5 2014, 7:34 PM (202 w, 6 d)
Availability
Available

Recent Activity

Jan 17 2018

ggreif committed rGHCc65104e1a687: Typos in comments (authored by ggreif).
Typos in comments
Jan 17 2018, 7:24 AM

Jan 14 2018

ggreif added inline comments to D4267: Pointer tagging for all families.
Jan 14 2018, 4:01 AM

Jan 5 2018

ggreif added inline comments to D4267: Pointer tagging for all families.
Jan 5 2018, 3:36 PM

Jan 3 2018

ggreif committed rGHC7a25659efc4d: Typos in comments (authored by ggreif).
Typos in comments
Jan 3 2018, 10:16 AM

Jan 2 2018

ggreif added inline comments to D4267: Pointer tagging for all families.
Jan 2 2018, 1:24 PM
ggreif added inline comments to D4267: Pointer tagging for all families.
Jan 2 2018, 1:15 PM
ggreif added a comment to D4267: Pointer tagging for all families.

@simonpj I have created https://ghc.haskell.org/trac/ghc/ticket/14626 for the "unnecessary enter" issue.

Jan 2 2018, 6:55 AM

Dec 28 2017

ggreif committed rNOFIB07a93962fa89: add missing import (authored by ggreif).
add missing import
Dec 28 2017, 2:36 PM
ggreif committed rGHCf2db228bd1fc: Typos in comments [ci skip] (authored by ggreif).
Typos in comments [ci skip]
Dec 28 2017, 3:25 AM

Dec 23 2017

ggreif added a comment to D4267: Pointer tagging for all families.

@simonpj Never mind, it is emitEnter; now I'll go and see who calls that. If I am on the wrong train, just yell!

Dec 23 2017, 7:14 AM
ggreif added a comment to D4267: Pointer tagging for all families.

@simonpj Please do not put too hope much into to the numbers, my laptop was on battery when I made them :-( and this machine is not quiet enough for the measurements. Indeed I could not repeat the same score in the meantime, so I'd say they are overly optimistic.

Dec 23 2017, 5:00 AM

Dec 21 2017

ggreif added a comment to D4267: Pointer tagging for all families.

@simonmar I found an outlier with instruction counts in no fib: spectral/lambda (+0.76%) so I went looking if this has negative effect on ruuntime. It does not, to the contrary:

Dec 21 2017, 12:49 PM
ggreif added a comment to D4267: Pointer tagging for all families.

@simonmar nofib sizes only change marginally: https://perf.haskell.org/ghc/#compare/244d1441bbe9a8d5e83015c749d1339b8f7c7319/efed6566078beace40443dd9acc2cdf73d0beb5c
the worst being +0.02%.

Dec 21 2017, 12:25 PM
ggreif added a comment to D4267: Pointer tagging for all families.
Dec 21 2017, 12:25 PM
ggreif added a comment to D4267: Pointer tagging for all families.

@simonpj I have added a pretty extensive note how the nested switches work: http://ghc.haskell.org/trac/ghc/changeset/57192187a2c086945897259847e3605bd9fea6b9/ghc

Dec 21 2017, 12:25 PM
ggreif committed rGHCbcb519c5f814: Typos in comments (authored by ggreif).
Typos in comments
Dec 21 2017, 11:37 AM

Dec 19 2017

ggreif committed rGHCa100763cc5c6: Get rid of some stuttering in comments and docs (authored by ggreif).
Get rid of some stuttering in comments and docs
Dec 19 2017, 7:37 AM
ggreif added a comment to D4267: Pointer tagging for all families.

@alexbiehl I have added a test case for your question (suggestion)

Dec 19 2017, 5:39 AM

Dec 18 2017

ggreif added a comment to D4267: Pointer tagging for all families.

@alexbiehl I have added a test case for your question (suggestion)

Dec 18 2017, 1:35 PM
ggreif committed rGHC244d1441bbe9: Typos in comments (authored by ggreif).
Typos in comments
Dec 18 2017, 11:57 AM
ggreif added inline comments to D4267: Pointer tagging for all families.
Dec 18 2017, 6:48 AM
ggreif updated the diff for D4267: Pointer tagging for all families.
  • Handle the case when ptr tag is telling no story
Dec 18 2017, 6:44 AM
ggreif added a comment to D4267: Pointer tagging for all families.

@simonmar @simonpj Over the next few days I'll try to write up everything (on a wiki?)

Dec 18 2017, 4:51 AM

Dec 16 2017

ggreif added a comment to D4267: Pointer tagging for all families.

I have resolved all coding issues. Remaining stuff:

Dec 16 2017, 7:04 AM
ggreif updated the diff for D4267: Pointer tagging for all families.
  • note tweaks
  • Extra argument for emitting pre-join label code
Dec 16 2017, 6:59 AM

Dec 15 2017

ggreif added a comment to D4267: Pointer tagging for all families.

@alexbiehl I am working on a slight tweak to emitSwitch, which will automatically take care of the degenerate cases that can arise. Thanks for the input!

Dec 15 2017, 6:07 AM
ggreif updated the diff for D4267: Pointer tagging for all families.
  • first round of review feedback
Dec 15 2017, 4:22 AM

Dec 14 2017

ggreif added a comment to D4267: Pointer tagging for all families.

Some comments will be resolved when I push next.

Dec 14 2017, 3:49 PM
ggreif added a comment to D4267: Pointer tagging for all families.

Self-critique.

Dec 14 2017, 3:19 PM
ggreif created D4267: Pointer tagging for all families.
Dec 14 2017, 10:27 AM
ggreif committed rGHCeeb36ebdfd13: typos in local var (authored by ggreif).
typos in local var
Dec 14 2017, 10:01 AM

Dec 13 2017

ggreif committed rGHC6eb32579478f: Typofix in comment (authored by ggreif).
Typofix in comment
Dec 13 2017, 4:00 PM

Nov 27 2017

ggreif accepted D4241: typecheck: Consistently use pretty quotes in error messages.
Nov 27 2017, 1:24 PM

Nov 22 2017

ggreif added inline comments to D4197: Add warn-missing-export-lists.
Nov 22 2017, 4:19 AM

Oct 30 2017

ggreif committed rGHC201b5aa65109: Catch a few more typos in comments (authored by ggreif).
Catch a few more typos in comments
Oct 30 2017, 9:01 AM
ggreif committed rGHC53700a9de48a: minor wordsmithing (authored by ggreif).
minor wordsmithing
Oct 30 2017, 9:01 AM
ggreif committed rGHC15696682a4ac: Typofixes in comments (authored by ggreif).
Typofixes in comments
Oct 30 2017, 9:01 AM
ggreif committed rGHCec356e8a3530: Typofix in panic (authored by ggreif).
Typofix in panic
Oct 30 2017, 9:01 AM
ggreif committed rGHC1b115b16729a: Fix typo in accessor name (authored by ggreif).
Fix typo in accessor name
Oct 30 2017, 9:01 AM

Oct 18 2017

ggreif committed rGHC870020e65728: whitespace only (authored by ggreif).
whitespace only
Oct 18 2017, 3:51 PM
ggreif committed rGHCaba7786068ae: Typofix in comment (authored by ggreif).
Typofix in comment
Oct 18 2017, 3:51 PM

Oct 17 2017

ggreif committed rGHC2f436151f481: Fix grammaros in comments (authored by ggreif).
Fix grammaros in comments
Oct 17 2017, 7:23 AM
ggreif committed rGHCed48d133f9b9: Simplify, no functionality change (authored by ggreif).
Simplify, no functionality change
Oct 17 2017, 7:23 AM

Oct 16 2017

ggreif committed rGHC6aa6a86b836e: Fix typo (authored by trommler).
Fix typo
Oct 16 2017, 6:57 AM
ggreif committed rGHCafac6b1107e6: Fix typo (authored by trommler).
Fix typo
Oct 16 2017, 6:57 AM

Sep 27 2017

ggreif committed rGHC4364f1e7543b: Typofixes (authored by ggreif).
Typofixes
Sep 27 2017, 5:59 AM

Sep 26 2017

ggreif committed rGHC7446c7f68bd5: A bunch of typofixes (authored by ggreif).
A bunch of typofixes
Sep 26 2017, 5:41 AM

Sep 7 2017

ggreif committed rGHCfee403fd9354: Handle W80 in floatFormat (authored by ggreif).
Handle W80 in floatFormat
Sep 7 2017, 6:49 AM
ggreif committed rGHCd97a6fe2b97c: Fix typos in diagnostics, testsuite and comments (authored by ggreif).
Fix typos in diagnostics, testsuite and comments
Sep 7 2017, 6:49 AM

Sep 6 2017

ggreif committed rGHCc6726d6ad99c: Cleanups, remove commented-out code (authored by ggreif).
Cleanups, remove commented-out code
Sep 6 2017, 6:32 PM

Aug 24 2017

ggreif committed rGHC74af2e72855b: Typo fixed (authored by ggreif).
Typo fixed
Aug 24 2017, 5:15 AM
ggreif committed rNOFIB999a46a1a738: Catch a few typos (authored by ggreif).
Catch a few typos
Aug 24 2017, 5:08 AM

Aug 1 2017

ggreif committed rGHC7a74f5053fa0: Typofixes [ci skip] (authored by ggreif).
Typofixes [ci skip]
Aug 1 2017, 7:17 AM

Jul 31 2017

ggreif committed rGHC2ef973e823ff: A bunch of typofixes (authored by ggreif).
A bunch of typofixes
Jul 31 2017, 12:38 PM

Jul 30 2017

ggreif committed rGHCf2c12c391e8c: Add haddock markup (authored by ggreif).
Add haddock markup
Jul 30 2017, 8:46 AM
ggreif committed rGHC969928602aa7: Typofixes [ci skip] (authored by ggreif).
Typofixes [ci skip]
Jul 30 2017, 8:46 AM

Jul 27 2017

ggreif committed rGHC4a2641578bc9: Remove unneeded import (authored by ggreif).
Remove unneeded import
Jul 27 2017, 6:06 AM

Jul 26 2017

ggreif committed rGHC362339dd4cfd: Fix note references and some typos (authored by ggreif).
Fix note references and some typos
Jul 26 2017, 9:41 AM

Jul 20 2017

ggreif committed rGHCa273c735ca26: Spelling fixes (authored by ggreif).
Spelling fixes
Jul 20 2017, 6:25 AM

Jul 18 2017

ggreif committed rGHC935acb6f0de3: Typos in comments and explanation for unusused imports (authored by ggreif).
Typos in comments and explanation for unusused imports
Jul 18 2017, 7:22 AM

Jul 6 2017

ggreif committed rGHC99adcc8804e9: Typos in comments [ci skip] (authored by ggreif).
Typos in comments [ci skip]
Jul 6 2017, 3:51 AM

Jul 3 2017

ggreif committed rGHC544ac0d2e8fc: rename tcInstBinder(s)X to tcInstBinder(s) (authored by ggreif).
rename tcInstBinder(s)X to tcInstBinder(s)
Jul 3 2017, 5:31 AM
ggreif closed D3690: rename tcInstBinder(s)X to tcInstBinder(s) by committing rGHC544ac0d2e8fc: rename tcInstBinder(s)X to tcInstBinder(s).
Jul 3 2017, 5:31 AM

Jun 30 2017

Herald added a reviewer for D3690: rename tcInstBinder(s)X to tcInstBinder(s): austin.
Jun 30 2017, 7:59 AM

Jun 29 2017

ggreif committed rGHC54ccf0c957a2: remove dead function 'tcInstBinders' (authored by ggreif).
remove dead function 'tcInstBinders'
Jun 29 2017, 6:07 AM

Jun 28 2017

ggreif committed rGHC7097f94df0c6: Remove unneeded import (authored by ggreif).
Remove unneeded import
Jun 28 2017, 1:13 PM
ggreif committed rGHC3f9422cb68d5: More typos in comments [ci skip] (authored by ggreif).
More typos in comments [ci skip]
Jun 28 2017, 1:12 PM
ggreif committed rGHC78c80c250021: Typos in comments and manual [ci skip] (authored by ggreif).
Typos in comments and manual [ci skip]
Jun 28 2017, 9:42 AM

Jun 20 2017

ggreif committed rGHCb1fa386cdae1: Fix note reference [ci skip] (authored by ggreif).
Fix note reference [ci skip]
Jun 20 2017, 5:01 AM

Jun 14 2017

ggreif committed rGHCece39c34b784: Fix Haddock markup (authored by ggreif).
Fix Haddock markup
Jun 14 2017, 5:17 AM

Jun 13 2017

ggreif committed rGHC0058a3490fc3: Typos [ci skip] (authored by ggreif).
Typos [ci skip]
Jun 13 2017, 5:07 AM

Jun 6 2017

ggreif committed rGHCe77b9a2069bc: Typo in output of remote slave startup [merge cand] (authored by ggreif).
Typo in output of remote slave startup [merge cand]
Jun 6 2017, 7:34 AM

Jun 2 2017

ggreif committed rGHC750a25f47b62: A few typos [ci skip] (authored by ggreif).
A few typos [ci skip]
Jun 2 2017, 4:09 AM

May 26 2017

ggreif committed rGHC19c4203f12a8: Typos in comments [ci skip] (authored by ggreif).
Typos in comments [ci skip]
May 26 2017, 7:56 AM

May 23 2017

ggreif committed rGHC0b4b4a346e69: Typos in comments and manual [ci skip] (authored by ggreif).
Typos in comments and manual [ci skip]
May 23 2017, 10:35 AM

May 12 2017

ggreif committed rGHC09938f29cd61: Typos [ci skip] (authored by ggreif).
Typos [ci skip]
May 12 2017, 3:07 AM

May 10 2017

ggreif committed rGHC22a03e728812: Typos [ci skip] (authored by ggreif).
Typos [ci skip]
May 10 2017, 3:03 AM

May 5 2017

ggreif committed rGHCa483e711da78: tweak to minimize diff against ocInit_ELF (authored by ggreif).
tweak to minimize diff against ocInit_ELF
May 5 2017, 5:52 AM
ggreif committed rGHC02748a526599: Typos in comments [ci skip] (authored by ggreif).
Typos in comments [ci skip]
May 5 2017, 5:27 AM

May 4 2017

ggreif committed rGHC81af480a0fd3: Abandon typedefing the {Section,ObjectCode}FormatInfo structs (authored by ggreif).
Abandon typedefing the {Section,ObjectCode}FormatInfo structs
May 4 2017, 9:51 AM
ggreif closed D3527: Abandon typedefing the {Section,ObjectCode}FormatInfo structs by committing rGHC81af480a0fd3: Abandon typedefing the {Section,ObjectCode}FormatInfo structs.
May 4 2017, 9:51 AM
ggreif updated the diff for D3527: Abandon typedefing the {Section,ObjectCode}FormatInfo structs.
  • cleanups
May 4 2017, 6:21 AM
ggreif added a comment to D3527: Abandon typedefing the {Section,ObjectCode}FormatInfo structs.

I'll clean up and commit+push.

May 4 2017, 3:30 AM

May 3 2017

ggreif added a comment to D3527: Abandon typedefing the {Section,ObjectCode}FormatInfo structs.

@angerman try compiling (only the .c files dominated by those headers) with --pedantic added to the command line manually. I do not really know, as I don't have another compiler to check.

May 3 2017, 8:00 AM
ggreif added a reviewer for D3527: Abandon typedefing the {Section,ObjectCode}FormatInfo structs: angerman.

I am testing the waters whether the rts maintainers really insist on the typedefs. If this commit is positively received, I intend to get rid of the leading underscores on the two affected struct names too.

May 3 2017, 5:15 AM
Herald added a reviewer for D3527: Abandon typedefing the {Section,ObjectCode}FormatInfo structs: austin.
May 3 2017, 5:10 AM

May 2 2017

ggreif committed rGHCb1aede61350a: Typos in manual and comments (authored by ggreif).
Typos in manual and comments
May 2 2017, 6:45 AM

Apr 12 2017

ggreif committed rGHCfc2a96a1ea9c: Typos in comments [ci skip] (authored by ggreif).
Typos in comments [ci skip]
Apr 12 2017, 5:44 AM

Apr 6 2017

ggreif committed rGHCc600f3cee57a: Fix markup (authored by ggreif).
Fix markup
Apr 6 2017, 6:45 AM

Apr 5 2017

ggreif committed rGHC4a1eed40bec0: test for HAVE_CLOCK_GETTIME definedness (authored by ggreif).
test for HAVE_CLOCK_GETTIME definedness
Apr 5 2017, 10:38 AM
ggreif committed rGHC577f3da7b819: Typos in comments [ci skip] (authored by ggreif).
Typos in comments [ci skip]
Apr 5 2017, 10:24 AM

Mar 30 2017

ggreif committed rGHCff7094e5a804: Typos in comments [ci skip] (authored by ggreif).
Typos in comments [ci skip]
Mar 30 2017, 5:15 AM

Mar 28 2017

ggreif committed rGHC08a6fc69ce16: Spelling in comments only [ci skip] (authored by ggreif).
Spelling in comments only [ci skip]
Mar 28 2017, 5:26 AM

Mar 27 2017

ggreif committed rGHCa6675a93efe7: Don't redefine typedef names (authored by ggreif).
Don't redefine typedef names
Mar 27 2017, 7:41 AM

Mar 24 2017

ggreif committed rGHC1dd60ac9a949: Typos in comments (notes too) [ci skip] (authored by ggreif).
Typos in comments (notes too) [ci skip]
Mar 24 2017, 8:24 AM

Mar 17 2017

ggreif committed rGHC7a38783b72f8: Typos in manual and comments [ci skip] (authored by ggreif).
Typos in manual and comments [ci skip]
Mar 17 2017, 5:25 AM

Mar 14 2017

ggreif committed rGHC50512c6b2bd8: Typos in manual and comments (authored by ggreif).
Typos in manual and comments
Mar 14 2017, 6:40 AM

Mar 9 2017

ggreif committed rGHC9ff05742de1e: Comments only [ci skip] (authored by ggreif).
Comments only [ci skip]
Mar 9 2017, 3:40 AM

Mar 7 2017

ggreif committed rGHC99fe579d8f95: Typos in changelog and comments (authored by ggreif).
Typos in changelog and comments
Mar 7 2017, 1:36 AM

Mar 6 2017

ggreif committed rGHC749740f9c3cb: Typos in comments and manual (authored by ggreif).
Typos in comments and manual
Mar 6 2017, 9:57 AM