facundominguez (Facundo Domínguez)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 28 2014, 8:50 AM (269 w, 3 h)

Recent Activity

Feb 19 2018

facundominguez committed rGHC5b63240f9822: Increase the amount of parallelism in circleci. (authored by facundominguez).
Increase the amount of parallelism in circleci.
Feb 19 2018, 6:43 AM
facundominguez closed D4415: Increase the amount of parallelism in circleci..
Feb 19 2018, 6:43 AM
facundominguez added a comment to D4415: Increase the amount of parallelism in circleci..

... However, doesn't this mean that we will oversubscribe users running CircleCI on their own forks that lack the higher resources limits that we enjoy?

Feb 19 2018, 6:40 AM

Feb 16 2018

facundominguez created D4415: Increase the amount of parallelism in circleci..
Feb 16 2018, 9:55 AM

Nov 9 2017

facundominguez added a comment to D4172: Staticpointers: * Document requirement to use the same binaries. * Fix some code comments..

To be conservative it would really need to be the same binary.

Nov 9 2017, 4:03 PM
facundominguez abandoned D3003: Expose local variables in brackets to reify..

I didn't need this anymore after having my use case, inline-java, use GHC plugins.

Nov 9 2017, 1:54 PM
facundominguez abandoned D2519: Fix the local type environment of module finalizers..

Didn't need this in the end since the use case I had, inline-java, moved to using ghc plugins.

Nov 9 2017, 9:52 AM
facundominguez created D4172: Staticpointers: * Document requirement to use the same binaries. * Fix some code comments..
Nov 9 2017, 6:48 AM

Sep 13 2017

facundominguez added inline comments to D3933: Explain that staticPtrKeys might not yield the keys of dead static pointers..
Sep 13 2017, 11:50 AM
facundominguez added inline comments to D3933: Explain that staticPtrKeys might not yield the keys of dead static pointers..
Sep 13 2017, 11:39 AM

Sep 11 2017

facundominguez added a comment to D3931: Check if -XStaticPointers is enabled when renaming static expressions.

Where was the previous check, the one that TH bypassed?

Sep 11 2017, 6:39 AM

Sep 8 2017

facundominguez created D3933: Explain that staticPtrKeys might not yield the keys of dead static pointers..
Sep 8 2017, 5:07 PM
facundominguez accepted D3931: Check if -XStaticPointers is enabled when renaming static expressions.

LGTM

Sep 8 2017, 4:19 PM

Aug 21 2017

facundominguez abandoned D3843: Make bindings containing static forms exported..

Dropping the patch as recommended in https://ghc.haskell.org/trac/ghc/ticket/14090#comment:15

Aug 21 2017, 7:19 AM

Aug 18 2017

facundominguez updated the diff for D3821: Implement TH addCorePlugin..
  • Mention addCorePlugin in the user guide.
Aug 18 2017, 11:19 AM
facundominguez added inline comments to D3821: Implement TH addCorePlugin..
Aug 18 2017, 9:20 AM

Aug 14 2017

facundominguez added a comment to D3843: Make bindings containing static forms exported..

There seems to be more than one place where the bindings are dropped. simpleOptPgm is one such place, but later on the simplifier also does drop the bindings prematurely.

Aug 14 2017, 12:55 PM
facundominguez updated the diff for D3843: Make bindings containing static forms exported..
  • Be explicit on the non-traversed CoreExpr constructors.
Aug 14 2017, 11:45 AM

Aug 12 2017

facundominguez updated the diff for D3843: Make bindings containing static forms exported..
  • Improve comments.
Aug 12 2017, 2:34 PM
facundominguez updated the diff for D3843: Make bindings containing static forms exported..
  • Improve comments.
Aug 12 2017, 2:33 PM
facundominguez created D3843: Make bindings containing static forms exported..
Aug 12 2017, 2:20 PM

Aug 4 2017

facundominguez created D3821: Implement TH addCorePlugin..
Aug 4 2017, 2:59 PM

Jun 5 2017

facundominguez abandoned D3610: Wrap quasiquotes in a recursive let expression..

Besides the problem with parsing of patterns, this patch wouldn't work for splices within brackets. We'd need a better design.

Jun 5 2017, 11:33 AM

May 24 2017

facundominguez added inline comments to D3610: Wrap quasiquotes in a recursive let expression..
May 24 2017, 6:51 PM
facundominguez created D3610: Wrap quasiquotes in a recursive let expression..
May 24 2017, 4:49 PM

Mar 7 2017

facundominguez added inline comments to D3280: Allow compilation of C/C++/ObjC/ObjC++ files with module from TH.
Mar 7 2017, 11:03 AM

Mar 6 2017

facundominguez added a comment to D3280: Allow compilation of C/C++/ObjC/ObjC++ files with module from TH.

https://ghc.haskell.org/trac/ghc/ticket/13366 talks about controlling compilation flags, but it doesn't look like this patch is addressing that. Perhaps update the ticket to explain the plan?

Mar 6 2017, 8:26 AM

Feb 10 2017

facundominguez added a comment to rGHCb9bebd8cedcc: Implement addCStub in template-haskell..

@nomeata please, could you remove the branches fd/fix-travis and fd/fix-travis2? Some server hook is preventing me from doing so.

Feb 10 2017, 2:42 PM
facundominguez committed rGHCe79ef75d9a22: Relax test TH_addCStub2 so it succeeds on travis. (authored by facundominguez).
Relax test TH_addCStub2 so it succeeds on travis.
Feb 10 2017, 2:40 PM
facundominguez closed D3124: Relax test TH_addCStub2 so it succeeds on travis. by committing rGHCe79ef75d9a22: Relax test TH_addCStub2 so it succeeds on travis..
Feb 10 2017, 2:40 PM
facundominguez updated the diff for D3124: Relax test TH_addCStub2 so it succeeds on travis..

Relaxed even more the test so it works with clang.

Feb 10 2017, 9:44 AM
facundominguez added a comment to D3124: Relax test TH_addCStub2 so it succeeds on travis..

Travis uses an older gcc version which doesn't print the offending line in the error message. https://phabricator.haskell.org/rGHCb9bebd8cedcc

=====> TH_addCStub1(normal) 4122 of 5714 [0, 0, 0]--- /tmp/ghctest-u7xmp5/test   spaces/./th/TH_addCStub2.run/TH_addCStub2.stderr.normalised	2017-02-09 17:41:03.087318367 +0000
+++ /tmp/ghctest-u7xmp5/test   spaces/./th/TH_addCStub2.run/TH_addCStub2.comp.stderr.normalised	2017-02-09 17:41:03.087318367 +0000
@@ -1,6 +1,4 @@
Feb 10 2017, 8:13 AM
facundominguez added a comment to D3124: Relax test TH_addCStub2 so it succeeds on travis..

Checking the stderr of the compiler and returning the right exit code is non-trivial in the current test framework. Couldn't tell either if it will work in all platforms. Travis build passes with a former version of this fix and I hope it will do it again with this change. The ongoing build is here https://travis-ci.org/ghc/ghc/builds/200324037

Feb 10 2017, 6:29 AM
facundominguez created D3124: Relax test TH_addCStub2 so it succeeds on travis..
Feb 10 2017, 6:21 AM
facundominguez committed rGHCdb92ab81e8a8: Relax test TH_addCStub2 so it succeeds on travis. (authored by facundominguez).
Relax test TH_addCStub2 so it succeeds on travis.
Feb 10 2017, 6:18 AM

Feb 9 2017

facundominguez committed rGHC969bc7be4a26: Relax test TH_addCStub2 so it succeeds on travis. (authored by facundominguez).
Relax test TH_addCStub2 so it succeeds on travis.
Feb 9 2017, 8:23 PM
facundominguez added inline comments to rGHCb9bebd8cedcc: Implement addCStub in template-haskell..
Feb 9 2017, 1:09 PM
facundominguez added a comment to rGHCb9bebd8cedcc: Implement addCStub in template-haskell..
Feb 9 2017, 12:54 PM
facundominguez committed rGHCb9bebd8cedcc: Implement addCStub in template-haskell. (authored by facundominguez).
Implement addCStub in template-haskell.
Feb 9 2017, 5:12 AM
facundominguez closed D3106: Implement addCStub in template-haskell. by committing rGHCb9bebd8cedcc: Implement addCStub in template-haskell..
Feb 9 2017, 5:12 AM

Feb 8 2017

facundominguez added inline comments to D3106: Implement addCStub in template-haskell..
Feb 8 2017, 1:48 PM
facundominguez added inline comments to D3106: Implement addCStub in template-haskell..
Feb 8 2017, 12:53 PM
facundominguez updated the diff for D3106: Implement addCStub in template-haskell..

Addressed Ben's comments.

Feb 8 2017, 12:45 PM
facundominguez updated the diff for D3106: Implement addCStub in template-haskell..

Did minor touch ups to tests.

Feb 8 2017, 8:22 AM
facundominguez updated the diff for D3106: Implement addCStub in template-haskell..

Reverted unintended change in GHCi.Message.

Feb 8 2017, 6:37 AM
facundominguez added inline comments to D3106: Implement addCStub in template-haskell..
Feb 8 2017, 6:28 AM
facundominguez updated the Trac tickets for D3106: Implement addCStub in template-haskell..
Feb 8 2017, 6:23 AM
facundominguez created D3106: Implement addCStub in template-haskell..
Feb 8 2017, 6:21 AM

Jan 26 2017

facundominguez added a comment to D3003: Expose local variables in brackets to reify..

Thanks for taking a look. We can manage without this. Let's wait until we can discuss it then.

Jan 26 2017, 7:15 AM

Jan 25 2017

facundominguez added a comment to D3003: Expose local variables in brackets to reify..

I was aiming towards merging this before the freeze deadline for ghc-8.2.1. We might still be able to address the open issues and new comments on time, provided we get some feedback and we find no major blockers. That said, I understand everybody might be just too busy for this plan to work.

Jan 25 2017, 2:46 PM

Jan 24 2017

facundominguez updated the diff for D3003: Expose local variables in brackets to reify..

Remove uses of unsafeCoerce by changing the ModFinalizers type.

Jan 24 2017, 6:39 AM

Jan 23 2017

facundominguez added inline comments to D3003: Expose local variables in brackets to reify..
Jan 23 2017, 4:07 PM
facundominguez added inline comments to D3003: Expose local variables in brackets to reify..
Jan 23 2017, 1:17 PM
facundominguez added a comment to D3003: Expose local variables in brackets to reify..

This patch addresses the intended issue but has the problems discussed in Trac #12778.

Jan 23 2017, 11:30 AM
facundominguez updated D3003: Expose local variables in brackets to reify..
Jan 23 2017, 11:10 AM
facundominguez retitled D3003: Expose local variables in brackets to reify. from to Expose local variables in brackets to reify..
Jan 23 2017, 11:08 AM

Jan 13 2017

facundominguez committed rGHC13a85211040f: Desugar static forms to makeStatic calls. (authored by facundominguez).
Desugar static forms to makeStatic calls.
Jan 13 2017, 2:37 PM
facundominguez closed D2930: Desugar static forms to makeStatic calls. by committing rGHC13a85211040f: Desugar static forms to makeStatic calls..
Jan 13 2017, 2:37 PM

Jan 11 2017

facundominguez updated the diff for D2930: Desugar static forms to makeStatic calls..

Moved StaticPtrInfo construction to StaticPtrTable.hs.

Jan 11 2017, 12:09 PM
facundominguez added inline comments to D2930: Desugar static forms to makeStatic calls..
Jan 11 2017, 8:47 AM
facundominguez added a comment to D2930: Desugar static forms to makeStatic calls..

bgamari, I agree with you. The point would be that the two open discussions do not look like major concerns, and if they were the patch surely wouldn't be accepted.

Jan 11 2017, 5:29 AM

Jan 10 2017

facundominguez added a comment to D2930: Desugar static forms to makeStatic calls..

I'm thinking of landing this last thing on Friday, given that it is accepted. Can address requests after that, but let me know if I should address any more concerns in advance.

Jan 10 2017, 6:02 PM

Jan 9 2017

facundominguez updated the diff for D2930: Desugar static forms to makeStatic calls..

Address more comments.

Jan 9 2017, 12:32 PM
facundominguez added inline comments to D2930: Desugar static forms to makeStatic calls..
Jan 9 2017, 11:34 AM
facundominguez updated the diff for D2930: Desugar static forms to makeStatic calls..

Addressed comments by RyanGlScott and some of simonpj's.

Jan 9 2017, 11:32 AM
facundominguez added inline comments to D2930: Desugar static forms to makeStatic calls..
Jan 9 2017, 11:26 AM
facundominguez added inline comments to D2930: Desugar static forms to makeStatic calls..
Jan 9 2017, 8:26 AM

Jan 6 2017

facundominguez updated the diff for D2886: Have addModFinalizer expose the local type environment..
Jan 6 2017, 12:33 PM
facundominguez committed rGHCc1ed9557ad4e: Have addModFinalizer expose the local type environment. (authored by facundominguez).
Have addModFinalizer expose the local type environment.
Jan 6 2017, 12:28 PM
facundominguez committed rGHCc5452cc1a67e: Revert "Have addModFinalizer expose the local type environment." (authored by facundominguez).
Revert "Have addModFinalizer expose the local type environment."
Jan 6 2017, 12:13 PM
facundominguez added a reverting change for rGHCe5d1ed9c8910: Have addModFinalizer expose the local type environment.: rGHCc5452cc1a67e: Revert "Have addModFinalizer expose the local type environment.".
Jan 6 2017, 12:13 PM
facundominguez added a comment to rGHCe5d1ed9c8910: Have addModFinalizer expose the local type environment..

hm, some misuse of arc land, I suppose.

Jan 6 2017, 12:03 PM
facundominguez committed rGHCe5d1ed9c8910: Have addModFinalizer expose the local type environment. (authored by facundominguez).
Have addModFinalizer expose the local type environment.
Jan 6 2017, 11:31 AM
facundominguez closed D2886: Have addModFinalizer expose the local type environment. by committing rGHCe5d1ed9c8910: Have addModFinalizer expose the local type environment..
Jan 6 2017, 11:30 AM
facundominguez added a comment to D2930: Desugar static forms to makeStatic calls..

I hope the trac ticket provides the necessary context to motivate the patch. But let me know if the commit message needs to be more descriptive.

Jan 6 2017, 10:17 AM
facundominguez abandoned D2720: Have the core linter accept unpacked StaticPtr's..

This approach is favored https://phabricator.haskell.org/D2930 over the current patch.

Jan 6 2017, 10:17 AM
facundominguez retitled D2930: Desugar static forms to makeStatic calls. from to Desugar static forms to makeStatic calls..
Jan 6 2017, 9:56 AM

Dec 20 2016

facundominguez updated D2886: Have addModFinalizer expose the local type environment..
Dec 20 2016, 11:42 AM
facundominguez updated D2886: Have addModFinalizer expose the local type environment..
Dec 20 2016, 11:42 AM
facundominguez updated the diff for D2886: Have addModFinalizer expose the local type environment..

Address review comments.

Dec 20 2016, 11:29 AM
facundominguez updated the diff for D2886: Have addModFinalizer expose the local type environment..

Fixed up test after rebasing master.

Dec 20 2016, 8:28 AM
facundominguez retitled D2886: Have addModFinalizer expose the local type environment. from to fixup! Have addModFinalizer expose the local type environment..
Dec 20 2016, 5:49 AM

Nov 19 2016

facundominguez added inline comments to D2504: [RFC] Add support for StaticPointers in GHCi.
Nov 19 2016, 9:26 PM

Nov 16 2016

facundominguez added a comment to D2720: Have the core linter accept unpacked StaticPtr's..

I still don't see a clear explanation in any of the notes describing why both StaticPtr and StaticPtrInternal are necessary. This really ought to be mentioned in Note [The grand plan for static pointers].

Nov 16 2016, 9:32 PM
facundominguez updated the diff for D2659: Have reify work for local variables with functional dependencies..

Rebased master.

Nov 16 2016, 9:15 PM
facundominguez updated the diff for D2659: Have reify work for local variables with functional dependencies..

Address review comments.

Nov 16 2016, 9:10 PM
facundominguez added a comment to D2659: Have reify work for local variables with functional dependencies..

Ben, please merge at your convenience. If I don't address the comments on time, I will push them to master.

Nov 16 2016, 12:12 PM
facundominguez updated the Trac tickets for D2519: Fix the local type environment of module finalizers..
Nov 16 2016, 11:50 AM
facundominguez updated the diff for D2720: Have the core linter accept unpacked StaticPtr's..

Improve comments.

Nov 16 2016, 6:07 AM
facundominguez added inline comments to D2720: Have the core linter accept unpacked StaticPtr's..
Nov 16 2016, 5:57 AM
facundominguez updated D2720: Have the core linter accept unpacked StaticPtr's..
Nov 16 2016, 5:55 AM
facundominguez retitled D2720: Have the core linter accept unpacked StaticPtr's. from to Have the core linter accept unpacked StaticPtr's..
Nov 16 2016, 5:41 AM

Nov 15 2016

facundominguez committed rGHC31d5b6efa249: fixup! Stop the simplifier from removing StaticPtr binds. (authored by facundominguez).
fixup! Stop the simplifier from removing StaticPtr binds.
Nov 15 2016, 6:41 PM
facundominguez abandoned D2709: Prevent StaticPtr fields from being unpacked..

I hate withdrawing an accepted PR, but I earned more insight today that could make disabling unpacking of StaticPtrs unnecessary. See the discussion on the related ticket for details.

Nov 15 2016, 1:06 PM
facundominguez added a comment to D2659: Have reify work for local variables with functional dependencies..

Note taken. I'll address comments after @simonpj feedback.

Nov 15 2016, 12:33 PM
facundominguez updated the diff for D2709: Prevent StaticPtr fields from being unpacked..

Further improve comments.

Nov 15 2016, 4:52 AM
facundominguez added inline comments to D2709: Prevent StaticPtr fields from being unpacked..
Nov 15 2016, 4:41 AM
facundominguez updated the diff for D2709: Prevent StaticPtr fields from being unpacked..

Improve comments.

Nov 15 2016, 4:30 AM

Nov 14 2016

facundominguez retitled D2709: Prevent StaticPtr fields from being unpacked. from to Prevent StaticPtr fields from being unpacked..
Nov 14 2016, 6:48 PM

Nov 1 2016

facundominguez closed D2655: Have static pointers work with -fno-full-lazyness..

This was landed as commit 0b70ec0c3b72a7f87776743e64b47b65ef0ca4a5 to master.

Nov 1 2016, 4:28 PM