enolan (Echo Nolan)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 27 2015, 6:28 PM (220 w, 4 d)

Recent Activity

Sep 22 2017

enolan added a comment to D4001: Include original process name in worker thread name (#14153).

How long do the Windows CI builds usually take? It's almost 48 hours old and AFAICT hasn't started yet.

Sep 22 2017, 5:35 PM

Sep 21 2017

enolan added inline comments to D4001: Include original process name in worker thread name (#14153).
Sep 21 2017, 11:52 AM

Sep 20 2017

enolan updated the diff for D4001: Include original process name in worker thread name (#14153).

Fix platform specific issue: use VLA over alloca()

Sep 20 2017, 8:22 PM
enolan updated the diff for D4001: Include original process name in worker thread name (#14153).

Fix some OS specific #ifdef stuff.

Sep 20 2017, 5:57 PM
Herald added a reviewer for D4001: Include original process name in worker thread name (#14153): austin.
Sep 20 2017, 5:27 PM

May 21 2016

enolan added a comment to D2252: Fix failing T12010.

I'm confused, does the test runner not always cd into the directory with the .T file?

May 21 2016, 1:04 PM

May 17 2016

enolan updated the diff for D2170: Use the correct return type for Windows' send()/recv() (Fix #12010).

Comments

May 17 2016, 3:03 PM
enolan updated the diff for D2170: Use the correct return type for Windows' send()/recv() (Fix #12010).

Review fixes

May 17 2016, 2:59 PM

May 15 2016

enolan added a comment to D2170: Use the correct return type for Windows' send()/recv() (Fix #12010).

I wrote a test that doesn't use network. It uses hsc2hs, and needs to link C code, so I wrote a Makefile. Tests using run_command don't have access to the flags from the way and this only happens in the threaded RTS - it's in blocking*RawBufferPtr. So I modified run_command to pass two new environment variables down: WAY_FLAGS and WAY_RTS_FLAGS. Here's what I have now: https://github.com/enolan/ghc/commit/4184264931fe9676c0450abed757e02ff202beb2. The bash -c is needed because some commands have ;s or &&s in them. It still breaks with commands that have double quotes in them though. I can figure out the shell escaping but I have the feeling there's an easier way to deal with this problem.

May 15 2016, 10:51 AM

May 13 2016

enolan added inline comments to D2170: Use the correct return type for Windows' send()/recv() (Fix #12010).
May 13 2016, 11:29 PM

May 8 2016

enolan added inline comments to D2170: Use the correct return type for Windows' send()/recv() (Fix #12010).
May 8 2016, 12:25 PM
enolan added a comment to D2170: Use the correct return type for Windows' send()/recv() (Fix #12010).
In D2170#63001, @thomie wrote:

@enolan: nice find.

I have some questions below, resulting mostly from my own ignorance on this matter (calling conventions / windows).

  • Commit 7f3e27157d1f812f3c98179458242f3d7c97bee8 changed the return type for safe_recv_off/c_safe_recv from CInt to CSsize. Now you're changing it back. Was the bug introduced in that commit? Could you check if that commit maybe introduced other bugs as well?
May 8 2016, 12:19 PM

May 6 2016

enolan added inline comments to D2170: Use the correct return type for Windows' send()/recv() (Fix #12010).
May 6 2016, 11:14 AM

May 4 2016

enolan retitled D2170: Use the correct return type for Windows' send()/recv() (Fix #12010) from to Use the correct return type for Windows' send()/recv() (Fix #12010).
May 4 2016, 6:10 AM