dolio (Dan Doel)
User

User Details

User Since
Oct 7 2014, 12:13 AM (270 w, 5 d)

Recent Activity

Dec 20 2015

dolio updated the diff for D1572: Modify IsString String instance (fixes #10814).
  • Add a test case for the modified IsString instance
  • Add a note on the new IsString instance
Dec 20 2015, 12:21 AM

Dec 19 2015

dolio updated the diff for D1605: Implement phase 1 of expanded Floating.
  • Add @since for floating point expansion.
Dec 19 2015, 4:24 PM

Dec 18 2015

dolio added a comment to D1605: Implement phase 1 of expanded Floating.

Windows fixes are now in.

Dec 18 2015, 9:13 PM
dolio updated the diff for D1605: Implement phase 1 of expanded Floating.
  • Fix haddock formatting for log1p/mexp
  • Fix building Floating expansion on Windows
Dec 18 2015, 9:11 PM

Dec 17 2015

dolio added a comment to D1572: Modify IsString String instance (fixes #10814).

I don't know what a "note" is.

Dec 17 2015, 2:18 PM
dolio added a comment to D1605: Implement phase 1 of expanded Floating.

So, I've added documentation for the new methods. Unfortunately, I can't see what it looks like, because there appears to be a haddock bug in head that makes classes not have lists of the methods in them, and thus the documentation for those methods doesn't show up.

Dec 17 2015, 1:37 PM
dolio updated the diff for D1605: Implement phase 1 of expanded Floating.
  • Document new floating point functions.
Dec 17 2015, 1:32 PM

Dec 12 2015

dolio added a comment to D1605: Implement phase 1 of expanded Floating.

I don't. Making sure things built on Windows was also supposed to be someone else's job. I can't verify it myself.

Dec 12 2015, 8:30 PM
dolio retitled D1605: Implement phase 1 of expanded Floating from Implement most of phase 1 of expanded Floating to Implement phase 1 of expanded Floating.
Dec 12 2015, 6:09 PM
dolio added a comment to D1605: Implement phase 1 of expanded Floating.

I've added Float and Double implementations based on libm foreign imports.

Dec 12 2015, 6:09 PM
dolio updated the diff for D1605: Implement phase 1 of expanded Floating.
  • Implement libm-based Floating ops
Dec 12 2015, 6:05 PM
dolio added a comment to D1605: Implement phase 1 of expanded Floating.

Design is here, I'm just implementing it:

Dec 12 2015, 2:32 PM
dolio updated the diff for D1605: Implement phase 1 of expanded Floating.
  • Document Floating expansion in changelog
Dec 12 2015, 2:29 PM
dolio added a reviewer for D1605: Implement phase 1 of expanded Floating: Core Libraries Committee.
Dec 12 2015, 2:23 PM
dolio retitled D1605: Implement phase 1 of expanded Floating from to Implement most of phase 1 of expanded Floating.
Dec 12 2015, 2:23 PM

Dec 5 2015

dolio added a comment to D1572: Modify IsString String instance (fixes #10814).

10814 is the trac task. I thought I put that into arc, but it doesn't appear to show up anywhere here (except in the commit message).

Dec 5 2015, 11:23 AM

Dec 4 2015

dolio updated the diff for D1572: Modify IsString String instance (fixes #10814).
  • Document IsString [Char] change in changelog.md
Dec 4 2015, 6:13 PM
dolio added a reviewer for D1572: Modify IsString String instance (fixes #10814): Core Libraries Committee.
Dec 4 2015, 5:38 PM
dolio retitled D1572: Modify IsString String instance (fixes #10814) from to Modify IsString String instance (fixes #10814).
Dec 4 2015, 5:38 PM

Nov 9 2015

dolio accepted D1450: Improve documentation of Data.List.lines:.

Adding CLC acceptance (hopefully).

Nov 9 2015, 1:02 AM

Aug 31 2015

dolio added a comment to D1185: Implement TypeSignatureSections.

Are we sure this would always happen? What if we end up mapping the signature section? Or do other strange things with it? In any case, this should be tested.

Aug 31 2015, 2:09 AM

Aug 29 2015

dolio added a comment to D1185: Implement TypeSignatureSections.

I think I agree with Richard. I can't think of a reason to use (unbound) variables other than for them to work as wildcards. But we have wildcards. So perhaps the current behavior is okay, or should be an error, rather than what I suggested.

Aug 29 2015, 2:14 PM

Aug 28 2015

dolio added a comment to D1185: Implement TypeSignatureSections.

The examples involving type variables are odd. They should probably be generalized as part of the type ascribed to the function, and not as the argument. I.E. right now we have:

Aug 28 2015, 11:15 AM

Jun 10 2015

dolio added a comment to D924: Drop custom mapM impl for [] & set mapM_ = traverse_.

The only thing that makes sense to me is that it doesn't make the decision on whether to inline (<*>) until ap is inlined, at which point it's too large. I'm not sure I knew it worked that way.

Jun 10 2015, 9:22 AM

Jun 8 2015

dolio added a comment to D924: Drop custom mapM impl for [] & set mapM_ = traverse_.

Actually, now that I think about it, I think the allocation difference was that I implemented (<*>) for strict StateT instead of lazy. But it doesn't matter, because just inlining (<*>) = ap achieves parity.

Jun 8 2015, 12:10 PM

Jun 6 2015

dolio added a comment to D924: Drop custom mapM impl for [] & set mapM_ = traverse_.

Okay. After further investigation, I have some results to report.

Jun 6 2015, 8:46 PM
dolio added a comment to D924: Drop custom mapM impl for [] & set mapM_ = traverse_.

Now I'm not sure if my test case is demonstrating the same thing, because moving the mapM/traverse call out to a separate, noinline function in cryptarithm2 has no effect on the results.

Jun 6 2015, 4:45 PM
dolio added a comment to D924: Drop custom mapM impl for [] & set mapM_ = traverse_.

Here's a simplified test case that may be relevant:

Jun 6 2015, 4:15 PM

Oct 18 2014

dolio accepted D336: Add new `Data.Bifunctor` module (re #9682).

Just wanted to make sure we considered the discrepancy.

Oct 18 2014, 5:13 PM

Oct 15 2014

dolio requested changes to D336: Add new `Data.Bifunctor` module (re #9682).
Oct 15 2014, 6:46 PM
dolio added a comment to D336: Add new `Data.Bifunctor` module (re #9682).

bimap id actually doesn't agree with fmap on tuples here.

Oct 15 2014, 6:35 PM