- User Since
- Sep 5 2014, 5:38 PM (197 w, 4 d)
Mon, Jun 18
Yes, that. But do you really need such fancy logic in the test? Wouldn't something much simpler (like a type error) do the trick? Then you wouldn't have to deal with -ddump-parsed-ast.
Can you add a test case?
Although it's unfortunate to change benchmark source in general, I think it's pretty clearly justified this time.
Sun, Jun 17
Mon, Jun 11
- Add output
Thu, Jun 7
I believe this change needs a formal libraries list proposal.
Wed, Jun 6
Yeah, that sounds reasonable. Not ideal, perhaps, but there's no obvious and easy way to make GHCi fail this without really reworking the test.
LGTM, if it validates.
- Add test
You state that this improves error messages, but you don't explain what happened before, what was wrong with it, what you're doing now, and what makes that better. Since this isn't entirely obvious, I suggest opening a Trac ticket.
- Pull out zapper; improve panic message
Tue, Jun 5
@simonpj, I didn't really want to use collectArgsTicks because it seems a bit expensive for the job. So for the moment I've written a function to just drop the arguments and ticks I need to make the comparison. Your other refactor request was definitely a major improvement. Thanks.
Remove likely-unnecessary bang pattern
I've opened D4796 to fix the problem in the simplifier.
Mon, Jun 4
Sat, Jun 2
Fri, Jun 1
Thu, May 31
Tue, May 29
Mon, May 28
Sun, May 27
Something isn't working. Also, it would be nice to have a test demonstrating that this sometimes does something useful.
Fri, May 25
Mon, May 21
- Fix some more
May 15 2018
Bleh! This part may take more community work. But I would leave it hidden
till we figure that out. The PR to process sounds like a good idea
That's my suggestion for now, yes.
I mostly agree with this. However, I think there are some modules that simply shouldn't be exposed through Cabal at all, and revealing their Haddocks seems like a step in the wrong direction sending the message that some end users might want to use them. A notable example is GHC.IO.IOMode, whose entire contents are exported by System.IO. I'm pretty strongly opposed to unhiding this module, and generally in favor of removing it from the Exposed-modules section.
The proposal was rejected by the committee, so this will not be merged.
May 13 2018
There are several things that don't fuse here. I'm not sure why as yet, but the unfoldings seem to get optimized too much. I think we can address that separately.
May 11 2018
I don't see how perf.haskell.org will help you here. It just counts
instructions, so it's not going to tell you anything about the cache
effects you're after.
May 9 2018
May 8 2018
- Update notes
- Adjust test output
@bgamari, is it better now? Is the remark about threads at the end correct?
- Respond to Ben's comments
Remove unused imports
May 7 2018
May 4 2018
May 3 2018
If the performance difference is negligible compared to additions then there's no point. But remember that we don't need to use the same functions to define the instances for Float and Double. OTOH, I really wish these instances didn't even exist, so I shouldn't care of they're fast!
May 2 2018
Something else to try: do different things depending on the magnitude of the arguments. If additions are substantially faster, then we'd prefer to use them when they don't lose too much precision. Can we get a conservative estimate of that for cheap? I conjecture that we can, especially if the step is an exact integer.
Oh blast.... This thing skips CI, and I just changed code. Hrmmmmm....
- Change arity info for absentError and address Simon's other comments.
May 1 2018
Apr 30 2018
Good enough for me!
Apr 29 2018
Apr 27 2018
It looks like the remaining test suite failures are unrelated.
Apr 26 2018
- Wall noise
- Add import of GHC.Num. This is okay because we already depend on GHC.List, which depends on GHC.Num.
Just a couple little things.
- Add instances for WrappedArrow
- Use the Monad and MonadPlus instances
- Missed a test
@RyanGlScott, I think I've handled your concerns.
- Document WrappedMonad
- Fix changelog
- Take care of <* as well