dfeuer (David Feuer)Administrator
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Sep 5 2014, 5:38 PM (180 w, 1 d)
Roles
Administrator
Availability
Available

Recent Activity

Fri, Feb 16

dfeuer committed rGHCd5ac5820111b: Fix #14811 by wiring in $tcUnit# (authored by RyanGlScott).
Fix #14811 by wiring in $tcUnit#
Fri, Feb 16, 12:53 PM
dfeuer closed D4414: Fix #14811 by wiring in $tcUnit#.
Fri, Feb 16, 12:53 PM
dfeuer added a comment to D4412: Add regression test for #12790.

I'm a bit nervous about the known fragility of the test. I'm a bit more concerned about the fact that this depends on an ever-shifting external library—what does this test actually test?

Fri, Feb 16, 12:45 PM

Thu, Feb 15

dfeuer accepted D4414: Fix #14811 by wiring in $tcUnit#.

If it passes validation, LGTM.

Thu, Feb 15, 11:21 AM
dfeuer requested changes to D4414: Fix #14811 by wiring in $tcUnit#.
Thu, Feb 15, 11:04 AM
dfeuer committed rGHC8529fbba309c: Get eqTypeRep to inline (authored by dfeuer).
Get eqTypeRep to inline
Thu, Feb 15, 2:50 AM
dfeuer closed D4405: Inline eqTypeRep.
Thu, Feb 15, 2:50 AM

Wed, Feb 14

dfeuer added a comment to D4403: Make accumArray and accum stricter.

Hmm, CI is now failing because of:

haddock: internal error: Unable to commit 1048576 bytes of memory
    (GHC version 8.5.20180213 for x86_64_unknown_linux)
    Please report this as a GHC bug:  http://www.haskell.org/ghc/reportabug
make[1]: *** [compiler/stage2/doc/html/ghc/ghc.haddock] Aborted
Wed, Feb 14, 3:01 AM

Tue, Feb 13

dfeuer created D4407: Fix test suite output following $! type change.
Tue, Feb 13, 3:19 PM
dfeuer updated the diff for D4403: Make accumArray and accum stricter.

Fix parse error

Tue, Feb 13, 2:04 PM
dfeuer added a comment to D4382: Make ($!) representation-polymorphic.

Blast. I'll fix them tomorrow.

Tue, Feb 13, 1:04 AM

Mon, Feb 12

dfeuer committed rGHCc9a88db3ac4f: Make ($!) representation-polymorphic (authored by dfeuer).
Make ($!) representation-polymorphic
Mon, Feb 12, 7:03 PM
dfeuer closed D4382: Make ($!) representation-polymorphic.
Mon, Feb 12, 7:03 PM
dfeuer updated the diff for D4405: Inline eqTypeRep.

Use INLINABLE instead of INLINE, as mpickering requests. Doing both
that and the eqTypeRep/sameTypeRep split seem to get GHC to produce
a nice small unfolding for eqTypeRep. Doing either alone doesn't cut it.

Mon, Feb 12, 2:57 PM

Sun, Feb 11

dfeuer added a comment to D4405: Inline eqTypeRep.

In principle, we should probably be able to do slightly better by using 0# and 1# instead of True and False in the result of sameTypeRep. But I don't know if it's worth the mess.

Sun, Feb 11, 3:07 PM
dfeuer created D4405: Inline eqTypeRep.
Sun, Feb 11, 12:54 PM

Fri, Feb 9

dfeuer created D4403: Make accumArray and accum stricter.
Fri, Feb 9, 3:14 PM

Thu, Feb 8

dfeuer updated the diff for D4382: Make ($!) representation-polymorphic.

Note in change logs

Thu, Feb 8, 4:49 AM

Mon, Feb 5

dfeuer created D4382: Make ($!) representation-polymorphic.
Mon, Feb 5, 2:24 PM
dfeuer added inline comments to D4370: Slight refactor of stock deriving internals.
Mon, Feb 5, 11:06 AM
dfeuer committed rGHCd987f71aa320: Improve unboxed sum documentation (authored by dfeuer).
Improve unboxed sum documentation
Mon, Feb 5, 8:47 AM
dfeuer closed D4379: Improve unboxed sum documentation.
Mon, Feb 5, 8:47 AM
dfeuer added inline comments to D4370: Slight refactor of stock deriving internals.
Mon, Feb 5, 8:26 AM
dfeuer created D4379: Improve unboxed sum documentation.
Mon, Feb 5, 1:53 AM

Sun, Feb 4

dfeuer created D4375: Document missing dataToTag# . tagToEnum# rule.
Sun, Feb 4, 1:53 PM

Wed, Jan 31

dfeuer added a comment to D4360: circleci: Use Docker images from ghcci.

Where are the new things? Some other repo?

Wed, Jan 31, 11:21 PM

Tue, Jan 30

dfeuer added a comment to D4320: Fix fannkuch-redux for GHC<=8.2.

Could you rebase this please?

Tue, Jan 30, 3:15 AM

Sat, Jan 27

dfeuer added a comment to D4340: Upgrade containers.

@bgamari, this is ready to go.

Sat, Jan 27, 8:01 AM

Fri, Jan 26

dfeuer updated the diff for D4340: Upgrade containers.

Rebase against last commit that builds

Fri, Jan 26, 9:19 PM
dfeuer updated the diff for D4340: Upgrade containers.

Update test results; rebase

Fri, Jan 26, 7:52 PM
dfeuer added a comment to D4340: Upgrade containers.

I'll update today.

Fri, Jan 26, 10:04 AM

Tue, Jan 23

dfeuer accepted D4326: Sort valid substitutions for typed holes by "relevance".

Ah. I didn't even know there'd been churn; I just wanted to make sure there wouldn't be.

Tue, Jan 23, 11:52 AM
dfeuer added a comment to D4326: Sort valid substitutions for typed holes by "relevance".

One question: how do you sort the results that are not comparable? Is that strong enough to avoid test case churn?

Tue, Jan 23, 9:38 AM

Mon, Jan 22

dfeuer added a comment to D4340: Upgrade containers.

Two of the backpack test failures are from the containers version changing. I have no clue what the other one is about. Please advise.

Mon, Jan 22, 11:14 PM
dfeuer created D4340: Upgrade containers.
Mon, Jan 22, 8:03 PM
dfeuer added a comment to D4320: Fix fannkuch-redux for GHC<=8.2.

I'll give it a go.

Mon, Jan 22, 2:18 PM
dfeuer accepted D4304: base: Refactor Show ErrorCall instance into proper ShowS style.

I doubt this matters in practice, but it's best to set a good example in base.

Mon, Jan 22, 2:26 AM
dfeuer requested changes to D4326: Sort valid substitutions for typed holes by "relevance".
Mon, Jan 22, 1:59 AM

Sun, Jan 21

dfeuer planned changes to D4318: Derive more Data methods.

This needs further consideration to figure out to what extent (if any) it's a good idea.

Sun, Jan 21, 10:33 PM
dfeuer accepted D4320: Fix fannkuch-redux for GHC<=8.2.
Sun, Jan 21, 10:33 PM

Jan 17 2018

dfeuer added a comment to D4318: Derive more Data methods.

I'm going to work on this more today. Both trying to track down the numbers
Simon wants and trying to work out which are worth deriving. It's hard to
use hand-written examples with things large enough to measure.

Jan 17 2018, 1:11 PM

Jan 16 2018

dfeuer added a comment to D4318: Derive more Data methods.

I mean probably shouldn't derive gmapQl. Just guessing anyway.

Jan 16 2018, 8:05 PM
dfeuer added a comment to D4318: Derive more Data methods.

So far, I'm not getting good performance. I think simplification is faster but type checking is slower. I wonder if some methods are more helpful to derive than others. First guess: we probably should derive gmapQi, and probably shouldn't derive gmapQr. I wonder if gmapT should be defined in terms of gmapM.

Jan 16 2018, 7:48 PM
dfeuer added inline comments to D4318: Derive more Data methods.
Jan 16 2018, 4:07 PM
dfeuer added inline comments to D4318: Derive more Data methods.
Jan 16 2018, 4:01 PM
dfeuer created D4318: Derive more Data methods.
Jan 16 2018, 3:56 PM

Dec 27 2017

dfeuer accepted D4276: Fix #14608 by restoring an unboxed tuple check.
Dec 27 2017, 5:15 PM

Dec 18 2017

dfeuer committed rGHCfb1f0a46983a: Blackholes can be large objects (#14497) (authored by simonmar).
Blackholes can be large objects (#14497)
Dec 18 2017, 10:56 AM
dfeuer closed D4254: Blackholes can be large objects (#14497).
Dec 18 2017, 10:56 AM
dfeuer accepted D4254: Blackholes can be large objects (#14497).
Dec 18 2017, 3:08 AM

Dec 14 2017

dfeuer added inline comments to D4260: Implement BlockArguments (#10843).
Dec 14 2017, 2:51 AM

Dec 13 2017

dfeuer added inline comments to D4260: Implement BlockArguments (#10843).
Dec 13 2017, 6:56 PM

Dec 12 2017

dfeuer updated the Trac tickets for D3848: Fix #12919 by making the flattener homogeneous..
Dec 12 2017, 12:13 PM
dfeuer added a comment to D4261: Kill off irrefutable pattern errors.

I'm not sure killing this off entirely is the right approach. Perhaps it would be better to rename and rephrase; I believe this is really about pattern bindings, not irrefutable patterns. Just killing this off leads to some messages that don't read very well. "Pattern Just p' failed to match in pattern binding" strikes me as better than "Non-exhaustive patterns in Just p'".

Dec 12 2017, 9:52 AM
dfeuer updated the diff for D4261: Kill off irrefutable pattern errors.

Update test results

Dec 12 2017, 8:31 AM
dfeuer added a comment to D4261: Kill off irrefutable pattern errors.

Looks good. Do *no* error messages change in the entire validation suite?

Regardless, good to add some tests.

Dec 12 2017, 3:31 AM
dfeuer created D4261: Kill off irrefutable pattern errors.
Dec 12 2017, 3:19 AM

Dec 11 2017

dfeuer updated the diff for D4123: Allow users to ignore optimization changes.

Rebase

Dec 11 2017, 11:53 AM
dfeuer added a comment to D3981: Fix #14135 by validity checking matches.

The slow validation failures @carlostome saw had nothing whatsoever to do with this patch. I
have started working on pinning down where they showed up, but I haven't gotten far yet.

Dec 11 2017, 7:30 AM
dfeuer updated the diff for D3981: Fix #14135 by validity checking matches.
  • Add a couple comments
Dec 11 2017, 7:27 AM
dfeuer commandeered D3981: Fix #14135 by validity checking matches.

Oh, what fools we mortals be! @carlostome, your assertion failures seem only to happen

Dec 11 2017, 7:27 AM

Dec 7 2017

dfeuer added a comment to D4254: Blackholes can be large objects (#14497).

That's quite a large test file! Would calculating it modulo a moderately large prime distinguish between the holy and the broken?

Dec 7 2017, 8:56 AM
dfeuer requested changes to D4254: Blackholes can be large objects (#14497).

Must add test output.

Dec 7 2017, 4:45 AM
dfeuer added a comment to D4254: Blackholes can be large objects (#14497).

Could the remaining assertion (about compacts) be changed to produce a clearer error message?

Dec 7 2017, 4:45 AM

Dec 5 2017

dfeuer added a comment to D4252: Split T12971 Makefile bits into a separate file.

The other option would be to encode the non-ASCII character in some fashion, however make prefers. But that seems less clear.

Dec 5 2017, 1:39 PM
dfeuer updated the diff for D4252: Split T12971 Makefile bits into a separate file.

Add comment

Dec 5 2017, 1:36 PM
dfeuer created D4252: Split T12971 Makefile bits into a separate file.
Dec 5 2017, 1:31 PM

Dec 4 2017

dfeuer committed rGHC1acb922bb118: Make the Con and Con' patterns produce evidence (authored by dfeuer).
Make the Con and Con' patterns produce evidence
Dec 4 2017, 7:33 AM
dfeuer closed D4139: Make the Con and Con' patterns produce evidence.
Dec 4 2017, 7:33 AM

Dec 1 2017

dfeuer committed rGHCbc761ad9c65c: Cache TypeRep kinds aggressively (authored by dfeuer).
Cache TypeRep kinds aggressively
Dec 1 2017, 5:37 PM
dfeuer closed D4085: Cache TypeRep kinds aggressively.
Dec 1 2017, 5:37 PM
dfeuer updated the diff for D4123: Allow users to ignore optimization changes.

Update changelog; add note

Dec 1 2017, 5:36 PM
dfeuer added a comment to D4244: Nested CPR.

If possible, it would be nice to commit the new tests before committing the real changes; that way the commit will clearly demonstrate what's changed.

Dec 1 2017, 3:45 PM
dfeuer committed rGHC12efb230de40: Add trace injection (authored by dfeuer).
Add trace injection
Dec 1 2017, 3:01 PM
dfeuer closed D4162: Add trace injection.
Dec 1 2017, 3:01 PM
dfeuer updated the diff for D4139: Make the Con and Con' patterns produce evidence.

Improve error message for redundant Con/Con'

Dec 1 2017, 2:56 PM

Nov 29 2017

dfeuer updated the diff for D4085: Cache TypeRep kinds aggressively.

Rebase

Nov 29 2017, 7:04 PM
dfeuer updated the diff for D4162: Add trace injection.

Add further documentation

Nov 29 2017, 7:04 PM
dfeuer updated the diff for D4085: Cache TypeRep kinds aggressively.

Rebase

Nov 29 2017, 7:04 PM
dfeuer updated the diff for D4162: Add trace injection.

Rebase

Nov 29 2017, 5:25 PM
dfeuer added inline comments to D4162: Add trace injection.
Nov 29 2017, 5:14 PM
dfeuer updated the diff for D4162: Add trace injection.

Clean things up a bit

Nov 29 2017, 5:08 PM
dfeuer updated the diff for D4123: Allow users to ignore optimization changes.

Address comments; adjust test results; rebase

Nov 29 2017, 3:46 PM

Nov 27 2017

dfeuer added inline comments to D4162: Add trace injection.
Nov 27 2017, 4:53 PM
dfeuer updated the diff for D4123: Allow users to ignore optimization changes.
  • Make -fignore-...-changes the default for GHCi
Nov 27 2017, 4:46 PM
dfeuer abandoned D4082: Simpler TypeRep deserialization fix.

Abandoned in favor of D4085.

Nov 27 2017, 11:05 AM

Nov 23 2017

dfeuer added inline comments to D4162: Add trace injection.
Nov 23 2017, 2:43 PM

Nov 17 2017

dfeuer updated the diff for D4085: Cache TypeRep kinds aggressively.

Rebase; fix up test results

Nov 17 2017, 2:52 PM
dfeuer updated the diff for D4085: Cache TypeRep kinds aggressively.

Add notes

Nov 17 2017, 2:21 PM

Nov 16 2017

dfeuer updated the diff for D4085: Cache TypeRep kinds aggressively.

Fix Constraint vs Type problem

Nov 16 2017, 9:27 AM

Nov 15 2017

dfeuer planned changes to D4085: Cache TypeRep kinds aggressively.

This runs into a Constraint vs. Type problem. Presumably isLiftedTypeKind is the wrong test? What's the right one?

Nov 15 2017, 11:56 PM
dfeuer added inline comments to D4139: Make the Con and Con' patterns produce evidence.
Nov 15 2017, 11:40 PM
dfeuer added a comment to D4190: Improve If type family.

It would likely be a good idea to point out in the haddocks that If will behave this way. Otherwise, a user could be surprised that If (TypeError ...) True True reduces.

Nov 15 2017, 10:02 PM
dfeuer updated the diff for D4139: Make the Con and Con' patterns produce evidence.

Rebase; rename constructors

Nov 15 2017, 9:32 PM
dfeuer added a comment to D4085: Cache TypeRep kinds aggressively.

A silly question: why do we use lists for the KindRep and TrTyCon business rather than dealing exclusively with arrays? And why do we use Array for it rather than SmallArray#; that would seem slightly lighter, and we're not doing enough array manipulation to feel the pain of a low-level interface.

Nov 15 2017, 9:09 PM
dfeuer updated the diff for D4085: Cache TypeRep kinds aggressively.

Move bang

Nov 15 2017, 9:02 PM
dfeuer added a dependency for D4085: Cache TypeRep kinds aggressively: D4162: Add trace injection.
Nov 15 2017, 8:49 PM
dfeuer added a dependent revision for D4162: Add trace injection: D4085: Cache TypeRep kinds aggressively.
Nov 15 2017, 8:49 PM
dfeuer abandoned D4150: Fix loops.
Nov 15 2017, 8:48 PM
dfeuer abandoned D4178: Why is there a loop?.
Nov 15 2017, 8:47 PM