dfeuer (David Feuer)Administrator
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 5 2014, 5:38 PM (197 w, 4 d)
Roles
Administrator

Recent Activity

Mon, Jun 18

dfeuer added a comment to D4866: Check if files are same in combineSrcSpans.

Yes, that. But do you really need such fancy logic in the test? Wouldn't something much simpler (like a type error) do the trick? Then you wouldn't have to deal with -ddump-parsed-ast.

Mon, Jun 18, 3:04 PM
dfeuer requested changes to D4866: Check if files are same in combineSrcSpans.

Can you add a test case?

Mon, Jun 18, 1:51 PM
dfeuer accepted D4868: Rewrite fasta in more idiomatic Haskell.

Although it's unfortunate to change benchmark source in general, I think it's pretty clearly justified this time.

Mon, Jun 18, 1:51 PM

Sun, Jun 17

dfeuer created D4864: Bump containers to v0.6.0.1.
Sun, Jun 17, 10:32 PM

Mon, Jun 11

dfeuer committed rGHC502026fc0a35: Make seq# evaluatedness look through casts (authored by dfeuer).
Make seq# evaluatedness look through casts
Mon, Jun 11, 9:35 AM
dfeuer closed D4804: Make seq# evaluatedness look through casts.
Mon, Jun 11, 9:35 AM
dfeuer updated the diff for D4804: Make seq# evaluatedness look through casts.
  • Add output
Mon, Jun 11, 9:25 AM

Thu, Jun 7

dfeuer requested changes to D4812: Add Foldable1 from package 'semigroupoids' to base.

I believe this change needs a formal libraries list proposal.

Thu, Jun 7, 1:52 PM

Wed, Jun 6

dfeuer accepted D4776: desugar: Rip out unsafeGlobalDynFlags usage in decomposeRuleLhs.

Yup!

Wed, Jun 6, 10:38 PM
dfeuer created D4804: Make seq# evaluatedness look through casts.
Wed, Jun 6, 3:29 PM
dfeuer committed rGHCd964b054d530: Let the simplifier know that seq# forces (authored by dfeuer).
Let the simplifier know that seq# forces
Wed, Jun 6, 2:53 PM
dfeuer closed D4796: Let the simplifier know that seq# forces.
Wed, Jun 6, 2:53 PM
dfeuer accepted D4802: testsuite: Skip T13838 in ghci way.

Yeah, that sounds reasonable. Not ideal, perhaps, but there's no obvious and easy way to make GHCi fail this without really reworking the test.

Wed, Jun 6, 2:47 PM
dfeuer accepted D4801: Don't expose (~#), (~R#), (~P#) from GHC.Prim.

LGTM, if it validates.

Wed, Jun 6, 2:23 PM
dfeuer updated the diff for D4796: Let the simplifier know that seq# forces.
  • Add test
Wed, Jun 6, 1:32 PM
dfeuer requested changes to D4783: Improve error message when importing an unusable package (Trac #4806).

You state that this improves error messages, but you don't explain what happened before, what was wrong with it, what you're doing now, and what makes that better. Since this isn't entirely obvious, I suggest opening a Trac ticket.

Wed, Jun 6, 10:31 AM
dfeuer updated the diff for D4796: Let the simplifier know that seq# forces.
  • Pull out zapper; improve panic message
Wed, Jun 6, 9:37 AM
dfeuer added inline comments to D4796: Let the simplifier know that seq# forces.
Wed, Jun 6, 9:13 AM

Tue, Jun 5

dfeuer updated the diff for D4796: Let the simplifier know that seq# forces.
  • Refactor
Tue, Jun 5, 9:07 PM
dfeuer added a comment to D4796: Let the simplifier know that seq# forces.

@simonpj, I didn't really want to use collectArgsTicks because it seems a bit expensive for the job. So for the moment I've written a function to just drop the arguments and ticks I need to make the comparison. Your other refactor request was definitely a major improvement. Thanks.

Tue, Jun 5, 9:05 PM
dfeuer updated the diff for D4796: Let the simplifier know that seq# forces.
  • Refactor
Tue, Jun 5, 9:02 PM
dfeuer updated the diff for D4796: Let the simplifier know that seq# forces.

Remove likely-unnecessary bang pattern

Tue, Jun 5, 1:01 PM
dfeuer updated the diff for D4796: Let the simplifier know that seq# forces.

Improve comment

Tue, Jun 5, 12:42 PM
dfeuer abandoned D4789: Force the result of seq#.

I've opened D4796 to fix the problem in the simplifier.

Tue, Jun 5, 12:00 PM
dfeuer created D4796: Let the simplifier know that seq# forces.
Tue, Jun 5, 12:00 PM

Mon, Jun 4

dfeuer updated the diff for D4789: Force the result of seq#.
  • Add note.
Mon, Jun 4, 2:26 PM
dfeuer created D4789: Force the result of seq#.
Mon, Jun 4, 2:07 PM

Sat, Jun 2

dfeuer created D4773: Index arrays more eagerly.
Sat, Jun 2, 9:46 PM

Fri, Jun 1

dfeuer created D4763: Remove ~# from surface syntax.
Fri, Jun 1, 8:36 AM

Thu, May 31

dfeuer requested changes to D4727: Move 'HsBangTy' out in constructor arguments.
Thu, May 31, 12:47 PM
dfeuer resigned from D4727: Move 'HsBangTy' out in constructor arguments.
Thu, May 31, 12:47 PM

Tue, May 29

dfeuer created D4751: Add some comments about interruptibility for Chan.
Tue, May 29, 7:26 PM
dfeuer committed rGHC5e91cdecc39d: Unmask readMVar in readChan (authored by dfeuer).
Unmask readMVar in readChan
Tue, May 29, 4:00 PM
dfeuer closed D4738: Unmask readMVar in readChan.
Tue, May 29, 4:00 PM

Mon, May 28

dfeuer added inline comments to D4736: Change to improve Eq, Ord, Float and Double documentation (trac issue #15078)..
Mon, May 28, 10:55 AM
dfeuer added inline comments to D4742: Unpack and simplify QSem.
Mon, May 28, 9:09 AM

Sun, May 27

dfeuer requested changes to D4727: Move 'HsBangTy' out in constructor arguments.
Sun, May 27, 7:41 PM
dfeuer updated the diff for D4742: Unpack and simplify QSem.

Rebase

Sun, May 27, 7:22 PM
dfeuer updated the diff for D4738: Unmask readMVar in readChan.

Rebase

Sun, May 27, 7:22 PM
dfeuer requested changes to D4740: Check if both branches of an Cmm if have the same target..

Something isn't working. Also, it would be nice to have a test demonstrating that this sometimes does something useful.

Sun, May 27, 7:12 PM
dfeuer added inline comments to D4739: Fix "redundant constraint" warnings when meets functional dependencies.
Sun, May 27, 6:26 PM
dfeuer created D4742: Unpack and simplify QSem.
Sun, May 27, 5:30 PM

Fri, May 25

dfeuer added a reviewer for D4738: Unmask readMVar in readChan: simonmar.
Fri, May 25, 3:23 PM
dfeuer created D4738: Unmask readMVar in readChan.
Fri, May 25, 2:52 PM
dfeuer added inline comments to D4736: Change to improve Eq, Ord, Float and Double documentation (trac issue #15078)..
Fri, May 25, 1:56 PM
dfeuer requested changes to D4736: Change to improve Eq, Ord, Float and Double documentation (trac issue #15078)..
Fri, May 25, 1:50 PM
dfeuer added inline comments to D4737: Change to improve the documentation of the enumFrom series of functions (trac issue #15134)..
Fri, May 25, 12:28 PM

Mon, May 21

dfeuer added a comment to D4720: Export Solo and Solo# from PrelInfo.hs.

What exactly is the problem here? Adding a test would help.

Mon, May 21, 10:00 PM
dfeuer updated the diff for D4720: Export Solo and Solo# from PrelInfo.hs.
  • Fix some more
Mon, May 21, 8:56 PM
dfeuer created D4720: Export Solo and Solo# from PrelInfo.hs.
Mon, May 21, 6:14 PM

May 15 2018

dfeuer added a comment to D4692: Remove OPTIONS_HADDOCK hide in favour for not-home.

Bleh! This part may take more community work. But I would leave it hidden
till we figure that out. The PR to process sounds like a good idea
regardless.

May 15 2018, 2:43 PM
dfeuer added a comment to D4692: Remove OPTIONS_HADDOCK hide in favour for not-home.

That's my suggestion for now, yes.

May 15 2018, 11:19 AM
dfeuer added a comment to D4692: Remove OPTIONS_HADDOCK hide in favour for not-home.

@dfeuer, GHC.IntWord64 is from ghc-prim, that one should certainly not be removed from exposed-modules? (base imports it)

May 15 2018, 7:31 AM
dfeuer requested changes to D4692: Remove OPTIONS_HADDOCK hide in favour for not-home.

I mostly agree with this. However, I think there are some modules that simply shouldn't be exposed through Cabal at all, and revealing their Haddocks seems like a step in the wrong direction sending the message that some end users might want to use them. A notable example is GHC.IO.IOMode, whose entire contents are exported by System.IO. I'm pretty strongly opposed to unhiding this module, and generally in favor of removing it from the Exposed-modules section.

May 15 2018, 1:39 AM
dfeuer abandoned D4626: type apps for overloaded literals (fixes #11409).

The proposal was rejected by the committee, so this will not be merged.

May 15 2018, 1:13 AM

May 13 2018

dfeuer added a comment to D4677: Improve some Foldable methods for NonEmpty.

There are several things that don't fuse here. I'm not sure why as yet, but the unfoldings seem to get optimized too much. I think we can address that separately.

May 13 2018, 12:03 PM

May 11 2018

dfeuer added a comment to D4679: RTS: Auto-size the allocation area depending on CPU cache size.

I don't see how perf.haskell.org will help you here. It just counts
instructions, so it's not going to tell you anything about the cache
effects you're after.

May 11 2018, 4:23 PM

May 9 2018

dfeuer added a comment to D4679: RTS: Auto-size the allocation area depending on CPU cache size.

Have you tested the performance implications?
I remember some programs in nofib actually getting slower with larger allocation sizes.

So it doesn't seem obvious to me that having the allocation area match a cache size would be better in general.

May 9 2018, 6:03 PM

May 8 2018

dfeuer created D4678: Fix changelog message for asinh.
May 8 2018, 8:16 PM
dfeuer updated the diff for D4601: Rip out ExnStr business.
  • Update notes
  • Adjust test output
May 8 2018, 8:16 PM
dfeuer added reviewers for D4677: Improve some Foldable methods for NonEmpty: mpickering, nomeata.
May 8 2018, 7:42 PM
dfeuer created D4677: Improve some Foldable methods for NonEmpty.
May 8 2018, 7:42 PM
dfeuer added a comment to D4656: Clarify what the FFI spec says.

@bgamari, is it better now? Is the remark about threads at the end correct?

May 8 2018, 7:05 PM
dfeuer updated the diff for D4656: Clarify what the FFI spec says.
  • Respond to Ben's comments
May 8 2018, 7:05 PM
dfeuer updated the diff for D4676: Remove unused things from utils/Digraph.

Remove unused imports

May 8 2018, 3:28 PM

May 7 2018

dfeuer created D4676: Remove unused things from utils/Digraph.
May 7 2018, 6:45 PM

May 4 2018

dfeuer added inline comments to D4632: An overhaul of the SRT representation.
May 4 2018, 12:28 AM

May 3 2018

dfeuer added inline comments to D4632: An overhaul of the SRT representation.
May 3 2018, 11:18 PM
dfeuer added a comment to D4601: Rip out ExnStr business.

Yes.

May 3 2018, 12:22 PM
dfeuer added a comment to D4650: Improve numeric stability of numericEnumFrom for floating numbers, fix #15081..

If the performance difference is negligible compared to additions then there's no point. But remember that we don't need to use the same functions to define the instances for Float and Double. OTOH, I really wish these instances didn't even exist, so I shouldn't care of they're fast!

May 3 2018, 1:46 AM

May 2 2018

dfeuer committed rGHC198db048f60f: Set arity for absentError (authored by dfeuer).
Set arity for absentError
May 2 2018, 10:53 PM
dfeuer closed D4655: Fix note on handling INLINABLE and absentError.
May 2 2018, 10:53 PM
dfeuer added a comment to D4650: Improve numeric stability of numericEnumFrom for floating numbers, fix #15081..

Something else to try: do different things depending on the magnitude of the arguments. If additions are substantially faster, then we'd prefer to use them when they don't lose too much precision. Can we get a conservative estimate of that for cheap? I conjecture that we can, especially if the step is an exact integer.

May 2 2018, 10:11 PM
dfeuer updated the diff for D4655: Fix note on handling INLINABLE and absentError.

Unskip CI

May 2 2018, 3:16 PM
dfeuer updated the summary of D4655: Fix note on handling INLINABLE and absentError.
May 2 2018, 3:15 PM
dfeuer added a comment to D4655: Fix note on handling INLINABLE and absentError.

Oh blast.... This thing skips CI, and I just changed code. Hrmmmmm....

May 2 2018, 2:21 PM
dfeuer added inline comments to D4655: Fix note on handling INLINABLE and absentError.
May 2 2018, 2:20 PM
dfeuer updated the diff for D4655: Fix note on handling INLINABLE and absentError.
  • Change arity info for absentError and address Simon's other comments.
May 2 2018, 2:19 PM

May 1 2018

dfeuer requested review of D4656: Clarify what the FFI spec says.
May 1 2018, 8:58 PM
dfeuer requested review of D4655: Fix note on handling INLINABLE and absentError.
May 1 2018, 7:24 PM

Apr 30 2018

dfeuer added inline comments to D4632: An overhaul of the SRT representation.
Apr 30 2018, 6:37 PM
dfeuer accepted D4626: type apps for overloaded literals (fixes #11409).

Good enough for me!

Apr 30 2018, 5:45 AM
dfeuer added inline comments to D4626: type apps for overloaded literals (fixes #11409).
Apr 30 2018, 5:30 AM

Apr 29 2018

dfeuer requested changes to D4626: type apps for overloaded literals (fixes #11409).
Apr 29 2018, 9:14 PM

Apr 27 2018

dfeuer added a comment to D4638: Adjust Control.Applicative instances.

It looks like the remaining test suite failures are unrelated.

Apr 27 2018, 12:17 AM

Apr 26 2018

dfeuer updated the diff for D4638: Adjust Control.Applicative instances.
  • Wall noise
Apr 26 2018, 10:46 PM
dfeuer updated the diff for D4638: Adjust Control.Applicative instances.
  • Add import of GHC.Num. This is okay because we already depend on GHC.List, which depends on GHC.Num.
Apr 26 2018, 4:10 PM
dfeuer requested changes to D4630: Refactor LitString.

Just a couple little things.

Apr 26 2018, 4:03 PM
dfeuer updated the diff for D4638: Adjust Control.Applicative instances.
  • Add instances for WrappedArrow
Apr 26 2018, 3:33 PM
dfeuer updated the diff for D4638: Adjust Control.Applicative instances.
  • Use the Monad and MonadPlus instances
Apr 26 2018, 2:55 PM
dfeuer updated the diff for D4638: Adjust Control.Applicative instances.
  • Missed a test
Apr 26 2018, 2:40 PM
dfeuer added a comment to D4638: Adjust Control.Applicative instances.

@RyanGlScott, I think I've handled your concerns.

Apr 26 2018, 2:36 PM
dfeuer updated the diff for D4638: Adjust Control.Applicative instances.
  • Document WrappedMonad
Apr 26 2018, 2:30 PM
dfeuer updated the diff for D4638: Adjust Control.Applicative instances.
  • Fixups
Apr 26 2018, 2:23 PM
dfeuer updated the Trac tickets for D4638: Adjust Control.Applicative instances.
Apr 26 2018, 1:53 PM
dfeuer updated the summary of D4638: Adjust Control.Applicative instances.
Apr 26 2018, 1:29 PM
dfeuer updated the diff for D4638: Adjust Control.Applicative instances.
  • Fix changelog
Apr 26 2018, 1:29 PM
dfeuer added a reviewer for D4638: Adjust Control.Applicative instances: RyanGlScott.
Apr 26 2018, 1:29 PM
dfeuer updated the diff for D4638: Adjust Control.Applicative instances.
  • Take care of <* as well
Apr 26 2018, 1:29 PM
dfeuer updated the summary of D4638: Adjust Control.Applicative instances.
Apr 26 2018, 1:29 PM