ckoparkar (Chaitanya Koparkar)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 3 2017, 4:26 PM (66 w, 3 d)

Recent Activity

Yesterday

ckoparkar added inline comments to D5415: Fix #15656 by extending -Wall with appropriate flags.
Wed, Dec 12, 2:44 PM
ckoparkar updated the diff for D5415: Fix #15656 by extending -Wall with appropriate flags.

Remove duplicate pragma.

Wed, Dec 12, 2:43 PM
ckoparkar added a comment to D5415: Fix #15656 by extending -Wall with appropriate flags.

Note that the build won't be totally warning free just yet because this patch doesn't suppress these warnings for the libraries.

Wed, Dec 12, 9:48 AM
ckoparkar updated the summary of D5415: Fix #15656 by extending -Wall with appropriate flags.
Wed, Dec 12, 9:46 AM
ckoparkar updated the diff for D5415: Fix #15656 by extending -Wall with appropriate flags.

Supress warnings.

Wed, Dec 12, 9:44 AM

Wed, Dec 5

ckoparkar planned changes to D5415: Fix #15656 by extending -Wall with appropriate flags.

Sorry, I was wrong. GHC does generate warnings because of this.

Wed, Dec 5, 11:14 AM
ckoparkar added a comment to D5415: Fix #15656 by extending -Wall with appropriate flags.

I looked at the stage1 and stage2 build logs, and GHC itself didn't generate any new warnings. I'll try to fix any warnings that other libraries in haskell/ might generate.

Wed, Dec 5, 10:42 AM
ckoparkar created D5415: Fix #15656 by extending -Wall with appropriate flags.
Wed, Dec 5, 10:36 AM

Thu, Nov 29

ckoparkar retitled D5393: Add a test case for #15962 from Add a test case for #T15962 to Add a test case for #15962.
Thu, Nov 29, 7:27 AM
ckoparkar created D5393: Add a test case for #15962.
Thu, Nov 29, 6:51 AM

Wed, Nov 28

ckoparkar added a comment to D5382: Fix #15953 by consistently using dumpIfSet_dyn to print debug output.

@RyanGlScott Oops, sorry. Fixed it :)

Wed, Nov 28, 8:13 AM
ckoparkar updated the diff for D5382: Fix #15953 by consistently using dumpIfSet_dyn to print debug output.

Bring back -ddump-tc.

Wed, Nov 28, 8:12 AM
ckoparkar added inline comments to D5382: Fix #15953 by consistently using dumpIfSet_dyn to print debug output.
Wed, Nov 28, 7:52 AM

Tue, Nov 27

ckoparkar updated the summary of D5382: Fix #15953 by consistently using dumpIfSet_dyn to print debug output.
Tue, Nov 27, 6:55 PM
ckoparkar updated the diff for D5382: Fix #15953 by consistently using dumpIfSet_dyn to print debug output.

Fixed some failing tests using 'traceTcRnForUser'.

Tue, Nov 27, 6:54 PM
ckoparkar planned changes to D5382: Fix #15953 by consistently using dumpIfSet_dyn to print debug output.

(fixing the build)

Tue, Nov 27, 7:55 AM

Mon, Nov 26

ckoparkar planned changes to D5280: Fix #15758 by making the RTS parse response file arguments.

@bgamari Should be ready for review soon :) I'm still working on rewriting the GCC parts.

Mon, Nov 26, 5:26 PM
ckoparkar added inline comments to D5382: Fix #15953 by consistently using dumpIfSet_dyn to print debug output.
Mon, Nov 26, 5:23 PM
ckoparkar retitled D5382: Fix #15953 by consistently using dumpIfSet_dyn to print debug output from Fix #15953 by using removing certain uses of putLogMsg to Fix #15953 by consistently using dumpIfSet_dyn to print debug output.
Mon, Nov 26, 5:13 PM
ckoparkar added a comment to D5382: Fix #15953 by consistently using dumpIfSet_dyn to print debug output.

@bgamari I started looking at DriverPipeline, and got distracted.
Also, even after this patch, '-ddump-mod-map' (used in Packages.mkPackageState) still prints the output to STDOUT,
because dumpPrefix is still Nothing. Does DriverPipeline.runPipeline not run before we get to mkPackageState?
On the other hand, it works ok if we use -ddump-file-prefix=blah by hand.

Mon, Nov 26, 5:12 PM
ckoparkar updated the diff for D5382: Fix #15953 by consistently using dumpIfSet_dyn to print debug output.

Fix other instances of when (dopt ...) print ....

Mon, Nov 26, 4:53 PM
ckoparkar planned changes to D5382: Fix #15953 by consistently using dumpIfSet_dyn to print debug output.

As @RyanGlScott pointed out, there are a few other places where when (dopt ...) print ... is used directly. Fixing those now.

Mon, Nov 26, 11:08 AM
ckoparkar created D5382: Fix #15953 by consistently using dumpIfSet_dyn to print debug output.
Mon, Nov 26, 10:54 AM

Fri, Nov 23

ckoparkar updated the summary of D5280: Fix #15758 by making the RTS parse response file arguments.
Fri, Nov 23, 11:06 AM
ckoparkar updated the summary of D5280: Fix #15758 by making the RTS parse response file arguments.
Fri, Nov 23, 11:04 AM
ckoparkar added a comment to D5280: Fix #15758 by making the RTS parse response file arguments.

No, because those options will not have been processed by the RTS. Why would users need to do that?

@simonmar Oh, I see what you mean. Filtering these out would actually make it seem that they were in fact processed by the RTS,
which would be incorrect.

Fri, Nov 23, 11:02 AM
ckoparkar updated the diff for D5280: Fix #15758 by making the RTS parse response file arguments.

Start updating semantics per @simonmar's comment (TODO: remove GCC bits)

Fri, Nov 23, 10:54 AM

Nov 12 2018

ckoparkar planned changes to D5280: Fix #15758 by making the RTS parse response file arguments.

Thanks @simonmar. I'll update this patch in a couple days.

Nov 12 2018, 7:45 AM

Nov 9 2018

ckoparkar added a comment to D5280: Fix #15758 by making the RTS parse response file arguments.

Ping :)

Nov 9 2018, 8:16 AM

Oct 29 2018

ckoparkar added inline comments to D5280: Fix #15758 by making the RTS parse response file arguments.
Oct 29 2018, 10:00 AM
ckoparkar requested review of D5280: Fix #15758 by making the RTS parse response file arguments.
Oct 29 2018, 10:00 AM
ckoparkar planned changes to D5280: Fix #15758 by making the RTS parse response file arguments.

This is still a WIP patch for option 2 mentioned in comment:2 in Trac #15732 (extending the RTS to parse response files). I submitted it here to get some early feedback. And there are a few things that must be dealt with:

Oct 29 2018, 9:54 AM
ckoparkar created D5280: Fix #15758 by making the RTS parse response file arguments.
Oct 29 2018, 9:49 AM

Oct 22 2018

ckoparkar accepted D5250: Update hsc2hs submodule to work around bug in response file handling..

LGTM. Thanks @AndreasK :)

Oct 22 2018, 9:01 AM

Sep 18 2018

ckoparkar added a comment to D5160: Use predefined known-key names when possible.

The ticket mentions one more thing which I have not implemented:

consider making liftA2 known-key for Traversable deriving.

Sep 18 2018, 3:36 PM
ckoparkar created D5160: Use predefined known-key names when possible.
Sep 18 2018, 3:36 PM

Sep 17 2018

ckoparkar added a comment to D5114: Update hsc2hs submodule.

Thanks @bgamari!

Sep 17 2018, 12:24 PM

Sep 6 2018

ckoparkar updated subscribers of D5114: Update hsc2hs submodule.

@bgamari @monoidal Does this look ready to be merged ?

Sep 6 2018, 7:03 AM

Aug 28 2018

ckoparkar added a comment to D5114: Update hsc2hs submodule.

(We should also merge this in the 8.6 branch)

Aug 28 2018, 5:46 PM
ckoparkar added a comment to D5114: Update hsc2hs submodule.

Thanks @RyanGlScott. Fixed it.

Aug 28 2018, 12:57 PM
ckoparkar updated the summary of D5114: Update hsc2hs submodule.
Aug 28 2018, 12:56 PM
ckoparkar retitled D5114: Update hsc2hs submodule from Bump hsc2hs submodule to Update hsc2hs submodule.
Aug 28 2018, 11:40 AM
ckoparkar updated the diff for D5114: Update hsc2hs submodule.

Fix typo in the commit message.

Aug 28 2018, 11:40 AM
ckoparkar created D5114: Update hsc2hs submodule.
Aug 28 2018, 11:39 AM

Aug 24 2018

ckoparkar added a comment to D5104: Fix #10859 by using foldr1 while deriving Eq instances.

You can grep for grep, some tests declare what to look for the in the dump. But in this example, I think it is hard to write a reliable grep command.

Aug 24 2018, 3:54 PM
ckoparkar updated the diff for D5104: Fix #10859 by using foldr1 while deriving Eq instances.

Get rid of the test

Aug 24 2018, 3:42 PM
ckoparkar added a comment to D5104: Fix #10859 by using foldr1 while deriving Eq instances.

Oh right, I should've used -dsuppress-uniques. Would a comment in the test file help ? Otherwise, I'll update this patch to not include it.

Aug 24 2018, 1:11 PM
ckoparkar added inline comments to D5104: Fix #10859 by using foldr1 while deriving Eq instances.
Aug 24 2018, 12:34 PM
ckoparkar updated the diff for D5104: Fix #10859 by using foldr1 while deriving Eq instances.

@nomeata's suggestion

Aug 24 2018, 12:33 PM
ckoparkar created D5104: Fix #10859 by using foldr1 while deriving Eq instances.
Aug 24 2018, 12:32 PM

Aug 23 2018

ckoparkar added inline comments to D5092: base: Add references to Notes for certain special imports.
Aug 23 2018, 6:49 PM
ckoparkar updated the diff for D5092: base: Add references to Notes for certain special imports.

@simonpj's suggestions

Aug 23 2018, 6:46 PM
ckoparkar added a comment to D5095: Remove dph, vector, primitive and random from .gitmodules.

It turns out that git rm PATH && git commit removes a sub-module from the git working tree but doesn't delete the relevant section from .gitmodules.

Aug 23 2018, 11:16 AM
ckoparkar created D5095: Remove dph, vector, primitive and random from .gitmodules.
Aug 23 2018, 11:16 AM
ckoparkar created D5092: base: Add references to Notes for certain special imports.
Aug 23 2018, 8:43 AM

May 9 2018

ckoparkar abandoned D4682: Remove everything related to response files.

Still WIP, and did not intend to submit a patch.

May 9 2018, 12:18 PM
ckoparkar created D4682: Remove everything related to response files.
May 9 2018, 12:06 PM

May 6 2018

ckoparkar added a comment to D4669: GHCi: Include a note in the hint to expose a hidden package.

In general I wish that :set weren't so destructive, but that is another issue altogether.

May 6 2018, 7:03 AM

May 5 2018

ckoparkar created D4669: GHCi: Include a note in the hint to expose a hidden package.
May 5 2018, 11:48 AM

May 4 2018

ckoparkar added a comment to D4621: GHCi: Improve the error message for hidden packages.

Does this look alright ?

May 4 2018, 7:39 AM

May 3 2018

ckoparkar added a comment to D4621: GHCi: Improve the error message for hidden packages.

Oh no, it was my fault. I'm AFK right now, but I'll submit another patch to update this hint tomorrow.

May 3 2018, 5:57 PM
ckoparkar added a comment to D4621: GHCi: Improve the error message for hidden packages.

Oops. Sorry, I should've changed the status to "Changes Planned" or something. Should I file a trac issue to fix this "hint" (@RyanGlScott's comment) ? Or is OK in it's current form ?

May 3 2018, 3:50 PM
ckoparkar added a comment to D4621: GHCi: Improve the error message for hidden packages.

That's a good point. If we decide to add this hint, it could maybe include a note about this effect.

May 3 2018, 9:49 AM

Apr 23 2018

ckoparkar requested review of D4621: GHCi: Improve the error message for hidden packages.
Apr 23 2018, 8:05 PM
ckoparkar updated the diff for D4612: Move the ResponseFile module from haddock into base.

Include an example that uses getArgsWithResponseFiles in the haddocks.

Apr 23 2018, 11:30 AM

Apr 22 2018

ckoparkar retitled D4612: Move the ResponseFile module from haddock into base from Move the parts related to handling response files from haddock into base to Move the ResponseFile module from haddock into base.
Apr 22 2018, 8:58 AM

Apr 21 2018

ckoparkar added a comment to D4612: Move the ResponseFile module from haddock into base.

The build failure seems unrelated to the patch:
exception 'PhabricatorWorkerPermanentFailureException' with message 'Lease "PHID-DRYL-zbqyzktfang7i4ajamnt" never activated.'

Apr 21 2018, 11:19 AM
ckoparkar updated the diff for D4612: Move the ResponseFile module from haddock into base.

Define getArgsWithResponseFiles in GHC.ResponseFile instead of System.Environment.

Apr 21 2018, 11:04 AM
ckoparkar requested review of D4612: Move the ResponseFile module from haddock into base.
Apr 21 2018, 2:31 AM

Mar 19 2018

ckoparkar added a comment to D4506: Turn a TH Name for built-in syntax into an unqualified RdrName.

:)

Mar 19 2018, 2:54 PM

Mar 17 2018

ckoparkar added a comment to D4506: Turn a TH Name for built-in syntax into an unqualified RdrName.

Thanks :)

Mar 17 2018, 6:26 PM
ckoparkar updated the diff for D4506: Turn a TH Name for built-in syntax into an unqualified RdrName.

Mention the trac number in the comment.

Mar 17 2018, 6:25 PM
ckoparkar created D4506: Turn a TH Name for built-in syntax into an unqualified RdrName.
Mar 17 2018, 3:29 PM

Feb 26 2018

ckoparkar updated the diff for D4452: Add @since annotations for derived instances in base.

Fixed the instance for Lifetime

Feb 26 2018, 1:31 PM
ckoparkar added a comment to D4452: Add @since annotations for derived instances in base.

@RyanGlScott I think most of the annotations should be correct. I've tagged some of the places which I wasn't sure about.

Feb 26 2018, 12:44 PM
ckoparkar added inline comments to D4452: Add @since annotations for derived instances in base.
Feb 26 2018, 12:41 PM
ckoparkar updated the diff for D4452: Add @since annotations for derived instances in base.

Fixed deriving instance Traversable Identity

Feb 26 2018, 12:12 PM
ckoparkar added a reviewer for D4452: Add @since annotations for derived instances in base: RyanGlScott.
Feb 26 2018, 12:03 PM
ckoparkar created D4452: Add @since annotations for derived instances in base.
Feb 26 2018, 12:02 PM