chessai (Daniel Cartwright)
User

Projects

User does not belong to any projects.

User Details

User Since
May 30 2018, 5:20 PM (38 w, 1 d)

Recent Activity

Dec 26 2018

chessai updated the diff for D5451: add -Wmissing-deriving-strategies.
  • fix indentation causing build failure
Dec 26 2018, 1:00 PM
chessai updated the diff for D5451: add -Wmissing-deriving-strategies.
  • fix indentation causing build failure
Dec 26 2018, 12:51 PM

Dec 17 2018

chessai added a comment to D5451: add -Wmissing-deriving-strategies.

What do the following errors mean? The docs are failing to build.

Dec 17 2018, 7:12 PM
chessai updated the diff for D5451: add -Wmissing-deriving-strategies.
  • doc changes suggested by Ryan
Dec 17 2018, 7:03 PM
chessai updated the diff for D5455: add -Wderiving-defaults for enabling/suppressing strategy defaulting warnings.
  • make changes suggested by Ryan Scott
Dec 17 2018, 9:31 AM
chessai updated the diff for D5451: add -Wmissing-deriving-strategies.
  • add missing newline to end of file
Dec 17 2018, 9:16 AM
chessai updated the diff for D5451: add -Wmissing-deriving-strategies.
  • add entry about flag in docs/users_guide/using-warnings.rst
Dec 17 2018, 9:12 AM
chessai updated the diff for D5451: add -Wmissing-deriving-strategies.

rebase on top of master to (hopefully) avoid test failures.

Dec 17 2018, 9:00 AM
chessai added a comment to D5451: add -Wmissing-deriving-strategies.
Dec 17 2018, 8:28 AM

Dec 14 2018

chessai created D5456: make QSem and QSemN newtypes.
Dec 14 2018, 3:23 PM
chessai updated the diff for D5451: add -Wmissing-deriving-strategies.
  • some stylistic changes
Dec 14 2018, 11:44 AM
chessai created D5455: add -Wderiving-defaults for enabling/suppressing strategy defaulting warnings.
Dec 14 2018, 11:37 AM
chessai updated the diff for D5451: add -Wmissing-deriving-strategies.
  • don't use OverloadedStrings to construct SDocs. Instead use the text convention.
Dec 14 2018, 10:57 AM
chessai updated the diff for D5451: add -Wmissing-deriving-strategies.
  • make -Wmissing-deriving-strategies work with -XStandaloneDeriving
Dec 14 2018, 10:42 AM
chessai added a comment to D5451: add -Wmissing-deriving-strategies.

Ryan, I'd appreciate any feedback. I'll look into how to enable this for standalone deriving clauses.

Dec 14 2018, 10:24 AM
chessai added a reviewer for D5451: add -Wmissing-deriving-strategies: RyanGlScott.
Dec 14 2018, 10:22 AM
chessai updated the diff for D5451: add -Wmissing-deriving-strategies.
  • resolve a number of issues
Dec 14 2018, 10:22 AM
chessai added a comment to D5451: add -Wmissing-deriving-strategies.
  • Does this emit warnings for StandaloneDeriving clauses?
Dec 14 2018, 9:34 AM

Dec 13 2018

chessai added a comment to D5451: add -Wmissing-deriving-strategies.

Don't accept this, please. I believe the warning message is inadequate, though I'm not quite sure how it should look, or how I would make it look better. If anyone has any advice on this please let me know.

Dec 13 2018, 5:52 PM
chessai created D5451: add -Wmissing-deriving-strategies.
Dec 13 2018, 5:50 PM
chessai updated the diff for D5447: don't suggest Rank2Types in error messages (Fixed #16000).
  • change .stderrs in testsuite to reflect new error message
Dec 13 2018, 2:06 PM
chessai added a comment to D5447: don't suggest Rank2Types in error messages (Fixed #16000).

Have you ran the test suite? Some tests' expected stderr files are almost certainly going to change as a result of this, so you need to accept the new stderr.

Dec 13 2018, 1:15 PM
chessai created D5447: don't suggest Rank2Types in error messages (Fixed #16000).
Dec 13 2018, 10:53 AM

Sep 30 2018

chessai added a comment to D5189: resolve T13704.

Thanks Daniel, can you clarify the difference between this patch and D5162?

Sep 30 2018, 8:14 PM
chessai created D5189: resolve T13704.
Sep 30 2018, 4:30 PM

Jun 7 2018

chessai updated the diff for D4812: Add Foldable1 from package 'semigroupoids' to base.
  • as FirstLast -> Monoid
Jun 7 2018, 1:41 PM
chessai retitled D4812: Add Foldable1 from package 'semigroupoids' to base from fix linter suggestions to Add Foldable1 from package 'semigroupoids' to base.
Jun 7 2018, 1:36 PM
chessai added a comment to D4812: Add Foldable1 from package 'semigroupoids' to base.

Can you amend the title and description of this Differential? It looks to me like this does far more than just fix linter suggestions.

Jun 7 2018, 1:30 PM
chessai updated the diff for D4812: Add Foldable1 from package 'semigroupoids' to base.
  • fix linter errors
Jun 7 2018, 1:28 PM
chessai updated the diff for D4812: Add Foldable1 from package 'semigroupoids' to base.

correct base commit

Jun 7 2018, 1:15 PM
chessai added a comment to D4812: Add Foldable1 from package 'semigroupoids' to base.

Forgive me, for I'm new to Phabricator, but I can't seem to find the diff showing the first commit that I made in this branch.

Jun 7 2018, 1:09 PM
chessai created D4812: Add Foldable1 from package 'semigroupoids' to base.
Jun 7 2018, 1:05 PM