I like working on GHC. 'tis all I have to say.
- User Since
- Jul 20 2014, 6:05 AM (152 w, 5 d)
Looks good to me. Thanks!
Feel free to disregard the comment; I'll try to address this myself.
Alright, bumping out of the review queue for now.
Sounds good to me.
Wed, Jun 21
As noted on the ticket, we are going to run the propose module structure through the proposal process.
Just one more iteration, I promise!
Bumping out of the review queue. Let me know if you have any questions.
Soundso good to me.
I think the right approach to deal with the semigroups dependency is to make it conditional on a base_with_semigroups Cabal flag.
Except for the error message wobble which I can fix on metge, looks good to me.
This seems pretty reasonable to me.
- Disable trace
- Fix RnBody strictness
- Fix spelling
Tue, Jun 20
Mon, Jun 19
At the moment the UnsafeReenterGhci test hangs here,
#0 pthread_cond_wait@@GLIBC_2.3.2 () at ../sysdeps/unix/sysv/linux/x86_64/pthread_cond_wait.S:185 #1 0x00007fffeee62209 in waitCondition (pCond=pCond@entry=0x754ea0, pMut=pMut@entry=0x754ed0) at rts/posix/OSThreads.c:117 #2 0x00007fffeee43c33 in waitForReturnCapability (task=task@entry=0x754e90) at rts/Capability.c:714 #3 0x00007fffeee444ac in waitForCapability (pCap=pCap@entry=0x7fffe77fdc28, task=0x754e90) at rts/Capability.c:806 #4 0x00007fffeee43248 in rts_lock () at rts/RtsAPI.c:597 #5 0x00007fffe65fba21 in zdmainzdMainzdMainzuwrapzzuf () from /tmp/ghc11809_0/libghc_7.so #6 0x00007fffec11d813 in hello () from /tmp/ghc11809_0/libghc_1.so #7 0x00007fffeec18914 in ffi_call_unix64 () from /opt/exp/ghc/ghc-landing/rts/dist/build/libffi.so.6 #8 0x00007fffeec18336 in ffi_call () from /opt/exp/ghc/ghc-landing/rts/dist/build/libffi.so.6 #9 0x00007fffeee460d6 in interpretBCO (cap=0x7fffef08ba40 <MainCapability>) at rts/Interpreter.c:1697 #10 0x00007fffeee3f3e2 in schedule (initialCapability=<optimized out>, task=task@entry=0x754e90) at rts/Schedule.c:471 #11 0x00007fffeee404fc in scheduleWorker (cap=<optimized out>, task=0x754e90) at rts/Schedule.c:2574 #12 0x00007fffee1bf494 in start_thread (arg=0x7fffe77fe700) at pthread_create.c:333 #13 0x00007fffed76faff in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:97
Address some of comments
Alright, I think this looks reasonable.
Merged with b9f9670c8cf4eac8798a8cb3e683d0411f9e94ec.
I also wonder whether it would be good to move this below (or perhaps even merge this into) Note [AbsBinds] (also in this module).
Sun, Jun 18
Sat, Jun 17
This looks great. However, can I ask you for a short note listing the various image formats that we support and when we expect to find them (perhaps with references to tickets as appropriate)?
@hvr, any objection here?
It turns out that I was wrong; @duog points out that the issue which I describe in the ticket actually isn't an issue.
Fri, Jun 16