bgamari (Ben Gamari)Administrator
Blub... blub... blub...

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

Badges

User Since
Jul 20 2014, 6:05 AM (140 w, 9 h)
Roles
Administrator
Availability
Available

I like working on GHC. 'tis all I have to say.

Recent Activity

Yesterday

bgamari updated the diff for D3380: Various testsuite updates for 32-bit.
  • Bump array submodule
Sat, Mar 25, 9:52 AM

Fri, Mar 24

bgamari retitled D3380: Various testsuite updates for 32-bit from testsuite: Make T10245 pass on 32-bit platforms to Various testsuite updates for 32-bit.
Fri, Mar 24, 10:15 PM
bgamari created D3380: Various testsuite updates for 32-bit.
Fri, Mar 24, 10:15 PM
bgamari added a comment to D2973: PPC NCG: Implement callish prim ops.

@hvr, can you have a look at this? It would be good to get poor
@trommler off the hook for rebasing this.

Fri, Mar 24, 11:41 AM
bgamari committed rGHCbe8122ab72ae: testsuite: Add testcase for #13429 (authored by bgamari).
testsuite: Add testcase for #13429
Fri, Mar 24, 9:54 AM
bgamari committed rGHC27c9a7d095d2: testsuite: Add failing testcase for #13233 (authored by bgamari).
testsuite: Add failing testcase for #13233
Fri, Mar 24, 9:54 AM
bgamari committed rGHCee7241cfde45: Document hithertoo undocumented HPCTIXFILE option. (authored by ezyang).
Document hithertoo undocumented HPCTIXFILE option.
Fri, Mar 24, 9:54 AM
bgamari closed D3357: Document hithertoo undocumented HPCTIXFILE option. by committing rGHCee7241cfde45: Document hithertoo undocumented HPCTIXFILE option. (authored by ezyang).
Fri, Mar 24, 9:54 AM
bgamari committed rGHCcaf94b062a0e: x86 nativeGen: Fix test with mask in range [128,255] (#13425) (authored by rwbarton).
x86 nativeGen: Fix test with mask in range [128,255] (#13425)
Fri, Mar 24, 9:54 AM
bgamari closed D3359: x86 nativeGen: Fix test with mask in range [128,255] (#13425) by committing rGHCcaf94b062a0e: x86 nativeGen: Fix test with mask in range [128,255] (#13425) (authored by rwbarton).
Fri, Mar 24, 9:54 AM
bgamari committed rGHC8429a202ec8a: Cmm: remove a few unused type aliases (authored by michalt).
Cmm: remove a few unused type aliases
Fri, Mar 24, 9:15 AM
bgamari closed D3372: Cmm: remove a few unused type aliases by committing rGHC8429a202ec8a: Cmm: remove a few unused type aliases (authored by michalt).
Fri, Mar 24, 9:15 AM
bgamari committed rGHC5671e22e913c: Improve tracing in OccurAnal (authored by mpickering).
Improve tracing in OccurAnal
Fri, Mar 24, 9:15 AM
bgamari closed D3371: Improve tracing in OccurAnal by committing rGHC5671e22e913c: Improve tracing in OccurAnal (authored by mpickering).
Fri, Mar 24, 9:14 AM
bgamari committed rGHCadf27d614f8a: Allow colors to be customized (authored by Rufflewind).
Allow colors to be customized
Fri, Mar 24, 12:35 AM
bgamari committed rGHC1b374402a7a0: config.mk.in: Add bzip, gzip, and xz executable names to be overridden (authored by bgamari).
config.mk.in: Add bzip, gzip, and xz executable names to be overridden
Fri, Mar 24, 12:35 AM
bgamari closed D3364: Allow colors to be customized by committing rGHCadf27d614f8a: Allow colors to be customized (authored by Rufflewind).
Fri, Mar 24, 12:35 AM
bgamari closed D3367: config.mk.in: Add bzip, gzip, and xz executable names to be overridden by committing rGHC1b374402a7a0: config.mk.in: Add bzip, gzip, and xz executable names to be overridden.
Fri, Mar 24, 12:35 AM
bgamari committed rGHC90d9e977224f: Bump haddock submodule (authored by bgamari).
Bump haddock submodule
Fri, Mar 24, 12:35 AM

Thu, Mar 23

bgamari accepted D3366: spectral/sphere: simplify Makefile.

Looks reasonable.

Thu, Mar 23, 10:01 PM
bgamari accepted D3376: Remove unused argument from importSuggestions.

Sounds good to me.

Thu, Mar 23, 9:55 PM
bgamari updated the diff for D3350: Drop dead code in rts/{Prelude.h,package.conf.in}.

Rebase

Thu, Mar 23, 8:05 PM

Wed, Mar 22

bgamari accepted D3372: Cmm: remove a few unused type aliases.

Thanks!

Wed, Mar 22, 8:05 PM
bgamari accepted D3370: Make unsafeInterleaveST less unsafe.

Looks good to me.

Wed, Mar 22, 3:59 PM

Tue, Mar 21

bgamari committed rGHC8ef3a3cabfa8: testsuite: Bump performance test allocations (authored by bgamari).
testsuite: Bump performance test allocations
Tue, Mar 21, 7:25 PM
bgamari committed rGHC25b2c1b22d1b: Bump unix submodule (authored by bgamari).
Bump unix submodule
Tue, Mar 21, 7:24 PM
bgamari accepted D3371: Improve tracing in OccurAnal.

Looks fine to me.

Tue, Mar 21, 12:52 PM
bgamari requested changes to D3278: Enable new warning for fragile/incorrect CPP #if usage.

Requesting changes on account of testsuite failures.

Tue, Mar 21, 12:51 PM
bgamari committed rGHCb3f7e9b54d9f: users-guide: Document TemplateHaskell availability (authored by bgamari).
users-guide: Document TemplateHaskell availability
Tue, Mar 21, 9:53 AM
bgamari committed rGHCba293130a716: No join-point from an INLINE function with wrong arity (authored by simonpj).
No join-point from an INLINE function with wrong arity
Tue, Mar 21, 9:53 AM
bgamari committed rGHC81abf7b4da85: Improve Lint a little (authored by simonpj).
Improve Lint a little
Tue, Mar 21, 9:53 AM
bgamari committed rGHC6c41ed6e7994: Remove solveSomeEqualities (authored by goldfire).
Remove solveSomeEqualities
Tue, Mar 21, 9:52 AM
bgamari committed rGHCd40d5e8b40a1: Test #13435 in typecheck/should_run/T13435 (authored by goldfire).
Test #13435 in typecheck/should_run/T13435
Tue, Mar 21, 9:52 AM
bgamari committed rGHC32c9abee8304: Fix #13343 by not defaulting SigTvs (authored by goldfire).
Fix #13343 by not defaulting SigTvs
Tue, Mar 21, 9:52 AM
bgamari committed rGHC4c6a016900b0: Fix #13202 by failing more eagerly in tcRnStmt (authored by goldfire).
Fix #13202 by failing more eagerly in tcRnStmt
Tue, Mar 21, 9:52 AM
bgamari committed rGHCdb0111cd458e: Comment coercion flattening [skip ci] (authored by goldfire).
Comment coercion flattening [skip ci]
Tue, Mar 21, 9:52 AM
bgamari committed rGHCae6e63aa858d: Fix #12709 by not building bad applications (authored by goldfire).
Fix #12709 by not building bad applications
Tue, Mar 21, 9:52 AM
bgamari committed rGHC2251905024f9: Never tick primitive string literals (authored by bgamari).
Never tick primitive string literals
Tue, Mar 21, 9:52 AM
bgamari added a reverting commit for rGHCf5b275a239d2: Don't tick top-level string literals: rGHC2251905024f9: Never tick primitive string literals.
Tue, Mar 21, 9:52 AM
bgamari committed rGHCe4620dc7d2b5: genSym: Fix DEBUG build (authored by bgamari).
genSym: Fix DEBUG build
Tue, Mar 21, 9:52 AM
bgamari committed rGHC46c368964cb1: Revert "Fix cost-centre-stacks bug (#5654)" (authored by bgamari).
Revert "Fix cost-centre-stacks bug (#5654)"
Tue, Mar 21, 9:52 AM
bgamari added a reverting commit for rGHC394231b301ef: Fix cost-centre-stacks bug (#5654): rGHC46c368964cb1: Revert "Fix cost-centre-stacks bug (#5654)".
Tue, Mar 21, 9:52 AM
bgamari added a reverting commit for rGHC2a02040b2e23: Fix bug in previous fix for #5654: rGHC58f055dae77a: Revert "Fix bug in previous fix for #5654".
Tue, Mar 21, 9:52 AM
bgamari committed rGHC58f055dae77a: Revert "Fix bug in previous fix for #5654" (authored by bgamari).
Revert "Fix bug in previous fix for #5654"
Tue, Mar 21, 9:52 AM
bgamari committed rGHCb0cac3904624: Revert "More fixes for #5654" (authored by bgamari).
Revert "More fixes for #5654"
Tue, Mar 21, 9:52 AM
bgamari added a reverting commit for rGHC3a18baff06ab: More fixes for #5654: rGHCb0cac3904624: Revert "More fixes for #5654".
Tue, Mar 21, 9:52 AM

Sun, Mar 19

bgamari committed rGHC9c041294e5ac: users-guide: Document TemplateHaskell availability (authored by bgamari).
users-guide: Document TemplateHaskell availability
Sun, Mar 19, 1:49 PM
bgamari committed rGHCd744c8645e77: genSym: Fix DEBUG build (authored by bgamari).
genSym: Fix DEBUG build
Sun, Mar 19, 1:49 PM
bgamari committed rGHC105a5f47e579: Update link to paper about demand analyser in user guide (authored by mpickering).
Update link to paper about demand analyser in user guide
Sun, Mar 19, 1:49 PM
bgamari closed D3354: Update link to paper about demand analyser in user guide by committing rGHC105a5f47e579: Update link to paper about demand analyser in user guide (authored by mpickering).
Sun, Mar 19, 1:49 PM
bgamari created D3367: config.mk.in: Add bzip, gzip, and xz executable names to be overridden.
Sun, Mar 19, 1:43 PM
bgamari requested changes to D3246: Revise list fusion for and, or, all, any, elem, notElem (#13351).

Bumping out of review queue due to apparent nofib regressions. Let me know when you would like a review, @nomeata!

Sun, Mar 19, 10:13 AM
bgamari accepted D3364: Allow colors to be customized.

Thanks @Rufflewind!

Sun, Mar 19, 10:12 AM

Sat, Mar 18

bgamari requested changes to D3364: Allow colors to be customized.

Thanks for the refactoring! Looks good to me except for the validation issues.

Sat, Mar 18, 9:30 PM
bgamari accepted D3360: OccurAnal.hs: Add an assert for an invariant.

Frankly, this check is cheap enough that I wonder whether it might be better to simply always perform it.

Sat, Mar 18, 7:40 PM
bgamari accepted D3357: Document hithertoo undocumented HPCTIXFILE option..
In D3357#96572, @dfeuer wrote:

I don't mind documenting this in principle, but the whole thing smells a bit funny; it would be even better to fix the funny smell than to just note it. Why don't we have an RTS option for this and allow it to be set at compile time using -with-rtsopts? Are other RTS options controlled by environment variables? If not, maybe this shouldn't be either.

Sat, Mar 18, 7:38 PM
bgamari added inline comments to D3358: base: Implement bit casts between word and float types.
Sat, Mar 18, 7:37 PM

Thu, Mar 16

bgamari requested changes to D3239: rts linker: Introduce MachOTypes.
Thu, Mar 16, 9:18 PM
bgamari accepted D3238: Make mmap r+w only during preload for iOS..

Alright, this seems reasonable enough although we should do the same for the other architectures soon.

Thu, Mar 16, 7:29 PM
bgamari accepted D3340: Let GHC know MutVar# ops can't fail.

Righto.

Thu, Mar 16, 10:14 AM
bgamari requested changes to D3348: Check TargetPlatform instead of HostPlatform for leading underscore.

I think we should reassess the point of this check and name it more appropriately. It looks like we primarily use FP_LEADING_UNDERSCORE to form symbols names in the RTS. In light of this, I would have thought that this should be named FP_LEADING_UNDERSCORE_TARGET.

Thu, Mar 16, 10:13 AM
bgamari requested changes to D3349: [libffi] use master..

Indeed I remember this being necessary. I don't know what to do about this. I'm really not excited about this approach. For one, it introduces a git dependency into the build system. Secondly, it pulls down untrusted code from the Internet (I would at very least freeze us at a particular commit so we know what we are getting).

Thu, Mar 16, 10:01 AM
bgamari added a comment to D3352: Replace opt and llc with clang.
In D3352#96309, @erikd wrote:

You get clang as part of the llvm suite (http://releases.llvm.org/download.html) it is often broken into clang and tools, as you do not necessarily need the tools, unless you want to do something very specific.

Up until now, I have just installed what LLVM (and also Clang) version is needed from the Debian repositories. Debian provides packages for multiple versions of LLVM and the can install in parallel.

I don't believe this patch changes this. You can use GHC against Debian's clang, just as you can use it against Debian's llc and opt.

Thu, Mar 16, 9:57 AM

Wed, Mar 15

bgamari committed rGHC2fd283bf46ed: Bump unix submodule (authored by bgamari).
Bump unix submodule
Wed, Mar 15, 8:29 PM
bgamari committed rGHC6ebfbdfb64cb: Bump hsc2hs submodule (authored by bgamari).
Bump hsc2hs submodule
Wed, Mar 15, 6:09 PM
bgamari committed rGHCd18d3d9461cf: Decrease locked region size on Windows to fix ERROR_LOCK_INVALID_RANGE (authored by arybczak).
Decrease locked region size on Windows to fix ERROR_LOCK_INVALID_RANGE
Wed, Mar 15, 6:09 PM
bgamari committed rGHCba4310510dde: Bump hsc2hs submodule (authored by bgamari).
Bump hsc2hs submodule
Wed, Mar 15, 5:32 PM
bgamari committed rNOFIB7d7bc03c3850: real/Makefile: remove OTHER_SUBDIRS (authored by michalt).
real/Makefile: remove OTHER_SUBDIRS
Wed, Mar 15, 4:53 PM
bgamari closed D3342: real/Makefile: remove OTHER_SUBDIRS by committing rNOFIB7d7bc03c3850: real/Makefile: remove OTHER_SUBDIRS (authored by michalt).
Wed, Mar 15, 4:53 PM
bgamari committed rNOFIBdd21f6bb1da7: fibheaps/Makefile: remove some weird character (authored by michalt).
fibheaps/Makefile: remove some weird character
Wed, Mar 15, 4:53 PM
bgamari closed D3344: fibheaps/Makefile: remove some weird character by committing rNOFIBdd21f6bb1da7: fibheaps/Makefile: remove some weird character (authored by michalt).
Wed, Mar 15, 4:53 PM
bgamari committed rNOFIB47f132de2885: spectral: temporarily disable secretary (authored by michalt).
spectral: temporarily disable secretary
Wed, Mar 15, 4:53 PM
bgamari closed D3347: spectral: temporarily disable secretary by committing rNOFIB47f132de2885: spectral: temporarily disable secretary (authored by michalt).
Wed, Mar 15, 4:53 PM
bgamari committed rGHC1cbc7c315fb6: Bump nofib submodule (authored by bgamari).
Bump nofib submodule
Wed, Mar 15, 4:50 PM
bgamari committed rGHC7e273ea28fe3: Decrease locked region size on Windows to fix ERROR_LOCK_INVALID_RANGE (authored by arybczak).
Decrease locked region size on Windows to fix ERROR_LOCK_INVALID_RANGE
Wed, Mar 15, 2:26 PM
bgamari committed rGHCcec90709c9c8: Bump hsc2hs submodule (authored by bgamari).
Bump hsc2hs submodule
Wed, Mar 15, 2:26 PM
bgamari closed D3345: Decrease locked region size on Windows to fix ERROR_LOCK_INVALID_RANGE by committing rGHC7e273ea28fe3: Decrease locked region size on Windows to fix ERROR_LOCK_INVALID_RANGE (authored by arybczak).
Wed, Mar 15, 2:26 PM
bgamari committed rGHC086b514b199c: Introduce putLogMsg (authored by bgamari).
Introduce putLogMsg
Wed, Mar 15, 2:26 PM
bgamari committed rGHCcc9d574a5780: Introduce and use EnumSet in DynFlags (authored by bgamari).
Introduce and use EnumSet in DynFlags
Wed, Mar 15, 2:26 PM
bgamari closed D3334: Introduce putLogMsg by committing rGHC086b514b199c: Introduce putLogMsg.
Wed, Mar 15, 2:25 PM
bgamari committed rGHCa7be163196f4: Always build GHCi libs (authored by simonmar).
Always build GHCi libs
Wed, Mar 15, 2:25 PM
bgamari closed D3331: Introduce and use EnumSet in DynFlags by committing rGHCcc9d574a5780: Introduce and use EnumSet in DynFlags.
Wed, Mar 15, 2:25 PM
bgamari closed D3298: RFC: Always build GHCi libs by committing rGHCa7be163196f4: Always build GHCi libs (authored by simonmar).
Wed, Mar 15, 2:25 PM
bgamari committed rGHC899fb8808da8: testsuite: Bump margin of T4029 to 15% (authored by bgamari).
testsuite: Bump margin of T4029 to 15%
Wed, Mar 15, 2:25 PM
bgamari committed rGHC59f72c9a5554: Bump hsc2hs submodule (authored by bgamari).
Bump hsc2hs submodule
Wed, Mar 15, 12:17 PM
bgamari committed rGHC7596efd6d253: Further document :type +v's role in analyzing -XTypeApplications in GHCi (authored by RyanGlScott).
Further document :type +v's role in analyzing -XTypeApplications in GHCi
Wed, Mar 15, 10:44 AM
bgamari committed rGHCe71c9c863c3e: testsuite: Sort out a few performance failures (authored by bgamari).
testsuite: Sort out a few performance failures
Wed, Mar 15, 10:44 AM
bgamari committed rGHC018ac7f4b2f7: Fix Windows GCC driver (authored by Phyx).
Fix Windows GCC driver
Wed, Mar 15, 10:44 AM
bgamari committed rGHCe59b602657d9: testsuite: Fix peak_megabytes_allocated for T4029 (authored by bgamari).
testsuite: Fix peak_megabytes_allocated for T4029
Wed, Mar 15, 10:44 AM
bgamari committed rGHC109a2429493c: Fix #13337. (authored by goldfire).
Fix #13337.
Wed, Mar 15, 10:44 AM
bgamari committed rGHC98692134c3ae: Fix constraint simplification in rules (authored by simonpj).
Fix constraint simplification in rules
Wed, Mar 15, 8:19 AM
bgamari committed rGHCbb51a99bb553: Update test output (authored by bgamari).
Update test output
Wed, Mar 15, 8:19 AM
bgamari committed rGHC8a526c1ca4dc: Define TcSimplify.simplifyTopImplic and use it (authored by simonpj).
Define TcSimplify.simplifyTopImplic and use it
Wed, Mar 15, 8:19 AM
bgamari committed rGHC026189aa7249: Improve error messages for skolems (authored by simonpj).
Improve error messages for skolems
Wed, Mar 15, 8:18 AM
bgamari committed rGHC82366c4c1501: Allow associated types to pattern-match in non-class-bound variables (authored by RyanGlScott).
Allow associated types to pattern-match in non-class-bound variables
Wed, Mar 15, 8:18 AM
bgamari committed rGHCdfd8f29eced6: Fix CaseIdentity optimisation AGAIN (authored by simonpj).
Fix CaseIdentity optimisation AGAIN
Wed, Mar 15, 8:18 AM
bgamari committed rGHC7ace4f0c377d: Fix #13382: Put join ceiling underneath lambdas (authored by lukemaurer).
Fix #13382: Put join ceiling underneath lambdas
Wed, Mar 15, 8:18 AM

Tue, Mar 14

bgamari added a comment to D3337: Make standalone DeriveAnyClass as permissive as empty instances.

Indeed it seems I misread the ticket. Ignore my previous comment.

Tue, Mar 14, 10:40 PM
bgamari added a comment to D3337: Make standalone DeriveAnyClass as permissive as empty instances.
In D3337#96183, @dfeuer wrote:

I'm having trouble understanding exactly what the point of all this is. Does allowing unconventional derived instances *itself* simplify any internal story? I don't see that. Is there some particular application in mind? Can't users just leave out the deriving?

Tue, Mar 14, 9:33 PM
bgamari accepted D3298: RFC: Always build GHCi libs.

Alright. Sounds reasonable to me. I'll merge to 8.2 as well.

Tue, Mar 14, 6:04 PM