bgamari (Ben Gamari)Administrator
Blub... blub... blub...

User Details

User Since
Jul 20 2014, 6:05 AM (229 w, 2 d)
Roles
Administrator

I like working on GHC. 'tis all I have to say.

Recent Activity

Today

bgamari added a comment to D5285: Warn about unused packages.
In D5285#149745, @Yuras wrote:

Throw a warning if -Wunused-packages is used without -fforce-recomp.

@bgamari I don't think it is a good idea because often the warning will be enabled on CI. So user is doing a clean build anyway, and the warning on -fforce-recomp will be completely wrong and annoying.

Tue, Dec 11, 5:45 PM
bgamari requested changes to D5369: RetainerProfiler: Update retainer profiler debugging.

Is this actually rebased on master? It still doesn't appear to apply to master.

Tue, Dec 11, 5:42 PM
bgamari accepted D5369: RetainerProfiler: Update retainer profiler debugging.

Thanks!

Tue, Dec 11, 5:39 PM
bgamari accepted D5299: Fix recompilation checking of pure plugins.
Tue, Dec 11, 5:39 PM
bgamari committed rGHC65fb69b78f48: testsuite: Mark linkwhole as broken on FreeBSD (authored by bgamari).
testsuite: Mark linkwhole as broken on FreeBSD
Tue, Dec 11, 5:22 PM
bgamari committed rGHC4faab14bcf8a: testsuite: Skip T703 on non-Linux platforms (authored by bgamari).
testsuite: Skip T703 on non-Linux platforms
Tue, Dec 11, 5:22 PM
bgamari committed rGHC847e8b60ff1f: testsuite: Mark keep-cafs and keep-cafs-fail as broken on FreeBSD (authored by bgamari).
testsuite: Mark keep-cafs and keep-cafs-fail as broken on FreeBSD
Tue, Dec 11, 5:22 PM
bgamari committed rGHCe98d220601fb: testsuite: Don't use sed -i in T15369 (authored by bgamari).
testsuite: Don't use sed -i in T15369
Tue, Dec 11, 5:22 PM
bgamari committed rGHC8a4edd15d878: Enable rebindable fail with overloaded strings (authored by shayne-fletcher-da).
Enable rebindable fail with overloaded strings
Tue, Dec 11, 5:22 PM
bgamari committed rGHC003ab6a1288e: testsuite: Ensure that unregisterised function is called (authored by bgamari).
testsuite: Ensure that unregisterised function is called
Tue, Dec 11, 5:22 PM
bgamari committed rGHCc98e25a4de88: Explicitly pass -fno-PIC to C compiler on linux (authored by watashi).
Explicitly pass -fno-PIC to C compiler on linux
Tue, Dec 11, 5:22 PM
bgamari committed rGHCf582379de2c4: Support generating HIE files (authored by harpocrates).
Support generating HIE files
Tue, Dec 11, 5:22 PM
bgamari closed D5251: enable rebindable fail with overloaded strings.
Tue, Dec 11, 5:22 PM
bgamari committed rGHC18b74cdbbfa0: testsuite: Add tests for #15270 (authored by bgamari).
testsuite: Add tests for #15270
Tue, Dec 11, 5:22 PM
bgamari closed D5288: Explicitly pass -fno-PIC to C compiler on linux.
Tue, Dec 11, 5:22 PM
bgamari committed rGHC21339c9f6bfb: RTS linker: don't crash early when not finding extra-libraries (authored by awson).
RTS linker: don't crash early when not finding extra-libraries
Tue, Dec 11, 5:22 PM
bgamari closed D5239: Support generating HIE files.
Tue, Dec 11, 5:22 PM
bgamari closed D5216: testsuite: Add tests for #15270.
Tue, Dec 11, 5:22 PM
bgamari closed D5170: RTS linker: don't crash early when not finding extra DLL, most likely it's not needed.
Tue, Dec 11, 5:22 PM
bgamari committed rGHCd549c081f199: dmdAnal: Move handling of datacon strictness to mkWWstr_one (authored by bgamari).
dmdAnal: Move handling of datacon strictness to mkWWstr_one
Tue, Dec 11, 5:22 PM
bgamari committed rGHCda05d79d03e5: Support registering Plugins through the GHC API (authored by DanielG).
Support registering Plugins through the GHC API
Tue, Dec 11, 5:22 PM
bgamari committed rGHC9e7d58c89457: PPC NCG: Generate MO_?_QuotRem for subword sizes (authored by trommler).
PPC NCG: Generate MO_?_QuotRem for subword sizes
Tue, Dec 11, 5:22 PM
bgamari closed D5226: dmdAnal: Move handling of datacon strictness to mkWWstr_one.
Tue, Dec 11, 5:22 PM
bgamari committed rGHC9e763afa9f1f: PPC NCG: Implement MachOps for smaller sizes (authored by trommler).
PPC NCG: Implement MachOps for smaller sizes
Tue, Dec 11, 5:22 PM
bgamari closed D5323: PPC NCG: Generate MO_?_QuotRem for subword sizes.
Tue, Dec 11, 5:22 PM
bgamari closed D5278: Support registering Plugins through the GHC API.
Tue, Dec 11, 5:22 PM
bgamari committed rGHC54ee148c2b28: Do not save performance test results if worktree is dirty. (authored by DavidEichmann).
Do not save performance test results if worktree is dirty.
Tue, Dec 11, 5:22 PM
bgamari committed rGHC4c174dddc7b3: Misleading msg with qualified imports "No module named X imported" (authored by RolandSenn).
Misleading msg with qualified imports "No module named X imported"
Tue, Dec 11, 5:22 PM
bgamari closed D5300: PPC NCG: Implement MachOps for smaller sizes.
Tue, Dec 11, 5:21 PM
bgamari committed rGHC288f681e06ac: Fix recompilation bug with default class methods (#15970) (authored by simonmar).
Fix recompilation bug with default class methods (#15970)
Tue, Dec 11, 5:21 PM
bgamari closed D5368: Do not save performance test results if worktree is dirty..
Tue, Dec 11, 5:21 PM
bgamari closed D5331: Misleading msg with qualified imports "No module named X imported".
Tue, Dec 11, 5:21 PM
bgamari committed rGHC0136906c9e69: Fix uninformative hp2ps error when the cmdline contains double quotes (authored by watashi).
Fix uninformative hp2ps error when the cmdline contains double quotes
Tue, Dec 11, 5:21 PM
bgamari committed rGHC0ff5ecfbc543: cosmetic change: expandtab in utils/hp2ps/HpFile.c (authored by watashi).
cosmetic change: expandtab in utils/hp2ps/HpFile.c
Tue, Dec 11, 5:21 PM
bgamari closed D5394: Fix recompilation bug with default class methods (#15970).
Tue, Dec 11, 5:21 PM
bgamari committed rGHCd7cb230ad878: circleci: ignore gitlab branches for all jobs in the validate workflow (authored by alpmestan).
circleci: ignore gitlab branches for all jobs in the validate workflow
Tue, Dec 11, 5:21 PM
bgamari closed D5388: Fix uninformative hp2ps error when the cmdline contains double quotes.
Tue, Dec 11, 5:21 PM
bgamari closed D5407: cosmetic change: expandtab in utils/hp2ps/HpFile.c.
Tue, Dec 11, 5:21 PM
bgamari committed rGHCa5e76a073afc: Hadrian: ability to run a subset of the testsuite (authored by alpmestan).
Hadrian: ability to run a subset of the testsuite
Tue, Dec 11, 5:21 PM
bgamari committed rGHC7491cedb20d1: Hadrian: simple targets for building libraries and executables (authored by alpmestan).
Hadrian: simple targets for building libraries and executables
Tue, Dec 11, 5:21 PM
bgamari closed D5429: circleci: ignore gitlab branches for all jobs in the validate workflow.
Tue, Dec 11, 5:21 PM
bgamari committed rGHC066d3989a450: configure: Don't use ln -v (authored by bgamari).
configure: Don't use ln -v
Tue, Dec 11, 5:21 PM
bgamari closed D5431: Hadrian: ability to run a subset of the testsuite.
Tue, Dec 11, 5:21 PM
bgamari closed D5434: Hadrian: simple targets for building libraries and executables.
Tue, Dec 11, 5:21 PM
bgamari committed rGHC015dd8ab64e2: Add +RTS -F to the --help output (authored by simonmar).
Add +RTS -F to the --help output
Tue, Dec 11, 5:21 PM
bgamari committed rGHC4efafe7e5288: Revert dynamically linking ghc. (authored by DavidEichmann).
Revert dynamically linking ghc.
Tue, Dec 11, 5:21 PM
bgamari closed D5425: configure: Don't use ln -v.
Tue, Dec 11, 5:21 PM
bgamari closed D5428: Add +RTS -F to the --help output.
Tue, Dec 11, 5:21 PM
bgamari committed rGHC50f0cd4647ff: circleci: Add integer-simple build target (authored by bgamari).
circleci: Add integer-simple build target
Tue, Dec 11, 5:21 PM
bgamari closed D5430: Revert dynamically linking ghc..
Tue, Dec 11, 5:21 PM
bgamari accepted D5433: Introduce GhciMonad and generalize types of functions in GHCi.UI.

The long term plan is to move reusable bits to ghci library and make it
easier to build a customized interactive ui which carries customized state
and provides customized commands.

Tue, Dec 11, 12:54 PM
bgamari accepted D5170: RTS linker: don't crash early when not finding extra DLL, most likely it's not needed.

Alright, this looks okay to me. Thanks for sticking with it @awson!

Tue, Dec 11, 12:45 PM
bgamari requested changes to D5205: Refactor NewHsTypeX to DerivedCoreTy.

It looks like there is more to be done here.

Tue, Dec 11, 12:40 PM
bgamari requested changes to D5270: Hadrian: merge sections in profiling _p.a to .p_o for ghci.

Can you rebase this @watashi?

Tue, Dec 11, 12:30 PM
bgamari requested changes to D5278: Support registering Plugins through the GHC API.

Alright, looks good. Let's merge this.

Tue, Dec 11, 12:24 PM
bgamari added a comment to D5286: Run typed splices in the zonker.

@goldfire, perhaps you could have one final look over this?

Tue, Dec 11, 12:23 PM
bgamari abandoned D5309: distrib/configure: Set RanlibCmd.

Merged in 0a126a32d1bbdb3bb70030a77e01415e19ea8b6e.

Tue, Dec 11, 12:22 PM
bgamari accepted D5323: PPC NCG: Generate MO_?_QuotRem for subword sizes.

Yes, looks good to me.

Tue, Dec 11, 12:21 PM
bgamari accepted D5331: Misleading msg with qualified imports "No module named X imported".
Tue, Dec 11, 12:20 PM
bgamari accepted D5368: Do not save performance test results if worktree is dirty..

Looks good! Thanks.

Tue, Dec 11, 12:19 PM
bgamari accepted D5394: Fix recompilation bug with default class methods (#15970).

Looks good to me.

Tue, Dec 11, 12:19 PM
bgamari accepted D5431: Hadrian: ability to run a subset of the testsuite.

Great documentation!

Tue, Dec 11, 12:11 PM
bgamari abandoned D5436: rts: Disable fallthrough attribute when compiling with Clang.
Tue, Dec 11, 12:10 PM
bgamari added a comment to D5436: rts: Disable fallthrough attribute when compiling with Clang.

Merged with 6a71add81d8f30b0caca0e869fb8e35787881c87.

Tue, Dec 11, 12:09 PM
bgamari accepted D5434: Hadrian: simple targets for building libraries and executables.

Thank you for doing this, @alpmestan. This looks great!

Tue, Dec 11, 12:06 PM
bgamari accepted D5439: Use unicode arrows with -fprint-unicode-syntax.

Sure.

Tue, Dec 11, 12:05 PM
bgamari requested changes to D5369: RetainerProfiler: Update retainer profiler debugging.

Can you rebase this, @qnikst?

Tue, Dec 11, 12:04 PM
bgamari committed rGHC4b3022021d49: testsuite: Mark tickets identified in #15467 as broken (authored by bgamari).
testsuite: Mark tickets identified in #15467 as broken
Tue, Dec 11, 9:07 AM
bgamari committed rGHC6a71add81d8f: rts: Disable fallthrough attribute when compiling with Clang (authored by bgamari).
rts: Disable fallthrough attribute when compiling with Clang
Tue, Dec 11, 9:06 AM
bgamari committed rGHCe709c8f8d45c: utils/gen-dll: Bump containers upper bound (authored by bgamari).
utils/gen-dll: Bump containers upper bound
Tue, Dec 11, 9:06 AM
bgamari committed rGHC6eab7cda23b5: CircleCI: Add configurations for Centos 7 and Debian 9 (authored by bgamari).
CircleCI: Add configurations for Centos 7 and Debian 9
Tue, Dec 11, 9:06 AM
bgamari committed rGHC3ab8234a9735: testsuite: Use explicit -e in sed command (authored by bgamari).
testsuite: Use explicit -e in sed command
Tue, Dec 11, 9:05 AM

Yesterday

bgamari created D5436: rts: Disable fallthrough attribute when compiling with Clang.
Mon, Dec 10, 8:50 PM
bgamari added a comment to D5431: Hadrian: ability to run a subset of the testsuite.

Where else do you want this to be documented?

There is a README plus some files in the doc directory in Hadrian, where we could be documenting the build system, and where the information about the testsuite could go. This has the benefit of being tracked together with the code/patches etc., so it's less likely to go out of date. However, it seems that documenting things on Trac is a lot more common among GHC developers, so I'm not sure what's the right answer is.

If the answer is: we document everything on Trac, then I guess we should just delete the README and doc/* since they will go out of date very quickly.

Mon, Dec 10, 6:42 PM
bgamari added a comment to D5430: Revert dynamically linking ghc..

Do we know what the actual issue is here? Are we certain that D5427 doesn't fix it?

Mon, Dec 10, 2:41 PM
bgamari requested changes to D5431: Hadrian: ability to run a subset of the testsuite.

Thank you for doing this!

Mon, Dec 10, 2:40 PM

Sun, Dec 9

bgamari added reviewers for D5427: hadrian: Only link against libffi when it is needed for adjustors: DavidEichmann, snowleopard.
Sun, Dec 9, 6:31 PM
bgamari created D5427: hadrian: Only link against libffi when it is needed for adjustors.
Sun, Dec 9, 9:07 AM

Sat, Dec 8

bgamari committed rGHCc00d2f59df1f: hadrian: Drop nix build script (authored by bgamari).
hadrian: Drop nix build script
Sat, Dec 8, 1:12 PM
bgamari added a parent revision for D5299: Fix recompilation checking of pure plugins: D5278: Support registering Plugins through the GHC API.
Sat, Dec 8, 12:51 PM
bgamari added a child revision for D5278: Support registering Plugins through the GHC API: D5299: Fix recompilation checking of pure plugins.
Sat, Dec 8, 12:51 PM
bgamari committed rGHCf5bff4bc2325: testsuite: 32-bit expected output for T15460 (authored by bgamari).
testsuite: 32-bit expected output for T15460
Sat, Dec 8, 8:37 AM

Fri, Dec 7

bgamari committed rGHC64ef4d7fb131: rts: Ensure that task->id is initialized (authored by bgamari).
rts: Ensure that task->id is initialized
Fri, Dec 7, 11:05 PM
bgamari committed rGHCaa619f39e39b: Use --no-as-needed with LLD too (authored by simonmar).
Use --no-as-needed with LLD too
Fri, Dec 7, 11:05 PM
bgamari closed D5325: rts: Ensure that task->id is initialized.
Fri, Dec 7, 11:05 PM
bgamari committed rGHC45e98f64e82f: Add -fno-safe-haskell flag (authored by mpickering).
Add -fno-safe-haskell flag
Fri, Dec 7, 11:05 PM
bgamari closed D5336: Use --no-as-needed with LLD too.
Fri, Dec 7, 11:05 PM
bgamari committed rGHC04caa935ac22: Fix StgLint bound id check, generalize StgLint (authored by osa1).
Fix StgLint bound id check, generalize StgLint
Fri, Dec 7, 11:05 PM
bgamari closed D5360: Add -fno-safe-haskell flag.
Fri, Dec 7, 11:05 PM
bgamari committed rGHC57c9b1ae4caf: Fix #15369: GHCi doesn't honor :set +c when loading for a second time (authored by RolandSenn).
Fix #15369: GHCi doesn't honor :set +c when loading for a second time
Fri, Dec 7, 11:05 PM
bgamari closed D5370: Fix StgLint bound id check, generalize StgLint.
Fri, Dec 7, 11:05 PM
bgamari closed D5376: Fix #15369: GHCi doesn't honor :set +c when loading for a second time ....
Fri, Dec 7, 11:05 PM
bgamari committed rGHCc5ced679a6f5: Add haddock for Node in Digraph. [skip ci] (authored by AndreasK).
Add haddock for Node in Digraph. [skip ci]
Fri, Dec 7, 11:05 PM
bgamari committed rGHCa24ab444c1b2: Remove redundant include of Rts.h in EventLogWriter.h (authored by watashi).
Remove redundant include of Rts.h in EventLogWriter.h
Fri, Dec 7, 11:05 PM
bgamari closed D5378: Add haddock for Node in Digraph. [skip ci].
Fri, Dec 7, 11:05 PM
bgamari committed rGHCf2bad7e1069e: Rename "changed" to "no-change" in HscMain (authored by osa1).
Rename "changed" to "no-change" in HscMain
Fri, Dec 7, 11:05 PM
bgamari closed D5395: Remove redundant include of Rts.h in EventLogWriter.h.
Fri, Dec 7, 11:05 PM
bgamari committed rGHC7d96d2816d11: Hadrian: fix dynamicGhcPrograms value for the quickest flavour (authored by alpmestan).
Hadrian: fix dynamicGhcPrograms value for the quickest flavour
Fri, Dec 7, 11:05 PM
bgamari closed D5416: Rename "changed" to "no-change" in HscMain.
Fri, Dec 7, 11:05 PM
bgamari committed rGHC38edeea990b4: Mark SRT_1/SRT_2 as CONSTR_1_0/CONSTR_2_0 (authored by osa1).
Mark SRT_1/SRT_2 as CONSTR_1_0/CONSTR_2_0
Fri, Dec 7, 11:05 PM