bgamari (Ben Gamari)Administrator
Blub... blub... blub...

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Jul 20 2014, 6:05 AM (152 w, 5 d)
Roles
Administrator
Availability
Available

I like working on GHC. 'tis all I have to say.

Recent Activity

Today

bgamari created D3669: rts: Always collect stats.
Fri, Jun 23, 4:49 PM
bgamari committed rGHCa48464a7d285: users guide: Rephrasing (authored by bgamari).
users guide: Rephrasing
Fri, Jun 23, 3:42 PM
bgamari committed rGHCfaefa7e57d54: documentation: fix trac issue #12978 (authored by erdeszt).
documentation: fix trac issue #12978
Fri, Jun 23, 3:42 PM
bgamari closed D3668: documentation: fix trac issue #12978 Add reference to TypeApplications to the AllowAmbiguousType section of the user docs by committing rGHCfaefa7e57d54: documentation: fix trac issue #12978 (authored by erdeszt).
Fri, Jun 23, 3:42 PM
bgamari accepted D3668: documentation: fix trac issue #12978 Add reference to TypeApplications to the AllowAmbiguousType section of the user docs.

Looks good to me. Thanks!

Fri, Jun 23, 3:42 PM
bgamari added a comment to D3668: documentation: fix trac issue #12978 Add reference to TypeApplications to the AllowAmbiguousType section of the user docs.

Feel free to disregard the comment; I'll try to address this myself.

Fri, Jun 23, 3:42 PM
bgamari committed rGHC8df27aaae031: testsuite: Bump Haddock performance metrics (authored by bgamari).
testsuite: Bump Haddock performance metrics
Fri, Jun 23, 2:01 PM
bgamari committed rGHCa6774e1d70f1: testsuite: Fix cabal01 for real this time (authored by bgamari).
testsuite: Fix cabal01 for real this time
Fri, Jun 23, 2:00 PM
bgamari committed rGHC0e2839a2474d: Use actual universal tvs in check for naughty record selectors (authored by mpickering).
Use actual universal tvs in check for naughty record selectors
Fri, Jun 23, 2:00 PM
bgamari committed rGHC379c07bb69d0: testsuite: Fix cabal01 test (authored by bgamari).
testsuite: Fix cabal01 test
Fri, Jun 23, 2:00 PM
bgamari committed rGHC0fa0d6c2d64d: compiler: Eliminate pprTrace in SPT entry addition codepath (authored by bgamari).
compiler: Eliminate pprTrace in SPT entry addition codepath
Fri, Jun 23, 2:00 PM
bgamari committed rGHC9057c250e303: Add missing -Wdeprecations flag to the users guide (authored by erdeszt).
Add missing -Wdeprecations flag to the users guide
Fri, Jun 23, 2:00 PM
bgamari committed rGHC05ae09c7fac3: change filtering of variables in extract_hs_tv_bndrs (fixes #13782) (authored by carlostome).
change filtering of variables in extract_hs_tv_bndrs (fixes #13782)
Fri, Jun 23, 2:00 PM
bgamari committed rGHC42eee6eac3d4: Hoopl: remove dependency on Hoopl package (authored by michalt).
Hoopl: remove dependency on Hoopl package
Fri, Jun 23, 12:10 PM
bgamari committed rGHC9077120918b7: Use actual universal tvs in check for naughty record selectors (authored by mpickering).
Use actual universal tvs in check for naughty record selectors
Fri, Jun 23, 12:10 PM
bgamari closed D3616: Hoopl: remove dependency on Hoopl package by committing rGHC42eee6eac3d4: Hoopl: remove dependency on Hoopl package (authored by michalt).
Fri, Jun 23, 12:10 PM
bgamari closed D3649: Use actual universal tvs in check for naughty record selectors by committing rGHC9077120918b7: Use actual universal tvs in check for naughty record selectors (authored by mpickering).
Fri, Jun 23, 12:10 PM
bgamari committed rGHC398a444bc673: Add fixity declaration for Data.List.NonEmpty.!! (authored by RyanGlScott).
Add fixity declaration for Data.List.NonEmpty.!!
Fri, Jun 23, 12:10 PM
bgamari committed rGHC3c4537ea1c94: Fix pretty-printing of zero-argument lambda expressions (authored by RyanGlScott).
Fix pretty-printing of zero-argument lambda expressions
Fri, Jun 23, 12:10 PM
bgamari committed rGHCe13edee31780: testsuite: Fix cabal01 test (authored by bgamari).
testsuite: Fix cabal01 test
Fri, Jun 23, 12:10 PM
bgamari closed D3664: Fix pretty-printing of zero-argument lambda expressions by committing rGHC3c4537ea1c94: Fix pretty-printing of zero-argument lambda expressions (authored by RyanGlScott).
Fri, Jun 23, 12:10 PM
bgamari closed D3666: Add fixity declaration for Data.List.NonEmpty.!! by committing rGHC398a444bc673: Add fixity declaration for Data.List.NonEmpty.!! (authored by RyanGlScott).
Fri, Jun 23, 12:10 PM
bgamari closed D3665: testsuite: Fix cabal01 test by committing rGHCe13edee31780: testsuite: Fix cabal01 test.
Fri, Jun 23, 12:10 PM
bgamari committed rGHC84cf095dc981: compiler: Eliminate pprTrace in SPT entry addition codepath (authored by bgamari).
compiler: Eliminate pprTrace in SPT entry addition codepath
Fri, Jun 23, 12:10 PM
bgamari closed D3663: compiler: Eliminate pprTrace in SPT entry addition codepath by committing rGHC84cf095dc981: compiler: Eliminate pprTrace in SPT entry addition codepath.
Fri, Jun 23, 12:09 PM
bgamari requested changes to D3523: Big-obj support for the Windows runtime linker.

Alright, bumping out of the review queue for now.

Fri, Jun 23, 10:48 AM
bgamari updated the diff for D3667: DWARF: Use .short to render half-machine-words.

Rebase

Fri, Jun 23, 10:39 AM
bgamari updated the diff for D3517: Enable -Wcpp-undef for GHC and runtime system.

Rebase

Fri, Jun 23, 10:38 AM
bgamari accepted D3666: Add fixity declaration for Data.List.NonEmpty.!!.

Sounds good to me.

Fri, Jun 23, 10:37 AM
bgamari updated the Trac tickets for D3667: DWARF: Use .short to render half-machine-words.
Fri, Jun 23, 10:34 AM
bgamari created D3667: DWARF: Use .short to render half-machine-words.
Fri, Jun 23, 9:46 AM

Yesterday

bgamari committed rGHC2ce8641a1668: Bump Haddock submodule (authored by bgamari).
Bump Haddock submodule
Thu, Jun 22, 1:42 PM
bgamari created D3665: testsuite: Fix cabal01 test.
Thu, Jun 22, 11:02 AM
bgamari committed rGHC9649420a05e6: base: Export Fingerprint accessors from Type.Reflection.Unsafe (authored by bgamari).
base: Export Fingerprint accessors from Type.Reflection.Unsafe
Thu, Jun 22, 9:35 AM
bgamari committed rGHC14ff644c45e0: Show only the number of modules in ghci (authored by bitonic).
Show only the number of modules in ghci
Thu, Jun 22, 9:35 AM
bgamari committed rGHC4f4f05a6baf2: Improve getNameToInstancesIndex (authored by Douglas Wilson <douglas.wilson@gmail.com>).
Improve getNameToInstancesIndex
Thu, Jun 22, 9:35 AM
bgamari committed rGHC9beb882cab2b: Add tcRnGetNameToInstancesIndex (authored by Douglas Wilson <douglas.wilson@gmail.com>).
Add tcRnGetNameToInstancesIndex
Thu, Jun 22, 9:35 AM

Wed, Jun 21

bgamari committed rGHC76769bdf9e42: Revert "rts: Suppress unused gcc_clear_cache warning" (authored by bgamari).
Revert "rts: Suppress unused gcc_clear_cache warning"
Wed, Jun 21, 5:02 PM
bgamari added a reverting commit for rGHCd1d3e98443cf: rts: Suppress unused gcc_clear_cache warning: rGHC76769bdf9e42: Revert "rts: Suppress unused gcc_clear_cache warning".
Wed, Jun 21, 5:02 PM
bgamari committed rGHCd1d3e98443cf: rts: Suppress unused gcc_clear_cache warning (authored by bgamari).
rts: Suppress unused gcc_clear_cache warning
Wed, Jun 21, 4:53 PM
bgamari committed rGHCc8370a821bb9: change filtering of variables in extract_hs_tv_bndrs (fixes #13782) (authored by carlostome).
change filtering of variables in extract_hs_tv_bndrs (fixes #13782)
Wed, Jun 21, 3:39 PM
bgamari closed D3641: change filtering of variables in extract_hs_tv_bndrs (fixes #13782) by committing rGHCc8370a821bb9: change filtering of variables in extract_hs_tv_bndrs (fixes #13782) (authored by carlostome).
Wed, Jun 21, 3:39 PM
bgamari committed rGHCc85cd9b2ff74: Show only the number of modules in ghci (authored by bitonic).
Show only the number of modules in ghci
Wed, Jun 21, 3:39 PM
bgamari closed D3651: Show only the number of modules in ghci by committing rGHCc85cd9b2ff74: Show only the number of modules in ghci (authored by bitonic).
Wed, Jun 21, 3:39 PM
bgamari committed rGHC88263f93e0f3: base: Export Fingerprint accessors from Type.Reflection.Unsafe (authored by bgamari).
base: Export Fingerprint accessors from Type.Reflection.Unsafe
Wed, Jun 21, 3:39 PM
bgamari closed D3660: base: Export Fingerprint accessors from Type.Reflection.Unsafe by committing rGHC88263f93e0f3: base: Export Fingerprint accessors from Type.Reflection.Unsafe.
Wed, Jun 21, 3:39 PM
bgamari requested changes to D3647: Introduce module hierarchy.

As noted on the ticket, we are going to run the propose module structure through the proposal process.

Wed, Jun 21, 2:56 PM
bgamari requested changes to D3443: [iserv] Fixing the word size for RemotePtr and toWordArray.

Just one more iteration, I promise!

Wed, Jun 21, 2:52 PM
bgamari requested changes to D2903: WIP: Register Allocator Loop Annotations.

Bumping out of the review queue. Let me know if you have any questions.

Wed, Jun 21, 2:49 PM
bgamari added inline comments to D3658: Fix Work Balance computation in RTS stats.
Wed, Jun 21, 2:47 PM
bgamari accepted D3616: Hoopl: remove dependency on Hoopl package.

Soundso good to me.

Wed, Jun 21, 2:39 PM
bgamari requested changes to D3650: [WIP] Integrating prettyprint into GHC..

I think the right approach to deal with the semigroups dependency is to make it conditional on a base_with_semigroups Cabal flag.

Wed, Jun 21, 2:38 PM
bgamari accepted D3523: Big-obj support for the Windows runtime linker.

Except for the error message wobble which I can fix on metge, looks good to me.

Wed, Jun 21, 2:33 PM
bgamari accepted D3649: Use actual universal tvs in check for naughty record selectors.

Thanks!

Wed, Jun 21, 2:30 PM
bgamari accepted D3664: Fix pretty-printing of zero-argument lambda expressions.

This seems pretty reasonable to me.

Wed, Jun 21, 2:28 PM
bgamari updated the diff for D3661: Treat banged bindings as FunBinds.
  • Disable trace
Wed, Jun 21, 11:36 AM
bgamari updated the diff for D3661: Treat banged bindings as FunBinds.
  • Fix RnBody strictness
  • Fix spelling
Wed, Jun 21, 11:13 AM
bgamari created D3663: compiler: Eliminate pprTrace in SPT entry addition codepath.
Wed, Jun 21, 11:09 AM

Tue, Jun 20

bgamari created D3661: Treat banged bindings as FunBinds.
Tue, Jun 20, 4:32 PM

Mon, Jun 19

bgamari committed rGHC986deaa55395: Add missing -Wdeprecations flag to the users guide (authored by erdeszt).
Add missing -Wdeprecations flag to the users guide
Mon, Jun 19, 10:16 AM
bgamari committed rGHC564a31f32e52: Reword documentation region overlap documentation for copying mutable arrays (authored by andrewthad).
Reword documentation region overlap documentation for copying mutable arrays
Mon, Jun 19, 10:15 AM
bgamari planned changes to D3519: [WIP] rts: Disable AdjustorAsm on soft-float PowerPC.
Mon, Jun 19, 9:56 AM
bgamari updated the diff for D3619: Allow bytecode interpreter to make unsafe foreign calls.

Use TEST_HC_OPTS_INTERACTIVE

Mon, Jun 19, 9:38 AM
bgamari added a comment to D3619: Allow bytecode interpreter to make unsafe foreign calls.

At the moment the UnsafeReenterGhci test hangs here,

#0  pthread_cond_wait@@GLIBC_2.3.2 () at ../sysdeps/unix/sysv/linux/x86_64/pthread_cond_wait.S:185
#1  0x00007fffeee62209 in waitCondition (pCond=pCond@entry=0x754ea0, pMut=pMut@entry=0x754ed0) at rts/posix/OSThreads.c:117
#2  0x00007fffeee43c33 in waitForReturnCapability (task=task@entry=0x754e90) at rts/Capability.c:714
#3  0x00007fffeee444ac in waitForCapability (pCap=pCap@entry=0x7fffe77fdc28, task=0x754e90) at rts/Capability.c:806
#4  0x00007fffeee43248 in rts_lock () at rts/RtsAPI.c:597
#5  0x00007fffe65fba21 in zdmainzdMainzdMainzuwrapzzuf () from /tmp/ghc11809_0/libghc_7.so
#6  0x00007fffec11d813 in hello () from /tmp/ghc11809_0/libghc_1.so
#7  0x00007fffeec18914 in ffi_call_unix64 () from /opt/exp/ghc/ghc-landing/rts/dist/build/libffi.so.6
#8  0x00007fffeec18336 in ffi_call () from /opt/exp/ghc/ghc-landing/rts/dist/build/libffi.so.6
#9  0x00007fffeee460d6 in interpretBCO (cap=0x7fffef08ba40 <MainCapability>) at rts/Interpreter.c:1697
#10 0x00007fffeee3f3e2 in schedule (initialCapability=<optimized out>, task=task@entry=0x754e90) at rts/Schedule.c:471
#11 0x00007fffeee404fc in scheduleWorker (cap=<optimized out>, task=0x754e90) at rts/Schedule.c:2574
#12 0x00007fffee1bf494 in start_thread (arg=0x7fffe77fe700) at pthread_create.c:333
#13 0x00007fffed76faff in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:97
Mon, Jun 19, 9:38 AM
bgamari updated the diff for D3619: Allow bytecode interpreter to make unsafe foreign calls.

Address some of comments

Mon, Jun 19, 9:38 AM
bgamari committed rGHC83a6dd82a883: Don't expose fingerprints from Type.Reflection (authored by dfeuer).
Don't expose fingerprints from Type.Reflection
Mon, Jun 19, 8:31 AM
bgamari committed rGHC7941f2f7c26f: Typofix in Data.Type.Equality comments (authored by RyanGlScott).
Typofix in Data.Type.Equality comments
Mon, Jun 19, 8:31 AM
bgamari committed rGHCe4925dab854c: Add fixity declaration for :~~: (authored by RyanGlScott).
Add fixity declaration for :~~:
Mon, Jun 19, 8:31 AM
bgamari committed rGHCc89ef44bbf8c: Make GHCi work when RebindableSyntax is enabled (authored by RyanGlScott).
Make GHCi work when RebindableSyntax is enabled
Mon, Jun 19, 8:31 AM
bgamari committed rGHC1ab05dac3c42: Bump Cabal submodule to 2.0.0.1 (authored by bgamari).
Bump Cabal submodule to 2.0.0.1
Mon, Jun 19, 8:31 AM
bgamari accepted D3641: change filtering of variables in extract_hs_tv_bndrs (fixes #13782).

Alright, I think this looks reasonable.

Mon, Jun 19, 8:23 AM
bgamari created D3660: base: Export Fingerprint accessors from Type.Reflection.Unsafe.
Mon, Jun 19, 8:11 AM
bgamari abandoned D3653: rts: Ensure that new capability count is > 0.

Merged with b9f9670c8cf4eac8798a8cb3e683d0411f9e94ec.

Mon, Jun 19, 8:11 AM
bgamari added a comment to D3659: Fix Note "What AbsBinds means".

I also wonder whether it would be good to move this below (or perhaps even merge this into) Note [AbsBinds] (also in this module).

Mon, Jun 19, 7:19 AM
bgamari committed rGHC6a2264d2bd47: cmm/CmmLayoutStack: avoid generating unnecessary reloads (authored by michalt).
cmm/CmmLayoutStack: avoid generating unnecessary reloads
Mon, Jun 19, 7:18 AM
bgamari committed rGHCa9b62a3e883e: configure: Look for objdump on OpenBSD and AIX (authored by bgamari).
configure: Look for objdump on OpenBSD and AIX
Mon, Jun 19, 7:17 AM
bgamari closed D3586: cmm/CmmLayoutStack: avoid generating unnecessary reloads by committing rGHC6a2264d2bd47: cmm/CmmLayoutStack: avoid generating unnecessary reloads (authored by michalt).
Mon, Jun 19, 7:17 AM
bgamari closed D3638: configure: Look for objdump on OpenBSD and AIX by committing rGHCa9b62a3e883e: configure: Look for objdump on OpenBSD and AIX.
Mon, Jun 19, 7:17 AM
bgamari committed rGHC271e0f087b65: Add test cases for #13821 (authored by Douglas Wilson <douglas.wilson@gmail.com>).
Add test cases for #13821
Mon, Jun 19, 7:17 AM
bgamari closed D3642: Add test cases for #13821 by committing rGHC271e0f087b65: Add test cases for #13821 (authored by Douglas Wilson <douglas.wilson@gmail.com>).
Mon, Jun 19, 7:17 AM
bgamari committed rGHC990928ff463e: Don't expose fingerprints from Type.Reflection (authored by dfeuer).
Don't expose fingerprints from Type.Reflection
Mon, Jun 19, 7:17 AM
bgamari committed rGHCbea18a0e9ea5: Fix GCC 7 warning in the RTS (authored by Sylvain Henry <hsyl20@gmail.com>).
Fix GCC 7 warning in the RTS
Mon, Jun 19, 7:17 AM
bgamari closed D3643: Don't expose fingerprints from Type.Reflection by committing rGHC990928ff463e: Don't expose fingerprints from Type.Reflection (authored by dfeuer).
Mon, Jun 19, 7:17 AM
bgamari closed D3648: Fix GCC 7 warning in the RTS by committing rGHCbea18a0e9ea5: Fix GCC 7 warning in the RTS (authored by Sylvain Henry <hsyl20@gmail.com>).
Mon, Jun 19, 7:17 AM
bgamari committed rGHCee9232524bdb: Add fixity declaration for :~~: (authored by RyanGlScott).
Add fixity declaration for :~~:
Mon, Jun 19, 7:17 AM
bgamari committed rGHC23f47b15bd45: Add T9630 (authored by dfeuer).
Add T9630
Mon, Jun 19, 7:17 AM
bgamari committed rGHC04ca0360a6b3: testsuite: Add testcase for #13822 (authored by bgamari).
testsuite: Add testcase for #13822
Mon, Jun 19, 7:17 AM
bgamari closed D3656: Add T9630 by committing rGHC23f47b15bd45: Add T9630 (authored by dfeuer).
Mon, Jun 19, 7:17 AM
bgamari closed D3657: Add fixity declaration for :~~: by committing rGHCee9232524bdb: Add fixity declaration for :~~: (authored by RyanGlScott).
Mon, Jun 19, 7:17 AM
bgamari committed rGHCe12ea39ee508: rts: A bit of cleanup around the eventlog (authored by bgamari).
rts: A bit of cleanup around the eventlog
Mon, Jun 19, 7:17 AM
bgamari closed D3655: testsuite: Add testcase for #13822 by committing rGHC04ca0360a6b3: testsuite: Add testcase for #13822.
Mon, Jun 19, 7:17 AM
bgamari committed rGHCb9f9670c8cf4: rts: Ensure that new capability count is > 0 (authored by bgamari).
rts: Ensure that new capability count is > 0
Mon, Jun 19, 7:17 AM

Sun, Jun 18

bgamari accepted D3657: Add fixity declaration for :~~:.

Good catch!

Sun, Jun 18, 3:44 PM

Sat, Jun 17

bgamari added inline comments to D3523: Big-obj support for the Windows runtime linker.
Sat, Jun 17, 12:42 PM
bgamari added a comment to D3523: Big-obj support for the Windows runtime linker.

This looks great. However, can I ask you for a short note listing the various image formats that we support and when we expect to find them (perhaps with references to tickets as appropriate)?

Sat, Jun 17, 11:11 AM
bgamari added a comment to D3638: configure: Look for objdump on OpenBSD and AIX.

@hvr, any objection here?

Sat, Jun 17, 10:25 AM
bgamari abandoned D3654: rts: Ensure that all EventsBufs are flushed.

It turns out that I was wrong; @duog points out that the issue which I describe in the ticket actually isn't an issue.

Sat, Jun 17, 8:44 AM

Fri, Jun 16

bgamari updated the diff for D3654: rts: Ensure that all EventsBufs are flushed.

Fix it

Fri, Jun 16, 7:56 PM
bgamari committed rGHC15af7156087d: Fix the treatment of 'closed' definitions (authored by simonpj).
Fix the treatment of 'closed' definitions
Fri, Jun 16, 5:53 PM
bgamari committed rGHC96706799d6cd: GHC.Stats cleanup (authored by RyanGlScott).
GHC.Stats cleanup
Fri, Jun 16, 5:53 PM