avd (Alex Dzyoba)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
May 15 2016, 1:19 PM (57 w, 5 d)
Availability
Available

Recent Activity

Aug 3 2016

avd added a comment to D2426: codeGen: Remove binutils<2.17 hack, fixes T11758.

@austin @bgamari maybe it's time to land this diff?

Aug 3 2016, 3:27 PM

Jul 26 2016

avd added a reviewer for D2426: codeGen: Remove binutils<2.17 hack, fixes T11758: rwbarton.

Reid, can you please take a look at this diff regarding T12433?

Jul 26 2016, 1:09 AM
avd retitled D2426: codeGen: Remove binutils<2.17 hack, fixes T11758 from to codeGen: Remove binutils<2.17 hack, fixes T11758.
Jul 26 2016, 1:06 AM

May 20 2016

avd added a comment to D2226: Testsuite: add CmmSwitchTest for 32-bit platforms.

@austin Is it ready to land?

May 20 2016, 9:33 AM
avd updated the diff for D2226: Testsuite: add CmmSwitchTest for 32-bit platforms.

Add "@generated" to the generated tests to please arcanist

May 20 2016, 5:11 AM

May 19 2016

avd updated the diff for D2226: Testsuite: add CmmSwitchTest for 32-bit platforms.

Rebased commits to cleanup history (squashed and reworded)

May 19 2016, 5:02 AM
avd added a comment to D2226: Testsuite: add CmmSwitchTest for 32-bit platforms.

If Iā€™m reading Phabricator correclty, your latest iteration lost the updated test case code

May 19 2016, 3:50 AM
avd added a comment to D2226: Testsuite: add CmmSwitchTest for 32-bit platforms.

@nomeata @bgamari I also wanted to rebase my commits to reorder and squash them. Is there any special arcanist workflow or should I just arc diff --update D2226 <branch root>?

May 19 2016, 2:04 AM
avd updated the diff for D2226: Testsuite: add CmmSwitchTest for 32-bit platforms.

Require -32/-64 option for CmmSwitchTestGen

May 19 2016, 1:47 AM

May 18 2016

avd updated the diff for D2226: Testsuite: add CmmSwitchTest for 32-bit platforms.

Update CmmSwitchTestGen to generate 32/64 bit versions

May 18 2016, 1:31 PM

May 17 2016

avd added a comment to D2226: Testsuite: add CmmSwitchTest for 32-bit platforms.

I didn't know that and made it by hand :-(

CmmSwitchTestGen.hs writes out a warning about that; but it looks like the committed version of the test case was produced before that warning was added ā€“ sorry.

Neither should be done. CmmSwitchTestGen.hs successfully generates 32-bit version, because it relies on minBound/maxBound for min/max values. In 32-bit environments it generates correct values.

It could be using fromIntegral (maxBound :: Word64) resp. fromIntegral (maxBound :: Word32) depending on an option. It would be good if the generator could generate both test cases independent of the host architecture, so when one wants to add more checks, anyone can generate them.

May 17 2016, 4:43 AM

May 16 2016

avd added a comment to D2226: Testsuite: add CmmSwitchTest for 32-bit platforms.
In D2226#64370, @thomie wrote:

Either CmmSwitchTestGen.hs should get deleted, or it should get updated to also generate CmmSwitchTest32 somehow.

May 16 2016, 11:43 AM
avd retitled D2226: Testsuite: add CmmSwitchTest for 32-bit platforms from to Testsuite: add CmmSwitchTest for 32-bit platforms.
May 16 2016, 7:11 AM